D29534: Implement scroll and drag adjustment of values for SpinBox control

[Andres Betts]

abetts added a comment.


  +1 from me!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D29070: add alligator icon

[Andres Betts]

abetts added a comment.


  Look great!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29070

To: mbruchert, tfella, #vdg, ndavis
Cc: abetts, ognarb, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Andres Betts]

abetts added a comment.


  My opinion on this patch from the beginning has been that it really doesn't 
add much more than was there before. Visually, it clutters the UI. The icon 
selected for it might also not be visually appealing or meaningful enough. I 
believe there should be a different approach to this request. However, I am 
also open to just dropping the idea completely.
  
  Some ideas for better UX on this:
  
  1. Hover over the "Defaults" button and the UI shows highlighted controls and 
labels that have changed. If you want to return things to default, click the 
button.
  2. Color controls and labels differently once they have changed to a 
non-default state. From Breeze Blue to a lighter blue, for example. (This could 
be confusing to some users)
  3. Keyboard shortcut. Use a keyboard shortcut to return settings back to 
their default state. Control + Z comes to mind.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: abetts, bam, GB_2, alexde, ndavis, iasensio, davidre, kde-frameworks-devel, 
LeGast00n, cblack, michaelh, ngraham, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Andres Betts]

abetts added a comment.


  +1 on visuals!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: abetts, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21511: Make falkon icon a real SVG

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

BRANCH
  falkon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21511

To: ndavis, #vdg, #falkon, abetts, drosca
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21315: Dolphin-style view modes in the file dialog

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20977

To: filipf, #vdg, ngraham, #frameworks, broulik, davidedmundson
Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

[Andres Betts]

abetts added a comment.


  +1

REVISION DETAIL
  https://phabricator.kde.org/D20181

To: JJRcop, broulik, #plasma, ngraham
Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D20672: Add an icon for Thunderbolt KCM

[Andres Betts]

abetts added a comment.


  Sorry for coming this late into the conversation. I was wondering if the 
spear in the bolt can be changed to be horizontal? It would be more visually 
consistent with the angle that the lightning bold is. The back of the arrow |>, 
that needs to be horizontal.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20672

To: yurchor, #vdg, ndavis, ngraham
Cc: abetts, ndavis, GB_2, filipf, ngraham, kde-frameworks-devel, michaelh, bruns

D20342: Update KDE logo to be closer to original

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

BRANCH
  update-kde-logo-to-be-closer-to-original (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20342

To: GB_2, #vdg, #kde_promo, filipf
Cc: abetts, ndavis, filipf, ngraham, #kde_promo, kde-frameworks-devel, #vdg, 
michaelh, bruns

D20367: Add alternatives icon

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20367

To: GB_2, #vdg
Cc: abetts, ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Andres Betts]

abetts added a comment.


  In D20226#442854 , @GB_2 wrote:
  
  > Move bell's pendulum
  
  
  Love it!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Andres Betts]

abetts added a comment.


  The line that goes across almost completely removes the bell's pendulum to 
the right. Maybe move the pendulum closer to the center so that even when there 
is that red strike line, the user can still make out that it is a notification 
bell

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D19646: Redesign KDE Connect and bluetooth config pages

[Andres Betts]

abetts added a comment.


  Could there be a checkmark box or some way to indicate what selection has 
been made?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D19646

To: nicolasfella, #vdg, apol, ngraham
Cc: abetts, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D19557: Update css

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation
Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, 
michaelh, ngraham, bruns, skadinna

D19020: [breeze-icons] Revamp system.svgz

[Andres Betts]

abetts added a comment.


  Well, maybe it is time to call it and be done. I don't think we are going to 
please everyone right now. Maybe our best option is to have you, as the 
proponent of this idea, make the decision after long debate.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Andres Betts]

abetts added a comment.


  I think the icon is pretty much there. Maybe the label can help the meaning 
come across. What about:
  
  "Enter User"
  "Type User"
  "Change User"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19047: [GridDelegate] Fix long labels blending into each other

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D19047

To: filipf, #frameworks, ngraham, #vdg
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Andres Betts]

abetts added a comment.


  In D19020#412431 , @ngraham wrote:
  
  > The only problem here that is that the label says "Type User" but the icon 
depicts a password field. Maybe the icon could depict both a username field and 
a password field, one on top of the other. Then I bet it would be tall enough 
that we wouldn't feel the need to put it inside a circle.
  
  
  Is the objective that the user sees the icon first and then understands what 
is to be done? If that's the case, the idea of image correctness would be 
relevant. If however, you want to only convey an idea of typing, then I would 
say this is enough. Which of the two assumptions is the one we are going for?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Andres Betts]

abetts added a comment.


  In D19020#412418 , @rooty wrote:
  
  > In D19020#412412 , @abetts wrote:
  >
  > > Would an icon like this work?
  > >
  > > F6615590: Group 3.png 
  > >
  > > Just trying to get to a good final icon for typing your user.
  >
  >
  > hey i like that, kai made fun of my version, but using both dots //and// an 
i beam could work
  
  
  Give it a shot. As for Kai, Kai is Kai... hehe.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Andres Betts]

abetts added a comment.


  Would an icon like this work?
  
  F6615590: Group 3.png 
  
  Just trying to get to a good final icon for typing your user.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405368 , @ngraham wrote:
  
  > One thing I will not do in this patch is synthesize a fake button that has 
different behaviors from the standard button. If there's a problem with our 
buttons we need to fix it everywhere, not work around it here (and elsewhere).
  >
  > Here are our two options:
  >
  > F6588077: Inline dark buttons.gif 
  >
  > F6588078: Slightly escaping light buttons.gif 

  >
  > Maybe we should just take a vote.
  
  
  Both are very compelling, I must say! I like version 1 better.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: rizzitello, ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18738: Add ebook thumbnailer

[Andres Betts]

abetts added a comment.


  +1
  
  Awesome!

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18738

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405214 , @ngraham wrote:
  
  > I want to point out that the original problem was not that the buttons 
lacked contrast, but that the //icons// were illegible with a variety of 
thumbnail contents. This problem is 100% solved by using a real button with 
background that uses the system color scheme in some capacity (theme-following 
or inverted). Whether the button backgrounds should be theme-following or 
inverted is an aesthetic judgment, not a usability one.
  
  
  Exactly. My argument is to support the direction for usability purposes and 
add an aesthetic element that helps contrast. I think others in the discussion 
want to stop at the usability fix, I want to push that a little more and add 
the aesthetic element.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405209 , @GB_2 wrote:
  
  > In D18649#405200 , @ngraham 
wrote:
  >
  > > Here's how the buttons look when placed fully inline and with the color 
scheme inverted:
  > >
  > > F6587345: Screenshot_20190204_130444.png 

  > >
  > > I have to admit, it ain't half bad.
  >
  >
  > I still think it looks better if it follows the color scheme.
  
  
  Why do you think that? Context?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405200 , @ngraham wrote:
  
  > Here's how the buttons look when placed fully inline and with the color 
scheme inverted:
  >
  > F6587345: Screenshot_20190204_130444.png 

  >
  > I have to admit, it ain't half bad.
  
  
  Thank you for trying it out Nate. I appreciate your willingness to take turns 
in our thinking.
  
  I agree, it doesn't look bad. If it was placed the way you proposed, at the 
top right, or bottom right, a little over the image frame, it would stand out 
even more. Either way works for me.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405180 , @ngraham wrote:
  
  > In D18649#405179 , @abetts wrote:
  >
  > > I was thinking of dark buttons mostly. Something along these lines\
  > >
  > > https://dribbble.com/shots/5204192-Buttons-Dark
  > >
  > > I think the breeze default color is just too close to white, the contrast 
with regular buttons is pretty low IMHO.
  >
  >
  >
  >
  > 1. If there's a problem with Breeze colors, we should fix it there rather 
than working around this in downstream software
  
  
  I disagree on this point. I feel the problem we experience is the belief that 
breeze colors should be slapped on every element on the desktop. There is 
nothing wrong with Breeze colors, but we should allow for variations within 
without thinking that Breeze needs to change. I am suggesting that we can make 
these buttons show more contrast by "not" using the main gray breeze color as 
the background for them. Instead we use something a little more subtle and that 
can help our line-art icons stand out. You proposed a really good idea of 
floating buttons but we have bumped into the same problem we did before, that 
the contrast of these buttons is not great.
  
  > 2. If anything I think the gray color used for our button backgrounds is 
too dark, not too light. Right now it's the exact same color as the window 
background. Most other color schemes make buttons a bit lighter, and I think 
that looks better in general
  > 3. The only elements that use a dark background with the Breeze light theme 
are tooltips; making only these buttons dark would be inconsistent with every 
other button in every other piece of KDE software
  
  And to the user, what does this mean? I think it means something to us, but 
not necessarily them. I don't see users saying, "OMG, this button is dark, not 
light, that color belongs in tooltips... KDE is so inconsistent..." To me, what 
works here is practicality. By trying to align the concepts to the rest of the 
desktop environment, we are limiting ourselves from providing good contrast and 
practical functionality.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405162 , @GB_2 wrote:
  
  > I think it looks good.
  
  
  I was thinking of dark buttons mostly. Something along these lines\
  
  https://dribbble.com/shots/5204192-Buttons-Dark
  
  I think the breeze default color is just too close to white, the contrast 
with regular buttons is pretty low IMHO.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405156 , @ngraham wrote:
  
  > Use square buttons and put them on the bottom right, not the top right
  
  
  The functionality seems great! We might need to do more padding with labels. 
Is there any way we can style the buttons in different ways? Colors, shades, 
etc? I don't mind the square but doesn't look very good when it uses regular 
breeze colors.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  Just some variations on Nate's idea:
  
  https://dribbble.com/shots/4981650-Floating-Button-Micro-Interaction
  
  https://dribbble.com/shots/2619684-Expense-Floating-Button
  
  The floating buttons is a very Android-unique feature. Not sure we are 
copying that if we utilize something similar. But I think it is very effective. 
It keeps the action buttons where the actions are happening. This also reminds 
me of the way that the mobile version of pinterest works.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405082 , @ngraham wrote:
  
  > In D18649#405081 , @abetts wrote:
  >
  > > In D18649#405078 , @ngraham 
wrote:
  > >
  > > > Use round buttons in the corner rather than an inline toolbar
  > >
  > >
  > > What does it look like now?
  >
  >
  > Test Plan section updates with new screenshots. :)
  
  
  That looks very interesting. Very Android in the way that the buttons are 
laid out. I like them. I think it is a good direction. It may be a bit rough, I 
will propose some examples along this idea.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#405078 , @ngraham wrote:
  
  > Use round buttons in the corner rather than an inline toolbar
  
  
  What does it look like now?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18675: Use different "None" item icon in grid view KCMs

[Andres Betts]

abetts added a comment.


  > Seems like a bit too much. BTW, this is the Plasma login splash and there 
is no text output when disabled.
  
  I see, maybe the label could be more descriptive then? Use something like 
"Black", or "No splash"?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

[Andres Betts]

abetts added a comment.


  In D18675#404090 , @ngraham wrote:
  
  > Hmm, I like the use of an X here, but I'm not sure the red color is 
appropriate. Nothing is being removed, deleted, or destroyed.
  
  
  I agree with you here. It may seem that you are selecting something 
different. What about a stop sign and behind it a representation of the splash 
screen. So as to signal that you are not wanting a splash screen. The concept 
is great though! Many people care little for the splash screen and prefer to 
see the booting output.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18686: Add Cursors KCM icon

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18686

To: ndavis, #vdg
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[Andres Betts]

abetts added a comment.


  In D18533#403337 , @ndavis wrote:
  
  > F6581666: Screenshot_20190201_131014.png 

  >
  > The colors are not very good, but this is what I was talking about. It 
looks more 3D.
  
  
  I would only add to this to lighten up the colors closer to yellow so that it 
retains the brightness that the flat icon had. You can achieve a 3D effect with 
brighter yellows. Orange tends to darken images.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  In D18649#403336 , @ngraham wrote:
  
  > In D18649#40 , @abetts wrote:
  >
  > > I love that implementation. I bounced back ideas with Marco long ago 
about this. I think we should implement it in all other KCMs with similar 
representations.
  >
  >
  > Yep, if this patch lands, then it will apply to all of them automatically. 
The screenshots are just depictions of how it happens to look with the Colors 
KCM.
  
  
  Looks great Nate, thanks!

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Andres Betts]

abetts added a comment.


  I love that implementation. I bounced back ideas with Marco long ago about 
this. I think we should implement it in all other KCMs with similar 
representations.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D17905: [frameworks] Do not use light font styles for headings (1/3)

[Andres Betts]

abetts added a comment.


  I don't have a problem with the font as much as I have a problem with the 
spacing for the title labels. They seem to be super close to checkboxes, other 
labels and controls. There should be a clear separation. Adding a heavier font 
to the title label helps a lot but because of its weight and the closeness with 
the rest of the elements, it seems crammed.
  
  Here are some good spacing examples for title labels
  
  https://dribbble.com/shots/5774759-Photo-Album-Application
  
  https://dribbble.com/shots/5779939-Qwick-Platform-Sneak-Peek
  
  https://dribbble.com/shots/5774973-Chris-Jon-Podcast
  
  And some good typographical advise
  
  
https://medium.com/@lukejones/3-typography-tips-for-a-more-comfortable-read-fed478affa8d

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17905

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Andres Betts]

abetts added a comment.


  Goodness, I think this is all about taste. I am more on the side that it 
looks good. It visually prioritizes hierarchy with labels. @mart Does it just 
look bad for you or do you think this will cause issues somewhere else?

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: abetts, mart, plasma-devel, dkardarakos, apol, davidedmundson, hein

D17609: KTextEditor: Add action for static word wrap

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17609

To: loh.tar, #ktexteditor, #vdg
Cc: abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

[Andres Betts]

abetts added a comment.


  +1 for improving visuals

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17461

To: ngraham, #vdg, #frameworks, cullmann, cfeck
Cc: abetts, apol, cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, 
bruns

D17496: Change network/web color icons to consistent style

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17496

To: ndavis, #vdg
Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17469: applications-games icon for dark theme

[Andres Betts]

abetts added a comment.


  It's looking good. I would say change the last tone to a tad lighter. The 
gray has too much black in it. I would probably move the hue to the yellow side.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: guoyunhe, #breeze, #vdg, ndavis
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17459: SearchBar: Add Cancel button to stop long running tasks

[Andres Betts]

abetts added a comment.


  I would probably not make the button that big, but I think it is useful

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg
Cc: abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17350: Add the missing api for multilevel KCMs to control the columns

[Andres Betts]

abetts added a comment.


  Instead of connection name, would it make sense to call it, network name 
instead?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D17350

To: mart, #plasma, jgrulich
Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17309

To: trickyricky26, #vdg
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

[Andres Betts]

abetts added a comment.


  In D17220#368147 , @trickyricky26 
wrote:
  
  > I think the distinction is useful. The off icons would then look like this:
  >  F6446567: microphone-sensitivity-high-22.svg.png 

  >
  > F6446566: audio-volume-high-22.svg.png 

  >  Should this style then also be applied to other "off" status icons like 
touchpad and camera?
  >
  > Also, I've experimented with a circle with one line through it, as that 
represents muted better than an X which looks too much like an error:
  >  F6446578: audio-volume-muted-alt-22.svg.png 

  
  
  These look really good. My only warning to the team is that we don't add too 
many elements to the icon that will make it expand in area. We should strive to 
keeping size constraints so that we don't introduce too many elements into the 
icon that will make it be confusing visually.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

[Andres Betts]

abetts added a comment.


  Looks good to me +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16951

To: ndavis, #vdg
Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

D16653: Use the new `drive-harddisk-root` icon for the root volume

[Andres Betts]

abetts accepted this revision.
abetts added a comment.


  Minor detail with great impact. Thank you for the work.

REPOSITORY
  R245 Solid

BRANCH
  arcpatch-D16653

REVISION DETAIL
  https://phabricator.kde.org/D16653

To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns, abetts
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, 
michaelh, ngraham, bruns

D16395: Update the "About KDE" text

[Andres Betts]

abetts added a comment.


  > KDE has created the friendly and powerful Plasma desktop environment
  
  KDE has created the most friendly and powerful desktop environment, Plasma.
  
  > KDE is a cooperative enterprise in which no single entity
  
  KDE is a disaggregated development community not governed by...
  
  Just my .02 :D

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15973: Add a 'Properties' entry in the places panel context menu

[Andres Betts]

abetts retitled this revision from "Add a 'Propreties' entry in the places 
panel context menu" to "Add a 'Properties' entry in the places panel context 
menu".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham, dfaure
Cc: dfaure, elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15935: Don't show an emblem for mounted disks, only unmounted disks

[Andres Betts]

abetts accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  no-mounted-emblem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15935

To: ngraham, #vdg, abetts
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15821: fix pop up positioning for !compositing mode

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15821

To: mvourlakos, #plasma, broulik, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

[Andres Betts]

abetts added a comment.


  In D15814#85 , @mvourlakos 
wrote:
  
  > In D15814#10 , @ngraham 
wrote:
  >
  > > A big improvement! Even better would be a little downward-pointing 
triangle pointing to the thing that spawned it. Here's a visual example from 
macOS with a vertical Dock: F6291932: macOS.png 

  >
  >
  > I am not sure.
  >  Latte is trying to be as much plasma as possible and a "downward-pointing 
triangle" isnt shown any where else in plasma.
  >  So that would make Latte to look a bit out of place in Plasma.
  >  I think for now a small improvement would be enough.
  
  
  Our HIGs don't prevent it. It is also a different element than a popup or 
sliding notification.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15814: show all borders for pop up windows in a dock

[Andres Betts]

abetts added a comment.


  I like both ideas so far. Great improvement! Would it be too hard to create 
the pointer triangle? I think it make so much sense. That way the poppup 
doesn't feel like it is floating out of nowhere.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma
Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D11880: Add firewall-config and firewall-applet icons

[Andres Betts]

abetts added a comment.


  Love it! Ship it! +100

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D15739: [Places panel] Don't show Root by default

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg
Cc: abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15721: Make lock on plasmavault icon visible with breeze-dark

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15721

To: ndavis, #vdg
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

[Andres Betts]

abetts added a comment.


  I solemnly approve! +1

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Andres Betts]

abetts added a comment.


  Seems good to me. Guys?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: bruns, abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh

D11880: Add firewall-config and firewall-applet icons

[Andres Betts]

abetts added a comment.


  If I understand right, there are three states of firewall security that you 
can be in. Maybe we could use the traffic lights metaphor and have green for 
low, yellow for medium and red for high?

REPOSITORY
  R266 Breeze Icons

BRANCH
  firewalld-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11880

To: ndavis, #vdg, #breeze, ngraham
Cc: abetts, alex-l, svenmauch, kde-frameworks-devel, ngraham, michaelh, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Andres Betts]

abetts added a comment.


  In D15194#328651 , @romangg wrote:
  
  > If there are more items than space available in the list a line is drawn 
already now to indicate that there are more items to come by scrolling down. 
Does this not conflict with the new line?
  
  
  Screenshot?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: romangg, abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15591: Add Open Document thumbnailer

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15591

To: broulik, #frameworks, #vdg, ngraham, kossebau, jtamate, fvogt, wbauer
Cc: abetts, kde-frameworks-devel, kfm-devel, leinir, kossebau, jtamate, 
ngraham, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
bruns, emmanuelp

D15557: Improve "insufficient disk space" error messgae

[Andres Betts]

abetts added a comment.


  In D15557#327094 , @ngraham wrote:
  
  > We can't use the words "file" or "move" since this part of the code can't 
know whether the user is moving or copying, or whether the thing being moved or 
copied is a file or a directory. Adjusting the code here to know those pieces 
of information not easily possible and would involve patches to multiple other 
repos--and it's also out of scope for this patch. :)
  
  
  Not married to any string. I think the patch is already improving it, just 
showing some perspective. I guess my main angle is to communicate the 
information as soon as the sentence starts. Something like "Not enough" or 
"Unable to" right off the bat so it can have a more immediate understanding 
from the user. ;)

REPOSITORY
  R241 KIO

BRANCH
  improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15557: Improve "insufficient disk space" error messgae

[Andres Betts]

abetts added a comment.


  I like the proposal already. I would just add other strings for perspective:
  
  - Cannot move file. File larger than remaining space.
  - Unable to move file, insufficient space remaining.

REPOSITORY
  R241 KIO

BRANCH
  improve-insufficient-disk-space-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15557

To: ngraham, #frameworks, #vdg, #dolphin, shubham
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15071: Don't draw frames and shadows around images with transparency

[Andres Betts]

abetts accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  thumbnail-frame-refinement (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15071

To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck, abetts
Cc: anthonyfieroni, markg, abetts, bruns, kde-frameworks-devel, michaelh, 
ngraham

D15240: Create a default wallet when user refuses to do so

[Andres Betts]

abetts added a comment.


  In D15240#319850 , @ngraham wrote:
  
  > This strikes me as likely to cause intense frustration. Consider the 
following dramatized dialogue between a user and the computer:
  >
  > User: "Neat, I just set up this KDE plasma thing. Let's start seeing what 
cool stuff it can do!"
  >  Computer: "Hey hey hey first what kind of KWallet do you want to create? 
Technical jargon thingy 1, or technical jargon thingy 2? Huh? Huh? What'll it 
be O noble user!?"
  >  User: "Okay, I have no idea, let me cancel out of this stupid thing..."
  >  Computer: "Don't worry I created a thing anyway and chose technical jargon 
thingy 1 for you!"
  >
  > Speaking personally, this sort of experience would make me want to put my 
fist through the screen.
  >
  > It might be worth stepping back and asking more higher-level questions like:
  >  "Why are users cancelling the wizard? Is it too technically intimidating?"
  >  "Should we even have a wizard at all? Maybe should we create a wallet 
automatically by default and let advanced users change its settings or delete 
it if they don't like it?"
  
  
  I can see this argument as very valuable. I have also been a little startled 
by setting this up when you first start using Plasma or create your first 
password. I have not seen this in other systems. I know also we care for 
security and transparency. Maybe we should reconsider the wizard and use a more 
automated approach. Thoughts?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15240

To: McPain, #frameworks, ngraham
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

[Andres Betts]

abetts added a comment.


  In D14580#317289 , @mart wrote:
  
  > F6223394: Spectacle.k3.png 
  >
  > in case the kcm wants to go multi columns (default off):
  >  F6223399: Spectacle.l3.png 
  >  that secon page with the giant pop button is just a placeholder for testing
  
  
  Very cool! Thanks for the pics Marco!

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D14580

To: mart, #plasma, #frameworks
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

[Andres Betts]

abetts added a comment.


  What does this look like now Marco?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D14580

To: mart, #plasma, #frameworks
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

[Andres Betts]

abetts added a comment.


  Thanks for the work Marco!

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D15099

To: mart, #plasma, #frameworks
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15071: Don't draw frames and shadows around images with an alpha channel

[Andres Betts]

abetts added a comment.


  I support this 100%

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15071

To: ngraham, #frameworks, #dolphin, #vdg, broulik, cfeck
Cc: abetts, bruns, kde-frameworks-devel, michaelh, ngraham

D14810: Improve Widgets' removal and configure text

[Andres Betts]

abetts accepted this revision.
abetts added a comment.
This revision is now accepted and ready to land.


  This patch is sensible, it saves some strings, space, and it is grammatically 
consistent.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-this-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14810

To: ngraham, #plasma, #vdg, abetts
Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14810: Improve Widgets' removal and configure text

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14810

To: ngraham, #plasma, #vdg
Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14579: api for multi level kcms

[Andres Betts]

abetts added a comment.


  Awesome!

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D14579

To: mart, #plasma, #frameworks
Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Andres Betts]

abetts added a comment.


  In D14640#304428 , @ngraham wrote:
  
  > In D14640#304405 , @abetts wrote:
  >
  > > In D14640#304400 , @ngraham 
wrote:
  > >
  > > > Hmm, I'm not sure a cancel button makes sense here because that would 
end the process of creating the folder. If you chose an invalid name, 
presumably you still want to create the folder.
  > >
  > >
  > > I am mostly trying to think of unintended actions upon unintended 
actions. Thinking maybe that a less knowledgeable user just took the wrong path 
in trying to complete an action.
  >
  >
  > Now that I think about it, you're right. I'll submit a patch for that once 
my current crop of patches are accepted and landed. Wanna accept this one?
  
  
  Yes, no problem! Thanks for taking my suggestion.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg
Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Andres Betts]

abetts accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  rename-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg, abetts
Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Andres Betts]

abetts added a comment.


  In D14640#304400 , @ngraham wrote:
  
  > Hmm, I'm not sure a cancel button makes sense here because that would end 
the process of creating the folder. If you chose an invalid name, presumably 
you still want to create the folder.
  
  
  I am mostly trying to think of unintended actions upon unintended actions. 
Thinking maybe that a less knowledgeable user just took the wrong path in 
trying to complete an action.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg
Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14640: Use appropriate icon for a cancel button that will ask for a new name

[Andres Betts]

abetts added a comment.


  Could the message have 2 buttons? A cancel and an "Enter a different name". 
That way, if the user inadvertently entered that reserved name can cancel the 
action still.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14640

To: ngraham, #frameworks, #vdg
Cc: abetts, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for multi-column views

[Andres Betts]

abetts accepted this revision.
abetts added a comment.
This revision is now accepted and ready to land.


  Looks good!

REPOSITORY
  R241 KIO

BRANCH
  alternating-row-colors-for-list-style-views (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13773

To: ngraham, #frameworks, #vdg, #dolphin, abetts
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for list-style views

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13773

To: ngraham, #frameworks, #vdg, #dolphin
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13643: Add LabPlot project file icon

[Andres Betts]

abetts added a comment.


  Oh great! I thought the team was looking for a logo. Then, I have nothing 
more to add. It looks great.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13643: Add LabPlot project file icon

[Andres Betts]

abetts added a comment.


  My first impression is that it looks a lot like a file emblem. I would 
probably remove the background and keep only the logo.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D13643

To: mtrescott, #labplot, #vdg, #breeze
Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D13552: [Properties dialog] Improve some permissions-related strings

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13552

To: ngraham, #frameworks, #vdg, #dolphin
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

[Andres Betts]

abetts added a comment.


  What can we do to help this patch move forward @zzag ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D13215: Update sizes before generating frame svg background

[Andres Betts]

abetts added a comment.


  +1 on this! Love it!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13215

To: zzag, #plasma, #frameworks
Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D12992: New elisa icon

[Andres Betts]

abetts added a comment.


  I think we are trying hard to accommodate and the elements are not lending 
themselves to turn them into an E with some musical tones. I reviewed a few 
music sheets looking for commonalities. I feel also that the icon is busy, it 
is trying really hard to tell you that this app is about music. I feel we can 
simplify and provide other ideas.
  
  Here is a proposal. Not final. I welcome feedback. The idea here is to show 
soundwaves instead.
  
  F5872565: Elisa Long Form.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: abetts, paullesur, januz, astippich, mgallien, alex-l, andreask, 
kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, 
michaelh, ngraham, bruns, kmf

D12992: New elisa icon

[Andres Betts]

abetts added a subscriber: andreask.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: andreask, kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, 
mykolak, jussiv, michaelh, ognarb, januz, ngraham, bruns, kmf, mgallien

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

[Andres Betts]

abetts added a comment.


  In D12986#265687 , @rkflx wrote:
  
  > In my personal experience spending more time on a limited set of items 
leads to better results and less churn (as in reverting commits, number of 
iterations per patch etc.) than only lightly touching a large amount of issues 
everywhere. Of course you can do whatever you feel is right, I was merely 
hinting at a potential issue (in particular with mass-changing UI everywhere).
  
  
  Thanks for your clarification. Let's keep moving forward. What should be the 
end result of this patch?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12986

To: ngraham, #dolphin, #frameworks, #vdg
Cc: abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

[Andres Betts]

abetts added a comment.


  In D12986#265675 , @rkflx wrote:
  
  > In D12986#265666 , @ngraham 
wrote:
  >
  > > In D12986#265662 , @rkflx 
wrote:
  > >
  > > > Anyway, I'm not complaining too much (but please be aware that every 
change you propose creates additional work for reviewers and translators).
  > >
  > >
  > > I'm quite aware, but this is just the nature of submitting patches, 
right? Nobody's making you review mine, and I hope you don't feel like it's 
your responsibility to babysit me to prevent things from getting broken or 
anything like that. :)
  >
  >
  > Well, I'd say you should use the resources available (which are quite 
scarce, as you are aware) wisely. I'd rather have the translators translate 
strings in Gwenview (there are many missing spots where we added things for 
18.04) and work on my review backlog. Also note that fighting an uphill battle, 
i.e. more stuff getting broken than you are able to fix by yourself, is not 
much fun.
  
  
  It's the unfortunate life of working in development. Changes are going to 
happen and others will have to make adjustments accordingly. There is nothing 
inherently wrong with that. If the argument is, "don't change things because 
they cause too much work for others" then we have to determine if we are a 
software provider that wants to keep the first iteration of their software and 
not hear customers, or if we want to hear customers and change our approach 
overtime, and evolve. I prefer the latter, no matter how many headaches I get. 
Let's take that approach and welcome change. Let's be sensible but not 
inflexible. I am sure there is a middle point for all of this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12986

To: ngraham, #dolphin, #frameworks, #vdg
Cc: abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

[Andres Betts]

abetts added a comment.


  In D12986#265552 , @ngraham wrote:
  
  > Like this?
  >
  > F5860366: Radiobutton version.png 
  
  
  That looks really good IMHO. Somewhat unrelated, I have seen a few UIs 
recently that ask the user to automatically empty their trash bin, can, 
container, whatever... every X amount of TIME UNIT. Would it make sense to add 
a feature like that in this KCM?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12986

To: ngraham, #dolphin, #frameworks, #vdg
Cc: abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

[Andres Betts]

abetts added a comment.


  In D12986#265235 , @rkflx wrote:
  
  > In D12986#265231 , @ngraham 
wrote:
  >
  > > Yeah, that makes sense. Suggestions welcome, of course. Is this any 
better?
  > >  F5859259: After 2.png 
  >
  >
  > Hm, I think after the checkbox there should some sort of sentence, with a 
noun in front:
  >
  >   Cleanup: [ ] Automatically empty after 7 days
  >   
  >
  >  ---
  >
  > In D12986#265232 , @abetts wrote:
  >
  > > Warn me - when limit is reached
  >
  >
  > Putting the combobox in front would violate the HIG, wouldn't it?
  >
  > @ngraham Please change your language to both Greek and German, and notice 
the width of the label as well as the width of the combobox. Your current 
proposal will blow up the width of the dialog massively, and create a huge 
amount of whitespace on the left as well.
  >
  > Perhaps you need something like this:
  >
  >   Noun: Explanations are good
  > Combobox
  >   
  >
  > Alternatively:
  >
  >   Noun: ( ) Option 1
  > ( ) Option 2
  > ( ) Option 3
  
  
  Much better!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12986

To: ngraham, #dolphin, #frameworks, #vdg
Cc: abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

[Andres Betts]

abetts added a comment.


  In D12986#265231 , @ngraham wrote:
  
  > Yeah, that makes sense. Suggestions welcome, of course. Is this any better?
  >  F5859259: After 2.png 
  >
  > Still not super happy with "When limit reached:
  
  
  Would it make sense to flip it? Start with:
  
  Warn me - when limit is reached
  
  Seems more natural to me

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12986

To: ngraham, #dolphin, #frameworks, #vdg
Cc: abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

[Andres Betts]

abetts added a comment.


  In D12986#265198 , @rkflx wrote:
  
  > I don't think putting whole phrases as a label before the checkbox works 
very well, and I would be surprised if that's what the HIG now recommends. I 
assume at most a single subject should be used there?
  >
  > For example, instead of the awkwardly placed checkbox in
  >
  >   Limit to maximum size: [ ] 10 %
  >
  > …it would work much better this way:
  >
  >   Size: [ ] Limit to 10 %
  >
  > Not only is scanning the dialog much quicker if you only have to read a 
single word when looking for an option in that vertical row, but for languages 
with longer translations it's the only way to make the dialog not fall apart in 
the horizontal direction.
  >
  > (Same reasoning applies to the other options too, of course.)
  
  
  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12986

To: ngraham, #dolphin, #frameworks, #vdg
Cc: abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D12895: WIP: Add KFileItemActionsPlugin

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12895

To: broulik, #plasma, #vdg, apol
Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D10937: Retouching of Screen Layout Selection OSD Icons

[Andres Betts]

abetts added a comment.


  In D10937#260688 , @pstefan wrote:
  
  > In D10937#260289 , @abetts wrote:
  >
  > > In D10937#260277 , @ngraham 
wrote:
  > >
  > > > Someone will need to land the changes for you. I'd prefer a few more 
thumbs up first. @abetts, are you good with these?
  > >
  > >
  > > I am linking these a lot. I am "almost" there with the designs. I would 
just ask that the center image of the sample window be simplified. I think it 
has a lot of detail. Maybe we can tone it down by removing some elements and 
making the window look more simple.
  >
  >
  > Could you give me more examples of what you'd remove?  As in direction.
  
  
  I would remove the user image and the text representation. Make the window 
title bar bigger. Just leave it blank.
  
  > 
  > 
  >> Icons 5-6 have a representation that is meant to be a second screen, or a 
projector screen? Can you tell me what it is meant to represent?
  > 
  > It's supposed to be a projector screen. I took the original icon metaphor 
to be a projector screen, so I continued with that.
  
  For the projector idea, I am a bit split, because my experience tells me that 
in most cases people are just adding another monitor and not a projector, 
except when they are presenting in front of an audience. Adding an extra 
monitor is a more common situation than a presentation IMHO. Therefore, I 
wonder if you could provide an alternative design where you have a screen 
representation instead of a projector? Just to see the contrast.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D10937: Retouching of Screen Layout Selection OSD Icons

[Andres Betts]

abetts added a comment.


  In D10937#260277 , @ngraham wrote:
  
  > Someone will need to land the changes for you. I'd prefer a few more thumbs 
up first. @abetts, are you good with these?
  
  
  I am linking these a lot. I am "almost" there with the designs. I would just 
ask that the center image of the sample window be simplified. I think it has a 
lot of detail. Maybe we can tone it down by removing some elements and making 
the window look more simple.
  
  Icons 5-6 have a representation that is meant to be a second screen, or a 
projector screen? Can you tell me what it is meant to represent?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender

D12508: Make KMessageWidget match Kirigami inlineMessage's style

[Andres Betts]

abetts added a comment.


  +1 on this!

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  arcpatch-D12508

REVISION DETAIL
  https://phabricator.kde.org/D12508

To: ngraham, hein, #plasma, #vdg, cfeck
Cc: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, 
#frameworks, michaelh, ngraham, bruns