Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> This entire "restore position" mumbojumbo only makes sense if the > > associated widget can change, in which case this will break the positioning. > > > > => only store on minimizing and see what happens. > > Anthony Fieroni wrote: > Bu

Re: Review Request 127240: [Applet] Don't crash on remove panel

-framework Description --- Stop timer is any case, if you don't want *this* to be nullptr Diffs (updated) - src/plasma/private/applet_p.cpp 38d486a Diff: https://git.reviewboard.kde.org/r/127240/diff/ Testing --- Still not tested, but look good for me. Thanks, Anthony

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 3, 2016, 10:57 след обяд, Anthony Fieroni wrote: > > Ping > > Martin Klapetek wrote: > Does not work for Quassel and Konversation, I'd like to know why before I > approve your patch. > > Martin Klapetek wrote: > Ah, interestingly I've never

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review93128 --- Ping - Anthony Fieroni On Фев. 29, 2016, 7:18 преди обяд

Review Request 127240: [Applet] Don't crash on remove panel

/ Testing --- Still not tested, but look good for me. Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127197: [kcm_colors] Port away from KDELibs4Support

/02/27/a23bfdad-7465-422e-9cef-25fe7991e795__Screenshot_20160227_102609.png Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

/diff/ Testing --- Tested on pixel ration = 1 Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127204: [KHintSettings] Disable setting the palette on-the-fly

/platformtheme/khintssettings.cpp 8adf6c5 Diff: https://git.reviewboard.kde.org/r/127204/diff/ Testing --- 1. Open Dolphin, Kate any other KDE/Qt5 app 2. kcmshell5 colors 3. Look at Xorg ram usage 3. Apply new colors 4. Look again Xorg ram - it's pro rata on opened apps Thanks, Anthony Fieroni

Review Request 127197: [kcm_colors] Port away from KDELibs4Support

/02/27/a23bfdad-7465-422e-9cef-25fe7991e795__Screenshot_20160227_102609.png Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127122: [Kate] Back/Forward mouse buttons

back/forward in kxmlgui. It looks wrong, but will be usefull for all KDE apps. Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

is refreshed as is, pointer hasn't same lifetime as panel + Animation is disabled if compositing is not active Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

> On Ян. 25, 2016, 10 преди обяд, Martin Gräßlin wrote: > > src/declarativeimports/core/tooltip.cpp, line 160 > > <https://git.reviewboard.kde.org/r/126870/diff/2/?file=436482#file436482line160> > > > > why bind it to compositingActive? > > Anthon

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

roblems automatically. > > > > Of course that comment is orthogonal to this review request: improvement is > > always good. > > Anthony Fieroni wrote: > Someone with KWin knowledge is needed here, i'm not so familiar with it > or post link to example It has special code to

Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

is not active Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

ated pointer, so let *refresh* the pointer :) - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126870/#review91521 -----------

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

viewboard.kde.org/r/126870/#review91521 --- On Ян. 24, 2016, 4:08 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

lifetime as panel + Animation is disabled if compositing is not active Thanks, Anthony Fieroni ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

performance after suspend/restore? > > > > Other than the KWindowSystem change I don't see what this is going to > > alter. You're removing a QPropertyAnimation when it's unused, which won't > > make a difference as it'll be unused anyway. > > Anthony Fieroni wrote: >

<    2   3   4   5   6   7