D13951: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R265:6657decb1d4b: Honor BUILD_TESTING (authored by arojas). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13951?vs=37317=37400 REVISION DETAIL https://phabricator.kde.org/D13951 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns
D13950: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R273:50c20f8c7d46: Honor BUILD_TESTING (authored by arojas). REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13950?vs=37316=37399 REVISION DETAIL https://phabricator.kde.org/D13950 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns
D13945: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R283:b08104d00a44: Honor BUILD_TESTING (authored by arojas). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13945?vs=37311=37398 REVISION DETAIL https://phabricator.kde.org/D13945 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13949: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R284:b15446a2288d: Honor BUILD_TESTING (authored by arojas). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13949?vs=37315=37397 REVISION DETAIL https://phabricator.kde.org/D13949 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns
D13946: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R270:b6c89b7e7b08: Honor BUILD_TESTING (authored by arojas). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13946?vs=37312=37395 REVISION DETAIL https://phabricator.kde.org/D13946 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns
D13943: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R243:6c2b95f4c3be: Honor BUILD_TESTING (authored by arojas). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13943?vs=37309=37394 REVISION DETAIL https://phabricator.kde.org/D13943 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13941: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R244:bb56c91ede0f: Honor BUILD_TESTING (authored by arojas). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13941?vs=37307=37393 REVISION DETAIL https://phabricator.kde.org/D13941 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: elvisangelaccio, asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns
D13993: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R316:a4cb54ea637a: Honor BUILD_TESTING (authored by arojas). REPOSITORY R316 KMediaPlayer CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13993?vs=37373=37392 REVISION DETAIL https://phabricator.kde.org/D13993 AFFECTED FILES CMakeLists.txt To: arojas, alexmerry, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13977: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R279:d9404a942334: Honor BUILD_TESTING (authored by arojas). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13977?vs=37351=37391 REVISION DETAIL https://phabricator.kde.org/D13977 AFFECTED FILES CMakeLists.txt To: arojas, mirko, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13980: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R6:569b588a5ede: Honor BUILD_TESTING (authored by arojas). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13980?vs=37354=37389 REVISION DETAIL https://phabricator.kde.org/D13980 AFFECTED FILES CMakeLists.txt To: arojas, ivan Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13985: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R216:b3cc8b84714d: Honor BUILD_TESTING (authored by arojas). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13985?vs=37364=37381 REVISION DETAIL https://phabricator.kde.org/D13985 AFFECTED FILES CMakeLists.txt To: arojas, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13947: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R237:00646c782459: Honor BUILD_TESTING (authored by arojas). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13947?vs=37313=37380 REVISION DETAIL https://phabricator.kde.org/D13947 AFFECTED FILES CMakeLists.txt To: arojas, mdawson, dfaure Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns
D13987: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R252:5ec96d346322: Honor BUILD_TESTING (authored by arojas). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13987?vs=37367=37379 REVISION DETAIL https://phabricator.kde.org/D13987 AFFECTED FILES CMakeLists.txt To: arojas, afiestas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13989: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R307:1599ed797389: Honor BUILD_TESTING (authored by arojas). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13989?vs=37369=37377 REVISION DETAIL https://phabricator.kde.org/D13989 AFFECTED FILES CMakeLists.txt To: arojas, apol, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13991: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R312:6239b73d5fa8: Honor BUILD_TESTING (authored by arojas). REPOSITORY R312 KXmlRpcClient CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13991?vs=37371=37376 REVISION DETAIL https://phabricator.kde.org/D13991 AFFECTED FILES CMakeLists.txt To: arojas, dvratil, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13992: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R495:f03e2db94959: Honor BUILD_TESTING (authored by arojas). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13992?vs=37372=37375 REVISION DETAIL https://phabricator.kde.org/D13992 AFFECTED FILES CMakeLists.txt To: arojas, apol, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13986: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R301:e7f4466de3b5: Honor BUILD_TESTING (authored by arojas). REPOSITORY R301 KEmoticons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13986?vs=37366=37374 REVISION DETAIL https://phabricator.kde.org/D13986 AFFECTED FILES CMakeLists.txt To: arojas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13993: Honor BUILD_TESTING
arojas created this revision. arojas added reviewers: alexmerry, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R316 KMediaPlayer REVISION DETAIL https://phabricator.kde.org/D13993 AFFECTED FILES CMakeLists.txt To: arojas, alexmerry, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13992: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13992 AFFECTED FILES CMakeLists.txt To: arojas, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13991: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dvratil. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R312 KXmlRpcClient REVISION DETAIL https://phabricator.kde.org/D13991 AFFECTED FILES CMakeLists.txt To: arojas, dvratil Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13990: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only builds tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D13990 AFFECTED FILES CMakeLists.txt To: arojas, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13989: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D13989 AFFECTED FILES CMakeLists.txt To: arojas, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13987: Honor BUILD_TESTING
arojas created this revision. arojas added reviewers: afiestas, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D13987 AFFECTED FILES CMakeLists.txt To: arojas, afiestas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13986: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R301 KEmoticons REVISION DETAIL https://phabricator.kde.org/D13986 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13985: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13985 AFFECTED FILES CMakeLists.txt To: arojas, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13983: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R314 KJs REVISION DETAIL https://phabricator.kde.org/D13983 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13982: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13982 AFFECTED FILES CMakeLists.txt To: arojas, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13972: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R290:1fec80d89989: Honor BUILD_TESTING (authored by arojas). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13972?vs=37346=37358 REVISION DETAIL https://phabricator.kde.org/D13972 AFFECTED FILES CMakeLists.txt To: arojas, mart, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13974: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R277:4eadd9ee0ef1: Honor BUILD_TESTING (authored by arojas). REPOSITORY R277 KPlotting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13974?vs=37348=37357 REVISION DETAIL https://phabricator.kde.org/D13974 AFFECTED FILES CMakeLists.txt To: arojas, cfeck, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13980: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: ivan. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D13980 AFFECTED FILES CMakeLists.txt To: arojas, ivan Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13977: Honor BUILD_TESTING
arojas created this revision. arojas added reviewers: mirko, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests and benchmarks if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R279 ThreadWeaver REVISION DETAIL https://phabricator.kde.org/D13977 AFFECTED FILES CMakeLists.txt To: arojas, mirko, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13976: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D13976 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13975: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R291 KPty REVISION DETAIL https://phabricator.kde.org/D13975 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13974: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R277 KPlotting REVISION DETAIL https://phabricator.kde.org/D13974 AFFECTED FILES CMakeLists.txt To: arojas, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13973: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on. Also remove unnecesary if() that check for packages which are always required. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D13973 AFFECTED FILES CMakeLists.txt To: arojas, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13973: Honor BUILD_TESTING
arojas edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D13973 To: arojas, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13972: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D13972 AFFECTED FILES CMakeLists.txt To: arojas, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13948: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R236:00175c834fb8: Honor BUILD_TESTING (authored by arojas). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13948?vs=37314=37341 REVISION DETAIL https://phabricator.kde.org/D13948 AFFECTED FILES CMakeLists.txt To: arojas, cfeck Cc: asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns
D13941: Honor BUILD_TESTING
arojas added a comment. There's more stuff being built inside tests and autotests besides ecm_add_tests REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13941 To: arojas, dfaure Cc: elvisangelaccio, asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns
D13965: Honor BUILD_TESTING
arojas created this revision. arojas added reviewers: valir, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D13965 AFFECTED FILES CMakeLists.txt To: arojas, valir, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13964: Honor BUILD_TESTING
arojas created this revision. arojas added reviewers: mck182, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D13964 AFFECTED FILES CMakeLists.txt To: arojas, mck182, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13963: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D13963 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13962: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13962 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13958: Honor BUILD_TESTING
This revision was automatically updated to reflect the committed changes. Closed by commit R310:347d932b9a49: Honor BUILD_TESTING (authored by arojas). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13958?vs=37325=37328 REVISION DETAIL https://phabricator.kde.org/D13958 AFFECTED FILES CMakeLists.txt To: arojas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13960: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D13960 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13959: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D13959 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13958: Honor BUILD_TESTING
arojas created this revision. arojas added reviewers: dfaure, mlaurent. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D13958 AFFECTED FILES CMakeLists.txt To: arojas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13957: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D13957 AFFECTED FILES CMakeLists.txt To: arojas, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13956: Honor BUILD_TESTING
arojas created this revision. arojas added reviewers: davidedmundson, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D13956 AFFECTED FILES CMakeLists.txt To: arojas, davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13955: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13955 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13954: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D13954 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13953: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D13953 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13952: Honor BUILD_TESTING
arojas updated this revision to Diff 37319. REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13952?vs=37318=37319 REVISION DETAIL https://phabricator.kde.org/D13952 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13952: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D13952 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13951: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D13951 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13950: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D13950 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13949: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D13949 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13948: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13948 AFFECTED FILES CMakeLists.txt To: arojas, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13947: Honor BUILD_TESTING
arojas created this revision. arojas added reviewers: mdawson, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D13947 AFFECTED FILES CMakeLists.txt To: arojas, mdawson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13946: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D13946 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13945: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests ib BUILD_TESTING is on TEST PLAN Builds REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D13945 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13944: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: ltoscano. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D13944 AFFECTED FILES CMakeLists.txt To: arojas, ltoscano Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna
D13943: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13943 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13941: Honor BUILD_TESTING
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Only build tests if BUILD_TESTING is on TEST PLAN Builds REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13941 AFFECTED FILES CMakeLists.txt To: arojas, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D12216: Don't need to run previous iterations commands again
arojas added a comment. Works for me, thanks REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12216 To: apol, #frameworks, arojas Cc: michaelh, ngraham, bruns
D11055: Pack python bindings into right dirs
arojas added a comment. The sip part is distro-specific. At least in Arch we don't have separate sip/sip3 directories (what's the point? sip files are independent of the python version) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D11055 To: McPain, vkrause Cc: arojas, apol, #frameworks, #build_system, michaelh
D9099: Update comment for new Qt API
This revision was automatically updated to reflect the committed changes. Closed by commit R275:8b5b30d90253: Update comment for new Qt 5.10 API (authored by arojas). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9099?vs=23252=23253 REVISION DETAIL https://phabricator.kde.org/D9099 AFFECTED FILES src/krecursivefilterproxymodel.h To: arojas, dfaure Cc: #frameworks
D9099: Update comment for new Qt API
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY recursiveFiltering has been renamed to recursiveFilteringEnabled in 5.10-rc2 https://github.com/qt/qtbase/commit/275c748ada9d869d803d5f446b48b915d686ab33 REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D9099 AFFECTED FILES src/krecursivefilterproxymodel.h To: arojas, dfaure Cc: #frameworks
D7677: Fix python bindings compilation after 7af93dd23873d0b9cdbac192949e7e5114940aa6
This revision was automatically updated to reflect the committed changes. Closed by commit R240:8b4033f16c2a: Fix python bindings compilation after 7af93dd23873d0b9cdbac192949e7e5114940aa6 (authored by arojas). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7677?vs=19139=19145 REVISION DETAIL https://phabricator.kde.org/D7677 AFFECTED FILES find-modules/FindPythonModuleGeneration.cmake To: arojas, dfaure, skelly Cc: #frameworks, #build_system
D7677: Fix python bindings compilation after 7af93dd23873d0b9cdbac192949e7e5114940aa6
arojas created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Explicitely set LIBRARY_OUTPUT_DIRECTORY for the python module TEST PLAN kcoreaddons python bindings are correctly built and installed REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7677 AFFECTED FILES find-modules/FindPythonModuleGeneration.cmake To: arojas, dfaure, skelly Cc: #frameworks, #build_system
D6665: Make kssl compile against OpenSSL 1.1.0
arojas added a comment. In https://phabricator.kde.org/D6665#141883, @aacid wrote: > So archlinux is using https://git.archlinux.org/svntogit/packages.git/tree/trunk/kdelibs4support-openssl-1.1.patch?h=packages/kdelibs4support > > @arojas why did you guys not try to contribute that? > > No idea if it can be used to at least compare your version with theirs to see how "good" it is. Because it's not our patch, we took it from OpenMandriva, which is the only one I could find at the time. One important difference is that OM's patch makes kdelibs4support link to openssl, unlike the current code (and this patch). REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D6665 To: dvratil, #frameworks, dfaure Cc: aacid, arojas, fvogt, ltoscano, rdieter, #frameworks
Re: Review Request 129280: Fix editing autostart items
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/ --- (Updated Oct. 31, 2016, 8:37 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit af0105c22ec80e411bf226e77f40987464e478d3 by Antonio Rojas to branch master. Bugs: 371194 https://bugs.kde.org/show_bug.cgi?id=371194 Repository: kio Description --- QFileInfo.canonicalFilePath() returns an empty string for non-existant directories, which matches any .desktop file path and makes KPropertiesDialog try to save it to the wrong location. Make sure that the dir exists before trying to match it in the .desktop file path. Diffs - src/widgets/kpropertiesdialog.cpp b570a85 Diff: https://git.reviewboard.kde.org/r/129280/diff/ Testing --- Autostart items can be edited and saved again from the systemsettings autostart KCM. Thanks, Antonio Rojas
Re: Review Request 129280: Fix editing autostart items
> On Oct. 30, 2016, 10:20 a.m., David Faure wrote: > > src/widgets/kpropertiesdialog.cpp, line 1242 > > <https://git.reviewboard.kde.org/r/129280/diff/1/?file=483165#file483165line1242> > > > > But this returns the *parent* of base, right? > > > > I guess what we need here is rather QDir(base).canonicalPath(). Do you > > agree? Can you try that? Ah yes. Actually I was wrong about canonicalFilePath, it works fine for directories. The problem was that it returns an empty string for non-existant dirs, which is usually the case for /usr/local/share/applications - Antonio --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/#review100390 ------- On Oct. 30, 2016, 10:36 p.m., Antonio Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129280/ > --- > > (Updated Oct. 30, 2016, 10:36 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 371194 > https://bugs.kde.org/show_bug.cgi?id=371194 > > > Repository: kio > > > Description > --- > > QFileInfo.canonicalFilePath() returns an empty string for non-existant > directories, which matches any .desktop file path and makes KPropertiesDialog > try to save it to the wrong location. Make sure that the dir exists before > trying to match it in the .desktop file path. > > > Diffs > - > > src/widgets/kpropertiesdialog.cpp b570a85 > > Diff: https://git.reviewboard.kde.org/r/129280/diff/ > > > Testing > --- > > Autostart items can be edited and saved again from the systemsettings > autostart KCM. > > > Thanks, > > Antonio Rojas > >
Re: Review Request 129280: Fix editing autostart items
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/ --- (Updated Oct. 30, 2016, 10:36 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Check that the dir exists before tying to match it to the path of the .desktop file being edited Bugs: 371194 https://bugs.kde.org/show_bug.cgi?id=371194 Repository: kio Description (updated) --- QFileInfo.canonicalFilePath() returns an empty string for non-existant directories, which matches any .desktop file path and makes KPropertiesDialog try to save it to the wrong location. Make sure that the dir exists before trying to match it in the .desktop file path. Diffs (updated) - src/widgets/kpropertiesdialog.cpp b570a85 Diff: https://git.reviewboard.kde.org/r/129280/diff/ Testing --- Autostart items can be edited and saved again from the systemsettings autostart KCM. Thanks, Antonio Rojas
Review Request 129280: Fix editing autostart items
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/ --- Review request for KDE Frameworks and David Faure. Bugs: 371194 https://bugs.kde.org/show_bug.cgi?id=371194 Repository: kio Description --- QFileInfo.canonicalFilePath() returns an empty string for directories, QFileInfo.canonicalPath() should be used instead. Diffs - src/widgets/kpropertiesdialog.cpp b570a85 Diff: https://git.reviewboard.kde.org/r/129280/diff/ Testing --- Autostart items can be edited and saved again from the systemsettings autostart KCM. Thanks, Antonio Rojas
Re: Review Request 128882: Fix launching terminal .desktop files with konsole
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128882/ --- (Updated Sept. 10, 2016, 10:16 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit c784a879eaba0babc6274bc32e761772add3d4f8 by Antonio Rojas to branch master. Repository: kio Description --- Launching .desktop files which have Terminal=true currently fails, because kio adds to the konsole command the obsolete KDE4 command line options, which are not recognized by the KF5 konsole. Diffs - src/core/desktopexecparser.cpp c526da7 Diff: https://git.reviewboard.kde.org/r/128882/diff/ Testing --- .desktop files with Terminal=true can be launched again from the Plasma menu and with kioclient5 exec. Thanks, Antonio Rojas
Re: Review Request 128882: Fix launching terminal .desktop files with konsole
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128882/ --- (Updated Sept. 10, 2016, 7:15 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Leave %i alone, --icon still works in qt5 Repository: kio Description --- Launching .desktop files which have Terminal=true currently fails, because kio adds to the konsole command the obsolete KDE4 command line options, which are not recognized by the KF5 konsole. Diffs (updated) - src/core/desktopexecparser.cpp c526da7 Diff: https://git.reviewboard.kde.org/r/128882/diff/ Testing --- .desktop files with Terminal=true can be launched again from the Plasma menu and with kioclient5 exec. Thanks, Antonio Rojas
Review Request 128882: Fix launching terminal .desktop files with konsole
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128882/ --- Review request for KDE Frameworks and David Faure. Repository: kio Description --- Launching .desktop files which have Terminal=true currently fails, because kio adds to the konsole command the obsolete KDE4 command line options, which are not recognized by the KF5 konsole. Diffs - src/core/desktopexecparser.cpp c526da7 Diff: https://git.reviewboard.kde.org/r/128882/diff/ Testing --- .desktop files with Terminal=true can be launched again from the Plasma menu and with kioclient5 exec. Thanks, Antonio Rojas
Re: QIcon::fromTheme() does not load scalable icons
Olivier Churlaud wrote: > > Can you point me to the right place where to open the bug? > Already fixed in http://commits.kde.org/kiconthemes/0abf1b7a148cf6b27caea01a329631e0f1daa983 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128427: Make sure ECMGeneratePriFile.cmake behaves like the rest of ECM
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128427/#review97303 --- Works here, thanks - Antonio Rojas On Jul. 12, 2016, 12:21 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128427/ > --- > > (Updated Jul. 12, 2016, 12:21 a.m.) > > > Review request for Extra Cmake Modules, KDE Frameworks and Antonio Rojas. > > > Repository: extra-cmake-modules > > > Description > --- > > In `KDEInstallDirs` we have some code to make sure that qmake is asked when > the project shares the prefix with the installed Qt, to make sure that if > something was changed in the distribution it would reflect on the projects. > Make sure PRI files are installed using the same reasoning. > > > Diffs > - > > modules/ECMGeneratePriFile.cmake af4b877 > > Diff: https://git.reviewboard.kde.org/r/128427/diff/ > > > Testing > --- > > The issue was reported by `arojas`, I haven't been able to reproduce myself. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Qt 5.6/QtWebkit (got it, now to build it)
René J. V. Bertin wrote: > I presume there must be at least one member on this list who managed to > build QtWebKit 5.6.0 (and remembers how)? See https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/qt5-webkit Besides generating headers with syncqt.pl, you need to backport a patch to fix linking to pthread ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
