D24665: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-15 Thread Ben Cooksley
bcooksley added a comment. As part of the transition to Gitlab, Sysadmin removed the staging repositories which a few Phabricator repositories had been configured to use. That error can be ignored. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24665 To: koss

Re: KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 114 - Failure!

2019-09-19 Thread Ben Cooksley
On Thu, Sep 19, 2019 at 11:48 AM Aleix Pol wrote: > > On Wed, Sep 18, 2019 at 12:25 AM David Faure wrote: > > > > On mardi 17 septembre 2019 23:53:00 CEST Aleix Pol wrote: > > > We'll need a libaccounts release I guess, master wouldn't have this > > > problem. > > > I created an issue upstream:

[sysadmin/repo-metadata] projects: Move KCalCore and KContacts to Frameworks from PIM.

2019-09-18 Thread Ben Cooksley
Git commit 482a0a57f218943ec155646f2952a1a054601956 by Ben Cooksley. Committed on 18/09/2019 at 13:18. Pushed by bcooksley into branch 'master'. Move KCalCore and KContacts to Frameworks from PIM. As part of this move, KCalCore will also be renaming to KCalendarCore. As agreed with

Re: [IMPORTANT] Binary Factory & CI System Maintenance

2019-09-17 Thread Ben Cooksley
make adding support to the Binary Factory straight forward and efficient in terms of resource utilisation. Existing work on Appimages has tended to be application specific and therefore not suitable for easy reuse (which Craft would solve) Cheers, Ben > > On Mon, Sep 16, 2019 at 3:47 PM Be

[IMPORTANT] Binary Factory & CI System Maintenance

2019-09-16 Thread Ben Cooksley
that require the services of the Binary Factory & CI system it would be appreciated if you could please let me know so I can take that into account for scheduling the various changes. Thanks, Ben Cooksley KDE Sysadmin

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-29 Thread Ben Cooksley
bcooksley removed a subscriber: fsitter. REPOSITORY R320 KIO Extras BRANCH fixSFTP (branched from master) REVISION DETAIL https://phabricator.kde.org/D23207 To: feverfew, chinmoyr, fvogt, sitter, dfaure Cc: bcooksley, kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe

D23381: Allow splitting lists using ;

2019-08-29 Thread Ben Cooksley
bcooksley removed a subscriber: fsitter. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D23381 To: apol, #frameworks Cc: bcooksley, dfaure, kossebau, sitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns, fsitter

D23262: disable autouic again - it breaks builds

2019-08-29 Thread Ben Cooksley
bcooksley removed a subscriber: fusitter. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23262 To: sitter, apol, nicolasfella, cullmann Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns, fusitter

D23344: assert slave command finality

2019-08-29 Thread Ben Cooksley
bcooksley removed a subscriber: fsitter. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23344 To: sitter, dfaure Cc: bcooksley, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns, fsitter

D16395: Update the "About KDE" text

2019-08-29 Thread Ben Cooksley
bcooksley removed a subscriber: fusitter. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: bcooksley, valorie, davidc, xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-dev

D21795: [KAuth] Add support for action details in Polkit1 backend.

2019-08-29 Thread Ben Cooksley
bcooksley removed a subscriber: fsitter. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter Cc: bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns, fs

[sysadmin/ci-tooling] craftmaster: Include SnoreToast in the Windows CI system.

2019-08-12 Thread Ben Cooksley
Git commit 4015e2bbba5a2eb2719f0979848dc86d28c67a31 by Ben Cooksley. Committed on 12/08/2019 at 19:09. Pushed by bcooksley into branch 'master'. Include SnoreToast in the Windows CI system. This should repair KNotifications builds on Windows and restore the maintainability of the CI

Re: KCrash - test_crasher spins in a loop on Windows

2019-07-23 Thread Ben Cooksley
On Wed, Jul 24, 2019 at 2:27 AM David Faure wrote: > > On mercredi 17 avril 2019 08:52:23 CEST Ben Cooksley wrote: > > On Sat, 13 Apr 2019, 07:35 Ben Cooksley, wrote: > > > Hi all, > > > > > > Currently we have an issue where the test_crasher test will endl

D22419: Fix cant enter directory error on Android FTP servers

2019-07-16 Thread Ben Cooksley
bcooksley changed the visibility from "All Users" to "Public (No Login Required)". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22419 To: nxiss7, #frameworks Cc: svuorela, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22257: performance, Qt API

2019-07-04 Thread Ben Cooksley
bcooksley added a comment. This change fails to build from source once committed. https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/35/changes#detail0 Please correct this urgently - at this very moment the CI system is proceeding through it's initial build r

D14467: Auth Support: Drop privileges if target is not owned by root

2019-06-22 Thread Ben Cooksley
bcooksley added a comment. Thanks REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14467 To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek Cc: bcooksley, maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, br

D14467: Auth Support: Drop privileges if target is not owned by root

2019-06-22 Thread Ben Cooksley
bcooksley added a comment. It would appear that the commit of this change disturbed somethng with FreeBSD builds - see https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/135/ Could someone take a look into that please? REPOSITORY R241 KIO REVISION D

D21660: change audio dep logic wrt win32

2019-06-18 Thread Ben Cooksley
bcooksley added a comment. With regards to Windows, please note that any unit test which depends on calls that involve D-Bus on the CI system will likely lead to that test hanging because dbus-daemon is not launched by the CI system. Where possible D-Bus should be avoided on Windows. REPOS

D21313: Create specific directory for Qt logging categories file

2019-06-16 Thread Ben Cooksley
bcooksley added a comment. The Binary Factory uses the tooling shipped as part of the KDE SDK (which always builds everything from scratch, and I don't know if part of that includes ECM, hence why the issue doesn't show up there). The CI system on the other hand uses it's own tooling exc

D20967: [UserMetaData] Add method to query which attributes are set

2019-06-15 Thread Ben Cooksley
bcooksley added a comment. Please note that there are very few people involved with Windows builds (despite the number of projects that make use of them in general) so people may not always have the ability to respond to every review request. That is why the CI system monitors the state of

D21313: Create specific directory for Qt logging categories file

2019-06-15 Thread Ben Cooksley
bcooksley added a comment. This change appears to be responsible for all Android builds being broken. See https://build.kde.org/view/Failing/ Could someone take a look please? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfau

D20967: [UserMetaData] Add method to query which attributes are set

2019-06-15 Thread Ben Cooksley
bcooksley added a comment. This change has unfortunately made MSVC unhappy - https://build.kde.org/view/Failing/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/lastFailedBuild/ REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

2019-06-06 Thread Ben Cooksley
bcooksley added a comment. This change unfortunately does not compile on any platform tracked by the CI system. Please see https://build.kde.org/job/Frameworks/job/baloo/ This is something which needs correcting relatively urgently, as without it running any Dependency Build job is imp

D21581: Detect valgrind, avoid database removal when using valgrind

2019-06-04 Thread Ben Cooksley
bcooksley added a comment. This changes breaks the build on Windows/MSVC because 'valgrind.h' doesn't support MSVC. Can you please correct this / disable this check on Windows? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21581 To: bruns, #baloo, ngraham, astippi

D21381: use org.freedesktop.appstream-glib package to validate appstream data

2019-05-24 Thread Ben Cooksley
bcooksley added a comment. Aleix is correct, Flatpak commands are not possible within the CI environment (as Docker is heavily locked down, and the containerisation and other isolation measures that Flatpak tries to take are locked out as a consequence) Not to mention that Flatpak is Linux

D19455: [knotification] compile without deprecated methods

2019-04-29 Thread Ben Cooksley
bcooksley added a comment. I'm fine with either fix, any objection to that being committed directly? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19455 To: mlaurent, dfaure Cc: aacid, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

[craft-blueprints-kde] kde/frameworks/tier3/knotifications: Circumvent deprecated before breakage on macOS within KNotifications by removing that requirement until it can be fixed properly.

2019-04-28 Thread Ben Cooksley
Git commit aeaac2863f7383780197c667a6a961256af6b4f5 by Ben Cooksley. Committed on 28/04/2019 at 09:00. Pushed by bcooksley into branch 'master'. Circumvent deprecated before breakage on macOS within KNotifications by removing that requirement until it can be fixed properly. This is a C

D19455: [knotification] compile without deprecated methods

2019-04-28 Thread Ben Cooksley
bcooksley added a comment. This change has broken builds on macOS. Please see https://binary-factory.kde.org/view/MacOS/job/Kig_Nightly_macos/407/console Whilst not documented in the Qt Documentation, the `qmacfunctions.h` header (which is what is included by `#include `) has the foll

Re: MacOS Builds - KArchive & KDocTools

2019-04-24 Thread Ben Cooksley
On Thu, Apr 25, 2019 at 11:36 AM Luigi Toscano wrote: > > Ben Cooksley ha scritto: > > Hi all, > > > > While getting Mac builds back on their feet this morning we've run > > into a rather terminal build failure issue, centering around KArchive > > and KDoc

MacOS Builds - KArchive & KDocTools

2019-04-24 Thread Ben Cooksley
Hi all, While getting Mac builds back on their feet this morning we've run into a rather terminal build failure issue, centering around KArchive and KDocTools. The issue is struck during the build of KDocTools, when the linking of libKF5DocTools.dylib fails with the following message: Undefined

D20694: Use regular stat when resolving a symlink

2019-04-20 Thread Ben Cooksley
bcooksley added a comment. The Gitlab migration is in planning and preparation stages, so should happen sometime in the next couple of months. REPOSITORY R241 KIO BRANCH fix-test REVISION DETAIL https://phabricator.kde.org/D20694 To: meven, dfaure, #frameworks Cc: bcooksley, kde-fram

Re: KCrash - test_crasher spins in a loop on Windows

2019-04-16 Thread Ben Cooksley
On Sat, 13 Apr 2019, 07:35 Ben Cooksley, wrote: > Hi all, > > Currently we have an issue where the test_crasher test will endlessly > fork itself while trying to setup it's conditions to run. > > This leads to an issue where it will occupy a single CPU core of a > build

D20529: add license to python test files

2019-04-16 Thread Ben Cooksley
bcooksley added a comment. In D20529#451561 , @bruns wrote: > In D20529#451147 , @bcooksley wrote: > > > can we get the full command it's running? > > > `ctest -V -R externalextractortest`

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-16 Thread Ben Cooksley
bcooksley added a comment. MSVC doesn't like this change i'm afraid - see https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/259/console Looks like you're making use of C++17 features? REPOSITORY R241 KIO REVISION DETAIL https://phabricat

D20529: add license to python test files

2019-04-16 Thread Ben Cooksley
bcooksley added a comment. The Python installation on the CI nodes is most definitely complete (the CI Tooling itself used to perform the builds is written entirely in Python) I'd therefore suggest that something isn't entirely right with how Python is being executed by the tests here...

KCrash - test_crasher spins in a loop on Windows

2019-04-12 Thread Ben Cooksley
Hi all, Currently we have an issue where the test_crasher test will endlessly fork itself while trying to setup it's conditions to run. This leads to an issue where it will occupy a single CPU core of a builder indefinitely until it's killed (and when killed there are always two test_crasher.exe

Unannounced Dependency Change - plasma-framework

2019-04-12 Thread Ben Cooksley
Hi all, Recently builds of plasma-framework have started failing on Windows due to the absence of "gzip", which was added as a Dependency without any announcement as is required of all new dependencies. With regards to Windows in particular, usually Craft based systems will make use of 7-Zip inst

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

2019-04-11 Thread Ben Cooksley
bcooksley added a comment. @ngraham The people you will be finding will be those who hold developer accounts - because their information is available in kde-common/accounts, that information is also made accessible on Identity. The people you're trying to find will likely be non-developers

D20352: Skip running benchmarks when in debug mode.

2019-04-07 Thread Ben Cooksley
bcooksley accepted this revision. bcooksley added a comment. This revision is now accepted and ready to land. Thanks David, this looks good to me! REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20352 To: dfaure, bcooksley, mwolff Cc: kde-framewo

[sysadmin/ci-tooling] helpers: Port to non-deprecated PyYAML functions.

2019-04-07 Thread Ben Cooksley
Git commit 1f1b5806aca0bec73b33820fac0044bd7914fe18 by Ben Cooksley. Committed on 07/04/2019 at 09:40. Pushed by bcooksley into branch 'master'. Port to non-deprecated PyYAML functions. This should also correct the breakage which is currently causing all Frameworks Linux builds

D20046: Verify mimetypes for all existing sample files, add some more

2019-04-03 Thread Ben Cooksley
bcooksley added a comment. Can you please file a task on the #build.kde.org board so I can get this worked through with the FreeBSD folks? (It will likely require the package being updated in FreeBSD itself) REPOSITORY R286 KFileMetaData R

Re: CI system maintainability

2019-04-02 Thread Ben Cooksley
On Sat, Mar 30, 2019 at 10:46 PM Volker Krause wrote: > > On Friday, 29 March 2019 20:54:54 CET Ben Cooksley wrote: > > On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl > > > I fear that a mandatory reviews would add too juch strain on smaller > > > teams. If t

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Ben Cooksley
bcooksley added a comment. In D20096#440451 , @dfaure wrote: > In D20096#440440 , @bruns wrote: > > > 2. Tell the application where the slave library is located: `QT_PLUGIN_PATH=...` There **must** b

Re: CI system maintainability

2019-03-29 Thread Ben Cooksley
On Fri, Mar 29, 2019 at 9:56 PM Kevin Ottens wrote: > > Hello, > > On Thursday, 28 March 2019 20:35:11 CET Dr.-Ing. Christoph Cullmann wrote: > > I and others tried to get more reviews done in the past, but actually I > > merged more than once stuff that I reviewed but it did break the CI. > > Tha

Re: CI system maintainability

2019-03-29 Thread Ben Cooksley
On Fri, Mar 29, 2019 at 10:35 PM David Faure wrote: > > On jeudi 28 mars 2019 16:56:33 CET laurent Montel wrote: > > CI: sometime I look at it, sometime not, sometime some guys informs me that > > it's broken (I remember that Luca told me some days ago that a package > > didn't compile, so I fixed

Re: CI system maintainability

2019-03-29 Thread Ben Cooksley
On Fri, Mar 29, 2019 at 10:33 PM Friedrich W. H. Kossebau wrote: > > Am Donnerstag, 28. März 2019, 23:06:17 CET schrieb laurent Montel: > > Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit : > > > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > > > > Le jeu

Re: CI system maintainability

2019-03-29 Thread Ben Cooksley
On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl wrote: > > Hi, Hi, > > (Sorry for top-posting) > > I fear that a mandatory reviews would add too juch strain on smaller teams. > If there's just one person with an intimate knowledge of the code-base, plus > two co-developers, then who should

Re: CI system maintainability

2019-03-28 Thread Ben Cooksley
On Thu, Mar 28, 2019 at 7:56 PM Konstantin Kharlamov wrote: > > > > On Чт, Mar 28, 2019 at 19:40, Ben Cooksley wrote: > > Hi all, > > > > We currently have a rather substantial issue, in that the CI system > > has been once again left in a position where it is

CI system maintainability

2019-03-27 Thread Ben Cooksley
system vs. the amount of care actually being given by some developers (who are ignoring it's failure emails) it becomes questionable whether the effort is worth the return (and if not, we should just shut it down) Regards, Ben Cooksley KDE Sysadmin

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

2019-03-18 Thread Ben Cooksley
bcooksley added a comment. I see. If possible please do try to batch the commits together into a single push to avoid such breakages in the future. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg, ndavis Cc: bcooksley, ngraham, ndavis, kde-

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

2019-03-17 Thread Ben Cooksley
bcooksley added a comment. This change appears to have broken Windows builds (when using the QRC bundles anyway, which it seems regular Windows CI builds don't enable) See https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20kf5-qt5%20WindowsMSVCQt5.11/lastFailedBui

D19812: Add a web page to view and compare icons of different sizes

2019-03-16 Thread Ben Cooksley
bcooksley added a comment. I assume this fetches the icons from your local system? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

2019-03-01 Thread Ben Cooksley
bcooksley added a comment. Given that Baloo Widgets isn't the only project showing that class of failure, it's more likely to be a case of ECM getting something wrong. (The CI system doesn't do anything special when it comes to this part of the execution) REPOSITORY R824 Baloo Widgets R

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

2019-03-01 Thread Ben Cooksley
bcooksley added a comment. Sorry, I don't see where it's complaining about not finding the right binary? (Not finding Dr Konqi is expected, given that it's part of Plasma and not a dependency of baloo-widgets) REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D1

Fwd: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still Failing!

2019-03-01 Thread Ben Cooksley
Hi Laurent, Thanks for taking a look - unfortunately it looks like this is still failing? Cheers, Ben -- Forwarded message - From: CI System Date: Fri, Mar 1, 2019 at 11:05 AM Subject: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still Failing! To: ,

Re: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Failure!

2019-02-28 Thread Ben Cooksley
Hi Laurent, Please see below - your changes broke the build on Windows. Cheers, Ben On Fri, Mar 1, 2019 at 1:18 AM CI System wrote: > *BUILD FAILURE* > Build URL > https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.11/39/ > Project: kf5-qt5 WindowsMSVCQt5.11 > Date o

[sysadmin/ci-tooling] pipeline-templates: Make ABI Dump generation failure non-terminal as well until this is corrected for kded.

2019-02-27 Thread Ben Cooksley
Git commit c90b101d10091cfdb06920ca550fd8af123fe443 by Ben Cooksley. Committed on 28/02/2019 at 07:23. Pushed by bcooksley into branch 'master'. Make ABI Dump generation failure non-terminal as well until this is corrected for kded. CCMAIL: kde-frameworks-devel@kde.org M +1-1

[sysadmin/ci-tooling] pipeline-templates: Make ABI checks non-fatal again until the error hit by kded can be corrected.

2019-02-27 Thread Ben Cooksley
Git commit e46a05908d02ca253e8dfbb55905b14f2730eca7 by Ben Cooksley. Committed on 28/02/2019 at 05:33. Pushed by bcooksley into branch 'master'. Make ABI checks non-fatal again until the error hit by kded can be corrected. CCMAIL: skna...@kde.org CCMAIL: kde-frameworks-devel@kde.org M

T3689: Add abi compliance checker to CI

2019-02-22 Thread Ben Cooksley
bcooksley added a comment. With the exception of D19222 all of those have now been integrated. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, bcooksley Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettc

T3689: Add abi compliance checker to CI

2019-02-22 Thread Ben Cooksley
bcooksley added a comment. Build logs from our Docker images can be found at https://build.kde.org/job/Administration/ In this case, the image last changed 26 days ago. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, bcooksley Cc: danders, davidedmundson, dfaure, kde-frameworks

D19075: Fix FindEGL

2019-02-18 Thread Ben Cooksley
bcooksley added a comment. If someone could please trigger all of the Dependency Builds for FreeBSD once this has been landed that would be appreciated: https://build.kde.org/view/Failing/ REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D18960: Add compile check to FindEGL

2019-02-15 Thread Ben Cooksley
bcooksley added a comment. /usr/local/bin/gmake -f CMakeFiles/cmTC_fd24d.dir/build.make CMakeFiles/cmTC_fd24d.dir/build gmake[1]: Entering directory '/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp' Building CXX object CMakeFiles/cmTC_fd24d.dir/src.cxx.o /usr/bin/c++ -I/u

D18822: Fix Windows build [hopefully]

2019-02-13 Thread Ben Cooksley
bcooksley added a comment. @kossebau Please go ahead with testing via trial and error in this manner. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18822 To: aacid, vonreth Cc: bcooksley, albertvaka, kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, bruns

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-02-09 Thread Ben Cooksley
On Sun, Feb 10, 2019 at 8:35 AM David Faure wrote: > > On samedi 9 février 2019 20:11:53 CET Ben Cooksley wrote: > > On Sat, Feb 9, 2019 at 9:46 PM David Faure wrote: > > > Do you have more details? Which kioslave, from which test program? > > > > Looking more c

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-02-09 Thread Ben Cooksley
On Sat, Feb 9, 2019 at 9:46 PM David Faure wrote: > > Do you have more details? Which kioslave, from which test program? Looking more closely it seems that the issue is only happening on the stable branch - did your fix land there by any chance? Cheers, Ben

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-02-08 Thread Ben Cooksley
Hi David, Unfortunately it seems that the issue is still occurring as it has reappeared and blocked a Linux builder for ~22 hours. Same behaviour as last time i'm afraid - the kioslave processes had been directly launched by the test and were hanging as they were previously. Any ideas? Cheers, B

Re: CI for prison: missing dependency

2019-02-08 Thread Ben Cooksley
On Fri, Feb 8, 2019 at 5:57 AM Volker Krause wrote: > > On Saturday, 2 February 2019 19:15:36 CET Ben Cooksley wrote: > > On Sun, Feb 3, 2019 at 12:02 AM David Faure wrote: > > > On samedi 2 février 2019 11:20:28 CET CI System wrote: > > > > -- The following REQU

D16643: Correct the accept flag of the event object on DragMove

2019-02-05 Thread Ben Cooksley
bcooksley added a comment. Your name has now been updated. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt Cc: bcooksley, fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

2019-02-05 Thread Ben Cooksley
bcooksley added a comment. Please update your name on Identity, then i'll sync it from there. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt Cc: bcooksley, fvogt, aacid, bruns, dkorth, ngraham, kde-fra

D16643: Correct the accept flag of the event object on DragMove

2019-02-05 Thread Ben Cooksley
bcooksley added a comment. Phabricator can take up to 30 minutes to become aware of commits depending on how active a repository normally is. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt Cc: bcooksl

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-02-05 Thread Ben Cooksley
On Mon, Feb 4, 2019 at 6:35 AM David Faure wrote: > > On vendredi 1 février 2019 10:32:19 CET Ben Cooksley wrote: > > On Fri, Feb 1, 2019 at 9:15 PM David Faure wrote: > > > I'll try to get around to debugging this, but I'm surprised by one thing: > > > do

Re: CI for prison: missing dependency

2019-02-02 Thread Ben Cooksley
On Sun, Feb 3, 2019 at 12:02 AM David Faure wrote: > > On samedi 2 février 2019 11:20:28 CET CI System wrote: > > -- The following REQUIRED packages have not been found: > > > > * QRencode, The QRencode library, > > Can this be added to the CI? Unfortunately Android doesn't use the standard mecha

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-02-01 Thread Ben Cooksley
nt.kde.org/sysadmin/ci-tooling/blob/master/helpers/run-tests.py#L156 Thanks, Ben > > On lundi 21 janvier 2019 06:46:32 CET Ben Cooksley wrote: > > Git commit f6c79ff4787148459aa91c17d683e4fd6a57c323 by Ben Cooksley. > > Committed on 21/01/2019 at 05:46. > > Pushed by

D18527: List Android as officially supported

2019-01-26 Thread Ben Cooksley
bcooksley added a comment. If the following could be corrected before this is landed that would be appreciated: https://build.kde.org/view/Failing/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/14/console REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL h

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-01-26 Thread Ben Cooksley
On Sun, Jan 27, 2019 at 6:41 AM Albert Astals Cid wrote: > > El dissabte, 26 de gener de 2019, a les 13:05:23 CET, Bhushan Shah va > escriure: > > > > > > Can we try to get this documented? 1.7GB isn't a lot for lots of people > > > with fast internet (if the server serves fast enough). > > > >

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

2019-01-26 Thread Ben Cooksley
bcooksley added a comment. This change is somewhat urgent - as can be seen at https://binary-factory.kde.org/view/MacOS/ all Mac builds are currently broken due to this issue. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18547 To: vonreth, aacid, apo

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-01-26 Thread Ben Cooksley
On Sat, Jan 26, 2019 at 10:35 AM Albert Astals Cid wrote: > > El dilluns, 21 de gener de 2019, a les 6:46:32 CET, Ben Cooksley va escriure: > > Git commit f6c79ff4787148459aa91c17d683e4fd6a57c323 by Ben Cooksley. > > Committed on 21/01/2019 at 05:46. > > Pushed by bcook

[sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

2019-01-20 Thread Ben Cooksley
Git commit f6c79ff4787148459aa91c17d683e4fd6a57c323 by Ben Cooksley. Committed on 21/01/2019 at 05:46. Pushed by bcooksley into branch 'master'. Disable execution of tests for plasma-integration. This is necessary to ensure CI nodes do not become blocked due to hanging tests with

Bugzilla Server Move

2019-01-09 Thread Ben Cooksley
Hi all, We've just completed the migration of Bugzilla from a previous system to a newer system. While this hasn't changed Bugzilla itself much, it did involve an update from Ubuntu 14.04 to Ubuntu 18.04. >From our testing everything appears to be operating correctly. Should anyone see anything

Re: CI system disruption

2019-01-06 Thread Ben Cooksley
On Sun, Jan 6, 2019 at 10:14 PM Ben Cooksley wrote: > > Hi all, Hi everyone, > > Due to a massive translation change which took place in the last 24 > hours, the CI system is currently in the process of rebuilding the > whole of KDE for all the platforms it covers (both branch

CI system disruption

2019-01-06 Thread Ben Cooksley
aused. Regards, Ben Cooksley KDE Sysadmin

Re: KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 1 - Failure!

2019-01-04 Thread Ben Cooksley
On Sat, Jan 5, 2019 at 5:58 PM Aleix Pol wrote: > No, it shouldn't be necessary anymore as of > https://phabricator.kde.org/D17808 > *nod* Albert pointed this out shortly after I sent the mail - it's been sorted out now. Cheers, Ben > > Aleix > > On Fri, Jan 4

Re: KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 2 - Still Failing!

2019-01-04 Thread Ben Cooksley
Hi Aleix, Looks like the Android tooling is falling over here? Cheers, Ben On Sat, Jan 5, 2019 at 10:47 AM CI System wrote: > > BUILD FAILURE > Build URL > https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/2/ > Project: kf5-qt5 AndroidQt5.11 > Date of build: Fri, 04 J

Re: KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 1 - Failure!

2019-01-04 Thread Ben Cooksley
Hi Volker, Please see below - is Phonon of any use on Android? Cheers, Ben On Sat, Jan 5, 2019 at 10:35 AM CI System wrote: > *BUILD FAILURE* > Build URL > https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/1/ > Project: kf5-qt5 AndroidQt5.11 > Date of build: F

D17817: Build without D-Bus on Android

2018-12-29 Thread Ben Cooksley
bcooksley added a comment. Android CI builds are only enabled for the following repositories: - "frameworks/extra-cmake-modules" - "frameworks/karchive" - "frameworks/attica" - "frameworks/breeze-icons" - "frameworks/kcodecs" - "frameworks/kconfig" - "frameworks/k

D17650: Install kioslave as kioslave5 on Windows

2018-12-21 Thread Ben Cooksley
bcooksley added a comment. It is much more than 7 - at least on the Binary Factory. See https://binary-factory.kde.org/view/Windows%2032-bit/ and https://binary-factory.kde.org/view/Windows%2064-bit/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker,

T3689: Add abi compliance checker to CI

2018-12-20 Thread Ben Cooksley
bcooksley added a comment. I've made an experimental change which should resolve this issue if it is what is suspected to be the issue here. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, bcooksley Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, kna

T3689: Add abi compliance checker to CI

2018-12-20 Thread Ben Cooksley
bcooksley added a commit: R857:dbb3d8d9f37a: Make sure we wait and block until the publishing process is completed.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, bcooksley Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blaz

T3689: Add abi compliance checker to CI

2018-12-20 Thread Ben Cooksley
bcooksley added a comment. I checked execution of KDav on all four build nodes, and the process ran fine when done manually. Given there is no output from check-abi.py, this is quite hard to diagnose. Can you propose some debug output which might point out why it's doing nothing? TASK

T3689: Add abi compliance checker to CI

2018-12-16 Thread Ben Cooksley
bcooksley added a comment. Okay, there have been a number of comments here since i've last read it, so a bit to catch up on and go over. In regards to `akonadi-mime` I have now re-run it, and it seems to work fine. As long as you're relying only on the master manifest.yaml, then it shou

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

2018-12-04 Thread Ben Cooksley
On Tue, Dec 4, 2018 at 9:45 AM Elvis Angelaccio wrote: > > > > On 03/12/18 09:46, Ben Cooksley wrote: > > Hi all, > > Hi Ben Hi Elvis, > > > > > I've been informed by the PIM developers that they would like to bump > > the dependency of

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

2018-12-03 Thread Ben Cooksley
On Mon, Dec 3, 2018 at 10:31 PM René J.V. Bertin wrote: > > Hi, > > Can't you just configure the CI to use Qt 5.10? I think it's not good to > hardcode an "overzealous" (for lack of a better word) Qt version in projects > that don't require them AND I think that one should support the current LT

Transitioning CI builds of all non-Frameworks from Qt 5.9

2018-12-03 Thread Ben Cooksley
Hi all, I've been informed by the PIM developers that they would like to bump the dependency of the Qt version they use, from Qt 5.9 which it's on currently, to Qt 5.10. As a consequence, due to many KDE projects using PIM libraries, their dependency on Qt will also be effectively bumped. To mini

D17281: Add icon to KBuildSycocaProgressDialog cancel button

2018-12-03 Thread Ben Cooksley
bcooksley added a comment. Phabricator has a strong privacy model, meaning your email address is not accessible to anyone except you, so you'll need to post it here in this review so it can be committed to our repositories. Sorry for any confusion around this. REPOSITORY R241 KIO REVISI

D16919: Re-add DBus test

2018-11-26 Thread Ben Cooksley
bcooksley added a comment. The best we have documentation wise is https://phabricator.kde.org/w/continuous-integration/ however these are quite out of date (and incomplete). REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole, #framew

D16919: Re-add DBus test

2018-11-25 Thread Ben Cooksley
bcooksley added a comment. Okay, that is odd. I'll try reproducing the issue on the CI nodes in the next day or so - you changed 'kcalcore' in that example to 'konsole' I assume? REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole

D16919: Re-add DBus test

2018-11-23 Thread Ben Cooksley
bcooksley added a comment. Yes, that is basically what the CI does so should be a pretty good method of reproducing it's results. Did you run "make tests" / "ctest" or did you use the run-tests.py script to execute the unit tests? REPOSITORY R319 Konsole REVISION DETAIL https://phabri

D16919: Re-add DBus test

2018-11-22 Thread Ben Cooksley
bcooksley added a comment. When you did your reproduction attempt @hindenburg did you use the binaries the CI system itself uses, or did you build Frameworks, etc yourself? REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole, #framewor

Re: Regression in Frameworks - DBus Hangs

2018-11-17 Thread Ben Cooksley
On Sat, Nov 17, 2018 at 9:31 PM Albert Astals Cid wrote: > > El diumenge, 11 de novembre de 2018, a les 11:29:51 CET, Albert Astals Cid va > escriure: > > El diumenge, 11 de novembre de 2018, a les 6:51:39 CET, Ben Cooksley va > > escriure: > > > On Thu, Nov 8

Re: Regression in Frameworks - DBus Hangs

2018-11-16 Thread Ben Cooksley
On Sat, Nov 17, 2018 at 4:30 AM David Edmundson wrote: > > > Don't thank me yet, I locked up one of the build jobs, sorry. > https://build.kde.org/job/Applications/job/konsole/job/kf5-qt5%20SUSEQt5.9/380/console Diagnostic output available from D-Bus: jenkins@6934489e2599:~> qdbus org.kde.konsol

<    1   2   3   4   5   6   7   8   9   10   >