D25015: Update breeze theme shadows

cblack added a comment. In D25015#560515 , @ndavis wrote: > One thing we might need to do in order to finally stop changing the shadows is come up with a math based system for deciding how shadows should look based on the elevation we want

D24537: Icons for windy weather

cblack updated this revision to Diff 68079. cblack added a comment. Run icons through SVG cleaner REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24537?vs=68009=68079 BRANCH windy-weather-icons (branched from master) REVISION DETAIL

D24537: Icons for windy weather

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH windy-weather-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg, ndavis, ngraham Cc: trickyricky26, GB_2, vkrause, ndavis, kossebau, ngraham,

D24537: Icons for windy weather

This revision was automatically updated to reflect the committed changes. Closed by commit R266:ed5d288ae908: Icons for windy weather (authored by cblack). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24537?vs=68079=68080 REVISION DETAIL

D24537: Icons for windy weather

cblack updated this revision to Diff 68008. cblack added a comment. Colour changes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24537?vs=67874=68008 BRANCH windy-weather-icons (branched from master) REVISION DETAIL

D24537: Icons for windy weather

cblack updated this revision to Diff 68009. cblack added a comment. Remove excess icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24537?vs=68008=68009 BRANCH windy-weather-icons (branched from master) REVISION DETAIL

D24537: Icons for windy weather

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24537: Icons for windy weather

cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY There are now icons to represent windy weather. REPOSITORY R266 Breeze Icons BRANCH

D24621: [RFC] New Konsole and Yakuake icons

cblack added a comment. They look nice, but I'm not sure how well they fit in with other Breeze icons. Comparison montages: F7590391: image.png F7590397: image.png REPOSITORY R266 Breeze Icons REVISION

D24537: Icons for windy weather

cblack updated this revision to Diff 67874. cblack added a comment. Shift wind emblem to the right, clean scratch work, and rename night icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24537?vs=67625=67874 BRANCH windy-weather-icons (branched

D24537: Icons for windy weather

cblack added a comment. In D24537#545187 , @ndavis wrote: > That cyan looks odd. It sticks out way too much and AFAIK, it isn't commonly used to represent wind. Gray on more gray is going to be tricky as well though, especially when you've got

D27246: add buho icon

cblack added a comment. In D27246#610777 , @ndavis wrote: > What is buho? Maui's note taking app REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27246 To: mbruchert, camiloh, #vdg, ndavis Cc: cblack,

D27218: Add icon for org.kde.Ikona

cblack updated this revision to Diff 75506. cblack added a comment. Update style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27218?vs=75266=75506 BRANCH ikona-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27218

D27263: RFC: Accent colour for KColorScheme

cblack planned changes to this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

cblack added a task: T11052: Accent Colors, Color Ramps and other improvements to theming.. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh,

D27263: RFC: Accent colour for KColorScheme

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY This is a roughly thrown-together patch demonstrating how an accent colour can be

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in plasmawindowmanagement_interface.cpp:129 > how is this 9 already? Git blame shows that it's been 9 since 2018. Looks like someone made a mistake a while back? REPOSITORY R127 KWayland REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added a comment. Would the version number already being 9 in old versions of KWayland cause any issues? I have a feeling old KWayland versions may not like it when they're sent events they don't recognize, unless libwayland/KWayland handle that usecase. REPOSITORY R127 KWayland

D27851: Add rss icons in action

cblack edited reviewers, added: VDG, Breeze; removed: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27851 To: ognarb, #vdg, #breeze, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trickyricky26, michaelh, ngraham, bruns

D27848: Remove the tooltip icon

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Visually, LGTM. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27848 To: ngraham, #vdg,

D27851: Add rss icons in action

cblack added a comment. SVG-wise, optimization here seems suboptimal. There's excess elements that could be removed. Visually, the icon looks like the RSS icon, which is about all you need out of an RSS icon. I do believe we need at least 16px and 22px for monochromatic actions,

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added a comment. @zzag does anything else look off to you? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added a dependent revision: D27818: [wayland/AbstractClient] Broadcast application menu events. REPOSITORY R127 KWayland BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag, davidedmundson Cc: davidedmundson,

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76885. cblack added a comment. Address feedback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76811=76885 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 AFFECTED

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76886. cblack added a comment. Add missing documentation REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76885=76886 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack marked 6 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76804. cblack added a comment. Address feedback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76035=76804 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 AFFECTED

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76811. cblack added a comment. Coding style REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76805=76811 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 AFFECTED FILES

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack marked 3 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76805. cblack added a comment. Tick up PWM version REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76804=76805 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 AFFECTED

D26441: New icon for KTimeTracker

cblack updated this revision to Diff 74293. cblack added a comment. Use a rich grey instead of a rich mahogany REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26441?vs=74286=74293 BRANCH ktimetracker-icon (branched from master) REVISION DETAIL

D26441: New icon for KTimeTracker

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26441 To: cblack, #vdg, ndavis Cc: hellcp, ndavis, kde-frameworks-devel, aspotashev, LeGast00n, GB_2, michaelh, ngraham, bruns

D27218: Add icon for org.kde.Ikona

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27218 To: cblack, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27218: Add icon for org.kde.Ikona

cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH ikona-icon (branched from master) REVISION DETAIL

D27218: Add icon for org.kde.Ikona

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27218 To: cblack, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27218: Add icon for org.kde.Ikona

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27218 To: cblack, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26441: New icon for KTimeTracker

cblack added a comment. @ndavis ping REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26441 To: cblack, #vdg, ndavis Cc: hellcp, ndavis, kde-frameworks-devel, aspotashev, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26595: Add network-wireless-hotspot icon

cblack added a comment. @ndavis do you want to take over this revision? You have a better sense of what this icon should be than I do. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26595 To: cblack, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n,

D27218: Add icon for org.kde.Ikona

cblack updated this revision to Diff 75266. cblack added a comment. Drop 64px icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27218?vs=75183=75266 BRANCH ikona-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27218

D26441: New icon for KTimeTracker

This revision was automatically updated to reflect the committed changes. Closed by commit R266:dca95f680776: New icon for KTimeTracker (authored by cblack). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26441?vs=74293=75263 REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

cblack accepted this revision. cblack added a comment. Style-wise, the tinting effect definitely an improvement over what we currently have. Everything here LGTM. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis,

D26441: New icon for KTimeTracker

cblack updated this revision to Diff 74286. cblack added a comment. Adjust colour from blue to mahogany REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26441?vs=72823=74286 BRANCH ktimetracker-icon (branched from master) REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack created this revision. cblack added reviewers: KWin, zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY This patch adds an interface allowing a compositor to send the service name and

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 75855. cblack added a comment. Figure out how to use arc correctly REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=75854=75855 BRANCH cblack/appmenu-listener REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack planned changes to this revision. cblack added a comment. whoops, I seem to have forgotten how to use arc REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27263: RFC: Accent colour for KColorScheme

cblack updated this revision to Diff 75310. cblack added a comment. Load accent colour from kdeglobals instead of colourscheme REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27263?vs=75289=75310 BRANCH kcolorscheme-accent (branched from master)

D27263: RFC: Accent colour for KColorScheme

cblack edited the summary of this revision. cblack edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh,

D27263: RFC: Accent colour for KColorScheme

cblack edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

cblack updated this revision to Diff 75311. cblack added a comment. Expose method to drop accent colours from a KColorScheme object REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27263?vs=75310=75311 BRANCH kcolorscheme-accent (branched from

D27263: RFC: Accent colour for KColorScheme

cblack edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

cblack added a dependent revision: D27271: [kcms/colors] RFC: Accent Colours. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27252: add maui index icon in pm style

cblack added subscribers: ndavis, cblack. cblack accepted this revision as: VDG. cblack added a comment. This icon is visually nice, but it doesn't look 100% Breeze-y to me. I would see what feedback @ndavis has for the icon. REPOSITORY R266 Breeze Icons BRANCH index (branched from

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added a comment. In D27464#614479 , @davidedmundson wrote: > Good start. The direction makes sense. > > display.cpp and registry.cpp need updating to the new version number. Otherwise we won't be able to use this new method. > >

D27589: Try to apply the colorscheme of the current theme to QIcons

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Patch works as advertised and the code LGTM. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76035. cblack added a comment. Use utf8 encoding on client side REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=75855=76035 BRANCH cblack/appmenu-listener REVISION DETAIL

D27218: Add icon for org.kde.Ikona

cblack updated this revision to Diff 75577. cblack added a comment. Adjust style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27218?vs=75506=75577 BRANCH ikona-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27218

D27218: Add icon for org.kde.Ikona

This revision was automatically updated to reflect the committed changes. Closed by commit R266:96cf15e1905d: Add icon for org.kde.Ikona (authored by cblack). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27218?vs=75577=75578 REVISION DETAIL

D27218: Add icon for org.kde.Ikona

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH ikona-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27218 To: cblack, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26595: Add network-wireless-hotspot icon

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26595 To: cblack, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26595: Add network-wireless-hotspot icon

cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH hotspot-icon (branched from master) REVISION DETAIL

D26326: Add application/x-audacity-project icon

cblack updated this revision to Diff 72635. cblack added a comment. Optimise with Scour REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26326?vs=72632=72635 BRANCH arcpatch-D26326 REVISION DETAIL https://phabricator.kde.org/D26326 AFFECTED FILES

D26326: Add application/x-audacity-project icon

cblack updated this revision to Diff 72632. cblack added a comment. Refine colour palette of icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26326?vs=72526=72632 BRANCH arcpatch-D26326 REVISION DETAIL https://phabricator.kde.org/D26326

D26326: Add application/x-audacity-project icon

cblack commandeered this revision. cblack added a reviewer: broulik. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26326 To: cblack, #vdg, ndavis, ngraham, broulik Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26326: Add application/x-audacity-project icon

cblack added a comment. F7855956: image.png F7855958: image.png REPOSITORY R266 Breeze Icons BRANCH arcpatch-D26326 REVISION DETAIL https://phabricator.kde.org/D26326 To: cblack, #vdg, ndavis, ngraham,

D26326: Add application/x-audacity-project icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:4bba41c56947: Add application/x-audacity-project icon (authored by cblack). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26326?vs=72635=72662 REVISION

D26326: Add application/x-audacity-project icon

cblack added a comment. The foreground's colour contrast against the base of the colour icon should be higher IMO. (I have to squint to make out the emblem, which kinda defeats the purpose of an icon: making a filetype easier to see.) Plus, dark mimetype icons almost never use a darker

D26441: New icon for KTimeTracker

cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY This diff adds a new icon for KTimeTracker. T12305

D26441: New icon for KTimeTracker

cblack edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26441 To: cblack, #vdg Cc: kde-frameworks-devel, aspotashev, LeGast00n, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

This revision was automatically updated to reflect the committed changes. Closed by commit R127:dddf9d1ac3f2: Add application menu dbus paths to org_kde_plasma_window interface (authored by cblack). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D28712: Redo api.kde.org to look more like Aether

cblack created this revision. cblack added reviewers: VDG, ognarb. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. cblack requested review of this revision. TEST PLAN F8227629: image.png

D28712: Redo api.kde.org to look more like Aether

This revision was automatically updated to reflect the committed changes. Closed by commit R264:a6c47b24d1df: Redo api.kde.org to look more like Aether (authored by cblack). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28712?vs=79738=79769 REVISION DETAIL

D28444: Add ECMCargo module

cblack updated this revision to Diff 79521. cblack added a comment. Add STATIC_LIBNAME and DYNAMIC_LIBNAME options REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28444?vs=79430=79521 BRANCH cblack/cargo-integration REVISION DETAIL

D27263: RFC: Accent colour for KColorScheme

cblack updated this revision to Diff 79517. cblack added a comment. Fix typo REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27263?vs=75311=79517 BRANCH kcolorscheme-accent (branched from master) REVISION DETAIL

D26918: Improve KNotification API docs

cblack requested changes to this revision. cblack added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Mainpage.dox:13 > +In order to perform a notification, you need to create a description file, > which contains > +default parameters of the notification. It

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

cblack added inline comments. INLINE COMMENTS > kcmoduleinfo.h:130 > * @return a QExplicitlySharedDataPointer to KService created from the > modules .desktop file > + * WARNING: this will be null if this KCModuleInfo was created from a > KPluginInfo coming from KPluginMetaData > +

D28734: Port to Aether Bootstrap 4

cblack closed this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28734 To: cblack, #vdg, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D28766: Add auth-sim-locked and auth-sim-missing

cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH sim-card (branched from master) REVISION DETAIL https://phabricator.kde.org/D28766 To: ndavis, #vdg, cblack Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack,

D28734: Port to Aether Bootstrap 4

cblack edited the summary of this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28734 To: cblack, #vdg, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28734: Port to Aether Bootstrap 4

cblack edited the summary of this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28734 To: cblack, #vdg, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28734: Port to Aether Bootstrap 4

cblack updated this revision to Diff 79796. cblack added a comment. Fix footer text REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28734?vs=79794=79796 BRANCH cblack+ognarb/bootstrap-4 (branched from master) REVISION DETAIL

D28734: Port to Aether Bootstrap 4

cblack created this revision. cblack added reviewers: VDG, ochurlaud. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY Output generated by kapidox now uses Aether

D28734: Port to Aether Bootstrap 4

cblack updated this revision to Diff 79798. cblack added a comment. Remove unused Bootstrap 3 assets REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28734?vs=79796=79798 BRANCH cblack+ognarb/bootstrap-4 (branched from master) REVISION DETAIL

D28737: Add sim card device icons

cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH sim-card (branched from master) REVISION DETAIL https://phabricator.kde.org/D28737 To: ndavis, #vdg, cblack Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk,

D28033: Create ExpandableListItem

cblack added a comment. In D28033#627180 , @davidre wrote: > I would love if we could find a way to show that the item is expandable I would probably use a pointing down arrow without a stem when collapsed, and pointing up when open.

D28579: Improve the look of kcachegrind

cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH kcachegrind (branched from master) REVISION DETAIL https://phabricator.kde.org/D28579 To: ndavis, #vdg, cblack Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28444: WIP/RFC: Add ECMCargo module

cblack updated this revision to Diff 79430. cblack added a comment. Address feedback REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28444?vs=78925=79430 BRANCH cblack/cargo-integration REVISION DETAIL https://phabricator.kde.org/D28444

D28444: Add ECMCargo module

cblack retitled this revision from "WIP/RFC: Add ECMCargo module" to "Add ECMCargo module". cblack edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28444 To: cblack, #frameworks, #build_system Cc: apol, IlyaBizyaev,

D28470: WIP: IconItem: Refactor source handling for different types

cblack added a comment. Splitting into multiple classes seems like a good idea, but "strategy"? Seems like an odd choice of name to me. INLINE COMMENTS > iconitem.cpp:58 > + > +class NullStategy : public IconItemStrategy > +{ Is this class necessary? I feel like this class's behaviour

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack requested changes to this revision. cblack added a comment. I've changed my mind to agree with @ngraham here—this is too transparent. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack, ngraham Cc:

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack added a comment. In D28353#636183 , @niccolove wrote: > In D28353#636164 , @cblack wrote: > > > Looks visually appealing to me, with one question: How does this look on low-end hardware

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack accepted this revision as: VDG, cblack. cblack added a comment. This revision is now accepted and ready to land. Looks visually appealing to me, with one question: How does this look on low-end hardware where there's compositing but no blur? REPOSITORY R242 Plasma Framework

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638435 , @apol wrote: > Will this make all the boilerplate in ikona disappear? It'll bring it down to the same level as everything else. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D28452: Fix baloo compile

cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28452 To: usta, #baloo, ngraham, cblack Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson,

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638540 , @IlyaBizyaev wrote: > In D28444#638430 , @cblack wrote: > > > more than half of Ikona's CMakeLists.txt is boilerplate dedicated to integrating Rust with

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638988 , @IlyaBizyaev wrote: > In D28444#638877 , @cblack wrote: > > > CMake needs to know when the Rust source has changed so it can rebuild it > > > Changes

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638428 , @apol wrote: > I wonder if this is covering a very widespread use-case. If there's just one application that needs it, it could make sense to keep it there and once it's polished, we put it in ECM to

D28444: WIP/RFC: Add ECMCargo module

cblack created this revision. cblack added reviewers: Frameworks, Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY The ECMCargo module allows for easy usage

  1   2   >