D21286: Perl: fix the // operator

cullmann accepted this revision. cullmann added a comment. Yes, please push, thanks. REPOSITORY R216 Syntax Highlighting BRANCH fix-perl REVISION DETAIL https://phabricator.kde.org/D21286 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D4234: Change algorithm for autobrace.

cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 To: cullmann, #ktexteditor, mwolff, brauch, cactus Cc: kde-frameworks-devel, nalvarez, mwolff, anthonyfieroni, dhaumann, brauch, cullmann, kwrite-devel, domson, michaelh, ngraham,

D4234: Change algorithm for autobrace.

cullmann commandeered this revision. cullmann added a reviewer: cactus. cullmann added a comment. We altered stuff in D19608 . Could you try if that fits your needs? If not, perhaps we need a new review for what can be further improved, thanks.

D20083: Multiple level of autobrace

cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20083 To: cullmann, cactus Cc: cullmann, loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D20083: Multiple level of autobrace

cullmann commandeered this revision. cullmann added a reviewer: cactus. cullmann added a comment. We consider this fixed with D19608 . If you disagree, feel free to reopen this request. Btw., thanks for the incentive to submit a patch! REPOSITORY R39

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

cullmann requested changes to this revision. This revision now requires changes to proceed. REVISION DETAIL https://phabricator.kde.org/D17693 To: loh.tar, #ktexteditor, cullmann, mwolff, #vdg Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson,

D21078: Avoid infinite loop in "Toggle Contained Nodes" action

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ;=) Thanks for quick fix. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21078 To: loh.tar, #ktexteditor, cullmann Cc: cullmann, kwrite-devel,

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

cullmann added a comment. I am not sure about the "UserSetsOfCharsToEncloseSelection" part. Wouldn't it be enough to have the "CharsToEncloseSelection" config part and have the other thing just internal in the editor config page as "template" the user can select to fill the selection of

D20958: New menu of syntax highlighting in the status bar

cullmann added a comment. Ok, thanks! REPOSITORY R39 KTextEditor BRANCH new-mode-menu REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel,

D20958: New menu of syntax highlighting in the status bar

cullmann accepted this revision. cullmann added a comment. I am ok with having this as is. If one can move it to QListView, nice, but that could be done in an extra request. Thanks for this great improvement. REPOSITORY R39 KTextEditor BRANCH new-mode-menu REVISION DETAIL

D20959: Allow to change the Mode, after changing the Highlighting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Sounds reasonable. REPOSITORY R39 KTextEditor BRANCH fix-mode-highlight-menu REVISION DETAIL https://phabricator.kde.org/D20959 To: nibags, #ktexteditor, #kate, cullmann Cc:

D20958: New menu of syntax highlighting in the status bar

cullmann added a comment. As first feedback: much better than current state :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20958 To: nibags, #ktexteditor, #kate, #vdg Cc: cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh,

D20963: Code cosmetic

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20963 To: loh.tar, #ktexteditor, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel,

D20924: ViewConfig: Use new generic config interface

cullmann accepted this revision. cullmann added a comment. I think this look OK. Can't verify every replacement is correct, but let's have that in now. Thanks for that massive amount of work ;=) REVISION DETAIL https://phabricator.kde.org/D20924 To: loh.tar, #ktexteditor, dhaumann,

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think this would be some initial solution for this issue. An highlighting specific config would be even cooler, but giving the user the choice to add additional chars (or

D20852: Fix to show folding preview when move the mouse from bottom to top

cullmann added a comment. Harr, with that change it looks good here. Need that a Diff here or can I commit without? > Feel free to commit that. === For unit tests: if you have small improvements for the tests that make them more stable, feel free to commit

D20697: Review IconBorder

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. loh.tar, can you take a look? If it is too complex to fix easily, we can still revert this and apply it again later together with a fix. Thanks for pointing the CI fail out David!

D20697: Review IconBorder

cullmann added a comment. :( Sorry, I didn't run them again, just tried out if it works in KDevelop. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor, dhaumann, cullmann Cc: dfaure, cullmann, dhaumann, kwrite-devel,

D20697: Review IconBorder

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. This works for me fine with KDevelop. Please commit. Thanks REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor, dhaumann, cullmann Cc: cullmann,

D20697: Review IconBorder

cullmann added a comment. I am not sure one can delay the updateGeometry stuff until one paints. REVISION DETAIL https://phabricator.kde.org/D20697 To: loh.tar, #ktexteditor, dhaumann, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh,

D20697: Review IconBorder

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Unfortunately, the annotation stuff regressed. I tried KDevelop, right click on text => Git -> Annotation... See pre-patch and post-patch pictures below, the too small one

D20766: Use appropriate background color for text previews

cullmann added a comment. I actually think the theme should contain all colors hard-coded and KTextEditor should properly use that instead of currently the mix of hardcoded/defaults. The only automatism should be (in my eyes) to switch between a light/dark variant automatic depending on

D20765: Add input methods to input method status bar button

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Good idea! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20765 To: broulik, #kate, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel,

D20742: Paint the folding marker in propper color and make it more visible

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Both diff + output change in the screenshot look reasonable for me. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20742 To: loh.tar, #ktexteditor,

D17442: KTextEditor: Tweak keyboard shortcuts to free F keys

This revision was automatically updated to reflect the committed changes. Closed by commit R39:8193e735bca2: remove default shortcut F6 to show icon border (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17442?vs=47152=56754#toc REPOSITORY R39 KTextEditor

D17442: KTextEditor: Tweak keyboard shortcuts to free F keys

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. We go with the minimal invasive effort ATM: just remove F6. As discussed in D17443 . We can introduce the CTRL-E... stuff later. REPOSITORY R39

D20606: Add action to toggle folding of child ranges

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Given we have no actions and some more proper documentation, I am in favor of this. I would remove the two asserts here: Q_ASSERT(startLine >= 0); Q_ASSERT(startLine <

D20565: Ensure not to fold the end marker

cullmann accepted this revision. cullmann added a comment. You can submit that, perhaps with the discussed checks, thanks And happy Easter ;=) REVISION DETAIL https://phabricator.kde.org/D20565 To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham Cc: kwrite-devel, kde-frameworks-devel,

D20606: Toggle folding of child ranges by right click

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. The question is: with a context menu, isn't that then already too inconvenient? At the moment we have no context menu for the bar at all. I could live with the right

D18996: Fix building with namespaced Qt

cullmann closed this revision. cullmann added a comment. The build issue got fixed. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18996 To: davschul, vkrause Cc: cgiboudeaux, cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, domson,

D20606: Toggle folding of child ranges by right click

cullmann added reviewers: ngraham, dhaumann. cullmann added a comment. I think the feature is nice. For the code: I would like to have comments for the function decls. to tell what they really do. e.g. toggleFoldingInRange needs a short summary what it does, the comments in the

D20565: Ensure not to fold the end marker

cullmann added reviewers: dhaumann, ngraham. cullmann added a comment. I like the idea, its nice for e.g. if then else cascades, you get then out of stuff like if (blockwise || range.onSingleLine()) { lineStart = range.start().column(); remainingChars =

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

cullmann accepted this revision. REPOSITORY R39 KTextEditor BRANCH arcpatch-D20542 REVISION DETAIL https://phabricator.kde.org/D20542 To: meven, #ktexteditor, ngraham, cullmann Cc: cullmann, kossebau, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, sars,

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

cullmann added a reviewer: ngraham. cullmann added a comment. Perhaps Nate has feedback, too. I have no issues with this change. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20542 To: meven, #ktexteditor, ngraham Cc: cullmann, kossebau, kwrite-devel,

D20534: avoid conflicting shortcuts for switching tabs

cullmann added a comment. Upsa, pushed it with my copyright update :/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20534 To: cullmann, #kate, ngraham, dhaumann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D20534: avoid conflicting shortcuts for switching tabs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:9f2ffd36c587: avoid conflicting shortcuts for switching tabs (authored by cullmann). REPOSITORY R39 KTextEditor

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann added a comment. :=) Nice that it helps. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh,

D20534: avoid conflicting shortcuts for switching tabs

cullmann added reviewers: Kate, ngraham, dhaumann. cullmann added a comment. Ok with that? Follow up of https://phabricator.kde.org/D7497 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20534 To: cullmann, #kate, ngraham, dhaumann Cc: kwrite-devel,

D20534: avoid conflicting shortcuts for switching tabs

cullmann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY use ALT + Home/End for top/bottom of view REPOSITORY R39 KTextEditor BRANCH master REVISION

D20495: KateIconBorder: Fix folding popup width and height

This revision was automatically updated to reflect the committed changes. Closed by commit R39:4396efe1cdce: KateIconBorder: Fix folding popup width and height (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20495?vs=56071=56184

D20495: KateIconBorder: Fix folding popup width and height

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Works ok for me. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20495 To: loh.tar, #ktexteditor, cullmann Cc: cullmann, kwrite-devel,

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann added a comment. Please try if my last commit fixed that: https://cgit.kde.org/ktexteditor.git/commit/?id=a9f97f1be115c1e4ede391b6d3d5e2aed6350992 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann added a comment. Ok, I can reproduce the issue you mention. I will take a look. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel,

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann added a comment. Didn't try folding :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham,

D19450: DocumentPrivate: Respect indention mode when block selection

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19450 To: loh.tar, #ktexteditor, #kate, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson,

D19450: DocumentPrivate: Respect indention mode when block selection

cullmann added a comment. Just had not looked at this. Looks reasonable, please push that. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19450 To: loh.tar, #ktexteditor, #kate, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad,

D12295: Supporting nested brackets for Kate autobrackets

cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12295 To: cullmann, #ktexteditor, #kate, dhaumann, brauch, sraizada Cc: loh.tar, brauch, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, szutmael, gennad, domson, michaelh,

D12295: Supporting nested brackets for Kate autobrackets

cullmann commandeered this revision. cullmann edited reviewers, added: sraizada; removed: cullmann. cullmann added a comment. We close this in favor of the other patches. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12295 To: cullmann, #ktexteditor, #kate,

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. 5.57 released, should ne tried now. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund,

D20499: Support gzipping of svgz also on windows, using 7z

cullmann added a comment. I glanced at it, thought I have at home no Windows machine at hand to test if the command line works as planned. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20499 To: kossebau, #plasma, #windows Cc: cullmann,

D19511: ViewPrivate: Disable read-only mode action when doc is modified

cullmann added a comment. I still think we should stay with status quo, can you drop this request? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19511 To: loh.tar, #ktexteditor, cullmann Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor,

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

cullmann added a comment. The CI is a bit unhappy with the gzip depedency on Windows. Might one just write a minimal KArchive based gzip'er for this? gzip isn't there on any normal Windows machine, even if you have libz. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

Re: Unannounced Dependency Change - plasma-framework

On 2019-04-12 20:47, Ben Cooksley wrote: Hi all, Recently builds of plasma-framework have started failing on Windows due to the absence of "gzip", which was added as a Dependency without any announcement as is required of all new dependencies. With regards to Windows in particular, usually

D19608: DocumentPrivate: Make bracket handling smart

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Works for me, beside that the patch no longer cleanly applies. But with some false removed and the later parts skipped, it did work as advertised. REPOSITORY R39 KTextEditor

D20264: Add test for "Auto Reload Document" option

cullmann accepted this revision. cullmann added a comment. I think this can go in as is, as long as the test works determinstically, which I assume it does. REVISION DETAIL https://phabricator.kde.org/D20264 To: loh.tar, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel,

D19691: ViewInternal: Review drop event

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. +1, nice Played a bit here with the new behavior, MUCH better than the old one. For the block selection stuff: yes, tabs + spaces + block selection is messy, thought I think

D20233: Add syntax highlighting for fish shell

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0e2d7e61a256: Add syntax highlighting for fish shell (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20233?vs=55361=56093

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1726c4f868f6: AppArmor: dont highlight variable assignments and alias rules within profiles (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST

D20467: Allow to close a document whose file was deleted on disk

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2a0cf7044f75: Allow to close a document whose file was deleted on disk (authored by meven, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D20467: Allow to close a document whose file was deleted on disk

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think this should go in. For application supporting the interface, the document is removed. For application not supporting the interface, at least the file is closed and you

D20467: Allow to close a document whose file was deleted on disk

cullmann added a comment. The current implementation at least closes the file, in all applications. It just doesn't remove in in all of them from the document list. I think that is ok enough, more can't be done in KTextEditor. Extra reviews for extending the applications are welcome.

D20467: Allow to close a document whose file was deleted on disk

cullmann added a comment. I think the solution with the bool setting is good enough. If nobody else disagrees, I would accept this later. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20467 To: meven, cullmann, #kate, #frameworks, dhaumann Cc: dhaumann,

D20467: Allow to close a document whose file was deleted on disk

cullmann added a comment. One could try to first do a closeUrl and just do the closeDocumentInApplication() in addition afterwards. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20467 To: meven, cullmann, #kate, #frameworks, dhaumann Cc: dhaumann, ngraham,

D20467: Allow to close a document whose file was deleted on disk

cullmann added a comment. If you really want to close the document aka removing it from the application's document list, you need the interface. If you just want to set it back to "untitled document" you can use closeUrl REPOSITORY R39 KTextEditor REVISION DETAIL

D20467: Allow to close a document whose file was deleted on disk

cullmann added a comment. That is because KWrite doesn't implement that interface function, unfortunately. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20467 To: meven, cullmann, #kate, #frameworks, dhaumann Cc: dhaumann, ngraham, kwrite-devel,

D20467: Allow to close a document whose file was deleted on disk

cullmann added reviewers: Kate, Frameworks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20467 To: meven, cullmann, #kate, #frameworks Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks REVISION DETAIL https://phabricator.kde.org/D20434 To: loh.tar, cullmann, #ktexteditor, dhaumann Cc: dhaumann, cfeck, ngraham, kwrite-devel, kde-frameworks-devel,

D20434: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think to not agonize MSVC it would be better to use the unicode code point for the QChar constructor. After that is altered I think, too, this should go in, nice!

D20233: Add syntax highlighting for fish shell

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, then we keep that license and push this as is. Thanks for the contribution, btw.! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D20233

D20372: [kemoticons] make it compile without foreach

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable. REPOSITORY R301 KEmoticons BRANCH compile_without_foreach REVISION DETAIL https://phabricator.kde.org/D20372 To: mlaurent, dfaure, cullmann Cc: cullmann,

D20233: Add syntax highlighting for fish shell

cullmann added a comment. If you think you nearly changed everything, I guess MIT is ok. If you think still too much is derived, I can live with LGPL ;=) I let you decide. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D20233 To: adiestelhorst,

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. See no obvious issues, please commit, thanks! REPOSITORY R216 Syntax Highlighting BRANCH arcpatch-D20221 REVISION DETAIL https://phabricator.kde.org/D20221 To: nibags,

D19446: DocumentPrivate: Support auto bracket in block selection mode

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. The new functionality works ok enough for me. For the other issues you found with the cursor updates and the range stuff I would like different patches if we want to tackle them.

D20233: Add syntax highlighting for fish shell

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Thanks for the contribution. On a first glance, that looks ok, no hard coded colors, test case, ... We would prefer if the license would be MIT, is that possible?

D20220: AppArmor & SELinux: remove one indentation in XML files

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH remove-indentation REVISION DETAIL https://phabricator.kde.org/D20220 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D19876: Fix: apply correctly the text colors of the chosen scheme

cullmann accepted this revision. cullmann added a comment. I think this is good enough as it is. I would prefer that we in the future just switch over to use the syntax-highlighting themes, but that is a lot of work :) REPOSITORY R39 KTextEditor REVISION DETAIL

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

cullmann accepted this revision. cullmann added a comment. The menu is now ok and the feature still works for me. And yes, the view still jumps a bit. :P Funny enough for me it failed during testing more because of missing file notifications, should not have tried it on NFS. REVISION

D20148: Allow line end context switches in empty lines

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok for me, thanks! REPOSITORY R216 Syntax Highlighting BRANCH fix-line-continue REVISION DETAIL https://phabricator.kde.org/D20148 To: nibags, #framework_syntax_highlighting,

D20148: Allow line end context switches in empty lines

cullmann added a comment. The change in the results look reasonable. For the loop itself: Should one not combine both loops? e.g. loop as long as either the emptycontext is stay and one does switch at line end or the emptycontext doesn't stay? Then one can handle intermixed things.

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

cullmann added a comment. Hmm, if the follow_.. stuff is removed, I think the sub-menu should go away, too. The view_auto_reload should just be a top-level action, menus with single entries are strange ;) Feel free to commit this with such a change. REPOSITORY R39 KTextEditor

D19051: [RFC]DocumentPrivate: Auto unwrap line when text is removed

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hmm, I am not sure if that is the right place for this. I think the wrapText call in KTextEditor::DocumentPrivate::editEnd() should handle this. REPOSITORY R39

D19425: DocumentPrivate: Support to set dictionary on block selection

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Doesn't hurt in my eyes, why not. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19425 To: loh.tar, #ktexteditor, cullmann Cc: cullmann, kwrite-devel,

D19771: Use placeholder instead of label

cullmann added a comment. Hi, if we do that: Could we then remove the "Mode:", too and move that into the combobox? Perhaps like "Plain text search", "Whole words search", ... Otherwise the search doesn't save space and it looks "strange". REPOSITORY R39 KTextEditor REVISION DETAIL

D19798: Fix Words & Chars String on katestatusbar.

This revision was automatically updated to reflect the committed changes. Closed by commit R39:f735948bbe25: Fix Words Chars String on katestatusbar. (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19798?vs=53989=55119 REVISION

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann added a comment. I think nobody has any idea if that is the right fix. My proposal would be: we wait until 5.57 is out in ~one week. Afterwards we apply this and give it some testing in master. If the world doesn't break, this can stay in, else we can revert it before 5.58.

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think this works well enough to be added. Could the "view_auto_follow" be implemented in a second review after this is commited? I see there is some unresolved comment about

D19446: DocumentPrivate: Support auto bracket in block selection mode

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19446 To: loh.tar, #ktexteditor, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson,

D19446: DocumentPrivate: Support auto bracket in block selection mode

cullmann added a comment. Hi, I think this is an improvement. Could you update the patch to current master? For your questions: - Feature or bug? Select in block mode from right->left on a single line after last char a block. The brackets are exchanged )( and placed at the

Re: CI system maintainability

u would let some student test the changed behavior some days. This is just not feasible for me, and yes, for some of these changes, rather than abandoning them (and trashing precious work others did), I will somewhen apply them with close to zero real testing. Greetings Christoph -- --

D19876: Fix: apply correctly the text colors of the chosen scheme

cullmann accepted this revision. cullmann added a comment. I am ok with this ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19876 To: nibags, #ktexteditor, #kate, cullmann, mwolff Cc: mwolff, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad,

D19876: Fix: apply correctly the text colors of the chosen scheme

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok with that. In the long run we should use only the syntaxhighlighting themes and provide UX for that. Volunteers? REPOSITORY R39 KTextEditor BRANCH fix-schemas REVISION

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

cullmann added a comment. I still need to test that again ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19517 To: loh.tar, #ktexteditor, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham,

D18793: Handle text completion with block selection mode

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hi, I still don't like that we do different things in replaceText depending on the selection of the potential activeView, that makes this function harder to use correctly, as

D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0)

This revision was automatically updated to reflect the committed changes. Closed by commit R216:a24144952688: Fix endRegion folding in rules with beginRegion+endRegion (use length=0) (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D19876: Fix: apply correctly the text colors of the chosen scheme

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19876 To: nibags, #ktexteditor, #kate, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson,

D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think this is a reasonable change! Thanks. REPOSITORY R216 Syntax Highlighting BRANCH folding-endRegion-beginRegion REVISION DETAIL https://phabricator.kde.org/D1 To:

D19876: Fix: apply correctly the text colors of the chosen scheme

cullmann added a comment. I don't like that one sets the global renderer config. Where attributesForDefinition is called one knows our schema name. One could just pass it to that routine and do the hack only there. REPOSITORY R39 KTextEditor REVISION DETAIL

D19798: Fix Words & Chars String on katestatusbar.

cullmann added a comment. I would like to push that but fail on the name filter. Can I ammend the author to "Yi-Jyun Pan "? REPOSITORY R39 KTextEditor BRANCH fixStatusBarString (branched from master) REVISION DETAIL https://phabricator.kde.org/D19798 To: ppeter, #kate, dhaumann Cc:

D19811: Add Smali syntax highlighting file

This revision was automatically updated to reflect the committed changes. Closed by commit R216:ed2b54803d1c: Add Smali syntax highlighting file (authored by davispuh, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D19974: Add extensions to groovy highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:e8f6b3542cbf: Add extensions to groovy highlighting (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19974?vs=54602=54668

<    2   3   4   5   6   7   8   9   10   11   >