D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

cullmann added a comment. Hmpf :/ I improved my commit message and amended, but arc at it :/ I will BUG: and CCBUG: the bugs manually :/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19283 To: cullmann, dhaumann Cc: loh.tar, thomassc, kwrite-devel, kde-frame

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

This revision was automatically updated to reflect the committed changes. Closed by commit R39:ce4194b5bc2e: try to improve painting height for text lines - bug 403868 avoid to cut _ and… (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19283?vs=52466&id=52544#toc R

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

cullmann created this revision. cullmann added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY using a better height and removing the overpainting stuff TEST

D19035: Help build on Windows with usage of CMake Targets

cullmann commandeered this revision. cullmann edited reviewers, added: dantti; removed: cullmann. cullmann added a comment. > I will abandon it. I compile syntax-highlighting btw. nightly, too, in the AbsInt compile farm on Windows (MSVC) and macOS (xcode toolchain)

D19035: Help build on Windows with usage of CMake Targets

cullmann abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19035 To: cullmann, #framework_syntax_highlighting, dhaumann, vkrause, dantti Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

This revision was automatically updated to reflect the committed changes. Closed by commit R39:8fb410574b14: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline (authored by ahmadsamir, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https:/

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Given the docs explicitly state one shall use the new enum value, I think this should go in. REPOSITORY R39 KTextEditor BRANCH syntax-hl (branched from master) REVISION DETAIL h

D18734: Update octave.xml to Octave 4.2.0

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c27d13d75155: Update octave.xml to Octave 4.2.0 (authored by sirgienko, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18734?vs=

D19163: Make it possible to show all spaces in the document

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0a9aeb183314: Make it possible to show all spaces in the document (authored by apol, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19163?

D19163: Make it possible to show all spaces in the document

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think that is ok now, thanks for the nifty feature. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D19163 To: apol, #kate, cullmann Cc: c

D18734: Update octave.xml to Octave 4.2.0

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. But beside the stuff with the xcvxv.xcvc stuff, I think you can commit this already as a first step to have a nicer highlighting, nice to see all hard coded colors gone! REPOSITORY R

D18734: Update octave.xml to Octave 4.2.0

cullmann added a comment. For the . stuff in keywords, have you tried to specify some style stuff? INLINE COMMENTS > sirgienko wrote in octave.xml:2745 > Could one word (`end`) be in several region? > Because, in Octave, you could end `if` statement by `endif` or just `end`. > In t

D19249: Improve highlighting of TypeScript (and React) and add more tests for PHP

This revision was automatically updated to reflect the committed changes. Closed by commit R216:df1afdbedcbf: Improve highlighting of TypeScript (and React) and add more tests for PHP (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE h

D19215: Install DefinitionDownloader header

cullmann added a comment. I would have no issues with this if Volker is ok, too. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19215 To: davschul, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, genethomas, ngraha

D19200: Return sorted definitions for file names and mime types

This revision was automatically updated to reflect the committed changes. Closed by commit R216:a62af5713549: Return sorted definitions for file names and mime types (authored by davschul, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricat

D19200: Return sorted definitions for file names and mime types

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, this seems to work now here, too ;) Will merge it, thanks again. REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann, vkrause Cc: dhaumann, kwrite-devel, kde

D19163: Make it possible to show all spaces in the document

cullmann added a comment. In D19163#417139 , @apol wrote: > In D19163#415907 , @cullmann wrote: > > > I like the feature, but for the implementation: Could we alter the config to itself hold the enu

D19200: Return sorted definitions for file names and mime types

cullmann added a comment. Thanks for taking a look again ;=) I would propose to just stable_sort the vector, that should always yield the same result. And I think the sorting is the only issue, the other problem I got did only occur with non-QRC syntax files and was introduced by mysel

D19200: Return sorted definitions for file names and mime types

cullmann added a comment. I think the + 1 is the only real issue, the other issue stems from my local setting that I have no compiled in QRC. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann, vkrause Cc: kwrite-devel, kde-fram

D19200: Return sorted definitions for file names and mime types

cullmann added a comment. I think one error is the sort of the empty vector with the begin() + 1 But even then, make test fails, after fixing this. Please take a look and run the tests. Thanks REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To

D19200: Return sorted definitions for file names and mime types

cullmann added a comment. Actually, do we need a partial sort? Should we not just stable_sort the complete vector by prio? That should keep stuff with same prio untouched, or? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann,

D18997: Add functions returning all definitions for a mimetype or file name

cullmann closed this revision. cullmann added a comment. Ok ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18997 To: davschul, vkrause, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, ngraham, br

D19200: Return sorted definitions for file names and mime types

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, ngraham

D19200: Return sorted definitions for file names and mime types

cullmann added a comment. The partial sort is bad ;=() REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkra

D19200: Return sorted definitions for file names and mime types

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Beside that this fails ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-d

D19200: Return sorted definitions for file names and mime types

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yes, this is nice, nice trick with value(0) to avoid adding an element to the vector but just letting the API default construct it. REPOSITORY R216 Syntax Highlighting REVISION DETAI

D19200: Return sorted definitions for file names and mime types

This revision was automatically updated to reflect the committed changes. Closed by commit R216:ba615b22ece6: Return sorted definitions for file names and mime types (authored by davschul, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricat

D18996: Fix building with namespaced Qt

cullmann added a comment. No problem, I just reopened it that I remember to take a look again at it myself. I just run into this issue wanting to land some patches on a openSUSE Leap machine. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18996 To: d

D18996: Fix building with namespaced Qt

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Hmm, there is one issue: With older cmake, aka cmake version 3.10.2 I get now: CMake Error at data/CMakeLists.txt:68 (target_link_libraries): Object library tar

D19198: BrightScript: Unary and hex numbers, @attribute

This revision was automatically updated to reflect the committed changes. Closed by commit R216:5c0f50026bfc: BrightScript: Unary and hex numbers, @attribute (authored by dlevin, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D19198: BrightScript: Unary and hex numbers, @attribute

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable + we have a test => nice, merging. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19198 To: dlevin, cullmann Cc: kwrite-devel, kd

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

This revision was automatically updated to reflect the committed changes. Closed by commit R39:598b6c9ca58b: katetextbuffer: refactor TextBuffer::save() to better separate code paths (authored by mgerstner, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

cullmann added a comment. Thanks, will apply this. Nice that you help to improve this code. REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, c

D19035: Help build on Windows with usage of CMake Targets

cullmann added a comment. I think then we should just abandon it, if it has no real benefit at all, or? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19035 To: dantti, #framework_syntax_highlighting, dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-fra

D19035: Help build on Windows with usage of CMake Targets

cullmann added a reviewer: vkrause. cullmann added a comment. I think I let Volker decide that, for non-cross compile stuff this is more or less a nop and I never do cross compiling ;) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19035 To: dantti, #fr

D19163: Make it possible to show all spaces in the document

cullmann added a comment. I like the feature, but for the implementation: Could we alter the config to itself hold the enum? An other thing: why was the non-printable regex altered? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19163 To: apol, #kate Cc: cullm

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

cullmann added a comment. If you pass me your author email, I will push that. REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sa

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks, other things looks reasonable to me. REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel, kde-

D18997: Add functions returning all definitions for a mimetype or file name

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. I would propose: Use the m_sortedDefs as base for the searching. Return the vector after the bestCandidate did the sort. That would yield in my eyes the most useful sorting: a

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. This looks reasonable, but could we get some Qt/KDE style CamelCase enum values? enum SaveResult { SAVE_FAILED = 0, SAVE_NO_PERMS, SAVE_SUCCESS

D18734: Update octave.xml to Octave 4.2.0

cullmann added a comment. In D18734#411416 , @sirgienko wrote: > In D18734#411032 , @cullmann wrote: > > > Good question: > > > > I added a minimal howto to the README.md: > > > > https://c

D18907: Handle the case if createSpeller is passed an unavailable language

This revision was automatically updated to reflect the committed changes. Closed by commit R246:f49e7a6fb88c: Handle the case if createSpeller is passed an unavailable language (authored by ahmadsamir, committed by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricat

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R216:eda235463cd2: Avoid duplicate *-php.xml files in "data/CMakeLists.txt" (authored by cullmann). REPOSITORY R216 Synta

D18997: Add functions returning all definitions for a mimetype or file name

cullmann added a comment. Thanks. Nice that we get the patches, then all can benefit from the improvements. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18997 To: davschul, vkrause, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad

D18997: Add functions returning all definitions for a mimetype or file name

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0e94e0006005: Add functions returning all definitions for a mimetype or file name (authored by davschul, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https

D18997: Add functions returning all definitions for a mimetype or file name

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks => will push that. REVISION DETAIL https://phabricator.kde.org/D18997 To: davschul, vkrause, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, micha

D18996: Fix building with namespaced Qt

This revision was automatically updated to reflect the committed changes. Closed by commit R216:96466afebf63: Fix building with namespaced Qt (authored by davschul, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18996?vs=516

D18998: update literate haskell mimetype

This revision was automatically updated to reflect the committed changes. Closed by commit R216:fe00f62078ea: update literate haskell mimetype (authored by davschul, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18998?vs=51

D18998: update literate haskell mimetype

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Makes sense ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18998 To: davschul, vkrause, cullmann Cc: kwrite-devel, kde-frameworks-devel, genna

D18997: Add functions returning all definitions for a mimetype or file name

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Makes sense. Could you add a @since 5.56 to the doxygen? Otherwise this seems fine. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.o

D18982: prevent assertion in regex load

This revision was automatically updated to reflect the committed changes. Closed by commit R216:152968754edc: prevent assertion in regex load (authored by davschul, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18982?vs=516

D18996: Fix building with namespaced Qt

cullmann added a comment. I think target_link_libraries is the right way to fix it, that's OK. I am not that into the QT_ macro magic, perhaps Volker can comment if that is ok ;) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18996 To: davschul, v

D18982: prevent assertion in regex load

cullmann added a comment. I can push that for you, which user to use? "David Schulz" REVISION DETAIL https://phabricator.kde.org/D18982 To: davschul, vkrause, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, sars

D18982: prevent assertion in regex load

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I assume Volker profiled it. I think it is ok to just check if the logging is on. 99% of the syntax definitions are anyways bundled and are checked by the indexer for such obvious fa

D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the

cullmann added a comment. In D18951#411715 , @nibags wrote: > I can add more examples in "autotests/input/highlight.php", for all the cases of languages ​​included That would be nice. REPOSITORY R216 Syntax Highlighting REVISION DETAI

D18995: Explicitly link against KAuth

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. OK, Thanks! REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D18995 To: apol, #kate, #frameworks, vkrause, cullmann Cc: cullmann, kwrite-deve

D18907: Handle the case if createSpeller is passed an unavailable language

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, thought lang ist still lang. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18907 To: ahmadsamir, sandsmark, cullmann, dhaumann Cc: dhaumann, cullmann, loh

D18948: CubeScript: fixes line continuation escape in strings

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-escape-cubescript REVISION DETAIL https://phabricator.kde.org/D18948 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-framew

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

cullmann updated this revision to Diff 51542. cullmann added a comment. I would propose this, OK for you? REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18746?vs=50913&id=51542 REVISION DETAIL https://phabricator.kde.org/D18746 AFFECTED FILE

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

cullmann commandeered this revision. cullmann edited reviewers, added: nibags; removed: cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18746 To: cullmann, #framework_syntax_highlighting, dhaumann, nibags Cc: kwrite-devel, kde-frameworks-devel, genn

D18734: Update octave.xml to Octave 4.2.0

cullmann added a comment. Good question: I added a minimal howto to the README.md: https://commits.kde.org/syntax-highlighting/9343341f91274f899f74b1ffe3fa260dadbc0978 Does that help you? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D1873

D18894: [RFC] General config interface

cullmann added a comment. First: the current framework for settings suck, I feel guilty. Second: I think a QVariant based approach would be nicer. I should think about how to do that best. Dominik, didn't you have some generic property stuff in your TikzKit? REPOSITORY R39 KTextE

D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the

This revision was automatically updated to reflect the committed changes. Closed by commit R216:33ad9cdec824: HTML: highlight JSX, TypeScript & MustacheJS code in the