On Thursday 02 January 2014 12:14:19 David Faure wrote:
TODO: get agreement on include/KF5/FrameworkName/{everything_here} and
convert all repos.
Done!
Make sure to update everything (ECM, all frameworks, plasma...) otherwise
you'll get compile errors. This is a good time to build from
point. Fix coming up.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
involved here and why they would work
differently in master and in next.
I'll do a full rebuild with cmake next, just to test.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel
have made things a bit simpler and more consistent :)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
On Saturday 04 January 2014 15:37:34 David Faure wrote:
I'll do a full rebuild with cmake next, just to test.
Built just fine locally. I'm stumped.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
and toolbars
Does oxygen animate any of that?
I'd be surprised, since these were already animated in Qt4.
What's new is letting users turn it off, via kstyle using kconfig.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
())
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
can use this to generate the entire
directory structure if you want.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
On Saturday 04 January 2014 16:53:42 David Faure wrote:
On Saturday 04 January 2014 15:37:34 David Faure wrote:
I'll do a full rebuild with cmake next, just to test.
Built just fine locally. I'm stumped.
OK it was a kde-build-metadata/dependency-data configuration issue,
it was grabbing
). Maybe don't even run the script, just run the
commands
one by one, to adapt them to your directory structure.
Once you have the clean new repo, you'll need to talk to sysadmin for uploading
it.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks
are off.
Are there plans to have a kdeglobals that has enabled effects?
As I said, it's a bug in the readEntry() call above. The default is supposed
to be 1, so you don't need a special kdeglobals.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE
On Sunday 05 January 2014 10:04:00 Hugo Pereira Da Costa wrote:
On 01/04/2014 11:21 PM, Dominik Haumann wrote:
On Saturday 04 January 2014 23:11:14 David Faure wrote:
On Saturday 04 January 2014 23:02:35 Dominik Haumann wrote:
On Saturday 04 January 2014 20:56:30 Hugo Pereira Da Costa wrote
On Saturday 04 January 2014 23:04:50 Nicolás Alvarez wrote:
2014/1/4 David Faure fa...@kde.org:
On Saturday 04 January 2014 23:02:35 Dominik Haumann wrote:
What I personally would like more is to always be able to read this.
I of course can use a KSharedConfig::openConfig() and then read
On Dec. 30, 2013, 12:31 p.m., David Faure wrote:
I don't really understand why this fails
IMHO it *did* make sense for the KToolBar unittest to check which icon size
the toolbars will get by default.
The value of 2 on build.kde.org, for instance, should never never happen. 2
, or that means
changes across the board in all frameworks.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
, you can just try it, see the instructions in that initial commit :-)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
it work better?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Sunday 05 January 2014 13:42:49 David Faure wrote:
I made and uploaded the tarballs (and zips) for the TP1 release.
Let's give the packagers a few days, and then we'll publish and announce the
release.
Meanwhile, no major changes in frameworks please, in case I need to redo
tarballs
isn't expected in debug mode.
- David Faure
On Jan. 7, 2014, 4:30 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114885
sure that all of these should be private? The ones that provide
classes that appear in the public API should be under LINK_PUBLIC.
set( katepart_PART_UI
)
unused, remove.
I tested the grafting, works fine.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular
from that wiki page, which
we can otherwise delete, no?
I guess I shall add all required frameworks to the
KF5TextEditorConfig.cmake.in, too, or?
Yes.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
(the stuff that allows compat
with kde4 APIs) - much like qt3support and kde3support in the old days.
No, this is about KDE4_* in extra-cmake-modules for instance. Or in any
CMakeLists.txt files.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks
that subdir, and committed.
It's a lib that provides API, not an integration plugin.
Hmm, but it installs a kpart, too, is that still ok?
Sure.
This doesn't change the basic rule:
Provide non-deprecated API - tier1/2/3.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE
On Jan. 7, 2014, 9:43 p.m., Alexander Neundorf wrote:
The motivation was that if somebody had set up carefully his install dirs
for kdelibs, he simply wanted to point a following project to the same
CMAKE_INSTALL_PREFIX, and have all the other install dirs automatically use
the same
) as
deprecated?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
it? ;-)
So you might just as well use file:/// or whatever.
- David Faure
On Jan. 9, 2014, 8:15 a.m., Frank Reininghaus wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114934/#review47142
---
Ship it!
Ship It!
- David Faure
On Jan. 10, 2014, 11:25
, or too many? Maybe check for 2, or adjust the error ... or check
both separately.
Also, this should be cerr, for error messages, as the name indicates.
src/kconfig_compiler/kconfig_compiler.cpp
https://git.reviewboard.kde.org/r/114937/#comment33592
return 1
- David Faure
On Jan. 10
wrong indentation, or is this just reviewboard being buggy?
- David Faure
On Jan. 10, 2014, 4:59 p.m., Bhushan Shah wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114937
/KNewStuff3/knewstuff3/entry.h
-- Up-to-date:
/d/kde/inst/kde_frameworks/include/KF5/KNewStuff3/knewstuff3/button.h
Looks nice and consistent to me (including consistent with the other
frameworks).
- David Faure
On Jan. 12, 2014, 8:15 p.m., Friedrich W. H. Kossebau wrote
forwarding headers for
compatibility.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
).
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114888/#review47300
---
Ship it!
Ship It!
- David Faure
On Jan. 13, 2014, 10:17
as well.
Yep.
Would update/prepare RRs for both kde4support and knewstuff modules, if I
got the proposal right and noone objects.
Sounds good to me.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
On Monday 13 January 2014 16:48:52 Nicolás Alvarez wrote:
2014/1/13 David Faure fa...@kde.org:
On Sunday 12 January 2014 19:59:26 Valentin Rusu wrote:
Hello,
Please be informed that I successfully imported the git history of
kwalletd from kde-runtime to kwallet-framework, the I ported
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115005/#review47371
---
Ship it!
Ship It!
- David Faure
On Jan. 13, 2014, 11:39
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114988/#review47383
---
Ship it!
Ship It!
- David Faure
On Jan. 13, 2014, 11:39
On Thursday 16 January 2014 17:57:51 Friedrich W. H. Kossebau wrote:
Am Mittwoch, 15. Januar 2014, 12:14:59 schrieb David Faure:
On Wednesday 15 January 2014 11:01:55 Friedrich W. H. Kossebau wrote:
Guess you already started to tackle that? :) Or should I give it a try
tonight?
Go
for the sake of consistency.
- David Faure
On Jan. 18, 2014, 3:47 a.m., Friedrich W. H. Kossebau wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115097
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115098/#review47627
---
Why does this remove some forwarding headers?
- David Faure
to me.
- David Faure
On Jan. 15, 2014, 12:21 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115024
.
Thanks,
David Faure
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
suppose]
- David Faure
On Jan. 17, 2014, 4:48 p.m., Jonathan Riddell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115065
On Jan. 19, 2014, 12:39 a.m., Luigi Toscano wrote:
The patch looks ago, I have two remarks:
- I think that kde5options should be kf5options (as it happened with
kde4-config - kf5-config)
- I'm not sure if the content of those manpages still applies. The special
options described
---
On Jan. 18, 2014, 11:02 a.m., David Faure wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115099
, this can involve kdeinit, but iirc it supports setting env
vars...)
(Even KCRASH_DISABLE isn't very descriptive technically; we don't disable the
fact that a crash handler gets called, but the launching of drkonqi from
there. But from a user point of view I guess that's all that matters).
--
David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115098/#review47725
---
Ship it!
Ship It!
- David Faure
On Jan. 19, 2014, 5:30
:)
KCRASH_DISABLE_DRKONQI is probably the only strictly-correct name.
Anyhow, naming is the easy part on to actually implementing it...
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel
://git.reviewboard.kde.org/r/115120/#comment33852
Remind me, who uses these desktop files?
Only the kde4support code, right?
- David Faure
On Jan. 19, 2014, 12:23 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply
, commit in a few days if no other
comments)
- David Faure
On Jan. 19, 2014, 1:21 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114908
the KNewPasswordDialog and
KPasswordDialog instances popping-up from the tests?
You can't do that, at least not portably nor easily.
It would be better to have a mode where the server replies prepared answers
*instead* of popping up a dialog.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working
differently - I added a
ignore-modules kapidox in kdesrc-build's include files.
And I don't like that this will break when using a custom prefix and PYTHONPATH
is not set (which is the case here).
- David Faure
On Jan. 21, 2014, 1:49 p.m., Aurélien Gâteau wrote
On Jan. 21, 2014, 2:57 p.m., David Faure wrote:
Note that I fixed the build failure with kdesrc-build differently - I
added a ignore-modules kapidox in kdesrc-build's include files.
And I don't like that this will break when using a custom prefix and
PYTHONPATH is not set (which
On Sunday 19 January 2014 20:56:23 David Faure wrote:
On Sunday 19 January 2014 20:44:48 Kevin Ottens wrote:
What about KCRASH_NO_CRASH_HANDLER ? It's long but it makes it at least
descriptive.
Except that it's not technically correct, a crash handler (= a function
called upon crashing
a more complete
fix, though.
- David Faure
On Jan. 21, 2014, 10:23 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115198
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115141/#review47986
---
Ship it!
Ship It!
- David Faure
On Jan. 20, 2014, 10:39
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115099/#review47948
---
On Jan. 18, 2014, 11:02 a.m., David Faure wrote:
---
This is an automatically
with qmake_test.pro saying:
QT += KArchive KJobWidgets KWidgetsAddons
SOURCES += main.cpp
- links to all the mentionned libs, including KCoreAddons (via KJobWidgets).
This requires $QMAKEPATH set to the kf5 install prefix.
Thanks,
David Faure
___
Kde
On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote:
Until now we had no problems with the data installed to bin/../share and
this setup would make it impossible to have multiple independent kde
setups on one system.
Alexander Richardson wrote:
I know. The problem is
you keep that patch locally for now and we try and come up with a
patch for Qt instead? We cannot restrict ourselves at that point I think.
Alexander Richardson wrote:
Sure no problem. I'll drop this request
David Faure wrote:
So what do you recommend instead, for QStandardPaths
a Qt fix or at least
bugreport?
- David Faure
On Jan. 22, 2014, 5:51 p.m., Alexander Richardson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115234
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115236/#review48093
---
Has this been compile-tested on Linux?
- David Faure
at many files with Okteta, but so for
not seen a file with a fraction byte ;)
Indeed. I wonder if this is historical from before qulonglong existed (you
know, a few minutes after the Big Bang, or 2001, in other words).
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115186/#review48257
---
Ship it!
Ship It!
- David Faure
On Jan. 21, 2014, 5:02
, but fixing it would be BIC, so yeah.
- David Faure
On Jan. 24, 2014, 4:13 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115300
(is a Qt option, move it there)
Add -stylesheet too
See QApplication class docu for these.
--geometry geometry
Sets the client geometry of the main widget.
Was from Qt. -geometry still works, on X11.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE
make sure we avoid wiki duplication.
Yeah, Alex, can you look into merging the two tables?
Then I'll go through and fill in info about the stuff I know about.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
for kio-based webbrowsers in any workspace.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
says it does.
Better make it a separate function.
- David Faure
On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115360/#review48514
---
Ship it!
Ship It!
- David Faure
On Jan. 28, 2014, 10:43
On Saturday 25 January 2014 16:36:22 Albert Astals Cid wrote:
El Dissabte, 25 de gener de 2014, a les 10:20:20, David Faure va escriure:
On Tuesday 21 January 2014 18:38:28 Jonathan Riddell wrote:
kdeoptions and qtoptions manpages listed the common options to
applications
using
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115415/#review48737
---
Ship it!
Oops, well spotted.
- David Faure
On Jan. 31
remember if I said that, and if so what I had in mind.
Compiling against a crippled framework and then missing the daemon for it to
work at runtime sounds a bit strange.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
, yes. And yes,
that is a hack, it would be much better not to do that in the first place...
- David Faure
On Jan. 27, 2014, 12:30 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/115424/#comment34420
There's never any reason for the tests/ subdir to use Qt5Test.
Qt5Test = library for autotests.
- David Faure
On Feb. 1, 2014, 6:28 p.m., Michael Palimaka wrote:
---
This is an automatically generated e
On Feb. 2, 2014, 9:36 a.m., David Faure wrote:
tests/CMakeLists.txt, lines 1-2
https://git.reviewboard.kde.org/r/115424/diff/1/?file=241204#file241204line1
There's never any reason for the tests/ subdir to use Qt5Test.
Qt5Test = library for autotests.
Michael
count, let's downgrade to 4.96.0 everywhere.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
On Monday 03 February 2014 11:34:44 Kevin Ottens wrote:
On Monday 03 February 2014 10:17:49 David Faure wrote:
Any new module that should be added to this release, compared to TP1?
Should I include attica?
Since this question keeps popping up, let's integrate it. It should also
because that
would break the Qt4 build scripts.
So, all KF5 hackers, please note that whenever making a change across all
frameworks you should also remember attica, outside your frameworks/ subdir.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks
On Thursday 06 February 2014 00:53:53 Frederik Gladhorn wrote:
On Thursday 6. February 2014 00.29.45 David Faure wrote:
Frederik wrote:
From my point of view, please just go ahead and change it as you think
is
sensible.
OK, thanks for the green lights, I went ahead:
* Qt4
? ('kdelibs' coding style, almost like the qt one)
- does it have a component on bugs.kde.org?
- does it exist on reviewboard.kde.org?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde
:-)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
interface (became dbus later) to be able to script
khtml (to automate lotto websites :).
It's fine to not install the dbus xml indeed, since I'm not aware of any app
using it.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
/*/CMakeLists.txt.
If it's needed that's fine, I adapted my scripts, but I'm just surprised.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
kstandardactiontest_automoc
man-preparetips5.1.docbook:5: warning: failed to load external entity
dtd/kdex.dtd
]
^
man-preparetips5.1.docbook:7: parser error : Entity 'language' not defined
refentry lang=language;
Did you set XDG_DATA_DIRS to contain yourkf5installprefix/share ?
--
David Faure, fa...@kde.org
On Thursday 06 February 2014 23:32:11 David Faure wrote:
On Wednesday 05 February 2014 22:42:00 Michael Palimaka wrote:
On 02/03/2014 08:17 PM, David Faure wrote:
Any new module that should be added to this release, compared to TP1?
I see that plasma-framework.yaml says tier 3
On Saturday 08 February 2014 10:55:25 Marco Martin wrote:
On Saturday 08 February 2014 10:31:10 David Faure wrote:
* it's not under frameworks/ in the projects.kde.org hierarchy. Shall we
move it?
* it declares itself to be version 2.0.0. Can I change that to 4.96.0
like
all
/readwritepart.h
Since there is no filename clash, what is the issue if these end up in the same
folder on Mac OSX?
- David Faure
On Feb. 7, 2014, 7:37 p.m., Harald Fernengel wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115524/#review49241
---
Ship it!
Ship It!
- David Faure
On Feb. 6, 2014, 10:35
.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Saturday 08 February 2014 11:36:26 Marco Martin wrote:
On Saturday 08 February 2014 10:59:19 David Faure wrote:
On Saturday 08 February 2014 10:55:25 Marco Martin wrote:
On Saturday 08 February 2014 10:31:10 David Faure wrote:
* it's not under frameworks/ in the projects.kde.org
btw:
commit 2702febc7474537b19d816a941261755b04798f4
Author: Aaron Seigo ase...@kde.org
cut off adding/removing activities at the source
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde
On Saturday 08 February 2014 14:13:40 Ivan Čukić wrote:
On Saturday, 8. February 2014. 12.58.53 David Faure wrote:
Also, kactivities is the only framework that still uses a branch named
frameworks.
Can we switch to master = kf5 and KDE/4.13 for the current master,
assuming
a 4.13
where to add a
if(BUILD_TESTING) around add_subdirectory(tests) and
add_subdirectory(autotests) :-)
- David Faure
On Feb. 8, 2014, 5:32 p.m., Michael Palimaka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Feb. 8, 2014, 5:34 p.m., David Faure wrote:
Looks good, but then you have 56 other frameworks where to add a
if(BUILD_TESTING) around add_subdirectory(tests) and
add_subdirectory(autotests) :-)
Michael Palimaka wrote:
That's fine, do I need to do a review request for all
On Feb. 8, 2014, 5:34 p.m., David Faure wrote:
Looks good, but then you have 56 other frameworks where to add a
if(BUILD_TESTING) around add_subdirectory(tests) and
add_subdirectory(autotests) :-)
Michael Palimaka wrote:
That's fine, do I need to do a review request for all
On Feb. 8, 2014, 10:07 a.m., David Faure wrote:
Urgh, we were hoping this wouldn't be an issue.
This commit would break #include attica/event.h, so it cannot go in.
All namespaced frameworks do it this way already btw, see kparts for
instance:
-- Up-to-date:
/d/kde/inst
PrivateDataParser
test (the class still exists, but is not exported and has a private parseXml
method; it could be exported for the test and the test class marked as friend,
for instance?).
sandsmark, can you confirm or deny removal of the autotest?
- David Faure
On Feb. 8, 2014, 7:52 p.m
by reviewboard
doesn't show that anywhere. It makes it look like Martin made that change.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
---BeginMessage---
---
This is an automatically generated e
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
---BeginMessage---
Well that was done for compatibility with what Firefox/Chromium.
The latest stable version (version 27) sends the following user agent
string:
Mozilla/5.0 (X11; Linux
301 - 400 of 6554 matches
Mail list logo
