On Sunday 16 March 2014 14:48:34 Treeve Jelbert wrote:
> kfiledialog.cpp:(.text.startup+0x47): undefined reference to
> `qt_filedialog_open_filenames_hook'
> kfiledialog.cpp:(.text.startup+0x54): undefined reference to
> `qt_filedialog_save_filename_hook'
Right. Fixed
like this code works on keycodes, not keysyms, so it basically ignores
my xmodmap configuration.
[*] keycode 133 = Meta_L Meta_L Meta_L Meta_L
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
If so, I'd suggest implementing solution 1 for the
> > general case, and then making a special construction function to handle
> > shared KConfig's. I don't want to avoid calling reparseConfiguration
> > without some warning around this, as it may again cause some
If so, I'd suggest implementing solution 1 for the
> > general case, and then making a special construction function to handle
> > shared KConfig's. I don't want to avoid calling reparseConfiguration
> > without some warning around this, as it may again cause some
> On March 16, 2014, 9:12 a.m., David Faure wrote:
> > src/kcrash.cpp, line 56
> > <https://git.reviewboard.kde.org/r/116087/diff/3/?file=254139#file254139line56>
> >
> > I just realized that this requires qpa-private headers, which is a
> > proble
ot;bool ok + qWarning" thing is a bit clumsy, maybe we want to port these
main() to qtestlib too, even though they are themselves executed by a unittest
:-)
Thanks,
David Faure
___
Kde-frameworks-devel mailing list
Kde-frameworks-deve
> On March 16, 2014, 9:12 a.m., David Faure wrote:
> > src/kcrash.cpp, line 56
> > <https://git.reviewboard.kde.org/r/116087/diff/3/?file=254139#file254139line56>
> >
> > I just realized that this requires qpa-private headers, which is a
> > proble
If so, I'd suggest implementing solution 1 for the
> > general case, and then making a special construction function to handle
> > shared KConfig's. I don't want to avoid calling reparseConfiguration
> > without some warning around this, as it may again cause some
without qtx11extras available, on Linux/X11.
Works.
Thanks,
David Faure
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
adConfig at
all. The singleton-generating code is just stupid, it all happens automatically
without a call to readConfig (except of course if apps wanted to reimplement
that...)
So DelayedParsing breaks the Test1 case (constructor, no explicit call to
readConfig/read). Yay for unittests.
- Davi
) to qtestlib too, even though they are themselves executed by a unittest
:-)
Thanks,
David Faure
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116895/#review53413
---
Ship it!
Ship It!
- David Faure
On March 19, 2014, 11:40
f the socks.
- David Faure
On March 20, 2014, 12:33 a.m., Alex Merry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116913/#review53478
---
Ship it!
Ship It!
- David Faure
On March 20, 2014, 12:28
ta-test it?
If nothing major came up, we'll switch lxr.kde.org to that new site.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-
On Thursday 20 March 2014 13:47:33 Bhushan Shah wrote:
> Hello,
>
> On Thu, Mar 20, 2014 at 1:43 PM, David Faure wrote:
> > Talking about LXR... I just finished setting up
> > http://lxrnew.kde.org/ident
> > Can you use it for your upcoming searches, to beta-test it?
&
it was my idea, I had forgotten :-)
Thanks!
- David Faure
On March 20, 2014, 6:30 p.m., Alex Merry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116914/#review53603
---
Ship it!
bye old code
- David Faure
On March 20, 2014, 6
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116927/#review53619
---
Ship it!
Ship It!
- David Faure
On March 20, 2014, 6:30
of QWidget
- David Faure
On March 19, 2014, 1 p.m., Michael Palimaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
just to make sure nothing got forgotten.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kd
On Wednesday 05 March 2014 10:44:24 Kevin Ottens wrote:
> Hello,
>
> On Tuesday 04 March 2014 22:54:42 David Faure wrote:
> > On Tuesday 04 March 2014 01:32:14 Michael Pyne wrote:
> > It wasn't that transparent at all - a number of modules have been re-
> > downl
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116894/#review53624
---
Ship it!
Ship It!
- David Faure
On March 19, 2014, 11:26
On Friday 22 November 2013 11:32:45 David Faure wrote:
> Which reminds me that we don't have a replacement for KCmdLineArgs::url(i)
> instead, i.e. a method that resolves "an absolute filename, a relative
> filename (given a CWD), or a URL" into a QUrl, for convenience.
compatibility and don't
need the mimetype definition.
- David Faure
On March 21, 2014, 6:07 p.m., Michael Palimaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
<https://git.reviewboard.kde.org/r/116935/#comment37700>
krazy will say .clear() is preferred (although in this case, we know the
string is not empty, so it amounts to the same).
- David Faure
On March 22, 2014, 1:27 p.m., Alex Merry
.
- David Faure
On March 21, 2014, 3:41 p.m., Alex Merry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
tps://git.reviewboard.kde.org/r/116938/#comment37719>
Missing @since 5.0
- David Faure
On March 21, 2014, 3:50 p.m., Alex Merry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.rev
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116934/#review53811
---
Ship it!
Ship It!
- David Faure
On March 23, 2014, 1:51
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116873/#review53813
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 3:47
ut that can be solved with bool
s_checkStampsDefault = true.
But anyway, no big deal.
- David Faure
On March 23, 2014, 1:29 p.m., Alex Merry wrote:
>
> ---
> This is an automatically generated e-mail. To r
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117005/#review53829
---
Ship it!
Ship It!
- David Faure
On March 23, 2014, 6:19
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117006/#review53830
---
Ship it!
Ship It!
- David Faure
On March 23, 2014, 6:25
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116966/#review53833
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 9:58
On Sunday 23 March 2014 17:33:46 Alex Merry wrote:
> On 23/03/14 14:55, Alex Merry wrote:
> > On 20/03/14 08:13, David Faure wrote:
> >> On Thursday 20 March 2014 00:28:44 Alex Merry wrote:
> >>> LXR says the only
> >>>
> >>> users a
tps://git.reviewboard.kde.org/r/116936/#comment37753>
funny iterator name ;)
- David Faure
On March 20, 2014, 8:48 p.m., Alex Merry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116937/#review53835
---
Ship it!
Ship It!
- David Faure
On March 20, 2014, 8:50
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116957/#review53838
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 5:05
more special
mimetypes. I'll do that.
- David Faure
On March 21, 2014, 5:09 p.m., Michael Palimaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53841
---
Ship it!
- David Faure
On March 21, 2014, 6:15 p.m., Alex
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117000/#review53850
---
Ship it!
Ship It!
- David Faure
On March 23, 2014, 4:45
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116967/#review53854
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 10:20
tps://git.reviewboard.kde.org/r/116959/#comment37758>
this if() isn't needed, already tested in the parent scope.
- David Faure
On March 21, 2014, 5:15 p.m., Alex Merry wrote:
>
> ---
> This is an automatically genera
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116968/#review53856
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 10:27
s mostly a TODO...)
- David Faure
On March 21, 2014, 10:51 p.m., David Gil Oliva wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.review
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116970/#review53858
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 11:06
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116971/#review53859
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 11:16
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116993/#review53860
---
Ship it!
Ship It!
- David Faure
On March 23, 2014, 2:18
hing is a bit clumsy, maybe we want to port these
main() to qtestlib too, even though they are themselves executed by a unittest
:-)
Thanks,
David Faure
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/
If so, I'd suggest implementing solution 1 for the
> > general case, and then making a special construction function to handle
> > shared KConfig's. I don't want to avoid calling reparseConfiguration
> > without some warning around this, as it may again cause some
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116995/#review53869
---
Ship it!
Ship It!
- David Faure
On March 23, 2014, 2:52
eviewboard.kde.org/r/117010/#comment37767>
Won't this break with MSVC?
- David Faure
On March 23, 2014, 11:11 p.m., Matthew Dawson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
the same patch to
your KDE4 installation, and testing these URIs.
Actually I wonder what these files are really good for, since they don't refer
to any executable ("helper") or kioslave. Check the logs, if you can't find any
helper or slave...
- David Faure
On Marc
er a dot" typography? I
thought that was only in old books.
src/plugin/kpluginloader.cpp
<https://git.reviewboard.kde.org/r/117112/#comment38093>
so obviousy I'm not sure it deserves a comment :)
- David Faure
ady installing things in /libexec
> (e.g. libexec/QtWebProcess). We probably want to do the same.
Qt is well known for NOT being relocatable (especially qmake), so I'm not sure
how much this example helps at all.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE,
e and instead, having the
info compiled into the plugin (using json)? This contradicts the commit log.
- David Faure
On March 28, 2014, 2:49 p.m., Alex Merry wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
is where it comes from and should be kept in sync.
Yes.
> I wonder how much of this functionality is now done in Qt5?
I'm not aware of a replacement for KCharsets::fromEntity() in Qt.
I.e. some code that can turn ñ into '~'.
--
David Faure, fa...@kde.org, http://www.davidfaure
libexec to your $PATH?
- David Faure
On March 24, 2014, 12:01 p.m., Dan Vrátil wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
://git.reviewboard.kde.org/r/101231/, and
indeed I agree with myself (big surprise) ;)
So go ahead.
- David Faure
On March 24, 2014, 1:51 p.m., Michael Palimaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
> On March 28, 2014, 2:13 p.m., David Faure wrote:
> > How does findExecutable() help at all? You plan on adding libexec to your
> > $PATH?
>
> Aleix Pol Gonzalez wrote:
> KStandardDirs::findExe used to look into libexec, IIRC.
>
> Maybe we c
/ :
this code is supposed to list the available translations. The new code doesn't
do that.
Is was using entry.desktop, maybe it can look up myapp.gmo files instead. But
it has to be based on what is actually installed.
- David Faure
On March 28, 2014, 11:50 a.m., Aleix Pol Gonzalez
8ec9cef7c68d2d995ceb85aa51839762b4406025
in kdelibs for the full story behind this. But if nobody ever used it, it
proves that it can be removed indeed.
- David Faure
On March 27, 2014, 6:42 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> T
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117070/#review54447
---
Ship it!
OK.
- David Faure
On March 25, 2014, 10:22 p.m
ithout the set capabilities thing.
I assume the same can be done with kcheckpass at some point too?
- David Faure
On March 27, 2014, 7:57 p.m., Hrvoje Senjan wrote:
>
> ---
> This is an automatically generated e-mail.
EROOT% won't do. Is
there any more standard way of doing this on Windows?
Even if it's just "relative to the executable" - we could let QStandardPaths
take care of that.
- David Faure
On March 23, 2014, 11:28 p.m., And
#x27;s about security. QtWebKit is no longer
> maintained by Digia and I am not aware that anybody stepped up to maintain
> it. Therefore web security vulnerabilities stay unfixed.
Well we can't deprecate both khtml and kdewebkit. What do we use then, right
now, to browse the web in a KDE ap
use .po/.gmo files
- different translation system.
Also doubly wrong because uiLanguages() returns the user preferences (e.g. for
me "en, fr"), which has nothing to do with "how many languages are actually
installed" (e.g. there could be about 54).
- David Faure
On March
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117137/#review54456
---
Ship it!
Ship It!
- David Faure
On March 28, 2014, 3:07
file looks for all deps --- even
if someone only needs KIOCore...
- David Faure
On March 28, 2014, 6:24 p.m., Michael Palimaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewb
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117135/#review54451
---
Ship it!
Ship It!
- David Faure
On March 28, 2014, 2:56
es kreadconfig and kwriteconfig) is going to be
> in plasma-workspace? Isn't it useful for every KConfig-based
> component/application? Maybe kde cli tools could be the target...
Yes, but only assuming that kde-workspace can then depend on kde-cli-tools at
runtime (since startkde uses
t;https://git.reviewboard.kde.org/r/117078/#comment38103>
Now that you have a QStringList, you can remove this "delete after the
fact". Just move the new + setItems into the if (userNames.size() < maxEntries)
- David Faure
> On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote:
> > What about QStandardPaths::findExecutable? Actually this one should look
> > into libexec too (at least the equivalent KStandardDirs::findExe used to).
>
> Alex Merry wrote:
> I'm pretty sure QStandardPaths won't look at libexec
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117074/#review54435
---
Ship it!
Ship It!
- David Faure
On March 26, 2014, 4:05
> On March 28, 2014, 3:51 p.m., David Faure wrote:
> > Same problem as https://git.reviewboard.kde.org/r/117132/ :
> > this code is supposed to list the available translations. The new code
> > doesn't do that.
> >
> > Is was using entry.desktop, maybe
this include:
kpluginfactory.h:30:#include // for source compat
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> > Thanks in advance for your answers.
>
> Hi Yuri,
> this is a good question also for kde-frameworks-devel@ (now in cc)
Yes the argument order was wrong, and this was fixed yesterday
(it was also detected by a unittest, by chance)
--
David Faure, fa...@kde.org, http://www.d
https://git.reviewboard.kde.org/r/117087/, so
go ahead.
- David Faure
On March 28, 2014, 7:20 p.m., Jonathan Riddell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
= old style = l10n means adapting to a country)
- David Faure
On March 28, 2014, 7:22 p.m., Jonathan Riddell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
On Saturday 29 March 2014 07:50:20 David Faure wrote:
> One thing will not be SC though: you'll have to remove this include:
> kpluginfactory.h:30:#include // for source compat
This bit is now out of the way (I added the include in all the code that was
relying on it, and removed i
d that be sensible?
Yes. But while at it, I would rename entry.desktop to country.desktop or
something, it's getting
really confusing with all the things called l10n and entry.desktop in here.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE F
mit log) + unittests in kconfig still pass.
Thanks,
David Faure
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
on't rename anything in
> the repositories, and also don't install these files at all. When it is
> decided how the language selection will work with KF5, revisit this matter.
Well, yes, but it's time to decide :-)
--
David Faure, fa...@kde.org, http://www.davidfaure
objections, if sebas and
ervin agree as well.
- David Faure
On March 30, 2014, 11:28 a.m., Alex Merry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
ided how the language selection will work with KF5, revisit this
> >> matter.
> >
> > [: David Faure :]
> > Well, yes, but it's time to decide :-)
>
> There I propose not to have language entry.desktop files any more :)
And, what do we use instead, to show the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117194/#review54647
---
Ship it!
Ship It!
- David Faure
On March 30, 2014, 10:05
t;CAN" or "COULD" in its own error
messages and descriptions. It actually manages to be much more precise about
the reason for the failure, not just "this call failed". Oh well :)
- David Faure
On March 31, 201
error: failed to push some refs to 'g...@git.kde.org:kde-workspace'
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
about this being removed without at least testing it in KDE4.
- David Faure
On April 1, 2014, 4:01 p.m., Alex Merry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> htt
g/r/117304/#comment38276>
the event loop is here.
- David Faure
On April 1, 2014, 4:01 p.m., Alex Merry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117313/#review55014
---
Ship it!
Ship It!
- David Faure
On April 1, 2014, 9:49
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117317/#review55015
---
Ship it!
Thanks!
- David Faure
On April 1, 2014, 10:34
d() method. That's vaguely on my
> to-do list somewhere...
You mean like this? :-)
https://codereview.qt-project.org/#change,82386
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
On Friday 28 March 2014 20:17:40 Markus Slopianka wrote:
> On Friday 28 March 2014 15:42:16 David Faure wrote:
> > Well we can't deprecate both khtml and kdewebkit. What do we use then,
> > right now, to browse the web in a KDE application?
>
> Deprecate does not mean t
On Wednesday 29 January 2014 12:47:02 Albert Astals Cid wrote:
> El Dimecres, 29 de gener de 2014, a les 09:25:47, David Faure va escriure:
> > On Saturday 25 January 2014 16:36:22 Albert Astals Cid wrote:
> > > El Dissabte, 25 de gener de 2014, a les 10:20:20, David Faure va
es
ocs/kbuildsycoca5/man-kbuildsycoca5.8.docbook
<https://git.reviewboard.kde.org/r/117320/#comment38384>
LOL, that was optimistic :)
- David Faure
On April 1, 2014, 11:32 p.m., Alex Merry wrote:
>
> ---
> This is an automatical
On Monday 24 March 2014 11:14:13 you wrote:
> On 23/03/14 19:51, David Faure wrote:
> > On Sunday 23 March 2014 17:33:46 Alex Merry wrote:
> >> On 23/03/14 14:55, Alex Merry wrote:
> >>> On 20/03/14 08:13, David Faure wrote:
> >>>> On Thursday 20 March
owerdevil, removing from list of packages to build.
> Conflicting source-dir present
-
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
documentation, I'm quite sure it refers
to kdebugdialog.
- David Faure
On April 5, 2014, 5:50 p.m., Michael Palimaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
.pri
file, dependency handling for users of your libs, forwarding headers,
versioning, releasing, etc. etc.).
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
___
Kde-frameworks-devel mailing list
601 - 700 of 7109 matches
Mail list logo
