Re: Split kde-baseapps?
On Sun, Feb 1, 2015 at 7:57 AM, David Narvaez david.narv...@computer.org wrote: On Mon, Jan 19, 2015 at 11:13 AM, David Narvaez david.narv...@computer.org wrote: On Mon, Jan 19, 2015 at 3:05 AM, David Faure fa...@kde.org wrote: I thought kio-about was going into kio-extras? Indeed, I just realized. This is now at g...@git.kde.org:clones/kio-extras/narvaez/kio-extras-about Could somebody check everything is in order so that I can push this merge into kio-extras? As in my other repo, this is meant to just transplant the code, I will then post RRs to make it compile. This is now in kio-extras. I'll post RRs to make the code compile etc. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Split kde-baseapps?
On Mon, Jan 19, 2015 at 11:13 AM, David Narvaez david.narv...@computer.org wrote: On Mon, Jan 19, 2015 at 3:05 AM, David Faure fa...@kde.org wrote: I thought kio-about was going into kio-extras? Indeed, I just realized. This is now at g...@git.kde.org:clones/kio-extras/narvaez/kio-extras-about Could somebody check everything is in order so that I can push this merge into kio-extras? As in my other repo, this is meant to just transplant the code, I will then post RRs to make it compile. Thanks. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Move thumbnail kioslave and thumbcreator service type to kio?
On Sun, Jan 18, 2015 at 2:38 PM, David Narvaez david.narv...@computer.org wrote: Coincidentially, I am transplanting a protocol into KIO right now, so I can do this move also. So this transplant required some heavier porting to KF5 and now I have a couple of questions about how to post this for review. Should I: A) 1) Post a clone repo with the transplant and wait for approval 2) Post a single RR with the KF5 port B) 1) Post a clone repo with the transplant and wait for approval 2) Post several RR with specific changes towards KF5 C) 1) Post a clone repo with the transplant and KF5 port all together A and B would mean I post a clone repo that has the thumbnail code but doesn't build it, the include_directory CMake instructions would come in A|B.2). David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Split kde-baseapps?
On Mon, Jan 19, 2015 at 3:05 AM, David Faure fa...@kde.org wrote: I thought kio-about was going into kio-extras? Indeed, I just realized. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Split kde-baseapps?
On Mon, Jan 5, 2015 at 3:27 AM, David Faure fa...@kde.org wrote: AFAIK there are two ways. One where you replay the history using git filter- branch, there's a wiki page about how to do this (iirc from Alex Merry). This is up at g...@git.kde.org:clones/kio/narvaez/kio-about-protocol Please review everything is in order. It says it is 49 commits different from kio: 47 commits from the git filter-branch'ed original repo, then the git mv, then the merge commit. You can check the history with $ git log --follow src/ioslaves/about/about.protocol Thanks to Alex Merry for the help. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Move thumbnail kioslave and thumbcreator service type to kio?
On Sun, Jan 18, 2015 at 9:16 AM, Bhushan Shah bhus...@gmail.com wrote: Thanks, can you do the move? as I have no knowledge of how to preserve history while doing so and stuff Coincidentially, I am transplanting a protocol into KIO right now, so I can do this move also. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Split kde-baseapps?
On Mon, Nov 10, 2014 at 4:46 PM, David Faure fa...@kde.org wrote: If it's useful to share it, let's share it, I have no objection to that. How should this be done? Can I just copy things around and post a RR or should be this moved around by one of our git curators to preserve history? David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Feedback on KDBusService::activateRequested
Hi, After working on the implementation of the unique mode in Rekonq[0], I have some (unsolicited) feedback about the activateRequested slot that I would like to share in case these issues can be addressed: Whenever I use libraries that deal with command line arguments my first question is whether they expect the first argument to be the name of the executable or not. For KDBusServices, it turns out that the answer is it depends, and I think that is almost never a good answer. For some context, the current behavior[1] is: - line 119: If the executable was called with more than one argument, send them all to the instance already running through a call to the CommandLine signal. - line 126: If the executable was called with just one argument (the executable name) call the Activate signal of the instance already running (effectively sending an empty list of arguments). At the other end, the receiver (which we can assume is using QCommandLineParser because this is Qt5 etc) always has to deal with the two cases because QCLP requires at least one argument and will crash if you pass an empty list of arguments. IMO, whenever all applications need to write the same boilerplate code - in this case if(arguments.size() 0) - that is already an indication of a bad API (see, e.g., [2]). In addition to that, one can argue that some info is lost: suppose you have a binary and several symlinks to that binary, and this binary decides what to do depending on the symlink used to call it (think of busybox). If this application was using KDBusService to implement Unique mode, then it would no longer know what the caller binary was. So my question woud be: is this behavior mandated by some standard? or can it be modified to always call CommandLine with the list of arguments? Thanks. David E. Narvaez [0] https://git.reviewboard.kde.org/r/120794/ [1] http://quickgit.kde.org/?p=kdbusaddons.gita=blobh=ea772hb=d8ff8f=src%2Fkdbusservice.cpp [2] http://lxr.kde.org/source/kde/workspace/plasma-workspace/plasma-windowed/plasmawindowedcorona.cpp?v=kf5-qt5#0103 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Split kde-baseapps?
On Sat, Oct 25, 2014 at 3:06 PM, David Narvaez david.narv...@computer.org wrote: It's also used by Rekonq and anything building a web browser using KDE software, it should really go to kioslave-extras. Any feedback on this? If it will not be moved to kioslave-extras I need to patch Rekonq to stop annoying me about the missing about protocol. Thanks. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Split kde-baseapps?
On Fri, Oct 10, 2014 at 5:07 PM, David Faure fa...@kde.org wrote: On Thursday 25 September 2014 01:01:27 Aleix Pol wrote: - kioslave/about: I guess it should go either to kioslave-extras or konqueror itself. I guess it's here because the applications use it, so kioslave. It's only used by Konqueror. It's also used by Rekonq and anything building a web browser using KDE software, it should really go to kioslave-extras. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KUnitConversion
On Wed, Aug 13, 2014 at 1:46 AM, Garret Wassermann gwas...@gmail.com wrote: A library that allows one to define new derived units in terms of base units and register them with the library would be really cool. it could be useful for anyone no matter how specialized the field, rather than having to update the library itself every time someone wants a new unit. I would also like to see a library that allows basic arithmetic with these units. Perhaps overloaded operators to allow one to add or multiply quantities and preserve the correct resulting units. Being able to for example set a = 2 kg, and b = 9.8 m/s^2, then type c = a * b and have the library know that c has the unit of Newtons now (or at least, know how to combine the units and show the resulting kg*m/s^2 and check that it is equivalent to a newton). It will be useful as a sanity check on my work, though I also see this being useful for more educational oriented software. There is what I consider a good design idea for such a library at http://www.stroustrup.com/Software-for-infrastructure.pdf written by someone that I think knows some stuff about C++. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Enabling Exceptions in CMake
On Mon, Aug 11, 2014 at 4:52 AM, Aleix Pol aleix...@kde.org wrote: Well, you can document it together with the funcion that enables exceptions at least. OK, documented at https://techbase.kde.org/index.php?title=Development/ECM_SourceIncompatChangesdiff=82951oldid=82898 David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Enabling Exceptions in CMake
Hi, I just noticed the old CMake line my project used to enable exceptions on a single file was not working and I dug into the ECM modules to find the correct way to do that. But I don't see exceptions mentioned in the ECM SIC page[0], should that documentation be there? i.e., is this considered an SIC? David E. Narvaez [0] https://techbase.kde.org/Development/ECM_SourceIncompatChanges ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KIcon - QIcon and KIconLoader
Hi, The migration script from KIcon to QIcon seems to think every usage of KIcon( ... ) is of the form KIcon( iconName ) but there's also KIcon( iconName, pointerToIconLoader ). What do I need to do to port those to QIcon? Thanks. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KIcon - QIcon and KIconLoader
On Fri, Jul 25, 2014 at 5:45 PM, Martin Klapetek martin.klape...@gmail.com wrote: You can do QIcon icon(new KIconEngine(iconName, pointerToIconLoader)); Thanks. I'll update the porting documentation and the porting script. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Porting KDialog::makeStandardCaption
Hi, What's the new way to do KDialog::makeStandardCaption[0] withot KDELibs4Support? Thanks. David E. Narvaez [0] http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKDialog.html#a765be466448a0212674700a8f843966e ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Porting: Installing Icons
On Thu, Jul 24, 2014 at 2:35 PM, Alex Merry alex.me...@kde.org wrote: As Jonathan said, yes, you are correct. And, yes, I should really write a porting script for that. Thanks for the confirmation, I just posted https://git.reviewboard.kde.org/r/119457/ David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Porting: Installing Icons
Hi, The information at [0] seems to indicate I just need to worry about renaming files to match the new categories (btw, is there a script for that?) but what I get from CMake Warning (dev) at /usr/share/ECM/modules/ECMInstallIcons.cmake:205 (message): ecm_install_icons() with no ICONS argument is deprecated Call Stack (most recent call first): icons/CMakeLists.txt:2 (ecm_install_icons) This warning is for project developers. Use -Wno-dev to suppress it. is that I need to update to # ecm_install_icons(ICONS icon [icon [...]] # DESTINATION icon_install_dir # [LANG l10n_code] # [THEME theme]) which seems to me like I need to explicitly list all icons in the dir, and # The given icons, whose names must match the pattern:: # # size-group-name.ext seems to indicate I need to rename all of the files to remove the theme from the prefix. Am I correct? Should I update the wiki with the complete oddyssey to a correct ecm_install_icions? David E. Narvaez [0] https://community.kde.org/Frameworks/Porting_Notes#Installing_Icons ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Porting: Installing Icons
On Wed, Jul 23, 2014 at 6:20 PM, Jonathan Riddell j...@jriddell.org wrote: # The given icons, whose names must match the pattern:: # # size-group-name.ext seems to indicate I need to rename all of the files to remove the theme from the prefix. Keep the theme name, preferably use hicolor for icons that are app specific. According to the documentation, that now goes to the THEME option? Am I correct? Should I update the wiki with the complete oddyssey to a correct ecm_install_icions? Maybe list it at https://techbase.kde.org/Development/ECM_SourceIncompatChanges Will do. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Build failed in Jenkins: kde4support_master_qt5 #32
On Fri, Jan 24, 2014 at 7:37 AM, Aleix Pol aleix...@kde.org wrote: I recreated my build directories and now I'm hitting it too. I guess it a matter of time that it spreads to the rest of who are building kde4support... I tried with cmake 2.8.12.1 and today's master. I'm on this, will provide my findings (and hopefully patches) soon. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Build failed in Jenkins: kde4support_master_qt5 #31
On Wed, Jan 22, 2014 at 3:28 AM, KDE CI System n...@kde.org wrote: In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3socketaddress.cpp:45:0: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/netsupp.h:168:8: error: redefinition of ‘struct addrinfo’ In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/netsupp.h:30:0, from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/k3socketaddress.cpp:45: /usr/include/netdb.h:567:8: error: previous definition of ‘struct addrinfo’ make[2]: *** [src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3socketaddress.cpp.o] Error 1 http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kcmdlineargs.cpp:654:66: note: #pragma message: KDE5 TODO: Remove this method once it is in Qt5 http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kcmdlineargs.cpp: In static member function ‘static void KCmdLineArgsStatic::parseAllArgs()’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kcmdlineargs.cpp:890:60: note: #pragma message: KDE5 TODO: use kcoreaddons version number http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kcmdlineargs.cpp: In static member function ‘static void KCmdLineArgs::enable_i18n()’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kcmdlineargs.cpp:1058:55: note: #pragma message: KDE5 NOTE: What about this method ? In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/netsupp.cpp:45:0: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/netsupp.h:168:8: error: redefinition of ‘struct addrinfo’ In file included from http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/netsupp.cpp:36:0: /usr/include/netdb.h:567:8: error: previous definition of ‘struct addrinfo’ make[2]: *** [src/CMakeFiles/KF5KDE4Support.dir/kdecore/netsupp.cpp.o] Error 1 http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kurl.cpp: In member function ‘void KUrl::setPath(const QString)’: http://build.kde.org/job/kde4support_master_qt5/ws/src/kdecore/kurl.cpp:1644:72: note: #pragma message: KDE5 TODO: Remove tildeExpand feature for local paths make[1]: *** [src/CMakeFiles/KF5KDE4Support.dir/all] Error 2 make: *** [all] Error 2 I came across this build error and spent some time trying to fix it. While I didn't find a proper fix, I'm sharing my findings since I see it is still red in Jenkins and I have no more time to spend on this: The addrinfo struct defined in netsupp.h wouldn't be defined if the addrinfo struct from /usr/include/netdb.h was properly detected, but it is not properly detected because when CMake tries to find it through try_compile, the compilation has the -std=iso9899:1990 flag, which is set in ECM (KDECompilerSettings.cmake). I removed that flag and reinstalled ECM, then tried building KDE4Support again and it works. Questions that are left unanswered are what changed that caused this error and, of course, how to fix it properly. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: cyclic dependency kinit - kservice
On Fri, Oct 25, 2013 at 11:37 AM, Kevin Ottens er...@kde.org wrote: Not that I know of, Alex never replied to that I think... What would be a proper fix for this? Separating kbuildsycoca and putting it on top of kinit? David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: cyclic dependency kinit - kservice
On Mon, Oct 21, 2013 at 12:08 PM, Kevin Ottens er...@kde.org wrote: On Monday 21 October 2013 17:01:44 Treeve Jelbert wrote: kinit needs kservice and installs KInitMacros.cmake which defines kf5_add_kdeinit_executable which is needed by kservice/kbuildsycoca Well, spotted, missed that one in the review. Alex could you look into solving this cycle? Thanks in advance. Has this been addressed/fixed? David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Removing the KFileMetadataWidget
On Mon, Sep 30, 2013 at 11:14 AM, Vishesh Handa m...@vhanda.in wrote: I'm planning on removing KFileMetaDataWidget completely, and marking it as deprecated in kdelibs4. Applications which still use it (Konversation and KGet) can start using Nepomuk::FileMetaDataWidget which offers the same api. I'll port KGet to Nepomuk::FileMetaDataWidget this week and put you in the review. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
