This revision was automatically updated to reflect the committed changes.
Closed by commit R216:f521183c4cc2: Highlighting indexer: Enable errors
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9377?vs=24027&id=24028
REVISIO
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Erros include:
- missing contexts
- duplicate contexts
- missing itemDatas
- missing keyword
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:412f5a7e705c: Highlighting indexer: report unused
itemDatas and missing itemDatas (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6b9c12981391: Lilypond, MetaFont, RHTML: Fix
missing/unused itemDatas (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9375?vs=240
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9cdf1bee0dd3: Prolog, RelaxNG, RMarkDown: Fix
highlighting issues (authored by dhaumann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9376?vs=24023&id=24024#toc
REPOSITORY
R216 Syntax Hig
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixRemaining (branched from master)
REVISION DETAIL
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixMoreXmlFiles (branched from master)
REVISION DET
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
With this patch, all issues are revealed, and not only missing itemDatas.
TEST PLAN
make test
REPOSI
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:91ca8ca39f66: Haml: Fix invalid and unused itemDatas
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9373?vs=24017&id=24018
REVI
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixHaml (branched from master)
REVISION DETAIL
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b80748a58293: ObjectiveC++: Remove duplicate comment
contexts (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9372?vs=24014&id=24
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The context "Commentar 1" was the same as "SingleLineComment".
The context "Commentar 2" was the same
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:da6d5a7cc33a: Diff, ObjectiveC++: Cleanups and fix
highlighting files (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9371?vs=240
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixDiff (branched from master)
REVISION DETAIL
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:00cbdc0fdc7d: Stata highlighting: Remove unused itemData
and fix non-existing attribute (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kd
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixStata (branched from master)
REVISION DETAIL
h
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b58763275dfd: XML (Debug): Fix incorrect DetectChar rule
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9369?vs=24007&id=24008
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The fix is to simply remove the parts of the char that were
ignored anyways. Whether this is the corre
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ec49a95d0959: Highlighting Indexer: Support cross-hl
context checking (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9361?vs=240
dhaumann updated this revision to Diff 24003.
dhaumann added a comment.
Cleanups
- ContextChecker::check(): use 'success' bool correctly (was unused before)
- remove m_ for member variables in the Language helper class
- turn firstContext into a bool and immediately add the first conte
dhaumann added a reviewer: cullmann.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D9361
To: dhaumann, vkrause, cullmann
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Previously, context references of the form "Comment##C++" were ignored.
With this patch, context cross
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
From my side this looks good. A second OK is always better, but I'd be OK if
you go ahead. Thanks for the ping!
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9217
To:
dhaumann updated this revision to Diff 23782.
dhaumann added a comment.
- Honor spacing for message widgets
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9257?vs=23781&id=23782
BRANCH
MessageInterface (branched from master)
REVISION DETAIL
https:/
dhaumann updated this revision to Diff 23781.
dhaumann added a comment.
- Remove unneeded include
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9257?vs=23780&id=23781
BRANCH
MessageInterface (branched from master)
REVISION DETAIL
https://phabricat
dhaumann updated this revision to Diff 23780.
dhaumann added a comment.
- Simplify MessageWidget member variable handling
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9257?vs=23655&id=23780
BRANCH
MessageInterface (branched from master)
REVISION DE
dhaumann added a comment.
@cullmann Did you intentionally request changes or was that by accident and
you meant Accept?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9219
To: dhaumann, cullmann, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann,
dhaumann added a comment.
@mwolff I still would like to know from you whether you think this patch
makes thinks better: I need additional helper functions etc. just to use the
STL to avoid these allocs. Additional helper functions are added complexity,
since it's not standard Qt stuff that e
dhaumann added a comment.
Btw: To update the reference, you can simply execute
build/frameworks/syntax-highlighting/autotests/update-reference-data.sh
Note, this script is in your *build* folder (not the git checkout folder).
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
dhaumann created this revision.
dhaumann added reviewers: cullmann, neundorf.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch extends the message interface to support CenterInView.
This should be binary
dhaumann added a comment.
Well, the scripting commands are also available on the command line as
commands, aren't they? So you could essentially call yourself.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9247
To: dhaumann, cullmann, mwolff, kfunk
Cc: #framewo
dhaumann retitled this revision from "Extend Scripting API to allow executong
commands" to "Extend Scripting API to allow executing commands".
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9247
To: dhaumann, cullmann, mwolff, kfunk
Cc: #frameworks, kevinapavew, ngr
dhaumann edited the summary of this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9247
To: dhaumann, cullmann, mwolff, kfunk
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
On Fri, Dec 8, 2017 at 10:21 AM, Ben Cooksley wrote:
> On Wed, Dec 6, 2017 at 9:24 PM, David Faure wrote:
>> On lundi 4 décembre 2017 18:38:50 CET Ben Cooksley wrote:
>>> If someone has a list of common font packages for SUSE then I can add
>>> those to the image relatively easy, which will proba
dhaumann created this revision.
dhaumann added reviewers: cullmann, mwolff, kfunk.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch adds the following JavaScript API:
object view.executeCommand(String
dhaumann added a comment.
I was just testing this. With this patch, a non-existing ~/test:
1. Dolphin goes to /home/dh/test, and a red box tells the folder does not
exist. This is better than the protocol-error message, so
https://bugs.kde.org/show_bug.cgi?id=372813 should be fixed.
2.
dhaumann added a reviewer: gregormi.
REVISION DETAIL
https://phabricator.kde.org/D9217
To: dfaure, emateli, elvisangelaccio, gregormi
Cc: broulik, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:f78b2e533fc1: Remove unused keyword lists and contexts
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9214?vs=23530&id=23579
RE
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:f930d6dbc399: Pony: Remove unused keyword lists (authored
by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9212?vs=23527&id=23578
REVISION
dhaumann created this revision.
dhaumann added reviewers: cullmann, mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch extends the KTextEditor scripting API by:
- String editor.clipboardText()
dhaumann marked 4 inline comments as done.
dhaumann added a comment.
Mark some comments as done.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9175
To: dhaumann, cullmann, kfunk, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
dhaumann updated this revision to Diff 23538.
dhaumann marked 3 inline comments as done.
dhaumann added a comment.
- Minor updates to the patch.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9175?vs=23437&id=23538
BRANCH
QRegExpCleanup2 (branched fro
dhaumann marked 5 inline comments as done.
dhaumann added a comment.
Update patch comes in a second.
INLINE COMMENTS
> mwolff wrote in katebookmarks.cpp:129
> static?
I don't think this is critical. Maybe it's even better to not have it static,
since otherwise it'll lurk around until applic
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:273e2f26fb55: email.xml: add *.email to the extensions
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8782?vs=22251&id=23531
RE
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Mostly just removed, some commented out where it seemed more appropriate.
TEST PLAN
make test
REPOSI
dhaumann closed this revision.
dhaumann added a comment.
Committed with
https://cgit.kde.org/syntax-highlighting.git/commit/?id=bb939b4ace0213b822383e23cd15719ad9b4242d
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D9186
To: dhaumann, vkrause
Cc: #frame
dhaumann created this revision.
dhaumann added reviewers: jpoelen, jpoelen2, vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Comment out currently unused keyword lists to
avoid having dead code lying around. O
dhaumann created this revision.
dhaumann added a reviewer: mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I had to add a helper function to avoid messy
STL iterator code everywhere. Not an ideal solution,
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:eb0bdd49417c: QStringList initializer list cleanup
(authored by dhaumann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9205?vs=23518&id=23525
REVISION DETAIL
dhaumann added a comment.
@mwolff I have a separate patch where I use STL algos in katedocument. I
would like to keep this as separate patch, though. So is this change fine now?
make test still passes.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9205
To:
dhaumann updated this revision to Diff 23518.
dhaumann added a comment.
Use initializer_lists directly
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9205?vs=23513&id=23518
BRANCH
QStringListCleanup (branched from master)
REVISION DETAIL
https://ph
dhaumann created this revision.
dhaumann added a reviewer: mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Simple cleanup of QStringList{...}
TEST PLAN
make test
REPOSITORY
R39 KTextEditor
BRANCH
QS
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:f9dbd24e80b7: Migrate some QRegExps to QRegularExpression
(authored by dhaumann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9168?vs=23491&id=23506#toc
REPOSITORY
R39 KTextEditor
CHANGES
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1c0667ac6af8: Highlighting Indexer: Check for infinite
loops (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9202?vs=23504&id=235
dhaumann updated this revision to Diff 23504.
dhaumann added a comment.
missing return true statement
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9202?vs=23503&id=23504
BRANCH
CheckLookAhead (branched from master)
REVISION DETAIL
https:
dhaumann updated this revision to Diff 23503.
dhaumann added a comment.
Fixed typo
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9202?vs=23502&id=23503
BRANCH
CheckLookAhead (branched from master)
REVISION DETAIL
https://phabricator.kde.o
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The infinite loop check looks for a lookAhead="true" in combination
with context="#stay". This would p
dhaumann marked an inline comment as done.
dhaumann added a comment.
Update patch.
INLINE COMMENTS
> mwolff wrote in katecmds.cpp:502
> static?
I do not think static is needed here: When you invoke the command line (F7),
and type 'char 0x123', then creating a QRegularExpression will not be
dhaumann updated this revision to Diff 23491.
dhaumann marked 4 inline comments as done.
dhaumann added a comment.
Remove one usage of QRegularExpression
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9168?vs=23488&id=23491
BRANCH
QRegExpCleanup (bran
dhaumann updated this revision to Diff 23488.
dhaumann added a comment.
Fix remarks by Milian.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9168?vs=23424&id=23488
BRANCH
QRegExpCleanup (branched from master)
REVISION DETAIL
https://phabricator.kd
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:fce0f06fb8b3: Highlighting Indexer: Check for empty
context names and regexps (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D918
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Warn about empty contexts of the form context="".
Warn about empty RegExps String="".
And fix the is
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Some contexts are commented out since they are used in commented
out rules. Besides that, contexts tha
dhaumann added a comment.
Looks already pretty just. I just stumbled over two issues which maybe should
be clarified - see comments.
INLINE COMMENTS
> kiconeffect.cpp:163
> +
> +if (state == Colorize || effectGroupState == ToMonochrome) {
> +cached += QLatin1Char(':') + d
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:792c9cb03888: Fix typo in namespace (authored by
dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9164?vs=23416&id=23443
REVISION DETAIL
htt
Hi frameworks-devs,
since some time we have several unit tests that fail in the
KTextEditor framework:
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/11/testReport/
It sesms all these issues are related to changes in the font, could that be?
It even seems that asking fo
dhaumann created this revision.
dhaumann added reviewers: cullmann, kfunk, mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Please make a careful review. Many of these code
changes are most likely not touch
dhaumann created this revision.
dhaumann added reviewers: cullmann, kfunk, mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Please make a careful review. Many of these code
changes are most likely not touch
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
There is an obvious typo in the namespace.
I do not know, though, where this string is used.
So what
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c59eedfa9087: Add API documentation about Search Paths
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9157?vs=23401&id=23415
RE
dhaumann added a comment.
Please test the following:
1. load an existing file in kwrite: kwrite myFile
2. touch it on console, e.g. echo "asdf" >> myFile
3. Now a message widghet should appear on top of the view with a notification
text.
4. This is animated. Is the final size correc
dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Currently, the search procedure for Definitions is:
1. $XDG_DATA_HOME/org.kde.syntax-highl
dhaumann closed this revision.
dhaumann added a comment.
This was committed with:
https://cgit.kde.org/syntax-highlighting.git/commit/?id=e5f5db6719681edb1aa3c442e10ab62615ebb5b4
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D9154
To: dhaumann, vkrause
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Just some minor cleanups.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixUnu
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a44fdbcdb319: Highlighting Indexer: Warn about unused
itemDatas (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9153?vs=23382&id=
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Current list looks like follows:
Unused itemDatas:
- "syntax/4dos.xml": QSet("Path")
- "syntax/
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a640eee5a2a1: Fix referencing of non-existing keyword
lists (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9146?vs=23370&id=2337
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
There are still some left (e.g. qml.xml) which need a fix later.
TEST PLAN
make test
REPOSITORY
R2
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a5ffeaa46d86: Fix simple cases of duplicate contexts
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9143?vs=23366&id=23369
REVI
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Other issues still exist, but need more careful investigation.
TEST PLAN
make && make test
REPOSITOR
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1f2f650f4fc8: Fix duplicate itemDatas (authored by
dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9142?vs=23363&id=23364
REVISION DETAIL
h
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Remove duplicate itemData entries.
TEST PLAN
make && make test
REPOSITORY
R216 Syntax Highlighting
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:7df4bda956d7: Fix DetectChar and Detect2Chars rules
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9140?vs=23361&id=23362
REVIS
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
These rules are allowed to have only one char.
TEST PLAN
make && make test
REPOSITORY
R216 Syntax
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:cd7f2837aad1: Try detecting unused contexts (authored by
dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9139?vs=23352&id=23356
REVISION DETA
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Try detecting unused contexts. This is only a heuristic,
since a context might be cross-included via I
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:463dfc78b4be: Highlighting Indexer: Check keyword lists
(authored by dhaumann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9137?vs=23348&id=23350#toc
REPOSITORY
R216 Syntax Highlighting
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This check includes:
- warn about duplicate keyword list
- warn about missing keyword list
- wa
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:621e282acbcb: Highlighting Indexer: Warn about duplicate
contexts (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9132?vs=23341&i
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Warn, if two contexts have the same name.
Currently, we have the following issues:
ContextChecker
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6b7cd0c8735a: Highlighting Indexer: Check for duplicate
itemDatas (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9129?vs=23335&i
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Check for duplicate itemData entries during indexing.
Currently, there are the following duplicates
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9d30439abda8: Highlighting indexer: Check DetectChar and
Detect2Chars (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9127?vs=233
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Raise a warning on the console in case of DetectChar or
Detect2Chars have more that one char contents.
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2b8b664e15c0: Validate that for all attributes an
itemData exists (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9125?vs=23329&i
dhaumann abandoned this revision.
dhaumann added a comment.
Abandoned in favor of https://phabricator.kde.org/D9125.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D8662
To: dhaumann, vkrause, cullmann
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch adds a check at compile time that verifies that for
all refereced attributes an itemData it
dhaumann added a comment.
In general this patch should be OK.
Could you try with Kate search warp behavior as well? KTextEditor relies on
correct behaviors here heavily.
INLINE COMMENTS
> kmessagewidgetautotest.cpp:32-40
> +#define CHECK_FULLY_VISIBLE \
> +QVERIFY(w.isVisible()); \
> +
dhaumann closed this revision.
dhaumann added a comment.
Committed:
https://cgit.kde.org/syntax-highlighting.git/commit/?id=105aca796ffbfebc4ffed4581f1cf69a531da996
Thanks for the patch!
INLINE COMMENTS
> bash.xml:11
> ]>
> - extensions="*.sh;*.bash;*.ebuild;*.eclass;*.nix;.bashrc;.bas
dhaumann accepted this revision.
dhaumann added a comment.
Can you commit yourself?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D8782
To: genethomas, vkrause, dhaumann
Cc: dhaumann, vkrause, #frameworks
901 - 1000 of 1384 matches
Mail list logo
