Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

-d49c0cf656e1__Spectacle.E12435.png After: no wasted space in the first messagewidget https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png Thanks, Elvis Angelaccio

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

marked as submitted. Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David Edmundson. Changes --- Submitted with commit 1076908c344674d2be4f4825f18f6f3900a09620 by Elvis Angelaccio to branch master. Repository: kwidgetsaddons Description --- Currently it's

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

e https://git.reviewboard.kde.org/media/uploaded/files/2016/11/15/25c50bd2-aa00-42ea-b9b5-38f3d1abddff__Spectacle.d20127.png After: hidden checkbox is hidden https://git.reviewboard.kde.org/media/uploaded/files/2016/11/15/815551e3-9987-4851-8025-50d44989f600__Spectacle.W20858.png Than

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

the first group to the second one (skipping the 7 checkboxes in the first group). Thanks, Elvis Angelaccio

Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

make sure the tab-focus goes from the first group to the second one (skipping the 7 checkboxes in the first group). Thanks, Elvis Angelaccio

Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox

- Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129389/#review100824 --- On Nov. 13, 2016, 11:33 a.m., Elvis Angelac

Re: Review Request 129390: KRecentFilesAction: remove unnecessary copy

To reply, visit: https://git.reviewboard.kde.org/r/129390/#review100814 ------- On Nov. 13, 2016, 11:45 a.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated

Re: Review Request 129390: KRecentFilesAction: remove unnecessary copy

/129390/diff/ Testing --- All tests pass. Thanks, Elvis Angelaccio

Review Request 129390: KRecentFilesAction: remove unnecessary copy

f09bf6349e5b98999373d762fdbc4fd3a1f8e8f4 autotests/krecentfilesactiontest.cpp 1ba100dd1a8b5295e28c436157283e4f493563cd src/krecentfilesaction.cpp 7ffe2e7b75e028346af3215dada8e96ea940d65b Diff: https://git.reviewboard.kde.org/r/129390/diff/ Testing --- All tests pass. Thanks, Elvis Angelaccio

Review Request 129389: KRecentFilesAction: improve addUrl() apidox

c13c81f8e3c334e3efe229c8befcc50be37a75a0 Diff: https://git.reviewboard.kde.org/r/129389/diff/ Testing --- Thanks, Elvis Angelaccio

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

sing Shift+Del in Gwenview now works as expected. Thanks, Elvis Angelaccio

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

> On Oct. 31, 2016, 6:50 p.m., Elvis Angelaccio wrote: > > src/kxmlguiwindow.cpp, line 327 > > <https://git.reviewboard.kde.org/r/129299/diff/1/?file=483570#file483570line327> > > > > I think it would be better if this were not blocking (i.e. creat

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

erwise the users get a messagebox instead of the main window of the app they started. - Elvis Angelaccio On Oct. 31, 2016, 5:24 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 129275: StoredTransferJob: add failing test case

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 36e730f22480ea7f4bb425ddfcc5ad6da445cfcd by Elvis Angelaccio to branch master. Repository: kio Description --- https://bugs.kde.org/show_bug.cgi?id=368314 seems to be an actual

Re: Review Request 129275: StoredTransferJob: add failing test case

autotests/jobtest.cpp 11bac4d51e97840181aff99fdddb92cdf4db1ba2 src/core/storedtransferjob.h 82ffe77eec9d37af3b3bad81a3515d31eb5d4e94 Diff: https://git.reviewboard.kde.org/r/129275/diff/ Testing --- jobtest still passes (with one expected failure). Thanks, Elvis Angelaccio

Re: Review Request 129275: StoredTransferJob: add failing test case

autotests/jobtest.cpp 11bac4d51e97840181aff99fdddb92cdf4db1ba2 src/core/storedtransferjob.h 82ffe77eec9d37af3b3bad81a3515d31eb5d4e94 Diff: https://git.reviewboard.kde.org/r/129275/diff/ Testing --- jobtest still passes (with one expected failure). Thanks, Elvis Angelaccio

Re: Review Request 129275: StoredTransferJob: add failing test case

/ Testing --- jobtest still passes (with one expected failure). Thanks, Elvis Angelaccio

Re: Review Request 129275: StoredTransferJob: add failing test case

hing that the job should do or the clients should do before calling KIO::storedPut()? - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/#review100384 ------

Re: Review Request 129275: StoredTransferJob: add failing test case

) - autotests/jobtest.h 5687b4a448d26d703d33603e5a0939bc4f8c77b4 autotests/jobtest.cpp 11bac4d51e97840181aff99fdddb92cdf4db1ba2 Diff: https://git.reviewboard.kde.org/r/129275/diff/ Testing --- jobtest still passes (with one expected failure). Thanks, Elvis Angelaccio

Re: Review Request 129275: StoredTransferJob: add failing test case

rd.kde.org/r/129275/#review100373 --- On Oct. 28, 2016, 3:28 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 129275: StoredTransferJob: add failing test case

://git.reviewboard.kde.org/r/129275/diff/ Testing --- jobtest still passes (with one expected failure). Thanks, Elvis Angelaccio

Re: Review Request 129222: ClipboardUpdater: fix crash on Wayland

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 722f735396107bc9ad77165f3e9471fdc67b6878 by Elvis Angelaccio to branch master. Bugs: 370520 https://bugs.kde.org/show_bug.cgi?id=370520 Repository: kio Description

Re: Review Request 129262: Properly finish DropJobs when triggered is not emitted

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 508720091088bb605fb153b3b547fd2cc7a130f4 by Elvis Angelaccio to branch master. Bugs: 363936 https://bugs.kde.org/show_bug.cgi?id=363936 Repository: kio Description

Re: Review Request 129223: ClipboardUpdater: fix another crash on Wayland

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit dd0d703e355bad9392b086f255f14ad8b7196f6c by Elvis Angelaccio to branch master. Bugs: 359883 https://bugs.kde.org/show_bug.cgi?id=359883 Repository: kio Description

Re: Review Request 129262: Properly finish DropJobs when triggered is not emitted

to do this... Diffs (updated) - src/widgets/dropjob.cpp f033bfb5318624836d8b83c6783cf998990dcc02 Diff: https://git.reviewboard.kde.org/r/129262/diff/ Testing --- Make sure https://bugs.kde.org/show_bug.cgi?id=363936 is fixed. Thanks, Elvis Angelaccio

Review Request 129262: Properly finish DropJobs when triggered is not emitted

/widgets/dropjob.cpp f033bfb5318624836d8b83c6783cf998990dcc02 Diff: https://git.reviewboard.kde.org/r/129262/diff/ Testing --- Make sure https://bugs.kde.org/show_bug.cgi?id=363936 is fixed. Thanks, Elvis Angelaccio

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

> On Oct. 24, 2016, 11 a.m., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

.kde.org/r/129251/#review100230 --- On Oct. 24, 2016, 10:47 a.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

on: https://bugs.kde.org/show_bug.cgi?id=347373#c2 Diffs - src/gui/kstandardshortcut.cpp 92eb091382c7ab2110240cef21f29268be787250 Diff: https://git.reviewboard.kde.org/r/129251/diff/ Testing --- Using Shift+Del in Gwenview now works as expected. Thanks, Elvis Angelaccio

Re: Review Request 129188: Add documentation for the GenerateProperties option

s not needed? > > Looks the kind of thing that will generate crazy errors, hard to figure out. > > Elvis Angelaccio wrote: > It won't compile without (unless I'm doing something wrong). > GenerateProperties adds "include xxx.moc" in the generated xxx.cpp file, but

Re: Review Request 129188: Add documentation for the GenerateProperties option

marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Changes --- Submitted with commit 3a7b8ae9c9b151c20e7b1f9d7f01aa2013a9b25f by Elvis Angelaccio to branch master. Repository: kconfig Description --- The `GenerateProperties` option is missing from: https

Review Request 129223: ClipboardUpdated: fix another crash on Wayland

... Diffs - src/widgets/clipboardupdater.cpp a459aa777ae5bc328cf8807827ed24ddaf952d6d Diff: https://git.reviewboard.kde.org/r/129223/diff/ Testing --- Thanks, Elvis Angelaccio

Review Request 129222: ClipboardUpdater: fix crash on Wayland

Diff: https://git.reviewboard.kde.org/r/129222/diff/ Testing --- Thanks, Elvis Angelaccio

Re: Review Request 129188: Add documentation for the GenerateProperties option

://git.reviewboard.kde.org/r/129188/#review100043 ------- On Oct. 15, 2016, 9:31 a.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 129188: Add documentation for the GenerateProperties option

b9606f1d157229a22afbeaea7d56ee95732762a2 Diff: https://git.reviewboard.kde.org/r/129188/diff/ Testing --- Thanks, Elvis Angelaccio

Review Request 129188: Add documentation for the GenerateProperties option

: https://git.reviewboard.kde.org/r/129188/diff/ Testing --- Thanks, Elvis Angelaccio

Re: Review Request 129172: kioexec: use friendly names

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 29e49857b9746e484b9a77fbd96b982766deb5d3 by Elvis Angelaccio to branch master. Repository: kio Description --- kioexec currently creates temp files using the following filename

Review Request 129172: kioexec: use friendly names

with Libreoffice. * Check the filename in the app window title. * Check that temp file and folder (in .cache/kioexec/krun) are deleted after the 3 minutes delay. Thanks, Elvis Angelaccio

Re: Review Request 129160: Drop obsolete version checks

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit bc9ff2f58bd2c359e682e645e12119bcc6725e5a by Elvis Angelaccio to branch master. Repository: kio Description --- Qt 5.5 is now required. While at it, drop also old checks from

Re: Review Request 129079: Register QPair<QString, QString> as metatype

marked as submitted. Review request for KDE Frameworks and Michael Pyne. Changes --- Submitted with commit 9d972fbe8c63203aaf766de45342829563d53c7b by Elvis Angelaccio to branch master. Repository: kcoreaddons Description --- This fixes the following warning when client apps emit

Re: Review Request 129079: Register QPair<QString, QString> as metatype

ir<QString,QString>' is registered using qRegisterMetaType().) Diffs - src/lib/jobs/kjobtrackerinterface.cpp 25af465de36ade6105533ecc9d8ea894a567a11d Diff: https://git.reviewboard.kde.org/r/129079/diff/ Testing --- Warning is gone. Thanks, Elvis Angelaccio

Review Request 129079: Register QPair<QString,QString> as metatype

sterMetaType().) Diffs - src/lib/jobs/kjobtrackerinterface.cpp 25af465de36ade6105533ecc9d8ea894a567a11d Diff: https://git.reviewboard.kde.org/r/129079/diff/ Testing --- Warning is gone. Thanks, Elvis Angelaccio

Re: Review Request 128831: Check whether kwallet is enabled in Wallet::isOpen(name)

> On Sept. 24, 2016, 12:40 p.m., Elvis Angelaccio wrote: > > src/api/KWallet/kwallet.cpp, line 366 > > <https://git.reviewboard.kde.org/r/128831/diff/1/?file=475994#file475994line366> > > > > You should probably use isEnabled() instead, in case someone is

Re: Review Request 129019: KFileItemActions: add addPluginActionsTo(QMenu *).

context menu class ;) - Elvis Angelaccio On Sept. 26, 2016, 7:58 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128831: Check whether kwallet is enabled in Wallet::isOpen(name)

> On Sept. 24, 2016, 12:40 p.m., Elvis Angelaccio wrote: > > src/api/KWallet/kwallet.cpp, line 366 > > <https://git.reviewboard.kde.org/r/128831/diff/1/?file=475994#file475994line366> > > > > You should probably use isEnabled() instead, in case someone is

Re: Review Request 128831: Check whether kwallet is enabled in Wallet::isOpen(name)

> On Sept. 24, 2016, 12:40 p.m., Elvis Angelaccio wrote: > > src/api/KWallet/kwallet.cpp, line 366 > > <https://git.reviewboard.kde.org/r/128831/diff/1/?file=475994#file475994line366> > > > > You should probably use isEnabled() instead, in case someone is

Re: Review Request 128831: Check whether kwallet is enabled in Wallet::isOpen(name)

tps://git.reviewboard.kde.org/r/128831/#comment66932> You should probably use isEnabled() instead, in case someone is using ksecretservice (though m_walletEnabled is already used all over the place)... Anyway +1 - Elvis Angelaccio On Sept. 4, 2016, 9:20 p.m., Wolfgang Bauer

Re: Review Request 128913: add a test to prevent file names from having newlines

in the first place. Shouldn't we use a server-side hook that prevents commits with broken filenames? Or this is only a problem with icons? - Elvis Angelaccio On Sept. 15, 2016, 8:17 a.m., Harald Sitter wrote: > > --- > This is an auto

Re: Review Request 128881: Remove outdated code snippet

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 6a753b9e227cc5519243af39724927212299a079 by Elvis Angelaccio to branch master. Repository: kio Description --- This seems to come from KDE3 times. I guess should be safe

Review Request 128881: Remove outdated code snippet

Description --- This seems to come from KDE3 times. I guess should be safe to remove... Diffs - src/filewidgets/kfilewidget.h bbbfd02 Diff: https://git.reviewboard.kde.org/r/128881/diff/ Testing --- Thanks, Elvis Angelaccio

Re: Review Request 128759: Show shortcut for New Folder action

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 8d9befe7c9f7813352ddb4b6a1c169f31e5f5365 by Elvis Angelaccio to branch master. Bugs: 366075 https://bugs.kde.org/show_bug.cgi?id=366075 Repository: kio Description

Re: Review Request 128796: Fix disabled paste action for slaves that don't emit an UDSEntry for "."

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit fcbfb61a5304554483ceb49d8728d0e947a4af9e by Elvis Angelaccio to branch master. Bugs: 366795 https://bugs.kde.org/show_bug.cgi?id=366795 Repository: kio Description

Re: Review Request 128759: Show shortcut for New Folder action

lly and now it is > > not, isn't that a problem? > > Elvis Angelaccio wrote: > Only if the action's triggered signal is not connected to the > createDirectory slot. I updated the apidox with this info, but yeah we can't > be 100% sure (unless there is a way to check whether a given

Re: Review Request 128796: Fix disabled paste action for slaves that don't emit an UDSEntry for "."

a fallback in the SlaveBase class. Diffs (updated) - src/core/slavebase.cpp f939146 Diff: https://git.reviewboard.kde.org/r/128796/diff/ Testing --- Paste action is enabled again for mtp:// and kdeconnect:// slaves. Thanks, Elvis Angelaccio

Re: Review Request 128796: Fix disabled paste action for slaves that don't emit an UDSEntry for "."

a fallback in the SlaveBase class. Diffs (updated) - src/core/slavebase.cpp f939146 Diff: https://git.reviewboard.kde.org/r/128796/diff/ Testing --- Paste action is enabled again for mtp:// and kdeconnect:// slaves. Thanks, Elvis Angelaccio

Re: Review Request 128796: Fix disabled paste action for slaves that don't emit an UDSEntry for "."

> On Aug. 29, 2016, 5:37 p.m., Elvis Angelaccio wrote: > > src/core/slavebase.cpp, line 465 > > <https://git.reviewboard.kde.org/r/128796/diff/1/?file=475607#file475607line465> > > > > Not sure how to achieve that. Maybe we can cache the QUrl passed

Re: Review Request 128796: Fix disabled paste action for slaves that don't emit an UDSEntry for "."

tps://git.reviewboard.kde.org/r/128796/#comment66508> Not sure how to achieve that. Maybe we can cache the QUrl passed to `listDir()` and retrieve the protocol (e.g. mtp://) from that? - Elvis Angelaccio On Aug. 29, 2016, 1:36 p.m., Elvis Angelaccio

Review Request 128796: Fix disabled paste action for slaves that don't emit an UDSEntry for "."

s. Diffs - src/core/slavebase.cpp f939146 Diff: https://git.reviewboard.kde.org/r/128796/diff/ Testing --- Paste action is enabled again for mtp:// and kdeconnect:// slaves. Thanks, Elvis Angelaccio

Re: Review Request 128759: Show shortcut for New Folder action

lly and now it is > > not, isn't that a problem? > > Elvis Angelaccio wrote: > Only if the action's triggered signal is not connected to the > createDirectory slot. I updated the apidox with this info, but yeah we can't > be 100% sure (unless there is a way to check whether a given

Re: Review Request 128759: Show shortcut for New Folder action

erhaps some moc black magic?) - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128759/#review98665 --- On Aug. 26, 2

Re: Review Request 128759: Show shortcut for New Folder action

wfilemenu.cpp a340429f5b7f99842747c6805187256e00179f22 Diff: https://git.reviewboard.kde.org/r/128759/diff/ Testing --- Make sure that "New -> Folder" shows F10 as shortcut in Dolphin. Make sure that triggering the action doesn't show the dialog twice. Thanks, Elvis Angelaccio

Re: Review Request 128759: Show shortcut for New Folder action

viewboard.kde.org/r/128759/#review98652 --- On Aug. 25, 2016, 4:57 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 128759: Show shortcut for New Folder action

ff/ Testing --- Make sure that "New -> Folder" shows F10 as shortcut in Dolphin. Make sure that triggering the action doesn't show the dialog twice. Thanks, Elvis Angelaccio

Re: Review Request 128698: Use Donate standard action in the help menu

marked as submitted. Review request for KDE Frameworks and Albert Astals Cid. Changes --- Submitted with commit 9fad205d33f3346bfd13f6cc8b86f188c9b27563 by Elvis Angelaccio to branch master. Repository: kxmlgui Description --- As suggested by Albert in https

Review Request 128698: Use Donate standard action in the help menu

: kxmlgui Description --- As suggested by Albert in https://git.reviewboard.kde.org/r/128609/ Diffs - src/khelpmenu.cpp 953c48446d4b3c73b5cc164e7664e1a11788979b Diff: https://git.reviewboard.kde.org/r/128698/diff/ Testing --- Donate action still works. Thanks, Elvis Angelaccio

Re: Review Request 128609: Add Donate action to KStandardAction

marked as submitted. Review request for KDE Frameworks and Albert Astals Cid. Changes --- Submitted with commit 5434c692c475cf6e32772c57c31238fade851074 by Elvis Angelaccio to branch master. Repository: kconfigwidgets Description --- Donate action has been recently added

Re: Review Request 128609: Add Donate action to KStandardAction

ated. - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128609/#review98405 --- On Aug. 8, 2016, 9:06 a.m., Elvis A

Re: Review Request 128608: Add Donate entry to KStandardShortcut

marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Changes --- Submitted with commit 3434b9efd0a8b77d558e4376af38e17d59ded66c by Elvis Angelaccio to branch master. Repository: kconfig Description --- This patch adds a Donate entry, such that https

Re: Review Request 128609: Add Donate action to KStandardAction

action_p.h 814374e0b7ed3939c8a80a26e59f461ef73e22c0 Diff: https://git.reviewboard.kde.org/r/128609/diff/ Testing --- Needs https://git.reviewboard.kde.org/r/128608/ to build. Thanks, Elvis Angelaccio

Re: Review Request 128608: Add Donate entry to KStandardShortcut

a5a7c28f86094bd346abc8dc17e24a6bd365f5bd src/gui/kstandardshortcut.cpp 6d749455782d55a81ed5448f35eade954c1df615 Diff: https://git.reviewboard.kde.org/r/128608/diff/ Testing --- Thanks, Elvis Angelaccio

Review Request 128609: Add Donate action to KStandardAction

--- Needs https://git.reviewboard.kde.org/r/128608/ to build. Thanks, Elvis Angelaccio ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128608: Add Donate entry to KStandardShortcut

6d749455782d55a81ed5448f35eade954c1df615 Diff: https://git.reviewboard.kde.org/r/128608/diff/ Testing --- Thanks, Elvis Angelaccio ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

marked as submitted. Review request for KDE Frameworks, KDE Usability and David Faure. Changes --- Submitted with commit a67b2ef0a38b7f80803d785c7784785e0e1093c5 by Elvis Angelaccio to branch master. Repository: kio Description --- As discussed in RR 128283, we can improve

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

this. - Elvis Angelaccio On July 22, 2016, 9:21 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

/5f137d47-4592-4f4c-be96-4c2fc3d09978__Spectacle.J32017.png Thanks, Elvis Angelaccio ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128490: Checksums tab: replace groupbox with horizontal separator

marked as submitted. Review request for KDE Frameworks and KDE Usability. Changes --- Submitted with commit 6fd238b461b4d51d02d4d24690c09452ada519d1 by Elvis Angelaccio to branch master. Repository: kio Description --- Follow up of RR [128283](https://git.reviewboard.kde.org/r

Re: Review Request 128150: [libkerfuffle] Ark application exits before job's finished

> (Updated June 11, 2016, 6:33 a.m.) > > > Review request for KDE Frameworks and Elvis Angelaccio. > > > Repository: ark > > > Description > --- > > This is *only* fix for 16.04.2 > > > Diffs > - > > kerfuffle/jobs.cpp 4

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

it: https://git.reviewboard.kde.org/r/128490/#review97737 --- On July 20, 2016, 1:01 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 128490: Checksums tab: replace groupbox with horizontal separator

-4b26-9852-876e48aa5143__Spectacle.T11454.png Thanks, Elvis Angelaccio ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

> On July 16, 2016, 10:30 a.m., Elvis Angelaccio wrote: > > Ping? > > > > (String freeze for frameworks is next Saturday, right?) > > Olivier Churlaud wrote: > I would say: replace the [copy] button by a select on click. and then > ship it Not

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

this before the Saturday string freeze :) - Elvis Angelaccio On July 20, 2016, 1:01 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128466: Rename Checksums tab to Integrity

-- Before https://git.reviewboard.kde.org/media/uploaded/files/2016/07/16/6771ed06-c803-4d18-abe3-91e4f97c8c76__checksums-tab.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/07/16/b2cd12c8-6bbf-4123-9e8e-59cb0c29cbdb__Spectacle.TJ7614.png Thanks, Elvis

Review Request 128490: Checksums tab: replace groupbox with vertical separator

a/uploaded/files/2016/07/20/e39d8b29-5837-4236-833b-26ecafe18bfb__checksums-tab.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/07/20/d1ec9cee-03e5-4b26-9852-876e48aa5143__Spectacle.T11454.png Thanks, Elvis Angelaccio ___ Kde-framew

Re: Review Request 128466: Rename Checksums tab to Integrity

stand the "Share" title in the original review, but > that's another matter.) > > This needs more work. > > Elvis Angelaccio wrote: > > Perhaps the whole thing could be simplified by naming the tab > "Checksums" and removing the groupbox altog

Re: Review Request 128466: Rename Checksums tab to Integrity

stand the "Share" title in the original review, but > that's another matter.) > > This needs more work. > > Elvis Angelaccio wrote: > > Perhaps the whole thing could be simplified by naming the tab > "Checksums" and removing the groupbox altog

Re: Review Request 128466: Rename Checksums tab to Integrity

stand the "Share" title in the original review, but > that's another matter.) > > This needs more work. > > Elvis Angelaccio wrote: > > Perhaps the whole thing could be simplified by naming the tab > "Checksums" and removing the groupbox altog

Re: Review Request 128466: Rename Checksums tab to Integrity

oving the groupbox altogether, as it's not providing any semantic value. Preview here: https://share.kde.org/index.php/s/RUs9gAhIQqpFIqF - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboa

Re: Review Request 128466: Rename Checksums tab to Integrity

rd.kde.org/media/uploaded/files/2016/07/16/6771ed06-c803-4d18-abe3-91e4f97c8c76__checksums-tab.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/07/16/b2cd12c8-6bbf-4123-9e8e-59cb0c29cbdb__Spectacle.TJ7614.png Thanks, Elvis Angelaccio _

Review Request 128466: Rename Checksums tab to Integrity

2016/07/16/ef8db8b1-f672-459a-9b3b-bc20a8c37df7__Spectacle.TJ7614.png Thanks, Elvis Angelaccio ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

git.reviewboard.kde.org/r/128413/#review97287 --- On July 9, 2016, 7:55 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

?) - Elvis Angelaccio On July 9, 2016, 7:55 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: QIcon::fromTheme() does not load scalable icons

2016-07-12 15:47 GMT+02:00 Olivier Churlaud : > Hello Hi > > For some time I was debugging why TeXstudio didn't have an icon in the task > manager. After comparing, the only difference with working apps was that > TeXStudio has only an icon in > >

Review Request 128413: Add clipboard buttons in the Checksums tab

/uploaded/files/2016/07/09/906d90f6-7727-4163-9992-c688667073ec__Spectacle.J11500.png Example of Copy button https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/10c18534-0e72-4c8c-98ae-144a909438c9__Spectacle.J11519.png Thanks, Elvis Angelaccio

Re: Review Request 128283: Add checksums tab to the properties dialog

board.kde.org/r/128283/#review97237 --- On July 8, 2016, 1:51 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review97235 --- On July 8, 2016, 1:51 p.m., Elvis Angelaccio wrote: > > --

Re: Review Request 128406: KCollapsibleGroupBox: Stop animation if still running in destructor

the unit test here, maybe is enough to expand the collapsible box and then delete the widget? - Elvis Angelaccio On July 8, 2016, 7:29 p.m., Ragnar Thomsen wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 128283: Add checksums tab to the properties dialog

marked as submitted. Review request for KDE Frameworks, KDE Usability and David Faure. Changes --- Submitted with commit c5ab1b80957a993c904f98a86ead880c3cc25421 by Elvis Angelaccio to branch master. Repository: kio Description --- This patch adds a Checksums tab in the properties

Re: Review Request 128283: Add checksums tab to the properties dialog

, Elvis Angelaccio ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128283: Add checksums tab to the properties dialog

checksum https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/a243c830-2dc0-4cbd-95e9-8f1684bc86a4__Spectacle.J13336.png Thanks, Elvis Angelaccio ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 128023: Deprecate authorizeKAction() in favor of authorizeAction()

marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Changes --- Submitted with commit b566ff96512b6ead8b11a20e23cc87bc80d72e75 by Elvis Angelaccio to branch master. Repository: kconfig Description --- We don't use anymore KActions, so both the function name

<    4   5   6   7   8   9   10   11   >