D18450: Add extractor for AppImage files

kossebau added a comment. In D18450#400865 , @astippich wrote: > I am having troubles getting it to build (Kubuntu 18.10). Unfortunately, I could not find pre-build packages for libappimage. I have overcome two small issues in building

D20202: FrameSvgItem: add "mask" property

kossebau added a dependent revision: D20203: desktoppackage: add "panelMask" property for Panel.qml. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20202 To: kossebau, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20202: FrameSvgItem: add "mask" property

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY This property allows e.g. the Plasma shell to query the shape a panel has when

D19939: Avoid failing installation via temporary dir due to file name clashes

kossebau created this revision. kossebau added reviewers: Frameworks, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY When installing to a temporary dir, there could be file name clashes

D19939: Avoid failing installation via temporary dir due to file name clashes

kossebau added a comment. So the solution would be to cache the calculated result. Which would also allow to have this as flag for some proper post-install cleanup once that is sorted out and defined. Problem is: `KNSCore::Installation` is an exported class, with an installed header.

D19939: Avoid failing installation via temporary dir due to file name clashes

kossebau planned changes to this revision. kossebau added a comment. Found a flaw: this will result in a different path on every call of the method for the same object, which can happen. Needs more thought. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19939

D19939: Avoid failing installation via temporary dir due to file name clashes

kossebau added a reviewer: apol. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19939 To: kossebau, #frameworks, leinir, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

kossebau updated this revision to Diff 55383. kossebau added a comment. Remove last bit about stripping that was still in the patch REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20166?vs=55231=55383 BRANCH uncompressedsvginrepo

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Since v0.13.0 (17 Nov 2018) quassel uses new names for the systemtray status

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

kossebau added a comment. To test this quickly, please download the files (View Options>Show Raw File (Right)>Download File) and place them in the respective folders `/usr/share/plasma/desktoptheme/{air,breeze}/icons/`, then "rm .cache/plasma* -r", and restart "plasmashell --replace" e.g.

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

kossebau added a comment. Recent example where plain SVGs in the repo would have made the change immdiate visible, as only the strings of some id attributes where changed (to match the new icon names), but instead all we see with our tool is an exchange of the complete binary blob: D20261

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

kossebau abandoned this revision. kossebau added a comment. In D20261#443859 , @broulik wrote: > I don't see how this could work. IconItem uses the first section as filename, for `active-quassel-tray` the word `active` and looks for an

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

kossebau added a comment. In D20166#443916 , @ngraham wrote: > In D20166#443781 , @kossebau wrote: > > > If so, I would propose to merge it after KDE Frameworks 5.57 has been branched this WE, i.e.

Re: CI system maintainability

Am Donnerstag, 28. März 2019, 11:27:44 CET schrieb Daniel Vrátil: > I'm completely fine with mandatory code review for everything and I'd be > happy to have this in PIM. I think the biggest problem in PIM to overcome > will be finding the reviewers - I dare say I'm currently the only one who > has

Re: CI system maintainability

Am Donnerstag, 28. März 2019, 09:29:22 CET schrieb Kevin Ottens: > Hello, > > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote: > > Please note that the commits in this instance were pushed without > > review, so restrictions on merge requests wouldn't make a difference > > in this case

Re: CI system maintainability

Hi Laurent, Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel: > For example I works all days on kde (pim or other) when I wake up, or at > noon after my lunch or the evening, I will not wait several days for a > review because nobody has time to do it. > > (For example I make ~

Re: CI system maintainability

Thanks for reply. More below: Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit : > > Hi Laurent, > > > > Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel: > > >

Re: CI system maintainability

Am Donnerstag, 28. März 2019, 16:04:01 CET schrieb Boudhayan Gupta: > I don't care if you lose time. I don't want the guys building my house to > cut corners mixing my concrete because it's going to save time. There is a difference here though, no? The people building your house will not live in

Re: CI system maintainability

Am Donnerstag, 28. März 2019, 23:06:17 CET schrieb laurent Montel: > Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit : > > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > > > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau added inline comments. INLINE COMMENTS > fvogt wrote in CMakeLists.txt:15 > You could make this optional and set the `STRIP_DESKTOPTHEME_SVG` default > depending on whether it's found. Personally I favour the buildsystem not to randomly do what it can given the current system state,

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau updated this revision to Diff 55191. kossebau added a comment. Fix some naming inconsistencies one only sees when looking at a patch through another viewer (like the phabricator review page :)) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau added a comment. SVGZ -> SVG conversion of all files not included in this uploaded patch, to keep it reviewable. Locally do this: Store a file `svgztosvg.sh` with this content in `src/desktoptheme`: #!/bin/sh SVGZ=$1 if [ ! -f "$SVGZ" ]; then

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau created this revision. kossebau added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The SVG format being based on plain text, storing the SVG in the repository

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau added a comment. In D20166#441733 , @GB_2 wrote: > In D20166#441715 , @ndavis wrote: > > > Be careful that you are not stripping stylesheets when you use SVG Cleaner. `scour` is less

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau added a comment. In D20166#441653 , @ngraham wrote: > Strong +1 on the idea. Shouldn't we put these `Find.cmake` files in ECM though? The Breeze icons repo could definitely benefit from `FindSVGCleaner` to automatically post-process

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau added a comment. While the main purpose of this patch is to have SVG files in the repo, the processing to optimize runtime load is an interesting side-effect. If you are curious about some numbers, here the install size estimated with `du -chb` for the respective subfolders

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau updated this revision to Diff 55231. kossebau added a comment. Remove stripping feature REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20166?vs=55191=55231 BRANCH uncompressedsvginrepo REVISION DETAIL

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau added a comment. In D20166#441854 , @ndavis wrote: > In D20166#441807 , @ngraham wrote: > > > Strictly speaking, there's no need to optimize the SVGs as a part of this, so maybe, yeah,

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

kossebau retitled this revision from "Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz" to "Keep desktoptheme SVG files uncompressed in repo, install svgz". kossebau edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D20202: FrameSvgItem: add "mask" property

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f20722fbe1d0: FrameSvgItem: add mask property (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20202?vs=55274=55738

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added inline comments. INLINE COMMENTS > cfeck wrote in textcreator.cpp:169 > KSyntaxHighlighting::Theme also provides a background color. Can that be used > instead of the hardcoded 245? I cannot remember reason why I disabled (or > never enabled) the QPalette code; I suggest to

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau created this revision. kossebau added a reviewer: broulik. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Makes previews of text files a bit easier to recognize, both

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added a comment. Before: F6645792: Screenshot_20190301_000252.png After: F6645790: Screenshot_20190301_03.png There is surely room for more improvements with this thumbnailer, but the

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added a subscriber: vkrause. kossebau added inline comments. INLINE COMMENTS > kossebau wrote in textcreator.cpp:169 > Good idea. Hm, > `highlightingTheme.backgroundColor(KSyntaxHighlighting::Theme::Normal)` > returns black for me, and there is a comment for >

D19453: Fix repository deletion warning

kossebau added a comment. I can confirm this results in the warnings about `Repository got deleted while a highlighter is still active!` no longer being shown when using D19432 . Also no issues seen in Kate. But not enough understanding of this

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

kossebau added a comment. FWIW, this still results in inproper pc files, from what I heard recently. The `prefix` variable can be overriden from outside when calling `pkg-config` (cmp. `pkg-config --help`) to allow for relocatable installations. Same like CMake Config files also allow

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau updated this revision to Diff 53273. kossebau added a comment. fixup: correct default cpp for SourceExtension in README.dox REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19565?vs=53272=53273 BRANCH configfileextensions REVISION DETAIL

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY When using kconfig_compiler generated sources in projects where the used

D19567: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The build configuration depends on the value of the "File=" entry in the

D19567: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up

kossebau added a comment. @apol Thanks for review :) REPOSITORY R237 KConfig BRANCH reruncmakeonkfgcchange REVISION DETAIL https://phabricator.kde.org/D19567 To: kossebau, #frameworks, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau updated this revision to Diff 53299. kossebau added a comment. update to latest master REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19565?vs=53273=53299 BRANCH configfileextensions REVISION DETAIL https://phabricator.kde.org/D19565

D19567: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up

This revision was automatically updated to reflect the committed changes. Closed by commit R237:d996a0fba67d: KCONFIG_ADD_KCFG_FILES macro: ensure a change of File= in kcfg is picked up (authored by kossebau). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D18450: Add extractor for AppImage files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1aa7f9168d51: Add extractor for AppImage files (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18450?vs=51934=52352#toc REPOSITORY R286 KFileMetaData CHANGES SINCE

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

This revision was automatically updated to reflect the committed changes. Closed by commit R320:b6cb0fa963db: [appimage thumbnailer] Rely on imported cmake target libappimage (authored by kossebau). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

This revision was automatically updated to reflect the committed changes. Closed by commit R320:d95ff837a9bc: [text thumbnailer] Use KSyntaxHighlighting for text rendering (authored by kossebau). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D19534: [i18n] compile without foreach

kossebau added a comment. In D19534#425325 , @dfaure wrote: > Well, you could have pushed a fix ;-) It seemed to me you were actively working on related stuff, and I was just too quickly curious without access to a build setup, so did

D19534: [i18n] compile without foreach

kossebau added a comment. Ah, seems I missed this was Android-specific code, and CI confirms what I had been thinking before, by failing the build for Android. Okay, nothing missed here on my side it seems, so moving out again :) REPOSITORY R249 KI18n REVISION DETAIL

D19534: [i18n] compile without foreach

kossebau added a comment. In D19534#425198 , @dfaure wrote: > I pushed a fix, please test: https://commits.kde.org/ki18n/927fd6c20a7e0acfe87353abb93dcb066d1d0713 > > Laurent: this was Android-specific code, not compiled on Linux. I suggest

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added a comment. So, from my side I am fine with the current patch. While the change to QTextDocument (& syntax highlighting?) results in a marginal bigger linespacing and as result up to one line less text rendered in the preview, I find the newer linespacing actually better to

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added a reviewer: cfeck. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19432 To: kossebau, broulik, cfeck Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns,

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added inline comments. INLINE COMMENTS > vkrause wrote in textcreator.cpp:169 > I think default background color here refers to what your palette gives you. > The background color defined by highlighting is typically only used for small > text blocks like for alerts ("TODO", "HACK",

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added a comment. New after: F6646824: Screenshot_20190301_144746.png Hm, meh, now I see that `textDocument.drawContents();` does not stay within the page size the document was given... let's see whether I can do some clipping

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau updated this revision to Diff 52899. kossebau added a comment. use original different x & y margins, to gain more chars rendered, as before REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19432?vs=52865=52899 BRANCH

D18943: Add Fontconfig find modudle

kossebau added a comment. In D18943#424029 , @vkrause wrote: > What I don't understand though is which FindFontconfig this used to find, there is non in plasma-desktop... kdelibs4support provides one. REPOSITORY R240 Extra CMake

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau updated this revision to Diff 52901. kossebau added a comment. Changes: - clip when drawing the text document, so our "page" margins stay clean - for that reuse vars some more Somehow the old custom margins look nicer to me, so I kept the logic in the code. Seems

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

kossebau updated this revision to Diff 52353. kossebau added a comment. Use 0.1.10 as min version for libappimage, which is the first to provide working cmake config files REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18611?vs=50537=52353 BRANCH

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau added a comment. An alternative approach might be to do instead //if tiling horizontally if (m_border == FrameSvg::TopBorder || m_border == FrameSvg::BottomBorder || m_border == FrameSvg::NoBorder) { textureRect.setWidth(qMax(1, nodeRect.width() /

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

kossebau added inline comments. INLINE COMMENTS > dhaumann wrote in textcreator.cpp:169 > I saw this review request just now: Using a hardcoded theme is not a good > idea. I suggest to use a solution based on the background color. We have the > following in our example codeeditor: > >

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0ffe183d71fd: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0 (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau added a comment. So far I have not yet seen another tiled-border theme on store.kde.org, so restoring the Plasma4 behaviour should be fine. Both tiled-border themes I know are now up at stores.kde.org/GHNS also to allow testing: - Fluffy Bunny:

D19907: Add Theme::blurBehindEnabled()

kossebau updated this revision to Diff 54416. kossebau added a comment. add missed-out application of the flag in PlasmaQuick::Dialog REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19907?vs=54399=54416 BRANCH addblurbehindflag

D19907: Add Theme::blurBehindEnabled()

kossebau updated this revision to Diff 54417. kossebau added a comment. Remove sneaked-in code clean-up for repeated fetching of mask @davidedmundson Is the new dialog code fine? REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D19907: Add Theme::blurBehindEnabled()

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows themes to disable the blurring of what is behind panels, if they either

D19907: Add Theme::blurBehindEnabled()

kossebau added inline comments. INLINE COMMENTS > theme.h:391 > + * \code > + * [BlurEffect] > + * enabled=false And this and above should have been updated to "[BlurBehindEffect]", as actually used in the code. So much for quick pre-lunch uploading, tss. Will fix when landing the

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau added a comment. @apol Thanks for review. No further comments anyone? Would then proceed to push this next Monday, March 18th, if no-one objects. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19565 To: kossebau, #frameworks Cc: apol,

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau added a comment. In D19787#431712 , @apol wrote: > Does this solve the fluffy bunny issue? Yes, both approaches solve the broken rendering for Fluffy Bunny, as they both prevent width/height to be set to 0. Given the fuzzy

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

This revision was automatically updated to reflect the committed changes. Closed by commit R237:a3ed87ca7808: kconfig_compiler: new kcfgc args HeaderExtension SourceExtension (authored by kossebau). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau updated this revision to Diff 53986. kossebau added a comment. Only prevent width/height of textureRect becoming 0, otherwise keep old behaviour. Not changing to qround to prevent bad image quality due to up-sampling. F6695867: Screenshot_20190316_070411.png

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau updated this revision to Diff 53987. kossebau added a comment. add documentation about wanted behaviour, so the next person does not change it again REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19787?vs=53986=53987 BRANCH

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau added a comment. After a first coffee, I realize this very logic actually already does upsampling all the time, given it takes the floor of the nodesize/samplesize expression, not the ceiling. And with eyes made sensitive, I see this now all the time. Rereading the CSS3 spec,

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

kossebau updated this revision to Diff 53988. kossebau added a comment. Update patch to restore initial logic without stretching, which also resembles Plasma4 one REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19787?vs=53987=53988

D19907: Add Theme::blurBehindEnabled()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fb1a332948e3: Add Theme::blurBehindEnabled() (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19907?vs=54417=54501

D19743: FrameSvgItem: catch margin changes of FrameSvg also outside own methods

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5f4f88ad66f9: FrameSvgItem: catch margin changes of FrameSvg also outside own methods (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D19551: [knotifications] compile without foreach

kossebau added a comment. This sadly breaks build with at least older versions of Phonon, as they have foreach loop in their public headers. So this either needs a bump of the current find_package(Phonon4Qt5 4.6.60 NO_MODULE) or adding the `QT_NO_FOREACH` only if a newer

D18822: Fix Windows build [hopefully]

kossebau added a comment. Looks fine to me from quick reading, everything done I would have thought of (whatever that is worth :P ) +1 REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18822 To: aacid Cc: kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham,

D18450: Add extractor for AppImage files

kossebau updated this revision to Diff 51934. kossebau added a comment. - update to latest master - remove unused name() method REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18450?vs=50535=51934 BRANCH addappimageextractor REVISION DETAIL

D18450: Add extractor for AppImage files

kossebau added a comment. In D18450#402995 , @astippich wrote: > Just noticed, you never use the AppDataParser.name(). Is that intentional? Good catch, was left over from first code drafts, before I aligned the data mapping with what I

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

kossebau added a comment. Created https://github.com/AppImage/libappimage/pull/71 as one approach to get this solved on libappimage side. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18611 To: kossebau, broulik Cc: sitter, kde-frameworks-devel, kfm-devel,

D18943: Add Fontconfig find modudle

kossebau added a comment. Could the indentation perhaps be turned to be 4 spaces while copying it here? While https://community.kde.org/Policies/CMake_Coding_Style#Indentation allows the choice of 2,3, or 4 spaces, using 4 is more in line with the indentation used in C++ sources, so IMHO

D18822: Fix Windows build [hopefully]

kossebau added a comment. Given the autotests reuse the source files from the lib (and thus also using the headers) the export macros confuse windows here. So in autotests/CMakeLists,txt, one needs to extend target_compile_definitions(kauth_tests_static PUBLIC

D18822: Fix Windows build [hopefully]

kossebau added a comment. Given this seems stuck by missing reviewers, IMHO time to test the fix by try & error on the CI. If no-one would dare to do this, would take over, given I got pulled in and now this unsolved thing steals my attention time ;) REPOSITORY R283 KAuth REVISION

D18960: Add compile check to FindEGL

kossebau added a comment. Seems this is sadly breaking something for FreeBSD though, see https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann,

D18822: Fix Windows build [hopefully]

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R283:c0854de284b7: Fix Windows build [hopefully] (authored by aacid, committed by kossebau). CHANGED PRIOR TO COMMIT

D18822: Fix Windows build [hopefully]

kossebau added a comment. Good news, kauth now passed at least CI again for all platforms tested there (so incl. Windows) :) Your iniail fix was almost complete, @aacid, just missed that last bit for the autotests code, so take pride here :) REPOSITORY R283 KAuth REVISION DETAIL

D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg

This revision was automatically updated to reflect the committed changes. Closed by commit R240:b23f4198a22a: ECMGeneratePkgConfigFile API dox: fix Since for DESCRIPTION arg (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg

kossebau created this revision. kossebau added a reviewer: cgiboudeaux. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Also place "Since" next to both argument and

D18450: Add extractor for AppImage files

kossebau added a comment. @astippich Thanks for the update. I see that myself I built libappimage with USE_SYSTEM_LIBARCHIVE:BOOL=ON, USE_SYSTEM_SQUASHFUSE:BOOL=OFF, USE_SYSTEM_XZ:BOOL=ON, BUILD_TESTING:BOOL=OFF (cannot remember why I configured the build that way when I initially set it

D18450: Add extractor for AppImage files

kossebau added a comment. Given there are now released versions of libappimage which provide cmake config files, I will now update this patch to simply only support those. Distributions will be encouraged to also get the latest version of libappimage anyway. REPOSITORY R286 KFileMetaData

D18450: Add extractor for AppImage files

kossebau updated this revision to Diff 50535. kossebau added a comment. rely completely on working libappimage cmake config files, as avail with recent releases REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18450?vs=50146=50535 BRANCH

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

kossebau created this revision. kossebau added a reviewer: broulik. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Recent released versions of libappimage set working imported

D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file

This revision was automatically updated to reflect the committed changes. Closed by commit R240:ed985869924f: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D18434: exiv2extractor: add support for bmp, gif, webp, tga

kossebau added a comment. In D18434#400106 , @aacid wrote: > is it worth adding files to autotests/exiv2extractortest.cpp ? Shortly considered, but then I saw so far only a jpg file is tested, and thinking about it, the test checks that

D18450: Add extractor for AppImage files

kossebau added a comment. In D18450#402952 , @astippich wrote: > got it up and running! Yay :) Thanks for keeping trying. > One question: Why is the extra desktop file parser necessary? Shouldn't all required information be

D18652: Improve weather-storm-* icons

kossebau added a comment. > This patch corrects that by removing the background cloud Thanks for the proposal. Hm, removal of the second cloud not what I would have expected to be done, was actually fine with it. Not sure. > slightly resizing and repositioning the sun and moon.

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

kossebau added a comment. In D18611#403137 , @sitter wrote: > Even with the chances being low of a system having an old version, I'd say it's better to actually make find_package look for at least the version that introduced the import target.

D12477: Add unit test to see that :/ files can work

kossebau added a comment. In D12477#403709 , @dfaure wrote: > Still, at the level of the KParts frameworks itself it's all fine ;) Which "level" do you mean here? This test only works by pure chance given the current implementation

D20478: Breeze desktoptheme clock: support hand shadow offset hint of Plasma 5.16

kossebau added a comment. For the hint as introduced with D20112 . Looks like this then: F6767766: Screenshot_20190412_015729.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D20478: Breeze desktoptheme clock: support hand shadow offset hint of Plasma 5.16

This revision was automatically updated to reflect the committed changes. Closed by commit R242:417a82b1b947: Breeze desktoptheme clock: support hand shadow offset hint of Plasma 5.16 (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D20510: SvgItem, IconItem: drop "smooth" property override, update node on change

This revision was automatically updated to reflect the committed changes. Closed by commit R242:18a2ca50ab09: SvgItem, IconItem: drop smooth property override, update node on change (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D20550: Oxygen desktoptheme: add padding to hands, against jagged outline on rotation

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b9ac83d4d7f5: Oxygen desktoptheme: add padding to hands, against jagged outline on rotation (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

<    2   3   4   5   6   7   8   9   10   11   >