D23839: Port away from Qt's foreach

kossebau created this revision. kossebau added reviewers: KWin, zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R278 KWindowSystem BRANCH portfromforeach REVISION DETAIL https://phabricator.kd

D23791: ECMAddQch: add INCLUDE_DIRS argument

kossebau added a comment. Would push upcoming WE if there are no objections. And then also adapt all KF modules to make use of this new argument, for better results and less need for predefined macros. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D237

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

This revision was automatically updated to reflect the committed changes. Closed by commit R39:328adb52d3db: Use QString::count(QChar)+1 over QString::splitRef().length() (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23674?vs=65738&

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

kossebau added a comment. In D23674#528430 , @cullmann wrote: > Hmm, is lastLineLenght correct? Must one not decrement by one? Yes, someone missed in their brain to properly turn `- (x + 1)` into `- x - 1`, just happened again with me whe

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

kossebau updated this revision to Diff 65738. kossebau added a comment. use brackets for correct logic REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23674?vs=65228&id=65738 BRANCH morecountoversplit REVISION DETAIL https://phabricator.kde.org/D236

D23810: Port away from Qt's foreach all loops over rvalue container objects

This revision was automatically updated to reflect the committed changes. Closed by commit R263:0cab036a2dab: Port away from Qt's foreach all loops over rvalue container objects (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23810?vs=65

D23813: Port away from foreach loops over arguments without calls to owner class

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which still call the own

D23812: Port away from foreach loops over members without calls to owner class

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which still call the own

D23810: Port away from Qt's foreach all loops over rvalue container objects

kossebau updated this revision to Diff 65714. kossebau added a comment. add some more of this category REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23810?vs=65712&id=65714 BRANCH portmoreforeachforlocalcontainerobjects REVISION DETAIL https://phabri

D23810: Port away from Qt's foreach all loops over rvalue container objects

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The other simple part of foreach porting, as those containers objects are not sha

D23664: Port away from Qt's foreach all loops over method-local containers

This revision was automatically updated to reflect the committed changes. Closed by commit R263:867351258d1f: Port away from Qt's foreach all loops over method-local containers (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23664?vs=652

D23664: Port away from Qt's foreach all loops over method-local containers

kossebau added a comment. Ping :) REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23664 To: kossebau, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau retitled this revision from "WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API" to "RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: koss

D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23800 To: kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a dependent revision: D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencre

D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a dependency: D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D23802 To: kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau edited the test plan for this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D23802 To: kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KService to hide deprecated API up to a given version or silence deprecation warnin

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a dependent revision: D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23789 To: kossebau Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencre

D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a dependency: D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23800 To: kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KCoreAddons to hide deprecated API up to a given version or silence deprecation war

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 65678. kossebau added a comment. - change BEFORE to BEFORE_AND_AT, to match actual Qt behaviour (though do not copy confusing name, but be more precise using AND_AT - add NO_DEFINITION_EXPORT_TO_BUILD_INTERFACE option REPOSITORY R240 Extra CMake Modu

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. In D23789#527769 , @cgiboudeaux wrote: > Tests needed :) Sure :) Will be done, once I know investment makes sense. For now interested in feedback whether the principle approach makes sense and is welcome/wanted,

D23791: ECMAddQch: add INCLUDE_DIRS argument

kossebau created this revision. kossebau added a reviewer: Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows to have headers be found by doxygen, e.g.

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. Current version works already quite well, developed against applying it to a few tier-1 and tier-2 KDE Frameworks modules. A few corner casess still need care, but otherwise already pretty much a prototype which is not too far from a production version. So fee

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Generates additional macros in the export header which can be used for fine-grained dis

D23696: completion: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:7679bf28f6c0: completion: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D23703: (others): Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:90aa6c665ed3: (others): Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23

D23702: utils: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:7449bb5a8f2e: utils: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23702

D23701: undo: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c365f1e9a2d3: undo: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23701?

D23700: view: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:d35377978a90: view: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23700?

D23699: mode: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2d582d7f8d46: mode: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23699?

D23698: document: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:84bb5661927b: document: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23

D23697: buffer: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:b9167245dd3d: buffer: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2369

D23597: Bulk port away from foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R236:549fc06ffa21: Bulk port away from foreach (authored by kossebau). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23597?vs=65089&id=65614 REVISION DETAIL h

D23772: Make less use of deprecated enum alias NET::StaysOnTop

This revision was automatically updated to reflect the committed changes. kossebau marked an inline comment as done. Closed by commit R278:c747c71d7146: Make less use of deprecated enum alias NET::StaysOnTop (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23772?vs=6

D23418: KStartupInfo: drop dead code for removing quotes from data values

This revision was automatically updated to reflect the committed changes. Closed by commit R278:14519d311709: KStartupInfo: drop dead code for removing quotes from data values (authored by kossebau). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23418?v

D23772: Make less use of deprecated enum alias NET::StaysOnTop

kossebau added a comment. @zzag: Thanks for review. Will land once KF 5.62 is branched this WE. INLINE COMMENTS > zzag wrote in netwininfotestwm.cpp:449 > We can remove this row now. Indeed, does the same test as the row above, good catch, Will remove then. REPOSITORY R278 KWindowSystem

D23418: KStartupInfo: drop dead code for removing quotes from data values

kossebau added a reviewer: KWin. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D23418 To: kossebau, #plasma, hein, broulik, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23772: Make less use of deprecated enum alias NET::StaysOnTop

kossebau added a comment. Found while experimenting with code for T11490 . This patch would later allow to do a simple #if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5, 0) /** @deprecated This is an obsolete name for Kee

D23772: Make less use of deprecated enum alias NET::StaysOnTop

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY - use NET::KeepAbove instead of NET::StaysOnTop in code - deduplicate code ha

D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:67acfe3c9c46: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg (authored by kossebau). REPOSI

D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

kossebau added a comment. Given ECM 5.62 will be tagged this WE and thus the API of the new macro `ecm_qtdesignerplugin_widget` being frozen, and no-one really gave feedback on the initial API, would take the responsibility and push tonight, unless there is last minute discussion. Only users

D23726: Designer plugin: adapt to pre-release API change of ECMAddQtDesignerPlugin

kossebau abandoned this revision. kossebau added a comment. No longer needed with latest change to still alllow CONSTRUCTOR_ARGS_CODE for convenience. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23726 To: kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2

D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

kossebau updated this revision to Diff 65514. kossebau added a comment. For convenience still enable CONSTRUCTOR_ARGS_CODE, usually simple string without ";" REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23725?vs=65396&id=65514 BRANCH crea

D23726: Designer plugin: adapt to pre-release API change of ECMAddQtDesignerPlugin

kossebau created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R236 KWidgetsAddons BRANCH adapttoecmaddqtpluginchange REVISION DETAIL https://phabrica

D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

kossebau added a dependent revision: D23726: Designer plugin: adapt to pre-release API change of ECMAddQtDesignerPlugin. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23725 To: kossebau, #frameworks, #build_system, vkrause Cc: kde-frameworks-devel, kde-bui

D23726: Designer plugin: adapt to pre-release API change of ECMAddQtDesignerPlugin

kossebau added a dependency: D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23726 To: kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

kossebau created this revision. kossebau added reviewers: Frameworks, Build System, vkrause. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The initial API asked to hav

D23711: Improve "user-trash" icon

kossebau added a comment. Maybe it's because I am thirsty rigt now, but the new user-full-trash on a quick look also resembles a full fresh beer glass waiting to be emptied :) Not sure this association improves my life :P REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.

D23695: autotests: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:54e241d18779: autotests: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D23695: autotests: Port away from foreach loops over members without calls to owner

kossebau added a comment. I have never seen a range-based for loop with qmap/qhash. But then I also only now learned about the existence of QKeyValueIterator being triggered by your question :) Looking further, given the definition of range-for, for what I understand, we are still out o

D23695: autotests: Port away from foreach loops over members without calls to owner

kossebau added a comment. In D23695#525155 , @cullmann wrote: > thought not sure why a range based for doesn't work on the m_codesToSpecialKeys stuff with qAsConst. But I assume that has some reason and it is just testing code anyways. T

D23703: (others): Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23702: utils: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23701: undo: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23700: view: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23696: completion: Port away from foreach loops over members without calls to owner

kossebau edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23696 To: kossebau, #kate Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23699: mode: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23698: document: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23697: buffer: Port away from foreach loops over members without calls to owner

kossebau edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23697 To: kossebau, #kate Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23697: buffer: Port away from foreach loops over members without calls to owner

kossebau added a comment. Also candidate for post 5.62-tagging, for some weeks of testing in master. Like all the following review requests. only the autotest one should be good to go in before, not critical to users. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.or

D23697: buffer: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23696: completion: Port away from foreach loops over members without calls to owner

kossebau added a comment. Candidate for post 5.62-tagging, for some weeks of testing in master. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23696 To: kossebau, #kate Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, de

D23696: completion: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23695: autotests: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimatio

D23689: Port away from Qt's foreach all loops over rvalue container objects

This revision was automatically updated to reflect the committed changes. Closed by commit R39:baea21ac638f: Port away from Qt's foreach all loops over rvalue container objects (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23689?vs=

D23689: Port away from Qt's foreach all loops over rvalue container objects

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY The other simple part of foreach porting, as those containers objec

D23664: Port away from Qt's foreach all loops over method-local containers

kossebau edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23664 To: kossebau, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23661: Port away from Qt's foreach all loops over method-local containers

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2ee34748cdb8: Port away from Qt's foreach all loops over method-local containers (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23661?vs=6

D23625: Use QString::count(QChar) over QString::split().length() - 1

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in normalvimode.cpp:3844 > Ah, no, textLines.last().length() needs the string section, so just a plain > count would not be enough, only if combining with a QString::section call > later, I now remember. > And some other patch sim

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH morecountoverspl

D23625: Use QString::count(QChar) over QString::split().length() - 1

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in normalvimode.cpp:3844 > Guess the complete change missed to enter the commit, and review did not > catch it, > Well spotted, I shall do a follow-up. Ah, no, textLines.last().length() needs the string section, so just a plain c

D23625: Use QString::count(QChar) over QString::split().length() - 1

kossebau added inline comments. INLINE COMMENTS > apol wrote in normalvimode.cpp:3844 > you didn't port this one to count? Guess the complete change missed to enter the commit, and review did not catch it, Well spotted, I shall do a follow-up. REPOSITORY R39 KTextEditor REVISION DETAIL ht

D23664: Port away from Qt's foreach all loops over method-local containers

kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The simple porting, as those containers are not shared with anyone, so the remova

D23661: Port away from Qt's foreach all loops over method-local containers

kossebau added a comment. There are quite a lot of foreachs in ktexteditor, so IMHO it makes sense to split up the porting in multiple commits, so in case of regressions one can bisect in the overall changes a bit and then has fewer changes to reason about where something might have been bro

D23661: Port away from Qt's foreach all loops over method-local containers

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY The simple porting, as those containers are not shared with anyone,

D23626: Use QChar overload for single char strings where possible

kossebau added a comment. In D23626#523884 , @dhaumann wrote: > Do you have a clang-tidy plugin for such changes, or do you use a manual regexp for detection? Very unprofessionally I use the grep dialog of KDevelop, to collect hits of me

D23645: Do not generate string list at runtime

kossebau added inline comments. INLINE COMMENTS > dhaumann wrote in katemodemanager.cpp:214 > I would even prefer: > > static const auto commonSuffixes = { ... }; > > This way it's an initializer_list and a pattern we use at other places in > KTextEditor as well. But of course, your patch is

D23645: Do not generate string list at runtime

This revision was automatically updated to reflect the committed changes. Closed by commit R39:a7212d561de1: Do not generate string list at runtime (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23645?vs=65164&id=65170 REVISION DETA

D23645: Do not generate string list at runtime

kossebau updated this revision to Diff 65164. kossebau added a comment. now as plain array REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23645?vs=65124&id=65164 BRANCH preparelistatbuildtie REVISION DETAIL https://phabricator.kde.org/D23645 AFFEC

D23645: Do not generate string list at runtime

kossebau added a comment. (And thanks for all the quick review :) ) In D23645#523622 , @cullmann wrote: > Hmm, could we here now avoid the QStringList completely and just use a normal array with a range based for below? Okay, looks l

D23646: Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:ede4725394e9: Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0) (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23646?vs=65125&id=65161#toc REPOSITORY R39 KTextEd

D23641: Use s.mid(n) instead of s.right(s.size() - n)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:a11e13d30378: Use s.mid(n) instead of s.right(s.size() - n) (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23641?vs=65117&id=65158 REVISI

D23633: Use s.chop(n) instead of s = s.left(s.length() - n)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:35537b5e1efd: Use s.chop(n) instead of s = s.left(s.length() - n) (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23633?vs=65108&id=65156

D23634: Use more QString::leftRef where possible

This revision was automatically updated to reflect the committed changes. Closed by commit R39:6e26fc41f7b1: Use more QString::leftRef where possible (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23634?vs=65109&id=65159#toc REPOSITORY R39 KTextEditor CHANGES S

D23630: Use QString(int, QChar) instead of QStringLiteral(" ").repeated(int)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:842486d3d10d: Use QString(int, QChar) instead of QStringLiteral(" ").repeated(int) (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23630?vs

D23644: Use more QString::splitRef

This revision was automatically updated to reflect the committed changes. Closed by commit R39:6532ee50669e: Use more QString::splitRef (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23644?vs=65123&id=65162#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDA

D23632: Use s.truncate(n) instead of s = s.left(n)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:8f76508792cc: Use s.truncate(n) instead of s = s.left(n) (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23632?vs=65107&id=65155 REVISION

D23626: Use QChar overload for single char strings where possible

This revision was automatically updated to reflect the committed changes. Closed by commit R39:3f993a2b9c05: Use QChar overload for single char strings where possible (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23626?vs=65101&id=65152#toc REPOSITORY R39 KText

D23637: Use more QString::midRef where possible

This revision was automatically updated to reflect the committed changes. Closed by commit R39:d77ce06e8e9d: Use more QString::midRef where possible (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23637?vs=65114&id=65160#toc REPOSITORY R39 KTextEditor CHANGES SI

D23642: Use QStringLiteral instead of runtime conversion to QString

This revision was automatically updated to reflect the committed changes. Closed by commit R39:e3cb6a131764: Use QStringLiteral instead of runtime conversion to QString (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23642?vs=65120&id

D23629: Use QLatin1String over QStringLiteral in string concatenation

This revision was automatically updated to reflect the committed changes. Closed by commit R39:67ed8cbdf954: Use QLatin1String over QStringLiteral in string concatenation (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23629?vs=65121&id=65154#toc REPOSITORY R39 K

D23625: Use QString::count(QChar) over QString::split().length() - 1

This revision was automatically updated to reflect the committed changes. Closed by commit R39:a5783ba11943: Use QString::count(QChar) over QString::split().length() - 1 (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23625?vs=65100&i

D23646: Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0)

kossebau added inline comments. INLINE COMMENTS > kateviewhelpers.cpp:1191 > { > +static const QRegularExpression > focusChangingCommands(QStringLiteral("^(buffer|b|new|vnew|bp|bprev|bn|bnext|bf|bfirst|bl|blast|edit|e)$")); > + Refactoring to one static object will be separate commit. REP

D23646: Use s.leftRef(s.indexOf(c)) instead of s.split(c).at(0)

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH leftrefnotsplit

D23645: Do not generate string list at runtime

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH preparelistatbui

D23644: Use more QString::splitRef

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH moresplitref RE

D23629: Use QLatin1String over QStringLiteral in string concatenation

kossebau updated this revision to Diff 65121. kossebau added a comment. two more case found REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23629?vs=65104&id=65121 BRANCH usemoreqlatin1string REVISION DETAIL https://phabricator.kde.org/D23629 AFFEC

D23642: Use QStringLiteral instead of runtime conversion to QString

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY Detected by clazy GIT_SILENT REPOSITORY R39 KTextEditor BRANC

<    4   5   6   7   8   9   10   11   12   13   >