Re: Review Request 125158: add logic to use icons for default xdg user dirs

966d8626708a8f2672f1777c873f4e27e13023d6 Diff: https://git.reviewboard.kde.org/r/125158/diff/ Testing --- maked autotested installed dolphin and file open dialogs now show icons Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 125158: add logic to use icons for default xdg user dirs

isDirectoryMounted(url)) { > > // iconFromDirectoryFile > > } > > } I ordered this the other way around as we want .directory to take preference over the standardpath icon - Harald ----------

Re: Review Request 125158: add logic to use icons for default xdg user dirs

itemtest.cpp 5f728a411401fe3009924b66970d9ae6f12c60f2 src/core/kfileitem.cpp 966d8626708a8f2672f1777c873f4e27e13023d6 Diff: https://git.reviewboard.kde.org/r/125158/diff/ Testing --- maked autotested installed dolphin and file open dialogs now show icons Thanks, H

Re: Review Request 125158: add logic to use icons for default xdg user dirs

tps://git.reviewboard.kde.org/r/125158/#comment59432> This actually makes my eyes bleed a fair amount. Are there any objections to moving the struct declaration out of the function? If so, any perferences on where to put it? Other suggestions also very welcome. - Harald Sitter On Oct. 2, 2015,

Re: qca-qt5 (qt5 branch) merge into qca (master branch)

QCA's qt5 branch has now been merged back into master. master now behaves like qt5 did. If qt5 is found libqca-qt5 is built, if it isn't found qt4 is a requirement and libqca will be built. You can override this behavior by using the cmake option QT4_BUILD. Going to prep a tarball shortly. HS

Re: kcrash when started from terminal

n Thu, Sep 24, 2015 at 9:30 AM, David Faure <fa...@kde.org> wrote: > On Wednesday 23 September 2015 14:24:33 Harald Sitter wrote: >> Heya >> >> is it intentional that KCrash is not running when an application is >> started via kdeinit? >> >> In particul

qca-qt5 (qt5 branch) merge into qca (master branch)

ahoy ahoy qca-qt5 as a "thing" is a build time switch on the same source as qca (qt4). so, it is the same source base but depending on how you run cmake you either get the qt5 or the qt4 build. originally various adjustments had to be made to qca-qt5 to make it work reliably without conflicting

Review Request 125343: bump so version from 5 to 6

, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125284: make install name of applications.menu file a cached cmake variable

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125284/#review85701 ----------- On Sept. 17, 2015, 9:32 a.m., Harald Sitter wrote: > > -

Re: marble builds when it shouldn't

On Wed, Sep 23, 2015 at 11:13 AM, Ben Cooksley wrote: > On Wed, Sep 23, 2015 at 7:25 AM, Scarlett Clark > wrote: >> That is correct. I have turned this off and on so many times it is not >> funny. Somehow everyone needs to agree on this. > >

Re: Review Request 125284: make install name of applications.menu file a cached cmake variable

marked as submitted. Review request for KDE Frameworks, David Faure, Jonathan Riddell, and Rex Dieter. Changes --- Submitted with commit 16e6b2b6a10622b060c22201085e26e8abcd60e2 by Harald Sitter to branch master. Repository: kservice Description --- To not conflict

Review Request 128115: do not load and debug in the same line

it might make debugging harder if something fails in an isolated testbed (e.g. CI) Diffs - autotests/knewstuffentrytest.cpp a886afc514abfa21b6396a8b2c8c3a88d65b4a5d Diff: https://git.reviewboard.kde.org/r/128115/diff/ Testing --- makes && test passes Thanks, Haral

Re: Review Request 128114: do not load and debug in the same line

14/#review96247 --- On June 7, 2016, 8:48 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128114/ > --

Review Request 128114: do not load and debug in the same line

Diff: https://git.reviewboard.kde.org/r/128114/diff/ Testing --- makes && passes test Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128114: do not load and debug in the same line

marked as submitted. Review request for KDE Frameworks, Andreas Cord-Landwehr and Jeremy Whiting. Changes --- Submitted with commit 81e2895b40684e275aadc944cdbc2f333a20782f by Harald Sitter to branch master. Repository: knewstuff Description --- if debugging is off the line is no-op

Re: Review Request 128147: isolate autotests from (installed) production data

://git.reviewboard.kde.org/r/128147/diff/ Testing --- make && test && install => all good Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128147: isolate autotests from (installed) production data

/tongue.png PRE-CREATION autotests/kemoticontest.cpp fdada9dfdaf9938e48f86face8e60c853ba54da3 autotests/ktexttohtmlplugintest.cpp 9326430f0a4e6545c4507ec9b4dfe64414dd0e4b Diff: https://git.reviewboard.kde.org/r/128147/diff/ Testing --- make && test && install => all goo

Re: Review Request 128065: move glass theme to kde-look.

knewstuff Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128065: move glass theme to kde-look.

/wink.png 166aef1e5675dabd41ce1a868c9f1d53cc494cc2 Diff: https://git.reviewboard.kde.org/r/128065/diff/ Testing --- builds and installs version from kde-look also installs via knewstuff Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list

Review Request 128072: add missing type_traits include making sure std::enable_if is declared

&& make test Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125343: bump so version from 5 to 6

ebd4b8981a658665a42140250b6eb3d92662e607 Diff: https://git.reviewboard.kde.org/r/125343/diff/ Testing --- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128072: add missing type_traits include making sure std::enable_if is declared

marked as submitted. Review request for KDE Frameworks and Gleb Popov. Changes --- Submitted with commit 8ab7daa8cbd54a51319a9086e3f143ad0559d3ae by Harald Sitter to branch master. Repository: kconfigwidgets Description --- fixes abi compliance test from http://build.neon.kde.org

Re: Review Request 128065: move glass theme to kde-look.

128065/#review96078 --- On May 31, 2016, 8:33 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://g

oxygen icon name clasheroo

Hola! Our most awesome icon maintainers wanted to carry over icon symlinking from breeze to oxygen, alas that turned up a whole slew of compatibility problems. examples: https://bugs.kde.org/show_bug.cgi?id=360605 https://bugs.kde.org/show_bug.cgi?id=360510 # Problem In kde4 software people

Re: oxygen icon name clasheroo

On Sun, Mar 20, 2016 at 10:08 AM, David Faure <fa...@kde.org> wrote: > On Wednesday 16 March 2016 15:57:45 Harald Sitter wrote: >> Hola! >> >> Our most awesome icon maintainers wanted to carry over icon symlinking >> from breeze to oxygen, alas that turned up

Review Request 127577: install index.theme to same directory it always was in

://git.reviewboard.kde.org/r/127577/diff/ Testing --- Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127577: install index.theme to same directory it always was in

marked as submitted. Review request for KDE Frameworks, David Faure, Jonathan Riddell, and Rex Dieter. Changes --- Submitted with commit 25a83b55f6b2439470bcc5d0963fd2ffa5c086ee by Harald Sitter to branch master. Repository: oxygen-icons5 Description --- otherwise we break

Re: Review Request 127743: mkpath instead of mkdir

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 90e8bb655f98722f6904c4aeb5b1089249814224 by Harald Sitter to branch master. Repository: kio Description --- if the parent directory/ies does not exist yet mkdir would fail even when

Review Request 127759: fix unresolvable types by adding relevant includes

ake test - abi-compliance-checker happy Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127759: fix unresolvable types by adding relevant includes

marked as submitted. Review request for KDE Frameworks and David Edmundson. Changes --- Submitted with commit 95e30fd2668700374140d4c590aa96dd6d1f593d by Harald Sitter to branch master. Repository: kcoreaddons Description --- - QString for versionString - uint is a typedef, use

Re: Review Request 127764: warn about need for production data, skip tests that depend on them

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit c9e8c4b38c0d633b9e288169f647bceebddda72f by Harald Sitter to branch master. Repository: plasma-framework Description --- numerous icon tests expect the actual production plasma

Review Request 127764: warn about need for production data, skip tests that depend on them

/127764/diff/ Testing --- test passes in minimal environment - skips when xdg_data is not set - doesnt' skip with data set - skips when hicolor is not installed at all - passes when hicolor is installed Thanks, Harald Sitter ___ Kde-frameworks

Re: ECM metainfo path

On Fri, Apr 22, 2016 at 10:13 PM, Matthias Klumpp <matth...@tenstral.net> wrote: > 2016-04-22 12:45 GMT+02:00 Harald Sitter <sit...@kde.org>: >> Lost mailing list CC, I am assuming that was intentional? (: > > Oops, no - I didn't see the CC and didn't hit reply-all the

Review Request 127743: mkpath instead of mkdir

.cpp 9f9d9449b2f06f33ac479b0b5fb47f26c169fb41 Diff: https://git.reviewboard.kde.org/r/127743/diff/ Testing --- tested the at the outlined scenario works make test still passes Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-framew

Re: Broken ABI in networkmanager-qt

On Tue, May 17, 2016 at 11:06 AM, Jan Grulich wrote: > Hi, > > we decided to drop WiMAX support in nm-qt when it's compiled against NM 1.2.0, > but this seems to break binary compatibility when nm-qt was previously build > against older NM version. I didn't realize this

Re: Review Request 127905: refine current icon theme heuristics

marked as submitted. Review request for KDE Frameworks, Christoph Feck and Marco Martin. Changes --- Submitted with commit 1425523dad0ba4f3acb9d0caa0ff772fd0a1a7e2 by Harald Sitter to branch master. Repository: kiconthemes Description --- this is to prevent incorrect default themes

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

with the presented ::forceCurrent we can solve the issue at hand and reduce overhead code in testing. - Harald --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127952/#review

Re: Review Request 127953: rename fake icon set to hicolor as oxygen is no longer a fallback

marked as submitted. Review request for KDE Frameworks and Aleix Pol Gonzalez. Changes --- Submitted with commit cfc0a65e4dda986311c74f10797b09b1084a8e19 by Harald Sitter to branch master. Repository: kxmlgui Description --- rename fake icon set to hicolor as oxygen is no longer

Re: Review Request 127954: force icon themes explicitly via new testing helper function

marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit 6ad988cb3df6ca3eac302444182b68fef383770f by Harald Sitter to branch master. Repository: plasma-framework Description --- force icon themes explicitly via new testing

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

> On May 18, 2016, 9:58 a.m., Marco Martin wrote: > > src/kicontheme.h, line 223 > > <https://git.reviewboard.kde.org/r/127952/diff/1/?file=465111#file465111line223> > > > > what about just a testmode bool like qstandardpaths? > > Harald Sitter wrote:

Re: Review Request 127952: add a function to override the current theme heuristics with a static value

to use this Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127954: force icon themes explicitly via new testing helper function

/127954/diff/ Testing --- passes in session env. whether it passes in testbeds we'll see on jenkins :O Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127953: rename fake icon set to hicolor as oxygen is no longer a fallback

/actions/go-up.png autotests/icons/oxygen/64x64/actions/go-up.png autotests/icons/oxygen/index.theme Diff: https://git.reviewboard.kde.org/r/127953/diff/ Testing --- - test fails without /usr/share/icons and icons/oxygen fake dir - test passes with icons/hicolor Thanks, Harald Sitter

Review Request 127830: use QUrl::fromUserInput to construct sound url

fybyaudio.cpp 6ae63b8df8e7aa692e88b03ca7b7538c78101917 Diff: https://git.reviewboard.kde.org/r/127830/diff/ Testing --- builds & test pass & I trust my testing in https://git.reviewboard.kde.org/r/127829/ Thanks, Harald Sitter ___ Kde-frameworks-d

Review Request 127829: use QUrl::fromUserInput to construct sound url

onswidget.cpp 98286c4d0e8a7deec5d35986a261222931afb60d Diff: https://git.reviewboard.kde.org/r/127829/diff/ Testing --- built and played all of the above Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@

Re: Review Request 127829: use QUrl::fromUserInput to construct sound url

git.reviewboard.kde.org/r/127829/#review95167 ------- On May 4, 2016, 1:26 p.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To re

ECM metainfo path

ahoy ahoy! http://commits.kde.org/extra-cmake-modules/4b7a90bfe7a3e2eb3ae83c946c182a79fabc51e3 doesn't that break compatibility with older appstreams for everything that uses ECM? if so, I am not sure that is appropriate TBH HS ___

Re: Review Request 127830: use QUrl::fromUserInput to construct sound url

marked as submitted. Review request for KDE Frameworks and Martin Klapetek. Changes --- Submitted with commit 9db06adc8114163f401417064b07772139bc36bc by Harald Sitter to branch master. Bugs: 337276 https://bugs.kde.org/show_bug.cgi?id=337276 Repository: knotifications Description

Re: Review Request 127829: use QUrl::fromUserInput to construct sound url

marked as submitted. Review request for KDE Frameworks and Martin Klapetek. Changes --- Submitted with commit 4832f7d9f2f3bd0fa8ab9b9162bf50e855efc448 by Harald Sitter to branch master. Bugs: 337276 https://bugs.kde.org/show_bug.cgi?id=337276 Repository: knotifyconfig Description

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

> On July 13, 2016, 12:43 p.m., Kai Uwe Broulik wrote: > > +1 to the idea > > > > However, will this mean we get this awful apport "something crashed, now or > > in the past" tray icon in addition to Drkonqi? > > Harald Sitter wrote: > ye

Re: Review Request 128533: Create a test that validates projects' appstream information

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128533/#review98097 --- Ship it! Ship It! - Harald Sitter On Aug. 4, 2016, 11

Re: Review Request 128533: Create a test that validates projects' appstream information

somesuch magic If you actually pick up the result of the validation and then `message(STATUS` on ==0 or `message(FATAL_ERROR`, I think usefulness will go up 300% by actually claiming a validation fail when there was a fail :) - Harald Sitter On Aug. 3, 2016, 11:21

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

> On July 13, 2016, 12:43 p.m., Kai Uwe Broulik wrote: > > +1 to the idea > > > > However, will this mean we get this awful apport "something crashed, now or > > in the past" tray icon in addition to Drkonqi? > > Harald Sitter wrote: > ye

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

> On July 13, 2016, 12:43 p.m., Kai Uwe Broulik wrote: > > +1 to the idea > > > > However, will this mean we get this awful apport "something crashed, now or > > in the past" tray icon in addition to Drkonqi? > > Harald Sitter wrote: > ye

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

e.org/r/128437/#review97363 --- On July 13, 2016, 12:40 p.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128437/ > ---

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

m (e.g. RHEL) already > > explicitly disable DrKonqi. > > Harald Sitter wrote: > That's not what the change does. > > Kevin Kofler wrote: > It raises the crash to the downstream bug handler, which in turn will > unfortunately encourage the users to file the bug in the down

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

h as their use case is more involved. - Harald --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128437/#review97345 --- On July 13,

Review Request 128437: raise to core dump handlers when drkonqi is done

b8c6477a70291ca9c1f0efef3bba061b6af247b0 Diff: https://git.reviewboard.kde.org/r/128437/diff/ Testing --- builds and passes Thanks, Harald Sitter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 128065: move glass theme to kde-look.

marked as submitted. Review request for KDE Frameworks and Andreas Kainz. Changes --- Submitted with commit e5363599936edec5ff3f51ed378e1325ea4cd4d1 by Harald Sitter to branch master. Repository: kemoticons Description --- we don't need 300 default themes http://kde-look.org

Re: Review Request 128147: isolate autotests from (installed) production data

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 74d8f8ede542a51405f3b3e1d526ca2a93e30a78 by Harald Sitter to branch master. Repository: kemoticons Description --- this means - doesn't depend on Glass theme anymore - doesn't hardcode

kded's cmake package

Hola! So, I just noticed that KDED's cmake package is inconsistently named. cmake/KF5DocTools/ versus cmake/KDED/ Is there a reason for this? Are we going to change this for KF6? :/ HS ___ Kde-frameworks-devel mailing list

Review Request 128626: silence contentHash deprecation warnings

4f5b78761ced760f081b3449afc67790d25138a2 Diff: https://git.reviewboard.kde.org/r/128626/diff/ Testing --- builds & tests pass (sans appstream, which I guess I didn't break :P) Thanks, Harald Sitter

Re: kded's cmake package

On Fri, Jul 1, 2016 at 1:34 PM, Aleix Pol <aleix...@kde.org> wrote: > On Wed, Jun 29, 2016 at 11:22 AM, Harald Sitter <sit...@kde.org> wrote: >> Hola! >> >> So, I just noticed that KDED's cmake package is inconsistently named. >> >&g

breeze-icons and the symlink business

hola breeze-icons uses lots of symlinks. Unfortunately, ever so often our icon designers make a mistake and create a bad symlink. To mitigate this I added a bunch of tests making sure everything is nice and dandy. In the mean parts of the build were changed to not tolerate broken symlinks. While

Re: Phabricator: All repositories registered - upcoming workflow changes

On Thu, Feb 2, 2017 at 10:31 AM, Ben Cooksley wrote: > On Thu, Feb 2, 2017 at 10:23 PM, Luigi Toscano > wrote: >> Il 02.02.2017 10:09 Ben Cooksley ha scritto: >> >>> Hi all, >>> >>> As a starting point: keeping the software itself running is a >>>

[Differential] [Closed] D4254: add new test for scalable exposure

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7d01f3d8b5c0: add new test for scalable exposure (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4254?vs=10460=10757 REVISION DETAIL

Re: breeze-icons and the symlink business

On Thu, Feb 2, 2017 at 12:24 PM, Jaroslaw Staniek <stan...@kde.org> wrote: > > > On 2 February 2017 at 00:49, Harald Sitter <sit...@kde.org> wrote: >> >> hola >> >> breeze-icons uses lots of symlinks. Unfortunately, ever so often our >> ico

Re: Phabricator: All repositories registered - upcoming workflow changes

On Thu, Feb 2, 2017 at 6:17 PM, Ben Cooksley <bcooks...@kde.org> wrote: > On Thu, Feb 2, 2017 at 11:51 PM, Harald Sitter <sit...@kde.org> wrote: >> On Thu, Feb 2, 2017 at 10:31 AM, Ben Cooksley <bcooks...@kde.org> wrote: >>> On Thu, Feb 2, 2017 at 10:23 PM, Lui

[Differential] [Updated, 285 lines] D4254: add new test for scalable exposure

sitter updated this revision to Diff 10460. sitter added a comment. warning-- qdebug the limited testing of the test REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4254?vs=10459=10460 BRANCH master REVISION DETAIL

[Differential] [Request, 286 lines] D4254: add new test for scalable exposure

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY the icon themes use SVG but do not want the same icon to be used for small resolutions as to not have high-detail icons at super small

[Differential] [Request, 54 lines] D4268: deprecate the security class

sitter created this revision. sitter added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The Security class is not actually used, hasn't seen any active development in years and uses gpg in a

[Differential] [Accepted] D4448: Don't use tier3 frameworks in unit tests

sitter accepted this revision. sitter added a comment. Ah! I hadn't even thought of QSettings. Love the change. FWIW if you fancy more work: seeing as the test now has its own enums you could align the Context enum values' names with their string representation allowing `parseContext`

[Differential] [Closed] D4268: deprecate the security class

This revision was automatically updated to reflect the committed changes. Closed by commit R304:0dc151ae2c8b: deprecate the security class (authored by sitter). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4268?vs=10491=10501 REVISION DETAIL

knewstuff's gpg use

Morning, I had the most peculiar incident just now. KNewstuff shouted at me because I have no bin/gpg(2). As it turns out core/security.cpp implements some form of gpg signing verification. Based on the gpg CLI app. Naturally, I am perplexed by this because CMake doesn't actually report gpg as a

Review Request 129028: introduce dupe test from breeze-icons

autotests/dupetest.cpp PRE-CREATION autotests/testdata.h.cmake 476cf9ebf8b45c65e5479e14adcb1ea352e1f24d autotests/testhelpers.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129028/diff/ Testing --- Thanks, Harald Sitter

Review Request 128913: add a test to prevent file names from having newlines

and fails current master since it has broken files Thanks, Harald Sitter

Re: Review Request 128913: add a test to prevent file names from having newlines

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b92ae8cde0643fe9d77fda8f7470d97bed6f689f by Harald Sitter to branch master. Repository: breeze-icons Description --- there is no reason for why they should. packaging systems take offense. so

Re: Review Request 128913: add a test to prevent file names from having newlines

/CMakeLists.txt 5c561c712322e1b90fdd2806ba4ce4011be2ad14 autotests/newlinetest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128913/diff/ Testing --- makes and fails current master since it has broken files Thanks, Harald Sitter

Re: Review Request 128913: add a test to prevent file names from having newlines

oard.kde.org/r/128913/#review99187 --- On Sept. 15, 2016, 8:17 a.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 85eef3241e45a0f1799069fa687f68ed9f802ef9 by Harald Sitter to branch master. Repository: kcrash Description --- with the rise of useful core dump handlers such as systemd's coredump

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

.org/r/128437/diff/ Testing --- builds and passes Thanks, Harald Sitter

Re: Review Request 129028: introduce dupe test from breeze-icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129028/#review99607 --- Ship it! shipping as part of 129026 - Harald Sitter

Re: Review Request 129028: introduce dupe test from breeze-icons

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 54a388ecb700f9e0030ce66535fe84b0e22276b1 by Harald Sitter to branch master. Repository: oxygen-icons5 Description --- this test uses the external binary fdupes to find duplicated files

Re: Review Request 128115: do not load and debug in the same line

/128115/diff/ Testing --- makes && test passes Thanks, Harald Sitter

Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

/CMakeLists.txt 9e3f841d951afb007cba3da79c217e9c2a3e38da autotests/dupetest.cpp PRE-CREATION autotests/testdata.h.cmake 476cf9ebf8b45c65e5479e14adcb1ea352e1f24d Diff: https://git.reviewboard.kde.org/r/129021/diff/ Testing --- correctly detects all the nasty dupes Thanks, Harald Sitter

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

FAIL unwind the stack? - Harald --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129021/#review99526 --- On Sept. 26, 2016

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

15047ea72f95cbaa4578668e59ad687faa8ae230 autotests/testdata.h.cmake 476cf9ebf8b45c65e5479e14adcb1ea352e1f24d autotests/testhelpers.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129021/diff/ Testing --- correctly detects all the nasty dupes Thanks, Harald Sitter

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

15047ea72f95cbaa4578668e59ad687faa8ae230 autotests/testdata.h.cmake 476cf9ebf8b45c65e5479e14adcb1ea352e1f24d autotests/testhelpers.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129021/diff/ Testing --- correctly detects all the nasty dupes Thanks, Harald Sitter

Re: Review Request 129021: add a test to find duplicated files (inspired by similar test in debian)

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 343b7ecce2c1a7e42a7a913258d65e993b603bce by Harald Sitter to branch master. Repository: breeze-icons Description --- run a duplicate detection program on the icon dir trees to detect

Review Request 129024: fail the entire dupe test if fdupes is not present

Description --- ctest doesn't know about skip or anything but fail, so in the interest of getting reports on this fail the test Diffs - autotests/dupetest.cpp bf1a67ccff789b5d3bdbe1c730d8c3441691a025 Diff: https://git.reviewboard.kde.org/r/129024/diff/ Testing --- Thanks, Harald

Re: Review Request 129024: fail the entire dupe test if fdupes is not present

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 92fda2493cc40fe8a243722f5a6630ae050d4367 by Harald Sitter to branch master. Repository: breeze-icons Description --- ctest doesn't know about skip or anything but fail, so in the interest

Re: Review Request 128626: silence contentHash deprecation warnings

9b1cadec2296132c2ec4a7fc8142ec34cb3381f1 src/kpackagetool/kpackagetool.cpp 4f5b78761ced760f081b3449afc67790d25138a2 Diff: https://git.reviewboard.kde.org/r/128626/diff/ Testing --- builds & tests pass (sans appstream, which I guess I didn't break :P) Thanks, Harald Sitter

python binding's __init__.py

Alohas I am currently trying to package kitemmodels' python bindings. The module generator installs -./usr/lib/python2.7/dist-packages/PyKF5/__init__.py -./usr/lib/python2.7/dist-packages/PyKF5/KItemModels.so This will cause a fairly shitty problem on packaging level, when a second framework

Re: python binding's __init__.py

On Tue, Nov 15, 2016 at 4:04 PM, Stephen Kelly <steve...@gmail.com> wrote: > Harald Sitter wrote: > >> Alohas >> >> I am currently trying to package kitemmodels' python bindings. The >> module generator installs >> >> -./usr/lib/python2.7/dist-pa

Review Request 129426: refactor gpg finding

://git.reviewboard.kde.org/r/129426/diff/ Testing --- builds and continues to link to gpg Thanks, Harald Sitter

Re: Review Request 129426: refactor gpg finding

iewboard.kde.org/r/129426/#review100933 ------- On Nov. 18, 2016, 2 p.m., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 129517: don't ignore return value, verify it

still Thanks, Harald Sitter

Re: Review Request 129426: refactor gpg finding

r > > the old one to the new one. > > Harald Sitter wrote: > You take offense with an if checking whether we can build with gpg > support? > > Andreas Sturmlechner wrote: > It does the opposite of what you say you want in the description. > Preferring the new lib is t

Re: Review Request 129426: refactor gpg finding

r > > the old one to the new one. > > Harald Sitter wrote: > You take offense with an if checking whether we can build with gpg > support? > > Andreas Sturmlechner wrote: > It does the opposite of what you say you want in the description. > Preferring the new lib is t

Re: Review Request 129426: refactor gpg finding

/CMakeLists.txt 2f99bc3cca89dd7a194f46cb314d2f7f90f931f3 tests/kwalletd/CMakeLists.txt 1e7c4b77ba478147fae964f61c28a736e32b9ea9 Diff: https://git.reviewboard.kde.org/r/129426/diff/ Testing --- builds and continues to link to gpg Thanks, Harald Sitter

<    1   2   3   4   5   6   7   8   9   10   >