from:"Helio Castro"

D7884: - Increase size of trailing mark

2017-10-17 Thread Helio Castro

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:92ec63dd1b07: - Increase size of trailing mark (authored 
by helio).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7884?vs=20330=20903

REVISION DETAIL
  https://phabricator.kde.org/D7884

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateviewinternal.cpp

To: helio, mwolff, kfunk, cullmann
Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks, kevinapavew

D7884: - Increase size of trailing mark

2017-10-17 Thread Helio Castro

helio added a comment.


  In https://phabricator.kde.org/D7884#154232, @sars wrote:
  
  > I'm OK with an option for this. The only problem, with the option in the 
screen-shot, is that it could be interpreted as also effecting the tabulator 
mark.
  
  
  I did not changed the current behavior, if you keep in the same initial 
level, all stays same.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks, kevinapavew

D7884: - Increase size of trailing mark

2017-10-10 Thread Helio Castro

helio added a comment.


  Ping ?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7884: - Increase size of trailing mark

2017-10-04 Thread Helio Castro

helio updated this revision to Diff 20330.
helio added a comment.


  Rebase on current master

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7884?vs=19888=20330

BRANCH
  big_trailing

REVISION DETAIL
  https://phabricator.kde.org/D7884

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateviewinternal.cpp

To: helio, mwolff, kfunk
Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7884: - Increase size of trailing mark

2017-09-25 Thread Helio Castro

helio added a comment.

  In https://phabricator.kde.org/D7884#148489, @cullmann wrote:

  > I would rather go with the "make the markers much larger but less contrast" 
solution than a setting for their size.
  >  Perhaps we really just need to look at how other editors do that.
  >  Eye-cancer like markers are no solution either, but I agree that if people 
turn them on, they should be able to spot them easily.

  And then will end up with the regular "this size is not good to me, can you 
make larger/smaller ?".
  Unfortunately, no size fits all, so i made the reasonable assumption to go 
from the original size to the near character size. 
  I honestly think that this will cover the 99% of users that will need this 
feature.

  This is how it appears on vim:
  F3943600: on_vim.png 

  We don't have the option on gedit.

  On Atom, we can't change color, we just can change the character of 
"Invisibles", which makes very bad at least on my screen:
  F3944421: atom.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7884: - Increase size of trailing mark

2017-09-25 Thread Helio Castro

helio added a comment.


  Fixed requests

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7884: - Increase size of trailing mark

2017-09-25 Thread Helio Castro

helio updated this revision to Diff 19888.
helio marked 3 inline comments as done.
helio added a comment.


  - Moved calc logic to updateMarkerSize
  - Fix identation
  - Make value properly float
  - Update view when apply pressed

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7884?vs=19786=19888

BRANCH
  big_trailing

REVISION DETAIL
  https://phabricator.kde.org/D7884

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateviewinternal.cpp

To: helio, mwolff, kfunk
Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7884: - Increase size of trailing mark

2017-09-24 Thread Helio Castro

helio added a comment.


  Is not that simple.
  Change only the color is fine, but then the effect is almost imperceptible,
  Right now from home i'm using a 25' 2560x1440 resolution with fonts in size 
10. Is a regular monitor, not the most expensive. 
  Even changing the color a single pixel is barely visible. And yes, the fonts 
are.
  If i go to HiDPI screen this becomes totally impossible to see ( unless you 
have eagle eyes ). This cases using a light background or white.
  If you are using darker backgrounds, like i use Breeze Dark, a pixel even on 
the most bright red color still mixed up. So, no good.
  
  To make my case mor appealing, all the other tools that we use, from simple 
vim to gerrit revision system shows a big mark, way more visible and this is 
essential to use to fix on the editor side or reject in gerrit side. So the 
only way that makes impossible to see the characters visible is kate. Assuming 
the current state is "good enought" of all cases was not a true statement

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: dhaumann, sars, #frameworks, cullmann

D7884: - Increase size of trailing mark

2017-09-22 Thread Helio Castro

helio added a comment.


  F3921383: configsize.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: sars, #frameworks, cullmann, dhaumann

D7884: - Increase size of trailing mark

2017-09-22 Thread Helio Castro

helio updated this revision to Diff 19786.
helio added a comment.


  - Make size configurable keeping the original default

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7884?vs=19686=19786

BRANCH
  big_trailing

REVISION DETAIL
  https://phabricator.kde.org/D7884

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: helio, mwolff, kfunk
Cc: sars, #frameworks, cullmann, dhaumann

D7884: - Increase size of trailing mark

2017-09-20 Thread Helio Castro

helio added a comment.


  Result of change using kdevelop
  F3918646: screenshot.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: #frameworks, cullmann, sars, dhaumann

D7884: - Increase size of trailing mark

2017-09-20 Thread Helio Castro

helio updated this revision to Diff 19686.
helio added a comment.


  - Using same code guideline as previous entry

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7884?vs=19685=19686

BRANCH
  big_trailing

REVISION DETAIL
  https://phabricator.kde.org/D7884

AFFECTED FILES
  src/render/katerenderer.cpp

To: helio, mwolff, kfunk
Cc: #frameworks, cullmann, sars, dhaumann

D7884: - Increase size of trailing mark

2017-09-20 Thread Helio Castro

helio added reviewers: mwolff, kfunk.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: #frameworks, cullmann, sars, dhaumann

D7884: - Increase size of trailing mark

2017-09-20 Thread Helio Castro

helio created this revision.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  On HiDPI screens and/or usage of small fonts current size of marker is
  so small making it almost invisible, even with a saturated color choice.
  This is specially visible on darker themes.

REPOSITORY
  R39 KTextEditor

BRANCH
  big_trailing

REVISION DETAIL
  https://phabricator.kde.org/D7884

AFFECTED FILES
  src/render/katerenderer.cpp

To: helio
Cc: #frameworks, cullmann, sars, dhaumann

Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

2014-09-29 Thread Helio Castro


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120421/
---

Review request for KDE Frameworks.


Repository: kauth


Description
---

- Update cmake files to match official polkit package, then enabling to use 
different include direcories


Diffs
-

  src/ConfigureChecks.cmake 70b9f7d22c7b30f92868d36d07b12a3a3a650655 

Diff: https://git.reviewboard.kde.org/r/120421/diff/


Testing
---


Thanks,

Helio Castro

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

2014-09-29 Thread Helio Castro



 On Sept. 29, 2014, 1:36 p.m., Aleix Pol Gonzalez wrote:
  Shouldn't include directories be dragged by polkit-qt? Maybe we should fix 
  polkit-qt cmake files to do so?

Nope, this is not automatic and we're talking about polkit-qt5-1. If you look 
on the cmake file, there's include directories for older polkit-qt, but was 
clearly missing on polkit-qt5-1.


- Helio


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120421/#review67622
---


On Sept. 29, 2014, 12:59 p.m., Helio Castro wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120421/
 ---
 
 (Updated Sept. 29, 2014, 12:59 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kauth
 
 
 Description
 ---
 
 - Update cmake files to match official polkit package, then enabling to use 
 different include direcories
 
 
 Diffs
 -
 
   src/ConfigureChecks.cmake 70b9f7d22c7b30f92868d36d07b12a3a3a650655 
 
 Diff: https://git.reviewboard.kde.org/r/120421/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Helio Castro
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

2014-09-29 Thread Helio Castro



 On Sept. 29, 2014, 1:36 p.m., Aleix Pol Gonzalez wrote:
  Shouldn't include directories be dragged by polkit-qt? Maybe we should fix 
  polkit-qt cmake files to do so?
 
 Helio Castro wrote:
 Nope, this is not automatic and we're talking about polkit-qt5-1. If you 
 look on the cmake file, there's include directories for older polkit-qt, but 
 was clearly missing on polkit-qt5-1.
 
 Hrvoje Senjan wrote:
 but i wonder 2 things, first why is this needed, second, why not fix 
 polkit-qt-1 then?

This is needed in cases of some distribution, im my case Fedora, decides to put 
as example include subdirectories in something like this 
/usr/include/polkit-qt5-1/PolkitQt1/.
Is a general way, the way kauth cmakefile is set, it will work everytime IF you 
have the regular polkit install in the include root, which is the usual case , 
but this would invalidate such special cases.

The PolkitQt5-1Config.cmake provided by library indeed has the settings for 
this case, so, is not wrong at all unless we assume that include directories 
should be mandatory when cmake is configuring package. 

The second part of the patch on linking assumes that the polkit is a component, 
but is not defined in the library upstream cmake file, there indeed i agree 
that could be added, but still would not solve the current issue ;-)


- Helio


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120421/#review67622
---


On Sept. 29, 2014, 12:59 p.m., Helio Castro wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120421/
 ---
 
 (Updated Sept. 29, 2014, 12:59 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kauth
 
 
 Description
 ---
 
 - Update cmake files to match official polkit package, then enabling to use 
 different include direcories
 
 
 Diffs
 -
 
   src/ConfigureChecks.cmake 70b9f7d22c7b30f92868d36d07b12a3a3a650655 
 
 Diff: https://git.reviewboard.kde.org/r/120421/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Helio Castro
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

2014-09-29 Thread Helio Castro


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120421/
---

(Updated Sept. 29, 2014, 6:26 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kauth


Description
---

- Update cmake files to match official polkit package, then enabling to use 
different include direcories


Diffs
-

  src/ConfigureChecks.cmake 70b9f7d22c7b30f92868d36d07b12a3a3a650655 

Diff: https://git.reviewboard.kde.org/r/120421/diff/


Testing
---


Thanks,

Helio Castro

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

D7884: - Increase size of trailing mark

Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

18 matches

Site Navigation

Mail list logo

Footer information