D12945: kcoredirlister lstItems benchmark

jtamate added a dependency: D13211: Enable comparing KFileItems by url. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12945 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13211: Enable comparing KFileItems by url

jtamate created this revision. jtamate added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Based on QUrl comparisons (available since Qt 5.4).

D13211: Enable comparing KFileItems by url

jtamate updated this revision to Diff 35188. jtamate marked 3 inline comments as done. jtamate edited the test plan for this revision. jtamate added a comment. A KFileItem without url will be the lowest, even lower than itself. Created a new test. The comparison with the QUrl is for this

D13211: Enable comparing KFileItems by url

jtamate updated this revision to Diff 35190. jtamate marked 4 inline comments as done. jtamate added a comment. Invalid items are not less than invalid items or invalid urls, they are not like -infinite. Added the tests comparing items with urls. Changed the descriptions. REPOSITORY R24

D13211: Enable comparing KFileItems by url

jtamate updated this revision to Diff 35192. jtamate added a comment. Taken into account invalid Items created from invalid QUrls. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13211?vs=35190&id=35192 REVISION DETAIL https://phabricator.kde.org/D13211 AFFE

D13189: [kcoredirlister] Remove as many url.toString() as possible

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ae08cc2c983c: [kcoredirlister] Remove as many url.toString() as possible (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13189?vs=35114&id=35201

D13211: Enable comparing KFileItems by url

jtamate updated this revision to Diff 35303. jtamate added a comment. Now passes the tests and its performance for non invalid items is not degraded too much (same +3ms inserting). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13211?vs=35192&id=35303 REVISIO

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

jtamate updated this revision to Diff 35305. jtamate marked 4 inline comments as done. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. The change in kdirmodel is not needed anymore. The methods that were const are const aga

D12945: kcoredirlister lstItems benchmark

jtamate updated this revision to Diff 35585. jtamate edited the summary of this revision. jtamate added a comment. Changed the structure QListBinaryHash to QMap Changed from KFileItems pointers to Values (it caused memory problems). Imported the parts that handle the filters to do the be

D12696: Use the new uds implementation

jtamate added a comment. In D12696#275105 , @martinkostolny wrote: > Hi! Probably after this commit sftp slave crashes when showing a directory with links. Please see my code comment. Can you also reproduce or is it on my side only? I'm

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

jtamate added a comment. In D12897#276182 , @dhaumann wrote: > @mwolff To me this looks ok - do you see an issue with this? E.g. that KTextEditor will require much more memory for almost no gain? If there is a more constrained limit, this

D12696: Use the new uds implementation

jtamate added a comment. I'm sorry, I was missing a -dev package and therefore I was not compiling kio sftp. A fix for this problem is in D13475 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #framewo

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

jtamate abandoned this revision. jtamate added a comment. More numbers: The patch reserves 67 buckets in the QHash table vs. 37 by default. In my test, pasing the content of https://www.boe.es/legislacion/documentos/ConstitucionCASTELLANO.pdf from Okular, the number of items in the cach

D13211: Enable comparing KFileItems by url

jtamate updated this revision to Diff 36037. jtamate marked an inline comment as done. jtamate edited the summary of this revision. jtamate added a comment. Change @since to 5.48 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13211?vs=35303&id=36037 REVISION D

D13211: Enable comparing KFileItems by url

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fb3c94ed96c3: Enable comparing KFileItems by url (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13211?vs=36037&id=36112 REVISION DETAIL https:

D13590: Use QUrl < instead of QString.compare

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Use the available Qurl < operator (since Qt

D13590: Use QUrl < instead of QString.compare

jtamate updated this revision to Diff 36283. jtamate edited the summary of this revision. jtamate added a comment. You're right :-) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13590?vs=36279&id=36283 REVISION DETAIL https://phabricator.kde.org/D13590 AFF

D13590: Use QUrl < instead of QString.compare

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bba871deced2: Use QUrl < instead of QString.compare (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13590?vs=36283&id=36343 REVISION DETAIL htt

D13674: Make it possible to go up to root again

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY If u == "file:///", then u.setPath(u.path()

D13674: Make it possible to go up to root again

jtamate updated this revision to Diff 36504. jtamate marked an inline comment as done. jtamate edited the summary of this revision. jtamate added a comment. Your suggested code works. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13674?vs=36499&id=36504 REVIS

D13676: Make it possible to change directory up even with trailing slashes in the url

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Leave only the last / in the url before goi

D13676: Make it possible to change directory up even with trailing slashes in the url

jtamate updated this revision to Diff 36513. jtamate added a comment. Using NormalizePathSegments. There is something else going on with the trailing slashes in the file dialog. If I'm in my home directory and I append slashes, they are removed, also in /, but in /home/ and other direct

D13674: Make it possible to go up to root again

jtamate updated this revision to Diff 36533. jtamate marked an inline comment as done. jtamate added a comment. Removed comment and added autotest. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13674?vs=36504&id=36533 REVISION DETAIL https://phabricator.kde

D13674: Make it possible to go up to root again

jtamate updated this revision to Diff 36534. jtamate added a comment. Moved the comment. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13674?vs=36533&id=36534 REVISION DETAIL https://phabricator.kde.org/D13674 AFFECTED FILES autotests/kfilewidgettest.cpp

D13674: Make it possible to go up to root again

This revision was automatically updated to reflect the committed changes. Closed by commit R241:1cea9463f471: Make it possible to go up to root again (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13674?vs=36534&id=36611 REVISION DETAIL h

D13813: make this test work again with new uds implementation

jtamate created this revision. jtamate added reviewers: Dolphin, Frameworks. Restricted Application added a project: Dolphin. Restricted Application added a subscriber: kfm-devel. jtamate requested review of this revision. REVISION SUMMARY With the new uds implementation, when some data is meant

D13814: Speedup sort

jtamate created this revision. jtamate added reviewers: Dolphin, Frameworks. Restricted Application added a project: Dolphin. Restricted Application added a subscriber: kfm-devel. jtamate requested review of this revision. REVISION SUMMARY Use a lambda function instead of a class. This way the

D13814: Speedup sort

jtamate added a dependency: D13813: make this test work again with new uds implementation. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13813: make this test work again with new uds implementation

jtamate added a dependent revision: D13814: Speedup sort. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13813 To: jtamate, #dolphin, #frameworks Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13813: make this test work again with new uds implementation

jtamate updated this revision to Diff 36975. jtamate added a comment. Updated the patch with context. It will not work with kio previous to 5.47, unless there is a way to check the kio version at compile time or runtime. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phab

D13813: make this test work again with new uds implementation

jtamate updated this revision to Diff 36976. jtamate edited the summary of this revision. jtamate added a comment. Use 3 entries instead of replace(). Now it will work with any kio version. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13813?vs=36975&id=

D13814: Speedup sort

jtamate added a comment. In D13814#285686 , @bruns wrote: > In D13814#285660 , @markg wrote: > > > > I don't know if that's still an issue or if your patch re-introduces whatever the problem was (rac

D13814: Speedup sort

jtamate updated this revision to Diff 37010. jtamate added a comment. Remove the _ prefix. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=36953&id=37010 REVISION DETAIL https://phabricator.kde.org/D13814 AFFECTED FILES src/kitemviews/kfileite

D13814: Speedup sort

jtamate added a comment. In D13814#285691 , @bruns wrote: > I assume you are sorting by name with "natural sorting". There may be another possibility for speedup here: > `QCollator::sortkey()`, http://doc.qt.io/qt-5/qcollator.html#sortKey >

D13814: Speedup sort

jtamate updated this revision to Diff 37019. jtamate added a comment. Can not use the name lessThan because of: error: use of ‘lessThan’ before deduction of ‘auto’ REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=37010&id=37019 REVISION DETAIL h

D13814: Speedup sort

jtamate updated this revision to Diff 37053. jtamate marked an inline comment as done. jtamate added a comment. > In other words, the fix for that can probably be removed now. I prefer not to do it (even I've tried without any crash), because QVariant is not even reentrant. Changed t

D13814: Speedup sort

jtamate updated this revision to Diff 37056. jtamate added a comment. Undo the right number of steps from a quick experiment. :-) REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=37053&id=37056 REVISION DETAIL https://phabricator.kde.org/D13814 A

D13813: make this test work again with new uds implementation

jtamate added a comment. In D13813#286313 , @aacid wrote: > Did we break how KIO works and we're now going after the users of KIO and fixing them or was this a "bad usage" from starters that worked by chance? We break how KIO works and we

D13813: Make this test work again with new uds implementation

jtamate updated this revision to Diff 37119. jtamate retitled this revision from "make this test work again with new uds implementation" to "Make this test work again with new uds implementation". jtamate edited the summary of this revision. jtamate added a comment. Call items.append inside th

D13813: Make this test work again with new uds implementation

jtamate added a comment. > But ForwardingSlaveBase::prepareUDSEntry in KIO itself, uses insert() to replace UDS_URL, and in fact all of ForwardingSlaveBase should use replace(), as well as users of ForwardingSlaveBase like kio_desktop. In ForwardingSlaveBase::prepareUDSEntry, it uses ins

D13892: Restore compatibility of UDS::insert

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks, aacid. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Restore KIO backwards compatibility

D13892: Restore compatibility of UDS::insert

jtamate updated this revision to Diff 37163. jtamate added a comment. Now better. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13892?vs=37161&id=37163 REVISION DETAIL https://phabricator.kde.org/D13892 AFFECTED FILES src/core/udsentry.cpp src/core/uds

D13892: Restore compatibility of UDS::insert

jtamate updated this revision to Diff 37170. jtamate marked 2 inline comments as done. jtamate added a comment. Added KIOCORE_DEPRECATED REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13892?vs=37163&id=37170 REVISION DETAIL https://phabricator.kde.org/D13892

D13897: Refactor udsentrytest

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Use c++ initialization lists instead of <<.

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Avoid the goto using local variables. Use

D13814: Speedup sort

jtamate updated this revision to Diff 37182. jtamate added a comment. Remove the friend non-exist class. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=37056&id=37182 REVISION DETAIL https://phabricator.kde.org/D13814 AFFECTED FILES src/kitem

D13897: Refactor udsentrytest

jtamate updated this revision to Diff 37183. jtamate added a comment. Commas at the end. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13897?vs=37172&id=37183 REVISION DETAIL https://phabricator.kde.org/D13897 AFFECTED FILES autotests/udsentrytest.cpp T

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate updated this revision to Diff 37184. jtamate edited the summary of this revision. jtamate added a comment. Renamed isSymLink to isBrokenSymLink. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13898?vs=37178&id=37184 REVISION DETAIL https://phabricato

D13892: Restore compatibility of UDS::insert

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8cd6be0b1c09: Restore compatibility of UDS::insert (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13892?vs=37170&id=37198 REVISION DETAIL http

D13897: Refactor udsentrytest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d24a61cae282: Refactor udsentrytest (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13897?vs=37183&id=37199 REVISION DETAIL https://phabricator.

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate updated this revision to Diff 37216. jtamate marked 3 inline comments as done. jtamate added a comment. Added a comment: // readlink doesn't append a null byte to linkTargetBuffer.data() Using target path to read ACL in a non broken symbolic link. Do not fill remaining data in case

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate added inline comments. INLINE COMMENTS > bruns wrote in file.cpp:864 > This is broken (although not new). > > `buff.st_size` is the size of the target name **without** null byte. > readlink(..., .., bufferSize) thus will typically read exactly bufferSize > bytes, thus n == bufferSize >

D13908: Use non deprecated fastInsert in ftp.cpp

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Use fastInsert instead of insert. All ent

D13909: Use non deprecated fastInsert in kfileitemtest

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Use fastInsert instead of insert. REPOSITO

D13910: Use non deprecated fastInsert in remoteimpl.cpp

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY All entries are cleared before fastInsert

D13912: Use non deprecated replace in ForwardingSlave

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY There is no contract that ensures entry doe

D13913: Use non deprecated fastInsert and replace in http.cpp

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY In davParsePropstats there are chances of r

D13915: Use non deprecated fastInsert in file_unix

jtamate created this revision. jtamate added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY The entry is local. REPOSITORY R241 KIO REVISION D

D13915: Use non deprecated fastInsert in file_unix

jtamate added a dependency: D13782: RFC: Ignore NTFS hidden flag for root volume. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13915 To: jtamate, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

jtamate added a dependent revision: D13915: Use non deprecated fastInsert in file_unix. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, ngraham, yurikoles, bruns Cc: wbauer, kde-frameworks-devel, michaelh, ngraham, bruns

D13916: Use non deprecated fastInsert in slaveBase

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Entry is local. REPOSITORY R241 KIO REV

D13917: Use non deprecated fastInsert in renameDialog

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY The entries are local variables. REPOSITOR

D13918: Use non deprecated fastInsert in kio_trash

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY This is the last one for kio The entry is

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate updated this revision to Diff 37240. jtamate marked 2 inline comments as done. jtamate added a comment. Incorporated Stephan code. Fill again the extra data like User/Group. I don't see any change and I don't want to break anything more. REPOSITORY R241 KIO CHANGES SINCE LAST U

D13908: Use non deprecated fastInsert in ftp.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f4b6e71c6839: Use non deprecated fastInsert in ftp.cpp (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13908?vs=37218&id=37259 REVISION DETAIL

D13909: Use non deprecated fastInsert in kfileitemtest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c2bd52926734: Use non deprecated fastInsert in kfileitemtest (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13909?vs=37219&id=37260 REVISION DET

D13910: Use non deprecated fastInsert in remoteimpl.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b4708f4ce2ec: Use non deprecated fastInsert in remoteimpl.cpp (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13910?vs=37221&id=37261 REVISION DE

D13912: Use non deprecated replace in ForwardingSlave

This revision was automatically updated to reflect the committed changes. Closed by commit R241:30a0b32d10e4: Use non deprecated replace in ForwardingSlave (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13912?vs=37224&id=37262 REVISION DETA

D13913: Use non deprecated fastInsert and replace in http.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit R241:de53875a6f52: Use non deprecated fastInsert and replace in http.cpp (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13913?vs=37225&id=37263 REVIS

D13915: Use non deprecated fastInsert in file_unix

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7048d259529f: Use non deprecated fastInsert in file_unix (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13915?vs=37227&id=37264 REVISION DETAIL

D13918: Use non deprecated fastInsert in kio_trash

jtamate edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13918 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13918: Use non deprecated fastInsert in kio_trash

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7b1210091c55: Use non deprecated fastInsert in kio_trash (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13918?vs=37232&id=37265 REVISION DETAIL

D13916: Use non deprecated fastInsert in slaveBase

This revision was automatically updated to reflect the committed changes. Closed by commit R241:be6075a2659f: Use non deprecated fastInsert in slaveBase (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13916?vs=37230&id=37270 REVISION DETAIL

D13917: Use non deprecated fastInsert in renameDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e7bd1c4b0abe: Use non deprecated fastInsert in renameDialog (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13917?vs=37231&id=37271 REVISION DETA

D13814: Speedup sort

This revision was automatically updated to reflect the committed changes. Closed by commit R318:63825de82f3a: Speedup sort (authored by jtamate). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=37182&id=37273 REVISION DETAIL https://phabricator.kde.o

D13814: Speedup sort

jtamate added a comment. I really, really hate these things. I've been testing this patch more than one month without any problem. And now, after pushing it, I got crashes everytime I start dolphin without parameters (user home). But not if I start it in / and keep changing directories,

D13814: Speedup sort

jtamate added a comment. > I just cloned dolphin with your changes. > It compiled just fine. > Starting it with and without arguments also worked just fine. > > Perhaps it's a local issue on your side? Have you tried cleaning your dolphin build (and perhaps KIO as well) and re

D13814: Speedup sort

jtamate added a comment. >> Perhaps it's a local issue on your side? Have you tried cleaning your dolphin build (and perhaps KIO as well) and re-run it to see if it still happens? > > I've done a kdesrc-build from empty sources directory and empty build directory, but not empty install

D13939: Don't ask for passwords in kfilewidgettest

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Changed the test to check if the root urls

D13674: Make it possible to go up to root again

jtamate added a comment. In D13674#288162 , @dfaure wrote: > somehow stub out any actual kioslave usage, and *just* test URLs. Please, check https://phabricator.kde.org/D13939 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.k

D13814: Speedup sort

jtamate updated this revision to Diff 37305. jtamate added a comment. My crashes are gone just doing a single comparison using the collator at the constructor. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=37273&id=37305 REVISION DETAIL https:

D13939: Don't ask for passwords in kfilewidgettest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:aca95c9df958: Don't ask for passwords in kfilewidgettest (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13939?vs=37302&id=37306 REVISION DETAIL

D13814: Speedup sort

jtamate added a comment. In D13814#288615 , @elvisangelaccio wrote: > @jtamate Can you show a complete gdb backtrace + valgrind log of this crash? Here you are F6051257: dolphin.crash.log REPOSITOR

D13814: Speedup sort

jtamate added a comment. Reading the source of QCollator*, I guess the hack works because I get a collator where d->dirty is true, and in compare there is this code if (d->dirty) d->init(); Once initialized, I don't see any other modification of QCollator members. Probabl

D13814: Speedup sort

jtamate updated this revision to Diff 37422. jtamate edited the summary of this revision. jtamate added a comment. Created the bug report referenced in the summary and code. Changed the strings to compare, they can be anything. > Perhaps there is a remote possibility of closing a view wh

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate updated this revision to Diff 37424. jtamate edited the summary of this revision. jtamate added a comment. Fixed targetPath of links. Question: If there any chance that st_birthtime and __st_birthtime are both present in the same OS? If affirmative, the entry of __st_birthtime so

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate updated this revision to Diff 37427. jtamate added a comment. Use st_birthtime or __st_birthtime but not both. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13898?vs=37424&id=37427 REVISION DETAIL https://phabricator.kde.org

D12865: transferjob new connect syntax

jtamate updated this revision to Diff 37448. jtamate added a comment. Sorry, I should have updated this revision earlier. There are two methods than can not be removed from the Q_PRIVATE_SLOT definitions, otherwise the invokeMethod will fail. if (m_closedBeforeStart) { QMetaOb

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6b452ae9892d: Use non deprecated fastInsert in file.cpp (first of many to come) (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13898?vs=37427&id=

D14022: Use non deprecated fastInsert in baloo

jtamate created this revision. jtamate added reviewers: Frameworks, Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY All the entries are local variables.

D13676: Make it possible to change directory up even with trailing slashes in the url

jtamate updated this revision to Diff 37500. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. The url in the lineedit is get from KUriFilterData, and it didn't normalize the paths, allowing trailing slashes. Include 4 new t

D14022: Use non deprecated fastInsert in baloo

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b806c88c6bcc: Use non deprecated fastInsert in baloo (authored by jtamate). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14022?vs=37493&id=37524 REVISION DETAIL

D13814: Speedup sort

jtamate updated this revision to Diff 37543. jtamate added a comment. I've applied some of @bruns suggestions. Just use QString(), less filesize and memory. Move the comparison after loadSortingSettings(); Change the comment from Force the cleanup of to Force the clean state of. @bruns

D13814: Speedup sort

jtamate updated this revision to Diff 37559. jtamate edited the summary of this revision. jtamate added a comment. Apply the workaround in loadSortingSettings. It is applied in the constructor and when the type of sorting is changed by the user. REPOSITORY R318 Dolphin CHANGES SINCE LAST

D13814: Speedup sort

jtamate edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuel

D13814: Speedup sort

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R318:765cc968c9df: Speedup sort (authored by jtamate). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13814?vs=37559

D13814: Speedup sort

jtamate added a comment. In D13814#291644 , @bruns wrote: > Any reason why you have pushed this with an obviously wrong commit message? Because I though the commit message was right. What should it be? REPOSITORY R318 Dolphin REVI

D13814: Speedup sort

jtamate edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuel

D13814: Speedup sort

jtamate added a comment. Also amended the commit message. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, firef, andr

D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache

jtamate created this revision. jtamate added a reviewer: Frameworks. jtamate requested review of this revision. REVISION SUMMARY When the device is blocked, for example by amarok mtp plugin, the result of LIBMTP_Open_Raw_Device_Uncached(rawDevice) is nullptr and LIBMTP_Get_Friendlyname(nullp

<    1   2   3   4   5   >