D28531: [KNotificationJobUiDelegate] Append "Failed" for error messages

broulik retitled this revision from "[KNotificationJobUiDelegate] Prepend "Failed" for error messages" to "[KNotificationJobUiDelegate] Append "Failed" for error messages". REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28531 To: broulik, #frameworks Cc:

D28499: [LauncherJobs] Emit description

broulik added a comment. Given we don't add elippsis after any other KIO Job (e.g. "Copying") probably shouldn't do it here either? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28499 To: broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28531: [KNotificationJobUiDelegate] Prepend "Failed" for error messages

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Makes the resulting error notification resemble one like a KJobTracker failure

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

broulik added a comment. Not sure how I would test running a command with a space in it.. putting a shell script in running it through QFINDTESTDATA? Not sure how to make that sort of stuff work on Windows REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28515 To:

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

broulik updated this revision to Diff 79189. broulik edited the test plan for this revision. broulik added a comment. - Quote executable in commandline - Add unittest REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28515?vs=79136=79189 REVISION DETAIL

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

broulik added a comment. Ok, makes sense. Just realized: do I need to `quoteArgs` the `executable`? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28515 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY More convenient than having to construct a proper escaped commandline.

D28488: [Fstab] Ensure uniqueness for all filesystem types

broulik added a comment. Wat. So maybe we need to add a hash of mount options to it? (Though I personally would call that pebkac) REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel,

D28499: [LauncherJobs] Emit description

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Provides for better error reporting. TEST PLAN Can't go in before tagging due

D28295: Introduce KNotificationJobUiDelegate

This revision was automatically updated to reflect the committed changes. Closed by commit R289:3dafde9c61b9: Introduce KNotificationJobUiDelegate (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28295?vs=78839=79104 REVISION

D28488: [Fstab] Ensure uniqueness for all filesystem types

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH fix_comment REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28295: Introduce KNotificationJobUiDelegate

broulik added a comment. Is this good now? But I think I'll wait until after tagging, it's not really urgent to get it in REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28295 To: broulik, #frameworks, nicolasfella, dfaure Cc: kossebau, kde-frameworks-devel,

D28220: Switch to using Kirigami's ShadowedRectangle

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH switch-to-kirigami-shadowedrectangle (branched from master) REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra,

D28488: [Fstab] Ensure uniqueness for all filesystem types

broulik added a comment. +1 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28463: do not install testengine

broulik added a comment. It's not used by any tests either REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28463 To: sitter, mart Cc: broulik, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28460: Add KCModuleStateProbe as base class for plugin

broulik added inline comments. INLINE COMMENTS > kcmodulestateprobe.h:21 > + > +#ifndef KCMODULEDEFAULT_H > +#define KCMODULEDEFAULT_H `KCMODULESTATEPROBE_H` > kcmodulestateprobe.h:25 > +#include > +#include > +#include Forward-declare > kcmodulestateprobe.h:39 > +virtual bool

D28460: Add KCModuleStateProbe as base class for plugin

broulik added inline comments. INLINE COMMENTS > kcmoduleloader.cpp:165 > + > +if (!mod.library().isEmpty()) { > +QString error; Use an early return here > kcmoduleloader.cpp:176 > +if (factory) { > +auto p = factory->create(nullptr, args2); > +if

D28440: Mark KIOFuse mounts as Probably slow

broulik accepted this revision. broulik added a comment. Makes sense since we generally don't want to access those directly anyway REPOSITORY R241 KIO BRANCH slowKIOFUse (branched from master) REVISION DETAIL https://phabricator.kde.org/D28440 To: feverfew, #frameworks, dfaure,

D28295: Introduce KNotificationJobUiDelegate

broulik updated this revision to Diff 78839. broulik added a comment. - Use `QScopedPointer` - No nested private class - Store `description` and use it as notification title REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28295?vs=78644=78839

D28295: Introduce KNotificationJobUiDelegate

broulik marked 5 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28295 To: broulik, #frameworks, nicolasfella, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28295: Introduce KNotificationJobUiDelegate

broulik added a comment. > To get the description, just connect to the description signal and store it, until the time you need to show the error? Should the jew app start jobs have one, maybe? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28295 To:

D28295: Introduce KNotificationJobUiDelegate

broulik planned changes to this revision. broulik added inline comments. INLINE COMMENTS > kossebau wrote in knotificationjobuidelegate.cpp:24 > Not using a nested class `Private` but a normal separate one like here to be > named `KNotificationJobUiDelegatePrivate` seems more simple, avoids the

D28268: KDesktopFileActions: port from KRun::run to KIO::ApplicationLauncherJob

broulik accepted this revision. broulik added a comment. Much nicer :) REPOSITORY R241 KIO BRANCH kdesktopfileactions REVISION DETAIL https://phabricator.kde.org/D28268 To: dfaure, davidedmundson, apol, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28266: KPropertiesDialog: port KRun::run to ApplicationLauncherJob

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Also +1 for porting to kservice rather than launching binary INLINE COMMENTS > applicationlauncherjob.h:50 > * > + * For error handling, either connect to the result() signal, or for a

D28367: KServiceAction: store parent service

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kserviceaction.cpp:50 > bool noDisplay) > : d(new KServiceActionPrivate(name, text, icon, exec, noDisplay)) > { You can just

D28390: KIO: remove waitForStarted() from the launcher jobs public API

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28390 To: dfaure, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28295: Introduce KNotificationJobUiDelegate

broulik added a dependent revision: D28347: Port services and shell runner away from KRun. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28295 To: broulik, #frameworks, nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28295: Introduce KNotificationJobUiDelegate

broulik updated this revision to Diff 78644. broulik added a comment. - Fix docs REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28295?vs=78520=78644 REVISION DETAIL https://phabricator.kde.org/D28295 AFFECTED FILES src/CMakeLists.txt

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

broulik added a comment. One thing I noticed, when I do `new CommandLaunchJob("somenonexistantbinary")` no error is raised and I just get console output `/bin/sh: 1: somenonexistantbinary: not found Though this was also the case of `runCommand`, so maybe not an issue. REPOSITORY

D27840: Introduce SettingState* elements to ease KCM writing

broulik added a comment. Cool INLINE COMMENTS > SettingStateBinding.qml:40 > + * target: Item > + * The graphical element which state we want to manage based on a setting > + */ *whose > SettingStateBinding.qml:58 > + * extraEnabledPredicate: bool > + * An extra

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

broulik added a comment. > KDesktopFileActions uses the name and icon from the action rather than the namd and icon from the service. Dunno if that's better though? I think we want to communicate to the user that "[Firefox icon] Firefox" is starting, not "[No icon] New incognito tab",

D28201: Add KIO::CommandLauncherJob to replace KRun::runCommand

broulik added a comment. Do we have a kf6 workboard entry for this effort? I think we should also have a replacement job for `new KRun(url)` and I'd love if we could split out the "default app for this mimetype" logic we (also?) have in `KFileItemActions` out into a dedicated public class.

D28298: Reduce superfluous changedEntriesChanged emissions

broulik added a comment. Hmm, when doing this, Qt suddenly refuses to pass the entries through to a `QQmlListReference` REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28298 To: broulik, #frameworks, leinir, ahiemstra Cc: kde-frameworks-devel, LeGast00n, cblack,

D28298: Reduce superfluous changedEntriesChanged emissions

broulik edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28298 To: broulik, #frameworks, leinir, ahiemstra Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28298: Reduce superfluous changedEntriesChanged emissions

broulik created this revision. broulik added reviewers: Frameworks, leinir, ahiemstra. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY For some reason I couldn't entirely get behind,

D28295: Introduce KNotificationJobUiDelegate

broulik created this revision. broulik added reviewers: Frameworks, nicolasfella, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This can be used for job error reporting using

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4f5503644aa6: [ApplicationLauncherJob] Add way to launch KServiceAction (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28285?vs=78470=78518

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28285 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28278: Move responsiblity for creating KService to CommandLauncherJob

broulik added a dependent revision: D28285: [ApplicationLauncherJob] Add way to launch KServiceAction. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28278 To: davidedmundson Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

broulik edited the test plan for this revision. broulik added a dependency: D28278: Move responsiblity for creating KService to CommandLauncherJob. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28285 To: broulik, #frameworks, dfaure, davidedmundson Cc:

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

broulik updated this revision to Diff 78470. broulik added a comment. - Assert REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28285?vs=78466=78470 REVISION DETAIL https://phabricator.kde.org/D28285 AFFECTED FILES src/gui/applicationlauncherjob.cpp

D28285: [ApplicationLauncherJob] Add way to launch KServiceAction

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This offers convenience API for launching a specific

D28278: Move responsiblity for creating KService to CommandLauncherJob

broulik added a comment. Lovely simplification INLINE COMMENTS > kprocessrunner.cpp:119 > { > -if (service && !service->entryPath().isEmpty() > +if (!service->entryPath().isEmpty() > && !KDesktopFile::isAuthorizedDesktopFile(service->entryPath())) > { I //think// we

D28220: Switch to using Kirigami's ShadowedRectangle

broulik added inline comments. INLINE COMMENTS > EntryScreenshots.qml:133 > anchors.fill: thumbnail > -verticalOffset: Kirigami.Units.largeSpacing > -horizontalOffset: 0 > -radius: 12.0 > -

D28223: Add "Stat" prefix to StatDetails Enum entries

broulik added inline comments. INLINE COMMENTS > global.h:322 > /// No field returned, useful to check if a file exists > -NoDetails = 0x0, > +StatNoDetails = 0x0, > /// Filename, access, type, size, linkdest Is this change source-compatible? REPOSITORY R241 KIO REVISION

D28197: [KSortFilterProxyModel QML] Make invalidateFilter public

This revision was automatically updated to reflect the committed changes. Closed by commit R275:37754045e2b8: [KSortFilterProxyModel QML] Make invalidateFilter public (authored by broulik). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE

D28197: [KSortFilterProxyModel QML] Make invalidateFilter public

broulik updated this revision to Diff 78227. broulik added a comment. - Add docs REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28197?vs=78206=78227 REVISION DETAIL https://phabricator.kde.org/D28197 AFFECTED FILES

D28197: [KSortFilterProxyModel QML] Make invalidateFilter public

broulik created this revision. broulik added reviewers: ahiemstra, davidedmundson, iasensio, kmaterka. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `invalidate` is, so I don't see why

D28131: listen to passiveNotificationRequested

broulik added a comment. Depends on kdeclarative, if that is rebuilt, a rebuild of kcmutil should fix that REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28131 To: mart, broulik Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28131: listen to passiveNotificationRequested

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH phab/passiveNotifications REVISION DETAIL https://phabricator.kde.org/D28131 To: mart, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28130: Introduce api for passive notifications

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH phab/passivenot REVISION DETAIL https://phabricator.kde.org/D28130 To: mart, broulik Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28130: Introduce api for passive notifications

broulik added inline comments. INLINE COMMENTS > configmodule.h:507 > + */ > +void showPassiveNotification(const QString , QVariant timeout = > QVariant(), const QString = QString(), const QJSValue = > QJSValue()); > Q_SIGNALS: `const QVariant &` REPOSITORY R296 KDeclarative

D28129: Read the new message string after rather than before

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. <3 REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D28129 To: apol, #frameworks, broulik, sitter Cc: plasma-devel, Orage, LeGast00n,

D28112: Expose application menu via KWindowInfo

broulik added inline comments. INLINE COMMENTS > kwindowinfo.h:579 > + * > + * Requires NET::WMPid passed as properties parameter to the constructor. > + * Copy paste error, requires `NET::WM2ApplicationMenuServiceName` > kwindowinfo.h:588 > + * > + * Requires NET::WMPid

D27985: Include s_kcrashErrorMessage in our traces

broulik added a comment. When this symbol isn't present, gdb just aborts and you don't get any back trace anymore: Error in sourced command file: No symbol "s_kcrashErrorMessage" in current context. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D27985

D28121: Use libcanberra as primary means of previewing the sound

broulik closed this revision. broulik added a comment. https://phabricator.kde.org/R305:4caaf107f1d4f45ff28d0de1b7e7e541e5827e3a REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D28121 To: broulik, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, cblack,

D28121: Use libcanberra as primary means of previewing the sound

broulik created this revision. broulik added reviewers: Frameworks, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY So it matches what `KNotification` is doing, especially since Phonon

D28114: Add call-incoming/missed/outgoing

broulik added a comment. Leave the phone in, please. I'm having a hard time grasping the pure arrow icons Android uses in the dialer. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28114 To: ndavis, #vdg, cblack Cc: broulik, cblack, jbbgameich, bshah,

D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

This revision was automatically updated to reflect the committed changes. Closed by commit R296:517bcca389d9: [KCM Controls GridDelegate] Use `ShadowedRectangle` (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28028?vs=77567=77571

D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

broulik edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28028 To: broulik, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Instead of expensive `DropShadow` layer. TEST PLAN Left is before, right is after

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

broulik added a comment. Anything WId also probably won't work on Wayland, so +1 REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28016 To: dfaure, zzag, broulik, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27953: Properly read string lists from desktop files when parsing the files

broulik added a comment. Do we have a task to clean that mix up for kf6 on the work board? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D27953 To: apol, dfaure Cc: broulik, dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

broulik added a comment. In D27464#625405 , @zzag wrote: > Could you please clarify what you mean by "plasma surface interface"? The thing we use in plasmashell to position panels and everything absolutely REPOSITORY R127 KWayland

D27464: Add application menu dbus paths to org_kde_plasma_window interface

broulik added a comment. Didn't we have a dedicated protocol for window menu in plasma-integration? Or is this just for reading? We surely don't want all apps to use plasma surface interface for announcing the global menu?

D27923: [FileIndexScheduler] Cleanup firstRun handling

broulik added inline comments. INLINE COMMENTS > indexerstate.h:41 > Unavailable, > + Startup, > }; Indentation > indexerconfig.cpp:112 > > +// KF6 TODO: remove > bool IndexerConfig::firstRun() const Please mark them as deprecated in the header file REPOSITORY R293 Baloo

D27279: Port away from QWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R274:5b6d26cd758c: Port away from QWidget (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27279?vs=75345=77252#toc REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE

D27357: Fix infinite recursion in xscreensaver plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R274:3dae871e6b89: Fix infinite recursion in xscreensaver plugin (authored by alnikiforov, committed by broulik). REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE

D27357: Fix infinite recursion in xscreensaver plugin

broulik added a comment. Sorry, I just returned from vacation. I'll merge this on Monday (since Frameworks tagging is tomorrow) so we'll get another month worth of testing. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson,

D27887: Fix config include

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27887 To: vonreth, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, cblack,

D27628: Buttons: allow to scale up icons

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Lovely. - Media controller is fine now - Pin on systray popup is fine - buttons in NM applet are fine REPOSITORY R242 Plasma Framework (Library) BRANCH phab/anothersizehint

D27622: only find bash once

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:79 > +find_program(BASH_EXE bash) > +add_feature_info("24x24 generation" BASH_EXE "'bash' is require to > generate 24x24 variants") > + *required REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL

D27357: Fix infinite recursion in xscreensaver plugin

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson, broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26918: Improve KNotification API docs

broulik added inline comments. INLINE COMMENTS > apol wrote in knotification.h:96 > Since Qt5 KIconLoader is an implementation detail. Even our apps and > frameworks use QIcon::fromTheme, I haven't looked at what KNotifications does > but pretty sure it's using QIcon. It actually sends out

Taking over KNotifications maintainership

Hi all, I propose to make me the official maintainer of KNotifications given that's pretty much what I've been doing for quite some time already anyway. It still lists Martin Klapetek as maintainer who unfortunately isn't very active anymore. Cheers Kai Uwe

D26769: Always strip html if server does not support it

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Also, title must never be HTML, there's a reason the capability is called //body//-markup :) REPOSITORY R289 KNotifications BRANCH stripcorrently REVISION DETAIL

D27399: make sure the size hints are integer and even

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/sizefixes REVISION DETAIL https://phabricator.kde.org/D27399 To: mart, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27396: support icon.width/height

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/iconSize REVISION DETAIL https://phabricator.kde.org/D27396 To: mart, #plasma, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27396: support icon.width/height

broulik added a comment. Don't we want to set a default? I keep seeing people hardcoding `icon.width` all over the place when they used PC3 and I want that to stop REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27396 To: mart, #plasma Cc:

D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

broulik added inline comments. INLINE COMMENTS > slavebase.cpp:1100 > } else { > -qFatal("Fatal Error: Got cmd %d, while waiting for an answer!", > cmd); > +qDebug("Error: Got cmd %d, while waiting for an answer!", cmd); > +return -1; Should at

D27376: Sync IndexerConfig on exit

broulik added a comment. +1 worksforme REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27376 To: davidedmundson Cc: broulik, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D27357: Fix infinite recursion in xscreensaver plugin

broulik added a reviewer: Frameworks. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson, broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27366: Construct NullEngine with KPluginMetaData()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1dc36bc2cee4: Construct NullEngine with KPluginMetaData() (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27366: Construct NullEngine with KPluginMetaData()

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The deprecated constructor taking a `KPluginInfo` unconditionally calls

D27357: Fix infinite recursion in xscreensaver plugin

broulik added a comment. Neither the XSync nor the windows backend explicitly call `resumingFromIdle` in `simulateUserActivity`, so I think this should be fine. However, I don't know if that won't indirectly trigger it if the session was idle? Maybe we need to check if the session was idle

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

broulik added a comment. Nice find! It appears the `DropdownMenu`, `PopupMenu`, and `Notification` type also incorrectly use a `len = 1`? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D27356 To: catherinez, #kwin Cc: broulik, kde-frameworks-devel,

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

broulik added a reviewer: KWin. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D27356 To: catherinez, #kwin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: 2 kirigami fixes for a point release

Hi, > We have to ask: what causes buggy releases? People rushing things in at the last minute, even better if unreviewed. Plasma 5.18 was a prime example of this. Every single time there's drama on Beta tagging day for some last minute change that should go in. To remedy this I wanted Beta

D27279: Port away from QWidget

broulik added a comment. > How can I reproduce crash in resume on idle? For me I set screen turn off to 1 minute, waited for the screen to fade to black, waited a bit more, got curious why it didn't actually turn it off, wiggled the mouse, and then found it crashed. You might need to

D27292: set the share comment as UDS_COMMENT for the UI to display

broulik added a comment. The comment will be shown in the status bar when hovering a file. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27292 To: sitter, ngraham Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack,

D26118: Port QRegExp to QRegularExpression

broulik added a comment. This appears to have broken policy file generation. The polkit files I now get have Neues Plymouth-Design installieren Note the "Name" in the `xml:lang` REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir,

D27284: [polkit-1] Simplify Polkit1Backend action exists lookup

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH kauth_fixup REVISION DETAIL https://phabricator.kde.org/D27284 To: davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27279: Port away from QWidget

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in widgetbasedpoller.h:18 > it's not an installed header, no need to wait Ok, I'll remove this comment. Let's do the rename in a separate patch when this goes in. REPOSITORY R274 KIdleTime REVISION DETAIL

D27279: Port away from QWidget

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY We can do everything we need with `QWindow` TEST PLAN Alternative to D27276

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH arcpatch-D25326 REVISION DETAIL https://phabricator.kde.org/D25326 To: davidedmundson, broulik Cc: kmaterka, iasensio, ahmadsamir, broulik, ahiemstra, mart,

D27140: Calculate KAuthAction::isValid on demand

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH delayed_isValid REVISION DETAIL https://phabricator.kde.org/D27140 To: davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27087: Add HEIF thumbnailer

broulik added a comment. https://codereview.qt-project.org/c/qt/qtimageformats/+/236077 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27087 To: zzag, #plasma Cc: cfeck, broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D27087: Add HEIF thumbnailer

broulik added a comment. -1 for making a dedicated thumbnailer. There's a Qt heif image plug in in the works in Qt. If any, we should help there or at least get our own into kimageformats, so Gwenview and others can open such files properly. REPOSITORY R320 KIO Extras REVISION DETAIL

D27067: Change "AutoSkip" to "Skip All"

broulik added a comment. +1 (also for considering the string freeze :) I think we should add some mnemonics, i.e. "" and "Skip " REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27067 To: ngraham, #frameworks, #vdg, dfaure Cc: broulik, kde-frameworks-devel,

D26841: hardware tool: define syntax via syntax arg

broulik added a comment. Oh god yes. Since it's only for compat and superfluous, how about setting `HiddenFromHelp` on the `QCommandLineOption` then? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26841 To: sitter Cc: broulik, bruns, kde-frameworks-devel,

<    1   2   3   4   5   6   7   8   9   10   >