D21099: Use locale currency for donate icon

broulik created this revision. broulik added reviewers: Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This allows the icon theme to provide a donate icon using the currency symbol

D21079: make sure to also assert ScaledDirectories

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21079 To: sitter, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

broulik added a comment. Looks like we need a symbolic icon for that in breeze REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21041 To: bruns, #frameworks, ngraham, hallas Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20986: Don't call click on the delegate, when we just want it to become current item

broulik added a comment. oh, crap, right, I thought that was the delegate code, not the buttons. I think it just shouldn't do anything then since when changing the `currentIndex` if the KCM isn't prepared for that might cause the visual index and actual selected setting to become out of

D20986: Don't call click on the delegate, when we just want it to become current item

broulik added a comment. -1 Most KCMs actually use `onClicked` to update the selected plugin and other bits. They don't actually set `currentIndex` on the `ListView` directly but have it updated based on whatever current scheme or theme etc is selected. REPOSITORY R296 KDeclarative R

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

broulik accepted this revision. broulik added a comment. Even more noticeable when using high dpi (Plasmashell doesn't use scaling on X): Before F6805353: Screenshot_20190503_105021.png After F6805355: Screenshot_20190503_105047.png

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

broulik closed this revision. broulik added a comment. https://cgit.kde.org/kwayland.git/commit/?id=3ef09f3e0c4d20cd9da482107bb3402c40e47c6a REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20628 To: broulik, #kwin, zzag Cc: zzag, davidedmundson, kde-frameworks-deve

D20630: [Dialog] Add CriticalNotification type

This revision was automatically updated to reflect the committed changes. Closed by commit R242:91024027b09b: [Dialog] Add CriticalNotification type (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20630?vs=56425&id=5736

D20627: Introduce CriticalNotificationType

This revision was automatically updated to reflect the committed changes. Closed by commit R278:dff8842bfaac: Introduce CriticalNotificationType (authored by broulik). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20627?vs=56418&id=57359 REVISION DETAI

D19617: Support NET_WM_STATE_FOCUSED

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. I think regardless of whether we end up using this in KWin or not, we should have the API for it in `KWindowSystem` REPOSITORY R278 KWindowSystem BRANCH state_focussed REVISION DETA

D20833: Simpler check for flatpak

broulik added inline comments. INLINE COMMENTS > knotificationmanager.cpp:94 > > if (!qEnvironmentVariableIsEmpty("XDG_RUNTIME_DIR")) { > +d->inSandbox = QFileInfo::exists(QLatin1String("/.flatpak-info")); Do you need this check now, even, since you're not using it anymore? REPOS

D20805: [Window Thumbnail] Also monitor scene visibility and clean up

broulik added inline comments. INLINE COMMENTS > zzag wrote in windowthumbnail.cpp:213 > Do you actually need Q_FALLTHROUGH() here? I fall through so I wanted to make it explicit. I would have put a `// fallthrough` comment otherwise REPOSITORY R242 Plasma Framework (Library) REVISION DETAI

D20805: [Window Thumbnail] Also monitor scene visibility and clean up

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1b2424879a19: [Window Thumbnail] Also monitor scene visibility and clean up (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20805?vs=56951&id=56956#toc REPOSITORY R242

D20805: [Window Thumbnail] Also monitor scene visibility and clean up

broulik added a comment. I recall there was also a bug about "games becoming slow when hovering them in task bar" which might be the same bug: us not unredirecting it again REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20805 To: broulik, #plasma

D20805: [Window Thumbnail] Also monitor scene visibility and clean up

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Just because the item is `visible` doesn't mean the window itself is. Keep track of t

D20196: Add Notify capability to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R237:5d2ed13479a4: Add Notify capability to KConfigXT (authored by broulik). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20196?vs=55730&id=56898 REVISION DETAIL ht

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

broulik updated this revision to Diff 56884. broulik edited the test plan for this revision. broulik added a comment. - do proper versioning REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20628?vs=56422&id=56884 REVISION DETAIL https://phabricator.kde.o

D20196: Add Notify capability to KConfigXT

broulik added a comment. Ping REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D20196 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20765: Add input methods to input method status bar button

This revision was automatically updated to reflect the committed changes. Closed by commit R39:14ff5dd8674f: Add input methods to input method status bar button (authored by broulik). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20765?vs=56804&id=56809 R

D20766: Use appropriate background color for text previews

broulik added a reviewer: kossebau. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau Cc: broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp,

D20766: Use appropriate background color for text previews

broulik added inline comments. INLINE COMMENTS > textcreator.cpp:140 > > -QColor bgColor = QColor ( 245, 245, 245 ); // light-grey > background > -m_pixmap.fill( bgColor ); > +m_pixmap.fill( > KColorScheme(QPalette::Active).background().color() ); > Can'

D20765: Add input methods to input method status bar button

broulik created this revision. broulik added reviewers: Kate, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. broulik requested review of this revision. REVISION SUMMARY Even though it indicates VI mode vs Normal mode clicking it o

D20656: Plotter: Scope GL Program to lifespan of scenegraph node

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > plotter.cpp:267 > +PlotSGNode(); > +void bind(){ > +m_program->bind(); Coding style REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL

D20579: [FrameSvgItem] Update filtering on smooth changes

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH updateframesvgitemsonsmoothchange REVISION DETAIL https://phabricator.kde.org/D20579 To: kossebau, #plasma, broulik, mart Cc: kde-frameworks-devel, michaelh,

D20649: [Notify by Portal] Support default action and priority hints

This revision was automatically updated to reflect the committed changes. Closed by commit R289:85bdacf738eb: [Notify by Portal] Support default action and priority hints (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20649?vs=565

D20649: [Notify by Portal] Support default action and priority hints

broulik updated this revision to Diff 56504. broulik added a comment. - Support `high` - Handle all switch cases REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20649?vs=56494&id=56504 REVISION DETAIL https://phabricator.kde.org/D20649 AFFECTED

D20648: [KNotification] Add HighUrgency

This revision was automatically updated to reflect the committed changes. Closed by commit R289:134e131762e9: [KNotification] Add HighUrgency (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20648?vs=56493&id=56503 REVISION DETAIL

D20655: Use generated DBus interface

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids introspection calls when creating the manager or devi

D20648: [KNotification] Add HighUrgency

broulik added inline comments. INLINE COMMENTS > dfaure wrote in knotification.h:283 > Isn't the change of value BIC? Even if it was, this stuff isn't released yet REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20648 To: broulik, #frameworks, dfaure, vkrause,

D20648: [KNotification] Add HighUrgency

broulik added a dependent revision: D20651: Support default action, priority hints, set desktop-entry. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20648 To: broulik, #frameworks, dfaure, vkrause, ogoffart, nicolasfella Cc: kde-frameworks-devel, michaelh, ngra

D20158: Allow to set urgency for notifications

broulik added a dependent revision: D20651: Support default action, priority hints, set desktop-entry. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh,

D20649: [Notify by Portal] Support default action and priority hints

broulik created this revision. broulik added reviewers: Frameworks, jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Compiles, untested as I couldn't figure out the flatpak build system stuff REPO

D20648: [KNotification] Add HighUrgency

broulik created this revision. broulik added reviewers: Frameworks, dfaure, vkrause, ogoffart, nicolasfella. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Freedesktop notifications only know low, n

D20158: Allow to set urgency for notifications

broulik added a comment. Good point, I shall space them apart a bit. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

broulik added a comment. @vkrause I just noticed xdg portal notification spec (the ones used for sandboxed flatpak apps) has four urgency levels: low, normal, *high*, critical. Do you think it would be useful to add `HighUrgency`, too? For Android, maybe? For freedesktop Notifications we co

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Volume icon are consistent now, Vault icon in tray is prettier (imho), media controls look unchanged/fine, folder view nav buttons look fine/better, lgtm REPOSITORY R242 Plasma Framewor

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

broulik added a dependent revision: D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20628 To: broulik, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20630: [Dialog] Add CriticalNotification type

broulik created this revision. broulik added reviewers: Plasma, KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Allows to flag a dialog window as critical notification that should be shown eve

D20627: Introduce CriticalNotificationType

broulik added a dependent revision: D20630: [Dialog] Add CriticalNotification type. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D20627 To: broulik, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20627: Introduce CriticalNotificationType

broulik added a dependent revision: D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D20627 To: broulik, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

broulik created this revision. broulik added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Compiles, tests adjusted and pass. I need some help with the versioning stuff please REPOSIT

D20627: Introduce CriticalNotificationType

broulik created this revision. broulik added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is a dedicated window type indicating a critical notification that is more urgent

D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

broulik added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20602 To: kossebau, #plasma, #vdg Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Instead of swapping out one random number for another, please correctly calculate the implicit size of the page, like `GridViewKCM` does: Something like implicitHeight:

D20594: Fix MobileTextSelection namespacing

broulik closed this revision. broulik added a comment. https://cgit.kde.org/plasma-framework.git/commit/?id=8431223542110fd112cda5a4b352ab4a8a21bb51 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20594 To: broulik, #plasma, mart, hein, lbeltrame

D20594: Fix MobileTextSelection namespacing

broulik edited the summary of this revision. broulik added a reviewer: lbeltrame. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20594 To: broulik, #plasma, mart, hein, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20594: Fix MobileTextSelection namespacing

broulik created this revision. broulik added reviewers: Plasma, mart, hein. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It is all in `MobileTextSelection` instead of `Private` now. TEST PLAN I

D20592: Set correct kwalletd_bin_path

This revision was automatically updated to reflect the committed changes. Closed by commit R311:25f9723e87ce: Set correct kwalletd_bin_path (authored by broulik). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20592?vs=56347&id=56349 REVISION DETAIL https:/

D20592: Set correct kwalletd_bin_path

broulik created this revision. broulik added reviewers: davidedmundson, jriddell. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It is installed as `kwalletd5` TEST PLAN Compiled this and kwallet

D20428: separe mobile text selection to avoid recursive imports

broulik added inline comments. INLINE COMMENTS > ComboBox.qml:174 > id: mobileCursor > Private.MobileCursor { > target: textField Does this not need to be adjusted? `ComboBox` is broken here. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://

D20570: [FrameSvgItem] Respect smooth property

This revision was automatically updated to reflect the committed changes. Closed by commit R242:2a636d66712f: [FrameSvgItem] Respect smooth property (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20570?vs=56289&id=5629

D20570: [FrameSvgItem] Respect smooth property

broulik updated this revision to Diff 56289. broulik added a comment. - Also update corner nodes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20570?vs=56288&id=56289 REVISION DETAIL https://phabricator.kde.org/D20570 AFFECTED FILES

D20570: [FrameSvgItem] Respect smooth property

broulik planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20570 To: broulik, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20570: [FrameSvgItem] Respect smooth property

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Set `smooth: true`, rotated it, didn't look jagged anymore REPOSITORY R242 Plasma Framewor

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:580fec7c0b20: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget… (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20465

D20462: [KUiServerJobTracker] Track kuiserver service life time and re-register jobs if needed

This revision was automatically updated to reflect the committed changes. Closed by commit R288:130809f97e6f: [KUiServerJobTracker] Track kuiserver service life time and re-register jobs if… (authored by broulik). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

broulik added a comment. I think so, it's the very same patch in that bugreport :) So, this patch makes even more sense, I only considered the Plasma case REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20465 To: broulik, #frameworks, dfaure, lbeltrame Cc: ngraham, kde-

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

broulik created this revision. broulik added reviewers: Frameworks, dfaure, lbeltrame. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It asks kuiserver whether we need to display a widget job tracke

D20462: [KUiServerJobTracker] Track kuiserver service life time and re-register jobs if needed

broulik created this revision. broulik added reviewers: Frameworks, dfaure, lbeltrame, kossebau, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When the process providing the kuiser

D19908: [ConfigModule] Pass initial properties

This revision was automatically updated to reflect the committed changes. Closed by commit R296:238a49139fd6: [ConfigModule] Pass initial properties in push() (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19908?vs=54398&id=55969 R

D20417: Add invokable public API for emitting contextualActionsAboutToShow

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks for taking care of this REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20417 To: davidedmundson, #plasma, broulik Cc:

D20433: Use mount point returned from DBus instead of using property value

broulik added inline comments. INLINE COMMENTS > udisksstorageaccess.cpp:35 > StorageAccess::StorageAccess(Device *device) > -: DeviceInterface(device), m_setupInProgress(false), > m_teardownInProgress(false), m_passphraseRequested(false) > +: DeviceInterface(device), m_setupInProgress(

D20433: Use mount point returned from DBus instead of using property value

broulik added a reviewer: bruns. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20433 To: nicolasfella, broulik, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

broulik abandoned this revision. broulik added a comment. Herald added a subscriber: kde-frameworks-devel. Superseded by D10657 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10657 To: broulik, #frameworks, davidedmundson, apol Cc:

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

broulik abandoned this revision. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D14290 To: broulik, dfaure Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D19908: [ConfigModule] Pass initial properties

broulik added a comment. Pingeliping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19908 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19913: [plasma-desktop] make it compiles without foreach

broulik added inline comments. INLINE COMMENTS > coronatest.cpp:150 > +const auto containments = m_corona->containments(); > +for (auto cont : containments) { > switch (cont->id()) { Please always annotate `auto` with e.g. asterisk or ampersand depending on type > coronatest.cp

D20196: Add Notify capability to KConfigXT

broulik updated this revision to Diff 55730. broulik retitled this revision from "RFC: Add Notify capability to KConfigXT" to "Add Notify capability to KConfigXT". broulik edited the test plan for this revision. broulik added a comment. - Move stuff into `KConfigSkeletonItem` REPOSITORY R23

D20374: [KNotifications] Update when flags, urls, or urgency change

This revision was automatically updated to reflect the committed changes. Closed by commit R289:c0b14c032746: [KNotifications] Update when flags, urls, or urgency change (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20374?vs=5572

D20374: [KNotifications] Update when flags, urls, or urgency change

broulik created this revision. broulik added reviewers: Plasma, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It was forgotten to schedule an update when they changed. TEST PLAN Updatin

D20158: Allow to set urgency for notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R289:39c6e0ea805c: Allow to set urgency for notifications (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20158?vs=55173&id=55726#toc REPOSITORY R289 KNotifications CHANGES

D20158: Allow to set urgency for notifications

broulik added a comment. Ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20196: RFC: Add Notify capability to KConfigXT

broulik planned changes to this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D20196 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

broulik added a comment. I don't see how this could work. IconItem uses the first section as filename, for `active-quassel-tray` the word `active` and looks for an active.svgz which there isn't. This is a bug in Quassel, a violation of the FDO spec, it should have ebeen `quassel-tray-inactiv

D20196: RFC: Add Notify capability to KConfigXT

broulik added a dependent revision: D20265: Introduce libnotificationmanager. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D20196 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20244: [AppletInterface] Check for corona before accessing it

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c65145bd3463: [AppletInterface] Check for corona before accessing it (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20244?

D20244: [AppletInterface] Check for corona before accessing it

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY On plasmashell shutdown when the panels are destroyed, the available screen geometry

D18365: Add a flag to keep a window on top

broulik added a comment. +1 also needed for critical notifications, cf D20154 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18365 To: davidedmundson, #kwin Cc: broulik, apol, zzag, kde-frameworks-devel, michaelh, ngraham, brun

D20210: [Label] Bump import version so padding properties are available

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN The following works now PlasmaComponents.Label { leftPadding: ... } REPOS

D20200: [Dialog] Don't forward hover event when there is nowhere to forward it to

This revision was automatically updated to reflect the committed changes. Closed by commit R242:9de0def99f96: [Dialog] Don't forward hover event when there is nowhere to forward it to (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabrica

D20199: [Menu] Fix triggered sign

This revision was automatically updated to reflect the committed changes. Closed by commit R242:9aa249e86a34: [Menu] Fix triggered signal (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20199?vs=55263&id=55267 REVISION

D20200: [Dialog] Don't forward hover event when there is nowhere to forward it to

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Dialog has this clever way of re-sending a mouse event inside the bounardies of the d

D20199: [Menu] Fix triggered sign

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It casted the `QAction` to a `MenuItem` which fails because it isn't such. Instead,

D20196: RFC: Add Notify capability to KConfigXT

broulik edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D20196 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20196: RFC: Add Notify capability to KConfigXT

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Lets you specify `Notifiers=` in `.kcfg` for config entries

D20176: make start-here-kde also available start-here-kde-plasma

broulik added a comment. Imho when we did the rebranding we should have added a `start-here-plasma` icon and switch to that everywhere rather than blatantly changing the `start-here-kde` icon +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20176 To: sitter

D20158: Allow to set urgency for notifications

broulik added a comment. So, in essence you're fine with adding the enum as it is, and then have some mapping in the Android code? :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaure

D20158: Allow to set urgency for notifications

broulik added a comment. In D20158#441322 , @vkrause wrote: > Nicely fits with the Android backend too, although that has one extra level (low, medium, high, urgent). I found the following enums in `NotificationManager`: - `IMPORTANC

D20047: Add X-GNOME-UsesNotifications as recognized key

This revision was automatically updated to reflect the committed changes. Closed by commit R309:1c783fd26c91: Add X-GNOME-UsesNotifications as recognized key (authored by broulik). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20047?vs=54789&id=55180 REVISI

D20065: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R295:dc3dd35d36c4: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule (authored by broulik). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20065?vs=54870

D20158: Allow to set urgency for notifications

broulik created this revision. broulik added reviewers: Plasma, Frameworks, vkrause, ogoffart, mck182. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This lets the application set an urgency hint on

D20039: [KConfig] Add Notify capability for revertToDefault

This revision was automatically updated to reflect the committed changes. Closed by commit R237:cad4889e490f: Add Notify capability to revertToDefault (authored by broulik). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20039?vs=54765&id=55167 REVISION DETAI

D20070: [PlasmaComponents3 ComboBox] Fix textColor

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d868804a7fe4: [PlasmaComponents3 ComboBox] Fix textColor (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20070?vs=54892&id=

D20070: [PlasmaComponents3 ComboBox] Fix textColor

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Uses the one from `ColorScope` rather than `Kirigami`. `Kirigami.Theme` isn't u

D20060: [KDynamicJobTracker] Use generated DBus interface

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ed158497a322: [KDynamicJobTracker] Use generated DBus interface (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20060?vs=54848&id=54873 REVISION

D20065: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule

broulik created this revision. broulik added reviewers: Frameworks, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Ensures `args` are passed into the `KQuickAddons::ConfigModule` TEST PLAN

D19875: [Kactivities-stats] compile without foreach

broulik added a reviewer: ivan. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19875 To: mlaurent, dfaure, ivan Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20060: [KDynamicJobTracker] Use generated DBus interface

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids doing a blocking introspection call. TEST PLAN Started a

D19985: [KStatusNotifierItem] Send desktop-entry hint

This revision was automatically updated to reflect the committed changes. Closed by commit R289:90050b02d725: [KStatusNotifierItem] Send desktop-entry hint (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19985?vs=54585&id=54813 RE

D20047: Add X-GNOME-UsesNotifications as recognized key

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is set by Gnome applications that will spawn notifications for identifying t

<    2   3   4   5   6   7   8   9   10   11   >