D19699: [DataModel] Add nullptr check

broulik abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19699 To: broulik, #plasma, mlaurent, arojas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19696: Add blender thumbnailer

broulik added a comment. Since this one is a bit more specific, perhaps it should indeed go into kdegraphics-thumbnailers, don't really mind. I think I have asked this often before but is kdegraphics-thumbnailers a thing that is installed out of the box in most distros? REPOSITORY R320 KI

D19698: Remove crash in plasmashell

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH remove_crash_bug_405351 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19698 To: mlaurent, dfaure, #frameworks, #plasma, broulik Cc: brou

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

This revision was automatically updated to reflect the committed changes. Closed by commit R288:4f4298539104: [KUiServerJobTracker] Update destUrl before finishing the job (authored by broulik). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19583?vs=53343

D19728: [GridViewKCM] Fix implicit width calculation

broulik edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19728 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19728: [GridViewKCM] Fix implicit width calculation

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Take into account paddings around the page and scroll view and also use the corr

D19728: [GridViewKCM] Fix implicit width calculation

This revision was automatically updated to reflect the committed changes. Closed by commit R296:72f438f8e7ad: [GridViewKCM] Fix implicit width calculation (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19728?vs=53799&id=53800 REVIS

D19500: [KDirModel] Fix job urls change signal connection

broulik added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19500 To: broulik, #frameworks, dfaure, jtamate Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19762: Only get clearTextPath when used

broulik created this revision. broulik added reviewers: Frameworks, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It does some queries and introspection that takes up to 2ms. TEST PLAN Mo

D19768: Fixes memory leak of ssh_session

broulik added a reviewer: sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19768 To: hallas, #frameworks, sitter Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19767: Fix malloc/delete mismatch

broulik added a reviewer: sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19767 To: hallas, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mi

D19762: Only get clearTextPath when used

This revision was automatically updated to reflect the committed changes. Closed by commit R245:185177379cc0: Only get clearTextPath when used (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19762?vs=53892&id=53996 REVISION DETAIL https:

D19786: Fix WebDAV directory renaming if KeepAlive is off

broulik added a reviewer: sitter. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19786 To: hoffmannrobert, #frameworks, #dolphin, dfaure, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19806: Allow selecting only supported audio files

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY While Phonon could play all the files, libcanberra as a low-latency notifi

D19805: Manager: Don't require Media1 interface for initialization

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH bug405478 REVISION DETAIL https://phabricator.kde.org/D19805 To: drosca, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19806: Allow selecting only supported audio files

This revision was automatically updated to reflect the committed changes. Closed by commit R305:5e2b9c838f3f: Allow selecting only supported audio files (authored by broulik). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19806?vs=54014&id=54358 REVISI

D19908: [ConfigModule] Pass initial properties

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN There's probably some std algo for it but `std::copy` didn't work so I gave up. di

D19978: Allow to set custom hints for notifications

broulik added a comment. +1 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19978 To: nicolasfella, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19985: [KStatusNotifierItem] Send desktop-entry hint

broulik created this revision. broulik added a reviewer: Framework: Syntax Highlighting. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This allows the notification service to know where the `showMe

D19985: [KStatusNotifierItem] Send desktop-entry hint

broulik edited reviewers, added: Frameworks; removed: Framework: Syntax Highlighting. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19985 To: broulik, #frameworks, #framework_syntax_highlighting Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19990: Switch URLs to https

broulik added a reviewer: leinir. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19990 To: vkrause, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19979: Don't create thumbnails for encrypted Vaults

broulik added inline comments. INLINE COMMENTS > previewjob.cpp:307 > > +auto mountsList = KMountPoint::currentMountPoints(); > +KMountPoint::List encryptedMountsList; Did you profile the impact of this call? I don't think it's cached. Can this maybe be moved to the thumbnail KIO so i

D20039: [KConfig] Add Notify capability for revertToDefault

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This enables `KConfigWatcher` TEST PLAN In preparation t

D20047: Add X-GNOME-UsesNotifications as recognized key

broulik edited the summary of this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D20047 To: broulik, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20047: Add X-GNOME-UsesNotifications as recognized key

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is set by Gnome applications that will spawn notifications for identifying t

D19985: [KStatusNotifierItem] Send desktop-entry hint

This revision was automatically updated to reflect the committed changes. Closed by commit R289:90050b02d725: [KStatusNotifierItem] Send desktop-entry hint (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19985?vs=54585&id=54813 RE

D20060: [KDynamicJobTracker] Use generated DBus interface

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids doing a blocking introspection call. TEST PLAN Started a

D19875: [Kactivities-stats] compile without foreach

broulik added a reviewer: ivan. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19875 To: mlaurent, dfaure, ivan Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20065: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule

broulik created this revision. broulik added reviewers: Frameworks, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Ensures `args` are passed into the `KQuickAddons::ConfigModule` TEST PLAN

D20060: [KDynamicJobTracker] Use generated DBus interface

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ed158497a322: [KDynamicJobTracker] Use generated DBus interface (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20060?vs=54848&id=54873 REVISION

D20070: [PlasmaComponents3 ComboBox] Fix textColor

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Uses the one from `ColorScope` rather than `Kirigami`. `Kirigami.Theme` isn't u

D20070: [PlasmaComponents3 ComboBox] Fix textColor

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d868804a7fe4: [PlasmaComponents3 ComboBox] Fix textColor (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20070?vs=54892&id=

D20039: [KConfig] Add Notify capability for revertToDefault

This revision was automatically updated to reflect the committed changes. Closed by commit R237:cad4889e490f: Add Notify capability to revertToDefault (authored by broulik). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20039?vs=54765&id=55167 REVISION DETAI

D20158: Allow to set urgency for notifications

broulik created this revision. broulik added reviewers: Plasma, Frameworks, vkrause, ogoffart, mck182. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This lets the application set an urgency hint on

D20065: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R295:dc3dd35d36c4: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule (authored by broulik). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20065?vs=54870

D20047: Add X-GNOME-UsesNotifications as recognized key

This revision was automatically updated to reflect the committed changes. Closed by commit R309:1c783fd26c91: Add X-GNOME-UsesNotifications as recognized key (authored by broulik). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20047?vs=54789&id=55180 REVISI

D20158: Allow to set urgency for notifications

broulik added a comment. In D20158#441322 , @vkrause wrote: > Nicely fits with the Android backend too, although that has one extra level (low, medium, high, urgent). I found the following enums in `NotificationManager`: - `IMPORTANC

D20158: Allow to set urgency for notifications

broulik added a comment. So, in essence you're fine with adding the enum as it is, and then have some mapping in the Android code? :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaure

D20176: make start-here-kde also available start-here-kde-plasma

broulik added a comment. Imho when we did the rebranding we should have added a `start-here-plasma` icon and switch to that everywhere rather than blatantly changing the `start-here-kde` icon +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20176 To: sitter

D20196: RFC: Add Notify capability to KConfigXT

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Lets you specify `Notifiers=` in `.kcfg` for config entries

D20196: RFC: Add Notify capability to KConfigXT

broulik edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D20196 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20199: [Menu] Fix triggered sign

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It casted the `QAction` to a `MenuItem` which fails because it isn't such. Instead,

D20200: [Dialog] Don't forward hover event when there is nowhere to forward it to

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Dialog has this clever way of re-sending a mouse event inside the bounardies of the d

D20199: [Menu] Fix triggered sign

This revision was automatically updated to reflect the committed changes. Closed by commit R242:9aa249e86a34: [Menu] Fix triggered signal (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20199?vs=55263&id=55267 REVISION

D20200: [Dialog] Don't forward hover event when there is nowhere to forward it to

This revision was automatically updated to reflect the committed changes. Closed by commit R242:9de0def99f96: [Dialog] Don't forward hover event when there is nowhere to forward it to (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabrica

D20210: [Label] Bump import version so padding properties are available

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN The following works now PlasmaComponents.Label { leftPadding: ... } REPOS

D18365: Add a flag to keep a window on top

broulik added a comment. +1 also needed for critical notifications, cf D20154 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18365 To: davidedmundson, #kwin Cc: broulik, apol, zzag, kde-frameworks-devel, michaelh, ngraham, brun

D20244: [AppletInterface] Check for corona before accessing it

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY On plasmashell shutdown when the panels are destroyed, the available screen geometry

D20244: [AppletInterface] Check for corona before accessing it

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c65145bd3463: [AppletInterface] Check for corona before accessing it (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20244?

D20196: RFC: Add Notify capability to KConfigXT

broulik added a dependent revision: D20265: Introduce libnotificationmanager. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D20196 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

broulik added a comment. I don't see how this could work. IconItem uses the first section as filename, for `active-quassel-tray` the word `active` and looks for an active.svgz which there isn't. This is a bug in Quassel, a violation of the FDO spec, it should have ebeen `quassel-tray-inactiv

D20196: RFC: Add Notify capability to KConfigXT

broulik planned changes to this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D20196 To: broulik, #frameworks, dfaure, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

broulik added a comment. Ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R289:39c6e0ea805c: Allow to set urgency for notifications (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20158?vs=55173&id=55726#toc REPOSITORY R289 KNotifications CHANGES

D20374: [KNotifications] Update when flags, urls, or urgency change

broulik created this revision. broulik added reviewers: Plasma, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It was forgotten to schedule an update when they changed. TEST PLAN Updatin

D20374: [KNotifications] Update when flags, urls, or urgency change

This revision was automatically updated to reflect the committed changes. Closed by commit R289:c0b14c032746: [KNotifications] Update when flags, urls, or urgency change (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20374?vs=5572

D20196: Add Notify capability to KConfigXT

broulik updated this revision to Diff 55730. broulik retitled this revision from "RFC: Add Notify capability to KConfigXT" to "Add Notify capability to KConfigXT". broulik edited the test plan for this revision. broulik added a comment. - Move stuff into `KConfigSkeletonItem` REPOSITORY R23

D19913: [plasma-desktop] make it compiles without foreach

broulik added inline comments. INLINE COMMENTS > coronatest.cpp:150 > +const auto containments = m_corona->containments(); > +for (auto cont : containments) { > switch (cont->id()) { Please always annotate `auto` with e.g. asterisk or ampersand depending on type > coronatest.cp

D19908: [ConfigModule] Pass initial properties

broulik added a comment. Pingeliping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19908 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

broulik abandoned this revision. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D14290 To: broulik, dfaure Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D10657: [UDisksDeviceBackend] Port from QDom to QXmlStreamReader

broulik abandoned this revision. broulik added a comment. Herald added a subscriber: kde-frameworks-devel. Superseded by D10657 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10657 To: broulik, #frameworks, davidedmundson, apol Cc:

D20433: Use mount point returned from DBus instead of using property value

broulik added a reviewer: bruns. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20433 To: nicolasfella, broulik, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20433: Use mount point returned from DBus instead of using property value

broulik added inline comments. INLINE COMMENTS > udisksstorageaccess.cpp:35 > StorageAccess::StorageAccess(Device *device) > -: DeviceInterface(device), m_setupInProgress(false), > m_teardownInProgress(false), m_passphraseRequested(false) > +: DeviceInterface(device), m_setupInProgress(

D20417: Add invokable public API for emitting contextualActionsAboutToShow

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks for taking care of this REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20417 To: davidedmundson, #plasma, broulik Cc:

D19908: [ConfigModule] Pass initial properties

This revision was automatically updated to reflect the committed changes. Closed by commit R296:238a49139fd6: [ConfigModule] Pass initial properties in push() (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19908?vs=54398&id=55969 R

D20462: [KUiServerJobTracker] Track kuiserver service life time and re-register jobs if needed

broulik created this revision. broulik added reviewers: Frameworks, dfaure, lbeltrame, kossebau, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When the process providing the kuiser

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

broulik created this revision. broulik added reviewers: Frameworks, dfaure, lbeltrame. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It asks kuiserver whether we need to display a widget job tracke

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

broulik added a comment. I think so, it's the very same patch in that bugreport :) So, this patch makes even more sense, I only considered the Plasma case REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20465 To: broulik, #frameworks, dfaure, lbeltrame Cc: ngraham, kde-

D20462: [KUiServerJobTracker] Track kuiserver service life time and re-register jobs if needed

This revision was automatically updated to reflect the committed changes. Closed by commit R288:130809f97e6f: [KUiServerJobTracker] Track kuiserver service life time and re-register jobs if… (authored by broulik). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:580fec7c0b20: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget… (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20465

D20570: [FrameSvgItem] Respect smooth property

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Set `smooth: true`, rotated it, didn't look jagged anymore REPOSITORY R242 Plasma Framewor

D20570: [FrameSvgItem] Respect smooth property

broulik planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20570 To: broulik, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20570: [FrameSvgItem] Respect smooth property

broulik updated this revision to Diff 56289. broulik added a comment. - Also update corner nodes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20570?vs=56288&id=56289 REVISION DETAIL https://phabricator.kde.org/D20570 AFFECTED FILES

D20570: [FrameSvgItem] Respect smooth property

This revision was automatically updated to reflect the committed changes. Closed by commit R242:2a636d66712f: [FrameSvgItem] Respect smooth property (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20570?vs=56289&id=5629

D20428: separe mobile text selection to avoid recursive imports

broulik added inline comments. INLINE COMMENTS > ComboBox.qml:174 > id: mobileCursor > Private.MobileCursor { > target: textField Does this not need to be adjusted? `ComboBox` is broken here. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://

D20592: Set correct kwalletd_bin_path

broulik created this revision. broulik added reviewers: davidedmundson, jriddell. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It is installed as `kwalletd5` TEST PLAN Compiled this and kwallet

D20592: Set correct kwalletd_bin_path

This revision was automatically updated to reflect the committed changes. Closed by commit R311:25f9723e87ce: Set correct kwalletd_bin_path (authored by broulik). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20592?vs=56347&id=56349 REVISION DETAIL https:/

D20594: Fix MobileTextSelection namespacing

broulik created this revision. broulik added reviewers: Plasma, mart, hein. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It is all in `MobileTextSelection` instead of `Private` now. TEST PLAN I

D20594: Fix MobileTextSelection namespacing

broulik edited the summary of this revision. broulik added a reviewer: lbeltrame. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20594 To: broulik, #plasma, mart, hein, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20594: Fix MobileTextSelection namespacing

broulik closed this revision. broulik added a comment. https://cgit.kde.org/plasma-framework.git/commit/?id=8431223542110fd112cda5a4b352ab4a8a21bb51 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20594 To: broulik, #plasma, mart, hein, lbeltrame

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Instead of swapping out one random number for another, please correctly calculate the implicit size of the page, like `GridViewKCM` does: Something like implicitHeight:

D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

broulik added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20602 To: kossebau, #plasma, #vdg Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20627: Introduce CriticalNotificationType

broulik created this revision. broulik added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This is a dedicated window type indicating a critical notification that is more urgent

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

broulik created this revision. broulik added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Compiles, tests adjusted and pass. I need some help with the versioning stuff please REPOSIT

D20627: Introduce CriticalNotificationType

broulik added a dependent revision: D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D20627 To: broulik, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20627: Introduce CriticalNotificationType

broulik added a dependent revision: D20630: [Dialog] Add CriticalNotification type. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D20627 To: broulik, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20630: [Dialog] Add CriticalNotification type

broulik created this revision. broulik added reviewers: Plasma, KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Allows to flag a dialog window as critical notification that should be shown eve

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

broulik added a dependent revision: D20629: Support CriticalNotification type and place it in a CriticalNotificationLayer. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20628 To: broulik, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Volume icon are consistent now, Vault icon in tray is prettier (imho), media controls look unchanged/fine, folder view nav buttons look fine/better, lgtm REPOSITORY R242 Plasma Framewor

D20158: Allow to set urgency for notifications

broulik added a comment. @vkrause I just noticed xdg portal notification spec (the ones used for sandboxed flatpak apps) has four urgency levels: low, normal, *high*, critical. Do you think it would be useful to add `HighUrgency`, too? For Android, maybe? For freedesktop Notifications we co

D20158: Allow to set urgency for notifications

broulik added a comment. Good point, I shall space them apart a bit. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20648: [KNotification] Add HighUrgency

broulik created this revision. broulik added reviewers: Frameworks, dfaure, vkrause, ogoffart, nicolasfella. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Freedesktop notifications only know low, n

D20649: [Notify by Portal] Support default action and priority hints

broulik created this revision. broulik added reviewers: Frameworks, jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. TEST PLAN Compiles, untested as I couldn't figure out the flatpak build system stuff REPO

D20158: Allow to set urgency for notifications

broulik added a dependent revision: D20651: Support default action, priority hints, set desktop-entry. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh,

D20648: [KNotification] Add HighUrgency

broulik added a dependent revision: D20651: Support default action, priority hints, set desktop-entry. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20648 To: broulik, #frameworks, dfaure, vkrause, ogoffart, nicolasfella Cc: kde-frameworks-devel, michaelh, ngra

D20648: [KNotification] Add HighUrgency

broulik added inline comments. INLINE COMMENTS > dfaure wrote in knotification.h:283 > Isn't the change of value BIC? Even if it was, this stuff isn't released yet REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20648 To: broulik, #frameworks, dfaure, vkrause,

D20655: Use generated DBus interface

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids introspection calls when creating the manager or devi

D20648: [KNotification] Add HighUrgency

This revision was automatically updated to reflect the committed changes. Closed by commit R289:134e131762e9: [KNotification] Add HighUrgency (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20648?vs=56493&id=56503 REVISION DETAIL

D20649: [Notify by Portal] Support default action and priority hints

broulik updated this revision to Diff 56504. broulik added a comment. - Support `high` - Handle all switch cases REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20649?vs=56494&id=56504 REVISION DETAIL https://phabricator.kde.org/D20649 AFFECTED

D20649: [Notify by Portal] Support default action and priority hints

This revision was automatically updated to reflect the committed changes. Closed by commit R289:85bdacf738eb: [Notify by Portal] Support default action and priority hints (authored by broulik). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20649?vs=565

<    4   5   6   7   8   9   10   11   12   13   >