Re: Solid situation for 5.0

2014-06-24 Thread Kevin Ottens
On Tuesday 24 June 2014 19:17:44 Àlex Fiestas wrote: > On Monday 23 June 2014 19:29:19 Kevin Ottens wrote: > > What do you mean? Not releasing solid as part of 5.0? Not enabling the new > > async API? > > Not enabling the new api. I don't really like that... But I don

Re: Solid situation for 5.0

2014-06-23 Thread Kevin Ottens
Hello, On Monday 23 June 2014 17:56:20 Àlex Fiestas wrote: > As many of you know late in the game I started writing some new code to add > much needed asynchronous api to Solid/Power which meant moving the old > deprecate code to kdelibs4Support. > > The new API is done (you can review it on mast

Re: git hooks for reviews mandatory?

2014-06-21 Thread Kevin Ottens
On Saturday 21 June 2014 11:22:28 Michael Pyne wrote: > On Thu, June 19, 2014 23:21:22 Marco Martin wrote: > > Hi all, > > I was thinking, since the policy for committing in frameworks is to always > > asking for a review, what about on repositories under frameworks/* adding > > an hook that accept

Re: git hooks for reviews mandatory?

2014-06-21 Thread Kevin Ottens
On Friday 20 June 2014 22:11:57 Albert Astals Cid wrote: > El Divendres, 20 de juny de 2014, a les 01:46:10, Aleix Pol va escriure: > > I've heard of many complaints about how noisy is kde-frameworks mailing > > list because of review requests. Also, I fear there's people not working > > at full sp

Re: git hooks for reviews mandatory?

2014-06-21 Thread Kevin Ottens
On Friday 20 June 2014 13:13:20 Aleix Pol wrote: > On Fri, Jun 20, 2014 at 7:40 AM, Kevin Ottens wrote: > > On Friday 20 June 2014 01:46:10 Aleix Pol wrote: > > > On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin > > > > wrote: > > > > Hi all, &g

Re: git hooks for reviews mandatory?

2014-06-19 Thread Kevin Ottens
On Friday 20 June 2014 01:46:10 Aleix Pol wrote: > On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin wrote: > > Hi all, > > I was thinking, since the policy for committing in frameworks is to always > > asking for a review, what about on repositories under frameworks/* adding > > an > > hook that acc

Re: Building KF5

2014-06-19 Thread Kevin Ottens
Hello, On Thursday 19 June 2014 22:30:26 André Wöbbeking wrote: > I wanted to give KF5 a try and followed the instructions from > http://community.kde.org/Frameworks/Building. After Albert told me not to > use Clang most of it compiled without any problem. Actually if it breaks with Clang it shou

Re: KCoreAddons does not install most of its headers on my system

2014-06-18 Thread Kevin Ottens
On Thursday 19 June 2014 08:21:30 Ben Cooksley wrote: > On 19 June 2014 07:19, Kevin Ottens wrote: > > On Monday 16 June 2014 20:55:10 Michael Pyne wrote: > >> On Mon, June 16, 2014 13:14:47 Kevin Ottens wrote: > >> > On Monday 16 June 2014 12:58:30 Àlex Fiestas wrot

Re: KCoreAddons does not install most of its headers on my system

2014-06-18 Thread Kevin Ottens
On Monday 16 June 2014 20:55:10 Michael Pyne wrote: > On Mon, June 16, 2014 13:14:47 Kevin Ottens wrote: > > On Monday 16 June 2014 12:58:30 Àlex Fiestas wrote: > > > I encountered this yesterday, for a quick workaround rollback to cmake > > > 3.0 > > >

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Kevin Ottens
> On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: > > Marco, any chance for a second run of review on that patch? > > Marco Martin wrote: > i still not like this patch.. > > Kevin Ottens wrote: > Should be dropped then? Or it can get somewhere? >

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Kevin Ottens
> On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: > > Marco, any chance for a second run of review on that patch? > > Marco Martin wrote: > i still not like this patch.. Should be dropped then? Or it can get somewhere? Feel free to drop it if you consider it a dead end

Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

2014-06-17 Thread Kevin Ottens
> On June 16, 2014, 7:10 p.m., Martin Gräßlin wrote: > > I would like to get the opinion from people who designed kglobalaccel. > > Personally I do not understand what the default shortcuts are for and why > > they are needed. > > > > From reading the documentation my understanding is that you

Re: Review Request 118780: Disable the xcb flush connection workaround for Qt >= 5.3.1

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118780/#review60291 --- Ship it! Ship It! - Kevin Ottens On June 16, 2014, 12:42

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

2014-06-17 Thread Kevin Ottens
ge in, and improve internals later" approach. Let's wait for David's opinion though. - Kevin Ottens On June 16, 2014, 7:58 a.m., Frank Reininghaus wrote: > > --- > This is an automatically generate

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

2014-06-17 Thread Kevin Ottens
> On June 16, 2014, 10:09 a.m., Emmanuel Pescosta wrote: > > src/core/kcoredirlister_p.h, lines 40-42 > > > > > > "using KFileItem::KFileItem;" maybe? > > Frank Reininghaus wrote: > Maybe - I'm always a bit u

Re: Review Request 118498: Make ECM language-independent again, but make the tests use C

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/#review60285 --- Ship it! Looks fine to me. - Kevin Ottens On June 15

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-17 Thread Kevin Ottens
c -tr i18n". Can go in IMO. - Kevin Ottens On June 12, 2014, 8:55 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 118740: Use standard message box icon size in password dialogs

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118740/#review60283 --- Ship it! Ship It! - Kevin Ottens On June 14, 2014, 11:11

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/#review60282 --- Ship it! Looks fine to me. - Kevin Ottens On June 14

Re: Review Request 118725: use renamed .direcory files

2014-06-17 Thread Kevin Ottens
it though. - Kevin Ottens On June 13, 2014, 11:31 a.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: Review Request 117974: Some more KArchive examples

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/#review60278 --- Ship it! Ship It! - Kevin Ottens On June 6, 2014, 7:15

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Kevin Ottens
? - Kevin Ottens On June 4, 2014, 10:43 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 118162: Make sure to use the absolute file path for test files.

2014-06-17 Thread Kevin Ottens
> On May 16, 2014, 11:49 a.m., Alex Merry wrote: > > This sounds like an issue that needs to be fixed in KArchive... > > Alex Merry wrote: > Where, exactly, were the files appearing? And which files were appearing > there? Any update about that patch? - Kevin --

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

2014-06-17 Thread Kevin Ottens
s not committed yet? - Kevin Ottens On May 15, 2014, 3 p.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 117985: frameworks/kjs: add missing man page docbook

2014-06-17 Thread Kevin Ottens
> On May 5, 2014, 7:17 a.m., Kevin Ottens wrote: > > IIRC that was intentional as to not have kjs depend on kdoctools. > > Alex Merry wrote: > Hrm. Distros like Debian aren't going to be super-happy about this. And > KJS is officially a porting aid, so I'm n

Re: Review Request 118264: Switch to PolkitQt5-1

2014-06-17 Thread Kevin Ottens
voje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118264/ > --- > > (Updated May 28, 2014,

KF5 Update Meeting Minutes 2014-w25

2014-06-17 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 25 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: agateau, apol, mgraesslin and myself. * agateau did some kapidox fixes on api.kde.org; * he also fixed a crash in KCMultiDialog; * he also proposed ColumnR

Re: KCoreAddons does not install most of its headers on my system

2014-06-16 Thread Kevin Ottens
On Monday 16 June 2014 12:58:30 Àlex Fiestas wrote: > On Mon, Jun 16, 2014 at 9:41 AM, Frank Reininghaus > wrote: > > > > Hello everyone, > > > > I tried to set up a separate Qt5+KF5 build in release mode. > > Unfortunately, I did not succeed :-( > > > > The first package that fails to build (e

Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

2014-06-16 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/#review60175 --- Ship it! Ship It! - Kevin Ottens On May 26, 2014, 7:09

KF5 Update Meeting 2014-w25 Reminder

2014-06-16 Thread Kevin Ottens
Hello all, After a three week hiatus because of me going on vacations and not managing properly to have someone impersonate me... a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.n

Re: Review Request 118614: Make KIO thread-safe

2014-06-14 Thread Kevin Ottens
adjustments. That's great! Definitely a go IMO. As for KDBusConnectionPool it's fine to use it I think. As you pointed out it'll be easy to switch later on if QTBUG-39528 gets addressed. - Kevin Ottens On June 8, 2014, 10:11 a.m., Da

Re: Review Request 118603: Remove data race on boolean by removing qRegisterMetaType call altogether.

2014-06-07 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118603/#review59515 --- Ship it! Ship It! - Kevin Ottens On June 7, 2014, 3:12

Re: Keeping CI green

2014-06-03 Thread Kevin Ottens
Hello, On Thursday 22 May 2014 21:08:05 Alex Merry wrote: > There are currently four frameworks that are yellow (for between 6 hours and > 8 days). kdelibs4support has had 3 commits (not counting those by scripty) > since it broke that have done nothing to fix the issue. > > If we claim that our

Re: How to port KIntSpinBox::setSuffix

2014-06-03 Thread Kevin Ottens
Hello, On Tuesday 03 June 2014 17:59:18 David Faure wrote: > On Tuesday 03 June 2014 17:53:22 Kevin Ottens wrote: > > I'm not sure I get the reasoning leading to that conclusion. Can't be done > > upstream in Qt? > > This is all about calling i18n() at runtime, fro

Re: Themed icons on Windows

2014-06-03 Thread Kevin Ottens
On Monday 26 May 2014 03:44:54 Aleix Pol wrote: > An alternative can be making KGuiAddons depend on a library that, Why not in KGuiAddons itself? > on windows, registers a Q_COREAPP_STARTUP_FUNCTION function that will set up > anything that's needed. Sounds like the best course of action IMO. >

Re: How to port KIntSpinBox::setSuffix

2014-06-03 Thread Kevin Ottens
On Sunday 01 June 2014 10:34:07 David Faure wrote: > On Friday 30 May 2014 07:54:45 Martin Gräßlin wrote: > > Hi all, > > > > while trying to get rid of kdelibs4support I stumbled [1] over > > KIntSpinBox::setSuffix which allows to set a plural aware suffix. The > > recommendation is to port to QS

KF5 Update Meeting Minutes 2014-w20

2014-05-13 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 20 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, arichardson, PovAddict, Riddell, sebas, shadeslayer, teo and myself. * afiestas has been working on the async powermanagement

Re: KFileAudioPreview

2014-05-12 Thread Kevin Ottens
On Monday 12 May 2014 22:46:08 Alex Merry wrote: > KFileAudioPreview is currently a framework that just provides a plugin. > This plugin is specifically looked for by the KFileMetaPreview class in KIO. > > Perhaps it's too late to change this, but it seems to me that this > plugin should either be

Re: Review Request 118098: Guard against empty QStringLists

2014-05-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118098/#review57793 --- Ship it! Ship It! - Kevin Ottens On May 12, 2014, 2:32

Re: Review Request 118084: Move sonnet plugins into kf5/sonnet subdir of plugin install dir

2014-05-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118084/#review57792 --- Ship it! Ship It! - Kevin Ottens On May 11, 2014, 2:48

Re: Review Request 118083: Move theme plugins to kf5/emoticonsthemes subdir of plugins dir

2014-05-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118083/#review57791 --- Ship it! Ship It! - Kevin Ottens On May 11, 2014, 2:11

Re: Review Request 118080: Move kioslaves to the "kf5/kio" subdirectory of the plugin directory

2014-05-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118080/#review57790 --- Ship it! Ship It! - Kevin Ottens On May 11, 2014, 2 p.m

Re: Review Request 118081: Move metainfo ioslave to kf5/kio subdirectory of plugin install dir

2014-05-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118081/#review57789 --- Ship it! Ship It! - Kevin Ottens On May 11, 2014, 2:01

Re: Review Request 118057: Use CMAKE_INSTALL_FOODIR style variables for KDEInstallDirs

2014-05-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118057/#review57788 --- Ship it! Ship It! - Kevin Ottens On May 8, 2014, 8:48 p.m

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-05-12 Thread Kevin Ottens
> On May 7, 2014, 1:30 p.m., Sven Brauch wrote: > > Ping, any new opinions on this? Looks good to me, but I'd rather see someone more knowledgeable with ktexteditor give the ship it. - Kevin --- This is an automatically generated e-mai

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

2014-05-12 Thread Kevin Ottens
along the way. K4About* is supposed to be the porting tool, so let's have this one in even if that's SIC. - Kevin Ottens On May 1, 2014, 1:03 a.m., Michael Pyne wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 117974: Some more KArchive examples

2014-05-12 Thread Kevin Ottens
org/r/117974/#comment40235> Maybe a better idea to use a loop to avoid the readAll? I know that's an example which needs to be kept simple, but that would be a bit more realistic to read a few bytes from the input and write them in the output to not load the memory. - Kevin Ottens

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-05-12 Thread Kevin Ottens
> On April 12, 2014, 10:48 a.m., Alex Merry wrote: > > This is my preferred solution, and is hopefully only a temporary one. > > However, I know David Faure doesn't like it, and (I assume) would rather > > have a generic LIBEXEC variable. > > > > My view is that libexec should be used for stu

Re: Review Request 118096: Remove unbuilt doc

2014-05-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118096/#review57779 --- Ship it! Ship It! - Kevin Ottens On May 12, 2014, 12:35

Re: Removing Sonnet documentation?

2014-05-12 Thread Kevin Ottens
Hello, On Monday 12 May 2014 03:15:22 Aurélien Gâteau wrote: > We can either turn Sonnet into a tier 3 module, remove the documentation > or move it somewhere else. Bumping Sonnet from tier 1 to tier 3 sounds > bad to me. Since the documentation only describes the correction dialog, > I suggest re

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Kevin Ottens
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Kevin Ottens
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote: > > AFAICT it is BIC but no SIC, no brainer. > > Martin Gräßlin wrote: > it's a SIC change as one could have used the variant specifying just > NET::Properties and screen. This would now have to be changed to use

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118016/#review57407 --- Ship it! AFAICT it is BIC but no SIC, no brainer. - Kevin

KDE Frameworks: There will be a beta 3

2014-05-05 Thread Kevin Ottens
Hello all, After the release of beta 2, we realized that it couldn't be the last beta for several reasons: * a long standing release blocker in libsolid still wasn't addressed in time for beta 2, it'll hopefully be solved in the next few days, otherwise we'll put in place a contingency plan;

Re: Review Request 117985: frameworks/kjs: add missing man page docbook

2014-05-05 Thread Kevin Ottens
kdoctools. - Kevin Ottens On May 4, 2014, 7:21 a.m., Burkhard Lück wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Tardy "KDE5 porting" for KAboutData

2014-04-29 Thread Kevin Ottens
On Tuesday 29 April 2014 22:32:46 Michael Pyne wrote: > Hi all, > > I was running through Kévin's frameworks release checklist for KCoreAddons, > and came across a class that has some residual porting to accomplish for > KF5, KAboutData. > > This class has 2 enums which are commented as needing t

KF5 Update Meeting Minutes 2014-w18

2014-04-29 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 18 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, dfaure, notmart, PovAddict, Riddell, shadeslayer, tosky, teo, vHanda and myself Announcement: * Beta 2 to be tagged end of this wee

Re: KF5 Maintainers: Please get ready for release

2014-04-29 Thread Kevin Ottens
On Tuesday 29 April 2014 12:40:16 Vishesh Handa wrote: > On Sunday, April 27, 2014 12:32:25 AM Kevin Ottens wrote: > > No maintainer: > > - krunner (porting aid) > > I'm willing to maintain krunner. Please add vhanda to the maintainer key in the metainfo.yaml file

Re: visibility compile flag

2014-04-29 Thread Kevin Ottens
Hello, On Monday 28 April 2014 19:50:51 Àlex Fiestas wrote: > I'm porting libkscreen to Frameworks and I found that we are passing (when > available) -fvisibility=hidden. > > After reading this[1] really quick I thought I would send an email here so > people wiser than me can decide if it makes s

Re: KF5 Maintainers: Please get ready for release

2014-04-28 Thread Kevin Ottens
On Monday 28 April 2014 18:13:44 Marco Martin wrote: > On Monday 28 April 2014, Kevin Ottens wrote: > > Martin Klapetek did that for all frameworks a while back. All the > > frameworks related products are prefixed with "frameworks-". Looks like > > your modules

Re: KF5 Maintainers: Please get ready for release

2014-04-28 Thread Kevin Ottens
Hello, On Monday 28 April 2014 16:32:41 Ivan Čukić wrote: > Should we create a new component in bko, or we can rename the existing one > (kactivities -> frameworks-kactivities)? (I did the former, but wanted to > check) Whatever works for you. > The same question for the revboard - should the r

Re: KF5 Maintainers: Please get ready for release

2014-04-28 Thread Kevin Ottens
Hello, On Monday 28 April 2014 13:32:08 Marco Martin wrote: > On Sunday 27 April 2014, Kevin Ottens wrote: > > Marco Martin: > > - kdeclarative > > - plasma-framework > > I think it's pretty fine on my part, i'll take another review on the > metada

Re: Kioslave repos

2014-04-27 Thread Kevin Ottens
On Sunday 27 April 2014 15:39:05 David Faure wrote: > On Tuesday 08 April 2014 06:02:33 Àlex Fiestas wrote: > > On Monday 07 April 2014 23:27:33 Alex Merry wrote: > > > Aleix wanted a separate thread for this, so here it is. > > > > > > The current runtime splitting plan says that ioslaves should

KDE Frameworks Release Cycle

2014-04-27 Thread Kevin Ottens
Hello people, As you may have noticed, we're covering quite a few tasks here during the sprint. But, we're also having discussion topics, and the most important one we covered is the release cycle. Indeed, we got the question several times already of "once 5.0 is out what will happen?" It is wh

KF5 Maintainers: Please get ready for release

2014-04-27 Thread Kevin Ottens
Hello framework maintainers, As you know we're getting near the final release. If we don't hit a critical issue, we'll release the final early June. Before that, we'll have a second beta on May 4th, and we'd like it to look as close to the final as possible. That's why I'm sending you this emai

Re: Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability

2014-04-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/#review56637 --- Ship it! Ship It! - Kevin Ottens On April 26, 2014, 4:48

Re: Review Request 117688: Do not skip a language if there is no application catalog for it

2014-04-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117688/#review56630 --- Ship it! Ship It! - Kevin Ottens On April 22, 2014, 1:39

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56629 --- Ship it! Ship It! - Kevin Ottens On April 25, 2014, 7:18

Re: plasma-framework in kdereview

2014-04-26 Thread Kevin Ottens
Hello, On Saturday 26 April 2014 02:33:07 Kevin Ottens wrote: > On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote: > > El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure: > > > since it was done earlier this week, better announce it forma

Re: plasma-framework in kdereview

2014-04-25 Thread Kevin Ottens
Hello, On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote: > El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure: > > since it was done earlier this week, better announce it formally, so > > everybody can actually do the -review part ;) > > Had a look and i18n wise

Re: Review Request 117780: Add a FindKF5.cmake module

2014-04-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117780/#review56584 --- Ship it! Ship It! - Kevin Ottens On April 25, 2014, 11:14

Re: plasma-framework in kdereview

2014-04-25 Thread Kevin Ottens
On Friday 25 April 2014 15:14:46 Àlex Fiestas wrote: > On Friday 25 April 2014 12:34:32 Marco Martin wrote: > > Hi all, > > since it was done earlier this week, better announce it formally, so > > everybody can actually do the -review part ;) > > > > the plasma-framework repository has been moved

Re: Review Request 117708: move kioslave docs paths for co-installability

2014-04-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/#review56509 --- Ship it! Ship It! - Kevin Ottens On April 23, 2014, 3:24

Re: Review Request 117733: Fully port KXMessages to XCB

2014-04-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117733/#review56508 --- Ship it! Ship It! - Kevin Ottens On April 25, 2014, 6:58

Re: Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/#review56448 --- Ship it! Ship It! - Kevin Ottens On April 24, 2014, 5:46

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56446 --- Ship it! Ship It! - Kevin Ottens On April 24, 2014, 5:27

Re: Review Request 117708: move kioslave docs paths for co-installability

2014-04-24 Thread Kevin Ottens
> On April 23, 2014, 3:30 p.m., Luigi Toscano wrote: > > I think after this change many documentation links (at least in > > khelpcenter) need to be fixed (I can't check now). That'd need to be confirmed before letting this patch in or not. - Kevin --

Re: Review Request 117704: Deprecate obsolete KStartupInfo ctor

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117704/#review56443 --- Ship it! Ship It! - Kevin Ottens On April 23, 2014, 12:19

Re: Review Request 117706: remove unused kwallet upgrade script

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117706/#review56444 --- Ship it! Ship It! - Kevin Ottens On April 23, 2014, 1:37

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/#review56441 --- Ship it! Ship It! - Kevin Ottens On April 24, 2014, 10:17

Re: Review Request 117703: Use NETWinInfo instead of custom XLib code in KStartupInfo

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117703/#review56442 --- Ship it! Ship It! - Kevin Ottens On April 23, 2014, 11:58

Re: Review Request 117749: Allow kmimeassociationstest to be run alone

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/#review56440 --- Looks fine to me. Let's wait for David though. -

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56439 --- Any chance to have some unit tests? - Kevin Ottens On

Re: Review Request 117682: Define _DARWIN_C_SOURCE when building on Mac

2014-04-24 Thread Kevin Ottens
ave a bit of time to react. - Kevin Ottens On April 22, 2014, 11:51 p.m., Allen Winter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/#review56436 --- Ship it! Ship It! - Kevin Ottens On April 21, 2014, 9:49

Re: Review Request 117581: Remove ECMDBusAddActivationService module

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/#review56435 --- Ship it! Ship It! - Kevin Ottens On April 21, 2014, 9:47

Re: Review Request 117658: Add a stub for ECMFindModuleHelpers to the find-modules dir

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117658/#review56434 --- Ship it! Ship It! - Kevin Ottens On April 20, 2014, 3 p.m

Re: Review Request 117617: New syntax for ecm_install_icons()

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117617/#review56432 --- Ship it! Ship It! - Kevin Ottens On April 17, 2014, 7:40

Re: Review Request 117602: Remove more UPnP stuff

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117602/#review56430 --- Ship it! Ship It! - Kevin Ottens On April 16, 2014, 7:46

Re: Review Request 117593: ECMGeneratePriFile: Allow lib and include install dirs to be overridden

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117593/#review56428 --- Ship it! Ship It! - Kevin Ottens On April 16, 2014, 1:35

Re: Review Request 117585: ECMFindModuleHelpers: set traditional variables

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117585/#review56427 --- Ship it! Ship It! - Kevin Ottens On April 16, 2014, 1:14

Re: Review Request 117583: Remove use of ecm_dbus_add_activation_service()

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117583/#review56426 --- Ship it! Ship It! - Kevin Ottens On April 16, 2014, 10:25

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/#review56425 --- Ship it! Ship It! - Kevin Ottens On April 14, 2014, 4:04

Re: Review Request 117491: Rework FindX11_XCB.cmake

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review56423 --- Ship it! Ship It! - Kevin Ottens On April 11, 2014, 8:32

Re: Default bugzilla asignees for frameworks

2014-04-15 Thread Kevin Ottens
On Tuesday 15 April 2014 17:07:38 Martin Klapetek wrote: > Hey, > > As we now have people stepping up as frameworks maintainers, I think part > of that maintainership should be becoming the default assignee for given > framework on bugzilla. > > For example I filed a bug against KIO and that was

KF5 Update Meeting Minutes 2014-w16

2014-04-15 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 16 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, apol, notmart, tosky and myself Announcement: * I won't be around next week for the meeting, Riddell will run the one next wee

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-14 Thread Kevin Ottens
> On April 12, 2014, 11:12 a.m., Kevin Krammer wrote: > > I wonder if this really belongs in kdecoreaddons. I.e. it is only relevant > > for KDE applications porting, right? > > IMHO this would fit best in an explicit porting framework > > David Faure wrote: > I don't want to put this in kd

Re: Review Request 117532: Remove rlogin docbook

2014-04-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117532/#review55751 --- Ship it! Ship It! - Kevin Ottens On April 13, 2014, 9:22

Re: Review Request 117490: Improve FindEGL.cmake

2014-04-14 Thread Kevin Ottens
at it. - Kevin Ottens On April 11, 2014, 8:21 p.m., Alex Merry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 117495: Fix doc of KWindowInfo::clientMachine()

2014-04-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117495/#review55746 --- Ship it! Ship It! - Kevin Ottens On April 11, 2014, 5:52

<    1   2   3   4   5   6   7   8   9   10   >