D13986: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R301 KEmoticons REVISION DETAIL https://phabricator.kde.org/D13986 To: arojas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13991: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R312 KXmlRpcClient REVISION DETAIL https://phabricator.kde.org/D13991 To: arojas, dvratil, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13989: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D13989 To: arojas, apol, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13987: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D13987 To: arojas, afiestas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13974: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R277 KPlotting REVISION DETAIL https://phabricator.kde.org/D13974 To: arojas, cfeck, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13972: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D13972 To: arojas, mart, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13958: Honor BUILD_TESTING

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D13958 To: arojas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

mlaurent added a comment. Ping bis ?:) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: dfaure, #frameworks

D11285: Introduce sanitizer class

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > databasesanitizer.cpp:44 > +struct FileInfo { > +quint32 deviceId; > +quint32 inode; initialize value by default please >

D11285: Introduce sanitizer class

mlaurent added a comment. Is it possible to create an autotest for this class ? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham, mlaurent Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella,

D12283: Allow to load dictionaries form a rcc

mlaurent added inline comments. INLINE COMMENTS > hunspelldict.cpp:104 > delete m_speller; > +if (m_tempDir) { > +delete m_tempDir; not necessary to check pointer here. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D12283 To:

D12283: Allow to load dictionaries form a rcc

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Remove indent and commit it :) Thanks INLINE COMMENTS > hunspellclient.cpp:104 > +} > +return QString(); > +} fix indent REPOSITORY R246 Sonnet BRANCH master

D12282: Look into subdirectories for dictionaries

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks :) REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D12282 To: vonreth, mlaurent Cc: #frameworks, michaelh, ngraham, bruns

D11285: Introduce sanitizer class

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. +2 for me but I don't know baloo code :) REPOSITORY R293 Baloo BRANCH sanitize-class (branched from master) REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh,

D11285: Introduce sanitizer class

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > databasesanitizer.cpp:46 > +public: > +FileInfo(const quint32 d = 0, const quint32 i = 0, > +const QString& u = QString(),

D11287: Introduce baloodb CLI tool

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:103 > +QStringLiteral("devices"), > +i18n("List devices "), > +QStringList{}, extra space at the end of i18n >

D11287: Introduce baloodb CLI tool

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:16 > + > +install(TARGETS baloodb DESTINATION ${BIN_INSTALL_DIR}) install(TARGETS baloodb ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}) >

D11287: Introduce baloodb CLI tool

mlaurent added inline comments. INLINE COMMENTS > michaelh wrote in CMakeLists.txt:16 > @mlaurent Is it worth the effort to change this for the other cli tools > accordingly? It's the default variable. But don't chnage it in this patch. Perhaps in the future as you are the baloo maintainer :)

D11287: Introduce baloodb CLI tool

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH sanitize-cmd (branched from master) REVISION DETAIL https://phabricator.kde.org/D11287 To: michaelh, #baloo, #frameworks, mlaurent Cc: mlaurent, ngraham, ashaposhnikov,

D10744: Use correct directory to lookup trigrams in windows build dir

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems good for me REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D10744 To: vonreth, mlaurent, dfaure, leinir Cc: #frameworks, michaelh

D15277: [mtp] Move MTP device handling from kioslave to kiod-module

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH mtp_next (branched from master) REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent Cc: mlaurent,

D16306: [Codecs] Remove unneeded const_cast

mlaurent added a reviewer: dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16306 To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:65 > + rename/batchrenamedialog.cpp > +rename/batchrenamedialogmodel_p.cpp > +rename/batchrenametypes_p.cpp fix indent >

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

mlaurent added inline comments. INLINE COMMENTS > emateli wrote in batchrenamedialog.h:69 > You mean to initialize them to nullptr on the header file or using a > constructor initialization list? Also see what problem? in header file. REPOSITORY R241 KIO REVISION DETAIL

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > batchrenamedialog.cpp:40 > +#include > +#include > +#include remove QtWidget > batchrenamedialog.cpp:41 > +#include > +#include > + remove QtGui

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

mlaurent accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

mlaurent added a comment. For me seems good +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D15778: Log wallet open failure errors

mlaurent accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mtpstorage.cpp:176 > +case LIBMTP_FILETYPE_UNDEF_AUDIO: > +return QStringLiteral(""); > +case LIBMTP_FILETYPE_WMV: QString() directly no

D16001: ktextedit: lazy load the QTextToSpeech object

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH lazy-qtexttospeech (branched from master) REVISION DETAIL https://phabricator.kde.org/D16001 To: pino, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

mlaurent added a comment. Ping? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

This revision was automatically updated to reflect the committed changes. Closed by commit R240:9b528012703a: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags (authored by mlaurent). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D15778: Log wallet open failure errors

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kwalletd.cpp:685 > +const auto errorStr = > KWallet::Backend::openRCToString(rc); > +

D16966: Fix typo in i18n message (cmdline option description)

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH opt-i18n REVISION DETAIL https://phabricator.kde.org/D16966 To: aspotashev, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18424: Instantiate QApplication before KCrash/KCatalog

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18424 To: sdepiets, #baloo, bruns, poboiko, mlaurent Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16966: Fix typo in i18n message (cmdline option description)

mlaurent added a comment. no commited yet ?:) REPOSITORY R290 KPackage BRANCH opt-i18n REVISION DETAIL https://phabricator.kde.org/D16966 To: aspotashev, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17065: Fix mem leak found with asan

mlaurent added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17065 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17065: Fix mem leak found with asan

mlaurent added a comment. Indeed a very good training "debugging and profiling" I fixed some potential other mem leak in kinfocenter/ark/libksysguard yesterday. Very useful indeed. REPOSITORY R241 KIO BRANCH fix_mem_leak (branched from master) REVISION DETAIL

D17065: Fix mem leak found with asan

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8fb6431784e2: Fix mem leak found with asan (authored by mlaurent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17065?vs=45928=45935 REVISION DETAIL

D17065: Fix mem leak found with asan

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Fix mem when I used dolphin #0 0x7fa8cd24d900 in operator new(unsigned long)

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

mlaurent created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Use QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default flags REPOSITORY R240 Extra

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

mlaurent added a reviewer: dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags

mlaurent added a comment. I fixed 2 repos. Otherwise all compiles fine (ok I don't test on windows/mac and perhaps some module is not compiles on my computer) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc:

D19934: [kded] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R297 KDED BRANCH

D19935: [KCMUTILS] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R295 KCMUtils

D19913: [plasma-desktop] make it compiles without foreach

mlaurent updated this revision to Diff 54920. mlaurent added a comment. Fix comment reported by Apol REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=54407=54920 BRANCH compile_without_foreach (branched from master) REVISION

D19875: [Kactivities-stats] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R159:5b969c5e6a55: [Kactivities-stats] compile without foreach (authored by mlaurent). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE

D19913: [plasma-desktop] make it compiles without foreach

mlaurent added a comment. Ping ?:) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19913 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19875: [Kactivities-stats] compile without foreach

mlaurent added a comment. Ping ?:) REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19875 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19318: compile without foreach

mlaurent added a comment. Fixed REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D19318 To: mlaurent, dfaure Cc: hindenburg, kde-frameworks-devel, michaelh, ngraham, bruns

D19929: [kparts] compile without foreacg

This revision was automatically updated to reflect the committed changes. Closed by commit R306:921f1f1fe09d: [kparts] compile without foreacg (authored by mlaurent). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19929?vs=54454=54478 REVISION DETAIL

D19929: [kparts] compile without foreacg

mlaurent added a comment. Argg I don't understand... I used 'git ci --amend' and it doesn't wotk when I used arc land... Sorry for your script... REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D19929 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh,

D19967: [kpeople] make it compile without foreach

mlaurent updated this revision to Diff 54749. mlaurent added a comment. Fix error reported by david REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19967?vs=54563=54749 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19930: [kwallets] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R311:0da6f73eddc0: [kwallets] compile without foreach (authored by mlaurent). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19930?vs=54455=54750 REVISION DETAIL

D19967: [kpeople] make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R307:5db114c9aad3: [kpeople] make it compile without foreach (authored by mlaurent). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19967?vs=54749=54766 REVISION

Re: CI system maintainability

Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit : > Hi Laurent, > > Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel: > > For example I works all days on kde (pim or other) when I wake up, or at > > noon after my lunch or the evening, I

Re: CI system maintainability

r work as we know that you are not really active on kde at the moment... For sure I broke kcontact 2 days ago, but as a friend told me when I started to work on kde "We can't create a bug when we don't code..." Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software

Re: CI system maintainability

Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit : > Thanks for reply. More below: > > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit : > > > Hi Laurent, > &

D20372: [kemoticons] make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R301:7b7476efb82a: [kemoticons] make it compile without foreach (authored by mlaurent). REPOSITORY R301 KEmoticons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20372?vs=55721=55722 REVISION

D20372: [kemoticons] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R301 KEmoticons

D20376: [ktextwidget] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R310 KTextWidgets

D20376: [ktextwidget] compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R310:b87f924aadf0: [ktextwidget] compile without foreach (authored by mlaurent). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20376?vs=55733=55734 REVISION

D19251: Make it compiles without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R243:ff2240350387: Make it compiles without foreach (authored by mlaurent). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19251?vs=52377=52426 REVISION DETAIL

D19251: Make it compiles without foreach

mlaurent added inline comments. INLINE COMMENTS > dfaure wrote in krcc.cpp:147 > move to temp var to avoid detaching? dir is const. Will it detach ? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D19251 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh,

D19319: make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R291 KPty BRANCH compile_without_foreach

D19317: compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R287 KImageFormats BRANCH

D19318: compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R274 KIdleTime BRANCH

D19271: Make it compiles without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R238:3fbec01f6f7c: Make it compiles without foreach (authored by mlaurent). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19271?vs=52435=52472 REVISION DETAIL

D19278: Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R279 ThreadWeaver BRANCH

D19285: Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R292 KUnitConversion BRANCH

D19271: Make it compiles without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R238 KDocTools

D19285: Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R292:6d3e49e94e98: Make it compile without foreach (authored by mlaurent). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19285?vs=52468=52473 REVISION DETAIL

D19278: Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R279:33bd17052e98: Make it compile without foreach (authored by mlaurent). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19278?vs=52452=52474 REVISION DETAIL

D19326: Compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R237 KConfig BRANCH

D19335: [kdoctools] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R238 KDocTools

D19336: [kguiaddons] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R273 KGuiAddons BRANCH

D19326: [Kconfig] Compile without foreach

mlaurent retitled this revision from "Compile without foreach" to "[Kconfig] Compile without foreach". REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19326 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19335: [kdoctools] make it compile without foreach

mlaurent added a comment. oops indeed. I landed it and forgot to git pull :) I will close it now :) REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19335 To: mlaurent, dfaure Cc: ltoscano, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham,

D19335: [kdoctools] make it compile without foreach

mlaurent abandoned this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19335 To: mlaurent, dfaure Cc: ltoscano, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19326: [Kconfig] Compile without foreach

mlaurent updated this revision to Diff 52808. mlaurent added a comment. Fixed code as requested by David REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19326?vs=52579=52808 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19326: [Kconfig] Compile without foreach

mlaurent edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19326 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19395: [KJobWidget] remove deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R288:07d140f5a206: [KJobWidget] remove deprecated method (authored by mlaurent). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19395?vs=52793=52801 REVISION

D19396: [kxmlgui] remove deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R263:8069268ceda6: [kxmlgui] remove deprecated method (authored by mlaurent). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19396?vs=52794=52802 REVISION DETAIL

D19387: Remove deprecated QSignalMapper

This revision was automatically updated to reflect the committed changes. Closed by commit R235:8856dfad857b: Remove deprecated QSignalMapper (authored by mlaurent). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19387?vs=52722=52735 REVISION DETAIL

D19387: Remove deprecated QSignalMapper

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY QSignalMapper is deprecated in Qt5 REPOSITORY R235 Attica BRANCH

D19418: Make it compiles without deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method TEST PLAN all autotest ok REPOSITORY R242

D19395: [KJobWidget] remove deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY remove deprecated method REPOSITORY R288 KJobWidgets BRANCH

D19396: [kxmlgui] remove deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY remove deprecated method REPOSITORY R263 KXmlGui BRANCH

D19418: Make it compiles without deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R242:9fc663d9f0ed: Make it compiles without deprecated method (authored by mlaurent). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D19317: compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R287:f1c6c15b061b: compile without foreach (authored by mlaurent). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19317?vs=52700=52863 REVISION DETAIL

D19430: Make it compile with QT_NO_CAST_FROM_ASCII

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile QT_NO_CAST_FROM_ASCII TEST PLAN autotests ok REPOSITORY R298

D19431: [kitemviews] make it compile without deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated methods TEST PLAN autotest ok REPOSITORY R276

D19436: [kservice] compile without deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method TEST PLAN autotest ok REPOSITORY R309

D19437: [knewstuff] Remove qt5.13 deprecated method

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY remove deprecated method TEST PLAN autotest ok REPOSITORY R304 KNewStuff

D19455: [knotification] compile without deprecated methods

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method TEST PLAN autotest ok REPOSITORY R289

D19442: [Kfilemetada] Make it compile without foreach

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R286:fcb1ec08bde9: [Kfilemetada] Make it compile without foreach (authored by mlaurent). REPOSITORY R286 KFileMetaData

D19503: Improve code: Remove temp container just to iterate

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Remove temp container TEST PLAN autotest ok REPOSITORY R283 KAuth BRANCH

D19298: Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R283:cd7490e85008: Make it compile without foreach (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19298?vs=52526=53097#toc REPOSITORY R283 KAuth CHANGES SINCE LAST

Re: Fwd: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still Failing!

Hi, I will investigate today. Regards Le vendredi 1 mars 2019, 20:09:54 CET Ben Cooksley a écrit : > Hi Laurent, > > > Thanks for taking a look - unfortunately it looks like this is still > failing? > > > Cheers, > Ben

D19436: [kservice] compile without deprecated method

mlaurent updated this revision to Diff 53011. mlaurent added a comment. Use toSecsSinceEpoch REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19436?vs=52878=53011 BRANCH compile_without_deprecated_method (branched from master) REVISION DETAIL

<    1   2   3   4   5   6   7   8   >