D23694: Add support for sshfs to the fstab backend

lbeltrame closed this revision. lbeltrame added a comment. https://invent.kde.org/frameworks/solid/commit/a41ce6a27eb07096356acb3e03ecf69e9ca0173d REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc:

D23694: Add support for sshfs to the fstab backend

lbeltrame added a comment. Any objections? Or I'll merge on Sunday evening UTC+1. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: elvisangelaccio, albertvaka, ngraham, kde-frameworks-devel, LeGast00n,

D23694: Add support for sshfs to the fstab backend

lbeltrame added a comment. @elvisangelaccio Thanks, first of all. If that's the case, do you think it's better to touch KIO first before landing this? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc:

D23694: Add support for sshfs to the fstab backend

lbeltrame added a comment. Would this change be needed on this side or kdeconnect side? I don't mind landing this, but I need formal approval by someone. (I won't have any time to do additional changes elsewhere). REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694

D27704: Drop FindAccountsFileDir.cmake

lbeltrame requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27704 To: nicolasfella, #frameworks, bshah, leinir, lbeltrame Cc: lbeltrame

D27704: Drop FindAccountsFileDir.cmake

lbeltrame reopened this revision. lbeltrame added a comment. This revision is now accepted and ready to land. "No one using it" is not correct. Or at least, `ACCOUNTS_SERVICES_DIR`, set in that file, is used by kaccounts-providers. I'll revert the change (breaks building other projects), but

D27633: Port to KPluginLoader

lbeltrame added a comment. This currently causes a compile error: /home/abuild/rpmbuild/BUILD/kaccounts-integration-20.03.70git.20200225T132248~74e770c/src/daemon/daemon.cpp:62:78: error: call of overloaded 'create(AccountsDaemon*, )' is ambiguous REPOSITORY R155 KAccounts

D27614: build: fix the build where install prefix is not user-writable

lbeltrame added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27614 To: bshah, ngraham, lbeltrame Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: 2 kirigami fixes for a point release

problem" for everything that's not KDE-made software, FTR, but that's not the issue I want to raise here) -- Luca Beltrame - KDE Forums team GPG key ID: A29D259B signature.asc Description: This is a digitally signed message part.

Re: 2 kirigami fixes for a point release

rticular because this failing is entirely upstream. We have already plenty in FOSS, I don't want KDE to be yet another community that "adopts" them. "We messed up so let's make things our way" is not an acceptable approach. -- Luca Beltrame - KDE Forums team GPG key ID:

D26394: ECMGeneratePriFile: Fix static configurations

lbeltrame added subscribers: cgiboudeaux, lbeltrame. lbeltrame added a comment. This breaks stuff in PIM: [ 107s] CMake Error at /usr/share/ECM/modules/ECMGeneratePriFile.cmake:183 (get_target_property): [ 107s] get_target_property() called with non-existent target "KF5AlarmCal".

D27141: Drop Policykit backend

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH no_policykit REVISION DETAIL https://phabricator.kde.org/D27141 To: davidedmundson, lbeltrame Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

lbeltrame added a reviewer: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26400 To: bport, ervin, crossi, meven, #plasma, bruns Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D26306: Define more documentation search paths (also custom)

lbeltrame added a comment. +1, would allow us to get rid of some downstream patches. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D26306 To: ltoscano Cc: cgiboudeaux, lbeltrame, rdieter, arojas, rikmills, maximilianocuria, asturmlechner, kde-frameworks-devel,

D25106: Also allow invoking session restoration logic when apps are manually launched

lbeltrame added a comment. Found also by openQA: two kontact windows get opened. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks, dfaure, vkrause Cc: lbeltrame, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24020: Support NetworkManager 1.20 and do actually compile the NM backend

lbeltrame added a comment. +1 REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D24020 To: arojas Cc: lbeltrame, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23694: Add support for sshfs to the fstab backend

lbeltrame added a comment. In D23694#524968 , @fvogt wrote: > `fuse.sshfs` is used by kdeconnect as well, does that cause some kind of conflict? I can't test this in the current network (no office wifi, broadcast blocked at all levels).

D23694: Add support for sshfs to the fstab backend

lbeltrame created this revision. lbeltrame added reviewers: bruns, broulik, fvogt. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. lbeltrame requested review of this revision. REVISION SUMMARY This commit introduces support for sshfs as network filesystem.

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

lbeltrame accepted this revision. lbeltrame added a comment. Not the prettiest, but I've seen worse. ;) REPOSITORY R264 KApiDox BRANCH handlenonasciipathwpython27 REVISION DETAIL https://phabricator.kde.org/D22836 To: kossebau, ochurlaud, bshah, aacid, lbeltrame Cc: lbeltrame,

D21002: Remove kde4 migration agent completely

lbeltrame closed this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid Cc: siddharthasahu, aacid, lbeltrame, kde-frameworks-devel, damjang, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21002: Remove kde4 migration agent completely

lbeltrame added a comment. Should be fixed with ff6b077d9200856dc6e393a04c6b3ae82d9792ed . REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid

D21002: Remove kde4 migration agent completely

lbeltrame reopened this revision. lbeltrame added a comment. This revision is now accepted and ready to land. This breaks GPG wallets completely. They are no longer accounted for by kwalletd: reverting this change makes them work again. REPOSITORY R311 KWallet REVISION DETAIL

D22339: Make sure solid backends are reentrant

lbeltrame added a comment. Why was this committed when changes were requested? Wasn't that the whole point of having reviews? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22339 To: apol, #frameworks, davidedmundson, bruns Cc: lbeltrame, bruns,

D21004: [UserMetaData] Shortcut attribute queries for the common case

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R824 Baloo Widgets BRANCH bulk_query REVISION DETAIL https://phabricator.kde.org/D21004 To: bruns, #baloo, #frameworks, ngraham, astippich, lbeltrame Cc: domson, ashaposhnikov, astippich,

D21002: Remove kde4 migration agent completely

lbeltrame added a comment. +1 REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: lbeltrame, kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

lbeltrame removed a subscriber: cgiboudeaux. lbeltrame added a reviewer: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

lbeltrame added a subscriber: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D20659: Detach container in Component::cleanUp before interating

lbeltrame added a comment. I confirm there are no more issues in valgrind after adding this patch. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D20659: Detach container in Component::cleanUp before interating

lbeltrame added a reviewer: Frameworks. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20594: Fix MobileTextSelection namespacing

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20594 To: broulik, #plasma, mart, hein, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

lbeltrame added reviewers: apol, vkrause. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20509 To: sh-zam, apol, vkrause Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

lbeltrame added a comment. +1. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20465 To: broulik, #frameworks, dfaure, lbeltrame Cc: ngraham, kde-frameworks-devel, michaelh, bruns

Re: CI system maintainability

I usually don't subscribe to failure notifications (almost 300 packages is overkill) but a bot starts pestering me with mails the moment build failures go unfixed (granted, the time scale is different). For the first, I'd like people more involved in the development to say their word. -- Luca Belt

Re: CI system maintainability

or on the anarchist side. I just want to make sure we don't engage in policies that can be (potentially, just potentially) harmful for some parts of KDE (while they are perfectly OK for others). -- Luca Beltrame GPG key ID: A29D259B signature.asc Description: This is a digitally signed message part.

Re: CI system maintainability

but I've seen other communities (many, many years ago) where a "semi anarchy" replaced by "iron-gripped rules" from one day to another actually killed them. -- Luca Beltrame GPG key ID: A29D259B signature.asc Description: This is a digitally signed message part.

Re: CI system maintainability

sitories managed by different groups. Some are very used to reviews, others not (and not necessarily PIM). Hence the (even debatable, if you may) proposal. -- Luca Beltrame GPG key ID: A29D259B signature.asc Description: This is a digitally signed message part.

Re: CI system maintainability

Pre-commit CI (i.e. once the switch to GitLab occurs) and perhaps direct mailing to the user (as I suggested earlier) in case of continuous failures will also help. If this thing works, one can gradually ramp up the requirements of things that go through review when the "muscle memory" is f

Re: CI system maintainability

I can't speak for seasoned developers, but I've found myself in a situation (more than once) where the fix is trivial (compile error, missing ";", etc) and being forced to go through review would (IMO) unnecessarily raise friction. -- Luca Beltrame GPG key ID: A29D259B s

D19698: Remove crash in plasmashell

lbeltrame added reviewers: Frameworks, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19698 To: mlaurent, dfaure, #frameworks, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19108: [ExternalExtractor] Provide more helpful output when extractor fails

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. LGTM!. Annoyed me for a long time (and made hard to debug some issues). INLINE COMMENTS > externalextractor.cpp:120 > extractorProcess.start(d->mainPath, QStringList(),

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

lbeltrame added reviewers: dhaumann, cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

lbeltrame added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18845: authority: add support for passing details to polkit

lbeltrame added a reviewer: Frameworks. lbeltrame added a subscriber: kde-frameworks-devel. REPOSITORY R563 Polkit-1 Qt Library REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks Cc: kde-frameworks-devel

D18952: new find module for Canberra

lbeltrame added a reviewer: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18947: Bring FindUDev.cmake up to ECM standards

lbeltrame added a reviewer: cgiboudeaux. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D18947 To: vkrause, #build_system, cgiboudeaux Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18941: Fix build with cmake 3.5

lbeltrame added a reviewer: bruns. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18941 To: wbauer, #build_system, cgiboudeaux, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18941: Fix build with cmake 3.5

lbeltrame added reviewers: Build System, cgiboudeaux. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18941 To: wbauer, #build_system, cgiboudeaux Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

lbeltrame added a comment. Can you expand a bit the description? I understand you are fixing problems, but why the problems are there and what you are doing exactly. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D18574 To: fvogt, aacid Cc: lbeltrame,

D18527: List Android as officially supported

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D18527 To: vkrause, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18424: Instantiate QApplication before KCrash/KCatalog

lbeltrame added reviewers: bruns, poboiko. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18424 To: sdepiets, #baloo, bruns, poboiko Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18345: Fix python binding generation for classes with deleted copy constructors

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. As far as I understand the logic of the whole thing, it looks sane. At some point we ought to find a way to properly test that the generated code... REPOSITORY R240 Extra CMake

D17863: Add ecm_check_linker_flags function

lbeltrame added a reviewer: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17863 To: tcberner, #freebsd, dfaure, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17650: Install kioslave.exe as kioslave5.exe under Windows

lbeltrame added a comment. I would still suggest you get your stuff done with the binary factory and not on the OBS simply because then KDE as a whole can benefit from it. Not doing so will make sure that Windows and other platform-specific issues will never be found. REPOSITORY R241 KIO

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a comment. In D17650#380243 , @habacker wrote: > > $ rpm -q -f /usr/i686-w64-mingw32/sys-root/mingw/bin/kioslave.exe > mingw32-kdelibs4-4.14.60-30.27.noarch > $ rpm -q -f

D17331: Extend PositionCodec unit tests, better code coverage

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17331 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko, lbeltrame Cc: kde-frameworks-devel, ashaposhnikov,

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a comment. In D17650#379423 , @heikobecker wrote: > In D17650#379396 , @habacker wrote: > > > I think this is unrelated - this request is to fix an issue with an available package

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a comment. In D17650#378765 , @habacker wrote: > On a recent opensuse Leap 42.3 or 15.x system there is > > > /usr/lib64/kde4/libexec/kioslave > > /usr/lib64/libexec/kf5/kioslave As a packager of KDE software for

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a reviewer: vonreth. lbeltrame added a comment. That said, let's hear the opinion of someone else as well. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker, #frameworks, lbeltrame, vonreth Cc: lbeltrame, kde-frameworks-devel, michaelh,

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a comment. > umbrello from binary factory is far from been production ready. Windows releases are made from the KDE4 branch. See for example https://phabricator.kde.org/T7659 I would argue this is more of umbrello's problem to keep on supporting kdelibs 4.x and KF5 at

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a reviewer: Frameworks. lbeltrame requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker, #frameworks, lbeltrame Cc: lbeltrame, kde-frameworks-devel, michaelh,

D17650: Install kioslave as kioslave5 on Windows

lbeltrame added a comment. At this point, I'd rather give my -1 to this. The 4.x kdelibs stack is *long* unmaintained, as well as Qt. What are real, **compelling** reasons to do this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17650 To: habacker Cc: lbeltrame,

D17090: Use append instead of operator+= when appending to an QVector

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17090 To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. LGTM; just a minor change needed. INLINE COMMENTS > basicindexingjob.cpp:153 > +//{"application/vnd.ms-excel", Type::Document}, > +//{"application/vnd.ms-excel",

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH extractor REVISION DETAIL https://phabricator.kde.org/D16523 To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov,

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

lbeltrame added a comment. +1. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D16305 To: fvogt, #frameworks Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D16524: [Extractor] Use QDataStream serialization in place of cooked one

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH extractor REVISION DETAIL https://phabricator.kde.org/D16524 To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

lbeltrame added a comment. In general (for my limited Baloo knowledge) this makes sense. You might want to add a few CCBUGs if you are aware of specific bugs this alleviates (@ngraham or someone from the bugsquad may help). REPOSITORY R293 Baloo REVISION DETAIL

D16505: [KFileMetaData] Replace QDir::separator() with '/' in unit tests

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH qdir_separator REVISION DETAIL https://phabricator.kde.org/D16505 To: bruns, #frameworks, #baloo, lbeltrame Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D16490: [KFileMetaData] Add unittest for XML extractor

lbeltrame added a comment. Generally looks OK to me, one note on `QDir::separator()` usage. INLINE COMMENTS > xmlextractortest.cpp:38 > +{ > +return QLatin1String(INDEXER_TESTS_SAMPLE_FILES_PATH) + > QDir::separator() + fileName; > +} IIRC you shouldn't use `QDir::separator()`. See

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH indexer_cleanup REVISION DETAIL https://phabricator.kde.org/D16255 To: bruns, #baloo, #frameworks, poboiko, ngraham, lbeltrame Cc: lbeltrame, kde-frameworks-devel,

D16265: [Scheduler] Use flag to track when a runner is going idle

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. The changes look sane to me. Perhaps wait a couple more days until any other objection is raised, then if not, commit away. REPOSITORY R293 Baloo REVISION DETAIL

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

lbeltrame added a comment. +1, but I'd like to hear people more experienced than me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16311 To: broulik, #frameworks, dfaure, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

lbeltrame added a comment. +1, looks fine to me as far as I understand. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16255 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Looks OK to me. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15867 To: bruns, #frameworks, apol, lbeltrame Cc: lbeltrame,

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

lbeltrame added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15426 To: fvogt, #frameworks, elvisangelaccio, dfaure Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15068: Bindings: Correct handling of sources containing utf-8

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. LGTM. INLINE COMMENTS > sip_generator.py:752 > # > -return "".join(extract).replace("\n", " ") > +return b''.join(extract).decode('utf-8').replace("\r\n", "

D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1

lbeltrame added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15113 To: fvogt, #frameworks Cc: lbeltrame

D14395: [KSambaShare] Check file that's changed before reloading

lbeltrame added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14395 To: broulik, #frameworks, dfaure Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D12233: Avoid manipulation of lists with quadratic complexity

lbeltrame added a reviewer: mgallien. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh, mgallien Cc: dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D13641: [KCharSelect] Port generate-datafile.py to Python 3

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. I did an accept to undo my earlier "Changes required" because Phab messed up the lines I commented on, and because I realized I wasn't commenting on your specific changes. Sorry

D13641: [KCharSelect] Port generate-datafile.py to Python 3

lbeltrame requested changes to this revision. lbeltrame added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcharselect-generate-datafile.py:41 Perhaps the diff view is wrong.. but the `return size` here (at this level of nesting) wouldn't make the

D13641: [KCharSelect] Port generate-datafile.py to Python 3

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13641 To: cfeck, #frameworks, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12696: Use the new uds implementation

lbeltrame added a comment. I wonder if this is related to timeline:/ no longer working properly in the file dialog. (didn't investigate yet). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #frameworks Cc: lbeltrame, asturmlechner,

D11925: Add "SkipSwitcher" to API

lbeltrame added a comment. For now I reverted the commit in kwin to allow building. Once this review is merged, it can be re-instated. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: lbeltrame, rikmills, davidedmundson,

D11925: Add "SkipSwitcher" to API

lbeltrame added a comment. Observed this on the openSUSE OBS as well. Please fix the compilation issue or revert. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: lbeltrame, rikmills, davidedmundson, #plasma, graesslin,

D12424: Install pri file for qmake support & document it in metainfo.yaml

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH installprifile REVISION DETAIL https://phabricator.kde.org/D12424 To: kossebau, #build_system, lbeltrame Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun,

D12423: Install pri file for qmake support & document it in metainfo.yaml

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH installprifile REVISION DETAIL https://phabricator.kde.org/D12423 To: kossebau, #build_system, lbeltrame Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D11330: Remove shebangs from non-executable files

This revision was automatically updated to reflect the committed changes. Closed by commit R264:642fd8a06fca: Remove shebangs from non-executable files (authored by lbeltrame). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11330?vs=29501=29539 REVISION

D11315: Look first for qhelpgenerator-qt5 for help generation

This revision was automatically updated to reflect the committed changes. Closed by commit R264:27a1126b1d79: Look first for qhelpgenerator-qt5 for help generation (authored by lbeltrame). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11315?vs=29468=29538

D11330: Remove shebangs from non-executable files

lbeltrame created this revision. lbeltrame added reviewers: Frameworks, ochurlaud. Restricted Application added projects: Frameworks, Documentation. Restricted Application added a subscriber: Documentation. lbeltrame requested review of this revision. REVISION SUMMARY These files are meant to

D10366: cmake: don't flag libnm-util as found when ModemManager is found

This revision was automatically updated to reflect the committed changes. Closed by commit R281:d3c573483257: cmake: dont flag libnm-util as found when ModemManager is found (authored by aleksanderm, committed by lbeltrame). REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE

D11315: Look first for qhelpgenerator-qt5 for help generation

lbeltrame created this revision. lbeltrame added reviewers: Frameworks, ochurlaud. Restricted Application added projects: Frameworks, Documentation. Restricted Application added a subscriber: Documentation. lbeltrame requested review of this revision. REVISION SUMMARY A number of distributions

D10824: Delete IdleSlave having temporary authorization

lbeltrame added a reviewer: Frameworks. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D10824 To: chinmoyr, dfaure, #frameworks Cc: #frameworks, michaelh

D10273: Create proper SocketAddress

lbeltrame added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10273 To: chinmoyr, #frameworks, dfaure Cc: ossi, thiago, dfaure, michaelh

D10764: [AppletQuickItem] Preload applet expander only if not already expanded

lbeltrame added a comment. +1 from me, fixes the issue I had. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10764 To: broulik, #plasma, mart, lbeltrame Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10661: indexerconfig: Expose canBeSearched function

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. For what it's worth, LGTM . REPOSITORY R293 Baloo BRANCH expose_canbesearched (branched from master) REVISION DETAIL https://phabricator.kde.org/D10661 To: michaelh, #baloo,

D10662: indexerconfig: Describe some functions

lbeltrame added inline comments. INLINE COMMENTS > fileindexerconfig.h:25 > +#include > +#include > I just noticed this. Can you do the #include changes as part of a separate commit? REPOSITORY R293 Baloo BRANCH publicdescriptions (branched from master) REVISION DETAIL

D10662: indexerconfig: Describe some functions

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Looks OK to me with some changes (for readability). INLINE COMMENTS > fileindexerconfig.h:50 > /** > - * The folders to search for files to analyze. Cached and cleaned up. >

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

lbeltrame added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Ping? Why this has not been committed even if in "accepted" state? REPOSITORY R127 KWayland BRANCH subsurface-parent-destroyed REVISION DETAIL https://phabricator.kde.org/D10300

D9989: baloo-tools: Make all output messages translatable

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH translate-all (branched from master) REVISION DETAIL https://phabricator.kde.org/D9989 To: michaelh, smithjd, #frameworks, vhanda, lueck, lbeltrame Cc: ngraham

  1   2   3   >