Re: Review Request 116116: Fix build with Qt 5.3

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116116/#review51335 --- Ship it! Ship It! - Lukáš Tinkl On Feb. 27, 2014, 1:25

Re: Review Request 119349: typo in signal names ( upowermanager )

/Removed signals... how did you come to this conclusion? Have you done any testing? - Lukáš Tinkl On Čec. 18, 2014, 7:31 dop., Ömer Fadıl Usta wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 119512: Fix saving/loading of file dialog sizes

/119512/diff/ Testing --- Current Plasma 5, working fine :) Thanks, Lukáš Tinkl ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119512: Fix saving/loading of file dialog sizes

(unless the compositor keeps it open for other reasons) Lukáš Tinkl wrote: The KDirSelectDialog does the same, hence why I reused it. QPlatformDialogHelper has an abstract method hide(), I just moved the implementation up one level to the native QDialog - Lukáš

Re: Review Request 119510: Fix untranslated menu entries

workspace/desktop File Attachments translated systemsettings https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/6989a707-ab72-46f0-8d3d-c61edd969e43__systemsettings.png Thanks, Lukáš Tinkl ___ Kde-frameworks-devel mailing

Re: Review Request 119510: Fix untranslated menu entries

., Lukáš Tinkl wrote: +1, makes sense to me. I'd like a from one of our l10n gurus too. ;) Fine, here's a +1 from me ;p - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119510

Re: Review Request 119510: Fix untranslated menu entries

--- On Čec. 28, 2014, 4:28 odp., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119510/ --- (Updated Čec

Re: Review Request 119512: Fix saving/loading of file dialog sizes

On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: If the only issue is the open ::exec() TODO, you might trick it by calling ::winId(), then restore the size and ultimately ::exec() Otherwise you could open an own nested eventloop instead of relying on the dialogs exec, but that'd

Re: Review Request 119510: Fix untranslated menu entries

KGlobal::locale(); +2 to removing that completely. Lukáš Tinkl wrote: Here it returns just the language (cs), although the docu says: Returns the dash-separated language, script and country (and possibly other BCP47 fields) of this locale as a string. Anyway I don't

Re: Review Request 119512: Fix saving/loading of file dialog sizes

On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: If the only issue is the open ::exec() TODO, you might trick it by calling ::winId(), then restore the size and ultimately ::exec() Otherwise you could open an own nested eventloop instead of relying on the dialogs exec, but that'd

Re: Review Request 119512: Fix saving/loading of file dialog sizes

On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: If the only issue is the open ::exec() TODO, you might trick it by calling ::winId(), then restore the size and ultimately ::exec() Otherwise you could open an own nested eventloop instead of relying on the dialogs exec, but that'd

Re: Review Request 119540: don't construct bogus KAuthAction objects

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119540/#review63630 --- Ship it! Ship It! - Lukáš Tinkl On Čec. 30, 2014, 2:32

Re: Review Request 119562: Load polkit backends from installed location.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119562/#review63631 --- Ship it! Ship It! - Lukáš Tinkl On Srp. 1, 2014, 3:59 odp

Re: Review Request 119512: Fix saving/loading of file dialog sizes

On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: If the only issue is the open ::exec() TODO, you might trick it by calling ::winId(), then restore the size and ultimately ::exec() Otherwise you could open an own nested eventloop instead of relying on the dialogs exec, but that'd

Re: Review Request 119577: Allow translations to have context again.

://bugreports.qt-project.org/browse/QTBUG-40444 , otherwise thanks for the fix! - Lukáš Tinkl On Srp. 2, 2014, 7:07 odp., Matthew Dawson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 119512: Fix saving/loading of file dialog sizes

5a8e758 Diff: https://git.reviewboard.kde.org/r/119512/diff/ Testing --- Current Plasma 5, working fine :) Thanks, Lukáš Tinkl ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

geometry. - Lukáš Tinkl On Srp. 3, 2014, 9:16 odp., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

On Srp. 4, 2014, 1:13 dop., Lukáš Tinkl wrote: No change here, ie. it doesn't restore the file dialog geometry. Thomas Lübking wrote: what is your precise testcase? a bit remote because of your other patches: did you check that the correct platformtheme lib is used? (ran

Re: Review Request 119594: fix FileDialog size restorage

://git.reviewboard.kde.org/r/119593/ - Lukáš Tinkl On Srp. 4, 2014, 1:57 odp., Thomas Lübking wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594

Re: Review Request 119593: Ensure there's a plastform window before restoring the window geometry

On Srp. 4, 2014, 1:13 dop., Lukáš Tinkl wrote: No change here, ie. it doesn't restore the window geometry. Martin Klapetek wrote: Same here, Qt 5.3.1. Thomas, which Qt are you using? Nevertheless, as your knowledge about windows stuff is much better and if you think

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

/lib64/libexec/kf5/start_kdeinit“: Directory or file doesn't exist - Lukáš Tinkl On Srp. 11, 2014, 2:30 odp., Nicolas Lécureuil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

:) - Lukáš Tinkl On Srp. 11, 2014, 4:22 odp., Nicolas Lécureuil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/#review64290 --- Ship it! Ship It! - Lukáš Tinkl On Srp. 11, 2014, 7:51

Re: Review Request 120040: Install kdesu under bin

/120040/#comment45938 The comment should probably also say kdesu5 I'm a bit worried by the multitude of user and distro specific scripts that rely on kdesu being present :/ - Lukáš Tinkl On Zář. 2, 2014, 8:27 odp., Marco Martin wrote

Re: Review Request 120078: workaround QTBUG-40584

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120078/#review65919 --- Ship it! \o/ - Lukáš Tinkl On Zář. 6, 2014, 3:43 odp

Re: Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120519/#review68091 --- Ship it! Seems sensible to me - Lukáš Tinkl On Říj. 7

Re: Review Request 120599: Properly construct QUrl for a temporary file which will be copied as a new file or edited

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120599/#review68451 --- Ship it! Ship It! - Lukáš Tinkl On Říj. 15, 2014, 3:02

Re: Review Request 120606: Properly parse URL in KUrlNavigator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120606/#review68552 --- Tested, works fine - Lukáš Tinkl On Říj. 16, 2014, 3:56

Re: Review Request 120728: Install public header for KNotifyPlugin

On Říj. 23, 2014, 1:12 dop., Aleix Pol Gonzalez wrote: You can rename it AFAIU. Given that no external project has seen the header file, nobody is linking against it (if they don't copy the header over, which is not supported, of course). Martin Klapetek wrote: My thinking is

Re: Review Request 120917: Fix memory leak for NETWinInfoPrivate::client_machine

=339902 Gonna test later, thanks for taking care of this! - Lukáš Tinkl On Říj. 31, 2014, 2:29 odp., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120917

Re: Review Request 121007: Fix warning when using newer upower backend.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/#review69984 --- Ship it! Ship It! - Lukáš Tinkl On Lis. 7, 2014, 1:20 odp

Re: Review Request 121007: Fix warning when using newer upower backend.

with an older UPower, I'd see `DeviceAdded(QString)` etc. Can someone with an older UPower test this and make sure? Milian Wolff wrote: Put differently: @Lukáš Tinkl: What did you try before, and why did you think it would fail this way? I didn't say it would fail, I just didn't see

Re: Review Request 122082: Rename jpegcreatorsettings to jpegcreatorsettings5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122082/#review74114 --- Ship it! Ship It! - Lukáš Tinkl On Led. 16, 2015, 1:49

Re: Review Request 121885: Properly check for systray being available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121885/#review74017 --- Ship it! Ship It! - Lukáš Tinkl On Led. 14, 2015, 4:13

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

://git.reviewboard.kde.org/r/122554/#comment52538 whether - Lukáš Tinkl On Úno. 13, 2015, 8:42 odp., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554

Re: Review Request 122293: Use activate on single click setting from QPlatformTheme rather than duplicating it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122293/#review74933 --- Ship it! Ship It! - Lukáš Tinkl On Led. 28, 2015, 6:26

Re: Review Request 122978: Add unit test for crash of bug 343976

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122978/#review77578 --- +1 from me - Lukáš Tinkl On Bře. 16, 2015, 1:04 odp

Re: Review Request 122590: Guard kglobalaccel against QApplication

On Bře. 5, 2015, 4:44 odp., Lukáš Tinkl wrote: For posterity, does this still work with khotkeys? Martin Gräßlin wrote: why should it not work with khotkeys? Or better said: what should be so special about khotkeys? Nothing in particular, I was just wondering - Lukáš

Re: Review Request 123131: Port kio_man away from kdelibs4support

/123131/#comment53475 Not correct, this returns only user configured list of languages, whereas it previously returned the full list. - Lukáš Tinkl On Bře. 25, 2015, 10:17 odp., Alex Richardson wrote: --- This is an automatically

Re: Review Request 122590: Guard kglobalaccel against QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review77063 --- For posterity, does this still work with khotkeys? - Lukáš

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

5.4 and they worked fine - Lukáš Tinkl On Dub. 11, 2015, 8:34 odp., David Rosca wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335

Re: Review Request 121446: Ignore child mtp devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121446/#review82360 --- Ship it! Ship It! - Lukáš Tinkl On Pro. 11, 2014, 2:05

D5503: No "KDE Daemon" in password dialogs

lukas created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Do not append non-translatable text "KDE Daemon" to the password dialog window title. This is done automatically by the xcb QPA plugin here:

D5503: No "KDE Daemon" in password dialogs

lukas added a comment. In action: F3729023: dialog-kded1.png before F3729025: dialog-kded2.png after REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D5503 To: lukas, #frameworks