D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven updated this revision to Diff 73260. meven marked an inline comment as done. meven added a comment. And KMountPoint::List::findByPathDirectly to check mount point without resolving symlinks REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

meven accepted this revision. meven added a comment. That seems good to me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26082 To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik, meven Cc: plasma-devel, meven, bport, LeGast00n,

D26564: Clean kbuildsycoca4 support

meven created this revision. meven added reviewers: ervin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26564

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven updated this revision to Diff 73182. meven added a comment. Clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26557?vs=73181=73182 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26557 AFFECTED FILES

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven updated this revision to Diff 73181. meven added a comment. Fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26557?vs=73179=73181 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26557 AFFECTED FILES src/core/desktopexecparser.cpp

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26557 To: meven, ervin, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven created this revision. meven added reviewers: ervin, ngraham, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The Terminal field in .desktop file was not taken into account as the

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26557 To: meven, ervin, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26519: Show button respecting what is declared by KCModule

meven added inline comments. INLINE COMMENTS > kcmultidialog.cpp:217 > +helpButton->setVisible(buttons & KCModule::Help); > helpButton->setEnabled(activeModule->buttons() & KCModule::Help); > } You can remove this line I think : no need to disable a hidden

D26517: Fix KCMModule::setButtons documentation, if Apply is activated we also want to show a Reset button

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26517 To: bport, ervin, meven, crossi, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26488: smb ioslave: fix build regression

This revision was automatically updated to reflect the committed changes. Closed by commit R320:b2ad75170084: smb ioslave: fix build regression (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26488?vs=72960=73005 REVISION DETAIL

D26496: Log categories: fix format adding DEFAULT_SEVERITY

meven abandoned this revision. meven added a comment. Thanks @mlaurent I just have old files installed on my system and got confused, I thought DEFAULT_SEVERITY was mandatory. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26496 To: meven, #frameworks, mlaurent Cc:

D26496: Log categories: fix format adding DEFAULT_SEVERITY

meven created this revision. meven added reviewers: Frameworks, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Prevents warning when launching kdebugsettings such as:

D26488: smb ioslave: fix build regression

meven added a reviewer: mlaurent. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26488 To: meven, #frameworks, mlaurent Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D26488: smb ioslave: fix build regression

meven created this revision. meven added a reviewer: Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Regression was introduced in D26420

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26466 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven added inline comments. INLINE COMMENTS > dfaure wrote in jobtest.cpp:2045 > The alternative is to export an env var that makes the ioslave call some > msleep()... Making an ioslave reading an env var for testing purposes is not a great alternative. REPOSITORY R241 KIO REVISION

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

meven added inline comments. INLINE COMMENTS > dhaumann wrote in kdiroperator.h:428 > Imho the API documentation should be improved (I am aware it was copied). > > Returns a map of all available actions. The action map remains unchanged > throughout the entire lifetime of the diroperator

D26415: Ensure to store resource uri without a trailing slash

This revision was automatically updated to reflect the committed changes. Closed by commit R6:409a2c0a4680: Ensure to store resource uri without a trailing slash (authored by meven). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26415?vs=72734=72931

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven added a comment. There is still an issue with the tests : It won't pass in wondws. So I am thinking duplicating the test `JobTest::cancelCopyAndCleanDest` and using an #ifdef to circumvent windows limitations. REPOSITORY R241 KIO REVISION DETAIL

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven marked an inline comment as done. meven added a comment. Thanks for the suggestion @dfaure INLINE COMMENTS > jobtest.cpp:2045 > f.close(); > -QCOMPARE(f.size(), 1000); //~10MB > +QCOMPARE(f.size(), 5); //~500MB to make sure copy is not too > fast, or the tests

D17596: [KDirOperator] Allow renaming files from the context menu

meven added a comment. D17595 just landed, just tested this patch REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks, #dolphin, meven Cc: meven, cfeck, emateli, elvisangelaccio, markuss, dhaumann,

D17595: Upstream Dolphin's file rename dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3f5341d3d7e2: Upstream Dolphins file rename dialog (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=72882=72922 REVISION DETAIL

D17595: Upstream Dolphin's file rename dialog

meven added a comment. last days for last minute review @dfaure REPOSITORY R241 KIO BRANCH arcpatch-D17595_2 REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure, elvisangelaccio Cc: elvisangelaccio, lydia, dfaure, sitter,

D26420: Add a logging category to smb ioslave

meven updated this revision to Diff 72901. meven added a comment. rebase REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26420?vs=72749=72901 BRANCH arcpatch-D26420_2 REVISION DETAIL https://phabricator.kde.org/D26420 AFFECTED FILES

D26420: Add a logging category to smb ioslave

This revision was automatically updated to reflect the committed changes. Closed by commit R320:1360c1f0e224: Add a logging category to smb ioslave (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26420?vs=72901=72902 REVISION DETAIL

D26358: KIO/SMB convert kio protocol declaration to json format

This revision was automatically updated to reflect the committed changes. Closed by commit R320:0354fd11f1f0: KIO/SMB convert kio protocol declaration to json format (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26358?vs=72743=72900

D17596: [KDirOperator] Allow renaming files from the context menu

meven accepted this revision as: meven. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks, #dolphin, meven Cc: meven, cfeck, emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26470: [Solid] Port QRegExp to QRegularExpression

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me REPOSITORY R245 Solid BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26470 To: ahmadsamir, #frameworks, dfaure,

D26468: Tests: don't build benchmark test by default

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Benchmark can have a long execution and have little interest for day-day tests. TEST

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. Apart from @since version, seems fine to me INLINE COMMENTS > kpluginselector.h:234 > + * Emitted after configuration is changed, tell if configuration > represent default or

D17596: [KDirOperator] Allow renaming files from the context menu

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. Don't forget to amend commit message (I have update the FIXED-IN: value). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks,

D17596: [KDirOperator] Allow renaming files from the context menu

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks, #dolphin Cc: meven, cfeck, emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17596: [KDirOperator] Allow renaming files from the context menu

meven added inline comments. INLINE COMMENTS > kdiroperator.h:800 > + * prompting the user to choose a new name(s) for the currently selected > items > + * @since 5.56 > + */ Update to @since 5.67 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To:

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 72882. meven added a comment. Update Copyright year REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=72881=72882 BRANCH arcpatch-D17595_2 REVISION DETAIL https://phabricator.kde.org/D17595 AFFECTED FILES

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 72881. meven marked 2 inline comments as done. meven added a comment. Rebase, amend, update @since, fix typo in TODO KF6 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=70224=72881 BRANCH arcpatch-D17595_2

D17595: Upstream Dolphin's file rename dialog

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D17595_1 REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure Cc: elvisangelaccio, lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven,

D26416: Kicker/Documents optimization: Lazily build KFileItem

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1640e9f46ef6: Kicker/Documents optimization: Lazily build KFileItem (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26415: Ensure to store resource uri without a trailing slash

meven added a comment. In D26415#588501 , @ivan wrote: > TBH, I'd like more to have dirs always end with a slash, but I guess this is fine as well. The sqlite database is not used direcly by users so we don't need to have a denominator

D25682: [WIP] add initial wsdiscovery support

meven added a comment. A few qDebug not to forget to clean before merging. INLINE COMMENTS > kio_smb_browse.cpp:380 > > + > udsentry.fastInsert( KIO::UDSEntry::UDS_NAME, udsName ); remove > kio_smb_browse.cpp:544 > if (dir_is_root) { > + qDebug() << "dir is

D26449: [PoC] Port to KRecentFileMenu

meven added inline comments. INLINE COMMENTS > mainwindow.h:67 > KParts::ReadWritePart *m_part; > -KRecentFilesAction*m_recentFilesAction; > QAction *m_openAction; Rename the variable as well ? REPOSITORY R36 Ark REVISION DETAIL

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven updated this revision to Diff 72832. meven added a comment. Use QTRY_VERIFY instead of sleep + Q_VERIFY REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=72798=72832 BRANCH arcpatch-D25117_1 REVISION DETAIL https://phabricator.kde.org/D25117

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven updated this revision to Diff 72798. meven added a comment. Stabilise test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=72729=72798 BRANCH arcpatch-D25117_1 REVISION DETAIL https://phabricator.kde.org/D25117 AFFECTED FILES

D26415: Ensure to store resource uri without a trailing slash

meven edited the summary of this revision. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D26415 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26416: Kicker/Documents optimization: Lazily build KFileItem

meven added a reviewer: apol. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26416 To: meven, #frameworks, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven added inline comments. INLINE COMMENTS > broulik wrote in kfileitem.cpp:783 > > when a network mount is unresponsive > > If I do a `QFileInfo` on an unresponsive mount it will still block. You > already freeze before you even know it's a network mount. Good point, indeed the current

D26416: Kicker/Documents optimization: Lazily build KFileItem

meven updated this revision to Diff 72761. meven added a comment. Remove outdate ifdef, we depend on KF5 5.62 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26416?vs=72735=72761 BRANCH arcpatch-D26416 REVISION DETAIL

D26416: Kicker/Documents optimization: Lazily build KFileItem

meven marked an inline comment as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26416 To: meven, #frameworks Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D26358: KIO/SMB convert kio protocol declaration to json format

meven added a comment. In D26358#587596 , @ngraham wrote: > BTW this does not fix https://bugs.kde.org/show_bug.cgi?id=414482 for me. :( I mistested this, and removed the "BUG: 414482" accordingly. I don't reproduce this bug locally

D26420: Add a logging category to smb ioslave

meven updated this revision to Diff 72749. meven added a comment. indent & "" REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26420?vs=72747=72749 BRANCH arcpatch-D26358 REVISION DETAIL https://phabricator.kde.org/D26420 AFFECTED FILES

D26420: Add a logging category to smb ioslave

meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26420 To: meven, #frameworks, mlaurent Cc: mlaurent, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D26420: Add a logging category to smb ioslave

meven updated this revision to Diff 72747. meven added a comment. Clean REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26420?vs=72746=72747 BRANCH arcpatch-D26358 REVISION DETAIL https://phabricator.kde.org/D26420 AFFECTED FILES

D26420: Add a logging category to smb ioslave

meven created this revision. meven added a reviewer: Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REPOSITORY R320 KIO Extras BRANCH arcpatch-D26358 REVISION DETAIL

D26358: KIO/SMB convert kio protocol declaration to json format

meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D26358: KIO/SMB convert kio protocol declaration to json format

meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: pino, apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D26358: KIO/SMB convert kio protocol declaration to json format

meven updated this revision to Diff 72743. meven added a comment. Update commit message REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26358?vs=72742=72743 BRANCH arcpatch-D26358 REVISION DETAIL https://phabricator.kde.org/D26358 AFFECTED FILES

D26358: KIO/SMB convert kio protocol declaration to json format

meven added a comment. I have tested it and it solves https://bugs.kde.org/show_bug.cgi?id=414482 It seems .protocol file support has some issue. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: pino, apol,

D26358: KIO/SMB convert kio protocol declaration to json format

meven updated this revision to Diff 72742. meven marked 4 inline comments as done. meven added a comment. Fix json REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26358?vs=72596=72742 BRANCH arcpatch-D26358 REVISION DETAIL

D26358: KIO/SMB convert kio protocol declaration to json format

meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: pino, apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D26358: KIO/SMB convert kio protocol declaration to json format

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > apol wrote in kio_smb.cpp:42 > Shouldn't this go in the SMBSlave class? No this is fine, this is done the same way in trash, file, recentlyused io~slaves... Follows

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven added inline comments. INLINE COMMENTS > broulik wrote in kfileitem.cpp:783 > Yes, but the "never blocks" claim in the commit message is misleading. Good point I have edited the commit message REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven,

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven updated this revision to Diff 72738. meven marked 3 inline comments as done. meven added a comment. amend commit title REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=72732=72738 BRANCH arcpatch-D26407 REVISION DETAIL

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

meven retitled this revision from "KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs" to "KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs". REPOSITORY R241 KIO

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

meven added inline comments. INLINE COMMENTS > broulik wrote in kfileitem.cpp:783 > This creates a `QFileInfo` for `canonicalFilePath` which blocks, so the cache > doesn't help at all. At least the mnttab reading business in KMountPoint::currentMountPoints is saved. > anthonyfieroni wrote in

D26415: Ensure to store resource uri without a trailing slash

meven updated this revision to Diff 72734. meven added a comment. Add ResourceInstance::setUri case REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26415?vs=72733=72734 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26415 AFFECTED FILES

D26415: Ensure to store resource uri without a trailing slash

meven created this revision. meven added reviewers: ivan, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Some apps may send resource such as /home/me/Documents/ When others, can

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

meven marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

meven updated this revision to Diff 72732. meven added a comment. Address review, don't commit at 1 a.m REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26407?vs=72720=72732 BRANCH arcpatch-D26407 REVISION DETAIL https://phabricator.kde.org/D26407

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven added a comment. I have to check on the tests. INLINE COMMENTS > dfaure wrote in jobtest.cpp:2171 > Why the short 500ms timeout? CI can be slow sometimes. It was the previous value used line 2176 for the same use, except the file cleaning will now be more immediate. REPOSITORY

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven updated this revision to Diff 72729. meven added a comment. Use more appropriate error(KIO::ERR_USER_CANCELED) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25117?vs=70401=72729 BRANCH arcpatch-D25117_1 REVISION DETAIL

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

meven created this revision. meven added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Alternative to D23198 BUG: 401579

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven added a comment. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure, ngraham, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

meven edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

meven created this revision. meven added reviewers: ervin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Add a utility function isImmutable to access immutability quickly. Generated

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

meven planned changes to this revision. meven added a comment. In D26361#586350 , @ervin wrote: > Indeed will have to wait KF6 branching AFAICT. Could you add a task for it in the KF6 board in the waiting for branching column? Just to make sure

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

meven added a comment. The methods are straight copy-paste compared to KCoreConfigSkeleton. The binary compatiblity might be affected though so we might want to do it for KF6 only. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26361 To: meven, ervin,

D26361: Clean up redundant methods for KConfigskeleton already present for base class KCoreConfigSkeleton

meven created this revision. meven added reviewers: ervin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL

D17595: Upstream Dolphin's file rename dialog

meven added a comment. In D17595#580655 , @ngraham wrote: > Awesome. Does this need a rebase? It should not, the API has not changed and this is new code. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To:

D26358: KIO/SMB convert kio protocol declaration to json format

meven added a comment. Not too sure if it helps bug https://bugs.kde.org/show_bug.cgi?id=414482 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D26358: KIO/SMB convert kio protocol declaration to json format

meven added a reviewer: ngraham. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26358 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D26358: KIO/SMB convert kio protocol declaration to json format

meven created this revision. meven added a reviewer: Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D26358: KIO/SMB convert kio protocol declaration to json format

meven updated this revision to Diff 72596. meven added a comment. clean REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26358?vs=72595=72596 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26358 AFFECTED FILES smb/CMakeLists.txt

D26208: [KEmailAddress] Remove redundant bool var

meven added a comment. Seems fine to me, indeed this bool was never changed REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D26208 To: ahmadsamir, dfaure Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

meven added inline comments. INLINE COMMENTS > kfileplacesview.h:157 > Q_PRIVATE_SLOT(d, void adaptItemSize()) > -Q_PRIVATE_SLOT(d, void _k_placeClicked(const QModelIndex &)) > +Q_PRIVATE_SLOT(d, void _k_placeClicked(const QModelIndex &)) // TODO > remove > Q_PRIVATE_SLOT(d,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven planned changes to this revision. meven added a comment. I have tried adding unit tests. It showed that the old: ` *stat(const QUrl , KIO::StatJob::StatSide side, short int details, JobFlags flags = DefaultFlags);` Takes over the new : `KIO::stat(const QUrl &, KIO::StatSide,

D26122: Add utility text function KShell::tildeCollapse

meven added a comment. In D26122#581717 , @apol wrote: > I might be missing something, explaining why it's necessary would be useful for the commit log as well as for lost reviewers like me. I replaced my first use case by

D26113: Places: For mounted volume display mount points instead of description

meven added a comment. In D26113#581077 , @ngraham wrote: > We can make the name override more discoverable for sure. But IMO we should also improve the default presentation, because this is just yucky: F7828189: Screenshot_20191221_092825.png

D26113: Places: For mounted volume display mount points instead of description

meven added a comment. In D26113#581021 , @bruns wrote: > I would consider an item changing its name based on the state a bug. > > As said, the name *is*configurable. I am leaning towards abandoning this and D26114

D26099: Port QRegExp to QRegularExpression

meven accepted this revision. meven added a comment. Seems fine to me REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2,

D26099: Port QRegExp to QRegularExpression

meven added a comment. In D26099#581001 , @ahmadsamir wrote: > Frameworks now require Qt 5.12 Indeed since 65da5bf151fa934bbdcac82543e3cd9f5cc4ab43 in baloo

D26112: Clean up unnecessary code

This revision was automatically updated to reflect the committed changes. Closed by commit R245:38c99f154ad3: Clean up unnecessary code (authored by meven). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26112?vs=71859=71925 REVISION DETAIL

D26122: Add utility text function KShell::tildeCollapse

meven created this revision. meven added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. TEST PLAN ctest REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL

D17595: Upstream Dolphin's file rename dialog

meven added a comment. In D17595#569924 , @lydia wrote: > For posterity's sake: > > I confirm that we have confirmation to the board list from (hope I didn't overlook anyone): > > - Emmanuel Pescosta > - Roman Inflianskas > -

D26116: Reduce timeout when trying to connect to an app dbus interface

meven added a comment. In D26116#580539 , @davidedmundson wrote: > > Encountered this issue while testing krunner. > > Can you expand on this, so I can see what problem we're actually trying to solve. I had a "org.kde.krunner"

D26116: Reduce timeout when trying to connect to an app dbus interface

meven added a comment. In D26116#580480 , @broulik wrote: > I'd say 5 seconds is optimistic. Granted. 10 seconds maybe. > Does Kate's session selection dialog still block startup? I am not aware of this. REPOSITORY R271

D26112: Clean up unnecessary code

meven edited the summary of this revision. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D26112 To: meven, #frameworks, bruns, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17205: Build kio_nfs against standalone libtirpc

meven added a comment. ping @asturmlechner REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D17205 To: asturmlechner, #dolphin, dfaure, rdieter Cc: meven, sitter, kde-frameworks-devel, cgiboudeaux, arojas, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26116: Reduce timeout when trying to connect to an app dbus interface

meven updated this revision to Diff 71867. meven added a comment. Include kde dbus daemon case REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26116?vs=71866=71867 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26116 AFFECTED FILES

<    2   3   4   5   6   7   8   9   10   11   >