Aw: BluezQt GATT client API

2019-08-26 Thread Manuel Weichselbaumer 
Hi,

 

the GATT client API is not fully implemented (nor tested). Unfortunately, i do not plan to implement this soon.

 

However, Qt also provides a BluettothLE API which should work just fine (in client mode).

 

Best regards,

Manuel Weichselbaumer

 

Gesendet: Freitag, 23. August 2019 um 19:18 Uhr
Von: "Иван Подкурков" 
An: kde-frameworks-devel@kde.org
Cc: manuel.weichselbau...@bmw.de, mince...@web.de
Betreff: BluezQt GATT client API

Hello,

I have a question regarding BluezQt library.

In recent commits I see that the functionality for Bluetooth Low Energy (GATT) was added, but I don't see the way to act as a client, i.e. to read GATT characteristics from other devices.

There is one test called leserver.cpp / leserver.h which demonstrates the way to act as a GATT server for other Low Energy devices, but not other way around.

Is Low Energy GATT client API not supported yet, or am I missing something among the API?

Best Regards,
Ivan Podkurkov

D22107: Add MediaTransport API

2019-07-03 Thread Manuel Weichselbaumer 
mweichselbaumer closed this revision.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D22107

To: mweichselbaumer, drosca
Cc: ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22107: Add MediaTransport API

2019-06-28 Thread Manuel Weichselbaumer 
mweichselbaumer added inline comments.

INLINE COMMENTS

> drosca wrote in tpendingcall.h:45
> Alright, that makes sense.
> 
> With KF6 we can convert all PendingCalls to this form. It would be a good 
> idea to add `TODO: KF6` somewhere to not forget it.

Ok, i will update this patch and land it in a couple of days.

REPOSITORY
  R269 BluezQt

BRANCH
  mediatransport

REVISION DETAIL
  https://phabricator.kde.org/D22107

To: mweichselbaumer, drosca
Cc: ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22107: Add MediaTransport API

2019-06-27 Thread Manuel Weichselbaumer 
mweichselbaumer added inline comments.

INLINE COMMENTS

> ltoscano wrote in a2dp-codecs.h:33
> Will it work with older versions of bluez?

Bluez just defines this constant, but does not use it internally (nor we do).
So, yes, this works with any version of bluez.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D22107

To: mweichselbaumer, drosca
Cc: ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22107: Add MediaTransport API

2019-06-27 Thread Manuel Weichselbaumer 
mweichselbaumer marked an inline comment as done.
mweichselbaumer added inline comments.

INLINE COMMENTS

> drosca wrote in a2dp-codecs.h:33
> Are you sure about this?

Yes, this has also been fixed by bluez as of 2018-12-28.

> drosca wrote in tpendingcall.h:45
> Is this really needed? In the end, it doesn't really make the code that much 
> better:
> 
>   TPendingCall *fd = 
> transport->tryAcquire();
>   fd->valueAt<0>();
>   fd->valueAt<1>();
>   fd->valueAt<2>();
> 
> vs
> 
>   PendingCall *fd = transport->tryAcquire();
>   fd->values().at(0).value();
>   fd->values().at(1).value();
>   fd->values().at(2).value();
> 
> Or we can add convenience method  `T valueAt(int)` so it becomes:
> 
>   PendingCall *fd = transport->tryAcquire();
>   fd->valueAt(0);
>   fd->valueAt(1);
>   fd->valueAt(2);

Actually, my intention was to provide a type-safe way to obtain return values 
from PendingCall and to express explicitly, what the corresponding method 
returns in API header.
As a client you can make use of "auto".

Consider:

  auto *fd = transport->tryAcquire(); // Method declaration will define return 
type.
  auto ret1 = fd->valueAt<0>();
  auto ret2 = fd->valueAt<1>();
  auto ret3 = fd->valueAt<2>();

Thus, return type (of PendingCall) is expressed in API header and clients do 
not need to express the return types themselves.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D22107

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22107: Add MediaTransport API

2019-06-26 Thread Manuel Weichselbaumer 
mweichselbaumer added a reviewer: drosca.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D22107

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22107: Add MediaTransport API

2019-06-26 Thread Manuel Weichselbaumer 
mweichselbaumer created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mweichselbaumer requested review of this revision.

REPOSITORY
  R269 BluezQt

BRANCH
  mediatransport

REVISION DETAIL
  https://phabricator.kde.org/D22107

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/autotests.cpp
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/deviceinterface.cpp
  autotests/fakebluez/deviceinterface.h
  autotests/fakebluez/devicemanager.cpp
  autotests/fakebluez/mediatransportinterface.cpp
  autotests/fakebluez/mediatransportinterface.h
  autotests/interfaces/org.bluez.MediaTransport1.xml
  autotests/mediatransporttest.cpp
  autotests/mediatransporttest.h
  src/CMakeLists.txt
  src/a2dp-codecs.h
  src/device.cpp
  src/device.h
  src/device_p.cpp
  src/device_p.h
  src/mediatransport.cpp
  src/mediatransport.h
  src/mediatransport_p.cpp
  src/mediatransport_p.h
  src/mediatypes.h
  src/pendingcall.cpp
  src/pendingcall.h
  src/tpendingcall.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/mediaendpointconnector.cpp
  tests/mediaendpointconnector.h

To: mweichselbaumer
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

2019-06-07 Thread Manuel Weichselbaumer 
mweichselbaumer closed this revision.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D21584

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

2019-06-07 Thread Manuel Weichselbaumer 
mweichselbaumer updated this revision to Diff 59349.
mweichselbaumer added a comment.


  Fixed according to comments

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21584?vs=59346=59349

BRANCH
  ble_gatt

REVISION DETAIL
  https://phabricator.kde.org/D21584

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/adapterinterface.cpp
  autotests/fakebluez/adapterinterface.h
  autotests/fakebluez/devicemanager.cpp
  autotests/fakebluez/devicemanager.h
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/fakebluez/leadvertisingmanagerinterface.cpp
  autotests/fakebluez/leadvertisingmanagerinterface.h
  autotests/gattmanagertest.cpp
  autotests/gattmanagertest.h
  autotests/leadvertisingmanagertest.cpp
  autotests/leadvertisingmanagertest.h
  src/CMakeLists.txt
  src/adapter.cpp
  src/adapter.h
  src/adapter_p.cpp
  src/adapter_p.h
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattmanager_p.cpp
  src/gattmanager_p.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/interfaces/org.bluez.GattCharacteristic1.xml
  src/interfaces/org.bluez.GattManager1.xml
  src/interfaces/org.bluez.LEAdvertisement1.xml
  src/interfaces/org.bluez.LEAdvertisingManager1.xml
  src/leadvertisement.cpp
  src/leadvertisement.h
  src/leadvertisement_p.cpp
  src/leadvertisement_p.h
  src/leadvertisementadaptor.cpp
  src/leadvertisementadaptor.h
  src/leadvertisingmanager.cpp
  src/leadvertisingmanager.h
  src/leadvertisingmanager_p.h
  src/mediaendpoint.cpp
  src/objectmanageradaptor.cpp
  src/objectmanageradaptor.h
  src/pendingcall.cpp
  src/pendingcall.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/leserver.cpp
  tests/leserver.h

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

2019-06-07 Thread Manuel Weichselbaumer 
mweichselbaumer updated this revision to Diff 59346.
mweichselbaumer added a comment.


  Fixed according to comments

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21584?vs=59277=59346

BRANCH
  ble_gatt

REVISION DETAIL
  https://phabricator.kde.org/D21584

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/adapterinterface.cpp
  autotests/fakebluez/adapterinterface.h
  autotests/fakebluez/devicemanager.cpp
  autotests/fakebluez/devicemanager.h
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/fakebluez/leadvertisingmanagerinterface.cpp
  autotests/fakebluez/leadvertisingmanagerinterface.h
  autotests/gattmanagertest.cpp
  autotests/gattmanagertest.h
  autotests/leadvertisingmanagertest.cpp
  autotests/leadvertisingmanagertest.h
  src/CMakeLists.txt
  src/adapter.cpp
  src/adapter.h
  src/adapter_p.cpp
  src/adapter_p.h
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattmanager_p.cpp
  src/gattmanager_p.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/interfaces/org.bluez.GattCharacteristic1.xml
  src/interfaces/org.bluez.GattManager1.xml
  src/interfaces/org.bluez.LEAdvertisement1.xml
  src/interfaces/org.bluez.LEAdvertisingManager1.xml
  src/leadvertisement.cpp
  src/leadvertisement.h
  src/leadvertisement_p.cpp
  src/leadvertisement_p.h
  src/leadvertisementadaptor.cpp
  src/leadvertisementadaptor.h
  src/leadvertisingmanager.cpp
  src/leadvertisingmanager.h
  src/leadvertisingmanager_p.h
  src/mediaendpoint.cpp
  src/objectmanageradaptor.cpp
  src/objectmanageradaptor.h
  src/pendingcall.cpp
  src/pendingcall.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/leserver.cpp
  tests/leserver.h

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

2019-06-07 Thread Manuel Weichselbaumer 
mweichselbaumer marked an inline comment as done.
mweichselbaumer added inline comments.

INLINE COMMENTS

> drosca wrote in objectmanager.h:47
> I don't really like this class at all. This is implementation detail, and is 
> of no use for the users of the library, so it shouldn't be exported. On top 
> of it, there is actually no code, it is just interface class.
> 
> Another issue here, although minor, is that the bluezqt_dbustypes.h is not 
> installed, so you can't use it. Yes, you could install it, but we don't need 
> it.
> 
> As I can see, the only reason for this class is so you can pass it to 
> ObjectManagerAdaptor, but there are other ways to achieve the same thing 
> without adding `ObjectManager` and deriving from it in GattApplication. If we 
> really need it in generic way, we can do it later.
> 
> Something like this would work:
> 
>   ObjectManagerAdaptor(QObject *parent)
>   {
>   GattApplication *app = qobject_cast(parent);
>   }
>   
>   DBusManagerStruct GetManagedObjects()
>   {
>   return app->d->getManagedObjects();
>   }
> 
> Or for now just make it work only with GattApplication, as this is the only 
> one we have now.
> 
> Yes, it will not work in the autotest, since you won't have the hook anymore, 
> but you can just remove that test.

I see your point and agree, that ObjectManager is solely used in 
GattApplication.
Just letting you know, that we would need an ObjectManager for the mesh-api as 
well.

Shall we then add constructors for appropriate types to ObjectManagerAdaptor 
(instead of exporting and inheriting from ObjectManager)?

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D21584

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

2019-06-06 Thread Manuel Weichselbaumer 
mweichselbaumer added inline comments.

INLINE COMMENTS

> drosca wrote in gattapplication.h:66
> Should this be made private (preferrably in GattApplicationPrivate)?

I override this in test class, so kept as protected.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D21584

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

2019-06-06 Thread Manuel Weichselbaumer 
mweichselbaumer updated this revision to Diff 59277.
mweichselbaumer added a comment.


  Fixed according to comments

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21584?vs=59238=59277

BRANCH
  ble_gatt

REVISION DETAIL
  https://phabricator.kde.org/D21584

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/adapterinterface.cpp
  autotests/fakebluez/adapterinterface.h
  autotests/fakebluez/devicemanager.cpp
  autotests/fakebluez/devicemanager.h
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/fakebluez/leadvertisingmanagerinterface.cpp
  autotests/fakebluez/leadvertisingmanagerinterface.h
  autotests/gattmanagertest.cpp
  autotests/gattmanagertest.h
  autotests/leadvertisingmanagertest.cpp
  autotests/leadvertisingmanagertest.h
  src/CMakeLists.txt
  src/adapter.cpp
  src/adapter.h
  src/adapter_p.cpp
  src/adapter_p.h
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattmanager_p.cpp
  src/gattmanager_p.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/interfaces/org.bluez.GattCharacteristic1.xml
  src/interfaces/org.bluez.GattManager1.xml
  src/interfaces/org.bluez.LEAdvertisement1.xml
  src/interfaces/org.bluez.LEAdvertisingManager1.xml
  src/leadvertisement.cpp
  src/leadvertisement.h
  src/leadvertisement_p.cpp
  src/leadvertisement_p.h
  src/leadvertisementadaptor.cpp
  src/leadvertisementadaptor.h
  src/leadvertisingmanager.cpp
  src/leadvertisingmanager.h
  src/leadvertisingmanager_p.h
  src/mediaendpoint.cpp
  src/objectmanager.cpp
  src/objectmanager.h
  src/objectmanageradaptor.cpp
  src/objectmanageradaptor.h
  src/pendingcall.cpp
  src/pendingcall.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/leserver.cpp
  tests/leserver.h

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

2019-06-05 Thread Manuel Weichselbaumer 
mweichselbaumer updated this revision to Diff 59238.
mweichselbaumer added a comment.


  Fixed according to comments

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21584?vs=59237=59238

BRANCH
  ble_gatt

REVISION DETAIL
  https://phabricator.kde.org/D21584

AFFECTED FILES
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/gattmanagertest.cpp
  src/CMakeLists.txt
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattmanager_p.cpp
  src/gattmanager_p.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/objectmanageradaptor.cpp
  src/objectmanageradaptor.h
  tests/leserver.cpp

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

2019-06-05 Thread Manuel Weichselbaumer 
mweichselbaumer updated this revision to Diff 59237.
mweichselbaumer added a comment.


  Fixed according to comments

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21584?vs=59236=59237

BRANCH
  ble_gatt

REVISION DETAIL
  https://phabricator.kde.org/D21584

AFFECTED FILES
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/gattmanagertest.cpp
  src/CMakeLists.txt
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattmanager_p.cpp
  src/gattmanager_p.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/objectmanageradaptor.cpp
  src/objectmanageradaptor.h
  tests/leserver.cpp

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

2019-06-05 Thread Manuel Weichselbaumer 
mweichselbaumer updated this revision to Diff 59236.
mweichselbaumer marked an inline comment as done.
mweichselbaumer added a comment.


  Fixed according to comments

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21584?vs=59151=59236

BRANCH
  ble_gatt

REVISION DETAIL
  https://phabricator.kde.org/D21584

AFFECTED FILES
  CMakeLists.txt
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/gattmanagertest.cpp
  src/CMakeLists.txt
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattmanager_p.cpp
  src/gattmanager_p.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/objectmanageradaptor.cpp
  src/objectmanageradaptor.h
  tests/leserver.cpp

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

2019-06-05 Thread Manuel Weichselbaumer 
mweichselbaumer marked 11 inline comments as done.
mweichselbaumer added inline comments.

INLINE COMMENTS

> drosca wrote in gattapplication_p.cpp:31
> Shouldn't the caller be made responsible for choosing object path?
> If we force a path then we should use "our" namespace - `/org/kde/bluez-qt/`.

Ok, will add possibility for custom prefix.

> drosca wrote in gattcharacteristic_p.cpp:33
> Any reason to use uint8?

I tried to figure out the maximum number of charcs (per service). I do not know 
exact numbers, but uint8 would intrinsically add limits.

> drosca wrote in gattservice.h:50
> Probably would be better to add setters for uuid/primary (and note that it 
> can only be set during creation), as if we need in future more properties we 
> will need to add new constructors.
> Or make it virtual?

GATT is well defined and i do not expect any changes (regarding additional 
properties).
This also follows the RAII idiom and is less error prone.
Could be made virtual though, however i believe adding further constructors 
won't harm.
Or if further properties are coming, we add setters for them, since they are 
then expected not to be mandatory.

> drosca wrote in leadvertisement.h:52
> Same as above, add setters?

see above

> drosca wrote in objectmanager.h:47
> Will this be used for more classes? Right now only GattApplication inherits 
> it.

QDbusAdaptors can only realize one single DBUS interface.
This is the base class the org.freedesktop.DBus.ObjectManager adaptor is 
handling.
Sure, this could (and should) be reused if other DBUS/BlueZ objects shall 
realize this interface.
GattApplication is meant to realize the org.freedesktop.DBus.ObjectManager 
interface (see gatt-api.txt).

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D21584

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

2019-06-04 Thread Manuel Weichselbaumer 
mweichselbaumer added a reviewer: drosca.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D21584

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

2019-06-04 Thread Manuel Weichselbaumer 
mweichselbaumer created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mweichselbaumer requested review of this revision.

REPOSITORY
  R269 BluezQt

BRANCH
  ble_gatt

REVISION DETAIL
  https://phabricator.kde.org/D21584

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/adapterinterface.cpp
  autotests/fakebluez/adapterinterface.h
  autotests/fakebluez/devicemanager.cpp
  autotests/fakebluez/devicemanager.h
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/fakebluez/leadvertisingmanagerinterface.cpp
  autotests/fakebluez/leadvertisingmanagerinterface.h
  autotests/gattmanagertest.cpp
  autotests/gattmanagertest.h
  autotests/leadvertisingmanagertest.cpp
  autotests/leadvertisingmanagertest.h
  src/CMakeLists.txt
  src/adapter.cpp
  src/adapter.h
  src/adapter_p.cpp
  src/adapter_p.h
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/interfaces/org.bluez.GattCharacteristic1.xml
  src/interfaces/org.bluez.GattManager1.xml
  src/interfaces/org.bluez.LEAdvertisement1.xml
  src/interfaces/org.bluez.LEAdvertisingManager1.xml
  src/leadvertisement.cpp
  src/leadvertisement.h
  src/leadvertisement_p.cpp
  src/leadvertisement_p.h
  src/leadvertisementadaptor.cpp
  src/leadvertisementadaptor.h
  src/leadvertisingmanager.cpp
  src/leadvertisingmanager.h
  src/leadvertisingmanager_p.h
  src/mediaendpoint.cpp
  src/objectmanager.cpp
  src/objectmanager.h
  src/objectmanageradaptor.cpp
  src/objectmanageradaptor.h
  src/pendingcall.cpp
  src/pendingcall.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/leserver.cpp
  tests/leserver.h

To: mweichselbaumer
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21265: Add Bluez API to DBus XML parser/generator

2019-05-31 Thread Manuel Weichselbaumer 
This revision was automatically updated to reflect the committed changes.
Closed by commit R269:bfe94dface00: Add Bluez API to DBus XML parser/generator 
(authored by mweichselbaumer).
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21265?vs=58867=58963

REVISION DETAIL
  https://phabricator.kde.org/D21265

AFFECTED FILES
  CMakeLists.txt
  tools/bluezapi2qt/BluezApiParser.cpp
  tools/bluezapi2qt/BluezApiParser.h
  tools/bluezapi2qt/CMakeLists.txt
  tools/bluezapi2qt/Comment.cpp
  tools/bluezapi2qt/Comment.h
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/CppGenerator.h
  tools/bluezapi2qt/Interface.cpp
  tools/bluezapi2qt/Interface.h
  tools/bluezapi2qt/Method.cpp
  tools/bluezapi2qt/Method.h
  tools/bluezapi2qt/Methods.cpp
  tools/bluezapi2qt/Methods.h
  tools/bluezapi2qt/Parameter.cpp
  tools/bluezapi2qt/Parameter.h
  tools/bluezapi2qt/Properties.cpp
  tools/bluezapi2qt/Properties.h
  tools/bluezapi2qt/Property.cpp
  tools/bluezapi2qt/Property.h
  tools/bluezapi2qt/TODO
  tools/bluezapi2qt/TypeAnnotation.cpp
  tools/bluezapi2qt/TypeAnnotation.h
  tools/bluezapi2qt/XmlGenerator.cpp
  tools/bluezapi2qt/XmlGenerator.h
  tools/bluezapi2qt/main.cpp

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16084: Add Media and MediaEndpoint API header generation

2018-10-09 Thread Manuel Weichselbaumer 
mweichselbaumer created this revision.
mweichselbaumer added a reviewer: drosca.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mweichselbaumer requested review of this revision.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D16084

AFFECTED FILES
  src/CMakeLists.txt
  tests/mediaendpointconnector.cpp
  tests/mediaendpointconnector.h

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread Manuel Weichselbaumer 
mweichselbaumer added a comment.


  In D15745#336711 <https://phabricator.kde.org/D15745#336711>, @drosca wrote:
  
  > Thanks.
  >  I'll need your full name + e-mail if you don't have dev account to push it.
  
  
  You're welcome. It's been a pleasure to contribute to this lib.
  Manuel Weichselbaumer, mince...@web.de

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread Manuel Weichselbaumer 
mweichselbaumer updated this revision to Diff 42877.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15745?vs=42861=42877

REVISION DETAIL
  https://phabricator.kde.org/D15745

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/fakebluez.cpp
  autotests/fakebluez/fakebluez.h
  autotests/fakebluez/media.cpp
  autotests/fakebluez/media.h
  autotests/mediatest.cpp
  autotests/mediatest.h
  src/CMakeLists.txt
  src/a2dp-codecs.c
  src/a2dp-codecs.h
  src/interfaces/org.bluez.Media1.xml
  src/interfaces/org.bluez.MediaEndpoint1.xml
  src/manager.cpp
  src/manager.h
  src/manager_p.cpp
  src/manager_p.h
  src/media.cpp
  src/media.h
  src/media_p.h
  src/mediaendpoint.cpp
  src/mediaendpoint.h
  src/mediaendpoint_p.cpp
  src/mediaendpoint_p.h
  src/mediaendpointadaptor.cpp
  src/mediaendpointadaptor.h
  src/pendingcall.h
  src/request.cpp
  src/request.h
  src/services.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/mediaendpointconnector.cpp
  tests/mediaendpointconnector.h

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread Manuel Weichselbaumer 
mweichselbaumer added a comment.


  In D15745#336644 , @drosca wrote:
  
  > Remove NoInputNoOutputAgent and it's good to go.
  
  
  Agree. Is it ok to move it to mediaendpointconnector?

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread Manuel Weichselbaumer 
mweichselbaumer added a comment.


  In D15745#336593 , @drosca wrote:
  
  > Alright, last thing:
  >
  > Why NoInputNoOutputAgent? That should be implemented by the application, 
and not be part of library. In almost all cases you actually want to inform 
user that something is trying to connect anyway.
  
  
  Yes, i also thought this should be application specific. However, i could not 
imagine another use case of a NoInputNoOutputAgent, except from doing auto 
connecting to a limited set of UUIDs. So, i thought it is generic enough to be 
part of the library.

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread Manuel Weichselbaumer 
mweichselbaumer updated this revision to Diff 42861.
mweichselbaumer added a comment.


  Fixed style issues and smart pointer construction

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15745?vs=42813=42861

REVISION DETAIL
  https://phabricator.kde.org/D15745

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/fakebluez.cpp
  autotests/fakebluez/fakebluez.h
  autotests/fakebluez/media.cpp
  autotests/fakebluez/media.h
  autotests/mediatest.cpp
  autotests/mediatest.h
  autotests/noinputnooutputagenttest.cpp
  autotests/noinputnooutputagenttest.h
  src/CMakeLists.txt
  src/a2dp-codecs.c
  src/a2dp-codecs.h
  src/interfaces/org.bluez.Media1.xml
  src/interfaces/org.bluez.MediaEndpoint1.xml
  src/manager.cpp
  src/manager.h
  src/manager_p.cpp
  src/manager_p.h
  src/media.cpp
  src/media.h
  src/media_p.h
  src/mediaendpoint.cpp
  src/mediaendpoint.h
  src/mediaendpoint_p.cpp
  src/mediaendpoint_p.h
  src/mediaendpointadaptor.cpp
  src/mediaendpointadaptor.h
  src/noinputnooutputagent.cpp
  src/noinputnooutputagent.h
  src/pendingcall.h
  src/request.cpp
  src/request.h
  src/services.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/mediaendpointconnector.cpp
  tests/mediaendpointconnector.h

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread Manuel Weichselbaumer 
mweichselbaumer marked 3 inline comments as done and an inline comment as not 
done.

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-10-03 Thread Manuel Weichselbaumer 
mweichselbaumer updated this revision to Diff 42813.
mweichselbaumer added a comment.


  Added autotests and additional test: mediaendpointconnector

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15745?vs=42313=42813

REVISION DETAIL
  https://phabricator.kde.org/D15745

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/fakebluez.cpp
  autotests/fakebluez/fakebluez.h
  autotests/fakebluez/media.cpp
  autotests/fakebluez/media.h
  autotests/mediatest.cpp
  autotests/mediatest.h
  autotests/noinputnooutputagenttest.cpp
  autotests/noinputnooutputagenttest.h
  src/CMakeLists.txt
  src/a2dp-codecs.c
  src/a2dp-codecs.h
  src/interfaces/org.bluez.Media1.xml
  src/interfaces/org.bluez.MediaEndpoint1.xml
  src/manager.cpp
  src/manager.h
  src/manager_p.cpp
  src/manager_p.h
  src/media.cpp
  src/media.h
  src/media_p.h
  src/mediaendpoint.cpp
  src/mediaendpoint.h
  src/mediaendpoint_p.cpp
  src/mediaendpoint_p.h
  src/mediaendpointadaptor.cpp
  src/mediaendpointadaptor.h
  src/noinputnooutputagent.cpp
  src/noinputnooutputagent.h
  src/pendingcall.h
  src/request.cpp
  src/request.h
  src/services.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/mediaendpointconnector.cpp
  tests/mediaendpointconnector.h

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-10-03 Thread Manuel Weichselbaumer 
mweichselbaumer edited the summary of this revision.

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-09-25 Thread Manuel Weichselbaumer 
mweichselbaumer updated this revision to Diff 42313.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15745?vs=42300=42313

REVISION DETAIL
  https://phabricator.kde.org/D15745

AFFECTED FILES
  src/CMakeLists.txt
  src/a2dp-codecs.h
  src/interfaces/org.bluez.Media1.xml
  src/interfaces/org.bluez.MediaEndpoint1.xml
  src/media.cpp
  src/media.h
  src/media_p.cpp
  src/media_p.h
  src/mediaendpoint.cpp
  src/mediaendpoint.h
  src/mediaendpoint_p.cpp
  src/mediaendpoint_p.h
  src/mediaendpointadaptor.cpp
  src/mediaendpointadaptor.h
  src/pendingcall.h

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-09-25 Thread Manuel Weichselbaumer 
mweichselbaumer marked 5 inline comments as done.
mweichselbaumer added inline comments.

INLINE COMMENTS

> broulik wrote in media_p.h:37
> Any particular reason this class must inherit `QObject`, you don't seem to be 
> using `signal` or `slot` in it

MediaPrivate will later act as parent for child objects (inheriting QObject).

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D15745

To: mweichselbaumer, drosca
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-09-25 Thread Manuel Weichselbaumer 
mweichselbaumer created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mweichselbaumer requested review of this revision.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D15745

AFFECTED FILES
  src/CMakeLists.txt
  src/interfaces/org.bluez.Media1.xml
  src/interfaces/org.bluez.MediaEndpoint1.xml
  src/media.cpp
  src/media.h
  src/media_p.cpp
  src/media_p.h
  src/mediaendpoint.cpp
  src/mediaendpoint.h
  src/mediaendpoint_p.h
  src/mediaendpointadaptor.cpp
  src/mediaendpointadaptor.h
  src/pendingcall.h

To: mweichselbaumer
Cc: kde-frameworks-devel, michaelh, ngraham, bruns