D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open

[Marco Martin]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> broulik wrote in containmentinterface.cpp:1073
> Not sure if we should use `this` (and then check `if m_containment` as 
> context or `m_containment`

should be the same

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6527

To: broulik, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6554: [Plasma Dialog] Fix flag condition

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6554

To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

[Marco Martin]

mart added a comment.


  ah, yeah, that's a leftover, should go

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D6899

To: mart, #frameworks, #plasma
Cc: broulik, #frameworks

D6899: support X-KDE-OnlyShowOnQtPlatforms

[Marco Martin]

mart updated this revision to Diff 17177.
mart added a comment.


  less blanks

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6899?vs=17176=17177

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6899

AFFECTED FILES
  src/kded.cpp
  src/kded.h

To: mart, #frameworks, #plasma
Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

[Marco Martin]

mart marked 2 inline comments as done.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D6899

To: mart, #frameworks, #plasma
Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

[Marco Martin]

mart created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  some kded modules can only run in one platform,
  especially only xcb or only wayland. this
  makes kded support the X-KDE-OnlyShowOnQtPlatforms
  entry in the desktop file

TEST PLAN
  touchpad and keyboard kdeds not loaded in wayland

REPOSITORY
  R297 KDED

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6899

AFFECTED FILES
  src/kded.cpp
  src/kded.h
  src/kdedmodule.desktop

To: mart
Cc: #frameworks

D6899: support X-KDE-OnlyShowOnQtPlatforms

[Marco Martin]

mart added reviewers: Frameworks, Plasma.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D6899

To: mart, #frameworks, #plasma
Cc: #frameworks

D6899: support X-KDE-OnlyShowOnQtPlatforms

[Marco Martin]

mart updated this revision to Diff 17176.
mart added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.


  readstringlist

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6899?vs=17175=17176

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6899

AFFECTED FILES
  src/kded.cpp
  src/kded.h
  src/kdedmodule.desktop

To: mart, #frameworks, #plasma
Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6776: Don't perform wayland specific fixes when on X

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D6776

To: davidedmundson, #plasma, mart
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6418: [XDGV6] manage every ping sent

[Marco Martin]

mart updated this revision to Diff 16044.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  - pingDelayed signal

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6418?vs=15997=16044

BRANCH
  mart/xdgv6ping

REVISION DETAIL
  https://phabricator.kde.org/D6418

AFFECTED FILES
  autotests/client/test_xdg_shell.cpp
  src/server/xdgshell_interface.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_interface_p.h
  src/server/xdgshell_v5_interface.cpp
  src/server/xdgshell_v6_interface.cpp

To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

Re: Kirigami in Frameworks

[Marco Martin]

Hi,
I have moved it, should be good to go.
one sidenote (hoping is not a problem) for historical reasons, the
tarballs were called kirigami2-version instead of just kirigami (or
distributions may have some problems in upgrading).. do release
scripts need to be adapted in some way?

On Fri, Jun 30, 2017 at 2:44 PM, David Faure <fa...@kde.org> wrote:
> What's the status with the move of Kirigami to frameworks?
> Do we want it in 5.36 tomorrow?
>
> AFAICS it's still in extragear/libs/kirigami in kde_projects.xml.
>
> David.
>
> On lundi 26 juin 2017 11:25:08 CEST Marco Martin wrote:
>> On Sat, Jun 24, 2017 at 3:27 PM, David Faure <fa...@kde.org> wrote:
>> >> the default style for QtQuickControlsStyle1 is "Desktop"
>> >> we could have called this style "Desktop" as well so all would have
>> >> aligned nicely, but that could be quite dangerous, as Qt coulddecide
>> >> any moment that they indeed want to do a style called "Desktop" for
>> >> qqc2, at which point it would conflict, so having the org.kde prefix
>> >> was the safe route.
>> >
>> > Well, we could also rename ours when/if the conflict occurs?
>>
>> since the conflict would be of installed files, it would make released
>> version not installable, which looks to me like too big of a risk.
>>
>> >> One way to silence this could be when the qtquickcontrols2
>> >> theme installs into qt's qqc2
>> >
>> > If you mean $QTDIR, that's not my case. The plugin is found via
>> > QML2_IMPORT_PATH I suppose.
>>
>> qtquickcontrols2 will be installed under QML2_IMPORT_PATH and we need
>> to install under that folder
>>
>> >> , to install also an org.kde.desktop
>> >> symlink in QtQuickControls1 that just points to "Desktop" (note that
>> >> style is not in the kirigami repository, kirigami has themes with the
>> >> same name because it's an extension on top of qtquickcontrols2)
>> >
>> > That sounds good, if it can be done.
>>
>> setting a symlink there seems to just work, so i would try to go for that
>> route
>> >> It has some android specific things, like providing a manifest.xml and
>> >> some optional qtandroidextras usage for integration when compiled
>> >> there, but it's intended to be multiplatform, so may make sesie to
>> >> enable it.
>> >
>> > Then I don't think it should be under an android subdir.
>> > A multiplatform app with extra stuff for android integration is still
>> > multiplatform in the first place.
>>
>> sure, renaming it to multipletform then :)
>>
>> >> talking about examples, do you think is better to build them with a
>> >> flag on the top cmake as is now, or provide a separate standalone
>> >> cmake file under examples/ ?
>> >
>> > Much better the way you did it, it's how I see it done in most other
>> > frameworks.
>> > It makes it easy to enable the building of examples once and for all in
>> > kdesrc-buildrc for instance, to make sure they keep compiling and so that
>> > they are available for testing.
>> > In fact, I wonder if the CI shouldn't set BUILD_EXAMPLES=ON in all
>> > frameworks that have that option... (4 currently, 5 with kirigami).
>>
>> ok
>>
>> --
>> Marco Martin
>
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>

D6390: WIP: Add remote runners over DBus

[Marco Martin]

mart added a comment.


  love the idea.
  when this goes in, at least one using this should already exist, to make sure 
the code gets well tested from day one.
  
  this makes me think...
  it's not exacrtly the same thing, maybe kindof a layer, but would be possible 
to start from this and have a process that contains all current runners which 
krunner and plasmashell then query? (this at least would get rid of things like 
the thousands of plasmashell crashes caused by baloo once for all, even tough 
it moves them to another process, it's a less mission critical one)

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D6390

To: davidedmundson, #plasma
Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Re: Kirigami in Frameworks

[Marco Martin]

On Saturday 01 July 2017, David Faure wrote:
> On vendredi 30 juin 2017 15:16:17 CEST Marco Martin wrote:
> > Hi,
> > I have moved it, should be good to go.
> > one sidenote (hoping is not a problem) for historical reasons, the
> > tarballs were called kirigami2-version instead of just kirigami (or
> > distributions may have some problems in upgrading).. do release
> > scripts need to be adapted in some way?
> 
> Isn't this the right time to drop that historic baggage?

I'm fine with it

-- 
Marco Martin

Re: Kirigami in Frameworks

[Marco Martin]

On Sunday 02 July 2017, David Faure wrote:
> 
> I'd like to finalize the tagging today.
> With kirigami still having issues with translations, CI, and naming, I'd
> like to skip it for now and release it next month, unless there are strong
> reasons to do otherwise.

I'm fine with this as well

-- 
Marco Martin

D6484: emit runningActivityListChanged on activity creation

[Marco Martin]

mart added a reviewer: ivan.

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D6484

To: mart, #plasma, ivan
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6484: emit runningActivityListChanged on activity creation

[Marco Martin]

mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  if an activity gets created and started immediately,
  runningActivityListChanged wasn't emitted, a symptom
  was the activitypager applet not updating the number of activities
  on activity creation, now emit this on setActivityInfo both
  when there wasn't such activity yet or the running
  status changes

TEST PLAN
  activity pager immediately reacts to activity creation,
  other kactivities users still work

REPOSITORY
  R6 KActivities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6484

AFFECTED FILES
  src/lib/activitiescache_p.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6484: emit runningActivityListChanged on activity creation

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R6:dce2a89774c6: emit runningActivityListChanged on activity 
creation (authored by mart).

REPOSITORY
  R6 KActivities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6484?vs=16130=16134

REVISION DETAIL
  https://phabricator.kde.org/D6484

AFFECTED FILES
  src/lib/activitiescache_p.cpp

To: mart, #plasma, ivan, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6518: guard against themes without a valid shadow

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6518#121981, @davidedmundson wrote:
  
  > What if a theme only has shadow-top, but not right etc.
  >  (or a more likely scenario, they exist, but the metadata has them be 0px 
big)
  >
  > What would happen if you have a theme with shadow then switch to one 
without?
  
  
  yeah, a better fix is needed.
  i can either check for every element, or try to make kwayland not crash 
(tough i'm still not really understanding why it does)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6518

To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D6523: check Buffer validity

[Marco Martin]

mart created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  if a plasma theme doesn't provide shadow graphics,
  the buffer will be a nullptr as would be created
  from an invalid image and would crash
  
  BUG:381953

TEST PLAN
  no crash anymore when using a theme that doesn't provide shadows

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6523

AFFECTED FILES
  src/client/shadow.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6518: guard against themes without a valid shadow

[Marco Martin]

mart added a comment.


  replaced by https://phabricator.kde.org/D6523

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6518

To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D6523: check Buffer validity

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6523#122107, @davidedmundson wrote:
  
  > Same question as before, what happens when we go from a theme with shadows 
to a theme without?
  
  
  I tried to switch back and forth several times between breeze and 
keramiek(the theme linked in the bug which could reproduce the crash) and all 
seems to be fine
  
  the shadows go from visible to absent and back and doesn't crash

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6523

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6523: check Buffer validity

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:dd8e084a685e: check Buffer validity (authored by mart).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6523?vs=16229=16242

REVISION DETAIL
  https://phabricator.kde.org/D6523

AFFECTED FILES
  src/client/shadow.cpp

To: mart, #plasma, davidedmundson, graesslin
Cc: graesslin, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, 
hein, lukas

D6518: guard against themes without a valid shadow

[Marco Martin]

mart abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6518

To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D6047: WIP: Support XDG v6

[Marco Martin]

mart added a comment.


  right now, the xdgv6 branch (xdgv6popup actually) for me causes a crash in 
kwin at startup, with the following BT:
  #0  _int_malloc (av=av@entry=0x7556ab20 , 
bytes=bytes@entry=72) at malloc.c:3414
  #1  0x7522a5d4 in __GI___libc_malloc (bytes=72) at malloc.c:2911
  #2  0x755fde78 in operator new(unsigned long) ()
  
from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
  
  #3  0x75dcc32e in QObjectPrivate::connectImpl 
(sender=sender@entry=0x69d950,
  
signal_index=5, receiver=receiver@entry=0x69c600, slot=slot@entry=0x0, 
slotObj=slotObj@entry=0x69c860, type=Qt::AutoConnection, types=0x0, 
senderMetaObject=0x7720c220 
)
at kernel/qobject.cpp:4829
  
  #4  0x75dcc69b in QObject::connectImpl (sender=0x69d950, 
signal=,
  
receiver=0x69c600, slot=0x0, slotObj=0x69c860, type=Qt::AutoConnection, 
types=0x0, 
senderMetaObject=0x7720c220 
)
at kernel/qobject.cpp:4784
  
  #5  0x76f1f249 in QObject::connect >(const 
QtPrivate::FunctionPointer::Object *, 
void (KWayland::Server::Display::*)(KWayland::Server::Display * const), const 
QObject *, KWayland::Server::Display::, Qt::ConnectionType) 
(sender=0x69d950,
  
signal=(void (KWayland::Server::Display::*)(KWayland::Server::Display * 
const)) 0x76fa67de , 
context=0x69c600, slot=..., 
type=Qt::AutoConnection) at /opt/kde5/include/QtCore/qobject.h:338

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6047

To: davidedmundson, #plasma
Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6418: [XDGV6] manage every ping sent

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6418#120319, @davidedmundson wrote:
  
  > > for how i did the kwin part, it must be who called it with discardTimer 
(this to allow kwin to receive 2 timeouts before deciding to kill the window)
  >
  > Ok, I see how it's meant to work but I don't understand why it's done like 
that.
  >
  > From what I see Kwayland can call "emit q->pingTimeout ; q->discardTimer() 
"  and your kwin code will still wait for 2 timeouts,
  
  
  in this case only one as the second timeout will never be emitted?
  what i could do, is chaning the timeout signature in pingTimeout(serial, 
attempt) so on kwayland-server part, it would emit timeout two times, then 
delte the timer by itself
  
  >> most of it is in private, just its creation is mostly identical in the 
implementation of ping in the subclasses
  > 
  > Yes, and I'm saying that bit could be shared as a method and called from 
the subclasses.
  
  +1

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6418

To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6418: [XDGV6] manage every ping sent

[Marco Martin]

mart updated this revision to Diff 15989.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  - get rid of discardPing

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6418?vs=15948=15989

BRANCH
  mart/xdgv6ping

REVISION DETAIL
  https://phabricator.kde.org/D6418

AFFECTED FILES
  autotests/client/test_xdg_shell.cpp
  src/server/xdgshell_interface.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_interface_p.h
  src/server/xdgshell_v5_interface.cpp
  src/server/xdgshell_v6_interface.cpp

To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6418: [XDGV6] manage every ping sent

[Marco Martin]

mart updated this revision to Diff 15997.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  - quint32 everywhere

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6418?vs=15989=15997

BRANCH
  mart/xdgv6ping

REVISION DETAIL
  https://phabricator.kde.org/D6418

AFFECTED FILES
  autotests/client/test_xdg_shell.cpp
  src/server/xdgshell_interface.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_interface_p.h
  src/server/xdgshell_v5_interface.cpp
  src/server/xdgshell_v6_interface.cpp

To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6518: guard against themes without a valid shadow

[Marco Martin]

mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  some themes don't have a valid shadow, which would lead
  to a crash in kwayland, don't even try to render a shadow
  if one of the elements is missing
  
  BUG:381953

TEST PLAN
  Doesn't crash anymore, i can't hellp but think something should be
  fixed in kwayland as well

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6518

AFFECTED FILES
  src/plasmaquick/dialogshadows.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6418: [XDGV6] manage every ping sent

[Marco Martin]

mart created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  if more ping arrives before a pong, store each of its
  serial and manage them one by one
  
  a new signal, pingTimeout emitted until explicitly stopped

TEST PLAN
  tests still pass, kwin modified to use it on window close
  and window focus gain works correctly.
  What is not tested: apps not answering to pings
  as usually the connection thread will still be
  running, so something to actually query the gui
  thread will be needed

REPOSITORY
  R127 KWayland

BRANCH
  mart/xdgv6ping

REVISION DETAIL
  https://phabricator.kde.org/D6418

AFFECTED FILES
  autotests/client/test_xdg_shell.cpp
  src/server/xdgshell_interface.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_interface_p.h
  src/server/xdgshell_v5_interface.cpp
  src/server/xdgshell_v6_interface.cpp

To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D6418: [XDGV6] manage every ping sent

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6418#120218, @davidedmundson wrote:
  
  > who deletes the qtimer if it times out?
  >
  > can this timer stuff be shared by moving it into XdgShellInterface::Private 
?
  
  
  for how i did the kwin part, it must be who called it with discardTimer (this 
to allow kwin to receive 2 timeouts before deciding to kill the window)
  most of it is in private, just its creation is mostly identical in the 
implementation of ping in the subclasses

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6418

To: mart, #plasma, davidedmundson, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D5593: Introduce units.iconSizeHints.* to provide user-configurable icon size hints

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5593

To: hein, #plasma, mart
Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5603: Install Plasma Components 3 so they can be used

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:45
>  
> -DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/plasma/components.3)
> +DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/plasma/components/3)

components.3 is actually what is searched for by the import system when 
importing  a versioned import (kirigami is doing this as well)

> qmldir:39
> +
> +BusyIndicator 3.0 3/BusyIndicator.qml
> +Button 3.0 3/Button.qml

the components.3 folder should have its own qmldir instead

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5603

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5605: Allow multiple categories with the same name

[Marco Martin]

mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  the category name was intended as a kind of unique id,
  this isn't true anymore, so multiple categories can have
  the same name (even if having a different display_name)
  this makes content listing of category names with
  multiple ids work

TEST PLAN
  on store.kde.org the category 399 is going to have the
  Plasma 5 Plasmoid name, tested with it and works (name
  got back to the old one now)

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5605

AFFECTED FILES
  src/attica/atticaprovider.cpp

To: mart, #plasma, leinir
Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5605: Allow multiple categories with the same name

[Marco Martin]

mart added a reviewer: whiting.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D5605

To: mart, #plasma, leinir, whiting
Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5603: Install Plasma Components 3 so they can be used

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  thanks, awesome now =)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5603

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6964: Force Plasma style for QQC2 in applets

[Marco Martin]

mart updated this revision to Diff 17325.
mart added a comment.


  comment useless debug

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6964?vs=17324=17325

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6964

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/packageurlinterceptor.cpp
  src/plasmaquick/packageurlinterceptor.h
  src/plasmaquick/view.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6964: Force Plasma style for QQC2 in applets

[Marco Martin]

mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  using the qml url interceptor, rewrite imports in order
  to load always the plasma styled qqc2 controls in plasmoids
  and plasma views. As is per-engine, is possible to load
  controls with qstyle theme in configuration dialogs
  and plasma style in plasmoids.
  
  Note: this replaces just the style org.kde.desktop
  to Plasma and not every style (so with Material
  set as QT_QUICK_CONTROLS_STYLE environment variable
  plasma would load controls with material style) because
  we can control both org.kde.desktop and Plasma styles:
  they must have the same subdirectories as unlike files,
  their existence is checked before the rewrite (in our case,
   "private"), so in order to work they must exist in both
  styles

TEST PLAN
  a qqc2 button in a plasmoid has the plasma style, in
  a config dialog has the qwidget style. rewrite works
  only from org.kde.desktop to Plasma and not from other
  styles, due to the existence of the "private" subdirectory

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6964

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/packageurlinterceptor.cpp
  src/plasmaquick/packageurlinterceptor.h
  src/plasmaquick/view.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6964: Force Plasma style for QQC2 in applets

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6964#129762, @davidedmundson wrote:
  
  > > ‎[13:51] ‎<‎notmart‎>‎ hmm, still random failures in loading components
  > > ‎[13:58] ‎<‎notmart‎>‎ gaah, import of a subdirectory still breaks
  >
  > Is this fixed?
  
  
  no, that's the problem of having to have a "private" subfolder in both themes 
i mentioned in the commit message, will need to look deeper in qml parsing to 
figure out what's going wrong and maybe patching qt, if both the style that we 
replace and the new one are controlled by us, that's workable around (as they 
happen to have the same directory structure) fragile but works
  
  > Also we'll need to maybe look at changing how kirigami does its theme stuff 
so we can make that work.
  
  kirigami does it exactly as qqc2 does, so should work as well. also in that 
case, we should make sure that both kirigami themes which we both control have 
the same directory structure

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6964

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6899#133625, @dfaure wrote:
  
  > "Show" is a bit of a historical name here, this isn't about showing apps in 
a menu...
  >
  > X-KDE-OnlyLoadOnQtPlatforms would be closer to the truth, no?
  >
  > Looks good otherwise.
  
  
  that would be a new key, would you prefer that version?

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D6899

To: mart, #frameworks, #plasma
Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6894

To: broulik, #plasma, mart
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7127: ignore spurious resize events to empty sizes

[Marco Martin]

mart updated this revision to Diff 17832.
mart added a comment.


  more comments

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7127?vs=17712=17832

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7127

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7127: ignore spurious resize events to empty sizes

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0c27df529d80: ignore spurious resize events to empty 
sizes (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7127?vs=17832=17834

REVISION DETAIL
  https://phabricator.kde.org/D7127

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7127: ignore spurious resize events to empty sizes

[Marco Martin]

mart added a comment.


  finally figured out where this event is generated:
  it's a spontaneous event generated in qguiapplication.cpp 
QGuiApplicationPrivate::processWindowScreenChangedEvent
  around line 2209 QWindowSystemInterfacePrivate::GeometryChangeEvent 
gce(window, QHighDpi::fromNativePixels(window->handle()->geometry(), window), 
QRect());
  
  this happens even before the first show event, right after the window has 
been created, the window is still 0x0, but the resize event gets delivered with 
0x0 again and executed with all the bad side effects
  this seems to happen for every window when there are multiple screens, so 
something we have probably to watch out for in the future

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7127

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

[Marco Martin]

mart added a comment.


  looking into it, i still think the dialog code is correct.
  what happens is that someone external resizes the notification window to 0x0 
pixels wide right after the componentcomplete event. if as in this patch the 
dialog is resized explicitly in componentcomplete, that other spurious resize 
(from 0x0 to 0x0 btw) doesn't happen anymore
  
  even tough I am still not sure where that resize event comes from (feeling 
like blaming either windowmanagement tough is weird as is still unmapped or qt 
xcb), I think a more correct patch, is https://phabricator.kde.org/D6964

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7071

To: matank, #plasma, davidedmundson
Cc: mart, plasma-devel, davidedmundson, ltoscano, #frameworks, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6964: Force Plasma style for QQC2 in applets

[Marco Martin]

mart updated this revision to Diff 17703.
mart added a comment.


  ignore resizes to empty sizes
  
  on multiscreen, it happens that notification windows areresized to 0,0
  by somebody else (not dialog code, perhaps kwin, perhaps notification applet
  
  this makes the notification main item lose track of its natural geometry
  causing bug 382340
  ignore those events as spurious (and resizing a window to 0x0 doesn't
  make sense anyways)
  
  with this, notifications on multi monitor systems with primary on the right 
are ok
  
  BUG:382340

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6964?vs=17325=17703

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6964

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/packageurlinterceptor.cpp
  src/plasmaquick/packageurlinterceptor.h
  src/plasmaquick/view.cpp

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6964: Force Plasma style for QQC2 in applets

[Marco Martin]

mart updated this revision to Diff 17706.
mart added a comment.


  remove unrelated changes

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6964?vs=17703=17706

BRANCH
  arcpatch-D6964

REVISION DETAIL
  https://phabricator.kde.org/D6964

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/packageurlinterceptor.cpp
  src/plasmaquick/packageurlinterceptor.h
  src/plasmaquick/view.cpp

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7127: ignore spurious resize events to empty sizes

[Marco Martin]

mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> broulik wrote in dialog.cpp:1045
> So it will never update its size? Shouldn't it be size == oldSize?

ouch, sure, sorry :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7127

To: mart, #plasma
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7127: ignore spurious resize events to empty sizes

[Marco Martin]

mart updated this revision to Diff 17712.
mart added a comment.


  - fix check

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7127?vs=17704=17712

BRANCH
  arcpatch-D7127

REVISION DETAIL
  https://phabricator.kde.org/D7127

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mart, #plasma
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7127: ignore spurious resize events to empty sizes

[Marco Martin]

mart marked an inline comment as done.
mart added a comment.


  not sure how to proceed in debugging this, as all i have is a resize event 
handler being called, which a backtrace there is useless to figure out who is 
resizing it

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7127

To: mart, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart updated this revision to Diff 18596.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  - Don't call release twice
  - Correctly set
  - don't call destroy in the destroyed callback
  - add a test exporting a surface two times
  - test importing two times the same surface
  - wrap XdgForeignUnstableV1 to XdgForeignUnstable
  - unexport classes that should be private

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7369?vs=18357=18596

BRANCH
  mart/xdgforeign

REVISION DETAIL
  https://phabricator.kde.org/D7369

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_foreign.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-foreign-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgforeign.cpp
  src/client/xdgforeign.h
  src/client/xdgforeign_p.h
  src/client/xdgforeign_v1.cpp
  src/client/xdgforeign_v1.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgforeign_interface.cpp
  src/server/xdgforeign_interface.h
  src/server/xdgforeign_v1_interface.cpp
  src/server/xdgforeign_v1_interface_p.h

To: mart, #plasma, #kwin, davidedmundson
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart added a comment.


  now the client part is wrapped too, so no V1 exported (the public facing 
classes should lose "Unstable" probably)
  two more tests to check that importing the same exported in two clients works 
and exporting the same surface two times works as well.
  thanks to david's help most of the random crashes are fixed, there is still 
to solve one crash at exit of the autotest and the warning message:
  wl_display@1: error 0: invalid object 9 in a couple of autotests, which still 
suggests something wrong.
  
  i think it's getting near feature completness to implement the kwin part tough

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7369

To: mart, #plasma, #kwin, davidedmundson
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7369

To: mart, #plasma, #kwin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> xdgforeign_v1_interface.cpp:212
> +QHash parents;
> +QHash children;
> +

the children hash may have to become a multihash to permit more children for a 
single parent

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7369

To: mart, #plasma, #kwin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Implement the "foreign" wayland protocol.
  A client can export a surface with an unique string as handle,
  then another client can refer to that surface and set an own surface as
  child of that surface.
  Potential use cases are out-of-process dialogs, such as file dialogs,
  meant to be used by sandboxed processes that may not have the access
  it needs to implement such dialogs.
  The handle needs to be shared between the processes with other means,
  such as dbus or command line paramenters

TEST PLAN
  the autotest works, but has a lot of random crashes when deleting surfaces,
  unfortunately backtraces don't tell much and the crashes never occur when 
running into valgrind
  behavior may still be wrong, depending on how the protocol is supposed
  to work if more clients try to set the same exported surface as parent

REPOSITORY
  R127 KWayland

BRANCH
  mart/xdgforeign

REVISION DETAIL
  https://phabricator.kde.org/D7369

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_foreign.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-foreign-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgforeign_v1.cpp
  src/client/xdgforeign_v1.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgforeign_v1_interface.cpp
  src/server/xdgforeign_v1_interface.h
  src/server/xdgforeign_v1_interface_p.h

To: mart, #plasma, #kwin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart marked 2 inline comments as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in xdgforeign_v1_interface.cpp:299
> this should be connected to unbound.

perhaps the connects to the destruction of the SurfaceInterface* are not even 
necessary?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7369

To: mart, #plasma, #kwin, davidedmundson
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D7369: [WIP] Wayland foreign protocol

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> graesslin wrote in registry.h:938-939
> The general pattern I used for protocols which might get another revision is 
> to create a "meta" class which hides the UnstableV1 mess. C.f. the 
> PointerConstraints a line above.

i see the types are named zxdg_exporter_v1 because it's how the interface is 
calledin the wayland protocol xml.
woudl i need to make another copy of the xml where the interface name is 
unversioned?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7369

To: mart, #plasma, #kwin, davidedmundson
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D5783: Use application name instead of pid when creating SNI dbus service

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  definitely better!
  i don't know whether we can afford to change it in any way outside the sanbox 
and not break things..
  it may make sense to use applicationName-pid at least inside the sandbox, 
maybe outside as well if affordable?
  (so you would have applicationName-1 applicationName-2 etc in the sandbox 
which still make sense

REPOSITORY
  R289 KNotifications

BRANCH
  application-dbus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5783

To: jgrulich, apol, mart
Cc: mart, #frameworks

D5806: [WIP] when building menu hyerarchies, parent menus to their containers

[Marco Martin]

mart retitled this revision from "[WIP] when building menu hierarchies, parent 
menus to their containers" to "[WIP] when building menu hyerarchies, parent 
menus to their containers".

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D5806

To: mart, #plasma, #plasma_on_wayland, #frameworks
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5806: [WIP] when building menu hierarchies, parent menus to their containers

[Marco Martin]

mart added reviewers: Plasma on Wayland, Frameworks.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D5806

To: mart, #plasma, #plasma_on_wayland, #frameworks
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5806: [WIP] when building menu hierarchies, parent menus to their containers

[Marco Martin]

mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Wayland requires menu windows to have a "transient parent" as wl_shell
  protocol refuses to either position correcty or assign the corrent
  flags to popup windows that don't have a parent.
  a lot of popup menus in KDE applications don't have any parent
  and will look wrong in wayland. this fixes at least some of the occurrences
  of popup menus build by kxmlgui

TEST PLAN
  "Bookmarks" menu in konsole menubar is now correct in
  wayland

REPOSITORY
  R263 KXmlGui

BRANCH
  phab/reparentmenus

REVISION DETAIL
  https://phabricator.kde.org/D5806

AFFECTED FILES
  src/kxmlguifactory_p.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5783: Use application name instead of pid when creating SNI dbus service

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  are we sure applicationname is unique? what about of multiple instances of 
the same application?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D5783

To: jgrulich, apol, mart
Cc: mart, #frameworks

D5783: Use application name instead of pid when creating SNI dbus service

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  are we sure applicationname is unique? what about of multiple instances of 
the same application?

REPOSITORY
  R289 KNotifications

BRANCH
  application-dbus (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5783

To: jgrulich, apol, mart
Cc: mart, #frameworks

D5806: When building menu hyerarchies, parent menus to their containers

[Marco Martin]

mart added a comment.


  possible fix https://phabricator.kde.org/D5900

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D5806

To: mart, #plasma, #plasma_on_wayland, #frameworks, davidedmundson
Cc: lbeltrame, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5900: use transientparent directly

[Marco Martin]

mart created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  don't parent directly as we don't want unwanted deletions.
  ensure we have a menu, not parented yet, the container exists,
  both the menu and the container's toplevel widget QWindows exist,
  then set the transient parent of the qmenu's qwindow to the
  container's toplevel widget's qwindow. this fixes positioning in
  wayland as the protocol requires every popup menu having a transient parent

TEST PLAN
  okular doesn't crash anymore, konsole's bookmarks menu still
  correctly positioned in wayland

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5900

AFFECTED FILES
  src/kxmlguifactory_p.cpp

To: mart
Cc: #frameworks

D5900: use transientparent directly

[Marco Martin]

mart updated this revision to Diff 14630.
mart added a comment.


  call windid only once

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5900?vs=14629=14630

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5900

AFFECTED FILES
  src/kxmlguifactory_p.cpp

To: mart
Cc: #frameworks

D5900: use transientparent directly

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:4690808e65f1: use transientparent directly (authored by 
mart).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5900?vs=14630=14631

REVISION DETAIL
  https://phabricator.kde.org/D5900

AFFECTED FILES
  src/kxmlguifactory_p.cpp

To: mart, lbeltrame
Cc: lbeltrame, #frameworks

D5745: recreate plasmashellsurf on exposed, destoy on hidden

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fd2e850156ac: recreate plasmashellsurf on exposed, destoy 
on hidden (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5745?vs=14435=14436

REVISION DETAIL
  https://phabricator.kde.org/D5745

AFFECTED FILES
  src/declarativeimports/core/tooltipdialog.cpp
  src/plasmaquick/dialog.cpp

To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5745: recreate plasmashellsurf on exposed, destoy on hidden

[Marco Martin]

mart updated this revision to Diff 14435.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  comments

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5745?vs=14247=14435

BRANCH
  arcpatch-D5745

REVISION DETAIL
  https://phabricator.kde.org/D5745

AFFECTED FILES
  src/declarativeimports/core/tooltipdialog.cpp
  src/plasmaquick/dialog.cpp

To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5773: [WIP] workarounds for menu positioning

[Marco Martin]

mart updated this revision to Diff 14438.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  - more aggressive reparenting in open()

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5773?vs=14311=14438

BRANCH
  arcpatch-D5773

REVISION DETAIL
  https://phabricator.kde.org/D5773

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp

To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5757: add requestToggleKeepAbove/below

[Marco Martin]

mart updated this revision to Diff 14581.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  - fix comment

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5757?vs=14320=14581

BRANCH
  arcpatch-D5757

REVISION DETAIL
  https://phabricator.kde.org/D5757

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h

To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, lukas

D5757: add requestToggleKeepAbove/below

[Marco Martin]

mart updated this revision to Diff 14582.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.


  - fix comment

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5757?vs=14581=14582

BRANCH
  arcpatch-D5757

REVISION DETAIL
  https://phabricator.kde.org/D5757

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h

To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5757: add requestToggleKeepAbove/below

[Marco Martin]

mart marked 2 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5757

To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5773: [WIP] workarounds for menu positioning

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:680a8a9e2832: [WIP] workarounds for menu positioning 
(authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5773?vs=1=14445

REVISION DETAIL
  https://phabricator.kde.org/D5773

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp

To: mart, #plasma, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5806: When building menu hyerarchies, parent menus to their containers

[Marco Martin]

mart retitled this revision from "[WIP] when building menu hyerarchies, parent 
menus to their containers" to "When building menu hyerarchies, parent menus to 
their containers".

REPOSITORY
  R263 KXmlGui

BRANCH
  phab/reparentmenus

REVISION DETAIL
  https://phabricator.kde.org/D5806

To: mart, #plasma, #plasma_on_wayland, #frameworks, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5773: [WIP] workarounds for menu positioning

[Marco Martin]

mart updated this revision to Diff 1.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  - remove duplication

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5773?vs=14438=1

BRANCH
  arcpatch-D5773

REVISION DETAIL
  https://phabricator.kde.org/D5773

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp

To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, 
lukas

D5806: When building menu hyerarchies, parent menus to their containers

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:b5af0296cb2f: When building menu hyerarchies, parent 
menus to their containers (authored by mart).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5806?vs=14384=14446

REVISION DETAIL
  https://phabricator.kde.org/D5806

AFFECTED FILES
  src/kxmlguifactory_p.cpp

To: mart, #plasma, #plasma_on_wayland, #frameworks, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  ping?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6215#117498, @davidedmundson wrote:
  
  > > this will work only when the Dialog' version of setvisible is called,
  >
  > So this will break released Plasma?
  
  
  no, it just means that who calls show() or the wrong setVisible() would just 
get the previous behavior of mainItem being shown only at showevent, so with 
the potential resize/position glitch that is already in now, but setvisible 
gets called both there and in the showevent, so it wouldn't significantly break 
(just in most common case, the second setvisible would be a noop)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart edited the summary of this revision.
mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  so, on the 5 points:
  
  1. yes, is necessary, resizing windows in their show event is definitely not 
enough, causes events to arrive to reset to the old geometry in race with the 
setgeometry done there, if it's the qpa, if it's qwindow, if it's the 
windowmanager doing that i have no idea, i have spent a week looking into that 
and really don't want to dive more in that spaghetti, more than accepting "qt 
wants sizes set before the showevent, move is fine" as a fact and adapting to it
  2. no it's not doing that anymore, all it changes is having 
syncToMainItemSize/updateLayoutParameters actually work when they are called 
with the window not visible, exactly because of 1)
  3. yeah, perhaps it should do it in a separate commit, and should be done 
everywhere a plasmashellsurface is used, or you will have wrong positions after 
hide/show that don't cause a moveevent
  4. as i explained in https://phabricator.kde.org/D6216, not strictly 
necessary, but avoids many bindings and resizes that happen when the window 
gets shown and hidden, that shouldn't be seen by the user anyways but useless 
never the less
  5. is done for a specific scenario (that is seen in the dbusnotificationtest 
manual test in knotifications) A notification is visible, and its content is 
replaced while still visible, so the actions gets removed, the window gets 
resized, all notifications gets rearranged, then actions populated again, 
window resized again, all notifications resized again. it is not strictly a 
bug, the whole procedure looks ugly and glitchy, especially if the number of 
actions after repopulating is the same, no resize or reposition of 
notifications should happen at all.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:eab4aa9909a6: Make sure size is final after showEvent 
(authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6215?vs=15579=15682

REVISION DETAIL
  https://phabricator.kde.org/D6215

AFFECTED FILES
  src/declarativeimports/core/tooltip.cpp
  src/plasmaquick/dialog.cpp

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

Re: Kirigami in Frameworks

[Marco Martin]

As there were no replies for quite a while, i assume there are no
particular objections.

so, how to proceed? what needs to be doe to do the actual move?

On Mon, Jun 5, 2017 at 2:42 PM, Marco Martin <notm...@gmail.com> wrote:
> Hi all,
> The Kirigami component set always was targeted to be eventually released as a
> framework, ideally tier 1. since a framework must depend at most from 2 Qt
> releases before the current one, it couldn't be released there yet.
> Now that Qt 5.9 is released, i would like to propose to move Kirigami in
> frameworks, to be relased in the main release cycle, and stop standalone
> releases from extragear.
>
> It strictly depends just from Qt stuff, so should be tier 1 (at runtime it can
> use optional styles that use features from Plasma, tough not having plasma
> installed doesn't touch its functionality in any part, if this ends up being a
> problem, i can move that style into plasma-integration)
>
> --
> Marco Martin

Re: Kirigami in Frameworks

[Marco Martin]

whops, forgot cc to kde-frameworks, resending
On Sat, Jun 24, 2017 at 10:58 AM, David Faure <fa...@kde.org> wrote:
> On lundi 5 juin 2017 14:42:47 CEST Marco Martin wrote:
>> Hi all,
>> The Kirigami component set always was targeted to be eventually released as
>> a framework, ideally tier 1. since a framework must depend at most from 2
>> Qt releases before the current one, it couldn't be released there yet. Now
>> that Qt 5.9 is released
>
> Given the LTS nature of Qt 5.6 I'd like to keep 5.6 as a base requirement 
for the
> other frameworks for a bit longer if possible, but this doesn't prevent 
kirigami
> from requiring Qt 5.7.
> This Qt version difference creates an issue for the CI though, as can be
> seen at https://build.kde.org/job/kirigami%20master%20stable-kf5-qt5/

so it could be released as a framework anyways, good 
If it helps, I could even let it build under 5.6, as everything that
depends on 5.7 are qml files, which is a runtime dependency (on a 5.6
system would just install a bunch of dead code in form of qml files)
Alternatively, there is still an old branch around that works on Qt
5.6, is pretty much dead, but we still do a bugfix in there every now
and then, that one could be built on the 5.6 version of ci

>> It strictly depends just from Qt stuff, so should be tier 1 (at runtime it
>> can use optional styles that use features from Plasma, tough not having
>> plasma installed doesn't touch its functionality in any part, if this ends
>> up being a problem, i can move that style into plasma-integration)
>
> I just cleaned up the toplevel CMakeLists.txt a bit, but I found an issue 
there:

oh, thanks you 

> it checks for KF5Declarative_FOUND but doesn't do a find_package for that 
component, so this looks pretty useless.
> Since DESKTOP_ENABLED is on by default, what's the point of that 
if(KF5Declarative_FOUND AND THEME STREQUAL "System") ?

uh, leftover, both checks on THEME can be removed safely

as DESKTOP_ENABLED and PLASMA_ENABLED install stuff that has more
dependencies (always runtime tough and just for the looks, never new
api/functionality) is it ok leaving it there built conditionally
(easier to maintain) or should be splitted in another repo?

> I noticed that DESKTOP_ENABLED installs a file called styles/org.kde.desktop,
> which matches a runtime error I've seen for some time now, e.g. at QtCreator 
startup:
> QtCreator(12888)/default QQuickControlSettings1::QQuickControlSettings1: 
WARNING: Cannot find style "org.kde.desktop" - fallback: 
"/d/qt/5/kde/build/qtbase/qml/QtQuick/Controls/Styles/Desktop"

basically kirigami has a style that is called org.kde.desktop for
desktop systems, that matches the style we did for QtQuickControls2
for desktop systems as well, as Qt is not interested to do a desktop
specific style for qtquickcontrols2 themselves,
however,
the environment variable to set the style of both qtquickcontrols1 and
2 style is QT_QUICK_CONTROLS_STYLE, which we set in startkde

the default style for QtQuickControlsStyle1 is "Desktop"
we could have called this style "Desktop" as well so all would have
aligned nicely, but that could be quite dangerous, as Qt coulddecide
any moment that they indeed want to do a style called "Desktop" for
qqc2, at which point it would conflict, so having the org.kde prefix
was the safe route.

QtQuickControls1 at this moment doesn't find org.kde.desktop, so just
falls back to its default "Desktop" and everything keeps working as
expected. One way to silence this could be when the qtquickcontrols2
theme installs into qt's qqc2, to install also an org.kde.desktop
symlink in QtQuickControls1 that just points to "Desktop" (note that
style is not in the kirigami repository, kirigami has themes with the
same name because it's an extension on top of qtquickcontrols2)

> I enabled BUILD_EXAMPLES and got a nice example "kirigami2gallery" built as 
a result, but why is it under the android subdirectory?

It has some android specific things, like providing a manifest.xml and
some optional qtandroidextras usage for integration when compiled
there, but it's intended to be multiplatform, so may make sesie to
enable it.

talking about examples, do you think is better to build them with a
flag on the top cmake as is now, or provide a separate standalone
cmake file under examples/ ?

--
Marco Martin

D6047: WIP: Support XDG v6

[Marco Martin]

mart added a comment.


  trying to implement the kwin part of ping btw, will do in a branch of the 
branch kwin/xdgv6

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6047

To: davidedmundson, #plasma
Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas

D6313: WIP: Support device pixel ratio in icon loader and engine

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6313#118285, @kvermette wrote:
  
  > Behaviorally speaking there's justification for ensuring SVGs are treated 
the same as PNGs in this case. Looking at the code we aren't shimming the SVGs 
specifically (unless I'm missing something), but I just wanted to chime in with 
this and nip special treatment for SVGs in the bud. In maintaining the Aether 
icon theme I would create links to the higher resolution icons, so you'd see 
something like a "16x16x2" folder point to my "32x32" 'native' folder, and a 
"16x16x3"->"48x48" folder, "32x32x2"->"64x64", etc. Just because we *can* scale 
SVG icons doesn't mean that behavior should be assumed, should the icon set 
have higher fidelity icons ready for HiDPI.
  
  
  i think for svgs 16x16x2 should be preferred over scaling by 2 the 16x16 
version, but still, scaling the 16x16 version should still be preferred over 
the 32x32 version, so this patch is on the right rirection

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: mart, kvermette, cfeck, davidedmundson, plasma-devel, #frameworks, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Re: Kirigami in Frameworks

[Marco Martin]

On Sat, Jun 24, 2017 at 3:27 PM, David Faure <fa...@kde.org> wrote:
>> the default style for QtQuickControlsStyle1 is "Desktop"
>> we could have called this style "Desktop" as well so all would have
>> aligned nicely, but that could be quite dangerous, as Qt coulddecide
>> any moment that they indeed want to do a style called "Desktop" for
>> qqc2, at which point it would conflict, so having the org.kde prefix
>> was the safe route.
>
> Well, we could also rename ours when/if the conflict occurs?

since the conflict would be of installed files, it would make released
version not installable, which looks to me like too big of a risk.

>> One way to silence this could be when the qtquickcontrols2
>> theme installs into qt's qqc2
>
> If you mean $QTDIR, that's not my case. The plugin is found via
> QML2_IMPORT_PATH I suppose.

qtquickcontrols2 will be installed under QML2_IMPORT_PATH and we need
to install under that folder

>> , to install also an org.kde.desktop
>> symlink in QtQuickControls1 that just points to "Desktop" (note that
>> style is not in the kirigami repository, kirigami has themes with the
>> same name because it's an extension on top of qtquickcontrols2)
>
> That sounds good, if it can be done.

setting a symlink there seems to just work, so i would try to go for that route

>> It has some android specific things, like providing a manifest.xml and
>> some optional qtandroidextras usage for integration when compiled
>> there, but it's intended to be multiplatform, so may make sesie to
>> enable it.
>
> Then I don't think it should be under an android subdir.
> A multiplatform app with extra stuff for android integration is still
> multiplatform in the first place.

sure, renaming it to multipletform then :)

>> talking about examples, do you think is better to build them with a
>> flag on the top cmake as is now, or provide a separate standalone
>> cmake file under examples/ ?
>
> Much better the way you did it, it's how I see it done in most other
> frameworks.
> It makes it easy to enable the building of examples once and for all in
> kdesrc-buildrc for instance, to make sure they keep compiling and so that they
> are available for testing.
> In fact, I wonder if the CI shouldn't set BUILD_EXAMPLES=ON in all frameworks
> that have that option... (4 currently, 5 with kirigami).

ok

--
Marco Martin

D6047: WIP: Support XDG v6

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> graesslin wrote in xdgshell_interface.h:80
> @davidedmundson  for the ping you could check the old wl_shell_surface 
> implementation in KWayland.

the implementation here in xdgshell_interface is basically copied over the 
kwayland  wl_shell_surface.

the code pasted above, is the only kwin part i found that was managing pings in 
any way, which is the x11 implementation (Client)
i guess ShellClient will have to have something along the lines using the 
kwayland implementations, tough casing between the possible interfaces exposed 
(wl_shell, xdgshellv5 and xdgshellv6)

> graesslin wrote in xdgshell_interface.h:75
> what is "gravity"?

as far i understood, it's an hint that tells the window the direction it 
prefers to popup, so like "please dear compositor make it show below the point 
i asked to", or at the left, or whatever
hint that the compositor can choose to ignore

REVISION DETAIL
  https://phabricator.kde.org/D6047

To: davidedmundson, #plasma
Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Re: Kirigami in Frameworks

[Marco Martin]

On Wed, Jun 21, 2017 at 6:22 PM, Jonathan Riddell <j...@jriddell.org> wrote:
> On 21 June 2017 at 15:00, Marco Martin <notm...@gmail.com> wrote:
>> As there were no replies for quite a while, i assume there are no
>> particular objections.
>>
>> so, how to proceed? what needs to be doe to do the actual move?
>
> Does it comply with the policies (as much as they are relevant for QML)?
> https://community.kde.org/Frameworks/Policies

yeah, it should for pretty much all rules

> Get David Faure to give his approval then see what the reponse to my
> "who is authorised to move repos around?" thead is.
> https://marc.info/?l=kde-core-devel=149806172721190=2



ok, waiting David's comment on it.

--
Marco Martin

D6047: WIP: Support XDG v6

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6047#119765, @graesslin wrote:
  
  > In https://phabricator.kde.org/D6047#119698, @mart wrote:
  >
  > > trying to implement the kwin part of ping btw, will do in a branch of the 
branch kwin/xdgv6
  >
  >
  > no need to hurry with it. IMHO the way ping works is completely broken and 
won't work. At least Qt holds the connection in a thread, so it will react to 
the ping even if the application is frozen in the main gui thread.
  
  
  any way to change this/make the gui thread actually answer?
  
  > Also please note that ping needs to be different in Wayland compared to 
X11. In X11 we only ping when trying to close the window. In Wayland we should 
ping whenever we interact with the window in some way. E.g. when we pass 
pointer focus, when we pass keyboard focus, maybe even when sending in input 
events.
  
  if it's done in all input events, couldn't this affect performance?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6047

To: davidedmundson, #plasma
Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5914: Add template for Plasma QML Applet with QML extension

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  addtemplateforplasmoidwithqmlplugin

REVISION DETAIL
  https://phabricator.kde.org/D5914

To: kossebau, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5912: minimize dialog resizes/moves

[Marco Martin]

mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  take into account size hints also when adjusting with synctomainitemsize
  which sometimes has to be executed right before adjusting from the layout
  hints, giving one wrong resize
  
  introduce geometryUpdatesBlocked, which stops the dialog
  from syncing which is useful when both visual parent and item
  contents gets updated in one go (the tooltip) it is not
  yet exported to qml and it shouldn't as is dangerous, but
  kicker may make use of it between changing the submenu model and
  the visualparent
  
  alternative implementations may be:
  
  - a method that takes both main item and visual parent
  - delaying with a timer setGeometry (ouch)
  
  this part can also be left behind for now and see if the rest is good enough

TEST PLAN
  no visual glitches visible anymore in wayland when moving the tooltip
  in the taskbar, x11 ok too

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/dialogresize

REVISION DETAIL
  https://phabricator.kde.org/D5912

AFFECTED FILES
  src/declarativeimports/core/tooltip.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialog.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5757: add requestToggleKeepAbove/below

[Marco Martin]

mart added a comment.


  ping?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5757

To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5757: add requestToggleKeepAbove/below

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:e8e88174571c: add requestToggleKeepAbove/below (authored 
by mart).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5757?vs=14582=14807

REVISION DETAIL
  https://phabricator.kde.org/D5757

AFFECTED FILES
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h

To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5912: minimize dialog resizes/moves

[Marco Martin]

mart updated this revision to Diff 14809.
mart added a comment.


  - use settype, not setflags

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5912?vs=14690=14809

BRANCH
  arcpatch-D5912

REVISION DETAIL
  https://phabricator.kde.org/D5912

AFFECTED FILES
  src/declarativeimports/core/tooltipdialog.cpp
  src/plasmaquick/dialog.cpp

To: mart, #plasma, hein, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5912: minimize dialog resizes/moves

[Marco Martin]

mart added a comment.


  ping?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5912

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5912: minimize dialog resizes/moves

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in tooltipdialog.cpp:45
> Calling set flags explicitly and set type explicitly is conflicting.

now just uses settype, tested on x11, still works and tooltip windows still has 
_NET_WM_WINDOW_TYPE_TOOLTIP
settype is needed in wayland as it uses the plasmashell protocol to set it as a 
parentless tooltip

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5912

To: mart, #plasma, hein, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5912: minimize dialog resizes/moves

[Marco Martin]

mart updated this revision to Diff 14688.
mart added a comment.


  - remove updategeometryblocked

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5912?vs=14674=14688

BRANCH
  phab/dialogresize

REVISION DETAIL
  https://phabricator.kde.org/D5912

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5912: minimize dialog resizes/moves

[Marco Martin]

mart added a comment.


  now tooltips are animated again

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5912

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5918: set transientparent for menus

[Marco Martin]

mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  set transient parent for popup menus created by appletinterface/
  containmentinterface, it makes them appear at the proper coordinates

TEST PLAN
  containment menus appear where the mouse was pressed

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/popupparents

REVISION DETAIL
  https://phabricator.kde.org/D5918

AFFECTED FILES
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5918: set transientparent for menus

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D5918#110833, @davidedmundson wrote:
  
  > Please test under x.
  
  
  no noticeable difference in x

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5918

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas