D22675: Search for the plugin of the other plasmoid

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0e859870a9bc: Search for the plugin of the other plasmoid (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D22675: Search for the plugin of the other plasmoid

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY Some applets use completely the code of another one with the key X-Plasma-RootPath. At the

D22546: Add missing components in org.kde.plasma.components 3.0

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22546 To: apol, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22083: introduce concept of header and footer for kpageview

mart added a comment. In D22083#496446 , @ngraham wrote: > Lovely. Looks perfect in Dolphin, Kate, Konsole, Okular, Gwenview, and Kile. > > Ark and Spectacle also need to be adapted, like kcmshell. Anything not using KPageView properly will

D22488: invoke QIcon::setFallbackThemeName a bit later

mart updated this revision to Diff 61857. mart added a comment. - nitialize REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22488?vs=61855=61857 BRANCH phab/qqcicons REVISION DETAIL https://phabricator.kde.org/D22488 AFFECTED FILES

D22488: invoke QIcon::setFallbackThemeName a bit later

mart edited the summary of this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D22488 To: mart, #frameworks, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22488: invoke QIcon::setFallbackThemeName a bit later

mart marked an inline comment as done. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D22488 To: mart, #frameworks, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22488: invoke QIcon::setFallbackThemeName a bit later

mart updated this revision to Diff 61855. mart added a comment. - use a local static REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22488?vs=61854=61855 BRANCH phab/qqcicons REVISION DETAIL https://phabricator.kde.org/D22488 AFFECTED FILES

D22488: invoke QIcon::setFallbackThemeName a bit later

mart created this revision. mart added reviewers: Frameworks, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY invoking QIcon::setFallbackThemeName at QCoreApplication ctor with

D22083: introduce concept of header and footer for kpageview

mart added a comment. this makes it look almost pixel perfect F7031708: Screenshot_20190716_115035.png tough introduces a behavior change: moves the responsibility of adding margins from the outer layout to the internal one, making some users

D22083: introduce concept of header and footer for kpageview

mart updated this revision to Diff 61844. mart added a comment. - introduce concept of header and footer for kpageview - adress code style comments - use rowspan and colspan to add margins in the right places REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D22083: introduce concept of header and footer for kpageview

mart added a comment. can this part go forward? I think ui-wise looks fine even if the other parts won't make it for release? (still hope they will tough :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22083 To: mart, #plasma, #frameworks, #vdg Cc:

D22083: introduce concept of header and footer for kpageview

mart added a comment. code issues are fixed. Now for removing the further margin around the whole window: should that be done here or in breeze? if done here, it may make it look bad on all other widget styles? REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D22083: introduce concept of header and footer for kpageview

mart reopened this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22083 To: mart, #plasma, #frameworks, #vdg Cc: hpereiradacosta, cfeck, ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22083: introduce concept of header and footer for kpageview

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. mart marked 3 inline comments as done. Closed by commit R236:fd5899d49d01: adress code style comments (authored by mart). CHANGED PRIOR TO

D22083: introduce concept of header and footer for kpageview

mart updated this revision to Diff 61206. mart added a comment. - introduce concept of header and footer for kpageview - adress code style comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22083?vs=60603=61206 BRANCH mart/pageviewfooter

D22265: KPluginMetaData: use Q_DECLARE_METATYPE

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D22265 To: apol, #frameworks, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22267: ContainmentAction: Fix loading from KPlugin

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22267 To: apol, #plasma, #frameworks, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22258: Improve plugin caching

mart accepted this revision. mart added a comment. move implementation out of definition and then ready to go REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22258 To: apol, #plasma, davidedmundson, mart Cc: davidedmundson, mart,

D22258: Improve plugin caching

mart added inline comments. INLINE COMMENTS > broulik wrote in pluginloader.cpp:120 > Remove or use categorized logging let's go with categorized REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22258 To: apol, #plasma Cc: mart, broulik,

D22257: performance, Qt API

mart accepted this revision. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D22257 To: apol, #frameworks, davidedmundson, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22250: get rid of blockSignals

This revision was automatically updated to reflect the committed changes. Closed by commit R296:087be3e4f4be: get rid of blockSignals (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22250?vs=61096=61097 REVISION DETAIL

D22250: get rid of blockSignals

mart added a reviewer: Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22250 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22250: get rid of blockSignals

mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY Don't call blockSignals, but instead, to avoid an infinite signal chain, check KCoreConfigSkeleton::configChanged wasn't

D22147: Better use of Qt APIs in Plasma::Theme

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D22147 REVISION DETAIL https://phabricator.kde.org/D22147 To: apol, #plasma, #frameworks, mart Cc: bruns, tcanabrava, fvogt, broulik,

D22083: introduce concept of header and footer for kpageview

mart added a comment. In D22083#487566 , @hpereiradacosta wrote: > ather simple and attached. Feel free to add this or something similar to any other modification you plan to do. F6938398: patch.diff >

D22083: introduce concept of header and footer for kpageview

mart added a comment. In D22083#487307 , @hpereiradacosta wrote: > On the breeze side, asside from the layout margins/spacing issues, there is at least one hard-coded pixel in the frame rendering that must be removed. In fact I have this

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

mart accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22076 To: broulik, #plasma, mart, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22049: pluginloader: Change behavior of X-KDE-ParentApp

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22049 To: bshah, mart, apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22083: introduce concept of header and footer for kpageview

mart added a comment. white background and part of margins removal will have to probably be in breeze style F6931480: Screenshot_20190624_184812.png REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22083 To: mart,

D22083: introduce concept of header and footer for kpageview

mart created this revision. mart added reviewers: Plasma, Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY put the dialog buttons in the footer for kpagedialog this is the first step

D21378: Make Breeze Light/Dark use more system colors

mart added a comment. the idea is kinda nice and with some schemes it will work just perfect... however i think it risks a lot of having loss in contrast on certain color schems with your patch try for instance breezedark and the honeycomb system theme, the current task highlight would

D21350: plasmacore: fix qmldir, ToolTip.qml no longer part of module

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH cleancoreqmldir REVISION DETAIL https://phabricator.kde.org/D21350 To: kossebau, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21355: Fix qmldir files

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH improveqmldirs REVISION DETAIL https://phabricator.kde.org/D21355 To: kossebau, #plasma, davidedmundson, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21001: Update *.qmltypes to current API of QML modules

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH updateqmltypes REVISION DETAIL https://phabricator.kde.org/D21001 To: kossebau, #plasma, apol, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21175: FrameSvgPrivate::generateBackground: generate background also if reqp != p

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixgeneratebackground REVISION DETAIL https://phabricator.kde.org/D21175 To: kossebau, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH makehaselementprefixmatchexpectation REVISION DETAIL https://phabricator.kde.org/D21174 To: kossebau, #plasma, mart Cc: apol, kde-frameworks-devel, michaelh,

D21183: search in the new location for knsrc files

This revision was automatically updated to reflect the committed changes. Closed by commit R252:e0df1f28231c: search in the new location for knsrc files (authored by mart). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21183?vs=57997=58001

D21183: search in the new location for knsrc files

mart updated this revision to Diff 57997. mart added a comment. use configSearchLocations REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21183?vs=57993=57997 BRANCH phab/newlocation REVISION DETAIL https://phabricator.kde.org/D21183

D21183: search in the new location for knsrc files

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY search in the new knsrc location, still fallback to the old one for compatibility TEST PLAN

D21115: [KCModuleQML] Fix typo breaking implicitWidth for modules

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D21115 To: broulik, #plasma, mart Cc: heikobecker, kde-frameworks-devel, michaelh, ngraham, bruns

D20839: AppStream generation: make sure we look up for the package structure on packages that have metadata.desktop/json too

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D20839 To: apol, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20665: use the base implementation hints

This revision was automatically updated to reflect the committed changes. Closed by commit R296:d9a0365ccc49: use the base implementation hints (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20665?vs=56534=56535 REVISION DETAIL

D20665: use the base implementation hints

mart updated this revision to Diff 56534. mart retitled this revision from "Use the base implementation hints" to "use the base implementation hints". mart edited the summary of this revision. mart added a comment. - remove visual debug REPOSITORY R296 KDeclarative CHANGES SINCE LAST

D20665: use the base implementation hints

mart added a comment. F6779963: Screenshot_20190418_164550.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20665 To: mart, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20665: use the base implementation hints

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY with latest kirigami master and kcmutils, the default size hints of scrollablepage are

D20283: [RFC] [SimpleKCM] Fix height calculation

mart added a comment. so, now on master Kirigami should have correct contentHeight and implicitHeight/implicitWidth for Page andScrollablePage. this means that this patch *should* be not necessary anymore (only thing that should happen, is ro remove completely implicitWidth/implicitheight

D20283: [RFC] [SimpleKCM] Fix height calculation

mart added inline comments. INLINE COMMENTS > SimpleKCM.qml:55 > ++ bottomPadding > ++ (header && header.visible ? header.height + header.topPadding + > header.bottomPadding : 0) > ++ (footer && footer.visible ? footer.height + footer.topPadding + > footer.bottomPadding

D20594: Fix MobileTextSelection namespacing

mart added a comment. sorry, didn't notice it :( REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20594 To: broulik, #plasma, mart, hein, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20570: [FrameSvgItem] Respect smooth property

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > framesvgitem.cpp:95 > { > +setFiltering(filtering); > m_lastParent->appendChildNode(this); could have here frameSvg->smooth() ? QSGTexture::Linear :

D20570: [FrameSvgItem] Respect smooth property

mart added a comment. FrameItemNode needs the same REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20570 To: broulik, #plasma Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D20478: Breeze desktoptheme clock: support hand shadow offset hint of Plasma 5.16

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH adaptbreezeclockshadow REVISION DETAIL https://phabricator.kde.org/D20478 To: kossebau, #plasma, #vdg, mart, davidedmundson, ngraham Cc: kde-frameworks-devel,

D20428: separe mobile text selection to avoid recursive imports

This revision was automatically updated to reflect the committed changes. Closed by commit R242:58dd4c5c0f12: separe mobile text selection to avoid recursive imports (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20428?vs=55885=55888#toc REPOSITORY R242 Plasma

D20428: separe mobile text selection to avoid recursive imports

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY the mobile text selection toolbar uses toolbuttons, which in turn use the private import.

D20202: FrameSvgItem: add "mask" property

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH framesvgitemaddmaskproperty REVISION DETAIL https://phabricator.kde.org/D20202 To: kossebau, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart abandoned this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart, #plasma, #frameworks Cc: broulik, ngraham, bruns, fvogt, kde-frameworks-devel, michaelh

D20085: Expose a method to show the context menu of an applet from QML

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. looking at D20093 made me rething this, the least intrusive one in the end seems really the first version, with explicit check of formfactor

D20085: Expose a method to show the context menu of an applet from QML

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20085 To: apol, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20042: Show the plasmoid context menu on long tap

mart added a comment. In D20042#439381 , @ngraham wrote: > Don't we want long-press-for-context-menu when using a touchscreen on the desktop? this patch is not "on desktop specific" also, in the desktop area, long press always was

D20042: Show the plasmoid context menu on long tap

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. for now we could go with this... can you make it work *only* when the applet's formfactor is horizontal or vertical? so this codepath wouldn't touch the desktop case at all

D20042: Show the plasmoid context menu on long tap

mart added a comment. what happens on long tap on the desktop? this introduces different behavior between long tap on panel and desktop REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20042 To: apol, #plasma, #frameworks Cc: mart, ngraham,

D19743: FrameSvgItem: catch margin changes of FrameSvg also outside own methods

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH catchSvgFrameMarginChangesOnThemeChange REVISION DETAIL https://phabricator.kde.org/D19743 To: kossebau, #plasma, mart Cc: kde-frameworks-devel, michaelh,

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fixtilingtexture REVISION DETAIL https://phabricator.kde.org/D19787 To: kossebau, #plasma, mart Cc: apol, sitter, kde-frameworks-devel, michaelh, ngraham, bruns

D19728: [GridViewKCM] Fix implicit width calculation

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D19728 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart added a comment. latest version loads again correctly stuff from @2 icon dirs, still, only on integer scaling, as it was doing before (wether that behavior is to be changedis another topic) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart,

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart updated this revision to Diff 53740. mart added a comment. - scale the size for lookup on KIconThemePrivate::iconPath REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19686?vs=53727=53740 BRANCH phab/iconRendering REVISION DETAIL

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart updated this revision to Diff 53727. mart added a comment. - don reset the scale that gets passed around REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19686?vs=53670=53727 BRANCH phab/iconRendering REVISION DETAIL

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart added a comment. In D19686#429343 , @broulik wrote: > I'm confused. Doesnt this undo the use of @2x icons and return to the old behavior of just loading a larger icon? hmm, perhaps, so probablythat check is to be done in kiconloader

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart edited the summary of this revision. mart added a reviewer: Frameworks. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart added a comment. F6684042: Screenshot_20190311_162844.png F6684047: Screenshot_20190311_164519.png F6684051: Screenshot_20190311_164524.png REPOSITORY R302

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY when the flag AA_UseHighDpiPixmaps is set, the pixmap is already scaled, no need to scale it

D19599: textfield height based only on clear text

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a2749dc9c718: textfield height based only on clear text (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19599?vs=53446=53449

D19599: textfield height based only on clear text

mart updated this revision to Diff 53446. mart added a comment. - better formatting REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19599?vs=53445=53446 BRANCH arcpatch-D19599 REVISION DETAIL https://phabricator.kde.org/D19599

D19599: textfield height based only on clear text

mart updated this revision to Diff 53445. mart added a comment. - use just M REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19599?vs=53381=53445 BRANCH arcpatch-D19599 REVISION DETAIL https://phabricator.kde.org/D19599 AFFECTED

D19599: textfield height based only on clear text

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY as the implicit height could change when switching to password mode, use a textmetrics which

D19421: WIP: [Icon Item] Block next animation also based on window visibility

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19421 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19383: remove kpackage_install_package deprecation warning

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH no-deprecate REVISION DETAIL https://phabricator.kde.org/D19383 To: sitter, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19384: extend documentation of kpackage_install_bundled_package

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH docs REVISION DETAIL https://phabricator.kde.org/D19384 To: sitter, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19110: Don't show the tooltip when the drop-down menu is shown

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D19110 To: apol, #kirigami, #frameworks, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18487: Do background contrast fallback at runtime

mart accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18487 To: broulik, #plasma, ngraham, mart Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

D18487: Reparse background contrast settings when colors changed

mart added inline comments. INLINE COMMENTS > mart wrote in theme_p.cpp:754 > They can be supplied from the theme too (or used to be) even though most of > the themes don't err, forget everything i said, i misunderstood your comment :) using qgray on the theme backgroundcolor instead of a

D18487: Reparse background contrast settings when colors changed

mart added inline comments. INLINE COMMENTS > broulik wrote in theme_p.cpp:754 > If the theme does not supply background contrast values, they are > auto-determined from the background color (dark or light), or what do you > mean? They can be supplied from the theme too (or used to be) even

D18487: Reparse background contrast settings when colors changed

mart added inline comments. INLINE COMMENTS > broulik wrote in theme_p.cpp:754 > An alternative approach would be to store those values and then do the > default fallback and `qGray(color(Plasma::Theme::BackgroundColor).rgb()) < > 127` stuff on the fly on demand. > It's runtime cpu cycles vs

D17691: Add rows info to the plasma virtual desktop protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d1e8b45d9310: Add rows info to the plasma virtual desktop protocol (authored by mart). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=50046=50063

D17691: Add rows info to the plasma virtual desktop protocol

mart updated this revision to Diff 50046. mart added a comment. - bump versions REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=49994=50046 BRANCH phab/virtualdesktoprows REVISION DETAIL https://phabricator.kde.org/D17691 AFFECTED FILES

D17691: Add rows info to the plasma virtual desktop protocol

mart updated this revision to Diff 49994. mart added a comment. - rows belongs to protocol version 2 REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=49610=49994 BRANCH phab/virtualdesktoprows REVISION DETAIL

D18149: Share Plasma::Theme instances between multiple ColorScope

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18149 To: broulik, #plasma, mart Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17691: Add rows info to the plasma virtual desktop protocol

mart updated this revision to Diff 49610. mart added a comment. - remove dead symbol REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=49425=49610 BRANCH phab/virtualdesktoprows REVISION DETAIL https://phabricator.kde.org/D17691 AFFECTED

D17691: Add rows info to the plasma virtual desktop protocol

mart updated this revision to Diff 49425. mart added a comment. - verify the signal has been emitted REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=47854=49425 BRANCH phab/virtualdesktoprows REVISION DETAIL

D17691: Add rows info to the plasma virtual desktop protocol

mart added inline comments. INLINE COMMENTS > zzag wrote in test_plasma_virtual_desktop.cpp:280 > QVERIFY why? we want to compare the number of rows, no? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin Cc: zzag, davidedmundson, hein,

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. so, if this is pushed, the same thing should happen at the same time to the corresponding plasma components REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma,

D17542: Reset parentItem when mainItem changes

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. sometimes in the past i had problems about setting parentitem of an item to nullptr, due to all the scenegraph nodes of the item being destroyed and recreated... somewhere else to do

D17543: [Dialog] Don't alter mainItem's visibility

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17543 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart accepted this revision. mart added a comment. bah, seems very tricky to make it work properly across distributions. to me, it speaks mostly as a failure for us to control the look of our product, due to broken fonts in distros and qt font rendering still buggy, issue that

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#388803 , @ngraham wrote: > F6531451: Screenshot_20190107_145258.png > In this one, the fact that it's a header is connoted by its much larger font size and wider

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#388294 , @filipf wrote: > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same problem. > > F6531867: image.png > > F6531893: image.png

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go to levels from 2 onwards where needed smaller and bigger? REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. in the end i *may* accept non light titles, even tough i still very much don't like the idea, but what i don't want to never, ever see in any circumstance is bold titles, anything of that will just be reverted. REPOSITORY R169 Kirigami BRANCH no-light-headings

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#385968 , @ngraham wrote: > - **Implementation inconsistency:** Many fonts don't have a dedicated light style, many distros don't ship them if they do, and Qt < 5.12 doesn't use them even if nope, with

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#385857 , @filipf wrote: > With the exception of the case of the Windows Store (which does nonetheless manage to achieve some visual hierarchy with different font sizes and colors), others mostly actually have an

<    1   2   3   4   5   6   7   8   9   10   >