D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. I'm very much against this, I think it looks very bad :/ REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma, #vdg, #frameworks Cc: mart, plasma-devel,

D17691: Add rows info to the plasma virtual desktop protocol

mart created this revision. mart added reviewers: Plasma, KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY in order for the pager to work correctly and not having to use a weird mix of wayland

D17355: Align Plasma QML button content in center if it has an icon

mart added a comment. pleaase add the changes to plasmacomponents3 as well REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: mart, davidedmundson, apol, ngraham, #vdg, kde-frameworks-devel, #plasma,

D17355: Align Plasma QML button content in center if it has an icon

mart added a comment. In D17355#371722 , @GB_2 wrote: > Improved code. > How `qmlscene tests/components/button.qml` looks like: > F6457867: Plasma QML Button Content Align qmlscene (1).png > For

D17355: Align Plasma QML button content in center if it has an icon

mart added a comment. in general, buttons with icons may be stacked vertically, which for me makes a general -1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: mart, davidedmundson, apol, ngraham, #vdg,

D17350: Add the missing api for multilevel KCMs to control the columns

mart added a comment. All is in now :) (connection name became Network name as requested) REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17351: make use of the new currentIndex api of QML kcms

This revision was automatically updated to reflect the committed changes. Closed by commit R295:313be515b2f8: make use of the new currentIndex api of QML kcms (authored by mart). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17351?vs=46847=46888 REVISION

D17350: Add the missing api for multilevel KCMs to control the columns

This revision was automatically updated to reflect the committed changes. Closed by commit R296:7482529530ca: Add the missing api for multilevel KCMs to control the columns (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D17350: Add the missing api for multilevel KCMs to control the columns

mart added a comment. In D17350#371496 , @jgrulich wrote: > @mart , can you push your changes for plasma-nm so I can try this? sure! can you ship it this too, so i get it all off in? REPOSITORY R296 KDeclarative REVISION DETAIL

D17351: make use of the new currentIndex api of QML kcms

mart edited the summary of this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D17351 To: mart, #plasma, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17351: make use of the new currentIndex api of QML kcms

mart added a reviewer: jgrulich. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D17351 To: mart, #plasma, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

mart added a reviewer: jgrulich. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

mart added a comment. F6454962: image.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17351: make use of the new currentIndex api of QML kcms

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY sync kcm currentindex with the pagerow's TEST PLAN tested with newtowrkmanager qml rewrite

D17350: Add the missing api for multilevel KCMs to control the columns

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY - add currentIndex and depth, which would map to the view in SystemSettings using a Kirigami

D16643: Correct the accept flag of the event object on DragMove

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

mart requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel,

D16643: Correct the accept flag of the event object on DragMove

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D17191: Perfect alignment between QML and QWidget KCM titles

This revision was automatically updated to reflect the committed changes. Closed by commit R295:bba3150027f3: Perfect alignment between QML and QWidget KCM titles (authored by mart). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17191?vs=46323=46464

D17190: Add level api from Kirigami.Heading

This revision was automatically updated to reflect the committed changes. Closed by commit R236:d3964629cbff: Add level api from Kirigami.Heading (authored by mart). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17190?vs=46322=46463 REVISION DETAIL

D17190: Add level api from Kirigami.Heading

mart added a comment. In D17190#366854 , @ngraham wrote: > In those screenshots, "< Fonts" is basically just a named back button. Should it really have the same size and visual weight as the active KCMs' title? I think so, it's the title

D17191: Perfect alignment between QML and QWidget KCM titles

mart added a comment. QML KCM: F6443898: image.png QWidget KCM: F6443900: image.png REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D17191 To: mart, #plasma, #vdg Cc:

D17191: Perfect alignment between QML and QWidget KCM titles

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY uses spacing metrics synced with systemsettings to have the title perfectly aligned with

D17190: Add level api from Kirigami.Heading

mart added a comment. F6443889: image.png with a QWidget KCM F6443893: image.png REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17190 To: mart, #plasma, #vdg Cc:

D17190: Add level api from Kirigami.Heading

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY add a "level" api that has the same meaning as in the Kirigami Heading component, This

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D14000 To: rjvbb, #frameworks, mart Cc: alexeymin, davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel,

D17079: Provide a qqc2/kirigami-based about page

mart added a comment. In D17079#364263 , @apol wrote: > In D17079#364163 , @ltoscano wrote: > > > In D17079#364157 , @mart wrote: > > > > > I think

D17079: Provide a qqc2/kirigami-based about page

mart added inline comments. INLINE COMMENTS > DiscoverWindow.qml:76 > } > +TopLevelPageData { > +id: aboutAction can you try how does it look for this page to be pushed as a layer instead of the main PageRow? would be like

D17079: Provide a qqc2/kirigami-based about page

mart added a comment. I think this ui should really go into KCoreAddons itself. Would it be accepted there? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17079 To: apol, #plasma, #frameworks Cc: mart, leinir, ngraham, ltoscano, plasma-devel,

D17052: Simplify reference counting of FrameData

mart added a comment. after adressing zzag's comments, is good to go for me REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

mart added a comment. adding a default value should be bc, the opposite of course is not.. in its current state, looks good to me REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure Cc: mart, mpyne, broulik, anthonyfieroni,

D17079: Provide a qqc2/kirigami-based about page

mart added a comment. In D17079#363975 , @ngraham wrote: > Cool! > > For this design, I'd like to get rid of the tabs and put everything in a scrollview. We generally have enough space that a tabbed view is overkill. +1 REPOSITORY

D17052: Simplify reference counting of FrameData

mart added a comment. things like https://bugs.kde.org/show_bug.cgi?id=398854 i guess REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17031: Fix a few memory leaksASAN: Fix leak in AppletQuickItem

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D17031 To: kfunk, mart Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D17031: Fix a few memory leaksASAN: Fix leak in AppletQuickItem

mart added a comment. looks good, thanks :) tough those fixes are quite unrelated, can they be made in separated commits? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17031 To: kfunk Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D16301: Remove ComponentInstaller

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16301 To: broulik, #plasma, mart Cc: apol, bruns, kde-frameworks-devel, michaelh, ngraham

D16883: Add VirtualDesktops to PlasmaWindowModel

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16883 To: davidedmundson, #kwin, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16880: Update PlasmaWindowModel test to reflect VirtualDesktop changes

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16880 To: davidedmundson, #kwin, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16877: Cleanup windowInterface in tests before windowManagement is destroyed

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16877 To: davidedmundson, #kwin, mart Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D16686: Cleanup Virtual Desktop Manager list entry in PlasmaVirtualDesktop destructor

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16686 To: davidedmundson, #kwin, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16742: Fix iconitemtest regression

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16742 To: joselema, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16685: Fix issue where there's only one element on the menu

mart accepted this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D16685 To: apol, #frameworks, mart, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D12820: Add KWayland virtual desktop protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d0db5da57563: Add KWayland virtual desktop protocol (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12820?vs=38123=44643#toc REPOSITORY R127 KWayland CHANGES SINCE LAST

D12820: Add KWayland virtual desktop protocol

mart added a comment. In D12820#297896 , @mart wrote: > RFC: add back some info for the layout? (in particular: rows and orientation, tought orientation is a bit concerning as is view-spacific) it was decided no, we care only about the

D14580: support for multi pages kcms

This revision was automatically updated to reflect the committed changes. Closed by commit R295:58e3b29efb99: support for multi pages kcms (authored by mart). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=43279=43280 REVISION DETAIL

D14580: support for multi pages kcms

mart updated this revision to Diff 43279. mart added a comment. - Merge branch 'master' into arcpatch-D14580 REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=40629=43279 BRANCH arcpatch-D14580 REVISION DETAIL

D15099: add a new property headerVisible

This revision was automatically updated to reflect the committed changes. Closed by commit R236:9069ae42435c: add a new property headerVisible (authored by mart). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15099?vs=40504=43278 REVISION DETAIL

D15098: make push/pop part of ConfigModule API

This revision was automatically updated to reflect the committed changes. Closed by commit R296:abfc94c6093a: make push/pop part of ConfigModule API (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15098?vs=40701=43276#toc REPOSITORY R296 KDeclarative CHANGES SINCE

D15853: Change drive-harddisk to more adaptable style

mart added a comment. What's that white blob on top of the hard disk? it looks really weird REPOSITORY R266 Breeze Icons BRANCH new-harddisk-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D15853 To: ndavis, #vdg, ngraham, pstefan Cc: mart, pstefan, ngraham,

D15705: Also raise configuration window when reusing it

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15705 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15164: Support button icons when present

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:85cab5772c56: Support button icons when present (authored by mart). REPOSITORY R242 Plasma Framework (Library)

D15098: make push/pop part of ConfigModule API

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in configmodule.h:392 > I don't understand this sentence. It contains two "when"s hopefully simpler comment REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D15098 To: mart, #plasma Cc:

D15098: make push/pop part of ConfigModule API

mart updated this revision to Diff 40701. mart marked an inline comment as done. mart added a comment. - hopefully clearer comment REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15098?vs=40499=40701 BRANCH arcpatch-D15098 REVISION DETAIL

D15164: Support button icons when present

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY support button icons. if there is no icon or is Qt 5.9, the iconItem will stay invisible

D14580: support for multi pages kcms

mart added a comment. F6223394: Spectacle.k3.png in case the kcm wants to go multi columns (default off): F6223399: Spectacle.l3.png REPOSITORY R295 KCMUtils REVISION DETAIL

D14580: support for multi pages kcms

mart updated this revision to Diff 40629. mart added a comment. - cosmetic spacing REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=40625=40629 BRANCH mart/multipageKCM REVISION DETAIL https://phabricator.kde.org/D14580 AFFECTED FILES

D14580: support for multi pages kcms

mart updated this revision to Diff 40625. mart added a comment. hide title of qml modules from KCMultidialog REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=40500=40625 BRANCH mart/multipageKCM REVISION DETAIL

D15139: hide title of qml modules from kcmultidialog

mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REPOSITORY R295 KCMUtils BRANCH mart/multipageKCM REVISION DETAIL https://phabricator.kde.org/D15139 AFFECTED FILES

D15139: hide title of qml modules from kcmultidialog

mart abandoned this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D15139 To: mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

mart updated this revision to Diff 40504. mart added a comment. - emit changed REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15099?vs=40501=40504 BRANCH phab/headerVisible REVISION DETAIL https://phabricator.kde.org/D15099 AFFECTED FILES

D15099: add a new property headerVisible

mart added a comment. KCM showing its own title F6218375: Spectacle.y22236.png Ttile shown by KPageWidget F6218377: Spectacle.S22236.png REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D15099: add a new property headerVisible

mart added a reviewer: Frameworks. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15099 To: mart, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY add a new property in KPageWidgetItem, headerVisible this way the page can control whether

D14580: support for multi pages kcms

mart updated this revision to Diff 40500. mart added a comment. - use the new ConfigMoule push/pop api REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=40370=40500 BRANCH mart/multipageKCM REVISION DETAIL https://phabricator.kde.org/D14580

D15098: make push/pop part of ConfigModule API

mart added a reviewer: Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D15098 To: mart, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15098: make push/pop part of ConfigModule API

mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY for better separation, abstract push/pop and columnWidth in the ConfigModule class so the qml part won't have access to

D14580: support for multi pages kcms

mart updated this revision to Diff 40370. mart added a comment. - retrocompatibility hack with systemsettings REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=39310=40370 BRANCH mart/multipageKCM REVISION DETAIL

D14990: [Icon Item] Watch KIconLoader icon change when using QIcon

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14990 To: broulik, #plasma, TheAssassin, mart Cc: azubieta, kde-frameworks-devel, michaelh, ngraham, bruns

D15017: Attach property to "delegate"

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D15017 To: broulik, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14579: api for multi level kcms

mart abandoned this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D14579 To: mart, #plasma, #frameworks Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

mart updated this revision to Diff 39310. mart added a comment. - paint internally the title and breadcrumb REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=39018=39310 BRANCH mart/multipageKCM REVISION DETAIL

D14579: api for multi level kcms

mart added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D14579 To: mart, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

mart added a reviewer: Frameworks. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D14580 To: mart, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY support multiple levels for QML kcms. use a

D14579: api for multi level kcms

mart added a dependent revision: D14580: support for multi pages kcms. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D14579 To: mart, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14579: api for multi level kcms

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY Support the concept of multi level kcms: systemsettings and

D13744: Let ki18n macro file name follow style of other find_package related files

mart added a comment. KI18n fails to install now REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13744 To: habacker, apol, ilic Cc: mart, kde-frameworks-devel, leinir, michaelh, ngraham, bruns

D14341: if an applet is invalid, it has immediately UiReadyConstraint

This revision was automatically updated to reflect the committed changes. Closed by commit R242:56f0df412713: if an applet is invalid, it has immediately UiReadyConstraint (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14341?vs=38352=38497#toc REPOSITORY R242

D14341: if an applet is invalid, it has immediately UiReadyConstraint

mart edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D14341 To: mart, #plasma, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

mart added a comment. RFC: add back some info for the layout? (in particular: rows and orientation, tought orientation is a bit concerning as is view-spacific) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma, graesslin, hein Cc:

D14341: if an applet is invalid, it has immediately UiReadyConstraint

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY mirroring the behavior when the applet is created by

D14218: Introduce a test to make sure we're not offering duplicated icons

mart added a comment. +100 from me as well REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14218 To: apol, andreaska, mart, vkrause, #framework_syntax_highlighting Cc: andreask, kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 38123. mart added a comment. - Revert "rename the virtual desktop to Unstable" - Merge branch 'master' into mart/plasmavirtualdesktop REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12820?vs=38122=38123 BRANCH

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 38122. mart added a comment. rever rename REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12820?vs=38017=38122 BRANCH mart/plasmavirtualdesktop REVISION DETAIL https://phabricator.kde.org/D12820 AFFECTED FILES

D12820: Add KWayland virtual desktop protocol

mart added a comment. classes renamed to fooUnstableV1, but i need comments, i'm not sure about the naming or how to manage the fact that's unstable.. ‎‎Most of the unstable protocols just have the protocol implementation as unstable, but already kinda commit to stability to the c++

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 38017. mart added a comment. - fix initial state on createresource - send done to new clients - desktops shouldn't be deleted when the clients go away - iget rid of setActiveDesktop - rename the virtual desktop to Unstable REPOSITORY R127 KWayland

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

mart accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14045 To: broulik, #plasma, mart, sitter, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14009: [Plasma PluginLoader] Cache plugins during startup

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14009 To: broulik, #plasma, davidedmundson, mart Cc: ngraham, zzag, kde-frameworks-devel, michaelh, bruns

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

mart added a comment. in principle i agree, I would love to be able to use this in qguiapplications, but are we sure qstyles won't access qapplication? doesn't this risk to just move the crash? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 37197. mart added a comment. - ensure there are never duplicates REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12820?vs=37149=37197 BRANCH mart/plasmavirtualdesktop REVISION DETAIL

D12820: Add KWayland virtual desktop protocol

mart added a comment. In D12820#286960 , @romangg wrote: > The VD protocol was a pure "consumer" protocol before this last revision. Now it gets more complicated by putting requests into it for asking the compositor to change its configuration.

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 37149. mart added a comment. - add a request remove to the protocol - add api call to request removal of a desktop - requestCreate - remove window management features: - active() -> isactive() - requestEnterNewVirtualDesktop REPOSITORY R127

D12820: Add KWayland virtual desktop protocol

mart marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma, graesslin, hein Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 36888. mart marked an inline comment as done. mart added a comment. - better comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12820?vs=36887=36888 BRANCH mart/plasmavirtualdesktop REVISION DETAIL

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 36887. mart added a comment. - add desktopActivated signal - correct behavior for set on all desktops - add new tests for on all desktops - make the old isOnallVirtualDesktops api work REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D13384: FrameSvg: Do not wreck shared mask frames

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. sorry for making you wait too long on those framesvg changes, looks like i have to tune up phab notifications a bit more as they didn't show up :/ (anyways, adding Plasma in tags should

D13402: FrameSvg: Simplify updateSizes

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH framesvg-simplify-updatesizes REVISION DETAIL https://phabricator.kde.org/D13402 To: zzag, #plasma, #frameworks, mart Cc: kde-frameworks-devel, michaelh,

D13496: FrameSvg: Update mask frame if image path has been changed

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH dont-wreck-shared-mask-frames REVISION DETAIL https://phabricator.kde.org/D13496 To: zzag, #plasma, #frameworks, mart Cc: kde-frameworks-devel, michaelh,

D13752: Kill solidautoeject

mart added a comment. +1 (maybe build conditionally on freebsd if it's *really* necessary there) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: mart, plasma-devel,

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 36528. mart added a comment. - Merge branch 'master' into mart/plasmavirtualdesktop REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12820?vs=36161=36528 BRANCH mart/plasmavirtualdesktop REVISION DETAIL

<    1   2   3   4   5   6   7   8   9   10   >