D9123: reuse KPackage instance between PluginLoader and Applet

This revision was automatically updated to reflect the committed changes. Closed by commit R242:604aba0e241f: reuse KPackage instance between PluginLoader and Applet (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9123?vs=

D9123: reuse KPackage instance between PluginLoader and Applet

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in applet.cpp:98 > If anyone uses the old argument list syntax (where the first argument was a > string or a kpluginmetadata) this will break. > > Can we be sure that the PluginLoader was the only user? > It was a somewhat und

D9124: make packageurlinterceptor as noop as possible

mart updated this revision to Diff 23490. mart added a comment. - use kpackage_install_bundled_package REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23463&id=23490 BRANCH phab/packegeFileUrl REVISION DETAIL https://phabrica

D9197: experimental support for rcc files loading in kpackage

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY support for the contents/ directory of kpackage to be compressed in an rcc file, new cmake

D9169: port to Package::fileUrl

This revision was automatically updated to reflect the committed changes. Closed by commit R242:84104aa463b1: port to Package::fileUrl (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9169?vs=23430&id=23464 REVISION DETAIL

D9124: make packageurlinterceptor as noop as possible

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d0cbef14cbdd: make packageurlinterceptor as noop as possible (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23397&id=

D9169: port to Package::fileUrl

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY makes things work when packages are in resources Depends from: https://phabricator.kde.org/

D9124: make packageurlinterceptor as noop as possible

mart updated this revision to Diff 23397. mart added a comment. only toString once REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23328&id=23397 BRANCH phab/killurlinterceptor REVISION DETAIL https://phabricator.kde.org/D912

D9141: Setup QQmlEngine only once in QmlObject

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in qmlobject.h:72 > The problem being solved is that QQmlObjectSharedEngine inherits QQmlObject > that needs a constructor that doesn't do engine things > > It could be protected though. what about a different ctor which does th

D9141: Setup QQmlEngine only once in QmlObject

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > qmlobject.h:72 > + */ > +enum class SetupFlag { > +Engine = 1<<0, ///< call setupEngine() on it this shouldn't be necessary? qmoobject will do th

D9113: [WIP] ensure only one kpackage per applet

mart abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9113 To: mart, #plasma Cc: davidedmundson, apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9124: make packageurlinterceptor as noop as possible

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY minimize file access during url rewrite we still need it for accessing stuff under code/

D9123: reuse KPackage instance between PluginLoader and Applet

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY to minimize metadata lookups, pass the kpackage created in pluginloader to the applet itsel

D8982: Qml controls for kcm creation

This revision was automatically updated to reflect the committed changes. Closed by commit R296:09ad7c2e2dad: Qml controls for kcm creation (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8982?vs=22996&id=23318 REVISION DETAIL https:

D9119: Initialize scale factor to the last scale factor set on any instance

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9119 To: hein, #plasma, davidedmundson, broulik, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesl

D9113: [WIP] ensure only one kpackage per applet

mart updated this revision to Diff 23300. mart added a comment. - Merge branch 'master' into phab/minimizekpackage - fix build REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9113?vs=23296&id=23300 BRANCH phab/minimizekpackage REVISI

D9113: [WIP] ensure only one kpackage per applet

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY - only one kpackage per applet, minimizes the metadata() cache misses (and access to json)

D8917: Reduce the amount of spurious property changes on ColorScope

mart added a comment. ah, you are right, yes, it should do checkcologgroupchanged instead REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8917 To: apol, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff

D8917: Reduce the amount of spurious property changes on ColorScope

mart accepted this revision. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in colorscope.cpp:193 > check here. this is when the item changes window and we're not sure we are still in the same color set, so i think is ok to keep this signal REPOSITORY R242 Plasma Framewor

D9089: Suppress unnecessary scroll indicators if the flickable is a ListView with known orientation

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9089 To: hein, #plasma, mart, garg Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed

D9066: [AppletInterface] Emit change signals for configurationRequired and -Reason

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9066 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D8982: Qml controls for kcm creation

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in SimpleKCM.qml:23 > > but i think the scrolling should be handed by the qml part. > > Why? 3 reasons: 1. because the long term goal is to get rid of the qwidget version, so even if it's long down the road things should be de

D8982: Qml controls for kcm creation

mart marked 10 inline comments as done. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D8982 To: mart, #plasma, hein, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mar

D8982: Qml controls for kcm creation

mart updated this revision to Diff 22996. mart added a comment. - documentation REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8982?vs=22897&id=22996 BRANCH arcpatch-D8982 REVISION DETAIL https://phabricator.kde.org/D8982 AFFECTED FILES src/qm

D8982: Qml controls for kcm creation

mart added a comment. In https://phabricator.kde.org/D8982#171694, @davidedmundson wrote: > I like the GridView > > Note that we'll want to use that from the WallpaperDialog in Plasma, which isn't a KCM. I don't think it will be a problem though ? yes, those components should

D8982: Qml controls for kcm creation

mart updated this revision to Diff 22897. mart added a comment. - use the actual scrollbar width - more sophisticated implicit size for kcms - size hints for the simple kcm REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8982?vs=22885&id=22897 BRAN

D8982: Qml controls for kcm creation

mart added inline comments. INLINE COMMENTS > hein wrote in GridDelegate.qml:130 > Do these numbers align with anything? Then a comment pointing at where else > we use them would be good. > > Or maybe use multiples of long/short duration? Or makes no sense? > > Same question about the other si

D8982: Qml controls for kcm creation

mart updated this revision to Diff 22885. mart added a comment. - include SimpleKCM REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8982?vs=22883&id=22885 BRANCH phab/kcmodules REVISION DETAIL https://phabricator.kde.org/D8982 AFFECTED FILES sr

D8982: Qml controls for kcm creation

mart added a reviewer: hein. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D8982 To: mart, #plasma, hein Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8982: Qml controls for kcm creation

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY the base C++ class for qml-based kcms is already there, KQuickAddons::ConfigModule, so this

D8436: use a single QML engine

This revision was automatically updated to reflect the committed changes. Closed by commit R296:fcecbc5c67f7: use a single QML engine (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8436?vs=21224&id=22693 REVISION DETAIL https://phabr

D8914: Remove duplicate boilerplate code

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8914 To: apol, #plasma, #frameworks, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jens

D8870: Synchronize the component with the one in Kirigami

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8870 To: apol, #plasma, mart Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-moh

D8522: keyboard navigation in and out QML kcms

This revision was automatically updated to reflect the committed changes. Closed by commit R295:9ebf898572ca: keyboard navigation in and out QML kcms (authored by mart). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=22463&id=22464 REVISION DETAIL

D8522: keyboard navigation in and out QML kcms

mart marked 2 inline comments as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks, davidedmundson Cc: broulik, davidedmundson, ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D8522: keyboard navigation in and out QML kcms

mart updated this revision to Diff 22463. mart added a comment. - guard null REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=21440&id=22463 BRANCH phab/keynav REVISION DETAIL https://phabricator.kde.org/D8522 AFFECTED FILES src/kcmoduleqml.

D8522: keyboard navigation in and out QML kcms

mart added a comment. ping REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks Cc: ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8691: add some metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R296:ae8d97bb5274: add some metadata (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8691?vs=22022&id=22141 REVISION DETAIL https://phabricator

D8691: add some metadata

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY accessible by the qml implementations TEST PLAN the properties kcm.name and kcm.descriptio

D8173: Use readelf to find project dependencies

mart added a comment. +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8173 To: apol, #frameworks, #build_system, aacid Cc: mart

D8522: keyboard navigation in and out QML kcms

mart updated this revision to Diff 21440. mart added a comment. - skip widgets that don't accept focus REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=21435&id=21440 BRANCH phab/keynav REVISION DETAIL https://phabricator.kde.org/D8522 AFFECTE

D8522: keyboard navigation in and out QML kcms

mart added a reviewer: Frameworks. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8522: keyboard navigation in and out QML kcms

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY QQuickWidget doesn't support keyboard navigation per se, the widget will gain keyboard focu

D8436: use a single QML engine

mart edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D8436 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8436: use a single QML engine

mart added a comment. In https://phabricator.kde.org/D8436#159212, @davidedmundson wrote: > Given the fallout we had when we made the similar change in Plasma, please don't merge until the start of the next release cycle. after november first week release? ok > Can you expand

D8436: use a single QML engine

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in configmodule.cpp:106 > !! this version now should work, as the context is used now: the way the static attached property function finds it is quite an heuristic, but should be 100% reliable REPOSITOR

D8436: use a single QML engine

mart updated this revision to Diff 21223. mart added a comment. - use the qmlobject's rootcontext instead of the engine as is now shared REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8436?vs=21184&id=21223 BRANCH arcpatch-D8436 REVISION DETAIL h

D8436: use a single QML engine

mart updated this revision to Diff 21224. mart added a comment. - use the qmlobject's rootcontext instead of the engine as is now shared REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8436?vs=21223&id=21224 BRANCH arcpatch-D8436 REVISION DETAIL h

D8436: use a single QML engine

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in configmodule.cpp:106 > !! right, since it keeps track of attached properties in this way, either gets changed or is not possible to use a single engine, damn :/ hmm, maybe using the rootcontext instea

D8436: use a single QML engine

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY use a shared qml engine for all ConfigModules in the same process this avoids some crashes

Re: qqc2-desktop-style as framework

thing purely runtime (being a style not even something that is explicitly imported) so anything ending up using it couldn't be considered "derivative" in any way -- Marco Martin

D7369: Wayland foreign protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R127:ce2ff96c5756: Wayland foreign protocol (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7369?vs=20639&id=20667#toc REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE http

D7369: Wayland foreign protocol

mart updated this revision to Diff 20639. mart marked 7 inline comments as done. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - more documentation REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7369

D7369: Wayland foreign protocol

mart updated this revision to Diff 20638. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - documentation++ - name the methods exportTopLevel/importTopLevel REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.

D7369: Wayland foreign protocol

mart added a comment. In https://phabricator.kde.org/D7369#154153, @graesslin wrote: > In https://phabricator.kde.org/D7369#153978, @mart wrote: > > > In https://phabricator.kde.org/D7369#152358, @graesslin wrote: > > > > > Documentation is still missing, Unstable suffix is still i

D7369: Wayland foreign protocol

mart updated this revision to Diff 20584. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - update to the upstream xml protocol REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7369?vs=20553&id=20584 BR

D7369: Wayland foreign protocol

mart updated this revision to Diff 20553. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - add api docs, getridof some unstable, calls with unstable follow the other interfaces REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE http

D7369: Wayland foreign protocol

mart added a comment. In https://phabricator.kde.org/D7369#152358, @graesslin wrote: > Documentation is still missing, Unstable suffix is still in two many API calls. i think the importerUnstableV2Announced exporterUnstableV2Announced should remain with unstable and versioned? R

D8060: allow to set a custom palette instead of colorSets

mart added a comment. In https://phabricator.kde.org/D8060#152619, @mardelle wrote: > KIconLoader::global()->setCustomPalette(plt); > > To make icon color theming work in existing apps that allow color theme switch. > Regression can be easily tested with KDevelop or Kdenlive using

D8146: Don't try to override label heights - PlasmaComponents

mart added a comment. yes, this should stay. this was done in order to have labels automatically vertically align with other controls with just a Row (before RowLayout and Layout.alignment was a thing) as David says, will get rid of those once all is ported to new controls REPOSITORY R

D8135: [FrameSvg] Optimize updateSizes

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8135 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D7369: Wayland foreign protocol

mart updated this revision to Diff 20257. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - move to xdg-foreign-unstable-v2 - get rid of setTransientFor REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D8111: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D8111 To: leinir, #knewstuff, mart Cc: bshah, #frameworks, ZrenBot

D8060: allow to set a custom palette instead of colorSets

This revision was automatically updated to reflect the committed changes. Closed by commit R302:0fd3ee28cedd: allow to set a custom palette instead of colorSets (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8060?vs=20107&id=20234#toc REPOSITORY R302 KIconThemes CH

D8060: allow to set a custom palette instead of colorSets

mart marked 2 inline comments as done. REPOSITORY R302 KIconThemes BRANCH custompalette REVISION DETAIL https://phabricator.kde.org/D8060 To: mart, dfaure, #frameworks, rikmills, davidedmundson Cc: davidedmundson, broulik, cfeck, #frameworks

D8058: don't redefine output dirs on android

mart added a comment. In https://phabricator.kde.org/D8058#150551, @apol wrote: > Before disabling it altogether on Android, I'd prefer to look into why it's not working. Give me a week, please? sure :) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.

D8060: allow to set a custom palette instead of colorSets

mart added inline comments. INLINE COMMENTS > broulik wrote in kiconloader.cpp:869 > You don't seem to be following `qApp->palette()` anymore if no custom one is > set? it uses an empty QPalette(), which accordning to the docs, it should fall back to the application's palette REPOSITORY R30

D8060: allow to set a custom palette instead of colorSets

mart added reviewers: Frameworks, rikmills. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D8060 To: mart, dfaure, #frameworks, rikmills Cc: #frameworks

D8060: allow to set a custom palette instead of colorSets

mart created this revision. mart added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY remove the public dependency to KConfigWidgets as this is breaking existing apps, but instead let application

D7891: expose the colorset for the stylesheet

mart added a comment. https://phabricator.kde.org/D8060 solves the same problem without new dependencies REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D7891 To: mart, #frameworks, #plasma, hein, dfaure Cc: rikmills, plasma-devel, #frameworks, ZrenBot, progwolff

D7891: expose the colorset for the stylesheet

mart added inline comments. INLINE COMMENTS > dfaure wrote in kiconloader.h:465 > I guess this is OK as is, so remove the comment (it's not we can change this > later) apparently this is giving problems indeed, polkit is now failing to build since it wasn't explicitly linking to KConfigWidgets

D8058: don't redefine output dirs on android

mart added a reviewer: Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8058 To: mart, apol, dfaure, #frameworks Cc: #frameworks, #build_system

D8058: don't redefine output dirs on android

mart created this revision. mart added reviewers: apol, dfaure. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY on Android the output directories need to stay default or it breaks packaging wi

D8014: Don't animate IconItem in software mode

mart added inline comments. INLINE COMMENTS > iconitem.cpp:624 > + > +if (QQuickWindow::sceneGraphBackend() == QLatin1String("software")) { > +animated = false; enclose this part with #ifdef on Qt version? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabr

D8034: add overflow-menu icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:9b3849050e1d: add overflow-menu icon (authored by mart). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8034?vs=20040&id=20044 REVISION DETAIL https://phabri

D8034: add overflow-menu icon

mart added a reviewer: andreask. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8034 To: mart, andreask Cc: #frameworks

D8034: add overflow-menu icon

mart created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add the overflow menu which is used a lot especially in mobile apps. It's a 3 dot icon called aso the "kebab" menu BUG:385171 TEST PLAN t

D8009: [Containment Interface] Don't add containment actions to applet actions on desktop

mart accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8009 To: broulik, #plasma, hein, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7891: expose the colorset for the stylesheet

This revision was automatically updated to reflect the committed changes. Closed by commit R302:b06e2ecb32a1: expose the colorset for the stylesheet (authored by mart). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7891?vs=19935&id=19936 REVISION DETAIL

D7891: expose the colorset for the stylesheet

mart updated this revision to Diff 19935. mart added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. - remove comment REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7891?vs=19787&id=199

D7891: expose the colorset for the stylesheet

mart edited the test plan for this revision. mart added reviewers: Frameworks, Plasma, hein. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D7891 To: mart, #frameworks, #plasma, hein Cc: #frameworks

D7891: expose the colorset for the stylesheet

mart added a reviewer: dfaure. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D7891 To: mart, #frameworks, #plasma, hein, dfaure Cc: #frameworks

D7891: expose the colorset for the stylesheet

mart updated this revision to Diff 19787. mart added a comment. - make it work REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7891?vs=19701&id=19787 BRANCH mart/colorSet REVISION DETAIL https://phabricator.kde.org/D7891 AFFECTED FILES src/CMake

D7891: expose the colorset for the stylesheet

mart created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY this makes possible having icons loaded with different colors in different parts of the application, will be needed by kirigami (which will

D7891: expose the colorset for the stylesheet

mart planned changes to this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D7891 To: mart Cc: #frameworks

D7819: Add extra visual indicator for Checkbox/Radio keyboard focus

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7819 To: davidedmundson, #plasma, #vdg, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, a

Re: qqc2-desktop-style as framework

this is a quick and dirty attempt at this.. i don't know how much it would break, but i think in order to have a correct import usable without install it should do something along the lines On Tue, Sep 12, 2017 at 8:49 PM, Marco Martin wrote: > On Mon, Sep 11, 2017 at 4:59 PM, Haral

Re: qqc2-desktop-style as framework

be installed together the source qml files? so this way would put everything togetether -- Marco Martin

Re: qqc2-desktop-style as framework

t the issue of `make > uninstall ; make test` in kirigami first, it's still broken. ok, so the only way i think is to move the source tree to src/org/kde/kirigami.2 i guess? -- Marco Martin

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > safaalfulaij wrote in ProgressBar.qml:33 > Actually, it’s used in default QQC2 styling and I just stole it from there.. > http://code.qt.io/cgit/qt/qtquickcontrols2.git/tree

Re: qqc2-desktop-style as framework

On Fri, Sep 1, 2017 at 3:02 PM, Marco Martin wrote: > On Thu, Aug 31, 2017 at 5:06 PM, Marco Martin wrote: >> any objection into pulling it into a framework? anything particular for the >> procedure? > > as an update to that, i've update its cmake files and metadata f

D7369: Wayland foreign protocol

mart retitled this revision from "[WIP] Wayland foreign protocol" to "Wayland foreign protocol". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7369 To: mart, #plasma, #kwin, davidedmundson Cc: davidedmundson, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff,

D6047: Support XDG v6

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in xdgshell_interface.cpp:40 > the captured "attempt" variable is modified inside the lambda needs to tack the state as needs to track that only a couple of attempts are made REPOSITORY R127 KWayland REVISION DETAIL https:

Re: qqc2-desktop-style as framework

On Thu, Aug 31, 2017 at 5:06 PM, Marco Martin wrote: > any objection into pulling it into a framework? anything particular for the > procedure? as an update to that, i've update its cmake files and metadata files to be coherent with other frameworks, at this point i'll wait a co

qqc2-desktop-style as framework

t differently), so as with kirigami only source compatibility on the qml- side will matter any objection into pulling it into a framework? anything particular for the procedure? -- Marco Martin

D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7602 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D7601: [EventPluginsManager] Expose pluginPath in model

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7601 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D6963: Don't block starting notification service

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D6963 To: davidedmundson, mart Cc: alexeymin, marten, vandenoever, mck182, dvratil, #frameworks

D7369: [WIP] Wayland foreign protocol

mart updated this revision to Diff 18767. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - get rid of setTransientFor REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7369?vs=18760&id=18767 BRANCH ma

D7369: [WIP] Wayland foreign protocol

mart updated this revision to Diff 18760. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - add a serverside setTransientFor in xdgshell REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7369?vs=18744&id=

<    2   3   4   5   6   7   8   9   10   11   >