---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
: https://git.reviewboard.kde.org/r/119846/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
, 2014, 5:21 p.m., Marco Martin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119846/
---
(Updated Aug. 19, 2014, 5:21 p.m
outside workspace so be it.
it would need i guess an area for runtime, but not necessarly workspace
things
--
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
On Aug. 19, 2014, 5:21 p.m., Marco Martin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119846
/RadioButtonStyle.qml
PRE-CREATION
src/desktoptheme/breeze/widgets/actionbutton.svgz 25aacc8
Diff: https://git.reviewboard.kde.org/r/119846/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
,
unchecked.
Marco Martin wrote:
eew, the tristate stuff, right..
checked is a boolean, and still used in radio, the tristate thing is
checkedState and is used now in checkbox
- Marco
---
This is an automatically generated e-mail
PRE-CREATION
src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml
PRE-CREATION
src/desktoptheme/breeze/widgets/actionbutton.svgz 25aacc8
Diff: https://git.reviewboard.kde.org/r/119846/diff/
Testing
---
Thanks,
Marco Martin
,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/119942/#comment45627
maybe going even more explicit and giving its own subdicrectory too? (i'm
fine with either)
- Marco Martin
On Aug. 26, 2014, 5:25 p.m., Aaron J. Seigo wrote:
---
This is an automatically
-ification
- Marco Martin
On Aug. 29, 2014, 11:51 a.m., Aaron J. Seigo wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119988
On Aug. 29, 2014, noon, David Edmundson wrote:
src/plasma/packagestructure.h, line 99
https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99
would removing a #define count as a SIC?
Aaron J. Seigo wrote:
Yes, but I don't think it maters for two
build without problems.
+1 for me..
- Marco Martin
On Aug. 29, 2014, 2:20 p.m., Aaron J. Seigo wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119992
).
Note that currently DataEngine is broken for plugins compiled with the
old define, so this is an issue that needs addressing with or without this
patch set.
Marco Martin wrote:
In which case the Plasma team ought to just install the headers for
libplasmaquick and make
).
Note that currently DataEngine is broken for plugins compiled with the
old define, so this is an issue that needs addressing with or without this
patch set.
Marco Martin wrote:
In which case the Plasma team ought to just install the headers for
libplasmaquick and make
://git.reviewboard.kde.org/r/120029/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120029/#review65648
---
On Sept. 1, 2014, 2:32 p.m., Marco Martin wrote
/private/package_p.h d902eb1
Diff: https://git.reviewboard.kde.org/r/120029/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/private/package_p.h d902eb1
Diff: https://git.reviewboard.kde.org/r/120029/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Sept. 1, 2014, 4:53 p.m., David Edmundson wrote:
I need some the concept explaining, why would a developer set a
fallbackpackage?
Is it not always org.kde.breeze.desktop?
Marco Martin wrote:
It would usually be the packagestructure setting it, in initPackage(), so
src/plasma/package.cpp 6ad3321
src/plasma/private/package_p.h d902eb1
Diff: https://git.reviewboard.kde.org/r/120029/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
reasons
therefore, kio/src/core/desktopexecparser.cpp should be modified to search for
kdesu5 instead of kdesu
Diffs
-
kdesu/CMakeLists.txt 2a70831
Diff: https://git.reviewboard.kde.org/r/120040/diff/
Testing
---
Thanks,
Marco Martin
it to kdesu5, for coinstallability reasons
therefore, kio/src/core/desktopexecparser.cpp should be modified to search for
kdesu5 instead of kdesu
Diffs
-
kdesu/CMakeLists.txt 2a70831
Diff: https://git.reviewboard.kde.org/r/120040/diff/
Testing
---
Thanks,
Marco Martin
, for coinstallability reasons
therefore, kio/src/core/desktopexecparser.cpp should be modified to search for
kdesu5 instead of kdesu
Diffs
-
kdesu/CMakeLists.txt 2a70831
Diff: https://git.reviewboard.kde.org/r/120040/diff/
Testing
---
Thanks,
Marco Martin
, for coinstallability reasons
therefore, kio/src/core/desktopexecparser.cpp should be modified to search for
kdesu5 instead of kdesu
Diffs
-
kdesu/CMakeLists.txt 2a70831
Diff: https://git.reviewboard.kde.org/r/120040/diff/
Testing
---
Thanks,
Marco Martin
it to kdesu5, for coinstallability reasons
therefore, kio/src/core/desktopexecparser.cpp should be modified to search for
kdesu5 instead of kdesu
Diffs
-
kdesu/CMakeLists.txt 2a70831
Diff: https://git.reviewboard.kde.org/r/120040/diff/
Testing
---
Thanks,
Marco Martin
On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote:
I'm a bit worried by the multitude of user and distro specific scripts that
rely on kdesu being present :/
to me either way it gets fixed i'm ok.
the other option is to keep it called kdesu, so it wouldn't be coinstallable so
distributions
On Set. 1, 2014, 4:53 p.m., David Edmundson wrote:
I need some the concept explaining, why would a developer set a
fallbackpackage?
Is it not always org.kde.breeze.desktop?
Marco Martin wrote:
It would usually be the packagestructure setting it, in initPackage(), so
On Set. 1, 2014, 4:53 p.m., David Edmundson wrote:
I need some the concept explaining, why would a developer set a
fallbackpackage?
Is it not always org.kde.breeze.desktop?
Marco Martin wrote:
It would usually be the packagestructure setting it, in initPackage(), so
On Set. 1, 2014, 4:53 p.m., David Edmundson wrote:
I need some the concept explaining, why would a developer set a
fallbackpackage?
Is it not always org.kde.breeze.desktop?
Marco Martin wrote:
It would usually be the packagestructure setting it, in initPackage(), so
On Set. 1, 2014, 4:53 p.m., David Edmundson wrote:
I need some the concept explaining, why would a developer set a
fallbackpackage?
Is it not always org.kde.breeze.desktop?
Marco Martin wrote:
It would usually be the packagestructure setting it, in initPackage(), so
On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote:
I'm a bit worried by the multitude of user and distro specific scripts that
rely on kdesu being present :/
Marco Martin wrote:
to me either way it gets fixed i'm ok.
the other option is to keep it called kdesu, so it wouldn't
://git.reviewboard.kde.org/r/120040/#review65738
---
On Sept. 2, 2014, 6:27 p.m., Marco Martin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://git.reviewboard.kde.org/r/120040/
- Marco Martin
On Sept. 13, 2014, 3:59 p.m., Maarten De Meyer wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120185
Comments/things that should be done there? missing features?
--
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Sept. 16, 2014, 10:33 a.m., Marco Martin wrote:
this approach is probably better than
https://git.reviewboard.kde.org/r/120040/
Maarten De Meyer wrote:
I think we'll need both. We still need to rename the kdesu binary, no?
if it goes in libexec yes, otherwise if it goes
On Tuesday 16 September 2014 14:19:44 Marco Martin wrote:
right now all the classes are still under the Plasma namespace, and should
probably be renamed and cmakes to be cleaned up (especially because it would
be used by plasma too to the two identically named classes, new and
deprecated would
fine for me, namespaces ftw
--
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Wednesday 17 September 2014 17:02:02 Vishesh Handa wrote:
On Tue, Sep 16, 2014 at 2:19 PM, Marco Martin notm...@gmail.com wrote:
right now all the classes are still under the Plasma namespace, and should
probably be renamed and cmakes to be cleaned up (especially because it
would
in playground, under
https://projects.kde.org/projects/playground/libs/kpackage
This means it's open for contributions, suggestions, uses and all that jazz
(reviewboard for it should appear shortly)
--
Marco Martin
___
Kde-frameworks-devel mailing list
--
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.
what's the build error on OSX?
--
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
you are
actually expecting, before pressing submit and then screaming w, shit! as
i did today ;)
Cheers,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
with the dialogtest?
Aleix
hmm, it's offset by one pixel compared to what i get locally.
maybe a different behavior between kwin and openbox?
--
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
/kdelibs4migration.h c26addc
src/lib/util/kdelibs4migration.cpp e1ec678
Diff: https://git.reviewboard.kde.org/r/120480/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
this may break.
Diffs (updated)
-
src/lib/CMakeLists.txt 5ae5c08
src/lib/util/kdelibs4migration.h c26addc
src/lib/util/kdelibs4migration.cpp e1ec678
Diff: https://git.reviewboard.kde.org/r/120480/diff/
Testing
---
Thanks,
Marco Martin
/kdelibs4migration.cpp e1ec678
src/lib/CMakeLists.txt 5ae5c08
src/lib/util/config-kde4home.h.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/120480/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde
/config-kde4home.h.cmake PRE-CREATION
src/lib/util/kdelibs4migration.cpp e1ec678
src/lib/CMakeLists.txt 5ae5c08
Diff: https://git.reviewboard.kde.org/r/120480/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde
/kdelibs4migration.cpp e1ec678
src/lib/CMakeLists.txt 5ae5c08
src/lib/util/config-kde4home.h.cmake PRE-CREATION
src/lib/util/kdelibs4migration.h c26addc
Diff: https://git.reviewboard.kde.org/r/120480/diff/
Testing
---
Thanks,
Marco Martin
On Fri, Oct 10, 2014 at 11:37 PM, David Faure fa...@kde.org wrote:
On Friday 10 October 2014 18:18:40 Marco Martin wrote:
(but even if it doesn't export symbols
i'm not sure removing target_link_libraries is bc?)
Depends if it was a PUBLIC or PRIVATE library (in the target_link_libraries
://git.reviewboard.kde.org/r/120550/#comment47603
would like some apidocs: at the beginning of the class some doc on why and
how use this class, and just a bit of apidoc on loadTexture()
- Marco Martin
On Oct. 13, 2014, 11:13 a.m., Aleix Pol Gonzalez wrote
good
src/quickaddons/managedtexturenode.h
https://git.reviewboard.kde.org/r/120550/#comment47616
even if will always remain just this member, just to me sure, it should be
in a dpointer
- Marco Martin
On Oct. 13, 2014, 11:13 a.m., Aleix Pol Gonzalez wrote
On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote:
src/quickaddons/managedtexturenode.h, line 52
https://git.reviewboard.kde.org/r/120550/diff/2/?file=318205#file318205line52
even if will always remain just this member, just to me sure, it should
be in a dpointer
Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120581/#review68390
---
Ship it!
Inviala!
- Marco Martin
On Ott. 14, 2014, 1:09
On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote:
src/quickaddons/managedtexturenode.h, line 52
https://git.reviewboard.kde.org/r/120550/diff/2/?file=318205#file318205line52
even if will always remain just this member, just to me sure, it should
be in a dpointer
Aleix Pol
in the
notifyrc is used as before
Diffs
-
src/knotification.cpp 0ea13cb
src/notifybypopup.cpp c7add40
src/knotification.h 456e84b
Diff: https://git.reviewboard.kde.org/r/120887/diff/
Testing
---
Thanks,
Marco Martin
___
Kde
to knotification, if none set, the one set in the
notifyrc is used as before
Diffs (updated)
-
src/knotification.h 456e84b
src/knotification.cpp 0ea13cb
src/notifybypopup.cpp c7add40
Diff: https://git.reviewboard.kde.org/r/120887/diff/
Testing
---
Thanks,
Marco Martin
/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Description
---
for
https://bugs.kde.org/show_bug.cgi?id=321688
Diffs
-
src/knotification.h 815d195
src/knotification.cpp 8421eaf
Diff: https://git.reviewboard.kde.org/r/120888/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
icons
--
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
generate a script in
the build dir with the proper command so the process would be eased at least a
little?
Index File Location
The indexer creates the index files in the plugin directories itself, not
+1
--
Marco Martin
___
Kde-frameworks-devel
? comments?
--
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Monday 10 November 2014, Marco Martin wrote:
* porting all the internal and api use of KPluginInfo to KPluginMetadata
* removing all the query functionality, (since it needs
KPluginTrader::applyConstraints) and making instead KPluginTrader able to
find packages as well
Opinions? comments
itself, QQuickView does internally use an incubator as well, even tough
in a slightly different manner it seems.
- Marco Martin
On Nov. 13, 2014, 6:24 p.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply
On Nov. 14, 2014, 12:16 p.m., Marco Martin wrote:
hm, i don't really like it.
is it working around a problem in particular?
if i try the patch, the difference during startup (or just duringopening a
popup on the first time) is pretty noticeable like, the wallpaper appearing
several
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121113/#review70598
---
Ship it!
Ship It!
- Marco Martin
On Nov. 13, 2014, 6:24
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121122/#review71169
---
Ship it!
Ship It!
- Marco Martin
On Nov. 14, 2014, 6:08
to access files from it
there is also a simple little tool called kpackagetool that can be used to
install, remove and list packages.
I would like to submit it (kpackage repo) for the usual 2 weeks period of
review.
--
Marco Martin
___
Kde-frameworks
a Q_DISABLE_COPY or similar in PackageLoader
done
Add const
foreach (QString prefix, d-contentsPrefixPaths) {
done
All those char * params make me a bit unhappy, any reason those are not
QString or QByteArray?
made them QByteArrays
--
Marco Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121411/#review71784
---
Ship it!
Ship It!
- Marco Martin
On Dec. 11, 2014, 3:55
-CREATION
Diff: https://git.reviewboard.kde.org/r/121575/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/kquickcontrolsplugin.cpp PRE-CREATION
src/qmlcontrols/kquickcontrols/plotter.h PRE-CREATION
src/qmlcontrols/kquickcontrols/plotter.cpp PRE-CREATION
src/qmlcontrols/kquickcontrols/qmldir 31d8b14
Diff: https://git.reviewboard.kde.org/r/121581/diff/
Testing
---
Thanks,
Marco Martin
now proposed in kdeclarative) if it
has a huge if not win32 block.
Marco Martin wrote:
ah, doesn't support windows at all? even for libplasma isn't that good
then.
how much boilerplate would be needed to not use it for the graph thing?
Jan Kundrát wrote:
There are some
the necessary cmake stuff in ecm instead of having
it copied in the two repos.
This is the file coming from KWin
Diffs
-
find-modules/Findepoxy.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/121575/diff/
Testing
---
Thanks,
Marco Martin
the issue
- Marco Martin
On Dec. 19, 2014, 11:55 a.m., David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121595
, the rest is different bewteen indexing
of libraries and packages.
One thing tough: since this wouldn't affect the API and if possible we would
kinda need this framework in the next workspace release, could this go in,
then moving parts afterwards?
--
Marco Martin
-CREATION
CMakeLists.txt 233ccce
cmake/Findepoxy.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/121581/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
install/uninstall it will delete the job before it's finished.
should be safe to don't have any parent since kjobs shuold delete themselves
iirc? (changed to that)
There's a Qt5 TODO on PackageJobThread::removeFolder
changed to just use QDir::removeRecursively()
--
Marco Martin
On Monday 10 November 2014, Marco Martin wrote:
Hi all,
since at akademy there seemed the interest in it,
I have been working on some classes i extracted from libplasma to be on
their own, those related to Plasma::Package, since several applications
have the interest of having scriptable
://gerrit.vesnicky.cesnet.cz/r/#/c/260/)
--
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
src/qmlcontrols/kquickcontrolsaddons/plotter.cpp PRE-CREATION
CMakeLists.txt 233ccce
cmake/Findepoxy.cmake PRE-CREATION
src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 786aaa5
Diff: https://git.reviewboard.kde.org/r/121581/diff/
Testing
---
Thanks,
Marco Martin
/qmlcontrols/kquickcontrolsaddons/plotter.h 3a10212
src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 1ea7fad
Diff: https://git.reviewboard.kde.org/r/122430/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde
compared to 100%
Diffs (updated)
-
src/qmlcontrols/kquickcontrolsaddons/plotter.h 3a10212
src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 1ea7fad
Diff: https://git.reviewboard.kde.org/r/122430/diff/
Testing
---
Thanks,
Marco Martin
://git.reviewboard.kde.org/r/122430/#review75430
---
On Feb. 4, 2015, 5:07 p.m., Marco Martin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Feb. 3, 2015, 8:43 p.m., David Edmundson wrote:
Next set of bugs:
- what about if the paintedWidth is requested before the item's source has
first been set?
- or if the item is currently invisible? (what should that return? I'm not
sure what Image does)
Other thought:
- Marco Martin
On Feb. 3, 2015, 5:11 p.m., Bhushan Shah wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122408
still be removed from paint()
src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp
https://git.reviewboard.kde.org/r/122413/#comment52152
i'm not sure setting the panted rect in paint changes anything.
since it's done in setPixmap/setFillmode, that should be enough?
- Marco Martin
On Feb. 4, 2015, 12:59 p.m., Marco Martin wrote:
src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 115
https://git.reviewboard.kde.org/r/122413/diff/4/?file=346726#file346726line115
i'm not sure setting the panted rect in paint changes anything.
since it's done
of the graph has the same proportion of the percentage
compared to 100%
Diffs
-
src/qmlcontrols/kquickcontrolsaddons/plotter.h 3a10212
src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 1ea7fad
Diff: https://git.reviewboard.kde.org/r/122430/diff/
Testing
---
Thanks,
Marco Martin
/filewidgets/kfileplacessharedbookmarks_p.h 4c9f6a4
Diff: https://git.reviewboard.kde.org/r/122459/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
/kfileplacessharedbookmarks.cpp fbd6b53
src/filewidgets/kfileplacessharedbookmarks_p.h 4c9f6a4
Diff: https://git.reviewboard.kde.org/r/122459/diff/
Testing
---
Thanks,
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
for KDE Frameworks and Marco Martin.
Repository: kdeclarative
Description
---
Use math.h round rather than C++11 std::lround.
Removes dependency on C++11.
Diffs
-
src/qmlcontrols/kquickcontrolsaddons/plotter.cpp
67ce63a943234b167165b0f3986f974bba5ff0cf
Diff
would go with it, can you push?
--
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Tier 2 policy correctly, is not allowed :-) Is
there a plan to move it to Tier 3, or remove the dependency? Sorry if this
was discussed before.
if also optional is a problem, it can be just removed
--
Marco Martin
___
Kde-frameworks-devel mailing list
in sysguard taking a
look at it as well tough)
- Marco Martin
On Jan. 15, 2015, 1:24 p.m., Eike Hein wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122072
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122514/#review75865
---
+1 from me
- Marco Martin
On Feb. 10, 2015, 5:18 p.m
that seems fine
src/knotifyconfigelement.h
https://git.reviewboard.kde.org/r/122554/#comment52536
uuh, this seems not exported, so should be fine to rename i think
- Marco Martin
On Feb. 13, 2015, 7:42 p.m., Jeremy Whiting wrote
kdesu is installed as well
- Marco Martin
On Oct. 4, 2014, 3:32 p.m., Maarten De Meyer wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120185
On Jan. 29, 2015, 3:01 p.m., Marco Martin wrote:
any updates on that?
here the patch works correctly after i make kdesu to be installed under
CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 instead of CMAKE_INSTALL_FULL_LIBEXECDIR
I would push this asap, since kdesu in Plasma 5 is *still
201 - 300 of 1771 matches
Mail list logo
