D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > broulik wrote in containmentinterface.cpp:1073 > Not sure if we should use `this` (and then check `if m_containment` as > context or `m_containment` should be the same

D6554: [Plasma Dialog] Fix flag condition

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6554 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6899: support X-KDE-OnlyShowOnQtPlatforms

mart added a comment. ah, yeah, that's a leftover, should go REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: broulik, #frameworks

D6899: support X-KDE-OnlyShowOnQtPlatforms

mart updated this revision to Diff 17177. mart added a comment. less blanks REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6899?vs=17176=17177 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6899 AFFECTED FILES src/kded.cpp src/kded.h

D6899: support X-KDE-OnlyShowOnQtPlatforms

mart marked 2 inline comments as done. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

mart created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY some kded modules can only run in one platform, especially only xcb or only wayland. this makes kded support the

D6899: support X-KDE-OnlyShowOnQtPlatforms

mart added reviewers: Frameworks, Plasma. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: #frameworks

D6899: support X-KDE-OnlyShowOnQtPlatforms

mart updated this revision to Diff 17176. mart added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. readstringlist REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6899?vs=17175=17176 BRANCH

D6776: Don't perform wayland specific fixes when on X

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D6776 To: davidedmundson, #plasma, mart Cc: graesslin, plasma-devel,

D6418: [XDGV6] manage every ping sent

mart updated this revision to Diff 16044. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - pingDelayed signal REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6418?vs=15997=16044 BRANCH

Re: Kirigami in Frameworks

, 2017 at 2:44 PM, David Faure <fa...@kde.org> wrote: > What's the status with the move of Kirigami to frameworks? > Do we want it in 5.36 tomorrow? > > AFAICS it's still in extragear/libs/kirigami in kde_projects.xml. > > David. > > On lundi 26 juin 2017 11:25:08 CEST

D6390: WIP: Add remote runners over DBus

mart added a comment. love the idea. when this goes in, at least one using this should already exist, to make sure the code gets well tested from day one. this makes me think... it's not exacrtly the same thing, maybe kindof a layer, but would be possible to start from this and have

Re: Kirigami in Frameworks

On Saturday 01 July 2017, David Faure wrote: > On vendredi 30 juin 2017 15:16:17 CEST Marco Martin wrote: > > Hi, > > I have moved it, should be good to go. > > one sidenote (hoping is not a problem) for historical reasons, the > > tarballs were called kirigami2-versi

Re: Kirigami in Frameworks

th this as well -- Marco Martin

D6484: emit runningActivityListChanged on activity creation

mart added a reviewer: ivan. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D6484 To: mart, #plasma, ivan Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6484: emit runningActivityListChanged on activity creation

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY if an activity gets created and started immediately, runningActivityListChanged wasn't emitted, a symptom was the

D6484: emit runningActivityListChanged on activity creation

This revision was automatically updated to reflect the committed changes. Closed by commit R6:dce2a89774c6: emit runningActivityListChanged on activity creation (authored by mart). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6484?vs=16130=16134 REVISION

D6518: guard against themes without a valid shadow

mart added a comment. In https://phabricator.kde.org/D6518#121981, @davidedmundson wrote: > What if a theme only has shadow-top, but not right etc. > (or a more likely scenario, they exist, but the metadata has them be 0px big) > > What would happen if you have a theme with shadow

D6523: check Buffer validity

mart created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY if a plasma theme doesn't provide shadow graphics, the buffer will be a nullptr as would be created from an

D6518: guard against themes without a valid shadow

mart added a comment. replaced by https://phabricator.kde.org/D6523 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6518 To: mart, #plasma Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6523: check Buffer validity

mart added a comment. In https://phabricator.kde.org/D6523#122107, @davidedmundson wrote: > Same question as before, what happens when we go from a theme with shadows to a theme without? I tried to switch back and forth several times between breeze and keramiek(the theme linked

D6523: check Buffer validity

This revision was automatically updated to reflect the committed changes. Closed by commit R127:dd8e084a685e: check Buffer validity (authored by mart). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6523?vs=16229=16242 REVISION DETAIL

D6518: guard against themes without a valid shadow

mart abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6518 To: mart, #plasma Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D6047: WIP: Support XDG v6

mart added a comment. right now, the xdgv6 branch (xdgv6popup actually) for me causes a crash in kwin at startup, with the following BT: #0 _int_malloc (av=av@entry=0x7556ab20 , bytes=bytes@entry=72) at malloc.c:3414 #1 0x7522a5d4 in __GI___libc_malloc (bytes=72) at

D6418: [XDGV6] manage every ping sent

mart added a comment. In https://phabricator.kde.org/D6418#120319, @davidedmundson wrote: > > for how i did the kwin part, it must be who called it with discardTimer (this to allow kwin to receive 2 timeouts before deciding to kill the window) > > Ok, I see how it's meant to work but

D6418: [XDGV6] manage every ping sent

mart updated this revision to Diff 15989. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - get rid of discardPing REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6418?vs=15948=15989 BRANCH

D6418: [XDGV6] manage every ping sent

mart updated this revision to Diff 15997. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - quint32 everywhere REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6418?vs=15989=15997 BRANCH

D6518: guard against themes without a valid shadow

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY some themes don't have a valid shadow, which would lead to a crash in kwayland, don't even try to render a shadow if

D6418: [XDGV6] manage every ping sent

mart created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY if more ping arrives before a pong, store each of its serial and manage them one by one a new signal,

D6418: [XDGV6] manage every ping sent

mart added a comment. In https://phabricator.kde.org/D6418#120218, @davidedmundson wrote: > who deletes the qtimer if it times out? > > can this timer stuff be shared by moving it into XdgShellInterface::Private ? for how i did the kwin part, it must be who called it with

D5593: Introduce units.iconSizeHints.* to provide user-configurable icon size hints

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5593 To: hein, #plasma, mart Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai,

D5603: Install Plasma Components 3 so they can be used

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:45 > > -DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/plasma/components.3) > +DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/plasma/components/3)

D5605: Allow multiple categories with the same name

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY the category name was intended as a kind of unique id, this isn't true anymore, so multiple categories can have the

D5605: Allow multiple categories with the same name

mart added a reviewer: whiting. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5605 To: mart, #plasma, leinir, whiting Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5603: Install Plasma Components 3 so they can be used

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. thanks, awesome now =) REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5603 To: davidedmundson, #plasma, mart Cc: mart,

D6964: Force Plasma style for QQC2 in applets

mart updated this revision to Diff 17325. mart added a comment. comment useless debug REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6964?vs=17324=17325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6964 AFFECTED

D6964: Force Plasma style for QQC2 in applets

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY using the qml url interceptor, rewrite imports in order to load always the plasma styled qqc2 controls in plasmoids and

D6964: Force Plasma style for QQC2 in applets

mart added a comment. In https://phabricator.kde.org/D6964#129762, @davidedmundson wrote: > > ‎[13:51] ‎<‎notmart‎>‎ hmm, still random failures in loading components > > ‎[13:58] ‎<‎notmart‎>‎ gaah, import of a subdirectory still breaks > > Is this fixed? no, that's the

D6899: support X-KDE-OnlyShowOnQtPlatforms

mart added a comment. In https://phabricator.kde.org/D6899#133625, @dfaure wrote: > "Show" is a bit of a historical name here, this isn't about showing apps in a menu... > > X-KDE-OnlyLoadOnQtPlatforms would be closer to the truth, no? > > Looks good otherwise. that would

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6894 To: broulik, #plasma, mart Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7127: ignore spurious resize events to empty sizes

mart updated this revision to Diff 17832. mart added a comment. more comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7127?vs=17712=17832 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7127 AFFECTED FILES

D7127: ignore spurious resize events to empty sizes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0c27df529d80: ignore spurious resize events to empty sizes (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D7127: ignore spurious resize events to empty sizes

mart added a comment. finally figured out where this event is generated: it's a spontaneous event generated in qguiapplication.cpp QGuiApplicationPrivate::processWindowScreenChangedEvent around line 2209 QWindowSystemInterfacePrivate::GeometryChangeEvent gce(window,

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

mart added a comment. looking into it, i still think the dialog code is correct. what happens is that someone external resizes the notification window to 0x0 pixels wide right after the componentcomplete event. if as in this patch the dialog is resized explicitly in componentcomplete, that

D6964: Force Plasma style for QQC2 in applets

mart updated this revision to Diff 17703. mart added a comment. ignore resizes to empty sizes on multiscreen, it happens that notification windows areresized to 0,0 by somebody else (not dialog code, perhaps kwin, perhaps notification applet this makes the notification main item

D6964: Force Plasma style for QQC2 in applets

mart updated this revision to Diff 17706. mart added a comment. remove unrelated changes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6964?vs=17703=17706 BRANCH arcpatch-D6964 REVISION DETAIL https://phabricator.kde.org/D6964

D7127: ignore spurious resize events to empty sizes

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > broulik wrote in dialog.cpp:1045 > So it will never update its size? Shouldn't it be size == oldSize? ouch, sure, sorry :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D7127: ignore spurious resize events to empty sizes

mart updated this revision to Diff 17712. mart added a comment. - fix check REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7127?vs=17704=17712 BRANCH arcpatch-D7127 REVISION DETAIL https://phabricator.kde.org/D7127 AFFECTED FILES

D7127: ignore spurious resize events to empty sizes

mart marked an inline comment as done. mart added a comment. not sure how to proceed in debugging this, as all i have is a resize event handler being called, which a backtrace there is useless to figure out who is resizing it REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D7369: [WIP] Wayland foreign protocol

mart updated this revision to Diff 18596. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - Don't call release twice - Correctly set - don't call destroy in the destroyed callback - add a test exporting a surface two times - test

D7369: [WIP] Wayland foreign protocol

mart added a comment. now the client part is wrapped too, so no V1 exported (the public facing classes should lose "Unstable" probably) two more tests to check that importing the same exported in two clients works and exporting the same surface two times works as well. thanks to david's

D7369: [WIP] Wayland foreign protocol

mart edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7369 To: mart, #plasma, #kwin Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D7369: [WIP] Wayland foreign protocol

mart added inline comments. INLINE COMMENTS > xdgforeign_v1_interface.cpp:212 > +QHash parents; > +QHash children; > + the children hash may have to become a multihash to permit more children for a single parent REPOSITORY R127 KWayland REVISION DETAIL

D7369: [WIP] Wayland foreign protocol

mart created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Implement the "foreign" wayland protocol. A client can export a surface with an unique string as handle,

D7369: [WIP] Wayland foreign protocol

mart marked 2 inline comments as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in xdgforeign_v1_interface.cpp:299 > this should be connected to unbound. perhaps the connects to the destruction of the SurfaceInterface* are not even necessary? REPOSITORY R127

D7369: [WIP] Wayland foreign protocol

mart added inline comments. INLINE COMMENTS > graesslin wrote in registry.h:938-939 > The general pattern I used for protocols which might get another revision is > to create a "meta" class which hides the UnstableV1 mess. C.f. the > PointerConstraints a line above. i see the types are named

D5783: Use application name instead of pid when creating SNI dbus service

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. definitely better! i don't know whether we can afford to change it in any way outside the sanbox and not break things.. it may make sense to use applicationName-pid at least inside the

D5806: [WIP] when building menu hyerarchies, parent menus to their containers

mart retitled this revision from "[WIP] when building menu hierarchies, parent menus to their containers" to "[WIP] when building menu hyerarchies, parent menus to their containers". REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5806 To: mart, #plasma,

D5806: [WIP] when building menu hierarchies, parent menus to their containers

mart added reviewers: Plasma on Wayland, Frameworks. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5806 To: mart, #plasma, #plasma_on_wayland, #frameworks Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5806: [WIP] when building menu hierarchies, parent menus to their containers

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Wayland requires menu windows to have a "transient parent" as wl_shell protocol refuses to either position correcty or

D5783: Use application name instead of pid when creating SNI dbus service

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. are we sure applicationname is unique? what about of multiple instances of the same application? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D5783

D5783: Use application name instead of pid when creating SNI dbus service

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. are we sure applicationname is unique? what about of multiple instances of the same application? REPOSITORY R289 KNotifications BRANCH application-dbus (branched from master) REVISION

D5806: When building menu hyerarchies, parent menus to their containers

mart added a comment. possible fix https://phabricator.kde.org/D5900 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5806 To: mart, #plasma, #plasma_on_wayland, #frameworks, davidedmundson Cc: lbeltrame, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr,

D5900: use transientparent directly

mart created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY don't parent directly as we don't want unwanted deletions. ensure we have a menu, not parented yet, the container exists, both the menu and

D5900: use transientparent directly

mart updated this revision to Diff 14630. mart added a comment. call windid only once REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5900?vs=14629=14630 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5900 AFFECTED FILES

D5900: use transientparent directly

This revision was automatically updated to reflect the committed changes. Closed by commit R263:4690808e65f1: use transientparent directly (authored by mart). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5900?vs=14630=14631 REVISION DETAIL

D5745: recreate plasmashellsurf on exposed, destoy on hidden

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fd2e850156ac: recreate plasmashellsurf on exposed, destoy on hidden (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5745: recreate plasmashellsurf on exposed, destoy on hidden

mart updated this revision to Diff 14435. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5745?vs=14247=14435 BRANCH

D5773: [WIP] workarounds for menu positioning

mart updated this revision to Diff 14438. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - more aggressive reparenting in open() REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5757: add requestToggleKeepAbove/below

mart updated this revision to Diff 14581. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - fix comment REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14320=14581 BRANCH arcpatch-D5757

D5757: add requestToggleKeepAbove/below

mart updated this revision to Diff 14582. mart added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - fix comment REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14581=14582 BRANCH arcpatch-D5757

D5757: add requestToggleKeepAbove/below

mart marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D5773: [WIP] workarounds for menu positioning

This revision was automatically updated to reflect the committed changes. Closed by commit R242:680a8a9e2832: [WIP] workarounds for menu positioning (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5773?vs=1=14445

D5806: When building menu hyerarchies, parent menus to their containers

mart retitled this revision from "[WIP] when building menu hyerarchies, parent menus to their containers" to "When building menu hyerarchies, parent menus to their containers". REPOSITORY R263 KXmlGui BRANCH phab/reparentmenus REVISION DETAIL https://phabricator.kde.org/D5806 To: mart,

D5773: [WIP] workarounds for menu positioning

mart updated this revision to Diff 1. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - remove duplication REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5773?vs=14438=1

D5806: When building menu hyerarchies, parent menus to their containers

This revision was automatically updated to reflect the committed changes. Closed by commit R263:b5af0296cb2f: When building menu hyerarchies, parent menus to their containers (authored by mart). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE

D6215: Make sure size is final after showEvent

mart added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6215: Make sure size is final after showEvent

mart added a comment. In https://phabricator.kde.org/D6215#117498, @davidedmundson wrote: > > this will work only when the Dialog' version of setvisible is called, > > So this will break released Plasma? no, it just means that who calls show() or the wrong setVisible() would

D6215: Make sure size is final after showEvent

mart edited the summary of this revision. mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks,

D6215: Make sure size is final after showEvent

mart added a comment. so, on the 5 points: 1. yes, is necessary, resizing windows in their show event is definitely not enough, causes events to arrive to reset to the old geometry in race with the setgeometry done there, if it's the qpa, if it's qwindow, if it's the windowmanager

D6215: Make sure size is final after showEvent

This revision was automatically updated to reflect the committed changes. Closed by commit R242:eab4aa9909a6: Make sure size is final after showEvent (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6215?vs=15579=15682

Re: Kirigami in Frameworks

As there were no replies for quite a while, i assume there are no particular objections. so, how to proceed? what needs to be doe to do the actual move? On Mon, Jun 5, 2017 at 2:42 PM, Marco Martin <notm...@gmail.com> wrote: > Hi all, > The Kirigami component set always

Re: Kirigami in Frameworks

whops, forgot cc to kde-frameworks, resending On Sat, Jun 24, 2017 at 10:58 AM, David Faure <fa...@kde.org> wrote: > On lundi 5 juin 2017 14:42:47 CEST Marco Martin wrote: >> Hi all, >> The Kirigami component set always was targeted to be eventually released as >>

D6047: WIP: Support XDG v6

mart added a comment. trying to implement the kwin part of ping btw, will do in a branch of the branch kwin/xdgv6 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff,

D6313: WIP: Support device pixel ratio in icon loader and engine

mart added a comment. In https://phabricator.kde.org/D6313#118285, @kvermette wrote: > Behaviorally speaking there's justification for ensuring SVGs are treated the same as PNGs in this case. Looking at the code we aren't shimming the SVGs specifically (unless I'm missing something),

Re: Kirigami in Frameworks

file under examples/ ? > > Much better the way you did it, it's how I see it done in most other > frameworks. > It makes it easy to enable the building of examples once and for all in > kdesrc-buildrc for instance, to make sure they keep compiling and so that they > are available for testing. > In fact, I wonder if the CI shouldn't set BUILD_EXAMPLES=ON in all frameworks > that have that option... (4 currently, 5 with kirigami). ok -- Marco Martin

D6047: WIP: Support XDG v6

mart added inline comments. INLINE COMMENTS > graesslin wrote in xdgshell_interface.h:80 > @davidedmundson for the ping you could check the old wl_shell_surface > implementation in KWayland. the implementation here in xdgshell_interface is basically copied over the kwayland

Re: Kirigami in Frameworks

On Wed, Jun 21, 2017 at 6:22 PM, Jonathan Riddell <j...@jriddell.org> wrote: > On 21 June 2017 at 15:00, Marco Martin <notm...@gmail.com> wrote: >> As there were no replies for quite a while, i assume there are no >> particular objections. >> >> so, how

D6047: WIP: Support XDG v6

mart added a comment. In https://phabricator.kde.org/D6047#119765, @graesslin wrote: > In https://phabricator.kde.org/D6047#119698, @mart wrote: > > > trying to implement the kwin part of ping btw, will do in a branch of the branch kwin/xdgv6 > > > no need to hurry with it.

D5914: Add template for Plasma QML Applet with QML extension

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH addtemplateforplasmoidwithqmlplugin REVISION DETAIL https://phabricator.kde.org/D5914 To: kossebau, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot,

D5912: minimize dialog resizes/moves

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY take into account size hints also when adjusting with synctomainitemsize which sometimes has to be executed right before

D5757: add requestToggleKeepAbove/below

mart added a comment. ping? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D5757 To: mart, #plasma, hein, graesslin, #plasma_on_wayland Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5757: add requestToggleKeepAbove/below

This revision was automatically updated to reflect the committed changes. Closed by commit R127:e8e88174571c: add requestToggleKeepAbove/below (authored by mart). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14582=14807 REVISION DETAIL

D5912: minimize dialog resizes/moves

mart updated this revision to Diff 14809. mart added a comment. - use settype, not setflags REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5912?vs=14690=14809 BRANCH arcpatch-D5912 REVISION DETAIL https://phabricator.kde.org/D5912

D5912: minimize dialog resizes/moves

mart added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D5912: minimize dialog resizes/moves

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in tooltipdialog.cpp:45 > Calling set flags explicitly and set type explicitly is conflicting. now just uses settype, tested on x11, still works and tooltip windows still has _NET_WM_WINDOW_TYPE_TOOLTIP settype is needed in

D5912: minimize dialog resizes/moves

mart updated this revision to Diff 14688. mart added a comment. - remove updategeometryblocked REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5912?vs=14674=14688 BRANCH phab/dialogresize REVISION DETAIL

D5912: minimize dialog resizes/moves

mart added a comment. now tooltips are animated again REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D5918: set transientparent for menus

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY set transient parent for popup menus created by appletinterface/ containmentinterface, it makes them appear at the proper

D5918: set transientparent for menus

mart added a comment. In https://phabricator.kde.org/D5918#110833, @davidedmundson wrote: > Please test under x. no noticeable difference in x REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5918 To: mart, #plasma, davidedmundson Cc:

<    5   6   7   8   9   10   11   12   13   14   >