Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

e same. Similar one doesn't need the QWidget usage as QWindow is already there. - Martin Gräßlin On Dec. 13, 2015, 2:54 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

tps://git.reviewboard.kde.org/r/126198/#comment61219> this looks like a not needed debug statement, same in dtor and loadSettings and KFontSettings - Martin Gräßlin On Dec. 12, 2015, 7:08 p.m., René J.V. Bertin

Re: Review Request 126312: Add xcb variant for static KStartupInfo::sendFoo methods

, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126312: Add xcb variant for static KStartupInfo::sendFoo methods

/kstartupinfo.cpp a97b8b5416ca67a083960a76093933fb098327a5 src/kstartupinfo.h dfcd42797d887ca6d43161f8c3b767ad436e5116 Diff: https://git.reviewboard.kde.org/r/126312/diff/ Testing --- autotest still passes Thanks, Martin Gräßlin ___ Kde-frameworks-devel

Review Request 126313: Use an xcb for interaction with KStartupInfo

--- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126314: Port klauncher to xcb

://git.reviewboard.kde.org/r/126314/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.h, lines 41-54 > > <https://git.reviewboard.kde.org/r/126198/diff/6/?file=420929#file420929line41> > > > > why did you add the virtual? The methods are marked as Q

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/main_mac.cpp, line 45 > > <https://git.reviewboard.kde.org/r/126198/diff/6/?file=420937#file420937line45> > > > > why does the mac platform want to setupXcbFlush? > > René J.

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

tps://git.reviewboard.kde.org/r/126198/#comment61002> same here src/platformtheme/kdemactheme.mm (line 188) <https://git.reviewboard.kde.org/r/126198/#comment61001> do we still need that? I thought 5.3 is the minimum version anyway - Martin Gräßlin On Dec. 4, 2015, 2:05 p.m., René

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

hy does the mac platform want to setupXcbFlush? - Martin Gräßlin On Dec. 3, 2015, 10:51 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 8:38 a.m., Martin Gräßlin wrote: > > Just wondering: if your main aim is to change default settings, why don't > > follow what linux distros do? That is ship some default configuration > > interface. For inspiration check e.g. kubuntu-default-settings.

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 2, 2015, 10:45 a.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

ment60946> please use the newer and easier endif() variant. - Martin Gräßlin On Dec. 1, 2015, 9:29 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

integration. In my opinion framework integration should only be about Plasma. I'll start a new thread about it. - Martin Gräßlin On Nov. 29, 2015, 8:53 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

> On Nov. 23, 2015, 8:13 a.m., Martin Gräßlin wrote: > > are you sure it means that? I mean I did read the documentation when > > writing that code and did deliberately wrote the code like that. So I'm a > > little bit surprised that I got it exactly the other way around.

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

the documentation when writing that code and did deliberately wrote the code like that. So I'm a little bit surprised that I got it exactly the other way around. - Martin Gräßlin On Nov. 22, 2015, 2:57 a.m., David Edmundson wrote

Re: Review Request 126123: [Linux/Kubuntu] find udev when installing to a parallel prefix

a /opt setup for years and udev was always found. Can you show the error you hit? - Martin Gräßlin On Nov. 20, 2015, 1:41 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: KIdleTime: early and/or failing/rejected timeout detection?

Am 2015-11-18 12:33, schrieb René J. V. Bertin: Actually, there is one thing I may have missed in the documentation, if it's there: Is KIdleTime supposed to detect system idling, or application idling? As it happens, it should be possible to make a distinction between the two with the

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 18, 2015, 8:22 a.m., Martin Gräßlin wrote: > > src/plugins/osx/macpoller.cpp, lines 222-227 > > <https://git.reviewboard.kde.org/r/126078/diff/6/?file=417217#file417217line222> > > > > seriously? You care about idle timeouts below 5 msec?

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

> On Nov. 18, 2015, 8:22 a.m., Martin Gräßlin wrote: > > src/plugins/osx/macpoller.cpp, lines 222-227 > > <https://git.reviewboard.kde.org/r/126078/diff/6/?file=417217#file417217line222> > > > > seriously? You care about idle timeouts below 5 msec?

Re: Review Request 126087: Move the i18n context from KDeclarative

> On Nov. 17, 2015, 10:58 a.m., Marco Martin wrote: > > Here's the reason I don't like it: > > In origin KDeclarative was intended to be a library that only depended from > > Qt stuff, to be at most tier 2 (and imports there were supposed to be > > qt-only as well) and frameworks applications

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

ove my finger from one key to another. What exactly is that you want to detect here? An event after each key press, maybe even between a key press and a key release? Because that's probably already more about 5 msec. - Martin Gräßlin On Nov. 17, 2015, 10:13 p.m., René J.V. Bertin

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88456 --- should the file be added to ksnapshot? - Martin Gräßlin

Re: Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126047/#review88327 --- Ship it! Ship It! - Martin Gräßlin On Nov. 12, 2015, 8:24

Re: Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

and if not we have the xembed-sni-proxy. Thoughts on that? Maybe bound to the Qt version which introduced the SNI support? - Martin Gräßlin On Nov. 12, 2015, 8:24 p.m., David Edmundson wrote: > > --- > This is an automatically generat

Review Request 126028: Add support for desktopFileName to NETWinInfo

, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125975: X11 build system cleanup

marked as submitted. Review request for KDE Frameworks, Plasma and Marco Martin. Changes --- Submitted with commit 9030405089bd9cc5ac663913d828e70939c69716 by Martin Gräßlin to branch master. Repository: plasma-framework Description --- Use newer cmake syntax for XCB dependencies

Review Request 125975: X11 build system cleanup

/plasma/CMakeLists.txt 73f308cf5ac8371c1d259c335edcb069117c5c11 src/plasmaquick/CMakeLists.txt 1ddc61123e2a061b42d14cbd1065a70458fdd2d7 Diff: https://git.reviewboard.kde.org/r/125975/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde

Re: Review Request 125961: [declarative/core] Use BypassWindowManagerHint only on platform X11

9272 - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125961/#review88056 --- On Nov. 5, 2015, 4:38 p.m., Marti

Review Request 125961: [declarative/core] Use BypassWindowManagerHint only on platform X11

4e0fe8bf95d51c282060a0a05914c976cd4e5783 src/declarativeimports/core/config-x11.h.cmake PRE-CREATION src/declarativeimports/core/tooltipdialog.cpp 121ccf91bb17c5dd17e0742831830186e9e44a1e Diff: https://git.reviewboard.kde.org/r/125961/diff/ Testing --- Thanks, Martin Gräßlin

Re: Review Request 125915: Drop runtime dependency on QApplication

high for little benefit. - Martin Gräßlin On Nov. 1, 2015, 11:58 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125905: Make kactivitymanagerd a QApplication

Updated Nov. 1, 2015, 2:33 a.m.) > > > Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić. > > > Repository: kactivities > > > Description > --- > > KWindowSystem is QWidget based so needs QApplication or asserts in some > situati

Re: Review Request 125905: Make kactivitymanagerd a QApplication

, 2:33 a.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125905/ > --- > > (Updated Nov. 1, 2015, 2:33 a.m.) > > > Review request for KDE Framewor

Re: Review Request 125915: Drop runtime dependency on QApplication

> On Nov. 2, 2015, 9:04 a.m., Martin Gräßlin wrote: > > I consider this a very dangerous change. We don't have unit tests for this > > specific code, it's an unlikely code path to be taken and we won't notice > > regressions. > > > > Personally I don't see a

Re: Review Request 125449: Add support for desktop file name to KAboutData

marked as submitted. Review request for KDE Frameworks, David Faure and Marco Martin. Changes --- Submitted with commit c0313039170d751c61a44a8f97e199b7ed8ffa4f by Martin Gräßlin to branch master. Repository: kcoreaddons Description --- This change introduces a way to set the new

Re: Review Request 125860: Handle proxying qInfo messages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125860/#review87670 --- Ship it! Ship It! - Martin Gräßlin On Oct. 29, 2015, 2:59

Re: Review Request 125859: Wait for async call starting helper to finish before checking the reply

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125859/#review87669 --- Ship it! looks correct to me. Nice spot! - Martin Gräßlin

Re: Review Request 125763: Add Skip Close Animation to NET::Property2

what the changes to NETWinInfo are supposed to do. - Martin Gräßlin On Oct. 23, 2015, 12:41 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

> On Oct. 23, 2015, 8:41 a.m., Martin Gräßlin wrote: > > src/platforms/xcb/kwindoweffects.cpp, line 333 > > <https://git.reviewboard.kde.org/r/125736/diff/4/?file=412114#file412114line333> > > > > nitpick: unrelated whitespace change. > > Boudhayan G

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

d be to add it to the NET_SUPPORTED in NETWM. src/platforms/xcb/kwindoweffects.cpp (line 333) <https://git.reviewboard.kde.org/r/125736/#comment59953> nitpick: unrelated whitespace change. - Martin Gräßlin On Oct. 21, 2015, 5:23 p.m., Bou

Re: Review Request 125756: Initialize QFunctionPointer to nullptr

e move to cpp file. Meh, I want full C++11 on Linux only code. - Martin Gräßlin On Oct. 22, 2015, 2 p.m., Dāvis Mosāns wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: Review Request 125756: Initialize QFunctionPointer to Q_NULLPTR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125756/#review87264 --- Ship it! Ship It! - Martin Gräßlin On Oct. 22, 2015, 2:31

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

s_x11.h (line 26) <https://git.reviewboard.kde.org/r/125736/#comment59909> why are you going for multiple inheritance? I would have gone for: class KWindowEffectsPrivate2 : public KWindowEffectsPrivate { ... } and class KWindowEffectsPrivateX11 : public KWindowEffe

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

B in class 2, > > but a plugin only wants to implement feature B without implementing feature > > A, they can't if you do what you're asking. > > Martin Gräßlin wrote: > I see what you mean. But that could also be achieved with default > implementation instead

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

ically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125736/ > --- > > (Updated Oct. 21, 2015, 1:55 p.m.) > > > Review request for KDE Frameworks and Martin Gräßlin. > > > Reposi

Re: Review Request 125656: Drop empty files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125656/#review87196 --- +1, I like this solution to the problem! - Martin Gräßlin

Re: Review Request 125449: Add support for desktop file name to KAboutData

approval. - Martin Gräßlin On Sept. 29, 2015, 1:53 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125725: Make KCrash optional for kservice

> On Oct. 20, 2015, 3:52 p.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca_main.cpp, line 122 > > > > > > Maybe it would make sense to handle it using signal() directly here, > > rather than

Re: Review Request 125725: Make KCrash optional for kservice

top of that (would it be > "use one or the other, they are fully independent and exclusive", or would it > extend this mechanism - well, by setting that crash-handler function, maybe). > > Martin Gräßlin wrote: > > given kglobalaccel + kinit use KCrash, too. &

Re: Review Request 125656: Add missing license

or removed to still be a framework. - Martin Gräßlin On Oct. 16, 2015, 2:23 p.m., Maximiliano Curia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 125525: Perform deep copy of QByteArray get_stringlist_reply

/platforms/xcb/netwm.cpp 3c70ed6baf07c38bf59b8102960e819792e46c93 Diff: https://git.reviewboard.kde.org/r/125525/diff/ Testing --- My KWin unit test does no longer fail Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 125525: Perform deep copy of QByteArray get_stringlist_reply

marked as submitted. Review request for KDE Frameworks, kwin and Albert Astals Cid. Changes --- Submitted with commit 246a3d64326ba8a357b12cbe4212b423dced7838 by Martin Gräßlin to branch master. Repository: kwindowsystem Description --- The code used fromRawData instead of a deep

Re: Review Request 125237: Change KKeyserver (x11) to categorized logging

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 9a0431fc5a275ced2e410f8e815c9fd07685d715 by Martin Gräßlin to branch master. Repository: kwindowsystem Description --- Introduces a dedicated logging category for the kkeyserver. Diffs

Re: Review Request 125238: [xcb] Consider mods in KKeyServer as initialized on platform != x11

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 4b9317af68bd1758dd2675d8e8386d674c927945 by Martin Gräßlin to branch master. Repository: kwindowsystem Description --- Calling initializeMods again won't change anything, just print a warning

Re: Review Request 120228: Support Gerrit in the fancy header style

Example for a new change https://git.reviewboard.kde.org/media/uploaded/files/2014/09/16/60cdd1c0-d911-49a7-b184-cbb424d45ae1__gerrit-fancy-.png Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 125309: Support multiple X servers in the NETWM classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125309/#review86093 --- Ship it! Ship It! - Martin Gräßlin On Sept. 28, 2015, 5

Review Request 125449: Add support for desktop file name to KAboutData

added unit test. For the command line parser I only tested whether it gets added to applications. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125259: Support multiple X servers in the NETWM classes

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 4d8394a5c4249e6b743aeb6d38bb2dda18266c42 by Martin Gräßlin to branch master. Repository: kwindowsystem Description --- So far on first creation of a NETRootInfo or NETWinInfo a static

Re: Review Request 125259: Support multiple X servers in the NETWM classes

patch version went in - Martin Gräßlin On Sept. 18, 2015, 10:19 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125309: Support multiple X servers in the NETWM classes

> On Sept. 28, 2015, 2:56 p.m., Martin Gräßlin wrote: > > src/platforms/xcb/netwm_p.h, line 39 > > <https://git.reviewboard.kde.org/r/125309/diff/1/?file=404731#file404731line39> > > > > I don't like the type name "Atom" as that's also an XLib type

Re: Review Request 125309: Support multiple X servers in the NETWM classes

" as that's also an XLib type. As the actual name is hardly used we could get it to something more precise, maybe NetAtom? - Martin Gräßlin On Sept. 19, 2015, 3:22 p.m., Thomas Lübking wrote: > > --- > This is an auto

Re: Review Request 125259: Support multiple X servers in the NETWM classes

ew85619 ------- On Sept. 18, 2015, 10:19 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r

Re: Review Request 125259: Support multiple X servers in the NETWM classes

--- see adjusted unit tests. Also tried it in kwin_wayland Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125259: Support multiple X servers in the NETWM classes

cbcc1769de3dadcf8f6222f6a > autotests/netwininfotestclient.cpp a5b10376b943ea914a9521b5c07f9ef13a65d2f1 > autotests/netwininfotestwm.cpp a98e12fd690b0250337c7588e1525af1d0dda38c > src/platforms/xcb/netwm.cpp d99a925ad2b99d5e60ab1dafcb01400b4a6a4c93 > src/platforms/xcb/net

Re: Review Request 125259: Support multiple X servers in the NETWM classes

67/easy-way-to-use-variables-of-enum-types-as-string-in-c > > Martin Gräßlin wrote: > rather orthogonal to the change. I'm not sure whether a huge switch > statemement will make it better. What might be more interesting is to get > something like KWin's Xcb::Atom in to als

Re: Review Request 125259: Support multiple X servers in the NETWM classes

67/easy-way-to-use-variables-of-enum-types-as-string-in-c > > Martin Gräßlin wrote: > rather orthogonal to the change. I'm not sure whether a huge switch > statemement will make it better. What might be more interesting is to get > something like KWin's Xcb::Atom in to als

Re: Review Request 125259: Support multiple X servers in the NETWM classes

67/easy-way-to-use-variables-of-enum-types-as-string-in-c > > Martin Gräßlin wrote: > rather orthogonal to the change. I'm not sure whether a huge switch > statemement will make it better. What might be more interesting is to get > something like KWin's Xcb::Atom in to als

Re: Review Request 125252: Clean X11/XCB detection

fixed. - Martin Gräßlin On Sept. 16, 2015, 1:23 a.m., Samuel Gaist wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125237: Change KKeyserver (x11) to categorized logging

s://git.reviewboard.kde.org/r/125237/#review85451 ------- On Sept. 15, 2015, 11:40 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. T

Review Request 125259: Support multiple X servers in the NETWM classes

/diff/ Testing --- see adjusted unit tests. Also tried it in kwin_wayland Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125237: Change KKeyserver (x11) to categorized logging

://git.reviewboard.kde.org/r/125237/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 29 - Unstable!

Hi, I investigated the issue this morning and I think I pushed a working fix for it. Unfortunately I'm not 100 % as: * tests are timing depending * individual test case are not atomic If we hit the problem again, I'll disable the test and replace it by one which has atomic test cases.

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

> On Sept. 7, 2015, 9:17 a.m., Martin Gräßlin wrote: > > hey OSX-devs: we need to find a better solution for this things. I didn't > > notice the review before it was pushed, but I would not have given a shipit > > for it. > > > > The solution is sementically

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

"workaround"/"fixup" to some OSX build-oddities. Please have a look at the bigger picture and think about a general solution on how to disable X11 without having to (stupidly) patch all frameworks. - Martin Gräßlin On Sept. 7, 2015, 1:31 a.m.

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

> On Sept. 7, 2015, 9:17 a.m., Martin Gräßlin wrote: > > hey OSX-devs: we need to find a better solution for this things. I didn't > > notice the review before it was pushed, but I would not have given a shipit > > for it. > > > > The solution is sementically

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902/ --- (Updated Aug. 24, 2015, 1:35 p.m.) Review

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

starting an application using global shortcuts, it still gets started Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

no longer gets started, when starting an application using global shortcuts, it still gets started Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124872: Default to Breeze colors

this is implemented. Would it be possible to move the defaults into our QPT plugin, so that these defaults are only applied if running on a platform with our plugin, otherwise it picks Qt defaults? - Martin Gräßlin On Aug. 21, 2015, 11:35 p.m., Kai Uwe Broulik wrote

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

Am 2015-08-24 01:03, schrieb Kevin Funk: Right now whenever I start kdevelop I get the following daemons up and running on Windows: - dbus-daemon - kded5 - kglobalaccel5 - kioslave - klauncher KGlobalAccel should only be started if there is something trying to interact with KGlobalAccel

Review Request 124902: Delay starting kglobalaccel5 till it's needed

3508c870c70a21e76263b7574c20b408cc09a837 Diff: https://git.reviewboard.kde.org/r/124902/diff/ Testing --- export $(dbus-launch) qdbusviewer kate - kglobalaccel5 gets started with the change: kglobalaccel5 no longer gets started, when starting an application using global shortcuts, it still gets started Thanks, Martin

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

marked as submitted. Review request for KDE Frameworks and Kevin Funk. Changes --- Submitted with commit 40d047f013dc6f0e2f78066184a51a8c6e22eccd by Martin Gräßlin to branch master. Repository: kglobalaccel Description --- There are usages of KGlobalAccel in e.g. KActionCollection

Re: Review Request 124386: Fix build with Qt 5.4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124386/#review82632 --- Ship it! Ship It! - Martin Gräßlin On July 18, 2015, 11

Re: Review Request 124384: Fix build with Qt 5.4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124384/#review82633 --- Ship it! Ship It! - Martin Gräßlin On July 18, 2015, 11

Re: Re: [kglobalaccel/kglobalaccel-master] /: Add missing licenses

On Friday 10 July 2015 15:46:08 Maximiliano Curia wrote: Hi Martin, On 10/07/15 14:44, Martin Gräßlin wrote: On Friday 10 July 2015 12:26:23 Maximiliano Curia wrote: Add missing licenses as the kglobalaccel maintainer I'm very surprised by your change. The framework MUST be LGPL

Re: Review Request 124319: Add missing licenses

fixing, just changing the license is no solution! Please refer to the discussion I just sent to the mailing list. It would be nice if such important changes don't get pushed after a 3 min review, but at least waited for the maintainer to have a chance to look at it. - Martin Gräßlin On July 10

Re: [kglobalaccel/kglobalaccel-master] /: Add missing licenses

On Friday 10 July 2015 12:26:23 Maximiliano Curia wrote: Git commit cd503fed45a937c5d7eae22502304c16ba5e8fea by Maximiliano Curia. Committed on 10/07/2015 at 12:13. Pushed by maximilianocuria into branch 'kglobalaccel-master'. Add missing licenses The distributed tarballs include GPL-2 po

Re: Review Request 124319: Add missing licenses

On July 10, 2015, 2:49 p.m., Martin Gräßlin wrote: absolute no ShipIt. Maintainer veto! This needs proper fixing, just changing the license is no solution! Please refer to the discussion I just sent to the mailing list. It would be nice if such important changes don't get pushed

Re: Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

is clearly a nice thing. - Martin Gräßlin On July 9, 2015, 1:48 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124304

Re: Review Request 124288: [kwindowsystem] Install private headers for platform plugins

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 299a963a8506b894ee9c6ff9d8848d46237b12a2 by Martin Gräßlin to branch master. Repository: kwindowsystem Description --- The headers are needed to create platform specific plugins which

Re: Review Request 124289: [kidletime] Install private headers for platform plugins

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit c9d9254e6fb079372aef4275c49eefa6d7fc6c1f by Martin Gräßlin to branch master. Repository: kidletime Description --- The headers are needed to create platform specific plugins which are not part

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/#review82237 --- On July 7, 2015, 1:31 p.m., Martin Gräßlin wrote: --- This is an automatically

Review Request 124288: [kwindowsystem] Install private headers for platform plugins

a51fd444b41c5be58cfae2fa9ecf66780482fb9c Diff: https://git.reviewboard.kde.org/r/124288/diff/ Testing --- see git://anongit.kde.org/scratch/greasslin/kwayland-integration.git Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks

Review Request 124289: [kidletime] Install private headers for platform plugins

d076345ded1c274ca5487a75e5dbe6eca2230bd9 Diff: https://git.reviewboard.kde.org/r/124289/diff/ Testing --- see git://anongit.kde.org/scratch/greasslin/kwayland-integration.git Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 124212: kwindowsystem: Change source file layout

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 21dd5094204c4b467a5c7f8114e1249b4d42f6bc by Martin Gräßlin to branch master. Repository: kwindowsystem Description --- In the src directory we introduce a platforms directory with a specific

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 569a72353ba8ca9eb9f1208b7cc4c5d28f9e by Martin Gräßlin to branch master. Repository: kwindowsystem Description --- A plugin interface is added which allows a platform specific plugin

Re: Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit ef79ebfccac039d2a497c3a4d6f8ee7a2f4304ee by Martin Gräßlin to branch master. Repository: kidletime Description --- Instead of having the platform specific implementations hard compiled

Re: Review Request 124266: Introduce an env variable to overwrite the platform name

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit fd607506642195b1cfd58d92b5d720d888b711b1 by Martin Gräßlin to branch master. Bugs: 349911 https://bugs.kde.org/show_bug.cgi?id=349911 Repository: kglobalaccel Description

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 9c47f37bd1faa39d130739e6a49003442bd3388b by Martin Gräßlin to branch master. Repository: kxmlgui Description --- This replaces the version information of the version and frameworks and moves

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/#review82175 --- I like it! - Martin Gräßlin On July 7, 2015, 2:52 p.m

<    1   2   3   4   5   6   7   8   9   10   >