kross: src/core/metafunction.h:89 char* to QByteArrayData*

Hi, As part of the packaging efforts in Debian we are testing the installed headers to check that they compile correctly and have all their dependencies installed. Testing kross we found this: // static metaobject staticMetaObject.d.superdata = QObject::staticMetaObject;

Review Request 123082: Add missing license

with this package. Diffs - COPYING-CMAKE-SCRIPTS PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123082/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 123082: Add missing license

need to distribute the COPYING-CMAKE-SCRIPTS file with this package. Also, I don't have commit access, so if approved please, commit. Diffs - COPYING-CMAKE-SCRIPTS PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123082/diff/ Testing --- Thanks, Maximiliano Curia

Re: Review Request 123082: Add missing license

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit bf7d94e68f86553f7a803b1d9b838bb4ec88054d by Christophe Giboudeaux on behalf of Maximiliano Curia to branch master. Repository: kauth Description --- The cmake files: cmake/FindPolkitQt.cmake

Re: Review Request 122764: Adding missing licenses

://git.reviewboard.kde.org/r/122764/#review76935 --- On Feb. 28, 2015, 7:38 p.m., Maximiliano Curia wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 122764: Adding missing licenses

: https://git.reviewboard.kde.org/r/122764/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122764: Adding missing licenses

/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122764: Adding missing licenses

-SCRIPTS PRE-CREATION COPYING.LGPL-2 PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122764/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 122764: Adding missing licenses

generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122764/#review76820 --- On Feb. 28, 2015, 7:38 p.m., Maximiliano Curia wrote: --- This is an automatically

Re: KCompletion test failing

On 26/03/15 22:45, David Gil Oliva wrote: The following test fails. From the message about QCollator, I suspect it is due to QCollator, not to KCompletion. Someone can give me a hint whether I am right? I'm not sure it helps, but it may be worth noting that: The actual values are showing the

Review Request 123528: Add missing license file: COPYING.LGPL-2

-CREATION autotests/kfindtest.h c8abb06b8f0047a72fc513af81d507f22597aefb Diff: https://git.reviewboard.kde.org/r/123528/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 123528: Add missing license file: COPYING.LGPL-2

://git.reviewboard.kde.org/r/123528/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125656: Drop empty files

src/core/upload_p.h 4fa38689f64a0dec94666962a7541dd3d6086482 Diff: https://git.reviewboard.kde.org/r/125656/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.o

Review Request 125656: Add missing license

, if that's possible, please discard this change. Diffs - COPYING.LGPL-2 PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125656/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 125656: Drop empty files

upload.cpp 486129b55bb108f965050ecc25df7e6d98bebb9e src/core/upload_p.h 4fa38689f64a0dec94666962a7541dd3d6086482 Diff: https://git.reviewboard.kde.org/r/125656/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde

Re: Review Request 124319: Add missing licenses

-CREATION COPYING.LGPL-2 PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124319/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 124319: Add missing licenses

/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124319: Add missing licenses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124319/#review82328 --- On July 10, 2015, 12:48 p.m., Maximiliano Curia wrote

Re: [kglobalaccel/kglobalaccel-master] /: Add missing licenses

Hi Martin, On 10/07/15 14:44, Martin Gräßlin wrote: On Friday 10 July 2015 12:26:23 Maximiliano Curia wrote: Add missing licenses as the kglobalaccel maintainer I'm very surprised by your change. The framework MUST be LGPL, because it's a framework. How come that you decided

Re: Review Request 127963: Adding missing license

src/plasma/private/package_p.h src/plasma/private/packagestructure_p.h src/plasma/private/servicejob_p.h Diffs - COPYING.LGPL-2 PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127963/diff/ Testing --- Thanks, Maximiliano Curia

Review Request 127959: Adding missing license

: https://git.reviewboard.kde.org/r/127959/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127961: Adding missing license

/netaccesstest.cpp Diffs - COPYING.LGPL-2 PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127961/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 127963: Adding missing license

/servicejob_p.h Diffs - COPYING.LGPL-2 PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127963/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 127959: Adding missing license

shipping the full text with the source code. Diffs - COPYING.LGPL-2 PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127959/diff/ Testing --- Thanks, Maximiliano Curia ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 130069: Reproducible builds: drop version from XMLGUI_COMPILING_OS

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 0570614d56712139fb7af90b92c31a32177b72f5 by Maximiliano Curia to branch master. Repository: kxmlgui Description --- This is a fix for the Debian bug: https://bugs.debian.org/835053

Review Request 130069: Reproducible builds: drop version from XMLGUI_COMPILING_OS

- src/config-xmlgui.h.cmake 9d7f3dcf3ba49f94c211afb6d054d8de6044b370 Diff: https://git.reviewboard.kde.org/r/130069/diff/ Testing --- Thanks, Maximiliano Curia

D12867: Fix minor documentation typos

maximilianocuria closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12867 To: maximilianocuria, #frameworks, alexmerry, kossebau, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D12867: Fix minor documentation typos

maximilianocuria created this revision. maximilianocuria added reviewers: Frameworks, alexmerry, kossebau. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. maximilianocuria requested review of this

D12867: Fix minor documentation typos

maximilianocuria added a comment. Please let me know if it's okay to land this kind of changes directly. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12867 To: maximilianocuria, #frameworks, alexmerry, kossebau Cc: kde-frameworks-devel,

D12867: Fix minor documentation typos

maximilianocuria edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12867 To: maximilianocuria, #frameworks, alexmerry, kossebau Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D12867: Fix minor documentation typos

maximilianocuria added a comment. Thanks. Sadly the commit went without the GIT_SILENT, sorry about that. I did: arc amend git commit -amend # to add the GIT_SILENT arc land I guess that the arc land called another arc amend. REPOSITORY R240 Extra CMake Modules REVISION

D12872: ScalableTest, add "scalable" plasma-browser-integration

maximilianocuria edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12872 To: maximilianocuria Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12872: ScalableTest, add "scalable" plasma-browser-integration

maximilianocuria created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. maximilianocuria requested review of this revision. REVISION SUMMARY With the introduction of the plasma-browser-integration icon (Add

D12872: ScalableTest, add "scalable" plasma-browser-integration

maximilianocuria added reviewers: Frameworks, dfaure, andreaska, andreask. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12872 To: maximilianocuria, #frameworks, dfaure, andreaska, andreask Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12877: GIT_SILENT fix minor typo in the license name

maximilianocuria created this revision. maximilianocuria added reviewers: Frameworks, bshah. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. maximilianocuria requested review of this revision. REPOSITORY R237 KConfig BRANCH

D12892: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file

This revision was automatically updated to reflect the committed changes. Closed by commit R237:c1fa17e99ad9: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file (authored by maximilianocuria). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D12892: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file

maximilianocuria created this revision. maximilianocuria added reviewers: Frameworks, mlaurent. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. maximilianocuria requested review of this revision. REVISION SUMMARY Since "Use

D12898: Add missing header

maximilianocuria created this revision. maximilianocuria added reviewers: Frameworks, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. maximilianocuria requested review of this revision. REVISION SUMMARY xdgforeign

D11235: [DrKonqi] Request change of ptrace scope from KCrash

maximilianocuria added inline comments. INLINE COMMENTS > queryptrace.cpp:26 > +server.sun_family = AF_UNIX; > +sprintf(server.sun_path, "/tmp/kcrash_%lld", > QCoreApplication::applicationPid()); > +if (::connect(sfd, (struct sockaddr *), sl) == 0) { Please honour TMPDIR or, even

D13018: Fix unit test for kfileplacesmodeltest

maximilianocuria added a comment. In D13018#266137 , @elvisangelaccio wrote: > Hmm, still seems to fail here: > > $ ctest -R kfileplacesmodeltest > Test project /home/elvis/dev/kde/kio/local-build > Start 50:

D12215: Add a "Reload" menu item to KDirOperator's context menu

maximilianocuria added a comment. > FIXED-IN: 5.56 You are planning a bit ahead, aren't you. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12215 To: ngraham, #frameworks Cc: maximilianocuria, dhaumann, rkflx, michaelh, bruns

D12513: CVE-2018-10361: privelege escalation

maximilianocuria created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. maximilianocuria requested review of this revision. REVISION SUMMARY See http://www.openwall.com/lists/oss-security/2018/04/24/1 REPOSITORY

D12513: CVE-2018-10361: privelege escalation

maximilianocuria added a comment. Why dropping syncToDisk? Why is that related to the current issue? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, maximilianocuria, dfaure Cc: cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns,

D12513: CVE-2018-10361: privelege escalation

maximilianocuria edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: maximilianocuria Cc: #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D12513: CVE-2018-10361: privilege escalation

maximilianocuria retitled this revision from "CVE-2018-10361: privelege escalation" to "CVE-2018-10361: privilege escalation". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, maximilianocuria, dfaure Cc: fvogt, cullmann, #frameworks, michaelh,

D12513: CVE-2018-10361: privilege escalation

maximilianocuria added a comment. In D12513#253537 , @fvogt wrote: > There's a typo in the title, it should be "privilege escalation". Done REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann,

D12513: CVE-2018-10361: privilege escalation

maximilianocuria resigned from this revision. This revision now requires review to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, dfaure Cc: fvogt, cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann

D12513: CVE-2018-10361: privilege escalation

maximilianocuria added a comment. Mmh, the accept revision doesn't work as a +1, does it? I was intending to say +1/thumbs up, but I would still prefer somebody else to review this. After all, I sent forwarded the original patch, clearly I want this to land, but it's up the

D12513: CVE-2018-10361: privilege escalation

maximilianocuria accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, maximilianocuria, dfaure Cc: fvogt, cullmann, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking,