D15814: show all borders for pop up windows in a dock

mvourlakos added a comment. In D15814#343330 , @davidedmundson wrote: > > first introduced at popupPlacement() > > ...by you :P I know :( and this broke plasma popups placement in !compositing mode. This is why I sent

D15839: extend PlasmaCore.ColorScope for custom colors

mvourlakos edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15839 To: mvourlakos, #plasma, davidedmundson, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

mvourlakos edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15839 To: mvourlakos, #plasma, davidedmundson, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

mvourlakos added a comment. F6294480: εικόνα.png [plasma taskmanager that is using red as textColor even though Breeze-Dark theme is chosen] REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15839 To:

D15839: extend PlasmaCore.ColorScope for custom colors

mvourlakos created this revision. mvourlakos added reviewers: Plasma, davidedmundson, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mvourlakos requested review of this revision. REVISION SUMMARY --In the future dynamic coloring might be needed for

D15821: fix pop up positioning for !compositing mode

mvourlakos added inline comments. INLINE COMMENTS > dialog.cpp:910 > const bool outsideParentWindow = ((winInfo.windowType(NET::AllTypesMask) > == NET::Dock) || (item->window()->flags() & Qt::X11BypassWindowManagerHint)) > -&& item->window()->mask().isNull(); > +

D15821: fix pop up positioning for !compositing mode

mvourlakos updated this revision to Diff 42536. mvourlakos added a comment. - dont use mask() to identify popups placement REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15821?vs=42510=42536 BRANCH maskPositioning REVISION DETAIL

D15814: show all borders for pop up windows in a dock

mvourlakos added inline comments. INLINE COMMENTS > davidedmundson wrote in dialog.cpp:209 > How does parentWindow->mask relate to being a dock or not? > > Also we need to be a bit careful on names. > _NET_WM_WINDOW_TYPE_DOCK is all panels, including the standard plasma one. The idea was first

D15814: show all borders for pop up windows in a dock

mvourlakos added a comment. @ngraham @abetts I searched a bit the "downward-pointing triangle" case but I dont think it can be drawn based on the current plasma theme implementation. Plasma themes are svg(s) so the borders images can also have borders so it isnt just drawing a triangle

D15821: fix pop up positioning for !compositing mode

mvourlakos added a reviewer: davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15821 To: mvourlakos, #plasma, broulik, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

mvourlakos added reviewers: broulik, davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15814 To: mvourlakos, #plasma, broulik, davidedmundson Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15821: fix pop up positioning for !compositing mode

mvourlakos added a comment. F6292209: εικόνα.png [BEFORE: popup placement in plasma panel in !compositing] F6292214: εικόνα.png [AFTER: popup placement in plasma panel in !compositing] REPOSITORY R242

D15821: fix pop up positioning for !compositing mode

mvourlakos created this revision. mvourlakos added reviewers: Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mvourlakos requested review of this revision. REVISION SUMMARY --pop up positioning that was introduced in order to a dock pop up

D15814: show all borders for pop up windows in a dock

mvourlakos added a comment. In D15814#10 , @ngraham wrote: > A big improvement! Even better would be a little downward-pointing triangle pointing to the thing that spawned it. Here's a visual example from macOS with a vertical Dock:

D15814: show all borders for pop up windows in a dock

mvourlakos added a comment. In D15814#13 , @broulik wrote: > The idea is fine in principle but Plasma may also set a mask on its panels, noticeably in non-composited case for rounded corners, so when I disable compositing I get borders on

D15814: show all borders for pop up windows in a dock

mvourlakos updated this revision to Diff 42489. mvourlakos added a comment. - do not consider dock for !compositing REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15814?vs=42480=42489 BRANCH dockBorders REVISION DETAIL

D15814: show all borders for pop up windows in a dock

mvourlakos added a comment. F6291922: εικόνα.png (before) F6291928: εικόνα.png (after) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15814 To: mvourlakos,

D15814: show all borders for pop up windows in a dock

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mvourlakos requested review of this revision. REVISION SUMMARY --it creates a much better and consistent visual effect when applets pop

D11484: Fix combobox breakage

mvourlakos added a comment. thank you, it works just fine now... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11484 To: ngraham, broulik, #plasma, mvourlakos, davidedmundson Cc: #frameworks, michaelh, ngraham

D10592: fix RTL appearance for ComboBox

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1ff405cca5b3: fix RTL appearance for ComboBox (authored by mvourlakos). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10592?vs=27382=27568

D10592: fix RTL appearance for ComboBox

mvourlakos added a comment. > Sure. Go ahead and commit. is it possible to give first the green light by accepting the review? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart, safaalfulaij Cc: safaalfulaij,

D10592: fix RTL appearance for ComboBox

mvourlakos added a reviewer: safaalfulaij. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart, safaalfulaij Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10592: fix RTL appearance for ComboBox

mvourlakos added a comment. @safaalfulaij is there a green light for this? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai,

D10592: fix RTL appearance for ComboBox

mvourlakos marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10592: fix RTL appearance for ComboBox

mvourlakos updated this revision to Diff 27382. mvourlakos added a comment. - improve semantics REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10592?vs=27373=27382 BRANCH rtl REVISION DETAIL https://phabricator.kde.org/D10592

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. @safaalfulaij I created the following for this: https://phabricator.kde.org/D10592 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart, plasma-devel, #frameworks,

D10592: fix RTL appearance for ComboBox

mvourlakos created this revision. mvourlakos added reviewers: Plasma, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY - when the combobox isnt

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. Latte config window is a Plasma::ConfigView, so it inherates a QQuickView REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart, plasma-devel, #frameworks, michaelh,

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. Can you build Latte from master version? All comboboxes in its settings window are PlasmaComponents3 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart,

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. > Would you please add a HACK so that we know when to remove this? You mean as a comment ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart, plasma-devel,

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. @mart I fixed this issue by changing these lines to: 113LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft 114LayoutMirroring.childrenInherit: true REPOSITORY R242 Plasma Framework (Library) REVISION

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. @safaalfulaij @mart we need to revert this... with frameworks 5.43 it reverses list items always!!! The issue is still present when the PlasmaComponents3.ComboBox is used in the Latte settings window, that is the items are not aligned correctly in

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. In https://phabricator.kde.org/D9275#190594, @safaalfulaij wrote: > In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote: > > > with your example me I cant reproduce it either... > > I can only reproduce it with Latte Settings window, all other

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. In https://phabricator.kde.org/D9275#190547, @safaalfulaij wrote: > In https://phabricator.kde.org/D9275#190497, @mvourlakos wrote: > > > how did you test it? > > > > I tried in an qml app (Latte dock) by passing the parameter "--reverse"... > > If

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. In https://phabricator.kde.org/D9275#190473, @safaalfulaij wrote: > In https://phabricator.kde.org/D9275#190464, @mvourlakos wrote: > > > In https://phabricator.kde.org/D9275#190441, @safaalfulaij wrote: > > > > > Can you please explain why these are

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. In https://phabricator.kde.org/D9275#190441, @safaalfulaij wrote: > Can you please explain why these are needed? I tested plasmacomponents3 and the combobox was working correctly. It wasnt, use english text in the

D9275: fix RTL appearance for ComboBox

This revision was automatically updated to reflect the committed changes. Closed by commit R242:547dade2f803: fix RTL appearance for ComboBox (authored by mvourlakos). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9275?vs=23708=25254

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a comment. external bug report: https://github.com/PapirusDevelopmentTeam/adapta-kde/issues/26 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma, mart Cc: mart, plasma-devel, #frameworks, ZrenBot,

D9275: fix RTL appearance for ComboBox

mvourlakos added a subscriber: mart. mvourlakos added a comment. @mart what about this? are you able to reproduce it in your system? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma Cc: mart, plasma-devel, #frameworks,

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos abandoned this revision. mvourlakos added a comment. this is Adapta theme issue... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma, mart Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a comment. In https://phabricator.kde.org/D9276#179574, @mart wrote: > here on master the item under mouse does get highlighted you are totally right!! so sorry... this is Adapta theme issue, changing to Breeze themes solves this... REPOSITORY R242 Plasma

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added inline comments. INLINE COMMENTS > mart wrote in ComboBox.qml:49 > uuh, no, ItemDelegate should highlight by itself when hovered without having > to do that, this would say that there is a problem in ItemDelegate? yes... it didnt highlight at all, neither the selected item nor

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a comment. just noticed that the reviewer is the person that decides to give the green light so it cant be set by the author without prior communication... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos,

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. just noticed that the reviewer is the person that decides to give the green light so it cant be set by the author without prior communication... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos,

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos removed a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

mvourlakos removed a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

mvourlakos added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

mvourlakos edited the summary of this revision. mvourlakos edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY --PlasmaComponents.ComboBox now highlights correctly the selected item and on

D9275: fix RTL appearance for ComboBox

mvourlakos updated this revision to Diff 23708. mvourlakos added a comment. - fix typos REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9275?vs=23707=23708 BRANCH listrtl REVISION DETAIL https://phabricator.kde.org/D9275 AFFECTED

D9275: fix RTL appearance for ComboBox

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY --PlasmaComponents3.ComboBox now appears correctly its list items in RTL

D9126: [RTL] - align properly the selected text for RTL

This revision was automatically updated to reflect the committed changes. Closed by commit R242:71f8f16fea15: [RTL] - align properly the selected text for RTL (authored by mvourlakos). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D9126: [RTL] - align properly the selected text for RTL

mvourlakos added a comment. In https://phabricator.kde.org/D9126#175594, @broulik wrote: > (I'd be fine with this one liner going in but I'm wondering why it would be needed in the first place) are we ok for landing this? REPOSITORY R242 Plasma Framework (Library) BRANCH

D9126: [RTL] - align properly the selected text for RTL

mvourlakos added a comment. without that line there is the following problem: if in the combobox list there are also LTR items then when these items are selected they are aligned to the left and when the RTL items are selected they are aligned to the right. By adding that line the

D9126: [RTL] - align properly the selected text for RTL

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY --align selected text correctly for PlasmaComponents2.ComboBox taking into

D5515: Update the ungrabMouse hack for Qt 5.8

mvourlakos added a comment. I had reported qts faulty behavior concerning centextmenus at: https://bugreports.qt.io/browse/QTBUG-59044 I think it is the mentioned case... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5515 To:

[Differential] [Commented On] D4711: Ungrab mouse on menu close

mvourlakos added a comment. In https://phabricator.kde.org/D4711#89334, @mart wrote: > this on released Qt 5.8? on 5.8 branch? > i can't reproduce with my 5.8 build here. > anyways, that beahvior change would be a Qt bug (one of the many the terrible 5.8 release had) and should be

[Differential] [Commented On] D4711: Ungrab mouse on menu close

mvourlakos added a comment. I just noticed... you dont have to go too far... any qt application using 5.8 has this problem... even qtcreator... showing a menu and then deactivating it from outside areas then the window needs a click from the user in order for this window to react

[Differential] [Commented On] D4711: Ungrab mouse on menu close

mvourlakos added a comment. You can observe the faulty behavior even with Qt's "Menu's Example". 1. Open any menu you want either with right click or from the menu 2. Close it by clicking in any outside area you want, that is (not inside the menu example window and not in the menu)

[Differential] [Commented On] D4711: Ungrab mouse on menu close

mvourlakos added a comment. In https://phabricator.kde.org/D4711#88621, @mart wrote: > do you know exactly what/where changed? sorry if this is irrelevant... I dont know if the above code works but in my code tree in latte dock I can not do anything to ungrabMouse in Qt 5.8 in