D28606: Add iconSize property to PC2 ToolButton

ngraham added a reviewer: mart. ngraham added a comment. Adding Marco as a reviewer since I know he just lves ToolButton sizing. :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma, mart Cc: broulik, ngraha

D28606: Add iconSize property to PC2 ToolButton

ngraham added a comment. Darn. Maybe we should fix the PC3 tooltips though? :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28532: Introduce more user-visible error reporting for installations

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH more-installation-error-handling (branched from master) REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: kde-framew

D27848: Remove the panel tooltip icon

ngraham added a comment. See the parent task. This component doesn't only darw system tray tooltips but rather tooltips for all panel widgets. The idea was that we don't want icons in *any* of these tooltips, because they're either redundant or inconsistent with the icon that you're hov

D27848: Remove the panel tooltip icon

ngraham added a comment. Fixed in 7aaee715aff2a3fadf950f686a8be5e0d49c3297 and did it the correct way in 1f0cf38dbf2eb7de2b7fe09ef82bbb281a296a68

D27263: RFC: Accent colour for KColorScheme

ngraham added a comment. Whoops, my bad. Tested this and found that setting an accept color seems to work for apps, but unsetting it doesn't go back to the color-scheme-provided one. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plas

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

ngraham added a comment. I haven't been working on it. There's an outstanding request to do this in a combination of CMake and Python, so it's cross-platform for Windows users of Breeze Icons too (see D27557#622879 ). Honestly I need to re-do the e

D28324: [Inotify] Remove dead/duplicate code

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I think this is fine. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28324 To: bruns, #baloo, ngraham Cc: pino, kde-frameworks-devel, hurikhan77,

D28328: [Inotify] Remove not-so-OptimizedByteArray

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28328 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28400 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domso

D28500: [PhraseAndIteratorTest] Cleanup, use better variable names

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28500 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domso

D28401: [SearchStore] Handle double values in property queries

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28401 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domso

D28397: Replace Vokoscreen with VokoscreenNG

This revision was automatically updated to reflect the committed changes. Closed by commit R304:5613fd66c5f4: Replace Vokoscreen with VokoscreenNG (authored by harogaston, committed by ngraham). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28397?vs=79185&i

D28397: Replace Vokoscreen with VokoscreenNG

ngraham added a comment. Great patches, @harogaston! Keep 'em coming! :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28397 To: harogaston, #knewstuff, ngraham, leinir Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D28397: Replace Vokoscreen with VokoscreenNG

ngraham added a comment. You're welcome! REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28397 To: harogaston, #knewstuff, ngraham, leinir Cc: apol, pino, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28499: [LauncherJobs] Emit description

ngraham added a comment. Seems sensible and sane to me. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28499 To: broulik, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

ngraham added a comment. Even with this patch, every attempt to uninstall a newly-installed global theme still fails with: The uninstallation process failed to successfully run the command kpackagetool5 -t Plasma/LookAndFeel -r /tmp/01-com.github.vinceliuice.McMojave.tar.xz And e

T8349: Improve Places panel usability and presentation

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, fprice, cblack, konkinarte

T8349: Improve Places panel usability and presentation

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, fprice, cblack, konkinarte

T8349: Improve Places panel usability and presentation

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, fprice, cblack, konkinarte

D28701: [WIP] Add KPackage support to KNewStuffCore

ngraham added a comment. Okay thanks, can you update the test plan then? Also I think the diff currently does not actually fix 418466. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, mich

D28701: [WIP] Add KPackage support to KNewStuffCore

ngraham added reviewers: Plasma, KNewStuff, Frameworks. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28712: Redo api.kde.org to look more like Aether

ngraham added a comment. Dang that looks way nicer. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28712 To: cblack, #vdg, ognarb, ochurlaud Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, bruns, skadinna

D28372: Remove rounded borders to plasmoidHeading

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH merged-plasmoidheading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28372 To: niccolove, #plasma, ngraham Cc: manueljlin, ahiemstra, nd

D7563: Add privilegeExecution field to file protocol description

ngraham added a comment. The outstanding security issues have been resolved (see T8075 ). We have requested a re-review from the SUSE security team, but have not received it yet. Given that the original schedule for this feature has already slipped by almos

D26113: Places: For mounted volume display mount points instead of description

ngraham added a comment. In D26113#642053 , @meven wrote: > I should go ahead with it in solid and loop back here once it is done. Yeah, that makes sense to me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26113

D19736: Add rotation icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH rotate (branched from master) REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol, ngraham Cc: ngraham, kde-framewor

D28755: Breeze Icons cannot be built from read-only source location

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice improvement. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28755 To: marten, #breeze, ngraham Cc: ngraham, pino, kde-frameworks-devel, LeGast00n, cbl

D28769: Add Icelandic Krona

ngraham added a comment. Hmm, this patch doesn't apply for me. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D28769 To: sandsmark, #frameworks Cc: ngraham, kde-frameworks-devel, #frameworks, LeGast00n, cblack, michaelh, bruns

D28770: Avoid blocking the UI thread

ngraham added inline comments. INLINE COMMENTS > currency.cpp:40 > #include > +#include > +#include Unused? > currency.cpp:884 > + > +#include "currency.moc" why? REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D28770 To: sandsmark, ngraham, #frameworks,

D28745: Skipping catching of thumbnails on encrypted filesystems

ngraham retitled this revision from "Skipping catching of thumbnails on encrytped filesystems" to "Skipping catching of thumbnails on encrypted filesystems". ngraham edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marci

D28745: Skipping catching of thumbnails on encrytped filesystems

ngraham added reviewers: ivan, broulik, Dolphin. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Cod

D28746: Show previews on encrypted filesystems

ngraham added reviewers: ivan, Frameworks, dfaure. ngraham added a comment. General idea looks sane to me. Thanks for working on this; it's been one of those minor annoyances of mine. INLINE COMMENTS > previewjob.cpp:718 > } > - > if (save) { unrelated change REPOSITORY R241 KI

D28746: Show previews on encrypted filesystems

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works and looks good to me modulo one comment, but let's wait for the other reviewers too. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu, ivan,

D28787: Fix PC3 BusyIndicator binding loop

ngraham created this revision. ngraham added reviewers: Plasma, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Without this, the Busy Indicator generates binding loops for me when us

D28746: Show previews on encrypted filesystems

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in previewjob.cpp:718 > unrelated change Now there are extra spaces on that line. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu, ivan, #frameworks, dfaure, ngraham Cc: ngraham, kde-fram

D28787: Fix PC3 BusyIndicator binding loop

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3743e9d67453: Fix PC3 BusyIndicator binding loop (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28787?vs=79980&id=80012 R

D28769: Add Icelandic Krona

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D28769 To: sandsmark, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, #frameworks, LeGast00n, cblack, michaelh, bruns

D28745: Skipping catching of thumbnails on encrypted filesystems

ngraham accepted this revision. ngraham added inline comments. INLINE COMMENTS > thumbnail.cpp:724 > // no cached version is available, a new thumbnail must be > created > - > QSaveFile thumbnailfile(thumbPath.absoluteFilePath(thumbName)); There are extra spaces on thi

D28745: Skip caching thumbnails on encrypted filesystems

ngraham retitled this revision from "Skipping catching of thumbnails on encrypted filesystems" to "Skip caching thumbnails on encrypted filesystems". ngraham edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan

D28746: Show previews on encrypted filesystems

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu, ivan, #frameworks, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28746: Show previews on encrypted filesystems

ngraham added a comment. Excellent job. This is a real improvement. Keep the great patches coming! :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu, ivan, #frameworks, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, br

D28746: Show previews on encrypted filesystems

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ae0beded1fd9: Show previews on encrypted filesystems (authored by marcingu, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28746?vs=80022&id=8002

D28802: Add standard shortcut for "Show/Hide Hidden Files"

ngraham created this revision. ngraham added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Add a standard shortcut for this action so it can be synchronized between

D28802: Add standard shortcut for "Show/Hide Hidden Files"

ngraham added a dependent revision: D28804: Use new "Show/Hide Hidden Files" standard shortcut. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28802: Add standard shortcut for "Show/Hide Hidden Files"

ngraham added a dependent revision: D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

ngraham created this revision. ngraham added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY CCBUG: 262551 Depends on D28802

D28802: Add standard shortcut for "Show/Hide Hidden Files"

ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28802: Add standard shortcut for "Show/Hide Hidden Files"

This revision was automatically updated to reflect the committed changes. Closed by commit R237:65cc12ab3ec8: Add standard shortcut for "Show/Hide Hidden Files" (authored by ngraham). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28802?vs=80039&id=80049 REVI

D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

ngraham added a comment. Will do! REPOSITORY R241 KIO BRANCH use-standard-shortcut (branched from master) REVISION DETAIL https://phabricator.kde.org/D28803 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d3977bdeacbb: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28803?vs=80040&id=

D28808: [ExpandableListItem] make it touch-friendly

ngraham created this revision. ngraham added reviewers: Plasma, apol, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Use a MultiPointTouchHandler as the top-level item to handle touch input. We

D27220: add pix icon

ngraham added a comment. @camiloh, how do you feel about this? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27220 To: mbruchert, camiloh, #vdg Cc: ngraham, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D26650: Use KService to look for Filelight

ngraham added a comment. Ping @shubham REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: shubham, broulik, ngraham Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28831: Add note about porting loadMimeTypeIcon

ngraham added a comment. +1 REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D28831 To: nicolasfella, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D26650: Use KService to look for Filelight

ngraham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: ngraham, broulik, shubham Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

ngraham commandeered this revision. ngraham edited reviewers, added: shubham; removed: ngraham. ngraham added a comment. Aha! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26650 To: ngraham, broulik, shubham Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGa

D7563: Add privilegeExecution field to file protocol description

ngraham added a comment. @chinmoyr phab reports that this has a missing dependency/patch base. Is there some unmerged patch that's left to do, or does it just need a rebase on master? BRANCH master REVISION DETAIL https://phabricator.kde.org/D7563 To: chinmoyr, #frameworks, dfaure Cc:

D28839: [PostingIterator] Make sure skipTo also works for first element

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28839 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ash

D28701: Add KPackage support to KNewStuffCore

ngraham added a comment. This has fixed the issues I was seeing with installation and uninstallation, nice! However I'm not seeing a very long hang when installing certain global themes--for example Sweet KDE and Layan Look and Feel Theme. It does ultimately work, but the dialog freezes for

D28808: [ExpandableListItem] make it touch-friendly

ngraham planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28808 To: ngraham, #plasma, apol, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

ngraham updated this revision to Diff 80217. ngraham added a comment. Use TapHandler instead of MultiPointTouchArea REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28808?vs=80054&id=80217 BRANCH make-ExpandableListItem-touchable (branch

D28808: [ExpandableListItem] make it touch-friendly

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28808 To: ngraham, #plasma, apol, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

ngraham updated this revision to Diff 80218. ngraham added a comment. Simpler enabled handling REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28808?vs=80217&id=80218 BRANCH make-ExpandableListItem-touchable (branched from master) REVI

D28844: [PhraseAndIterator] Replace recursive next() implementation

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28844 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ash

D28843: [AndPostingIterator] Replace recursive next() implementation

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28843 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ash

D28845: [OrpostingIterator] Allow skipping elements, implement skipTo

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28845 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ash

D28862: [Extractor] Remove IdleStateMonitor wrapper class

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D28862 To: bruns, #baloo, ngraham Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, do

D28863: [Extractor] Fix idle monitoring

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28863 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ash

D28864: [Extractor] Better balance idle and busy mode

ngraham added a comment. Can you explain the conceptual reasoning behind this change? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28864 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnik

D28865: [PhraseAndIterator] Remove temporary arrays when checking matches

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28865 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ash

D28864: [Extractor] Better balance idle and busy mode

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, makes sense to me! REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28864 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77,

D28808: [ExpandableListItem] make it touch-friendly

ngraham added a comment. Good question. I'm not sure it's possible here; the list views that use this component as a delegate might have to learn how to unset the selection with their own `TapHandler`. I'm not 100% sure on that though. REPOSITORY R242 Plasma Framework (Library) REVISION D

D28891: Nicaragua Holidays

ngraham added reviewers: winterz, Frameworks. ngraham added a comment. Thanks for the patch! You need to update the `holidays/holidays.qrc` file too, to mention this new file that you're adding. Also I don't think you need to have the `.qrc` extension on the file you're adding. REPOSITORY

D28891: Nicaragua Holidays

ngraham removed a reviewer: VDG. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

ngraham added a comment. Now the new file you wanted to add is gone. :) With Phabricator, you need to include all commits in your patch, not just the latest one. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngr

D28891: Nicaragua Holidays

ngraham added a comment. git add [the path to the new file you want to add]` arc diff --update D28891 REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michael

D28891: Nicaragua Holidays

ngraham added a comment. Great job! I'll hand it over to @winterz and other reviewers now. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

ngraham added a comment. You're very welcome. Thank you for the patch! REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

ngraham added a comment. Thanks @chinmoyr! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7563 To: chinmoyr, #frameworks, dfaure Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

ngraham commandeered this revision. ngraham added a reviewer: chinmoyr. ngraham added a comment. Yoink! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865,

D7563: Add privilegeExecution field to file protocol description

ngraham updated this revision to Diff 80342. ngraham added a comment. - Fix build failure - Add more stuff (thanks @chinmoyr) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80341&id=80342 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator

D7563: Add privilegeExecution field to file protocol description

ngraham updated this revision to Diff 80343. ngraham added a comment. Set the patch base REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80342&id=80343 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES src/co

D7563: Add privilegeExecution field to file protocol description

ngraham added a comment. [insert I-have-no-idea-what-I'm-doing dog meme here] When trying to create items in root-owned locations, I'm getting an errors saying "The process for the file protocol died unexpectedly." or else Dolphin simply crashes with a totally unhelpful backtrace. REPOS

D28701: Add KPackage support to KNewStuffCore

ngraham added a comment. Thanks, the hang is gone now. However I have a new problem: 1. Open Global Themes KCM and click new new global themes 2. Install Sweet KDE and McMojave LAF global themes 3. Close the GHNS dialog 4. Open the dialog again 5. Uninstall the McMojave LAF theme

D28923: Update links in README.md

ngraham added inline comments. INLINE COMMENTS > README.md:22 > +- The VDG Telegram room: > +- The Breeze Icons Telegram room: > +- The visual-des...@kde.org mailing list: >

D28923: Update links in README.md

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH readme (branched from master) REVISION DETAIL https://phabricator.kde.org/D28923 To: ndavis, #vdg, ngraham Cc: alex-l, ngraham, kde-frameworks-devel, LeGast00n, cblack, mic

D28874: Taiwanese holidays

ngraham added a comment. Do you not have commit access? I thought you were the maintainer based on the repo's history! REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: ngraham, winterz, kde-frameworks-devel, LeGast00n, cb

D28925: [QueryTest] Extend phrase query tests

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28925 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ash

D28924: [SearchStore] Allow querying exact matches for non-properties

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28924 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ash

D28874: Taiwanese holidays

ngraham added a comment. Sure, I can do it. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: ngraham, winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28808: [ExpandableListItem] make it touch-friendly

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:52c0a136f9ff: [ExpandableListItem] make it touch-friendly (authored by ngraham). REPOSITORY R242 Plasma Framework (L

D28929: [QueryTest] Track if phrase matches in content or filename

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28929 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ash

D28940: [baloo_file] Remove KAboutData from baloo_file

ngraham accepted this revision. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28940 To: bruns, #baloo, ngraham, leszeklesner, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippi

D28933: [Coding] Avoid recurrent detach and size checks

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28933 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ash

D28980: Revert "add Baloo DBus signals for moved or removed files"

ngraham accepted this revision. REPOSITORY R293 Baloo BRANCH config_rework REVISION DETAIL https://phabricator.kde.org/D28980 To: bruns, #baloo, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich,

D28995: Add imperial gallon and US pint

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks very much for the patch, but that bug report is very old and these units of measurement were already added in 5.53 as `GallonUS` and `PintImperial`. I'm sorry the the bug

D7563: Add privilegeExecution field to file protocol description

ngraham updated this revision to Diff 80644. ngraham added a comment. Install auth helper too REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80343&id=80644 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES s

D7563: Add privilegeExecution field to file protocol description

ngraham updated this revision to Diff 80645. ngraham added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80644&id=80645 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES src/core/kfileitem

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a task: T11925: Breeze Desktop Theme Transparency. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

<    1   2   3   4   5   6   7   8   9   10   >