D29793: Rename Perl6 syntax to Raku

[Nibaldo González]

nibags abandoned this revision.
nibags added a comment.


  This is equivalent to: 
https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/1

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29793

To: nibags, #framework_syntax_highlighting, #kate, jpoelen, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29795: Add collaboration guide

[Nibaldo González]

nibags abandoned this revision.
nibags added a comment.


  This is moved to 
https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/2

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29795

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29793: Rename Perl6 syntax to Raku

[Nibaldo González]

nibags updated this revision to Diff 83088.
nibags added a comment.


  - Fix extensions and unit tests

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29793?vs=82987=83088

BRANCH
  rename-perl6-raku

REVISION DETAIL
  https://phabricator.kde.org/D29793

AFFECTED FILES
  autotests/folding/highlight.pl6.fold
  autotests/folding/highlight.raku.fold
  autotests/html/highlight.pl6.html
  autotests/html/highlight.raku.html
  autotests/input/highlight.pl6
  autotests/input/highlight.raku
  autotests/reference/highlight.pl6.ref
  autotests/reference/highlight.raku.ref
  data/syntax/perl6.xml
  data/syntax/raku.xml

To: nibags, #framework_syntax_highlighting, #kate, jpoelen, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29795: Add collaboration guide

[Nibaldo González]

nibags added a comment.


  I put it all in the README. I also corrected the repository, I had not 
noticed that this repository was already in GitLab!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29795

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29795: Add collaboration guide

[Nibaldo González]

nibags updated this revision to Diff 83086.
nibags added a comment.


  - Add collaboration guide in the README file

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29795?vs=82995=83086

BRANCH
  add-collaboration-guide

REVISION DETAIL
  https://phabricator.kde.org/D29795

AFFECTED FILES
  README.md

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29795: Add collaboration guide

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Add a file with instructions and basic information on how to collaborate in 
the repository.
  
  The idea is to provide information for first-time contributors or who are 
only going to improve or fix some XML file without anything else. This file 
collects the doubts and errors that I have seen that some new contributors have 
had.
  
  Any correction or improvement in the text is appreciated (especially, I would 
appreciate if you could check the wording).

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-collaboration-guide

REVISION DETAIL
  https://phabricator.kde.org/D29795

AFFECTED FILES
  COLLABORATE.md

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29793: Rename Perl6 syntax to Raku

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29793

To: nibags, #framework_syntax_highlighting, #kate, jpoelen, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29793: Rename Perl6 syntax to Raku

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, Kate, jpoelen, 
cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  In October 2019, Perl6 was renamed to "Raku".
  
  The syntax is renamed to **"Raku"**, however, I don't know if you prefer a 
name that also includes "Perl6", such as **"Raku (Perl6)"** or **"Raku/Perl6"**.
  
  I also add the new extensions and update the extension in the test file.
  
  Any inconvenience with this diff don't hesitate to notify.
  
  **Sources:**
  
  - Raku Programming Language: https://raku.org/
  - Raku Documentation: https://docs.perl6.org/
  - The Perl Foundation News. TPF response to Raku rename: 
https://news.perlfoundation.org/post/tpf-response-raku-rename
  - LWN.net. Perl 6 renamed to Raku: https://lwn.net/Articles/802329/
  
  **NOTE:** This was sent by nvisser on GitHub: 
https://github.com/KDE/syntax-highlighting/pull/24

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  rename-perl6-raku

REVISION DETAIL
  https://phabricator.kde.org/D29793

AFFECTED FILES
  autotests/folding/highlight.pl6.fold
  autotests/folding/highlight.raku.fold
  autotests/html/highlight.pl6.html
  autotests/html/highlight.raku.html
  autotests/input/highlight.pl6
  autotests/input/highlight.raku
  autotests/reference/highlight.pl6.ref
  autotests/reference/highlight.raku.ref
  data/syntax/perl6.xml
  data/syntax/raku.xml

To: nibags, #framework_syntax_highlighting, #kate, jpoelen, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29521

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 419125
  
  Fix folding in \end{...}
  
  
  In `\end{...}` the folding region "block" is terminated twice, which causes a 
folding error.
  
  Add folding in regions BEGIN/END
  
  
  Add code folding in the rules of the region markers BEGIN/END. The context 
"FindComments" is created with the rules of comments.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-folding-latex

REVISION DETAIL
  https://phabricator.kde.org/D29521

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/highlight.tex.fold
  autotests/html/highlight.tex.html
  autotests/input/highlight.tex
  autotests/reference/highlight.tex.ref
  data/syntax/latex.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29354: Bash: fix comments after escapes

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29354: Bash: fix comments after escapes

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29354: Bash: fix comments after escapes

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 418876
  
  Comments were not highlighted after an escaped space, but this should only 
occur in commands.
  This is corrected: outside of a command, comments are highlighted after an 
escaped space.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-comments-bash

REVISION DETAIL
  https://phabricator.kde.org/D29354

AFFECTED FILES
  autotests/folding/highlight.sh.fold
  autotests/html/highlight.sh.html
  autotests/input/highlight.sh
  autotests/reference/highlight.sh.ref
  autotests/reference/test.bb.ref
  data/syntax/bash.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28814: TypeScript: add the "awaited" type operator

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Add the new keyword "awaited": 
https://github.com/microsoft/TypeScript/pull/35998

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-awaited-typescript

REVISION DETAIL
  https://phabricator.kde.org/D28814

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/html/test.ts.html
  autotests/input/test.ts
  autotests/reference/test.ts.ref
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27660: Add Inno Setup syntax, including embedded Pascal scripting

[Nibaldo González]

nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27660

To: zrax, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28303: LaTeX: fix math parentheses in optional labels

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, 
jpoelen.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 418979
  
  Single parentheses within `[...]` were highlighted as math text, but the math 
text is `\(...\)`.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-latex

REVISION DETAIL
  https://phabricator.kde.org/D28303

AFFECTED FILES
  autotests/folding/highlight.tex.fold
  autotests/html/highlight.tex.html
  autotests/input/highlight.tex
  autotests/reference/highlight.tex.ref
  data/syntax/latex.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27797: Agda: keywords updated to 2.6.0 and fix float points

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  New keywords are added, this corresponds to the pull request:
  https://github.com/KDE/syntax-highlighting/pull/23
  
  I also added a test file, which I obtained from: 
https://github.com/agda/agda/blob/master/examples/syntax/highlighting/Test.agda
  
  When I saw the test file, I noticed some problems in the highlighting of 
floating point. So I fixed this, according to the lexical described in the Agda 
documentation: 
https://agda.readthedocs.io/en/latest/language/lexical-structure.html#literals
  
  In addition, I added folded and `##Alerts` in the comments.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-agda

REVISION DETAIL
  https://phabricator.kde.org/D27797

AFFECTED FILES
  autotests/folding/test.agda.fold
  autotests/html/test.agda.html
  autotests/input/test.agda
  autotests/reference/test.agda.ref
  data/syntax/agda.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27692

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

[Nibaldo González]

nibags updated this revision to Diff 76518.
nibags added a comment.


  - Update TypeScript

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27692?vs=76511=76518

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D27692

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/highlight.php.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.markdown.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27693: Add syntax highlighting for Java Properties

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  https://en.wikipedia.org/wiki/.properties
  
  The XML file was sent to kwrite-de...@kde.org by Matthias Böhm.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-java-properties

REVISION DETAIL
  https://phabricator.kde.org/D27693

AFFECTED FILES
  autotests/folding/test.properties.fold
  autotests/html/test.properties.html
  autotests/input/test.properties
  autotests/reference/test.properties.ref
  data/syntax/java-properties.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  - Add private-named instance fields. Ex: `x.#name;`. [1]
  - Support type-only imports and exports. [2]
  - Improve the detection of conditional expressions `a ? b : c`. Allow 
multiple lines.
  - Add rules of round brackets `()` to correct bracket animation feature. [3]
  
  [1] https://github.com/microsoft/TypeScript/pull/30829
  [2] https://github.com/microsoft/TypeScript/pull/35200
  [3] 
https://unix.stackexchange.com/questions/527268/kate-18-12-3-no-longer-shows-matching-parenthesis-for-typescript

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D27692

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/highlight.php.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.markdown.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27343: Makefile highlight: fix variable names in "else" conditionals

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27343

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27343: Makefile highlight: fix variable names in "else" conditionals

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 417379
  
  Allow highlighting variables in "else" conditionals, for example: `else ifdef 
foo` or `else ifeq (bar, foo)`.
  
  Previously, these (bar and foo) were highlighted as "Error".

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-makefile

REVISION DETAIL
  https://phabricator.kde.org/D27343

AFFECTED FILES
  autotests/folding/Makefile.fold
  autotests/html/Makefile.html
  autotests/input/Makefile
  autotests/reference/Makefile.ref
  data/syntax/makefile.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27313: Add syntax highlighting for Solidity

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  FEATURE: 411867
  
  The XML file was created by Robert Kaiser and attached in: 
https://bugs.kde.org/show_bug.cgi?id=411867
  
  I took the test file from the Solidity documentation: 
https://solidity.readthedocs.io/en/latest/solidity-by-example.html

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-solidity

REVISION DETAIL
  https://phabricator.kde.org/D27313

AFFECTED FILES
  autotests/folding/test.sol.fold
  autotests/html/test.sol.html
  autotests/input/test.sol
  autotests/reference/test.sol.ref
  data/syntax/solidity.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27009: Makefile highlight: add substitutions

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 416685
  
  Add substitutions:
  
$(var:pattern=replacement)
  
  **Source:** 
https://www.gnu.org/savannah-checkouts/gnu/make/manual/html_node/Text-Functions.html

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  makefile-substitutions

REVISION DETAIL
  https://phabricator.kde.org/D27009

AFFECTED FILES
  autotests/folding/Makefile.fold
  autotests/html/Makefile.html
  autotests/input/Makefile
  autotests/reference/Makefile.ref
  data/syntax/makefile.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26957: KateModeMenuList: don't overlap the scroll bar

[Nibaldo González]

nibags updated this revision to Diff 74531.
nibags added a comment.


  - Restore parameters

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26957?vs=74479=74531

BRANCH
  mode-menu-scrollbar-overlap

REVISION DETAIL
  https://phabricator.kde.org/D26957

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, cullmann, #ktexteditor
Cc: ngraham, anthonyfieroni, kwrite-devel, kde-frameworks-devel, rrosch, 
LeGast00n, GB_2, domson, michaelh, bruns, demsking, cullmann, sars, dhaumann

D26957: KateModeMenuList: don't overlap the scroll bar

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: cullmann, KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D26957

To: nibags, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26957: KateModeMenuList: don't overlap the scroll bar

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  mode-menu-scrollbar-overlap

REVISION DETAIL
  https://phabricator.kde.org/D26957

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26151: LaTeX: fix brackets in some commands

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6ddf50d243dd: LaTeX: fix brackets in some commands 
(authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26151?vs=71983=72031

REVISION DETAIL
  https://phabricator.kde.org/D26151

AFFECTED FILES
  autotests/folding/highlight.tex.fold
  autotests/html/highlight.tex.html
  autotests/input/highlight.tex
  autotests/reference/highlight.tex.ref
  data/syntax/latex.xml

To: nibags, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D26151: LaTeX: fix brackets in some commands

[Nibaldo González]

nibags created this revision.
nibags added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 415384
  
  In the parameter of some commands, such as `\input{\a{}}`, the brackets are 
closed incorrectly, which causes the pairs of brackets to be marked incorrectly.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  latex-brackets

REVISION DETAIL
  https://phabricator.kde.org/D26151

AFFECTED FILES
  autotests/folding/highlight.tex.fold
  autotests/html/highlight.tex.html
  autotests/input/highlight.tex
  autotests/reference/highlight.tex.ref
  data/syntax/latex.xml

To: nibags, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25939: TypeScript: add "bigint" primitive type

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25939

To: nibags, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D25939: TypeScript: add "bigint" primitive type

[Nibaldo González]

nibags created this revision.
nibags added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Add the "bigint" type: 
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-2.html#bigint

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  typescript-bigint-type

REVISION DETAIL
  https://phabricator.kde.org/D25939

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/html/test.ts.html
  autotests/input/test.ts
  autotests/reference/test.ts.ref
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25869

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

[Nibaldo González]

nibags updated this revision to Diff 71333.
nibags added a comment.


  - Improve number delimiters (use lookbehind)

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25869?vs=71242=71333

BRANCH
  python-numbers

REVISION DETAIL
  https://phabricator.kde.org/D25869

AFFECTED FILES
  autotests/folding/test.py.fold
  autotests/html/test.py.html
  autotests/input/test.py
  autotests/reference/test.py.ref
  data/syntax/python.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25870: SELinux: add "glblub" keyword and update permissions list

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6f9022a66567: SELinux: add glblub keyword and 
update permissions list (authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25870?vs=71243=71307

REVISION DETAIL
  https://phabricator.kde.org/D25870

AFFECTED FILES
  autotests/folding/test.cil.fold
  autotests/folding/test.te.fold
  autotests/html/test.cil.html
  autotests/html/test.te.html
  autotests/input/test.cil
  autotests/input/test.te
  autotests/reference/test.cil.ref
  autotests/reference/test.te.ref
  data/syntax/selinux-cil.xml
  data/syntax/selinux.xml

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25870: SELinux: add "glblub" keyword and update permissions list

[Nibaldo González]

nibags edited the test plan for this revision.
nibags added reviewers: dhaumann, cullmann, Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25870

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25870: SELinux: add "glblub" keyword and update permissions list

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  - Add new keyword "glblub" for default_range rules: 
https://github.com/SELinuxProject/selinux/commit/9ba35fe8c280b7c91ec65b138d9f13e44ededaa9
  
  - Update vector permissions list:
1. Add watch access vectors:
  - 
https://github.com/SELinuxProject/refpolicy/commit/c656b97a289ce6c2da2871700384f0f9d831be18#diff-792dd8ea2659914d48ee2fa0fe1eda1c
  - 
https://android.googlesource.com/platform/system/sepolicy/+/dddbaaf1e8791f8fffde424aa09a6e135f973771
  - 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ac5656d8a4cdd93cd2c74355ed12e5617817e0e7
2. Remove translate permission:
  - 
https://github.com/SELinuxProject/refpolicy/commit/65da822c1b5c70bd1ff7eca645f5f9fd74fa949e#diff-792dd8ea2659914d48ee2fa0fe1eda1c

TEST PLAN
  dhaumann, cullmann, #framework_syntax_highlighting 


REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-selinux

REVISION DETAIL
  https://phabricator.kde.org/D25870

AFFECTED FILES
  autotests/folding/test.cil.fold
  autotests/folding/test.te.fold
  autotests/html/test.cil.html
  autotests/html/test.te.html
  autotests/input/test.cil
  autotests/input/test.te
  autotests/reference/test.cil.ref
  autotests/reference/test.te.ref
  data/syntax/selinux-cil.xml
  data/syntax/selinux.xml

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

[Nibaldo González]

nibags updated this revision to Diff 71242.
nibags added a comment.


  - Fix autotest

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25869?vs=71241=71242

BRANCH
  python-numbers

REVISION DETAIL
  https://phabricator.kde.org/D25869

AFFECTED FILES
  autotests/folding/test.py.fold
  autotests/html/test.py.html
  autotests/input/test.py
  autotests/reference/test.py.ref
  data/syntax/python.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25869

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  - Improve number detection with underscores. Add binaries and octales. 
https://www.python.org/dev/peps/pep-0515/ (I took the regular expressions from 
the TypeScript highlighting file and adapted them to Python).
  - Add keyword "breakpoint" introduced in Python 3.7: 
https://www.python.org/dev/peps/pep-0553/

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  python-numbers

REVISION DETAIL
  https://phabricator.kde.org/D25869

AFFECTED FILES
  autotests/folding/test.py.fold
  autotests/html/test.py.html
  autotests/input/test.py
  autotests/reference/test.py.ref
  data/syntax/python.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25409: rst: Add support for standalone hyperlinks

[Nibaldo González]

nibags added a comment.


  The version and kateversion are updated in D25276 


REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25409

To: adrianchavesfernandez, mosra, nibags
Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25276: reStructuredText: Fix inline literals highlighting preceding characters

[Nibaldo González]

nibags closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D25276

To: adrianchavesfernandez, mosra, dhaumann
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D25276: reStructuredText: Fix inline literals highlighting preceding characters

[Nibaldo González]

nibags updated this revision to Diff 70849.
nibags added a comment.


  Update kateversion to 5.0: use of POSIX character classes in regular 
expressions

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25276?vs=70846=70849

BRANCH
  arcpatch-D25276

REVISION DETAIL
  https://phabricator.kde.org/D25276

AFFECTED FILES
  autotests/folding/highlight.rst.fold
  autotests/html/highlight.cmake.html
  autotests/html/highlight.rst.html
  autotests/input/highlight.rst
  autotests/reference/highlight.cmake.ref
  autotests/reference/highlight.rst.ref
  data/syntax/rest.xml

To: adrianchavesfernandez, mosra, dhaumann
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D25276: reStructuredText: Fix inline literals highlighting preceding characters

[Nibaldo González]

nibags updated this revision to Diff 70846.
nibags added a comment.


  - Update version & branch

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25276?vs=69647=70846

BRANCH
  arcpatch-D25276

REVISION DETAIL
  https://phabricator.kde.org/D25276

AFFECTED FILES
  autotests/folding/highlight.rst.fold
  autotests/html/highlight.cmake.html
  autotests/html/highlight.rst.html
  autotests/input/highlight.rst
  autotests/reference/highlight.cmake.ref
  autotests/reference/highlight.rst.ref
  data/syntax/rest.xml

To: adrianchavesfernandez, mosra, dhaumann
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D25409: rst: Add support for standalone hyperlinks

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25409

To: adrianchavesfernandez, mosra, nibags
Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25409: rst: Add support for standalone hyperlinks

[Nibaldo González]

nibags accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  arcpatch-D25409

REVISION DETAIL
  https://phabricator.kde.org/D25409

To: adrianchavesfernandez, mosra, nibags
Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25409: rst: Add support for standalone hyperlinks

[Nibaldo González]

nibags updated this revision to Diff 70841.
nibags added a comment.


  - Update branch & remove autotests

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25409?vs=70011=70841

BRANCH
  arcpatch-D25409

REVISION DETAIL
  https://phabricator.kde.org/D25409

AFFECTED FILES
  autotests/input/highlight.rst
  data/syntax/markdown.xml
  data/syntax/rest.xml

To: adrianchavesfernandez, mosra
Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25276: reStructuredText: Fix inline literals highlighting preceding characters

[Nibaldo González]

nibags added a comment.


  @dhaumann I take care to correct the version and commit this

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25276

To: adrianchavesfernandez, mosra
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D24982: Small improvements in some XML files

[Nibaldo González]

nibags updated this revision to Diff 70781.
nibags added a comment.


  - Resolve conflicts

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24982?vs=70779=70781

REVISION DETAIL
  https://phabricator.kde.org/D24982

AFFECTED FILES
  autotests/folding/highlight.y.fold
  data/syntax/apparmor.xml
  data/syntax/coffee.xml
  data/syntax/fortran-fixed.xml
  data/syntax/fortran-free.xml
  data/syntax/html.xml
  data/syntax/logcat.xml
  data/syntax/mustache.xml
  data/syntax/rust.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml
  data/syntax/selinux.xml
  data/syntax/xml.xml
  data/syntax/yacc.xml
  data/syntax/yaml.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24982: Small improvements in some XML files

[Nibaldo González]

nibags updated this revision to Diff 70779.
nibags added a comment.


  - Resolve merge conflicts.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24982?vs=68824=70779

REVISION DETAIL
  https://phabricator.kde.org/D24982

AFFECTED FILES
  autotests/folding/highlight.y.fold
  data/syntax/apparmor.xml
  data/syntax/coffee.xml
  data/syntax/fortran-fixed.xml
  data/syntax/fortran-free.xml
  data/syntax/html.xml
  data/syntax/logcat.xml
  data/syntax/mustache.xml
  data/syntax/rust.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml
  data/syntax/selinux.xml
  data/syntax/xml.xml
  data/syntax/yacc.xml
  data/syntax/yaml.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24982: Small improvements in some XML files

[Nibaldo González]

nibags added a comment.


  Captures can also be used without dynamic rules, for example in the regular 
expression: `(+)[^]*\1`
  In these cases, a `capture="true"` attribute can be used to enable captures, 
but in dynamic rules the detection will be automatic.
  
  I could do a benchmark the test units with the disabled captures to check the 
improvement in performance, and see if these changes are worth making.
  
  I don't know if you want to include this diff. If you prefer, I can update 
this diff, remove the inclusion of `?:` in regex and leave only the other 
improvements.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24982

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

[Nibaldo González]

nibags added a comment.


  Now the object KateModeMenuList is obtained from the object KateStatusBar.  I 
don't know if you prefer this way

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25390

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

[Nibaldo González]

nibags updated this revision to Diff 70392.
nibags added a comment.


  - Get the KateMenuList objects using KateGlobal

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25390?vs=69971=70392

BRANCH
  verify-katefiletypes

REVISION DETAIL
  https://phabricator.kde.org/D25390

AFFECTED FILES
  src/mode/katemodemanager.cpp
  src/mode/katemodemenu.cpp
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h
  src/syntax/katehighlightmenu.cpp
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25503: JavaScript: move keywords from TypeScript and other improvements

[Nibaldo González]

nibags updated this revision to Diff 70254.
nibags added a comment.


  - Update comment

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25503?vs=70253=70254

BRANCH
  improve-javascript

REVISION DETAIL
  https://phabricator.kde.org/D25503

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/highlight.js.fold
  autotests/folding/highlight.jsp.fold
  autotests/folding/highlight.php.fold
  autotests/folding/test.coffee.fold
  autotests/folding/test.htm.fold
  autotests/folding/test.js.fold
  autotests/folding/test.jsx.fold
  autotests/folding/test.markdown.fold
  autotests/folding/test.qml.fold
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/highlight.js.html
  autotests/html/highlight.jsp.html
  autotests/html/highlight.php.html
  autotests/html/highlight.qml.html
  autotests/html/test.coffee.html
  autotests/html/test.htm.html
  autotests/html/test.js.html
  autotests/html/test.jsx.html
  autotests/html/test.markdown.html
  autotests/html/test.qml.html
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/highlight.js
  autotests/input/test.coffee
  autotests/input/test.js
  autotests/input/test.jsx
  autotests/input/test.qml
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/highlight.js.ref
  autotests/reference/highlight.jsp.ref
  autotests/reference/highlight.php.ref
  autotests/reference/highlight.qml.ref
  autotests/reference/test.coffee.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.js.ref
  autotests/reference/test.jsx.ref
  autotests/reference/test.markdown.ref
  autotests/reference/test.qml.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/coffee.xml
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/qml.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25503: JavaScript: move keywords from TypeScript and other improvements

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: cullmann, dhaumann, Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25503

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25503: JavaScript: move keywords from TypeScript and other improvements

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-javascript

REVISION DETAIL
  https://phabricator.kde.org/D25503

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/highlight.js.fold
  autotests/folding/highlight.jsp.fold
  autotests/folding/highlight.php.fold
  autotests/folding/test.coffee.fold
  autotests/folding/test.htm.fold
  autotests/folding/test.js.fold
  autotests/folding/test.jsx.fold
  autotests/folding/test.markdown.fold
  autotests/folding/test.qml.fold
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/highlight.js.html
  autotests/html/highlight.jsp.html
  autotests/html/highlight.php.html
  autotests/html/highlight.qml.html
  autotests/html/test.coffee.html
  autotests/html/test.htm.html
  autotests/html/test.js.html
  autotests/html/test.jsx.html
  autotests/html/test.markdown.html
  autotests/html/test.qml.html
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/highlight.js
  autotests/input/test.coffee
  autotests/input/test.js
  autotests/input/test.jsx
  autotests/input/test.qml
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/highlight.js.ref
  autotests/reference/highlight.jsp.ref
  autotests/reference/highlight.php.ref
  autotests/reference/highlight.qml.ref
  autotests/reference/test.coffee.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.js.ref
  autotests/reference/test.jsx.ref
  autotests/reference/test.markdown.ref
  autotests/reference/test.qml.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/coffee.xml
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/qml.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25429: JavaScript/TypeScript React: rename syntax definitions

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Rename definitions from **JavaScript React** to **JavaScript React (JSX)**; 
and from **TypeScript React** to **TypeScript React (TSX)**. Because JSX 
(JavaScript-XML) is the name of the files and React doesn't necessarily use 
JSX. It's much more descriptive to add JSX and TSX to the name of the 
definition, especially to facilitate the user search for highlighting languages.
  
  More: https://en.reactjs.org/docs/introducing-jsx.html

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  rename-def-jsx

REVISION DETAIL
  https://phabricator.kde.org/D25429

AFFECTED FILES
  autotests/html/test.jsx.html
  autotests/html/test.tsx.html
  autotests/syntaxrepository_test.cpp
  data/syntax/html.xml
  data/syntax/javascript-react.xml
  data/syntax/markdown.xml
  data/syntax/typescript-react.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: KTextEditor, cullmann, dhaumann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25390

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

[Nibaldo González]

nibags updated this revision to Diff 69971.
nibags added a comment.


  - Fix format

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25390?vs=69970=69971

BRANCH
  verify-katefiletypes

REVISION DETAIL
  https://phabricator.kde.org/D25390

AFFECTED FILES
  src/mode/katemodemanager.cpp
  src/mode/katemodemenu.cpp
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h
  src/syntax/katehighlightmenu.cpp

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  verify-katefiletypes

REVISION DETAIL
  https://phabricator.kde.org/D25390

AFFECTED FILES
  src/mode/katemodemanager.cpp
  src/mode/katemodemenu.cpp
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h
  src/syntax/katehighlightmenu.cpp

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25389: Verify modes of the session config file

[Nibaldo González]

nibags edited the summary of this revision.
nibags edited the test plan for this revision.
nibags added reviewers: KTextEditor, cullmann, dhaumann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25389

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25389: Verify modes of the session config file

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  verify-session-modes

REVISION DETAIL
  https://phabricator.kde.org/D25389

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25139: LaTeX: fix backslash delimiter in some keywords

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25139

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25139: LaTeX: fix backslash delimiter in some keywords

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  latex-keys-del

REVISION DETAIL
  https://phabricator.kde.org/D25139

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25139: LaTeX: fix backslash delimiter in some keywords

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25139

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25139: LaTeX: fix backslash delimiter in some keywords

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, 
jpoelen.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 413493
  
  A delimiter before keywords of kind `\command` isn't required. Therefore, a 
DetectChar rule with lookAhead is used to detect `\` at the beginning of the 
keywords, and thus avoid the delimiter in the keyword.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  latex-keys-del

REVISION DETAIL
  https://phabricator.kde.org/D25139

AFFECTED FILES
  autotests/folding/highlight.tex.fold
  autotests/html/highlight.tex.html
  autotests/input/highlight.tex
  autotests/reference/highlight.tex.ref
  data/syntax/latex.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25102: VHDL: all keywords are insensitive

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25102

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D24983

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25102: VHDL: all keywords are insensitive

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 413409
  
  In the VHDL highlighter all the rules have the **insensitive** flag, except 
two, probably by mistake.
  I also add `##Alerts` in comments.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-vhdl

REVISION DETAIL
  https://phabricator.kde.org/D25102

AFFECTED FILES
  autotests/folding/light52_tb.vhdl.fold
  autotests/html/light52_muldiv.vhdl.html
  autotests/html/light52_tb.vhdl.html
  autotests/input/light52_tb.vhdl
  autotests/reference/light52_muldiv.vhdl.ref
  autotests/reference/light52_tb.vhdl.ref
  data/syntax/vhdl.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags updated this revision to Diff 69150.
nibags added a comment.


  - Increase the menu size according to the font size, to improve the display
  
  This achieves a better visualization if the user increases the font size in 
the Plasma preferences.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24983?vs=69022=69150

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags updated this revision to Diff 69022.
nibags added a comment.


  - Increase margin of list - search bar in Windows

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24983?vs=69005=69022

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags updated this revision to Diff 69005.
nibags added a comment.


  - Restore scroll bar margins

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24983?vs=68974=69005

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags updated this revision to Diff 68974.
nibags added a comment.


  - Fix font size/style

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24983?vs=68828=68974

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24982: Small improvements in some XML files

[Nibaldo González]

nibags added a comment.


  No, the dynamic flag is used to insert the captures already stored in `%N` 
(the captures are stored in the RegExpr rules and then "inserted" in the rules 
with the dynamic flag)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24982

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24981: Modelines: fix end of comment

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:73489a79f9fd: Modelines: fix end of comment (authored by 
nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24981?vs=68820=68870

REVISION DETAIL
  https://phabricator.kde.org/D24981

AFFECTED FILES
  autotests/folding/test.js.fold
  autotests/html/test.js.html
  autotests/input/test.js
  autotests/reference/test.js.ref
  data/syntax/modelines.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags added a comment.


  `QFontMetrics::boundingRect(text).width()` doesn't deliver an exact value of 
the text width, since I detected that in some translations and some desktop 
themes the text goes below the scroll bar. This problem doesn't exist with 
`QFontMetrics::horizontalAdvance(text)`.
  
  For example, in the "Fusion" application style, with Portuguese language, it 
may be incorrectly seen:
  Before / After
  F7676460: Sin nombre.png 

REPOSITORY
  R39 KTextEditor

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24982: Small improvements in some XML files

[Nibaldo González]

nibags added a comment.


  I had also thought about using `QRegularExpression::DontCaptureOption`, which 
is equivalent to using `(?:...)`, but I wasn't sure how much the real 
improvement in performance is. However, disabling captures avoids allocating 
unnecessary QString for each capture.
  
  One option would be to add a **capture** or **dontCapture** attribute to 
enable or disable captures for RegExpr rules. Also, captures could be enabled 
or disabled in all RegExpr rules using the  group, adding an 
element for that.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24982

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags updated this revision to Diff 68828.
nibags added a comment.


  - Fixes

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24983?vs=68827=68828

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags created this revision.
nibags added reviewers: KTextEditor, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  - Use `QFontMetrics::horizontalAdvance(text)` instead of 
`QFontMetrics::boundingRect(text).width()`, since it obtains a more precise 
value over the width of a text.
  - Allow word wrap in section titles.

REPOSITORY
  R39 KTextEditor

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24982: Small improvements in some XML files

[Nibaldo González]

nibags updated this revision to Diff 68824.
nibags added a comment.


  - Increase version of javascript.xml

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24982?vs=68823=68824

BRANCH
  improve-some-xml

REVISION DETAIL
  https://phabricator.kde.org/D24982

AFFECTED FILES
  autotests/folding/highlight.y.fold
  data/syntax/apparmor.xml
  data/syntax/coffee.xml
  data/syntax/fortran-fixed.xml
  data/syntax/fortran-free.xml
  data/syntax/html.xml
  data/syntax/javascript.xml
  data/syntax/logcat.xml
  data/syntax/mustache.xml
  data/syntax/rust.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml
  data/syntax/selinux.xml
  data/syntax/xml.xml
  data/syntax/yacc.xml
  data/syntax/yaml.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24982: Small improvements in some XML files

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  **Changes:**
  
  - Replace some unnecessary RegExpr rules with other rules.
  - Use non-capturing groups in some regular expressions.
  - Add `##Modelines` in comments.
  - Add folding for multi-line comments, add attribute `region` in element 
``.
  - Add `column` atributte in some rules.

TEST PLAN
  make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-some-xml

REVISION DETAIL
  https://phabricator.kde.org/D24982

AFFECTED FILES
  autotests/folding/highlight.y.fold
  data/syntax/apparmor.xml
  data/syntax/coffee.xml
  data/syntax/fortran-fixed.xml
  data/syntax/fortran-free.xml
  data/syntax/html.xml
  data/syntax/javascript.xml
  data/syntax/logcat.xml
  data/syntax/mustache.xml
  data/syntax/rust.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml
  data/syntax/selinux.xml
  data/syntax/xml.xml
  data/syntax/yacc.xml
  data/syntax/yaml.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24981: Modelines: fix end of comment

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Use `fallthroughContext` to finish Modeline. This allows you to finish the 
comment block correctly if the Modeline is incomplete.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-end-modelines

REVISION DETAIL
  https://phabricator.kde.org/D24981

AFFECTED FILES
  autotests/folding/test.js.fold
  autotests/html/test.js.html
  autotests/input/test.js
  autotests/reference/test.js.ref
  data/syntax/modelines.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24355: TypeScript: update grammar and fixes

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c6f2bd8ba96d: TypeScript: update grammar and fixes 
(authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24355?vs=67588=67624

REVISION DETAIL
  https://phabricator.kde.org/D24355

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24357: KateModeMenuList: force the vertical position above the button

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D24357

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24355: TypeScript: update grammar and fixes

[Nibaldo González]

nibags updated this revision to Diff 67588.
nibags added a comment.


  - TypeScript React: fix end-line regex

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24355?vs=67587=67588

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D24355

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24355: TypeScript: update grammar and fixes

[Nibaldo González]

nibags updated this revision to Diff 67587.
nibags added a comment.


  typescript-react: increase version.
  javascript: use non-capturing groups in RegExpr

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24355?vs=67162=67587

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D24355

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24355: TypeScript: update grammar and fixes

[Nibaldo González]

nibags added a comment.


  ups! i will correct it

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D24355

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: minor fixes

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: minor fixes

[Nibaldo González]

nibags added a comment.


  As the delimiters in WordDetect rules were changed in D24378 
, I updated this diff only by making minor 
fixes in the Mustache/Handlebars definition.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: minor fixes

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: minor fixes

[Nibaldo González]

nibags retitled this revision from "Mustache/Handlebars: fix delimiters in HTML 
tags" to "Mustache/Handlebars: minor fixes".

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: fix delimiters in HTML tags

[Nibaldo González]

nibags updated this revision to Diff 67297.
nibags added a comment.


  Minor corrections:
  
  - Restore WordDetect rules
  - Use **kateversion="5.44"** (WordDetect with insensitive).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24354?vs=67161=67297

BRANCH
  fix-delimiters-mustache

REVISION DETAIL
  https://phabricator.kde.org/D24354

AFFECTED FILES
  autotests/folding/test.mustache.fold
  autotests/html/test.mustache.html
  autotests/input/test.mustache
  autotests/reference/test.mustache.ref
  data/syntax/mustache.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24378: WordDetect rule: detect delimiters at the inner edge of the string

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24378

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24378: WordDetect rule: detect delimiters at the inner edge of the string

[Nibaldo González]

nibags updated this revision to Diff 67238.
nibags added a comment.


  - Add comment

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24378?vs=67237=67238

BRANCH
  fix-worddetect

REVISION DETAIL
  https://phabricator.kde.org/D24378

AFFECTED FILES
  autotests/folding/delimiters_WordDetect.delWordDetect.fold
  autotests/html/delimiters_WordDetect.delWordDetect.html
  autotests/input/delimiters_WordDetect.delWordDetect
  autotests/input/syntax/delimiters_WordDetect.xml
  autotests/reference/delimiters_WordDetect.delWordDetect.ref
  data/syntax/elm.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml
  src/lib/rule.cpp

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: fix delimiters in HTML tags

[Nibaldo González]

nibags added a comment.


  i did it in: D24378 

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24378: WordDetect rule: detect delimiters at the inner edge of the string

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, 
vkrause, jpoelen.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  In WordDetect rules, verify delimiter characters also on the right and left 
edges inside the string.
  
  For example:
  

  
  In the past, this rule was equivalent to `\bhttps://phabricator.kde.org/D24378

AFFECTED FILES
  autotests/folding/delimiters_WordDetect.delWordDetect.fold
  autotests/html/delimiters_WordDetect.delWordDetect.html
  autotests/input/delimiters_WordDetect.delWordDetect
  autotests/input/syntax/delimiters_WordDetect.xml
  autotests/reference/delimiters_WordDetect.delWordDetect.ref
  data/syntax/elm.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml
  src/lib/rule.cpp

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: fix delimiters in HTML tags

[Nibaldo González]

nibags added a comment.


  I think it makes sense to change this in WorDetect: verify delimiter 
characters on the left and right edge of the string, either inside or outside 
the string. I will make another diff with this.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: fix delimiters in HTML tags

[Nibaldo González]

nibags added a comment.


  Indeed, WordDetect checks only the boundaries. What happens is that when 
using WordDetect with `".
  It's correct to use RegExpr with `https://phabricator.kde.org/D24354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24357: KateModeMenuList: force the vertical position above the button

[Nibaldo González]

nibags created this revision.
nibags added reviewers: KTextEditor, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Always display the menu above the trigger button, just like the rest of the 
menus in the status bar (class `KateStatusBarOpenUpMenu`).
  
  This is only noticeable on large monitors, when Kate's window is small.

REPOSITORY
  R39 KTextEditor

BRANCH
  menu-vertical-position

REVISION DETAIL
  https://phabricator.kde.org/D24357

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h
  src/view/katestatusbar.cpp

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24355: TypeScript: update grammar and fixes

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  TypeScript:
  
  - Add asserts: https://github.com/microsoft/TypeScript/pull/32695
  - Highlight types after `as` expression.
  - Add type helpers: 
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-5.html#the-omit-helper-type
  
  TypeScript React (TSX):
  
  - When `https://github.com/microsoft/TypeScript-TmLanguage/commit/11b1a4f8dc3a3eaa4df71e8cc1ad6f01a688961d
  
  JavaScript React (JSX):
  
  - Use non-capture groups in RegExpr rules.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D24355

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann