D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-08 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, c

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-09 Thread Niccolò Venerandi
niccolove added a comment. In D27122#608324 , @ndavis wrote: > Still uses ViewBackground on panels. For panel popups, you wanted to use a header area like the systray mockups, right? If so, the dialog SVG could use ViewBackground and you should

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-10 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-10 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-10 Thread Niccolò Venerandi
niccolove added a comment. - Breeze panel and dialog being different when using a dark theme - Avoiding controls to be used in ViewBackground areas / using Background Breeze color without it looking gray I have no idea how these could be fixed without just using a color file-d theme by

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-11 Thread Niccolò Venerandi
niccolove added a comment. In D27122#609276 , @ndavis wrote: > I think rather than adjusting hardcoded opacity in the SVGs, we need to make configurable plasmashell opacity a reality. Then, if we want to do an effect like what Nate described, we

D27354: Remove hardcoded colors

2020-02-12 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Fixes https://www.reddit.com/r/kde/comments/f2mxd3/517_seeing_weird_white_corners_on_my_autohiding/ BUG:417511

D27354: Remove hardcoded colors

2020-02-12 Thread Niccolò Venerandi
niccolove added a reviewer: ndavis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27354 To: niccolove, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27354: Remove hardcoded colors

2020-02-13 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R242:1ed47e7c4188: Remove hardcoded colors (authored by niccolove). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27354?vs=75572&id=75629 REVISION D

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-16 Thread Niccolò Venerandi
niccolove updated this revision to Diff 75786. niccolove added a comment. - Merge branch 'master' into contrast_effect_background_color REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75277&id=75786 BRANCH contrast_effect_backg

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-16 Thread Niccolò Venerandi
niccolove updated this revision to Diff 75787. niccolove added a comment. Make the panel always as transparent as the dialogs REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75786&id=75787 BRANCH contrast_effect_background_colo

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-16 Thread Niccolò Venerandi
niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Fe

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-16 Thread Niccolò Venerandi
niccolove added a comment. Regarding maximized windows: I don't think it's possible to make the dialog and panel feel united in this case; windows has this problem as well: F8107248: image.png I'd say this is the expected behavior for a theme with som

D27444: Added top area

2020-02-16 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY Adds top area for D27189 REPOSITORY R242 Plasma Framework (Library) BRANCH

D27444: Added top area

2020-02-16 Thread Niccolò Venerandi
niccolove added reviewers: VDG, ngraham, ndavis. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

2020-02-16 Thread Niccolò Venerandi
niccolove added a dependent revision: D27189: Created a top area based on widgets/toparea.svg. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngra

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY *gimme a sec* REPOSITORY R242 Plasma Framework (Library) BRANCH 2px_tasks (branched from master) REVISION DET

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove updated this revision to Diff 75798. niccolove added a comment. Used scour REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27445?vs=75797&id=75798 BRANCH 2px_tasks (branched from master) REVISION DETAIL https://phabricator.

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove planned changes to this revision. niccolove added a comment. I do prefer the 2px version, but I think a compromise would look best. I will try a 2.5px version, although I'm not sure how good .5 pixel are displayed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL http

D27445: Move tasks from 3px to 2px

2020-02-16 Thread Niccolò Venerandi
niccolove requested review of this revision. niccolove added a comment. Nope, that does not work. Let's stick to 2px. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, micha

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-16 Thread Niccolò Venerandi
niccolove edited the summary of this revision. niccolove added dependencies: D27189: Created a top area based on widgets/toparea.svg, D27439: Replaced isDock check with !hasDecoration. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolov

D27444: Added top area

2020-02-17 Thread Niccolò Venerandi
niccolove updated this revision to Diff 75824. niccolove added a comment. Remove hardcoded values REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=75796&id=75824 BRANCH top_area (branched from master) REVISION DETAIL https://

D27444: Added top area

2020-02-17 Thread Niccolò Venerandi
niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

2020-02-17 Thread Niccolò Venerandi
niccolove added a comment. In D27444#612582 , @ngraham wrote: > This will need CMake changes to actually install it. Isn't this automatically done by the glob? FILE(GLOB widgets widgets/*.svg) plasma_install_desktoptheme_svgs(de

D27445: Move tasks from 3px to 2px

2020-02-17 Thread Niccolò Venerandi
niccolove added a comment. With big panels this is not really a problem, but I feel like a 3px lines takes too much space from the icon space, making it a bit cramped. Here's an example of a theme using a 2px line as well (Sweet KDE, the most downloaded Plasma theme): F8108529: Screenshot_

D27444: Added top area

2020-02-20 Thread Niccolò Venerandi
niccolove added a comment. In D27444#614762 , @mart wrote: > - i would provide one single svg with top and bottom areas so one can use something like that as a footer as well (and probably a frame that has nothing rounded) > - if you have a to

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-20 Thread Niccolò Venerandi
niccolove added a comment. Couple of screenshots more from this patch: F8115905: Screenshot_20200220_194559.png F8115907: Screenshot_20200220_194611.png F8115910: Screenshot_20200220_194622.png

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76373. niccolove added a comment. Tweaked values REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=75787&id=76373 BRANCH contrast_effect_background_color (branched from master) REVISION DE

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Niccolò Venerandi
niccolove added a comment. I felt that the transparency was not working very well with the headerbar on some wallpapers, so I toned down the transparency a bit, going from F8131395: image.png to F8131397: image.png

D27444: Added top area

2020-02-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76376. niccolove added a comment. Added toparea margins REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=75824&id=76376 BRANCH top_area (branched from master) REVISION DETAIL https://ph

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Niccolò Venerandi
niccolove added a comment. In D27122#617614 , @trmdi wrote: > Hmm, I think you need to rebase to remove unrelated files in this patch e.g. `dropjob.cpp` ... ? Definitively. *sigh* REPOSITORY R242 Plasma Framework (Library) REVISION DE

D27444: Added top area

2020-02-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76378. niccolove added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=76376&id=76378 BRANCH top_area (branched from master) REVISION DETAIL https://phabricator.kde.o

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76381. niccolove added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=76373&id=76381 BRANCH contrast_effect_background_color (branched from master) REVISION DETAIL h

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-25 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76382. niccolove added a comment. re-tweaked commits REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27122?vs=76381&id=76382 BRANCH contrast_effect_background_color (branched from master) REVISIO

D27444: Added top area

2020-02-27 Thread Niccolò Venerandi
niccolove added a dependent revision: D27695: WIP: Create a new TopArea element using widgets/toparea svg. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY This creates a new component that uses the widgets/toparea svg. First time I try to add something to PlasmaComponen

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76528. niccolove added a comment. Added licence REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76527&id=76528 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTE

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove added a dependent revision: D27189: Created a top area based on widgets/toparea.svg. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76531. niccolove added a comment. Fixed svg path REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76528&id=76531 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECT

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76534. niccolove added a comment. Fixed conditionals REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76531&id=76534 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AF

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove marked an inline comment as done. niccolove added inline comments. INLINE COMMENTS > ahiemstra wrote in TopArea.qml:40 > This conditional is wrong. The syntax is `condition ? true_case : false_case` > so you want to write `flipped ? -topAreaSvg.margins.top : > -topAreaSvg.margins.bott

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76562. niccolove added a comment. Hardcoded colors REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=76378&id=76562 BRANCH top_area (branched from master) REVISION DETAIL https://phabric

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76572. niccolove marked an inline comment as done. niccolove added a comment. Fixed margin REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76534&id=76572 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76822. niccolove added a comment. Width is fill anyway, no need to calculate it REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76572&id=76822 BRANCH master REVISION DETAIL https://pha

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY The style of pressed- listitem (which is actually often used for hover as well, while the hover- listitem is never

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove added reviewers: VDG, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Niccolò Venerandi
niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76860. niccolove added a comment. Moved the file to Extra components REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76822&id=76860 BRANCH master REVISION DETAIL https://phabricator.kd

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove added a comment. In D27695#621305 , @davidedmundson wrote: > PC3 is designed to be only a theme for QQC2 That's why I moved it to plasmaextracomponent with the last commit, actually REPOSITORY R242 Plasma Framework (Library)

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76862. niccolove added a comment. Replace test with widgets/toparea REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76860&id=76862 BRANCH master REVISION DETAIL https://phabricator.kde

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-03 Thread Niccolò Venerandi
niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27807: Changed style of pressed list item to be consistent

2020-03-04 Thread Niccolò Venerandi
niccolove abandoned this revision. niccolove added a comment. Actually, there is a proper way to do this. Gimme a sec. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove, #vdg, #plasma Cc: ngraham, plasma-devel, ndavis, kde-framewo

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-04 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76947. niccolove added a comment. Moved TopArea to PlasmoidHeading and various fixes in it REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76862&id=76947 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-04 Thread Niccolò Venerandi
niccolove added a comment. Two questions: - I know we should not assume it's a Layout, but margins should be defined inside the file as they compensate the inset; is it possible to both define them with Layout and anchors, or something that would work with both? - Is code on line 51 fi

D27848: Remove the tooltip icon

2020-03-04 Thread Niccolò Venerandi
niccolove accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27848 To: ngraham, #vdg, #plasma, cblack, niccolove Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngra

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77263. niccolove added a comment. Correct padding and borders REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76947&id=77263 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77266. niccolove added a comment. using =| REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77263&id=77266 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED FIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Niccolò Venerandi
niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-09 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77271. niccolove added a comment. documentation REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77266&id=77271 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTE

D27444: Added top area

2020-03-09 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77272. niccolove added a comment. Renamed file as plasmoidheader and used scour REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=76562&id=77272 BRANCH top_area (branched from master) REVI

D27445: Move tasks from 3px to 2px

2020-03-11 Thread Niccolò Venerandi
niccolove abandoned this revision. niccolove added a comment. I'd actually prefer to make the task manager extend to panel borders. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27445 To: niccolove, #vdg Cc: ndavis, ngraham, kde-frameworks-devel,

D25334: Added transparent blue background to tabbars

2020-03-11 Thread Niccolò Venerandi
niccolove abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77402. niccolove added a comment. Local is not a type REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77271&id=77402 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 A

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77404. niccolove added a comment. Missed a PlasmoidHeading. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77402&id=77404 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77405. niccolove added a comment. bottomPadding rather than bottomMargin REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77404&id=77405 BRANCH master REVISION DETAIL https://phabricato

D27444: Added top area

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77407. niccolove added a comment. Changed filename to heading REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=77272&id=77407 BRANCH top_area (branched from master) REVISION DETAIL http

D27444: Added plasmoid heading svg

2020-03-11 Thread Niccolò Venerandi
niccolove retitled this revision from "Added top area" to "Added plasmoid heading svg". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngrah

D27444: Added plasmoid heading svg

2020-03-11 Thread Niccolò Venerandi
niccolove edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77408. niccolove added a comment. use heading instead of header REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77405&id=77408 BRANCH master REVISION DETAIL https://phabricator.kde.org

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-11 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77418. niccolove added a comment. Trailing spaces REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77408&id=77418 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFEC

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-12 Thread Niccolò Venerandi
niccolove updated this revision to Diff 77482. niccolove added a comment. Added PlasmoidHeading to qmldir REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77418&id=77482 BRANCH master REVISION DETAIL https://phabricator.kde.o

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-12 Thread Niccolò Venerandi
niccolove planned changes to this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart, ngraham Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

<    1   2   3