D25660: Add member for editbookmarks action

nicolasfella added a task: T12056: KBookmarks. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25658: Remove superflous private

This revision was automatically updated to reflect the committed changes. Closed by commit R294:29139b7b8f66: Remove superflous private (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25658?vs=70678&id=70681 REVISION DETAIL htt

D25660: Add member for editbookmarks action

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY First step towards getting rid of KActionCollection dependency. Sav

D25659: Add TODO KF6 note

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R294 KBookmarks BRANCH toto REVISION DETAIL https://phabricator.kde

D25658: Remove superflous private

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R294 KBookmarks BRANCH pri REVISION DETAIL http

D25657: Clean up includes

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Sort alphabetically and use CamelCase headers TEST PLAN builds

D25656: Remove unneeded moc include

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R294 KBookmarks BRANCH moc REVISION DETAIL http

D25655: Remove outdated comments

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY They come from a time before KF5 and are probably outdated since th

D25654: Rename actions to be consistent

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Rename actions to all have Action suffix after D25653

D25653: [bookmarksmenu] Improve variable name

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY addAddBookmark make some sense as the method name, but as a variabl

D25629: Port away from KTextWidgets

This revision was automatically updated to reflect the committed changes. Closed by commit R263:13cb497277fa: Port away from KTextWidgets (authored by nicolasfella). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25629?vs=70619&id=70672 REVISION DETAIL http

D25650: Port foreach

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds, tests pass, dolphin opens REPOSITORY R263 KXmlGui BRANCH for

D25630: Port to json metadata

nicolasfella added a task: T11919: Port KDED modules from .desktop files to JSON metadata. REPOSITORY R150 KDE Telepathy KDE Daemon Module REVISION DETAIL https://phabricator.kde.org/D25630 To: nicolasfella, #frameworks

D25630: Port to json metadata

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. nicolasfella requested review of this revision. REPOSITORY R150 KDE Telepathy KDE Daemon Module BRANCH json REVISION DETAIL https://phabricator.kde.org/D25630 AFFECTED FILES CMakeLists.txt ktp_integration_m

D25630: Port to json metadata

nicolasfella added a reviewer: KDE Telepathy. REPOSITORY R150 KDE Telepathy KDE Daemon Module REVISION DETAIL https://phabricator.kde.org/D25630 To: nicolasfella, #frameworks, #kde_telepathy

D25533: Deprecate KFileWidget::toolBar

nicolasfella updated this revision to Diff 70622. nicolasfella added a comment. - Adjust version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25533?vs=70317&id=70622 BRANCH ktoolbar REVISION DETAIL https://phabricator.kde.org/D25533 AFFECTED FILES sr

D25629: Port away from KTextWidgets

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It is only used for the bugreport dialog for non-KDE apps. By repla

D25233: [kded] Port plugin metadata to JSON

This revision was automatically updated to reflect the committed changes. Closed by commit R363:0a54612c21a0: [kded] Port plugin metadata to JSON (authored by nicolasfella). REPOSITORY R363 Print Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25233?vs=69521&id=70383 REVISION

D25555: deprecate kregexpeditorinterface

This revision was automatically updated to reflect the committed changes. Closed by commit R310:1b2d198b6984: deprecate kregexpeditorinterface (authored by nicolasfella). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=70370&id=70372 REVISION DET

D25555: deprecate kregexpeditorinterface

nicolasfella added a reviewer: cullmann. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D2 To: nicolasfella, #frameworks, cullmann Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25555: deprecate kregexpeditorinterface

nicolasfella added a task: T12159: KTextWidgets: Remove plugin system. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D2 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25555: deprecate kregexpeditorinterface

nicolasfella edited the summary of this revision. nicolasfella added a reviewer: Frameworks. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D2 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25555: deprecate kregexpeditorinterface

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R310 KTextWidgets BRANCH regexped REVISION DETAIL https://phabricator.kde.org/D2 AFFECTED FILES src/CMa

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

This revision was automatically updated to reflect the committed changes. Closed by commit R310:3ba71ffb3865: [kfinddialog] Remove usage of kregexpeditor plugin system (authored by nicolasfella). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25538?vs=703

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

nicolasfella added a comment. > Beside that, should the header not get a deprecation attribute to ensure nobody new picks that up? yes, one step at a time :) REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D25538 To: nicolasfella, #frameworks, cullmann Cc:

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

nicolasfella updated this revision to Diff 70365. nicolasfella added a comment. - [kfinddialog] Remove usage of kregexpeditor plugin system - Remove desktop file REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25538?vs=70326&id=70365 BRANCH noplug

D25550: Mark KInit as porting aid

nicolasfella added a comment. Done with D25491 REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D25550 To: nicolasfella, #frameworks Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25551: Mark KXmlRpcClient as porting aid

nicolasfella added reviewers: Frameworks, dvratil. REPOSITORY R312 KXmlRpcClient REVISION DETAIL https://phabricator.kde.org/D25551 To: nicolasfella, #frameworks, dvratil Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25551: Mark KXmlRpcClient as porting aid

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Execute T12157 REPOSITORY R312 KXmlRpcClient BRANCH portaid REVISI

D25548: [kcookiejar] Remove unneeded KService linkage

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a215767ba692: [kcookiejar] Remove unneeded KService linkage (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25548?vs=70358&id=70362 REVISION

D25550: Mark KInit as porting aid

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY First step towards T12140 REP

D25548: [kcookiejar] Remove unneeded KService linkage

nicolasfella added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25548 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25548: [kcookiejar] Remove unneeded KService linkage

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R241 KIO BRANCH cookiejar REVISION DETAIL https://phabricator.kde.org/D25548 AFFECTED FIL

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

nicolasfella added a task: T12159: KTextWidgets: Remove plugin system. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D25538 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The interface is only provided by one unreleased application, so pe

D25528: Only build activities support if QtSQL is found

This revision was automatically updated to reflect the committed changes. Closed by commit R320:839fe1b51aea: Only build activities support if QtSQL is found (authored by nicolasfella). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25528?vs=70316&id=70321

D25233: [kded] Port plugin metadata to JSON

nicolasfella added a reviewer: KF6. REPOSITORY R363 Print Manager REVISION DETAIL https://phabricator.kde.org/D25233 To: nicolasfella, #frameworks, dantti, #kf6 Cc: kde-utils-devel

D25527: [activities/fileitemaction] Port plugin metadata to JSON

This revision was automatically updated to reflect the committed changes. Closed by commit R320:f5b426a7f294: [activities/fileitemaction] Port plugin metadata to JSON (authored by nicolasfella). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25527?vs=70299&

D25533: Deprecate KFileWidget::toolBar

nicolasfella added a task: T12206: Port KFileWidget away from KToolBar. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25533 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25533: Deprecate KFileWidget::toolBar

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It leaks KToolBar from KXmlGui into the public API. I did no

D25528: Only build activities support if QtSQL is found

nicolasfella updated this revision to Diff 70316. nicolasfella added a comment. - Use if TARGET REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25528?vs=70301&id=70316 BRANCH clean REVISION DETAIL https://phabricator.kde.org/D25528 AFFECTED FILES

D25528: Only build activities support if QtSQL is found

nicolasfella retitled this revision from "[activities] Clean up cmake" to "Only build activities support if QtSQL is found". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25528 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iase

D25512: Remove unused include

This revision was automatically updated to reflect the committed changes. Closed by commit R265:719569193c7d: Remove unused include (authored by nicolasfella). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25512?vs=70270&id=70302 REVISION DETAIL htt

D25528: [activities] Clean up cmake

nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25528 To: nicolasfella Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampalo

D25528: [activities] Clean up cmake

nicolasfella added a reviewer: Frameworks. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25528 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D25528: [activities] Clean up cmake

nicolasfella created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R320 KIO Extras BRANCH clean REVISION DETAIL https://phabricator.kde.org/D25528 AFFECTED FI

D25527: [activities/fileitemaction] Port plugin metadata to JSON

nicolasfella added a task: T12250: Port KFileItemActionPlugin usage to KPluginLoader. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25527 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampalouka

D25527: [activities/fileitemaction] Port plugin metadata to JSON

nicolasfella edited the summary of this revision. nicolasfella added a reviewer: Frameworks. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25527 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbamp

D25527: [activities/fileitemaction] Port plugin metadata to JSON

nicolasfella created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R320 KIO Extras BRANCH json REVISION DETAIL https://phabricator.kde.org/D25527 AFFECTED FIL

D25512: Remove unused include

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R265 KConfigWidgets BRANCH incl REVISION DETAIL

D25490: Remove legacy plugin loading code

nicolasfella updated this revision to Diff 70219. nicolasfella added a comment. - Remove REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25490?vs=70218&id=70219 BRANCH service REVISION DETAIL https://phabricator.kde.org/D25490 AFFECTED FILES CMakeLi

D25490: Remove legacy plugin loading code

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY All plugins (even ktp) use the proper system now. This allows to get rid

D25443: [chmodjob] Port away from QLinkedList

nicolasfella updated this revision to Diff 70143. nicolasfella added a comment. - Use stack REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25443?vs=70138&id=70143 BRANCH ll REVISION DETAIL https://phabricator.kde.org/D25443 AFFECTED FILES src/core/chmo

D25446: [kcoredirlister] Port away from QLinkedList

This revision was automatically updated to reflect the committed changes. Closed by commit R241:521453d71075: [kcoredirlister] Port away from QLinkedList (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25446?vs=70137&id=70142 REVISION D

D25443: [chmodjob] Port away from QLinkedList

nicolasfella marked 3 inline comments as done. nicolasfella added inline comments. INLINE COMMENTS > bruns wrote in chmodjob.cpp:115 > For efficiency, probably do a > `m_infos.reserve(m_infos.capacity() + m_lstItems.size());` > here. Does that make sense with a linked list? REPOSITORY R241 KI

D25443: [chmodjob] Port away from QLinkedList

nicolasfella updated this revision to Diff 70138. nicolasfella added a comment. - Move REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25443?vs=70114&id=70138 BRANCH ll REVISION DETAIL https://phabricator.kde.org/D25443 AFFECTED FILES src/core/chmodjob.

D25446: [kcoredirlister] Port away from QLinkedList

nicolasfella updated this revision to Diff 70137. nicolasfella added a comment. - Remove reserver REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25446?vs=70117&id=70137 BRANCH kdili REVISION DETAIL https://phabricator.kde.org/D25446 AFFECTED FILES src/

D25445: [copyjob] Port away from QLinkedList

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ddedd87456c9: [copyjob] Port away from QLinkedList (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25445?vs=70116&id=70136 REVISION DETAIL

D25446: [kcoredirlister] Port away from QLinkedList

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Use QVector instead. Not sure that's the best thing complexity-wise

D25446: [kcoredirlister] Port away from QLinkedList

nicolasfella added a task: T12087: Port away from QLinkedList. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25446 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25445: [copyjob] Port away from QLinkedList

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY QLinkedList will likely go away in Qt 6 TEST PLAN Copied files f

D25445: [copyjob] Port away from QLinkedList

nicolasfella added a task: T12087: Port away from QLinkedList. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25445 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25443: [chmodjob] Port away from QLinkedList

nicolasfella added a task: T12087: Port away from QLinkedList. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25443 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25443: [chmodjob] Port away from QLinkedList

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY QLinkedList is likely to go away in Qt 6. A comment suggests that a

D25396: Make the docs reflect that setIconName should be preferred over setPixmap when possible

This revision was automatically updated to reflect the committed changes. Closed by commit R289:ec2e765242f5: Make the docs reflect that setIconName should be preferred over setPixmap when… (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricat

D25396: Make the docs reflect that setIconName should be preferred over setPixmap when possible

nicolasfella created this revision. nicolasfella added reviewers: Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R289 KNotifications BRANCH doc REVISION DETAIL https://phabrica

D25237: Deprecated KTcpSocket and KSsl* classes

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D25237 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25223: Avoid side effects during menu initialization

nicolasfella added a comment. My long-term goal is to get rid of the application side KStatusNotifierItem and amend the QSystemTrayIcon API REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks, br

D25223: Avoid side effects during menu initialization

nicolasfella added subscribers: davidedmundson, nicolasfella. nicolasfella added a comment. In D25223#561561 , @kmaterka wrote: > Off-topic idea: This QPA integration uses KStatusNotifierItem, which then translates it to DBus. Wouldn't it be bett

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

nicolasfella accepted this revision. REPOSITORY R241 KIO BRANCH pending REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause, nicolasfella Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

nicolasfella added inline comments. INLINE COMMENTS > ksslinfodialog.h:113 > > -static QList > errorsFromString(const QString > &s); > +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 64) > +/** @deprecated since 5.64, use certificateErrorsFromString */ You missed a spot REPOSITORY R241 KIO

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

nicolasfella added inline comments. INLINE COMMENTS > ksslinfodialog.h:113 > > -static QList > errorsFromString(const QString > &s); > +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 64) > +/** @deprecated since 5.64, use certificateErrorsFromString */ Shouldn't this be 65 now? REPOSITORY

D25234: Deprecate KTcpSocket overload of KSslErrorUiData ctor

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8b206d84efb6: Deprecate KTcpSocket overload of KSslErrorUiData ctor (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25234?vs=69528&id=69529

D25234: Deprecate KTcpSocket overload of KSslErrorUiData ctor

nicolasfella edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25234 To: nicolasfella, #frameworks Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25234: [WIP] Deprecate KTcpSocket overload of KSslErrorUiData ctor

nicolasfella updated this revision to Diff 69528. nicolasfella added a comment. - Add 5.65 to deprecation versions REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25234?vs=69522&id=69528 BRANCH dpe REVISION DETAIL https://phabricator.kde.org/D25234 AFFECT

D25234: Deprecate KTcpSocket overload of KSslErrorUiData ctor

nicolasfella retitled this revision from "[WIP] Deprecate KTcpSocket overload of KSslErrorUiData ctor" to "Deprecate KTcpSocket overload of KSslErrorUiData ctor". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25234 To: nicolasfella, #frameworks Cc: vkrause, kde-framework

D25234: [WIP] Deprecate KTcpSocket overload of KSslErrorUiData ctor

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This does not build as-is, but I don't understand why REPOSITORY

D25233: [kded] Port plugin metadata to JSON

nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. nicolasfella added reviewers: Frameworks, dantti. REPOSITORY R363 Print Manager REVISION DETAIL https://phabricator.kde.org/D25233 To: nicolasfella, #frameworks, dantti Cc: kde-utils-devel

D25233: [kded] Port plugin metadata to JSON

nicolasfella added a task: T11919: Port KDED modules from .desktop files to JSON metadata. REPOSITORY R363 Print Manager REVISION DETAIL https://phabricator.kde.org/D25233 To: nicolasfella, #frameworks, dantti Cc: kde-utils-devel

D25225: Symlink microphone to audio-input-microphone on all sizes

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R267 Oxygen Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D25225 To: ltoscano, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Code looks sane to me and builds. Haven't done any testing though REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause, nicolas

D25221: Add OBS to screenrecorders

nicolasfella added inline comments. INLINE COMMENTS > com.obsproject.Studio.desktop:4 > +GenericName=Streaming/Recording Software > +GenericName[fr]=Logiciel d'enregistrement/diffusion > +Comment=Free and Open Source Streaming/Recording Software Remove the translated strings REPOSITORY R304 K

D24443: Add a plugin system

nicolasfella updated this revision to Diff 69253. nicolasfella added a comment. - Docs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=69241&id=69253 BRANCH arcpatch-D24443 REVISION DETAIL https://phabricator.kde.org/D24443 AFFECTED FILES src/CMakeLists.txt src/cal

D25122: embedd trigrams.map into shared library

nicolasfella added a comment. Thanks for the quick fix! REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24443: Add a plugin system

nicolasfella marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: dkardarakos, vkrause, dvratil, davidedmundson, dhaumann

D24443: Add a plugin system

nicolasfella updated this revision to Diff 69241. nicolasfella added a comment. - Put into namespace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=69239&id=69241 BRANCH arcpatch-D24443 REVISION DETAIL https://phabricator.kde.org/D24443 AFFECTED FILES src/CMakeLists

D24443: Add a plugin system

nicolasfella added inline comments. INLINE COMMENTS > dvratil wrote in calendarentry.h:57 > I would move `sync()` from here to be a virtual method on the plugin - > `sync(const CalendarEntry::Ptr &)`. The implementations would reimplement it > to handle sync, which feels cleaner than having to

D24443: Add a plugin system

nicolasfella updated this revision to Diff 69239. nicolasfella marked 9 inline comments as done. nicolasfella added a comment. - Drop property - Use QVector - Use unique_ptr - Make unique_ptr const - Comments - Make calendars pure virtual - ref CHANGES SINCE LAST UPDATE https://p

D25122: embedd trigrams.map into shared library

nicolasfella added a comment. This seems to break several Android builds https://binary-factory.kde.org/view/Android/job/Koko_android/36/console REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause Cc: nicolasfell

D24895: [RFC] Drop implicit size from PC buttons

nicolasfella updated this revision to Diff 68629. nicolasfella added a comment. - Actually remove REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24895?vs=68628&id=68629 BRANCH mo REVISION DETAIL https://phabricator.kde.org/D24895 A

D24895: [RFC] Drop implicit size from PC buttons

nicolasfella created this revision. nicolasfella added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It makes buttons in apps using plasma as a QQC2 style weirdly wide

D24895: [RFC] Drop implicit size from PC buttons

nicolasfella edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart Cc: kde-frameworks-devel, mart, LeGast00n, GB_2, michaelh, ngraham, bruns

D22520: Remove Growl support

This revision was automatically updated to reflect the committed changes. Closed by commit R289:e2eed147c53c: Remove Growl support (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22520?vs=61942&id=67687 REVISION DETAIL http

D24046: Allow triggering sort from QML

nicolasfella added a comment. In D24046#542147 , @jbbgameich wrote: > why not > > Q_INVOKABLE void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) override { > QSortFilterProxyModel::sort(column, order); > } >

D24443: Add a plugin system

nicolasfella edited the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma

D24443: Add a plugin system

nicolasfella added a comment. Something I'm unsure about is the usage of std::vector in public API. We never really did that, but given Qt6 is ahead we might want to consider doing it from now on REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma

D24443: Add a plugin system

nicolasfella edited the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma

D24443: Add a plugin system

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, Plasma. nicolasfella requested review of this revision. REVISION SUMMARY This allows applications/services (e.g. Akonadi, Sink, KHolidays etc) to provide calendar content to other applications/services (e.g. KOrganize

D24416: Declare Calendar::Ptr as metatype

nicolasfella closed this revision. REVISION DETAIL https://phabricator.kde.org/D24416 To: nicolasfella, #frameworks, vkrause

D24416: Declare Calendar::Ptr as metatype

nicolasfella updated this revision to Diff 67347. nicolasfella added a comment. Revert accidental change CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24416?vs=67330&id=67347 BRANCH metatype REVISION DETAIL https://phabricator.kde.org/D24416 AFFECTED FILES src/calendar.h T

<    1   2   3   4   5   6   7   8   9   >