D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

nicolasfella added a comment. > Beside that, should the header not get a deprecation attribute to ensure nobody new picks that up? yes, one step at a time :) REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D25538 To: nicolasfella, #frameworks, cullmann Cc:

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

nicolasfella updated this revision to Diff 70365. nicolasfella added a comment. - [kfinddialog] Remove usage of kregexpeditor plugin system - Remove desktop file REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25538?vs=70326&id=70365 BRANCH noplug

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

This revision was automatically updated to reflect the committed changes. Closed by commit R310:3ba71ffb3865: [kfinddialog] Remove usage of kregexpeditor plugin system (authored by nicolasfella). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25538?vs=703

D25555: deprecate kregexpeditorinterface

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R310 KTextWidgets BRANCH regexped REVISION DETAIL https://phabricator.kde.org/D2 AFFECTED FILES src/CMa

D25555: deprecate kregexpeditorinterface

nicolasfella edited the summary of this revision. nicolasfella added a reviewer: Frameworks. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D2 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25555: deprecate kregexpeditorinterface

nicolasfella added a task: T12159: KTextWidgets: Remove plugin system. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D2 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25555: deprecate kregexpeditorinterface

nicolasfella added a reviewer: cullmann. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D2 To: nicolasfella, #frameworks, cullmann Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25555: deprecate kregexpeditorinterface

This revision was automatically updated to reflect the committed changes. Closed by commit R310:1b2d198b6984: deprecate kregexpeditorinterface (authored by nicolasfella). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=70370&id=70372 REVISION DET

D25233: [kded] Port plugin metadata to JSON

This revision was automatically updated to reflect the committed changes. Closed by commit R363:0a54612c21a0: [kded] Port plugin metadata to JSON (authored by nicolasfella). REPOSITORY R363 Print Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25233?vs=69521&id=70383 REVISION

D25629: Port away from KTextWidgets

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It is only used for the bugreport dialog for non-KDE apps. By repla

D25533: Deprecate KFileWidget::toolBar

nicolasfella updated this revision to Diff 70622. nicolasfella added a comment. - Adjust version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25533?vs=70317&id=70622 BRANCH ktoolbar REVISION DETAIL https://phabricator.kde.org/D25533 AFFECTED FILES sr

D25630: Port to json metadata

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. nicolasfella requested review of this revision. REPOSITORY R150 KDE Telepathy KDE Daemon Module BRANCH json REVISION DETAIL https://phabricator.kde.org/D25630 AFFECTED FILES CMakeLists.txt ktp_integration_m

D25630: Port to json metadata

nicolasfella added a reviewer: KDE Telepathy. REPOSITORY R150 KDE Telepathy KDE Daemon Module REVISION DETAIL https://phabricator.kde.org/D25630 To: nicolasfella, #frameworks, #kde_telepathy

D25630: Port to json metadata

nicolasfella added a task: T11919: Port KDED modules from .desktop files to JSON metadata. REPOSITORY R150 KDE Telepathy KDE Daemon Module REVISION DETAIL https://phabricator.kde.org/D25630 To: nicolasfella, #frameworks

D25650: Port foreach

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds, tests pass, dolphin opens REPOSITORY R263 KXmlGui BRANCH for

D25629: Port away from KTextWidgets

This revision was automatically updated to reflect the committed changes. Closed by commit R263:13cb497277fa: Port away from KTextWidgets (authored by nicolasfella). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25629?vs=70619&id=70672 REVISION DETAIL http

D25653: [bookmarksmenu] Improve variable name

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY addAddBookmark make some sense as the method name, but as a variabl

D25654: Rename actions to be consistent

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Rename actions to all have Action suffix after D25653

D25655: Remove outdated comments

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY They come from a time before KF5 and are probably outdated since th

D25656: Remove unneeded moc include

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R294 KBookmarks BRANCH moc REVISION DETAIL http

D25657: Clean up includes

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Sort alphabetically and use CamelCase headers TEST PLAN builds

D25658: Remove superflous private

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R294 KBookmarks BRANCH pri REVISION DETAIL http

D25659: Add TODO KF6 note

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R294 KBookmarks BRANCH toto REVISION DETAIL https://phabricator.kde

D25660: Add member for editbookmarks action

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY First step towards getting rid of KActionCollection dependency. Sav

D25658: Remove superflous private

This revision was automatically updated to reflect the committed changes. Closed by commit R294:29139b7b8f66: Remove superflous private (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25658?vs=70678&id=70681 REVISION DETAIL htt

D25660: Add member for editbookmarks action

nicolasfella added a task: T12056: KBookmarks. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25650: Port foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R263:6ba0d9371f74: Port foreach (authored by nicolasfella). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25650?vs=70664&id=70682 REVISION DETAIL https://phabricator.

D25650: Port foreach

nicolasfella marked an inline comment as done. nicolasfella added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:72 > This comment looks wrong Fixed REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25650 To: nicolasfella, #frameworks, apol Cc: apol, kd

D25656: Remove unneeded moc include

This revision was automatically updated to reflect the committed changes. Closed by commit R294:1ee83cf07143: Remove unneeded moc include (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25656?vs=70676&id=70683 REVISION DETAIL h

D25657: Clean up includes

This revision was automatically updated to reflect the committed changes. Closed by commit R294:a195de5012b1: Clean up includes (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25657?vs=70677&id=70684 REVISION DETAIL https://pha

D25661: Simplify null check

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds, Dolphin's bookmark menu stil opens REPOSITORY R294 KBookmarks

D25660: Add member for editbookmarks action

nicolasfella planned changes to this revision. nicolasfella added a comment. I can do it with the rest of the patch REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngrah

D25661: Simplify null check

This revision was automatically updated to reflect the committed changes. Closed by commit R294:4b8609a04c31: Simplify null check (authored by nicolasfella). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25661?vs=70687&id=70688 REVISION DETAIL https://p

D25660: Add member for editbookmarks action

nicolasfella updated this revision to Diff 70693. nicolasfella added a comment. - Decouple from KActionCollection REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25660?vs=70680&id=70693 BRANCH addd REVISION DETAIL https://phabricator.kde.org/D25660

D25660: Decouple KBookmarksMenu from KActionCollection

nicolasfella retitled this revision from "Add member for editbookmarks action" to "Decouple KBookmarksMenu from KActionCollection". nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabri

D25660: Decouple KBookmarksMenu from KActionCollection

nicolasfella updated this revision to Diff 70694. nicolasfella added a comment. Rebase REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25660?vs=70693&id=70694 BRANCH addd REVISION DETAIL https://phabricator.kde.org/D25660 AFFECTED FILES src/kbo

D25630: Port to json metadata

nicolasfella updated this revision to Diff 70698. nicolasfella added a comment. - Use kcoreaddons_desktop_to_json REPOSITORY R150 KDE Telepathy KDE Daemon Module CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25630?vs=70623&id=70698 BRANCH json REVISION DETAIL https://phabri

D25673: Deprecate KServiceTypeProfile

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It's unused. See T12287 REPOS

D25696: Remove dead code

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This code was last touched before kdelibs was split, so it can be c

D25697: Port away from KIconLoader::SizeSmallMedium

nicolasfella added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25697 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25697: Port away from KIconLoader::SizeSmallMedium

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY There is no direct equivalent of SizeSmallMedium (22) in QStyle. Th

D25700: [KHistoryComboBox] Add method to set an icon provider

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY An icon provider can be any function that takes a QString and retur

D25700: [KHistoryComboBox] Add method to set an icon provider

nicolasfella added a task: T12310: Kill KUrlPixmapProvider. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D25700 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

nicolasfella added a task: T12310: Kill KUrlPixmapProvider. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragree

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

nicolasfella created this revision. nicolasfella added reviewers: Plasma, Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY setPixmapProvider will be deprecated with D25700

D25700: [KHistoryComboBox] Add method to set an icon provider

nicolasfella edited the summary of this revision. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D25700 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25700: [KHistoryComboBox] Add method to set an icon provider

nicolasfella updated this revision to Diff 70794. nicolasfella added a comment. - Deprecation, fix, and docs REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25700?vs=70791&id=70794 BRANCH icopro REVISION DETAIL https://phabricator.kde.org/D25700 A

D25702: Deprecate KUrlPixmapProvider

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY See T12310 for context TEST P

D25704: [kfilewidget] Load icons by name

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Skip the indirection over pixmap REPOSITORY R241 KIO BRANCH m

D25704: [kfilewidget] Load icons by name

nicolasfella updated this revision to Diff 70801. nicolasfella added a comment. - [kfilewidget] Load icons by name - Remove include REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25704?vs=70800&id=70801 BRANCH icco REVISION DETAIL https://phabricator.kd

D25704: [kfilewidget] Load icons by name

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b21a6c1a5b93: [kfilewidget] Load icons by name (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25704?vs=70801&id=70803 REVISION DETAIL htt

D25705: Deprecate KIO::pixmapForUrl

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Can easily be done otherwise. REPOSITORY R241 KIO BRANCH pfo

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN Triggered rename dialog. Still have icons in there REPOSITORY R241 KIO

D24046: Allow triggering sort from QML

nicolasfella updated this revision to Diff 70833. nicolasfella added a comment. Override and forward REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24046?vs=66370&id=70833 BRANCH fo REVISION DETAIL https://phabricator.kde.org/D24046 AFFECTED FILES

D24046: Allow triggering sort from QML

This revision was automatically updated to reflect the committed changes. Closed by commit R307:1e339edef781: Allow triggering sort from QML (authored by nicolasfella). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24046?vs=70833&id=70838 REVISION DETAIL h

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella updated this revision to Diff 70853. nicolasfella added a comment. - Fall back to application-octet-stream REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25707?vs=70806&id=70853 BRANCH rena REVISION DETAIL https://phabricator.kde.org/D25707

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. It's a bit ugly that fallback is a QIcon, not a QString :/ I will send a patch to Qt REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

nicolasfella added a comment. Well, there are certainly more ugly things out there :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

nicolasfella added a comment. Works fine for my rather simple KDE Connect use case +1 REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D25698 To: dfaure, broulik, mart, vkrause, nicolasfella Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25723: Replace KIconloader with QIcon::fromTheme

nicolasfella added reviewers: Frameworks, KDE Telepathy. REPOSITORY R152 KDE Telepathy Send File REVISION DETAIL https://phabricator.kde.org/D25723 To: nicolasfella, #frameworks, #kde_telepathy

D25723: Replace KIconloader with QIcon::fromTheme

This revision was automatically updated to reflect the committed changes. Closed by commit R152:f25a4e3e989a: Replace KIconloader with QIcon::fromTheme (authored by nicolasfella). REPOSITORY R152 KDE Telepathy Send File CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25723?vs=70863&id

D25630: Port to json metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R150:423c75cc12c3: Port to json metadata (authored by nicolasfella). REPOSITORY R150 KDE Telepathy KDE Daemon Module CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25630?vs=70698&id=70869 REVI

D25754: Refactor KHistoryComboBox::insertItems

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Use range-based for instead of iterators Apply return-early idiom

D25755: Replace iterators with range-based for

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds, kded starts REPOSITORY R297 KDED BRANCH iter REVISION DETAI

D25756: Port from QStringList::ConstIterator to range-based for

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN tests pass REPOSITORY R237 KConfig BRANCH for REVISION DETAIL htt

D25798: Deprecated allowAsDefault

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Execute upon T12309 . The KServ

D25754: Refactor KHistoryComboBox::insertItems

This revision was automatically updated to reflect the committed changes. Closed by commit R284:ecb651bb2ee6: Refactor KHistoryComboBox::insertItems (authored by nicolasfella). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25754?vs=70926&id=71054 REVISIO

D25802: Don't use obsolete qVariantFromValue

nicolasfella edited the test plan for this revision. nicolasfella added reviewers: iromanov, sitter, dfaure, Frameworks. REPOSITORY R486 QCA Library REVISION DETAIL https://phabricator.kde.org/D25802 To: nicolasfella, iromanov, sitter, dfaure, #frameworks

D24443: Add a plugin system

nicolasfella updated this revision to Diff 71066. nicolasfella added a comment. Herald added a project: KDE PIM. Herald added a subscriber: kde-pim. - Fix build - Rename description to name REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=69

D24443: Add a plugin system

nicolasfella updated this revision to Diff 71067. nicolasfella added a comment. - Use uniqe_ptr again REPOSITORY R172 KCalendar Core CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24443?vs=71066&id=71067 BRANCH arcpatch-D24443_1 REVISION DETAIL https://phabricator.kde.org/D2

D25802: Don't use obsolete qVariantFromValue

This revision was automatically updated to reflect the committed changes. Closed by commit R486:c167627675e8: Don't use obsolete qVariantFromValue (authored by nicolasfella). REPOSITORY R486 QCA Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25802?vs=71063&id=71068 REVISION

D25700: [KHistoryComboBox] Add method to set an icon provider

nicolasfella updated this revision to Diff 71070. nicolasfella added a comment. - Deprecation, fix, and docs REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25700?vs=70794&id=71070 BRANCH icopro REVISION DETAIL https://phabricator.kde.org/D25700 A

D25700: [KHistoryComboBox] Add method to set an icon provider

nicolasfella updated this revision to Diff 71071. nicolasfella added a comment. - Adapt deprecation version REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25700?vs=71070&id=71071 BRANCH icopro REVISION DETAIL https://phabricator.kde.org/D25700 AF

D25700: [KHistoryComboBox] Add method to set an icon provider

nicolasfella updated this revision to Diff 71072. nicolasfella added a comment. - For real REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25700?vs=71071&id=71072 BRANCH icopro REVISION DETAIL https://phabricator.kde.org/D25700 AFFECTED FILES sr

D25700: [KHistoryComboBox] Add method to set an icon provider

nicolasfella added a reviewer: dfaure. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D25700 To: nicolasfella, #frameworks, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25809: Use standard ECMQMLModules

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D25809 To: asturmlechner, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25700: [KHistoryComboBox] Add method to set an icon provider

nicolasfella updated this revision to Diff 71098. nicolasfella marked 3 inline comments as done. nicolasfella added a comment. - Comments REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25700?vs=71072&id=71098 BRANCH icopro REVISION DETAIL https://

D25700: [KHistoryComboBox] Add method to set an icon provider

This revision was automatically updated to reflect the committed changes. Closed by commit R284:9fe2d187f8e9: [KHistoryComboBox] Add method to set an icon provider (authored by nicolasfella). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25700?vs=71098&id

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

nicolasfella added a comment. Can Plasma depend on Frameworks master or does this have to wait until 5.66 release? REPOSITORY R135 Integration for Qt applications in Plasma BRANCH prov REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks, apol Cc:

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

This revision was automatically updated to reflect the committed changes. Closed by commit R135:a5bdd39f9355: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox (authored by nicolasfella). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D25997: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kfileplacesmodel REVISION DETAIL https://phabricator.kde.org/D25997 To: chehrlic, dfaure, nicolasfella, ngraham, #dolphin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, n

D26006: Deprecate KPixmapProvider

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY It has no known non-deprecated users and can easily be replaced by

D26006: Deprecate KPixmapProvider

nicolasfella added a task: T12310: Kill KUrlPixmapProvider and KPixmapProvider. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D26006 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25533: Deprecate KFileWidget::toolBar

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6973d4b26501: Deprecate KFileWidget::toolBar (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25533?vs=70622&id=71631#toc REPOSITORY R241 KIO CHANGES SINCE LAST UP

D26034: Replace KLocalSocket with QLocalSocket

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY As described in T12010 . A

D26034: Replace KLocalSocket with QLocalSocket

nicolasfella edited the summary of this revision. nicolasfella added subscribers: vonreth, cullmann. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26034 To: nicolasfella, #frameworks Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26034: Replace KLocalSocket with QLocalSocket

nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26034 To: nicolasfella, #frameworks, dfaure Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26006: Deprecate KPixmapProvider

nicolasfella added a reviewer: dfaure. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D26006 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26167: Update holidays and add flagdays and namedays for Sweden

nicolasfella added reviewers: KDE PIM, winterz. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D26167 To: riiga, #kde_pim, winterz Cc: ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26198: Deprecate KCModuleContainer

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Part of T12153 . There are

D26198: Deprecate KCModuleContainer

This revision was automatically updated to reflect the committed changes. Closed by commit R295:34686047d57c: Deprecate KCModuleContainer (authored by nicolasfella). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26198?vs=72121&id=72410 REVISION DETAIL htt

D25696: Remove dead code

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:6281990dd4e9: Remove dead code (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://p

D25705: Deprecate KIO::pixmapForUrl

nicolasfella added a comment. In D25705#571458 , @apol wrote: > What do you mean by `Can easily be done otherwise.`? You can get an icon name for the icon with KIO::iconNameForUrl and then use QIcon API if you really need a pixmap REPOSI

D25705: Deprecate KIO::pixmapForUrl

nicolasfella updated this revision to Diff 72413. nicolasfella added a comment. - Fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=70804&id=72413 BRANCH arcpatch-D25705 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES src/wi

D25702: Deprecate KUrlPixmapProvider

nicolasfella updated this revision to Diff 72414. nicolasfella added a comment. - Update version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25702?vs=70795&id=72414 BRANCH arcpatch-D25702 REVISION DETAIL https://phabricator.kde.org/D25702 AFFECTED FIL

D26006: Deprecate KPixmapProvider

nicolasfella added a comment. Done in D25702 REPOSITORY R284 KCompletion BRANCH pmp REVISION DETAIL https://phabricator.kde.org/D26006 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25702: Deprecate KUrlPixmapProvider

nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25702 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25702: Deprecate KUrlPixmapProvider

nicolasfella updated this revision to Diff 72537. nicolasfella added a comment. - fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25702?vs=72414&id=72537 BRANCH arcpatch-D25702_1 REVISION DETAIL https://phabricator.kde.org/D25702 AFFECTED FILES src/

D25702: Deprecate KUrlPixmapProvider

nicolasfella marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25702 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25702: Deprecate KUrlPixmapProvider

This revision was automatically updated to reflect the committed changes. Closed by commit R241:00e8034f0e9a: Deprecate KUrlPixmapProvider (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25702?vs=72537&id=72553 REVISION DETAIL https:/

<    2   3   4   5   6   7   8   9   >