D19629: Change media-skip* and media-seek* style

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19629 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19629: Change media-skip* and media-seek* style

This revision was automatically updated to reflect the committed changes. Closed by commit R266:581ce275edbd: Change media-skip* and media-seek* style (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19629?vs=53494&id=53510 REVISION D

D19633: Improve consistency of window-* and add more

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add window-keep-above/below Add window-maximize/maximized/minimize Change window-p

D19633: Improve consistency of window-* and add more

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19633: Improve consistency of window-* and add more

ndavis updated this revision to Diff 53516. ndavis edited the test plan for this revision. ndavis added a comment. Rename window-maximized to window-restore for better 3rd party compatibility REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19633?vs=5351

D19633: Improve consistency of window-* and add more

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Could you align the top of the down arrow in expand-all to the pixel grid and move it down by 1px? Like so: F6677924: Screenshot_20190309_114706.png

D19575: Add collapse-all and expand-all action icons

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19638: Make go-bottom/first/last/top look more like media-skip*

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Once D19575 lands, the style of `go-top` will conflict

D19638: Make go-bottom/first/last/top look more like media-skip*

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19638 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19633: Improve consistency of window-* and add more

ndavis added a comment. In D19633#427913 , @ngraham wrote: > Neat! Very helpful, thanks. > > While you're at it, do you think you could add a `window-unpin` icon too? https://bugs.kde.org/show_bug.cgi?id=405195 Yes, but I'm not sure i

D19639: Change go-up/down-search symlinks target to go-up/down

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY go-up/down is more appropriate because go-top/bottom is supposed to be for skipping to the

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY These icons had subtle alignment issues. They weren't even always visible, but it's a probl

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19641 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19639: Change go-up/down-search symlinks target to go-up/down

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19639 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19638: Make go-bottom/first/last/top look more like media-skip*

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19638 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

ndavis updated this revision to Diff 53558. ndavis edited the test plan for this revision. ndavis added a comment. Rebase on master REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19641?vs=53533&id=53558 BRANCH go-icons (branched from master) REVISI

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

This revision was automatically updated to reflect the committed changes. Closed by commit R266:612a0134603d: Improve pixel grid alignment of go-up/down/next/previous/jump (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19641?vs=53558

D19639: Change go-up/down-search symlinks target to go-up/down

ndavis updated this revision to Diff 53560. ndavis added a comment. Rebase on master REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19639?vs=53531&id=53560 BRANCH go-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19639

D19639: Change go-up/down-search symlinks target to go-up/down

This revision was automatically updated to reflect the committed changes. Closed by commit R266:f2509047d437: Change go-up/down-search symlinks target to go-up/down (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19639?vs=53560&id=535

D19638: Make go-bottom/first/last/top look more like media-skip*

ndavis updated this revision to Diff 53563. ndavis added a comment. Rebase on master REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19638?vs=53530&id=53563 BRANCH go-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19638

D19638: Make go-bottom/first/last/top look more like media-skip*

This revision was automatically updated to reflect the committed changes. Closed by commit R266:24067c74c2d6: Make go-bottom/first/last/top look more like media-skip* (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19638?vs=53563&id=5

D19633: Improve consistency of window-* and add more

ndavis updated this revision to Diff 53569. ndavis added a comment. - Add window-unpin REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19633?vs=53516&id=53569 BRANCH window-states (branched from master) REVISION DETAIL https://phabricator.kde.org/

D19633: Improve consistency of window-* and add more

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

ndavis updated this revision to Diff 53571. ndavis added a comment. - Add window-unpin-symbolic REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19633?vs=53569&id=53571 BRANCH window-states (branched from master) REVISION DETAIL https://phabricator

D19633: Improve consistency of window-* and add more

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

ndavis added a comment. window-shade can be added in a later patch so that this one isn't unnecessarily held back REPOSITORY R266 Breeze Icons BRANCH window-states (branched from master) REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg, ngraham Cc: ngraham, kde-fra

D19633: Improve consistency of window-* and add more

This revision was automatically updated to reflect the committed changes. Closed by commit R266:3bc4079c220e: Improve consistency of window-* and add more (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19633?vs=53571&id=53607 REVISI

D19575: Add collapse-all and expand-all action icons

ndavis added a comment. @trickyricky26 do you mind if I commandeer this so I can get it finished today? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

ndavis commandeered this revision. ndavis edited reviewers, added: trickyricky26; removed: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: ndavis, #vdg, ngraham, trickyricky26 Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

ndavis updated this revision to Diff 53744. ndavis added a comment. Lower down arrow on expand-all REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53522&id=53744 BRANCH arcpatch-D19575 REVISION DETAIL https://phabricator.kde.org/D19575 A

D19575: Add collapse-all and expand-all action icons

ndavis updated this revision to Diff 53746. ndavis added a comment. - Add window-shade/unshade REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53744&id=53746 BRANCH arcpatch-D19575 REVISION DETAIL https://phabricator.kde.org/D19575 AFFEC

D19575: Add collapse/expand-all, window-shade/unshade

ndavis retitled this revision from "Add collapse-all and expand-all action icons" to "Add collapse/expand-all, window-shade/unshade". ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: ndavis, #vdg, ngraham, tri

D19575: Add collapse/expand-all, window-shade/unshade

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b128afbbfe62: Add collapse/expand-all, window-shade/unshade (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53746&id=53751 REVIS

D17469: applications-games icon for dark theme

ndavis added a comment. @guoyunhe Do you mind if I commandeer this? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: guoyunhe, #breeze, #vdg, ndavis Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: applications-games icon for dark theme

ndavis commandeered this revision. ndavis edited reviewers, added: guoyunhe; removed: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19736: Add screen-rotate-auto-on/off

ndavis created this revision. ndavis added reviewers: VDG, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Screen auto rotate icons for D19690 REPOSITORY

D19736: Add screen-rotate-auto-on/off

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

ndavis updated this revision to Diff 53826. ndavis edited the test plan for this revision. ndavis added a comment. - Increase spacing between outside rotation marks and screen REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19736?vs=53825&id=53826 BRAN

D19736: Add screen-rotate-auto-on/off

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

ndavis added a comment. I don't think the light/dark window background looks good. It also gives the wrong message because the Colors KCM is what controls the Window background. The Window Decoration KCM icon has the same issue, but that already exists. Perhaps you should put buttons or slid

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

ndavis added a comment. BTW, when you change an icon into a symlink or vice versa, can you delete the icon you're changing in a separate commit and then add the new version of the icon? `arc patch` doesn't work when a file has been changed from or to a symlink. REPOSITORY R266 Breeze Icon

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

ndavis added a comment. We did agree to have Qt and GTK settings separate in T8871 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D17469: applications-games icon for dark theme

ndavis updated this revision to Diff 53836. ndavis added a comment. Change style for Breeze and Breeze Dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17469?vs=47254&id=53836 BRANCH arcpatch-D17469 (branched from master) REVISION DETAIL https

D17469: applications-games icon for dark theme

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

ndavis retitled this revision from "applications-games icon for dark theme" to "Give applications-games more contrast with Breeze Dark". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe Cc: abetts, ngraham, pstefan, ndavis,

D19736: Add screen-rotate-auto-on/off

ndavis added a comment. In D19736#430545 , @ngraham wrote: > Hmm, TBH it feels too busy for me, especially at the smaller sizes. I wonder if it might benefit from using a single circular line with an arrowhead instead, like this comically crude

D17469: Give applications-games more contrast with Breeze Dark

ndavis updated this revision to Diff 53839. ndavis added a comment. Darken the handle grips REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17469?vs=53836&id=53839 BRANCH arcpatch-D17469 (branched from master) REVISION DETAIL https://phabricator.k

D17469: Give applications-games more contrast with Breeze Dark

ndavis added a comment. In D17469#430573 , @ngraham wrote: > Better, but the dark parts of the dark version still disappear against a dark background. Most of the time we solve this with a transparent outline (we did this for the clock icon rece

D17469: Give applications-games more contrast with Breeze Dark

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

ndavis added a comment. In D17469#430616 , @ngraham wrote: > No room? Instead of widening the grips by one pixel to make room for the contrast border, how about building it in, effectively narrowing the grips by one pixel? That's what I

D17469: Give applications-games more contrast with Breeze Dark

ndavis added a comment. In D17469#430647 , @ngraham wrote: > Hmm, I see what you mean. Okay, let's go with this one! > > BTW, the duplicate test fails as of f2509047d4372f1a59d8f8b5ff009146f1a6adcb

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

ndavis added a comment. I think `preferences-desktop-theme-applications` is fine, but `preferences-desktop-theme-windowdecorations` looks odd with that border. F6691545: Screenshot_20190314_135511.png REVISION DETAIL https://phabricator.kde.org/D19733

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

ndavis added a comment. In D19733#431237 , @GB_2 wrote: > In D19733#431139 , @ndavis wrote: > > > I think `preferences-desktop-theme-applications` is fine, but `preferences-desktop-theme-windowdecora

D17469: Give applications-games more contrast with Breeze Dark

ndavis updated this revision to Diff 53925. ndavis added a comment. Update input-gaming and make circle around dpad and colored buttons darker REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17469?vs=53839&id=53925 BRANCH arcpatch-D17469 (branched fr

D17469: Give applications-games more contrast with Breeze Dark

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D17469 (branched from master) REVISION DETAIL https://phabricator.kde.org/D17469 To: ndavis, #breeze, #vdg, guoyunhe, ngraham Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, b

D17469: Give applications-games and input-gaming more contrast with Breeze Dark

ndavis retitled this revision from "Give applications-games more contrast with Breeze Dark" to "Give applications-games and input-gaming more contrast with Breeze Dark". REPOSITORY R266 Breeze Icons BRANCH arcpatch-D17469 (branched from master) REVISION DETAIL https://phabricator.kde.org

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D19733 REVISION DETAIL https://phabricator.kde.org/D19733 To: GB_2, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D17469: Give applications-games and input-gaming more contrast with Breeze Dark

This revision was automatically updated to reflect the committed changes. Closed by commit R266:559782c5f5b4: Give applications-games and input-gaming more contrast with Breeze Dark (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1746

D19812: Add a web page to view and compare icons of different sizes

ndavis added a comment. Could you use `#eff0f1` and `#31363b` for the light and dark backgrounds since those are the colors we normally use for window backgrounds? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breez

D19812: Add a web page to view and compare icons of different sizes

ndavis added a comment. In D19812#433941 , @guoyunhe wrote: > In D19812#433916 , @ndavis wrote: > > > Could you use `#eff0f1` and `#31363b` for the light and dark backgrounds since those are the colo

D19736: Add screen-rotate-auto-on/off

ndavis added a comment. @ngraham Here's something similar to what you asked for: F6701127: Screenshot_20190318_235338.png This is 22px. I couldn't get it to work for 16px. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org

D19736: Add screen-rotate-auto-on/off

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19736 To: ndavis, #vdg, apol Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19736: Add screen-rotate-auto-on/off

ndavis added a comment. This is what the current 32px version with arrowheads added looks like, but it can't be done like that with 16px or 22px. F6701152: montage.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D1973

D19736: Add screen-rotate-auto-on/off

ndavis added a comment. In D19736#434616 , @apol wrote: > How about having 3 icons? autorotate, locked portrait and locked landscape? > > This way we don't need to have a weird red strike-through. That's what I asked about the first ti

D19736: Add screen-rotate-auto-on/off

ndavis added a comment. In D19736#434274 , @ngraham wrote: > Maybe the rectangle itself doesn't need to be so big? Or maybe it could be even bigger and have the arrows inside? I can make the rectangle slightly smaller. I can't make the re

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: arvidhansson, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. That "1" is too blurry. Did you use the font tool or did you draw it with the pen or rectangle tools? Since this is "numlock" Wouldn't it make more sense to put a "1" inside of a lock? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a reviewer: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: arvidhansson, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. You need to make the icons on 16x16px and 22x22px canvases. If you use a grid with 1 line every pixel, it will be easier to make icons look sharp. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: arvidhansson, #vdg, ndavis Cc: n

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#436425 , @taskf wrote: > Hi, I created some icons a week ago, just didn't post them as @arvidhansson was already on the task. > > They are not polished as you can see from the screenshot. The left version sy

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. Here's my attempt: F6711669: montage-breeze-Background.png F6711673: input-numlock-on.16.svg F6711674: input-numlock-on.22.svg REPOSITORY R2

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#436853 , @arvidhansson wrote: > In D19952#436834 , @taskf wrote: > > > There is one issue I'm not sure about. The user might feel pressured to check something if th

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#437670 , @arvidhansson wrote: > In D19952#437419 , @ndavis wrote: > > > This can be done in the system tray widget instead of making a separate icon for off. Ever n

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#438130 , @arvidhansson wrote: > In D19952#437726 , @ndavis wrote: > > > In D19952#437670 , @arvidhansson wrote: > > >

D12327: Show Detailed Tree View by default

ndavis added a comment. +1 Navigation is so much faster in tree view. I think navigation speed is what matters most of the time when people are selecting files or locations. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham, #frameworks, #vdg, apol

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. The rounded corners and bold 1 are not very breeze like, so I don't think so, unless he changes his design. Unless you still plan to do the icon yourself, you should probably hand off responsibility for the patch to someone else. REPOSITORY R266 Breeze Icons REVISI

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#439031 , @arvidhansson wrote: > In D19952#438965 , @ndavis wrote: > > > The rounded corners and bold 1 are not very breeze like, so I don't think so, unless he chan

D20063: Sublime Merge Icon.

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. This is very nice. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-dev

D20063: Sublime Merge Icon.

ndavis added a comment. In D20063#439465 , @ngraham wrote: > I don't that version is actually in the patch though. @otavva can you update this patch to have that version of the icon? Then we can get it landed for you. No, it's there, but

D20063: Sublime Merge Icon.

ndavis added a comment. Oh wait no, it's not there yet, but it still looks pretty good. However, I did notice this on a closer inspection of the shapes: F6726111: Screenshot_20190327_182820.png @otavva, could you make the top shape more like h

D20063: Sublime Merge Icon.

ndavis accepted this revision. ndavis added a comment. @otavva I need your email and real name to land your patch with the correct author. If you use the Arcanist tool for patches in the future, you will need to make sure that your real name is set as your Git user name. REPOSITORY R266 Br

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis created this revision. ndavis added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY There was a small gap in the corners of the thumbnailArea highlight rectangle that w

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20140 To: ndavis, #plasma, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis updated this revision to Diff 55106. ndavis added a comment. - Remove radius from thumbnailArea highlight REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20140?vs=55105&id=55106 BRANCH grid-delegate-rectangle (branched from master) REVISION D

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20140 To: ndavis, #plasma, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis added a comment. In D20140#440989 , @ngraham wrote: > It's probably going to be more noticeable for High DPI users. It seems like there must be a way to fix this rather than just removing the thumbnail radius. I could remove the ra

D20063: Sublime Merge Icon.

This revision was automatically updated to reflect the committed changes. Closed by commit R266:69d7182daffc: Sublime Merge Icon. (authored by otavva, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20063?vs=54981&id=55140 REVISION D

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis added a comment. Here is how no radius for the thumbnailArea and thumbnail highlight looks: F6739553: Screenshot_20190331_131729.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20140 To: ndavis, #plasma, #vdg Cc

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis added a comment. Another alternative would be to turn the thumbnail outline into a real outline instead of a rounded rectangle behind the thumbnailArea. Then it could go on top of the thumbnailArea and the thumbnail highlight could fit perfectly inside of it. This would give previews

D20147: Improve executable dialog buttons' icons

ndavis accepted this revision. ndavis added a comment. Yes, this is much better. Wow, that `application-x-executable` icon is really blurry. REPOSITORY R241 KIO BRANCH improve-execute-dialog-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D20147 To: ngraham,

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

ndavis added a comment. Be careful that you are not stripping stylesheets when you use SVG Cleaner. `scour` is less effective than SVG Cleaner, but it doesn't strip stylesheets and it's available in more distros. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabric

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

ndavis added a comment. In D20166#441807 , @ngraham wrote: > Strictly speaking, there's no need to optimize the SVGs as a part of this, so maybe, yeah, let's split that out into a separate feature (and one that the Breeze Icons repo would ultima

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

ndavis added a comment. In D20166#441863 , @kossebau wrote: > IMHO the SVG files in the repo may contain comments and metadatas, for further work on them. Like source code also has all the oomments and metadata. > Only the deployed graphics re

D20226: Add "notifications" and "notifications-disabled" icons

ndavis added a comment. The proportions aren't quite right. F6749114: Screenshot_20190403_112343.png This is one way to make a perfectly smooth bell. Subtract the red shapes from the black shapes. F6749117: Screenshot_20190403_112550.png

D20226: Add "notifications" and "notifications-disabled" icons

ndavis added a comment. In D20226#442906 , @GB_2 wrote: > In D20226#442882 , @ngraham wrote: > > > Also, could we create a 22x22 version too? > > > How can you efficiently do that without havin

D20226: Add "notifications" and "notifications-disabled" icons

ndavis added a comment. In D20226#442934 , @bruns wrote: > Diagonal or round shapes are **not** required to be pixel grid aligned. Actually, it is not even possible, as there is **always** some antialiasing. It even helps to make round shapes a

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis commandeered this revision. ndavis edited reviewers, added: arvidhansson; removed: ndavis. ndavis added a comment. Alright. I'll finish it when I have time. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: ndavis, #vdg, arvidhansson Cc: ngraham,

<    1   2   3   4   5   6   7   8   9   10   >