D15240: Create a default wallet when user refuses to do so

2018-09-05 Thread Oleg Solovyov
McPain added a comment.


  In D15240#320542 , @ngraham wrote:
  
  > Stuff that doesn't work with KWallet should be fixed. But the point would 
be moot if we create a default wallet in a more user-friendly manner...
  
  
  I never told that there are stuff that doesn't work with KWallet
  I'm saying about stuff that doesn't work _without_ KWallet :)

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15240

To: McPain, #frameworks, ngraham
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns


D15240: Create a default wallet when user refuses to do so

2018-09-05 Thread Oleg Solovyov
McPain added a comment.


  In D15240#320542 , @ngraham wrote:
  
  > I would favor automatically creating a default wallet with the user's 
current password using a "good enough" cipher that we can hopefully all agree 
on. This would probably require changes to user-manager, or whatever it is that 
receives the string used for a new account's password. At the moment when a new 
user account is created, it would not only create the new user account, but it 
would also create a wallet using the same password.
  
  
  What if we create a user in AD? (Active Directory or something similar, not 
local user)

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15240

To: McPain, #frameworks, ngraham
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns


D11055: Pack python bindings into right dirs

2018-09-11 Thread Oleg Solovyov
McPain abandoned this revision.
Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel; 
removed: Frameworks, Build System.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11055

To: McPain, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, arojas, apol, michaelh, ngraham, 
bruns, #frameworks, #build_system


D11055: Pack python bindings into right dirs

2018-03-05 Thread Oleg Solovyov
McPain created this revision.
McPain added a reviewer: vkrause.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
McPain requested review of this revision.

REVISION SUMMARY
  1. Python modules are packed into /usr/lib/ for both x86 and x86_64 
architectures
  
  Should be:
  /usr/lib/ for x86
  /usr/lib64/ for x86_63
  
  2. sip modules are packed into /usr/share/sip for both python2 and python3
  
  Should be:
  /usr/share/sip/ for python2
  /usr/share/sip3/ for python3

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D11055

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: McPain, vkrause
Cc: #frameworks, #build_system, michaelh


D15240: Create a default wallet when user refuses to do so

2018-09-03 Thread Oleg Solovyov
McPain added a reviewer: Frameworks.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15240

To: McPain, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15240: Create a default wallet when user refuses to do so

2018-09-03 Thread Oleg Solovyov
McPain created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
McPain requested review of this revision.

REVISION SUMMARY
  This patch allows creating a default wallet with empty password when user 
explicitly refuses to create one (tons of KWallet dialogs looks annoying)
  
  Also, KWallet will notify user once the wallet was created.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15240

AFFECTED FILES
  src/runtime/kwalletd/kwalletd.cpp

To: McPain
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15240: Create a default wallet when user refuses to do so

2018-09-04 Thread Oleg Solovyov
McPain added a comment.


  In D15240#319850 , @ngraham wrote:
  
  > This strikes me as likely to cause intense frustration. Consider the 
following dramatized dialogue between a user and the computer:
  >
  > User: "Neat, I just set up this KDE plasma thing. Let's start seeing what 
cool stuff it can do!"
  >  Computer: "Hey hey hey first what kind of KWallet do you want to create? 
Technical jargon thingy 1, or technical jargon thingy 2? Huh? Huh? What'll it 
be O noble user!?"
  >  User: "Okay, I have no idea, let me cancel out of this stupid thing..."
  >  Computer: "Don't worry I created a thing anyway and chose technical jargon 
thingy 1 for you!"
  >
  > Speaking personally, this sort of experience would make me want to put my 
fist through the screen.
  >
  > It might be worth stepping back and asking more higher-level questions like:
  >  "Why are users cancelling the wizard? Is it too technically intimidating?"
  >  "Should we even have a wizard at all? Maybe should we create a wallet 
automatically by default and let advanced users change its settings or delete 
it if they don't like it?"
  
  
  What could you say about stuff that doesn't work without wallet but stubborn 
user always _refuses_ to create one?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D15240

To: McPain, #frameworks, ngraham
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns


D28669: make CopyJob non-recursive

2020-04-07 Thread Oleg Solovyov
McPain created this revision.
McPain added a reviewer: kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
McPain requested review of this revision.

REVISION SUMMARY
  Break recursive loop causing Dolphin to crash when linking 2 objects from 
one directory to another.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28669

AFFECTED FILES
  src/core/copyjob.cpp

To: McPain, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns