Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac : isShiftAsModifierAllowed() involved.

2017-01-08 Thread René J . V . Bertin
On Sunday January 8 2017 11:48:08 Kevin Funk wrote: >Nope, sorry, never tried. Could you try with a current build when you have a moment, please? >I'm happy to receive any patches that improve shortcut handling in KDevelop on >Mac. Sure, but I think that in principle that should rather be

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac : isShiftAsModifierAllowed() involved.

2017-01-07 Thread René J . V . Bertin
On Saturday January 07 2017 13:32:22 René J.V. Bertin wrote: > After saving the shortcuts to the current scheme and restarting the app: > - the shortcut is shown as Command+< > - it no longer works In fact, that was testing in KDevelop, which has a hardcoded Ctrl+< shortcut for the (popup

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac : isShiftAsModifierAllowed() involved.

2017-01-07 Thread René J . V . Bertin
Looking over the kxmlgui code I notice isShiftAsModifierAllowed(), from KWindowSystem. Have there been recent changes in that function or its use in other places Applying the patch below has the following effect: - Command+Shift+, (Command+<) is shown as Command+Shift+, in the shortcut editor

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-07 Thread René J . V . Bertin
On Saturday January 7 2017 19:33:13 Albert Astals Cid wrote: >You're a developer, you can reproduce the problem in one version and not in >another, instead of workarounding the problem you should bisect it until you >find where it broke. Sure, that's what I'd have done with my own code, and

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-06 Thread René J . V . Bertin
On Friday January 06 2017 18:33:01 David Faure wrote: > Well, you didn't say either way, so I tried to guess from your description, > and guessed wrong. No problem, can't be right all the time (and it's Friday night at that) ;) > > the shortcut shows up correctly (Command-<) but doesn't work.

Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-05 Thread René J . V . Bertin
Hi, I'm noticing a different in the handling of Command+Shift shortcuts on Mac, after upgrading to Qt 5.7.1 Pre-existing shortcuts like Command+Shift+, for Command-< continue to show up as Command-< (<) but they no longer function. When I try to re-record them, the Shift modifier is dropped

Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129733/#review101744 --- Ship it! Ship It! - René J.V. Bertin On Jan. 2, 2017,

Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread René J . V . Bertin
> On Jan. 2, 2017, 9:29 p.m., René J.V. Bertin wrote: > > Ship It! Oops, I was too fast. David, on a whim I just tried ``` sudo ln -s ../../.. /opt/local/share/applications/kde4/testlink ``` which is the exact same kind of tarpit situation that got me the other day. Your patch doesn't

Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129733/#review101740 --- Ship it! Ship It! - René J.V. Bertin On Dec. 31,

Re: Mac: kbuildsycoca5 and kded5 deadloop *somewhere* after upgrading to Qt 5.7.1

2016-12-31 Thread René J . V . Bertin
On Saturday December 31 2016 14:10:38 David Faure wrote: >OK that recursion is fixed in https://git.reviewboard.kde.org/r/129733/ > >Can you check if you still hit an issue? Sure ... next year ;) I do wonder, won't there be unwanted/unforeseen side-effects from skipping symlinks to directories?

Review Request 129730: [WIP] : kbuildsyscoca should skip /Applications on Mac

2016-12-30 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129730/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Review Request 129729: [OS X] : don't risk deleting /Applications (!)

2016-12-30 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129729/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Re: Mac: kbuildsycoca5 and kded5 deadloop *somewhere* after upgrading to Qt 5.7.1

2016-12-30 Thread René J . V . Bertin
For the sake of completeness, here are the QSP locations returned (with "XDG-compliant" writable locations), for 5.6.2 and 5.7.1 . R. DesktopLocation: "Desktop" = */Users/bertin/Desktop* DocumentsLocation: "Documents" = */Users/bertin/Documents* FontsLocation: "Fonts" =

Re: Mac: kbuildsycoca5 and kded5 deadloop *somewhere* after upgrading to Qt 5.7.1

2016-12-30 Thread René J . V . Bertin
On Friday December 30 2016 18:49:46 David Faure wrote: > > Edit: it doesn't. > > What's it and what is it that it doesn't? Sorry, yes. > Can you reproduce the problem on Linux or not? No. kbuildsycoca5 finishes without issues there. It may run a bit slower but that could just as well be my

Re: Mac: kbuildsycoca5 and kded5 deadloop *somewhere* after upgrading to Qt 5.7.1

2016-12-30 Thread René J . V . Bertin
On Friday December 30 2016 18:08:11 René J.V. Bertin wrote: > My analoguous Linux build isn't finished yet so I cannot say whether this is > Mac-specific or something that may have to do with the way I install things. Edit: it doesn't. And FWIW, I did rebuild KService and KDEd against the new

Mac: kbuildsycoca5 and kded5 deadloop *somewhere* after upgrading to Qt 5.7.1

2016-12-30 Thread René J . V . Bertin
Hi, I am in the process of upgrading to Qt 5.7.1 . While porting my Qt5 patches and building was largely a no-brainer and most applications seem to work without issues, there are (at least) 2 annoying exceptions among basic KF5 apps: - kded5 deadloops somewhere - kbuildsysoca5 idem. In

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations

2016-12-27 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 27, 2016, 5:40 p.m.) Review request for KDE Software on

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations

2016-12-27 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 27, 2016, 5:31 p.m.) Review request for KDE Software on

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

2016-12-27 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/ --- (Updated Dec. 27, 2016, 5 p.m.) Review request for KDE Software on Mac

Re: Review Request 126086: [OS X] backend ported from KDE4

2016-12-20 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126086/ --- (Updated Dec. 20, 2016, 3:28 p.m.) Review request for KDE Software on

Review Request 129661: optional CHM generation

2016-12-16 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129661/ --- Review request for KDE Frameworks and Olivier Churlaud. Bugs: 373723

Re: Review Request 127635: use QSettings::IniFormat

2016-12-11 Thread René J . V . Bertin
> On April 17, 2016, 12:49 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > Just briefly looking around at what's using Sonnet, at least Calligra and > > Quassel uses it on Windows, so I'd really like to migrate the settings on > > Windows. > > Martin Tobias Holmedahl Sandsmark wrote: >

Re: Review Request 127635: use QSettings::IniFormat

2016-11-20 Thread René J . V . Bertin
> On April 17, 2016, 12:49 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > Just briefly looking around at what's using Sonnet, at least Calligra and > > Quassel uses it on Windows, so I'd really like to migrate the settings on > > Windows. > > Martin Tobias Holmedahl Sandsmark wrote: >

Review Request 129513: use QSettings::IniFormat everywhere

2016-11-20 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129513/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Laurent

Re: Review Request 127635: use QSettings::IniFormat

2016-11-20 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127635/ --- (Updated Nov. 20, 2016, 8:44 p.m.) Review request for KDE Frameworks and

Re: kapidox and non-frameworks source

2016-11-18 Thread René J . V . Bertin
On Friday November 18 2016 11:19:41 Olivier Churlaud wrote: Hi, I don't think there's anything personal in your reply so I'm keeping it on the ML, for general reference. > Could you be more specific? > - What are you running it on? > - Did you add a metainfo.yaml? A README.md or a

kapidox and non-frameworks source

2016-11-18 Thread René J . V . Bertin
Hi, I've been having issues generating API docs with KApiDox v. 5.24.0 and later, at least for projects that aren't KF5 frameworks. The online documentation of the framework itself (https://api.kde.org/frameworks/kapidox/html/index.html) suggests that this shouldn't matter, but with version

Re: Review Request 129267: [OS X] emulate posix_fallocate()

2016-10-28 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129267/ --- (Updated Oct. 28, 2016, 10:03 p.m.) Status -- This change has been

Re: Review Request 129267: [OS X] emulate posix_fallocate()

2016-10-28 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129267/ --- (Updated Oct. 28, 2016, 10:01 p.m.) Review request for KDE Software on

Re: Review Request 129267: [OS X] emulate posix_fallocate()

2016-10-27 Thread René J . V . Bertin
> On Oct. 27, 2016, 3:55 a.m., Michael Pyne wrote: > > src/lib/caching/posix_fallocate_mac.h, line 97 > > > > > > Given that the user has some input into the size of the cache I'd > > prefer to have some kind of

Review Request 129267: [OS X] emulate posix_fallocate()

2016-10-26 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129267/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-10-20 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/ --- (Updated Oct. 20, 2016, 12:05 p.m.) Status -- This change has been

Re: Fwd: KStandardAction::showMenubar and native menubars

2016-10-11 Thread René J . V . Bertin
On Wednesday October 12 2016 01:12:14 Marko Käning wrote: > > From: Albert Astals Cid > > My current (yet to implement/test) idea is have > > KStandardAction::showMenubar check all the menubars of the top level > > windows of the app and if they are all marked as native, then

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

2016-10-11 Thread René J . V . Bertin
> On Feb. 25, 2016, 8:26 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, lines 465-467 > > > > > > I would prefer to not introduce new platform specific code in the > > shared part. > > > > The

Re: Review Request 127822: address the potential name/case clash of the Attica/Attica and Attica/attica header dirs

2016-09-30 Thread René J . V . Bertin
> On May 11, 2016, 4:05 p.m., René J.V. Bertin wrote: > > src/CMakeLists.txt, lines 160-163 > > > > > > This change is problematic, and apparently needs to be > > platform-specific (if done here): > > > >

Re: Review Request 127822: address the potential name/case clash of the Attica/Attica and Attica/attica header dirs

2016-09-30 Thread René J . V . Bertin
> On May 3, 2016, 2:42 p.m., Aleix Pol Gonzalez wrote: > > Is this specific to Attica or it will happen on other frameworks? I have a > > memory of having such an issue worked on at some point. > > René J.V. Bertin wrote: > Hah... > > The principal applies universally of course,

sleeper design bug in the installation layout due to assumptions about filesystem case sensitivity

2016-09-30 Thread René J . V . Bertin
Hello, I think I've tried to raise some awareness about this already in the past. The issue has come up again among KDE/Mac users, and this time I decided to file a ticket on BKO. Finding the right category wasn't trivial, so I picked what seemed the best compromise and relay it here:

KActionCollection, menu/action reuse and the native Mac menubar

2016-09-24 Thread René J . V . Bertin
Hi, I'm making another attempt at raising awareness about a Qt platform limitation on Mac that has potentially severe implications for reuse of QMenus, QActions and QActionWidgets in multiple menus if one of those is attached to a native QMenuBar. In short, the KActionCollection class is

Re: Review Request 126086: [OS X] backend ported from KDE4

2016-09-22 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126086/ --- (Updated Sept. 22, 2016, 4 p.m.) Review request for KDE Software on Mac

KIO, proxies, libproxy and OS X/MSWin

2016-09-22 Thread René J . V . Bertin
Hi, Can someone provide a synthetic resume of how KIO handles proxies on systems other than Linux/Plasma5? I observe that - KIO doesn't link to libproxy and doesn't require its presence in order to build - libproxy is capable of detecting the system settings on OS X - Qt can build against

KF5/Qt5 and multiple QPAs

2016-09-21 Thread René J . V . Bertin
Hi, Am I correct that Qt now provides a Wayland QPA and that users on Linux can now decide, in principle "on the fly" which displaying protocol a newly started application is going to use, presumably with a platform-wide default either hardwired into Qt or defined in some settings file? If

Re: Review Request 126086: [OS X] backend ported from KDE4

2016-09-17 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126086/ --- (Updated Sept. 17, 2016, 7:41 p.m.) Review request for KDE Software on

Re: Help requested with KAuth backends : OS X

2016-09-17 Thread René J . V . Bertin
Sune Vuorela wrote: > I know nothing about mac, and only have a limited knowledge of KAuth, on > linux, but I'll give it a go replying anyways. Thanks, that's a start :) > Whenever an application wants something that requires elevated > priviledges, it contacts policykit, that does the

Help requested with KAuth backends : OS X

2016-09-17 Thread René J . V . Bertin
Hi, Can someone please give me some help setting up a working Mac backend for KAuth? I currently have the basics right after porting the modifications I made to the KDE4 predecessor, but there's a nasty not-so-little detail I've not yet tackled: the helper process that does the actual work.

Re: Review Request 126086: [OS X] backend ported from KDE4

2016-09-15 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126086/ --- (Updated Sept. 15, 2016, 6:41 p.m.) Review request for KDE Software on

Re: installing from git and translations from release?

2016-09-05 Thread René J . V . Bertin
On Friday September 02 2016 09:57:33 Kevin Funk wrote: > > No language dictionaries for the language: "pt" OK, this is weird. I rebuilt Sonnet with clang 3.8.1 on a hunch and the warning disappeared - for a while. Here's what I think happens: - Sonnet is initialised for background spell

Re: Review Request 126161: OS X housekeeping

2016-07-20 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/ --- (Updated July 20, 2016, 1:06 p.m.) Status -- This change has been

regression in kapidox 5.24.0 : failure generating QtCurve API documentation

2016-07-19 Thread René J . V . Bertin
Hi, I'm in the progress of upgrading to FWs 5.24.0 and am having difficulties with my automatic API documentation generating routine. It's working again for the frameworks, but when I try to run it on a QtCurve git working copy I'm seeing this: %> kapidox_generate --qhp --qtdoc-dir

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-07-16 Thread René J . V . Bertin
> On June 14, 2016, 11:10 a.m., René J.V. Bertin wrote: > > sublime/kwidgetstyleselector.cpp, lines 110-112 > > > > > > This works on OS X using the Cocoa QPA, but crashes because of a NULL > > `this` pointer

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-07-15 Thread René J . V . Bertin
> On July 14, 2016, 1:14 p.m., Hannah von Reth wrote: > > sublime/kwidgetstyleselector.cpp, line 43 > > > > > > Dont fall back to Windows. > > Windows is the win3.11 like style. > > I guess the current

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-07-14 Thread René J . V . Bertin
> On July 14, 2016, 1:14 p.m., Hannah von Reth wrote: > > sublime/kwidgetstyleselector.cpp, line 43 > > > > > > Dont fall back to Windows. > > Windows is the win3.11 like style. > > I guess the current

Re: Review Request 126161: OS X housekeeping

2016-07-02 Thread René J . V . Bertin
> On July 2, 2016, 1:11 p.m., David Faure wrote: > > Looks OK to me. > > Please ensure it still compiles+works on Linux, and push it after July 4 > > (so that it doesn't break KF 5.24 at the last minute). > > René J.V. Bertin wrote: > Great. That probably means I'll be pushing it well

Re: Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound file (WIP)

2016-07-02 Thread René J . V . Bertin
> On May 30, 2016, 7:38 p.m., Martin Klapetek wrote: > > src/notifybyaudio.cpp, line 61 > > > > > > But this is not correct, if you disable the sound in the config, the > > soundFilename will be empty and this

Re: Review Request 126161: OS X housekeeping

2016-07-02 Thread René J . V . Bertin
> On July 2, 2016, 1:11 p.m., David Faure wrote: > > Looks OK to me. > > Please ensure it still compiles+works on Linux, and push it after July 4 > > (so that it doesn't break KF 5.24 at the last minute). Great. That probably means I'll be pushing it well after July 4th, though :) > On July

Re: Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound file (WIP)

2016-07-02 Thread René J . V . Bertin
> On July 2, 2016, 10:50 a.m., David Faure wrote: > > src/notifybyaudio.cpp, line 88 > > > > > > So if the user upgrades from Plasma 5 to Plasma 6, and the old sound > > file no longer exists, the user is going

kded5 and "other platforms"

2016-06-22 Thread René J . V . Bertin
Hi, David (Faure) mentioned he's been working to port the kcookiejar away from kded5 (maybe that has advantages on *n*x too?). Idem for the automatic sycoca regeneration, IIRC. I've been running kded4 and now kded5 as part of a "fullest possible" build & install principle under MacPorts on OS

Re: Review Request 128202: Fix problem with install prefix & application bundles

2016-06-18 Thread René J . V . Bertin
> On June 18, 2016, 11:17 a.m., René J.V. Bertin wrote: > > AFAIK emerge is not an OS X utility, but something ported from elsewhere. > > Does it use `-DBUNDLE_INSTALL_DIR` and if not, why? > > > > A few remarks re: kded5. AFAICT this is one of those things that should > > *not* be installed

Re: Review Request 128202: Fix problem with install prefix & application bundles

2016-06-18 Thread René J . V . Bertin
> On June 18, 2016, 11:17 a.m., René J.V. Bertin wrote: > > kde-modules/KDEInstallDirs.cmake, line 388 > > > > > > Is this going to change anything when you define BUNDLE_INSTALL_DIR on > > the commandline? >

Re: Review Request 128202: Fix problem with install prefix & application bundles

2016-06-18 Thread René J . V . Bertin
> On June 18, 2016, 11:17 a.m., René J.V. Bertin wrote: > > kde-modules/KDEInstallDirs.cmake, line 388 > > > > > > Is this going to change anything when you define BUNDLE_INSTALL_DIR on > > the commandline? >

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

2016-06-18 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/ --- (Updated June 18, 2016, 4:06 a.m.) Status -- This change has been

Re: Review Request 128202: Fix problem with install prefix & application bundles

2016-06-18 Thread René J . V . Bertin
> On June 18, 2016, 11:17 a.m., René J.V. Bertin wrote: > > AFAIK emerge is not an OS X utility, but something ported from elsewhere. > > Does it use `-DBUNDLE_INSTALL_DIR` and if not, why? > > > > A few remarks re: kded5. AFAICT this is one of those things that should > > *not* be installed

Re: Review Request 128202: Fix problem with install prefix & application bundles

2016-06-18 Thread René J . V . Bertin
> On June 18, 2016, 11:17 a.m., René J.V. Bertin wrote: > > AFAIK emerge is not an OS X utility, but something ported from elsewhere. > > Does it use `-DBUNDLE_INSTALL_DIR` and if not, why? > > > > A few remarks re: kded5. AFAICT this is one of those things that should > > *not* be installed

Re: Review Request 126161: OS X housekeeping

2016-06-18 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/#review96665 --- There is one general question that remains: wouldn't it be

Re: Review Request 128202: Fix problem with install prefix & application bundles

2016-06-18 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128202/#review96661 --- AFAIK emerge is not an OS X utility, but something ported

Re: Review Request 126161: OS X housekeeping

2016-06-18 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/ --- (Updated June 18, 2016, 11 a.m.) Review request for KDE Software on Mac

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

2016-06-18 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/ --- (Updated June 18, 2016, 10:52 a.m.) Review request for KDE Software on

Re: qmlplugindump org.kde.kquickcontrolsaddons 2.0 dysfunctional

2016-06-15 Thread René J . V . Bertin
On Wednesday June 15 2016 14:42:54 Aleix Pol wrote: >That happens because we're randomly using QWidgets code within >KDeclarative. There's not much else we can do until that's fixed, >except for passing -noinstantiate. Is there something against using that option? Or else simply do a

qmlplugindump org.kde.kquickcontrolsaddons 2.0 dysfunctional

2016-06-15 Thread René J . V . Bertin
Hi, Building the latest Purpose git/master I just discovered this (applies to OS X and Linux): %> /opt/local/libexec/qt5/bin/qmlplugindump org.kde.kquickcontrolsaddons 2.0 QObject: Cannot create children for a parent that is in a different thread. (Parent is QGuiApplication(0x7ffdd69c20c0),

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-06-14 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128056/ --- (Updated June 14, 2016, 7:20 p.m.) Review request for KDE Software on

Re: Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound file (WIP)

2016-06-09 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128043/ --- (Updated June 9, 2016, 7:52 p.m.) Review request for KDE Software on Mac

Re: Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound file (WIP)

2016-06-09 Thread René J . V . Bertin
> On May 30, 2016, 7:38 p.m., Martin Klapetek wrote: > > src/notifybyaudio.cpp, line 61 > > > > > > But this is not correct, if you disable the sound in the config, the > > soundFilename will be empty and this

Re: Review Request 128005: fix alignment issue with the OS X native "macintosh" style

2016-06-09 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128005/ --- (Updated June 9, 2016, 7:13 p.m.) Status -- This change has been

Re: Review Request 128002: address alignment issue with the OS X native "macintosh" style

2016-06-09 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128002/ --- (Updated June 9, 2016, 5:10 p.m.) Status -- This change has been

Re: [kio] : khelpcenter no longer works on OS X

2016-06-02 Thread René J . V . Bertin
On Thursday June 02 2016 10:25:36 David Faure wrote: Are you sure kdeinit and/or klauncher don't filter stderr? I'm not getting *anything* on the kdeinit5 terminal, not with qDebug(), not with qCDebug(KIO_HELP) (category I added), not even with fprintf(stderr,...) ... Anyway, I found the

Re: [kservice] new warnings from kbuildsycoca5, every time

2016-06-02 Thread René J . V . Bertin
On Thursday June 02 2016 13:59:52 David Faure wrote: >On Thursday, June 2, 2016 1:22:25 PM CEST you wrote: >> On Thursday June 02 2016 09:07:53 David Faure wrote: >> > Can you revert the local changes, pull (I committed a fix for the "Not >> > found:" I was getting locally, but it was due to

Re: [kservice] new warnings from kbuildsycoca5, every time

2016-06-02 Thread René J . V . Bertin
On Thursday June 02 2016 09:07:53 David Faure wrote: > Can you revert the local changes, pull (I committed a fix for the "Not > found:" > I was getting locally, but it was due to lowercase/uppercase issues, unlike > what you're seeing), then download and apply >

Re: [kio] : khelpcenter no longer works on OS X

2016-06-02 Thread René J . V . Bertin
On Thursday June 02 2016 10:58:43 David Faure wrote: >We both use an install prefix for the KF5-based code which is different from >the kde4 install prefix. Hah, I'm not the only one on here who still has enough reason to stick to a KDE4 (or at least, non-Plasma5) desktop! :) >So how can

Re: [kio] : khelpcenter no longer works on OS X

2016-06-02 Thread René J . V . Bertin
On Thursday June 02 2016 09:16:16 David Faure wrote: >Please debug which code path of frameworks/kio/src/ioslaves/help/kio_help.cpp >this is going into (method HelpProtocol::get()). Any suggestions on how to do that with something from a plugin that's loaded by a helper process that's itself

Re: [kservice] new warnings from kbuildsycoca5, every time

2016-06-01 Thread René J . V . Bertin
On Wednesday June 01 2016 23:49:51 David Faure wrote: > Apply http://www.davidfaure.fr/2016/more_debug.diff to kservice > and then run > kbuildsycoca5 2>&1 | grep pcx > ? INHERITANCE: Adding service "kactivitymanagerd_fileitem_linking_plugin.desktop" to "image/vnd.zbrush.pcx"

Re: [kio] : khelpcenter no longer works on OS X

2016-06-01 Thread René J . V . Bertin
Luigi Toscano wrote: Hi, > Is it the same with khelpcenter from KDE Applications 16.04.x, which is newer? Sadly, yes. The issue must be in KIO. Before I rebuilt khelpcenter 5.6.4 I have been able to switch back to KIO 5.20.0 (that's a nifty MacPorts feature), and that restored functionality.

Re: [kservice] new warnings from kbuildsycoca5, every time

2016-06-01 Thread René J . V . Bertin
On Monday May 30 2016 23:50:08 David Faure wrote: > I found the last one, it came from kcoreaddons' kde5.xml file, fixed. > http://commits.kde.org/kcoreaddons/4b257a60280de2c68ba24a620127649df3f49d2c Apparently not :-/ Not really surprising even, maybe: kde5.xml isn't the only file in

[kio] : khelpcenter no longer works on OS X

2016-06-01 Thread René J . V . Bertin
Hi, KHelpcentre 5.6.4 no longer works with KIO 5.22.0 on Mac OS X. An identically configured build on Linux still works. The app gives me a popup error that "The file or folder help:/kioslave5/fish/index.html does not exist" and displays "There is no documentation available for

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128056/ --- (Updated May 31, 2016, 11:22 p.m.) Review request for KDE Software on

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128056/ --- (Updated May 31, 2016, 11:21 p.m.) Review request for KDE Software on

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 29, 2016, 7:45 p.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 962 > > > > > > That's not what this is for. It's so it uses merely the "shape" of the > > icon. From your description

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 12:47 p.m., Martin Gräßlin wrote: > > I suggest to look at > > https://api.kde.org/frameworks/kconfigwidgets/html/classKColorSchemeManager.html > > which does something similar just for color schemes. Might make sense to > > have the API structured very similar > > René

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 12:47 p.m., Martin Gräßlin wrote: > > I suggest to look at > > https://api.kde.org/frameworks/kconfigwidgets/html/classKColorSchemeManager.html > > which does something similar just for color schemes. Might make sense to > > have the API structured very similar > > René

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 12:47 p.m., Martin Gräßlin wrote: > > I suggest to look at > > https://api.kde.org/frameworks/kconfigwidgets/html/classKColorSchemeManager.html > > which does something similar just for color schemes. Might make sense to > > have the API structured very similar > > René

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 10:51 a.m., Milian Wolff wrote: > > -2 > > > > kdevelop should use the global widget style. if you don't want that, change > > it via systemsettings > > Aleix Pol Gonzalez wrote: > Well, it's not far-fetching to understand that on non-plasma systems this > KCM will be

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 12:47 p.m., Martin Gräßlin wrote: > > I suggest to look at > > https://api.kde.org/frameworks/kconfigwidgets/html/classKColorSchemeManager.html > > which does something similar just for color schemes. Might make sense to > > have the API structured very similar Yes, that

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 10:51 a.m., Milian Wolff wrote: > > -2 > > > > kdevelop should use the global widget style. if you don't want that, change > > it via systemsettings > > Aleix Pol Gonzalez wrote: > Well, it's not far-fetching to understand that on non-plasma systems this > KCM will be

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 1:38 a.m., Aleix Pol Gonzalez wrote: > > Would it be possible to get this as a KWidgetsAddons patch? It seems like > > it could easily be turned into a `KStyleSelectorMenu`. > > René J.V. Bertin wrote: > True, and the same would go for the "Theme" (colour palette) menu

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
> On May 31, 2016, 10:51 a.m., Milian Wolff wrote: > > -2 > > > > kdevelop should use the global widget style. if you don't want that, change > > it via systemsettings > > Aleix Pol Gonzalez wrote: > Well, it's not far-fetching to understand that on non-plasma systems this > KCM will be

Re: Review Request 128056: Provide a style-selection menu as in KDenlive (WIP)

2016-05-31 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128056/ --- (Updated May 31, 2016, 10:48 a.m.) Review request for KDE Software on

Re: [kservice] new warnings from kbuildsycoca5, every time

2016-05-30 Thread René J . V . Bertin
On Monday May 30 2016 23:50:08 David Faure wrote: > Did you find what is referring to these mimetypes? I've looked for some of them, and found the palm-database one too, but stopped the search when I realised I saw nothing wrong with what I found. I'll have a look at what you changed tomorrow

[kservice] new warnings from kbuildsycoca5, every time

2016-05-30 Thread René J . V . Bertin
Hi, I'm upgrading from my install from 5.20.0 to 5.22.0 and with that version I'm now getting a new list of warnings (errors?) each time kbuildsycoca5 is invoked: Not found: "image/x-pcx" Not found: "application/x-deb" Not found: "video/x-ms-asf" Not found: "application/x-palm-database" Saving

Re: Review Request 126161: OS X housekeeping

2016-05-30 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/ --- (Updated May 30, 2016, 8:28 p.m.) Review request for KDE Software on Mac

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

2016-05-30 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated May 30, 2016, 12:39 p.m.) Review request for KDE Software on

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

2016-05-30 Thread René J . V . Bertin
> On May 30, 2016, 10:43 a.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 910 > > > > > > That "bell" looks like some electrical circuit symbol, I'd rather > > prefer the exclamation mark

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

2016-05-30 Thread René J . V . Bertin
> On May 29, 2016, 5:51 p.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > i18nc please > > René J.V. Bertin wrote: > I'm not sure what to expect here, what effect is using

<    2   3   4   5   6   7   8   9   10   11   >