Re: [OS X] adding a link module to all KF5 targets

2015-09-23 Thread René J . V . Bertin
Let me just add what me me come to KDE. That was mostly out of unhappiness with changes in OS X applications and development, and to find replacements for mail and IDE applications (and because I'd seen on Linux that KDE4 was about ripe to be an alternative to the OS X GUI, I was both

Re: [KDE/Mac] [OS X] adding a link module to all KF5 targets

2015-09-24 Thread René J . V . Bertin
In fact, let me ask a different question: is there a KF5 framework that is guaranteed to be linked to by all KF5 applications that have reason (or are likely) to query QStandardPaths for locations? That would probably provide the cleanest and easiest solution to my quest: that framework could

Re: [KDE/Mac] [OS X] adding a link module to all KF5 targets

2015-09-24 Thread René J . V . Bertin
On Wednesday September 23 2015 14:34:25 Jeremy Whiting wrote: >Back to your original question I don't think there is such a place, >besides patching QtCore itself. Many of the frameworks and >applications use KI18n, but some don't I don't think there's a common >location that every application

Re: [OS X] adding a link module to all KF5 targets

2015-09-22 Thread René J . V . Bertin
On Tuesday September 22 2015 22:35:40 Albert Astals Cid wrote: > Shouldn't KF5 work with those sandboxing? I'd expect that KF5 goal is that > you > can use it in applications that end up in the App Store. It might be possible that someone will someday write an application that uses (a) KF5

Re: [OS X] adding a link module to all KF5 targets

2015-09-22 Thread René J . V . Bertin
Albert Astals Cid wrote: >> (just a non-default option). But it shouldn't be compulsory for everyone. > > Why not? Because it's an enormous lot of extra work that will lead to equally enormous disk overhead (duplicating everything for each and every application), as well as to applications

Re: [KDE/Mac] [OS X] adding a link module to all KF5 targets

2015-09-25 Thread René J . V . Bertin
On Thursday September 24 2015 22:56:37 David Faure wrote: > [warning: long, and I change my mind mid-way; I left it all so you can follow > my reasoning] Seems like a gradual change of mind :) > If you're really only thinking of apps made by the KDE community, I would be > surprised to see any

Re: [KDE/Mac] [OS X] adding a link module to all KF5 targets

2015-09-25 Thread René J . V . Bertin
And another "one more thing": Back when we attempted a first Qt code review, the proposed change was rejected in large part because some Qt devs were against implementing a patch that was only for the benefit of KF5 apps and something that was presented too much as a KF5 issue. IIRC, the

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

2015-12-07 Thread René J . V . Bertin
On Sunday December 06 2015 14:51:40 David Faure wrote: > Here is an easy way to test this: do the same change for kiod in kio (it's > like a mini kded) and then > cd kio/tests ; ./listjobtest ftp://t...@upload.kde.org > should bring up a password dialog. Regardless of what I try (even with

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-07 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89222 --- So with the current implementation that uses inheritance,

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-07 Thread René J . V . Bertin
> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.h, lines 41-54 > > > > > > why did you add the virtual? The methods are marked as Q_DECL_OVERRIDE > > which implies they

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-07 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 7, 2015, 5:43 p.m.) Review request for KDE Software on Mac

Re: Review Request 126241: [OS X] adapting KStyle (WIP)

2015-12-07 Thread René J . V . Bertin
> On Dec. 7, 2015, 4:29 p.m., Hugo Pereira Da Costa wrote: > > I honestly have some doubt on the approach (but no counter proposal either) > > Basically the file kstyle.mm is a *copy* of the .cpp file, with a couple of > > lines changed. (which I had to track down by > > - downloading the

kdelibs4support forces "icons in buttons"?

2015-12-08 Thread René J . V . Bertin
Hi, I have the strong impression that applications using the kdelibs4support fw are forced to show icons in buttons, regardless of the corresponding setting (which is respected elsewhere). For some reason it does not happen when I use the native platform plugin on OS X, but if the

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-02 Thread René J . V . Bertin
> On Dec. 2, 2015, 10:45 a.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-02 Thread René J . V . Bertin
> On Dec. 2, 2015, 10:45 a.m., Boudhayan Gupta wrote: > > src/platformtheme/kdemactheme.mm, line 39 > > > > > > This makes me very nervous. > > > > Using private APIs is almost always a guarantee the

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-02 Thread René J . V . Bertin
> On Dec. 1, 2015, 9:34 p.m., René J.V. Bertin wrote: > > src/platformtheme/kdemactheme.mm, lines 53-87 > > > > > > I thought it would be best to use a native dialog here to show a > > warning dialog, but it

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-02 Thread René J . V . Bertin
> On Dec. 2, 2015, 8:46 a.m., Martin Gräßlin wrote: > > Overall I think this is now too much code duplication. With this appraoch > > you don't get bug fixes from the base code. I recommed to rather go for > > inheritance to have the actual code which can be shared still together. Yes, I was

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-02 Thread René J . V . Bertin
> On Dec. 2, 2015, 8:38 a.m., Martin Gräßlin wrote: > > Just wondering: if your main aim is to change default settings, why don't > > follow what linux distros do? That is ship some default configuration > > interface. For inspiration check e.g. kubuntu-default-settings. > > René J.V. Bertin

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-02 Thread René J . V . Bertin
> On Dec. 2, 2015, 8:38 a.m., Martin Gräßlin wrote: > > Just wondering: if your main aim is to change default settings, why don't > > follow what linux distros do? That is ship some default configuration > > interface. For inspiration check e.g. kubuntu-default-settings. If I understand you

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

2015-11-29 Thread René J . V . Bertin
On Nov. 25, 2015, 6:18 p.m., René J.V. Bertin wrote: > > See qtbase/src/plugins/platforms/cocoa/qcocoaintegration.mm and > > qcocoahelpers.mm > > René J.V. Bertin wrote: > Isn't copy/paste a great tool? :) > > Anyway, `qt_mac_transformProccessToForegroundApplication` only reads

Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-11-29 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Re: setting default widgetStyle (and ColorScheme)

2015-11-30 Thread René J . V . Bertin
Martin Graesslin wrote: > That is in deed a better approach. I'm still questioning whether it's the > right thing to do on OSX, but that would then be up to the OSX developers to > decide on. I'll handle that tomorrow. > But if the platformtheme plugin does get moved to Plasma I would say

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-01 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89008 --- A couple of things I jotted down today, probably open doors

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-01 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 1, 2015, 9:29 p.m.) Review request for KDE Software on Mac

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-01 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89009 --- src/platformtheme/kdemactheme.mm (lines 53 - 87)

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

2015-12-02 Thread René J . V . Bertin
> On Dec. 2, 2015, 8:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-02 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 2, 2015, 10:38 p.m.) Review request for KDE Software on

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-02 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 2, 2015, 10:42 p.m.) Review request for KDE Software on

Re: KTabBar/QTabBar and documentMode

2015-12-04 Thread René J . V . Bertin
Jaroslaw Staniek wrote: > Hi, that's one of my hints from 2010 > https://blogs.kde.org/2010/09/29/elegance-4-tab-bar-uncluttered :) But that's for a different purpose, removing distracting visual clutter rather than ensuring that the tabs themselves remain useful. After looking into the issue

Review Request 126239: make autotests nongui executables

2015-12-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126239/ --- Review request for KDE Frameworks. Repository: frameworkintegration

Review Request 126241: [OS X] adapting KStyle (WIP)

2015-12-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126241/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Hugo

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 4, 2015, 2:05 p.m.) Review request for KDE Software on Mac

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-04 Thread René J . V . Bertin
> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > Please include Hugo for a review on the KStyle changes. > > > > I'd suggest to split the review into three parts: one about the adjusted > > test (ecm_foo) - that's a no brainer and doesn't need further discussion. > > One about the

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-04 Thread René J . V . Bertin
> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.h, lines 41-54 > > > > > > why did you add the virtual? The methods are marked as Q_DECL_OVERRIDE > > which implies they

Re: Review Request 126239: make autotests nongui executables

2015-12-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126239/ --- (Updated Dec. 4, 2015, 4:49 p.m.) Status -- This change has been

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

2015-12-06 Thread René J . V . Bertin
On Sunday December 06 2015 14:51:40 David Faure wrote: > Here is an easy way to test this: do the same change for kiod in kio (it's > like a mini kded) and then > cd kio/tests ; ./listjobtest ftp://t...@upload.kde.org > should bring up a password dialog. OK, hope to get around to doing that

Re: kpty/utempter

2015-12-06 Thread René J . V . Bertin
On Sunday December 06 2015 21:52:21 David Faure wrote: > > Question is, how useful is this in KPty? > > `utempter is a privileged helper program that writes utmp/wtmp entries for > unprivileged programs.` I can read, you know ;) > > Does utmp or wtmp exist on OSX? > Hmm, yes, but deprecated

[OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

2015-12-09 Thread René J . V . Bertin
Hi, Several classes exist that have the possibility to create widgets or windows from a Qt WId, and those are used (exclusively? mostly?) by certain helper agents like the kwalletd to display dialogs parented by a window from the application that sent the request that justified posting the

Re: [OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

2015-12-09 Thread René J . V . Bertin
On Wednesday December 09 2015 13:51:47 Martin Graesslin wrote: > > KWindowSystem::setMainWindow() is a different matter. Firstly, it does NOT > > use the plugin architecture currently, but simply assumes that > > QWindow::fromWinId() will always work (and never crash). > > oh that explains a

Re: Scope of framework integration plugin?

2015-12-05 Thread René J . V . Bertin
Boudewijn Rempt wrote: From what I recall from KDE4, there was at least a KDE -> X resources path in systemsettings > without any kde integration available, and I noticed that Qt 5.6 doesn't seem > to pick up the Gnome font hinting settings. Re-reading this I'd say there must be a default

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-04 Thread René J . V . Bertin
> On Dec. 4, 2015, 2:40 p.m., Martin Gräßlin wrote: > > No, those we shouldn't need anymore as the toplevel CMake file will reject Qt versions earlier than 5.3.0 . Should I clean up all occurrences from platformtheme, even where they have nothing to do with the Mac version? - René J.V.

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-04 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 4, 2015, 7:01 p.m.) Review request for KDE Software on Mac

KTabBar/QTabBar and documentMode

2015-12-03 Thread René J . V . Bertin
Hi, I've been looking into ways to configure (improve) the look and feel using the native platform theme on OS X, and was reminded quite quickly about one of the nuisances that can arise with the default look of the native widget used by QTabBar. It's easy to reach the number of open tabs

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-03 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 3, 2015, 10:51 p.m.) Review request for KDE Software on

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

2015-12-02 Thread René J . V . Bertin
> On Dec. 2, 2015, 8:38 a.m., Martin Gräßlin wrote: > > Just wondering: if your main aim is to change default settings, why don't > > follow what linux distros do? That is ship some default configuration > > interface. For inspiration check e.g. kubuntu-default-settings. > > René J.V. Bertin

Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

2015-12-09 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Re: [OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

2015-12-09 Thread René J . V . Bertin
Kai Uwe Broulik wrote: > ‎> On OS X (and MS Windows?), > > And Wayland, so it affects Linux, too. Yes, I learned that while composing my message (cf. the subject). FWIW, I just provided an initial/WIP implementation of a KWindowSystem plugin for OS X: https://git.reviewboard.kde.org/r/126291/

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread René J . V . Bertin
> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

system tray test?

2015-12-11 Thread René J . V . Bertin
Hi, Does KF5 provide any classes above Qt's for putting up and controlling an icon (with/out menu) in the "system tray"? If so, is there a simple test app I can try? Reason I'm asking: kwalletmanager5 isn't showing a systray interface like kwalletmanager(4) does. Not on OS X (where Qt5's

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 11, 2015, 1:42 p.m.) Review request for KDE Software on

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 11, 2015, 1:59 p.m.) Review request for KDE Software on

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread René J . V . Bertin
> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread René J . V . Bertin
> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread René J . V . Bertin
> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-10 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Qt KDE.

Review Request 126309: backtrace and demangle for OS X, FreeBSD and Solaris/OpenIndiana

2015-12-10 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126309/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 11, 2015, 5:26 p.m.) Review request for KDE Software on

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread René J . V . Bertin
> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 61 > > > > > > unrelated and it won't leak, since the cleanup is done by the > > parent/child relation ("this" passed

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread René J . V . Bertin
> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 36 > > > > > > unrelated and not required Not required indeed, but related in the sense that it removes any ambiguity

kwidgetsaddons on OS X: menus become menu items

2015-12-11 Thread René J . V . Bertin
Hi, After building kate I'm seeing repeating messages like the ones below on the calling terminal, using either Kate or KWrite. This also happens with Christoph's bundle(d) build. (I've patched my Qt build to be more informative though). void QCocoaMenu::insertNative(QCocoaMenuItem *,

Re: kwidgetsaddons on OS X: menus become menu items

2015-12-11 Thread René J . V . Bertin
On Friday December 11 2015 23:55:35 René J.V. Bertin wrote: KActionMenu being derived from QWidgetAction I wonder if the following blurb from the QWidgetAction documentation is relevant here: OS X: If you add a widget to a menu in the application's menu bar on OS X, the widget will be added

lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

2015-12-15 Thread René J . V . Bertin
Out of curiosity: is it intended that KFileMetaData sets the library compatibility version to 3, leading to /opt/local/lib/x86_64-linux-gnu/libKF5FileMetaData.so /opt/local/lib/x86_64-linux-gnu/libKF5FileMetaData.so.3 /opt/local/lib/x86_64-linux-gnu/libKF5FileMetaData.so.5.17.0 and on OS X %>

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

2015-12-15 Thread René J . V . Bertin
On Tuesday December 15 2015 18:55:52 René J.V. Bertin wrote: > for packaging purposes it would be preferable if all libraries (symlinks) > that are recorded in dependents' dependency lists are of the form > libKF5*.5.dylib or libKF5*.so.5 (KFileMetadata is the only deviant one). PS : KDE4's

Re: system tray test?

2015-12-15 Thread René J . V . Bertin
René J. V. Bertin wrote: > Sebastian Kügler wrote: >> Seems to make sense to me. Could you file a review request for this? > > Ok, will put that on my todo list :) https://git.reviewboard.kde.org/r/126369/ :) R. ___ Kde-framework

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

2015-12-16 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 16, 2015, 10:24 p.m.) Review request for KDE Software on

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

2015-12-16 Thread René J . V . Bertin
> On Dec. 16, 2015, 5:40 p.m., Martin Klapetek wrote: > > src/kstatusnotifieritem.cpp, line 710 > > > > > > Why is it reasonable if the platform guidelines speak against it? The platform guidelines apply to

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

2015-12-16 Thread René J . V . Bertin
šumski wrote: >> Fixed, it was an oversight when converting the lib into a KF5 framework. > > But this is a BiC change... Yes, bug fixes can do that ;) R ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-17 Thread René J . V . Bertin
> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2015-12-14 Thread René J . V . Bertin
> On Dec. 14, 2015, 7:53 a.m., Martin Gräßlin wrote: > > src/gui/CMakeLists.txt, line 2 > > > > > > this introduces a QtWidgets dependency and thus changes the integration > > level of the framework. I highly

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-14 Thread René J . V . Bertin
> On Dec. 14, 2015, 7:56 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.cpp, line 45 > > > > > > this looks like a not needed debug statement, same in dtor and > > loadSettings and

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2015-12-14 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/ --- (Updated Dec. 14, 2015, 5:04 p.m.) Review request for KDE Software on

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2015-12-14 Thread René J . V . Bertin
> On Dec. 14, 2015, 12:47 p.m., Marco Martin wrote: > > src/gui/CMakeLists.txt, line 22 > > > > > > we really can't add a dependency to QWidgets here. > > depending on qwidgets will make many potential

about ki18n/locales: installing only a subset?

2015-12-15 Thread René J . V . Bertin
Hi, The KDE4 approach to internationalisation (sic :)) had the huge advantage that it was rather trivial to provide installer packages for individual languages so users could install only those few languages they would actually use. It seems that with KF5 we have gotten back in the situation

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-13 Thread René J . V . Bertin
> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > For the record: I've raised a few interrogations that are preventing me from following up and addressing the open issues raised by Thomas. - René J.V. --- This is an

"Buttons have icons", round N+1

2015-12-13 Thread René J . V . Bertin
Hi, There has been some discussion around one of my RRs concerning how to respect KDE's ShowIconsOnPushButtons and Qt's SH_DialogButtonBox_ButtonsHaveIcons style hint. The ultimate way would be in the style that does the actual drawing, but that is probably not the one with the smallest

Re: "Buttons have icons", round N+1

2015-12-13 Thread René J . V . Bertin
On Sunday December 13 2015 17:14:17 Thomas Lübking wrote: > I object the overhead concern. The global solution is easily applied by the > style (the icon isn't loaded from disk or rendered until you/the style > requires a pixmap from painting - until then there's just a string that hints >

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2015-12-13 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/ --- (Updated Dec. 13, 2015, 2:54 p.m.) Review request for KDE Software on

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-13 Thread René J . V . Bertin
> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 39 > > > > > > QDialogButtonBox::addButton should do correctly anyway, so please don't > > workaround things that are

Re: kwidgetsaddons on OS X: menus become menu items

2015-12-12 Thread René J . V . Bertin
René J.V. Bertin wrote: > The widget is reparented away from the QMenu to the native menu view. If you > show the menu in some other place (e.g. as a popup menu), the widget will not > be there. Actually I think this part *is* related: I noticed that the Bookmarks menu is supposed to appear

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-12 Thread René J . V . Bertin
> On Dec. 7, 2015, 5:41 p.m., René J.V. Bertin wrote: > > So with the current implementation that uses inheritance, there are 2 > > classes that have a `delayedDBusConnects` method which uses > > `QDBusConnection::sessionBus().connect()` to register things on the DBus. > > Both invoke that

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-12 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 12, 2015, 7:08 p.m.) Review request for KDE Software on

kdebugdialog5 crashing on exit (FYI)

2015-12-11 Thread René J . V . Bertin
Hi, I mentioned having crashes on exit with kdebugdialog5 a couple of days ago, deep in Qt territory. At first I thought the culprit was my implementation of a "KdeMacPlatformTheme" that inherits from the regular KdePlatformTheme. Then I noticed that kdebugdialog5 also crashes on exit on

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

2015-12-17 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review89652 --- Well, it isn't exactly easy, but I remembered that KMail can

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

2015-12-17 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 17, 2015, 3 p.m.) Review request for KDE Software on Mac

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

2015-12-17 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 17, 2015, 5:26 p.m.) Review request for KDE Software on

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-17 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 17, 2015, 7:40 p.m.) Review request for KDE Software on

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2015-12-17 Thread René J . V . Bertin
> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2015-12-17 Thread René J . V . Bertin
> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-17 Thread René J . V . Bertin
> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > > > René J.V. Bertin wrote: > For the record: I've raised a few interrogations that are preventing me > from following up and addressing the open issues raised by Thomas. I'm stepping out, patching icons out of buttons elsewhere but

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2015-12-18 Thread René J . V . Bertin
> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-18 Thread René J . V . Bertin
> On Dec. 18, 2015, 8:11 a.m., Martin Gräßlin wrote: > > I still want to see other OSX devs comment on that this is really the > > wanted approach. Also I need to point out that the split out of QPT to > > plasma-integration is prepared. I suggest to introduce a comparable > > osx-integration

Re: about ki18n/locales: installing only a subset?

2015-12-18 Thread René J . V . Bertin
On Friday December 18 2015 10:53:35 Chusslove Illich wrote: >I'm not talking about offices requiring it. I'm talking about coming to a >random office in the world and finding my language already available, >without trifling anyone about it. Out of curiosity: do you expect to use your language

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2015-12-18 Thread René J . V . Bertin
> On Dec. 18, 2015, 8:11 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.cpp, lines 45-46 > > > > > > Q_NULLPTR > > René J.V. Bertin wrote: > I recall a relatively recent discussion on a

Re: about ki18n/locales: installing only a subset?

2015-12-16 Thread René J . V . Bertin
On Wednesday December 16 2015 14:18:33 Jaroslaw Staniek wrote: > How about bundling the files in qrc containers, one per language to address > the issue of many tiny files? Agreed (and a priori already raised in a previous message). > That reminds me similar case of icon files. Indeed. And the

Re: about ki18n/locales: installing only a subset?

2015-12-16 Thread René J . V . Bertin
On Wednesday December 16 2015 11:48:58 David Faure wrote: > They are copied into the frameworks at release time. So you can also grab > them from > svn://anonsvn.kde.org/home/kde/trunk/l10n-kf5 directly (warning, this is huge) Ah, good! Svn is a bit of a hog indeed, but IIRC it does make it

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-10 Thread René J . V . Bertin
> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-10 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 10, 2015, 11:54 p.m.) Review request for KDE Software on

Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

2015-12-10 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126304/ --- Review request for KDE Frameworks, Qt KDE and Yichao Yu. Repository:

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2015-12-14 Thread René J . V . Bertin
> On Dec. 14, 2015, 7:53 a.m., Martin Gräßlin wrote: > > src/gui/CMakeLists.txt, line 2 > > > > > > this introduces a QtWidgets dependency and thus changes the integration > > level of the framework. I highly

Re: system tray test?

2015-12-14 Thread René J . V . Bertin
Sebastian Kügler wrote: >> >> I'd suggest replacing the line above with a sequence "m->addAction, m- >> >> >addSeparator" on OS X, or do you have other suggestions? > > Seems to make sense to me. Could you file a review request for this? Ok, will put that on my todo list :) Cheers, R.

<    1   2   3   4   5   6   7   8   9   10   >