D5178: QtCurve/Qt5 : further KF5 adaptation

rjvbb created this revision. REVISION SUMMARY This patch introduces several improvements to QtCurve's integration with KF5: - Inherit KStyle instead of QCommonStyle when built with KDE support - recognise at least KF5 systemsettings application and above all KWin5 - use the new method

D5178: QtCurve/Qt5 : further KF5 adaptation

rjvbb added a comment. In https://phabricator.kde.org/D5178#99143, @bcooksley wrote: > We won't be modifying Phabricator, in part because Arcanist as shipped by upstream is designed to work with that text. We're talking about the trigger in commit messages made with regular git

D5089: KDE compiler settings fail to consider AppleClang

rjvbb closed this revision. rjvbb added a comment. https://commits.kde.org/extra-cmake-modules/7af9f8e2b6eb235923a329e8ff24012883fb6b86 REVISION DETAIL https://phabricator.kde.org/D5089 To: rjvbb, #build_system, #frameworks, kfunk Cc: kfunk, apol, kde-mac, #frameworks, #build_system

D5037: KTextEditor: prevent accidental zooming

rjvbb updated this revision to Diff 12608. rjvbb added a comment. Updated as requested CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5037?vs=12480=12608 REVISION DETAIL https://phabricator.kde.org/D5037 AFFECTED FILES src/view/kateviewinternal.cpp

python bindings

Hi, I see that 5.31.0 marked the introduction of python bindings. That's nice (once you figure out how to get them to build) but does that mean there will be no standalone py-kde project like there was for KDE4? IOW, building the bindings and for what python version is something that will have

D5089: KDE compiler settings fail to consider AppleClang

rjvbb created this revision. rjvbb added projects: Build System, Frameworks. REVISION SUMMARY KDECompilerSettings.cmake and KDEFrameworksCompilerSettings.cmake fail to consider the fact that cmake considers Apple's clang compiler to be different (differences that exist but are largely

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

Either way it remains tricky business doing this without any knowledge about the widget that's being grabbed. I've already seen cases where you open a menu with a single mouse click and then the context menu appeared as well a short while later. That looks as if even the standard behaviour of

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/#review102882 --- https://phabricator.kde.org/D5069 - René J.V. Bertin On

D5069: initial implementation of a platform plugin for OS X

rjvbb created this revision. rjvbb added a project: Frameworks. REVISION SUMMARY KWindowSystem has been and is still lacking a platform plugin for OS X. A ReviewBoard RR has been up with a "backport" of the modified KDE4 KWindowSystem implementation that has been used in the MacPorts kdelibs4

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated March 16, 2017, 4:42 p.m.) Status -- This change has been

Re: Review Request 126086: [OS X] backend ported from KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126086/ --- (Updated March 16, 2017, 4:31 p.m.) Status -- This change has been

Re: Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound file (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128043/#review102883 --- https://phabricator.kde.org/D5070 - René J.V. Bertin On

D5070: Allow to play the default system sound (beep) instead of a specific sound file (WIP)

rjvbb created this revision. rjvbb added a project: Frameworks. REVISION SUMMARY This is a "port" of https://git.reviewboard.kde.org/r/128043/ which is itself a follow-up to discussion on the plasma-devel ML. The main goal behind the patch is to ensure audio notifications will sound

D5089: KDE compiler settings fail to consider AppleClang

rjvbb added a comment. In https://phabricator.kde.org/D5089#95732, @apol wrote: > Maybe it would make sense to use MATCHES? are there any other *Clang*? That was my first idea, use `MATCHES "*Clang"`, but then I realised I have no idea if there are other SomethingClang. Searching

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

This actually works pretty nicely: https://commits.kde.org/scratch/rjvbb/osx-integration/1bfc3c00293dff6c726d0853457ab09b560e3df9 - m_grabbing is still used to track whether the 1st mousebutton press must be resend after grabbing the gesture. I prefer that to using a separate object property,

D5037: KTextEditor: prevent accidental zooming

rjvbb updated this revision to Diff 12480. rjvbb added a comment. - don't use QElapsedTimer::elapsed() when the timer isn't valid. Changes nothing to the behaviour but may make the code a bit less obfuscated. - edited a few comments CHANGES SINCE LAST UPDATE

D5037: KTextEditor: prevent accidental zooming

rjvbb added a comment. In https://phabricator.kde.org/D5037#95031, @anthonyfieroni wrote: > Ok, note this situation, hold modifier before first ever wheel event => you call m_lastWheelEvent.elapsed on unstarted timer This is true, and things can indeed be improved a bit there.

D5089: KDE compiler settings fail to consider AppleClang

rjvbb updated this revision to Diff 12583. rjvbb added a comment. Uses `MATCHES "Clang"` . Tested and appears to work with AppleClang `Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)` CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5089?vs=12572=12583 REVISION

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a continuation/transfer of https://git.reviewboard.kde.org/r/128109/ (which still has a few screenshots) There currently is no

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. Once more. Note how Oxygen renders an icon on the menu button despite me having disabled the icons-in-buttons feature in the settings. Only QtCurve seems to respect this setting for regular buttons (in dialog button boxes) nowadays. F2988220:

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. > - please re-add the screenshot from Review Board. (sorry I was not aware of this review request cause I was not in the list of reviewers, even though official maintainer of oxygen ...) Sorry about that, I thought you'd be a member of the Plasma group. But I had

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb updated this revision to Diff 12644. rjvbb edited the summary of this revision. rjvbb added a comment. Updated, not yet split. I've kept the former left-to-right menu action as a "check here" noop action and made the distinction a bit more explicit by adding a menu section (which

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. Colour scheme chooser proposition split off: https://phabricator.kde.org/D5113 REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, jriddell, anthonyfieroni, zhigalin, hpereiradacosta Cc: kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb updated this revision to Diff 12647. rjvbb added a comment. stripped diff. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5111?vs=12644=12647 REVISION DETAIL https://phabricator.kde.org/D5111 AFFECTED FILES kstyle/demo/oxygendemodialog.cpp

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb removed a project: Plasma. rjvbb removed a subscriber: plasma-devel. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, hpereiradacosta, jriddell, anthonyfieroni, zhigalin Cc: kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. Screenshots: F2988075: oxydemo-breeze.png F2988076: oxydemo-qtcurve.png F2988077: oxydemo-oxygen.png F2988078:

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Wednesday March 15 2017 09:07:48 David Faure wrote: >Definitely. But there's another solution: QObject::setProperty, >which supports dynamic properties so you can store anything you want in there. I did think of something like that, but didn't get around yet to figuring out how. Any idea

D5286: QtCurve alternative style for named menu section headers (WIP)

rjvbb added a comment. F3517948: qtcurve-menusections-config.png F3517946: qtcurve-menusections-new.png F3517943: qtcurve-menusections-buttonstyle.png F3517944:

D5286: QtCurve alternative style for named menu section headers (WIP)

rjvbb added a comment. I have been unable to figure out whether it's indeed impossible to detect if a menu item is the 1st or last in a menu when calculating its content size (CT_MenuItem). Is it? Idem for drawing (CE_MenuItem): is there anything other than the content rect co-ordinates

D5286: QtCurve alternative style for named menu section headers (WIP)

rjvbb created this revision. REVISION SUMMARY This patch introduces an optional new/modern look for named menu section headers to the Qt4 and Qt5 style plugins. The context: I have been tinkering with (minimal changes to) Qt's Cocoa backends to enable full support of named menu

D3830: Add a new FindGperf module

rjvbb accepted this revision. rjvbb added a comment. This revision is now accepted and ready to land. Sorry, I haven't had the occasion to test this modification but given our exchange above this ought to be fine as far as I can tell. REPOSITORY R240 Extra CMake Modules BRANCH

D5379: Fix compilation under AppleClang

rjvbb accepted this revision. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5379 To: kfunk, apol, rjvbb Cc: #frameworks, #build_system

D5379: Fix compilation under AppleClang

rjvbb added a comment. LGTM. Is this related to the compiler features issue in one of Qt's cmake modules? REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5379 To: kfunk, apol, rjvbb Cc: #frameworks, #build_system

KTextEditor : best way to add background vertical guide lines?

Hi, What's the best way to add render a couple of vertical lines in a widget derived from KTextEditor, for instance to provide margin indicators? Thanks, René

Re: KTextEditor : best way to add background vertical guide lines?

Dominik Haumann wrote: Hi Dominik, > This discussion belongs to kwrite-de...@kde.org. Forgive me if I prefer not to subscribe to another ML just yet... > The KTextEditor::View can only display one vertical indicator. > Is that what you mean? I didn't know that, I looked for ways to activate

D5286: QtCurve alternative style for named menu section headers

rjvbb retitled this revision from "QtCurve alternative style for named menu section headers (WIP)" to "QtCurve alternative style for named menu section headers". REPOSITORY R626 QtCurve REVISION DETAIL https://phabricator.kde.org/D5286 To: rjvbb, yuyichao Cc: #plasma, kde-mac, #frameworks

D5286: QtCurve alternative style for named menu section headers

rjvbb closed this revision. rjvbb added a comment. Submitted: https://commits.kde.org/qtcurve/88296597a57eaac7849aaa2feb201cba3a9213b4 REPOSITORY R626 QtCurve REVISION DETAIL https://phabricator.kde.org/D5286 To: rjvbb, yuyichao Cc: #plasma, kde-mac, #frameworks

D5286: QtCurve alternative style for named menu section headers

rjvbb added a comment. In https://phabricator.kde.org/D5286#103899, @yuyichao wrote: > Assuming the coordinate calculations are correct (which I can never get right without seeing the result) this LGTM. They can't be completely wrong as I have now used the new mode for a while

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

> On Feb. 25, 2016, 8:26 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, lines 465-467 > > > > > > I would prefer to not introduce new platform specific code in the > > shared part. > > > > The

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/ --- (Updated March 3, 2017, 6:23 p.m.) Review request for KDE Software on

D5037: KTextEditor: prevent accidental zooming

rjvbb marked an inline comment as done. rjvbb added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kateviewinternal.cpp:76 > About me, it's designed to unset modifiers so param looks unwanted. I don't disagree but not for exactly the same reason. I'm not sure the function is or

D5037: KTextEditor: prevent accidental zooming

rjvbb updated this revision to Diff 12466. rjvbb added a comment. This makes unsetting the modifier non-optional and rewords some comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5037?vs=12448=12466 REVISION DETAIL https://phabricator.kde.org/D5037 AFFECTED FILES

D5037: KTextEditor: prevent accidental zooming

rjvbb added a comment. In https://phabricator.kde.org/D5037#94944, @anthonyfieroni wrote: > Ok, we discard first wheel event cause elapsed timer isn't started, right? No, it's not discarded; no wheel events are being discarded unless they already were being discarded. What my

D5037: KTextEditor: prevent accidental zooming

rjvbb added a subscriber: luebking. REVISION DETAIL https://phabricator.kde.org/D5037 To: rjvbb, #ktexteditor Cc: luebking, anthonyfieroni, dhaumann, kwrite-devel, #ktexteditor, #frameworks, head7, cullmann, kfunk, sars

KGuiAddons and QGestures like tap/click-and-hold to open context menu?

Hello, The other day I had to add a context menu to a widget (QPushbutton) defined in a .ui file and went a bit further when I realised it could be nice to be able to open such a menu without using a right-click or menu button. After all, not all platforms have a (physical) right mouse button

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 15:27:43 David Faure wrote: > Isn't this exactly what QToolButton::setMenu does? > (given that the default popupMode is DelayedPopup) Possible, one would indeed expect that from the description . That class wouldn't need this extension then, but I think it's not trivial

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 16:54:20 David Faure wrote: >If it's about a very general long-click-should-open-context-menu then maybe it >can be done globally in the QPA rather than in each and every widget? Probably, yes. >It would >then be a generic event handling thing. Off by default though,

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 17:52:25 David Faure wrote: > It would trigger, sometimes against the user's will if he's a bit slow, on > desktop systems where it's really not necessary since there's a right mouse > button. Quite slow, more like "oops, forgot to release the mousebutton". 700ms is

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 20:11:08 René J.V. Bertin wrote: > And a static method that takes a QWidget, subscribes it to the gesture and > installs the event filter. Correction: the event filter could of course be provided by a QPA platform plugin and installed at the application level. But what

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 18:57:23 David Faure wrote: > Or I hold the mouse button pressed because I'm about to start a drag-n- > drop. One for which you wait too long then, something users of systems where tap-and-hold is usual (i.e. most of us?) would probably recognise. If you start

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 17:52:25 David Faure wrote: > > And if you make it an optional feature in the QPA it (almost?) becomes > > something that users might want to control the way they could control > > certain things via Q4's qtconfig . > > Or systemsettings, sure. > > > Maybe the QPA

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 20:21:33 David Faure wrote: >Forget QGesture, this can be done with simple mouse events. Reinvent the wheel? Why not. I got the impression from the google results that led to finding the TapAndHold gesture solution that it could be trickier than you might think but

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

On Sunday March 12 2017 20:21:33 David Faure wrote: > Forget QGesture, this can be done with simple mouse events. Another solution: catch mouse events for the desired QWidget types, use QGesture::grabbedGesture to check if they are subscribed and if not subscribe them. Re-implementing this

Re: KGuiAddons and QGestures like tap/click-and-hold to open context menu?

Proof of concept: https://commits.kde.org/scratch/rjvbb/osx-integration/1260a608db98cfd3d75bf15917945b59c81b1182 The same class also adds a simulated (emulated?) Menu key that's a real saver in those situations where I'm getting more side-effects from my trackpad's 2-finger right-tap than

D4968: Mac OS (X) has a POSIX-compliant /bin/sh too

rjvbb closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4968 To: rjvbb, #frameworks, dfaure Cc: bcooksley, dfaure, #frameworks

D5037: KTextEditor: prevent accidental zooming

rjvbb created this revision. rjvbb added a project: KTextEditor. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY KTextEditor::KateViewInternal::wheelEvent() implements text zoom in reaction to Ctrl+Wheel

D5037: KTextEditor: prevent accidental zooming

rjvbb updated this revision to Diff 12448. rjvbb edited the test plan for this revision. rjvbb added a comment. Was this what you had in mind? CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5037?vs=12438=12448 REVISION DETAIL https://phabricator.kde.org/D5037 AFFECTED FILES

D5037: KTextEditor: prevent accidental zooming

rjvbb marked 2 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D5037 To: rjvbb, #ktexteditor Cc: dhaumann, kwrite-devel, #ktexteditor, #frameworks, head7, cullmann, kfunk, sars

D4968: Mac OS (X) has a POSIX-compliant /bin/sh too

rjvbb created this revision. rjvbb added a project: Frameworks. REVISION SUMMARY Apple also ships a POSIX-compliant /bin/sh, which is in fact a copy of /bin/bash . Some relevant links:

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

> On Dec. 27, 2016, 6:39 p.m., Martin Gräßlin wrote: > > src/platforms/osx/kwindowinfo.mm, line 33 > > > > > > what's "Ext"? Stood for Extended. > On Dec. 27, 2016, 6:39 p.m., Martin Gräßlin wrote: > >

D4968: Mac OS (X) has a POSIX-compliant /bin/sh too

rjvbb added a comment. In https://phabricator.kde.org/D4968#93535, @dfaure wrote: > Can you use arc diff to upload changes? Then context would be available in the diffs (I think). This *was* uploaded with arc diff (through KDevelop's new export-to-Phabricator plugin)... With

D4968: Mac OS (X) has a POSIX-compliant /bin/sh too

rjvbb added a comment. In https://phabricator.kde.org/D4968#93542, @bcooksley wrote: > Something is definitely odd about this revision - it doesn't appear to have been submitted using Arcanist. > The branch, along with local commit information is missing, and Arcanist always

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb updated this revision to Diff 12666. rjvbb added a comment. Maintain Qt4 compatibility CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5111?vs=12647=12666 REVISION DETAIL https://phabricator.kde.org/D5111 AFFECTED FILES kstyle/demo/main.cpp

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

rjvbb added a comment. In https://phabricator.kde.org/D5111#96517, @ltoscano wrote: > Which repository is this? Oxygen? Please add it. Apologies, something must have gone wrong adding it the 1st time. REPOSITORY R113 Oxygen Theme REVISION DETAIL

KF5Solid in subprefix and/or on [K]Ubuntu 14.04

Hi, As you know I've been building my own KF5 (and Qt5) packages for installation into /opt/local on an up-to-date Ubuntu 14.04LTS system. I register the required directories under /opt/local with DBus so (almost) everything works as you'd expect. On notable difference I just discovered:

Re: konqueror5/Mac : kf5.kio.widgets: KonqRun(x) ERROR (stat): 111 "The file or folder http://www.kde.org/ does not exist."

On Thursday August 10 2017 09:37:05 David Faure wrote: > On mercredi 9 août 2017 18:10:12 CEST René J.V. Bertin wrote: > > ERR_UNKNOWN_URL_SCHEME > > Debug KProtocolInfo::isKnownProtocol("http") returning false. It doesn't (or at least it shouldn't;

Re: konqueror5/Mac : kf5.kio.widgets: KonqRun(x) ERROR (stat): 111 "The file or folder http://www.kde.org/ does not exist."

On Thursday August 10 2017 09:37:05 David Faure wrote: >On mercredi 9 août 2017 18:10:12 CEST René J.V. Bertin wrote: >> ERR_UNKNOWN_URL_SCHEME > >Debug KProtocolInfo::isKnownProtocol("http") returning false. > >KProtocolInfoFactory::fillCache() should find plugins/kf5/kio/http.so and make

Re: konqueror5/Mac : kf5.kio.widgets: KonqRun(x) ERROR (stat): 111 "The file or folder http://www.kde.org/ does not exist."

Oh, and DrKonqi uses kio_http just fine. R.

D7237: KIO/Mac : make kiod5 an "agent"

rjvbb created this revision. rjvbb added a project: Frameworks. REVISION SUMMARY This introduces a similar change to kiod5 that was already made to other comparable background applications: 1 the LSUIElement InfoDict key is set, causing the application to run like an "agent" (without

D7237: KIO/Mac : make kiod5 an "agent"

rjvbb updated this revision to Diff 17997. rjvbb edited the summary of this revision. rjvbb added a comment. Forgot a `git add` indeed, as well as a final bit of proofreading. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7237?vs=17981=17997 REVISION DETAIL

D7237: KIO/Mac : make kiod5 an "agent"

rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7237 To: rjvbb, #frameworks, dfaure Cc: kde-mac, dfaure, #frameworks

D7237: KIO/Mac : make kiod5 an "agent"

rjvbb added a comment. In https://phabricator.kde.org/D7237#134438, @dfaure wrote: > Forgot to git add kiod_agent.mm? In fact, I see I have a comparable patch for kioslave, but simpler because AFAICT it won't ever put up a GUI itself. What would be an appropriate place in

D7237: KIO/Mac : make kiod5 an "agent"

rjvbb updated this revision to Diff 18037. rjvbb added a comment. I clearly didn't have my eyes aligned with their sockets ... this should finally be the complete patch. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7237?vs=17997=18037 REVISION DETAIL

D7237: KIO/Mac : make kiod5 an "agent"

rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7237 To: rjvbb, #frameworks, dfaure Cc: kde-mac, dfaure, #frameworks

D7237: KIO/Mac : make kiod5 an "agent"

This revision was automatically updated to reflect the committed changes. Closed by commit R241:088a0c67ccdc: make kiod5 an "agent" on Mac (authored by rjvbb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7237?vs=18037=18080#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D7283: WIP: KIO/Mac : move LaunchServices code to shared library and make kioslave an agent too

rjvbb created this revision. rjvbb added a project: Frameworks. REVISION SUMMARY As mentioned in https://phabricator.kde.org/D7237, the kioslave helper is also a candidate for being converted to a "nongui" agent. It thus makes sense to put the helper functions into a shared library, all the

Re: KF5Solid in subprefix and/or on [K]Ubuntu 14.04

On Thursday August 17 2017 10:11:35 David Faure wrote: >Maybe a missing devel package (optional dependency of solid) ? >Check the cmake output when configuring solid... The first thing I did of course ;) Everything appears to be there: -- The following features have been enabled: * Solid::Job,

Re: konqueror5/Mac : kf5.kio.widgets: KonqRun(x) ERROR (stat): 111 "The file or folder http://www.kde.org/ does not exist."

On Thursday August 10 2017 11:53:21 David Faure wrote: > > Will do. The http.so binary exists, loads (using a simple dlsym wrapper > > utility) and also has what looks to be the proper plugin info according to > > qtplugindump. > > Sounds like it's not found then, check Qt's plugin path (qmake

Re: KTitleWidget and the native Mac style

René J.V. Bertin wrote: > style. I think I figured out the how/where once but can't seem to find the > info anymore so I'd appreciate a pointer. Found it. > FWIW, drawing this kind of label in a frame and/or with a different background > colour isn't appropriate for the native Macintosh style.

Re: KTitleWidget and the native Mac style

On Tuesday July 04 2017 15:49:28 Kevin Funk wrote: >With regards to the "Widget Style and Behaviour" label in the `kcmshell5 >style` dialog: I don't find that particularly attracting under Breeze as well. > >It's too "bulky" for my taste. Indeed. I just notice that contrary to what you'd

Re: KTitleWidget and the native Mac style

On Tuesday July 04 2017 18:02:13 Hugo Pereira Da Costa wrote: > One should really consult with vdg here, since all these points (larger > fonts, padding, no frame), was already discussed with them, and agreed > upon, back in the days. As far as the official 1 or 2 KDE styles are concerned, I

Re: KTitleWidget and the native Mac style

Hi, How about this? In KWidgetAddons (out-commented code shows "stock" 5.35.0): KTitleWidget::KTitleWidget(QWidget *parent) : QWidget(parent), d(new Private(this)) { QFrame *titleFrame = new QFrame(this); // titleFrame->setAutoFillBackground(true); //

Re: KTitleWidget and the native Mac style

On Tuesday July 04 2017 20:16:55 Sebastian Kügler wrote: >The frame in my understanding is old weight, and can go (do check with the VDG I noticed it was already there in KDE4, indeed, though not usually rendered. >but to me, more importantly, reducing its size will >lead to regressions in

kpage titles and style

Hi, How/where is the rendering of "KPage" titles determined, like for instance the "Widget Style and Behaviour" label in the `kcmshell5 style` dialog? This appears to be a KF5-specific widget that's somehow under control of the widget style. I think I figured out the how/where once but can't

Re: KTitleWidget and the native Mac style

On Wednesday July 05 2017 10:58:59 Hugo Pereira Da Costa wrote: >No >the default is false (no frame): > >breeze.kcfg: > > > >false > > Curious, I've always seen Breeze display the frame, and never activated the option as far as I can remember. I did notice yesterday that breezerc doesn't

Re: KTitleWidget and the native Mac style

On Wednesday July 05 2017 09:55:27 Hugo Pereira Da Costa wrote: (CC'ing the plasma-devel ML and thus keeping Hugo's full reply as context.) >On 07/04/2017 11:13 PM, René J.V. Bertin wrote: >> On Tuesday July 04 2017 20:16:55 Sebastian Kügler wrote: >> >> @Kevin: should we continue to CC you? >>

konqueror5/Mac : kf5.kio.widgets: KonqRun(x) ERROR (stat): 111 "The file or folder http://www.kde.org/ does not exist."

Hi, Not sure where to ask about this: I recently upgraded to frameworks 5.35.0 and applications 17.04.2 . I don't think I tested konqueror5 with a remote website (on Mac), and discover today that it fails with terminal errors of the style kf5.kio.widgets: KonqRun(0x7f89f7dd9db0) ERROR (stat):

D7407: audiocd-kio : modernise debugging

rjvbb created this revision. REVISION SUMMARY Modernises the use of debugging classes in audiocd-kio (cf. https://phabricator.kde.org/D7380). I've named the category the way most kioslaves seem to name their categories, using the `kf5` toplevel domain rather than `org.kde` mostly because

libkcompactdisc test (testkcd) finds no tracks - wrong initialiser sent to the Phonon backend?

Hi, I'm not certain where to raise issues with libkcompactdisc, I hope this ML isn't the worst choice. I can't say I understand very well exactly how this library is suppose to integrate with Solid and the backends. It evidently works with the audiocd kio on Linux, but while trying to get

D7380: KCD: use modern logging classes throughout

rjvbb set the repository for this revision to R349 KCompactDisc Library. REPOSITORY R349 KCompactDisc Library REVISION DETAIL https://phabricator.kde.org/D7380 To: rjvbb, #frameworks

D7380: KCD: use modern logging classes throughout

rjvbb updated this revision to Diff 18325. rjvbb added a comment. missed 2 instances CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7380?vs=18323=18325 REVISION DETAIL https://phabricator.kde.org/D7380 AFFECTED FILES src/kcompactdisc.cpp src/kcompactdisc_p.cpp

D7380: KCD: use modern logging classes throughout

rjvbb created this revision. REVISION SUMMARY This change migrates libkcompactdisc to using modern logging for debugging purposes. It introduces a `cd` base category since a `cd.playlist` category existed already. An additional `cd.test` category is introduced in the testkcd utility,

Re: libkcompactdisc test (testkcd) finds no tracks - wrong initialiser sent to the Phonon backend?

On Friday August 18 2017 09:24:56 René J.V. Bertin wrote: >It looks to me like that could well be because it hands off a Solid UDI to >Phonon and from there to the VLC Phonon backend. I've lost track of the >control flow somewhere in there but I don't think Phonon knows how to handle >such

D7380: KCD: use modern logging classes throughout

rjvbb added a comment. Some thoughts, I'll update the patch later today. INLINE COMMENTS > ltoscano wrote in kcompactdisc_p.cpp:30 > On the other side, this is not a frameworks, but a generic library. I've seen > (and pushed) org.kde.[.] for applications. What could > it be a proper choice

D7380: KCD: use modern logging classes throughout

rjvbb added a comment. Simply because there's no quick and convenient other way for doing output in Qt, I think. But even then, if QPrint existed you'd be using it in testkcd but most likely not in the library itself and I'd still propose to activate debug output from the library in

D7380: KCD: use modern logging classes throughout

rjvbb updated this revision to Diff 18344. rjvbb added a comment. Updated as discussed. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7380?vs=18325=18344 REVISION DETAIL https://phabricator.kde.org/D7380 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt

D7380: KCD: use modern logging classes throughout

rjvbb set the repository for this revision to R349 KCompactDisc Library. REPOSITORY R349 KCompactDisc Library REVISION DETAIL https://phabricator.kde.org/D7380 To: rjvbb, #frameworks, davidedmundson, ltoscano Cc: ltoscano, davidedmundson

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

rjvbb created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY A recent commit disabled support for named (logical) operators (and, not, bitand, ) when using GCC, Clang or ICC. This patch adds a function to (re)enable them in a cross-platform

Re: Problem solved ([vlc] Qt4 plugin into Qt5 program)

On Wednesday May 17 2017 11:45:08 Rex Dieter wrote: >> Distro packaging should ensure that vlc-cache-gen is run every time the >> software gets installed or updated. This is also something that could be handled on our side, if KDE/Plasma is indeed the only environment where VlC's plugin

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

rjvbb updated this revision to Diff 14635. rjvbb marked an inline comment as done. rjvbb added a comment. This update hopefully introduces the appropriate check for MSVC 2015 update 3 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5865?vs=14548=14635 REVISION DETAIL

<    2   3   4   5   6   7   8   9   10   11   >