rjvbb added a comment.
You're still determining the location from the path with this new revision,
right?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: pino,
rjvbb added a comment.
In https://phabricator.kde.org/D3830#72701, @pino wrote:
> The full path of gperf is determined using `find_program`, which looks in
`$PATH` -- you can always specify the variable with the full path to force a
custom location.
great, that's exactly what I
rjvbb added a comment.
In https://phabricator.kde.org/D3830#72508, @pino wrote:
> For the input file? Yes.
I did mean the gperf executable...!
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
EMAIL PREFERENCES
rjvbb added a comment.
In https://phabricator.kde.org/D3830#71722, @pino wrote:
> Windows and Mac people: at least from a quick glance, GNU gperf should be
already available on Windows and Mac
I can only speak for 10.9 but indeed, gperf is available in /usr/bin .
REPOSITORY
rjvbb retitled this revision from "Provide demo/preview for checkable menu
items and colour scheme comparison" to "Provide demo/preview for checkable menu
items".
rjvbb edited the summary of this revision.
rjvbb edited the test plan for this revision.
rjvbb set the repository for this revision
rjvbb updated this revision to Diff 15812.
rjvbb added a comment.
Updated for 5.10.2+
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5111?vs=12788=15812
REVISION DETAIL
https://phabricator.kde.org/D5111
AFFECTED FILES
kstyle/demo/main.cpp
kstyle/demo/oxygendemodialog.cpp
rjvbb added a comment.
A priori this should be fine, and it might even address the long standing bug
by leaving more time for Phonon objects to "do their thing". It might be an
idea though to include a `qCDebug()` probe that outputs the number of items
left for auto-cleanup in
rjvbb added a comment.
In https://phabricator.kde.org/D6376#119376, @cullmann wrote:
> Next try ;=)
> Question is, can really such a race happen, that finishNotification
triggers duplicate insertion?
Do you see any other explanation why a crash could occur under qDeleteAll,
rjvbb added a comment.
> Hmm, not really
Not really what?
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D6376
To: cullmann, #frameworks
Cc: rjvbb
rjvbb added a comment.
In https://phabricator.kde.org/D6376#119500, @cullmann wrote:
> I don't speak about threading races. The whole class is not thread-safe, if
threading occurs, all is lost.
Really? Only a single thread at a time should trigger audio notifications, is
that
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:ac5cbf6b4aa9: More details about deploying icon themes on
Mac & MSWin (authored by rjvbb).
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6309?vs=15694=15775
rjvbb added a comment.
Ben Cooksley wrote on 20170623::09:17:33 re:
"https://phabricator.kde.org/D6309: KIconThemes: some additional details about
themes & icons on Mac & MSWin"
> The system has now polled the repository and the hook has correspondingly
been triggered.
I see.
rjvbb added a comment.
Well, somehow this wasn't closed automatically:
https://commits.kde.org/kiconthemes/ac5cbf6b4aa969542a780077213cb39a4c110fe6
> Arguably, this is not the place where I would have looked for an answer to
that question, first, but since it does provide an answer, it
13 matches
Mail list logo
