Re: Review Request 125800: OS X build and warning fix

2015-10-27 Thread Samuel Gaist
: https://git.reviewboard.kde.org/r/125800/diff/ Testing --- Build on OS X 10.8 Check that qcatool-qt5 keystore list-stores returns the same results Thanks, Samuel Gaist ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 125800: OS X build and warning fix

2015-10-26 Thread Samuel Gaist
on OS X 10.8 Check that qcatool-qt5 keystore list-stores returns the same results Thanks, Samuel Gaist ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125025: eps: fix includes related to Qt Caterogized Logging

2015-09-01 Thread Samuel Gaist
--- Build on OS X 10.8 Thanks, Samuel Gaist ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125025: eps: fix includes related to Qt Caterogized Logging

2015-09-03 Thread Samuel Gaist
55d15a207418b90c91f46f36f36f36bce7406385 Diff: https://git.reviewboard.kde.org/r/125025/diff/ Testing --- Build on OS X 10.8 Thanks, Samuel Gaist ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-07 Thread Samuel Gaist
his will also require patching of the frameworks but will allow to disable it globally when needed ? - Samuel --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125083/#review84

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-07 Thread Samuel Gaist
/125083/diff/ Testing --- Build on OS X 10.8 Thanks, Samuel Gaist ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-06 Thread Samuel Gaist
Description --- This avoids trying to detect X11 packages that might be installed on OS X Diffs - CMakeLists.txt 3460224eb895b2295b6e7ee66dd8258da5ec2b91 Diff: https://git.reviewboard.kde.org/r/125083/diff/ Testing --- Build on OS X 10.8 Thanks, Samuel Gaist

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-08 Thread Samuel Gaist
ild-oddities. Please have a look at the > > bigger picture and think about a general solution on how to disable X11 > > without having to (stupidly) patch all frameworks. > > Samuel Gaist wrote: > Hi, > > Sorry for that mistake. > > What abo

Re: Review Request 125070: Setup and install dbus interfaces for all platforms since dbus is a mandatory component.

2015-09-06 Thread Samuel Gaist
--- Build on OS X 10.8 Thanks, Samuel Gaist ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125252: Clean X11/XCB detection

2015-09-15 Thread Samuel Gaist
10.8 Thanks, Samuel Gaist ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-11 Thread Samuel Gaist
ild-oddities. Please have a look at the > > bigger picture and think about a general solution on how to disable X11 > > without having to (stupidly) patch all frameworks. > > Samuel Gaist wrote: > Hi, > > Sorry for that mistake. > > What abo

Re: Review Request 125800: OS X build and warning fix

2015-12-08 Thread Samuel Gaist
9349c90c8258d3d1f00a3796d93f94c09f5b1f2a Diff: https://git.reviewboard.kde.org/r/125800/diff/ Testing --- Build on OS X 10.8 Check that qcatool-qt5 keystore list-stores returns the same results Thanks, Samuel Gaist ___ Kde-frameworks-devel mailing

Re: Review Request 126285: OS X build and warning fix

2015-12-08 Thread Samuel Gaist
c09f5b1f2a Diff: https://git.reviewboard.kde.org/r/126285/diff/ Testing --- Thanks, Samuel Gaist ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126285: OS X build and warning fix

2016-05-10 Thread Samuel Gaist
e has been removed by commit f223ce03d4b94ffbb093fc8be5adf8d968f54434 Diffs (updated) - cmake/modules/FindCoreFoundation.cmake c08e529ceec337c085f2f650f180b4e7897246bb Diff: https://git.reviewboard.kde.org/r/126285/diff/ Testing --- Thanks, Sa

Re: Review Request 126285: OS X build and warning fix

2016-05-10 Thread Samuel Gaist
- Samuel --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/#review95174 --- On April 29, 2016, 11:59 a.m., Samuel Ga

Re: Review Request 126285: OS X build and warning fix

2016-10-20 Thread Samuel Gaist
marked as submitted. Review request for KDE Software on Mac OS X, KDE Frameworks and Ivan Čukić. Changes --- Submitted with commit 7ba0ee591e0f50a7e7b532f9eb7e500e7da784fb by Albert Astals Cid on behalf of Samuel Gaist to branch master. Repository: qca Description --- Revert &quo

Re: Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-08 Thread Samuel Gaist
> On 8 Jan 2017, at 19:09, René J.V. Bertin wrote: > > So... > > It seems we are indeed looking at a Qt regression. > > https://github.com/RJVB/shortcut-test-qt5 > > > That's an adapted version of Qt's menus example which adds a shortcut test > action with a