D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham updated this revision to Diff 44712. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=44710=44712 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, elvisangelaccio, #frameworks, bruns Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)
shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) " to "Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB) ". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks, bruns Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)
shubham updated this revision to Diff 44710. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=44688=44710 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, elvisangelaccio, #frameworks, bruns Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)
shubham updated this revision to Diff 44688. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=43938=44688 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, elvisangelaccio, #frameworks, bruns Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)
shubham added a comment. Can I get a review? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)
shubham added a comment. @bruns Apart from these, does the code seems sane to you? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)
shubham updated this revision to Diff 43938. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=43930=43938 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)
shubham added a comment. @ngraham No, please recheck, the check is before the first m_totalSize > m_freeSpace check REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)
shubham updated this revision to Diff 43930. shubham marked 5 inline comments as done. shubham added a comment. File size limit check for a given file system before (m_totalSize > m_freeSpace) check REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=43895=43930 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)
shubham added inline comments. INLINE COMMENTS > ngraham wrote in job_error.cpp:253 > Unrelated and incorrect change: `https` is correct here, so please revert. That was my previous commit where I changed http -> https. Don't know why it affected my local branch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)
shubham updated this revision to Diff 43895. shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system" to "Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) ". REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=43894=43895 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system
shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system
shubham updated this revision to Diff 43894. shubham added a comment. Cache file system time instead of creating it every time REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=43890=43894 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system
shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system
shubham updated this revision to Diff 43890. shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System" to "Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system". REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=43735=43890 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System
shubham added a comment. Is there any predefined function which returns the file size limit for a given file system? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size of in a File System
shubham retitled this revision from "Warn user before copy/move job if required space exceeds the maximum volume size of a File System" to "Warn user before copy/move job if the file size exceeds the maximum possible file size of in a File System". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System
shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size of in a File System" to "Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System
shubham added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System
shubham added a reviewer: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System
shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System
shubham created this revision. shubham added a reviewer: ngraham. shubham added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. shubham requested review of this revision. REVISION SUMMARY BUG: 198772 TEST PLAN 1.Prepare copy/move job. 2. Copy/move the contents to external USB drive/ Pen drive Result: Inline error message appears. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D16141: Disable unmount option for / or /home
shubham added inline comments. INLINE COMMENTS > kfileplacesview.cpp:33 > +#include > > #include Move this header up > kfileplacesview.cpp:54 > +#include > > #include "kfileplaceeditdialog_p.h" Move the header up, to its appropriate position letter wise. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16141 To: thsurrel, #frameworks, ngraham Cc: shubham, ngraham, kde-frameworks-devel, michaelh, bruns
D14449: Modify device usage information
shubham added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: ngraham, pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, bruns
D14449: Modify device usage information
shubham added a comment. won't the pie chart representation look good, as we have in windows? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D15645: [WIP] Add scheme selection menu with a "System" entry.
shubham added inline comments.
INLINE COMMENTS
> kcolorschememanager.cpp:39
>
> +KActionMenu* KColorSchemeManagerPrivate::createSchemeMenu(const QIcon ,
> const QString , const QString , bool defaultEntry,
> QObject *parent)
> +{
KActionMenu* -> KActionMenu *
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D15645
To: amhndu, #frameworks
Cc: shubham, ngraham, broulik, kde-frameworks-devel, michaelh, bruns
D15557: Improve "insufficient disk space" error messgae
shubham added a comment. Maybe "Dont have enough space available on the disk" REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc: broulik, abetts, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham added a comment. Sorry for that, will take care of that in future. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham added a comment. @ngraham I thought those "request changes" were against my prior diffs REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
D14757: Warn user before copy/move operation if available space is not enough
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:5a48bd21212c: Warn user before copy/move operation if available space is not enough (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41765=41792 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
D15557: Improve "insufficient disk space" error messgae
shubham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham updated this revision to Diff 41765. shubham added a comment. addressed broulik's comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41764=41765 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham updated this revision to Diff 41764. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41761=41764 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham updated this revision to Diff 41761. shubham added a comment. done above requested change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41751=41761 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham updated this revision to Diff 41751. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41747=41751 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham updated this revision to Diff 41747. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41746=41747 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham updated this revision to Diff 41746. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41655=41746 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy/move operation if available space is not enough
shubham retitled this revision from "Warn user before copy operation if available space is not enough" to "Warn user before copy/move operation if available space is not enough". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy operation if available space is not enough
shubham updated this revision to Diff 41655. shubham edited reviewers, added: broulik; removed: cfeck. shubham added a comment. Done above requested changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=39531=41655 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik, cfeck Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy operation if available space is not enough
shubham added inline comments. INLINE COMMENTS > pino wrote in copyjob.cpp:891 > Uninitialized pointer, this will crash two lines later... > Also, this is the base class of the private class used for this job, and this > function is part of that class already; so why aren't you just invoking it? which class you are talking about? requestMessageBox() exists only in simpleJobPrivate, jobUiDelegate and jobUiDelegateExtension REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, cfeck Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy operation if available space is not enough
shubham added a comment. @dfaure @pino help? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, cfeck Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D15127: Fix typos for "Show line count"
This revision was automatically updated to reflect the committed changes. Closed by commit R39:4c43ab238ec2: Fix typos for Show line count (authored by shubham). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15127?vs=40564=40575 REVISION DETAIL https://phabricator.kde.org/D15127 AFFECTED FILES src/dialogs/katedialogs.cpp src/dialogs/textareaappearanceconfigwidget.ui src/utils/kateconfig.cpp src/utils/kateconfig.h src/view/katestatusbar.cpp To: shubham, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann
D15127: Fix typos for "Show line count"
shubham added a comment. Going to land this now REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15127 To: shubham, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann
D15127: Fix typos for "Show line count"
shubham updated this revision to Diff 40564. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15127?vs=40563=40564 REVISION DETAIL https://phabricator.kde.org/D15127 AFFECTED FILES src/dialogs/katedialogs.cpp src/dialogs/textareaappearanceconfigwidget.ui src/utils/kateconfig.cpp src/utils/kateconfig.h src/view/katestatusbar.cpp To: shubham, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann
D15127: Fix typos for "Show line count"
shubham edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15127 To: shubham, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann
D15127: Fix typos for "Show line count"
shubham created this revision. shubham added reviewers: cullmann, vkrause. shubham added projects: KTextEditor, Frameworks. Herald added a project: Kate. Herald added subscribers: kde-frameworks-devel, kwrite-devel. shubham requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15127 AFFECTED FILES src/dialogs/katedialogs.cpp src/dialogs/textareaappearanceconfigwidget.ui src/utils/kateconfig.cpp src/utils/kateconfig.h src/view/katestatusbar.cpp To: shubham, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann
D15000: Display mounted file system type and mounted from fields in properties dialog
This revision was automatically updated to reflect the committed changes. Closed by commit R241:9e706796b152: Display mounted file system type and mounted from fields in properties dialog (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40397=40468 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik, ngraham, #frameworks, cfeck Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
D15000: Display mounted file system type and mounted from fields in properties dialog
shubham added a comment. @cfeck @broulik any comments on this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik, ngraham, #frameworks, cfeck Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
D14449: Modify device usage information
shubham added a comment. You plz proceed on it. Right now working on some other patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D14449: Modify device usage information
shubham added a comment. In D14449#315524 <https://phabricator.kde.org/D14449#315524>, @ngraham wrote: > Do you plan to submit a new version of this after the layout has been converted to use `QFormLayout`? I do hope some form of this patch makes it in, since IMHO it's a nice little quality-of-life improvement. Sure REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D15000: Display mounted file system type and mounted from fields in properties dialog
shubham added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik, ngraham Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
D15000: Display mounted file system type and mounted from fields in properties dialog
shubham retitled this revision from "Display mounted file system type in properties dialog" to "Display mounted file system type and mounted from fields in properties dialog". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik, ngraham Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
D15000: Display mounted file system type in properties dialog
shubham added a comment. Move Mounted from into conditional. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik, ngraham Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
D15000: Display mounted file system type in properties dialog
shubham updated this revision to Diff 40397. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40312=40397 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik, ngraham Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
D15000: Display mounted file system type in properties dialog
shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
D15000: Display mounted file system type in properties dialog
shubham updated this revision to Diff 40312. shubham added a comment. Add mounted from label REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40236=40312 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
D15000: Display mounted file system type in properties dialog
shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
D15000: Display mounted file system type in properties dialog
shubham added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
D15000: Display mounted file system type in properties dialog
shubham updated this revision to Diff 40236. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40233=40236 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D15000: Display mounted file system type in properties dialog
shubham added a comment. 1. use KMountPoint::mountPoint() 2. Move everything into isLocal REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D15000: Display mounted file system type in properties dialog
shubham updated this revision to Diff 40233. shubham edited the summary of this revision. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40219=40233 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D15000: Display mounted file system type in properties dialog
shubham edited the summary of this revision. shubham added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D15000: Display mounted file system type in properties dialog
shubham removed a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D15000: Display mounted file system type in properties dialog
shubham updated this revision to Diff 40219. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40217=40219 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D15000: Display mounted file system type in properties dialog
shubham added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D15000: Display mounted file system type in properties dialog
shubham created this revision. shubham added a reviewer: dfaure. shubham added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY F6209381: Screenshot_20180822_173758.png <https://phabricator.kde.org/F6209381> TEST PLAN Open properties dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy operation if available space is not enough
shubham added inline comments. INLINE COMMENTS > pino wrote in copyjob.cpp:909 > The return value is `JobUiDelegateExtension::MessageBoxType`, not > `KMessageBox::ButtonCode`. There is no enum for Button Code inside JobUiDelegatextension. So how to take that into consideration? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, cfeck Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14449: Modify device usage information
shubham abandoned this revision. shubham added a comment. Actually should be implemented using form layout REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy operation if available space is not enough
shubham added a reviewer: cfeck. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, cfeck Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy operation if available space is not enough
shubham added a comment. A question requestMessageBox( ) is a "pure virtual" function inside "jobUiDelegateExtension" class which is implemented in "jobUiDelegate" class which is the derived class of "jobUiDelegateExtension". When I resolve requestMessageBox() using : : like this (jobUiDelegate::), I get an error saying jobUiDelegate has not been declared , to correct the problem when I #include it shows unknown file/directory. what's actually the problem? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy operation if available space is not enough
shubham edited reviewers, added: dfaure; removed: broulik, ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy operation if available space is not enough
shubham updated this revision to Diff 39531. shubham added a comment. use simpleJobPrivate REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=39492=39531 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/CMakeLists.txt src/core/copyjob.cpp To: shubham, pino, dfaure Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy operation if available space is not enough
shubham added a comment. @dfaure is it that message boxes cant be used in non gui library as suggested by pino. Is there any harm in using kmessagebox instead? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, broulik, ngraham, pino Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy operation if available space is not enough
shubham added a comment. In D14757#306938 <https://phabricator.kde.org/D14757#306938>, @pino wrote: > Also, considering this is in a job in `KIOCore` (i.e. non-gui library), I suspect that using a message box directly is the wrong way to do it. @dfaure what is your opinion on that? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, broulik, ngraham, pino Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy operation if available space is not enough
shubham added a comment. In D14757#306938 <https://phabricator.kde.org/D14757#306938>, @pino wrote: > Also, considering this is in a job in `KIOCore` (i.e. non-gui library), I suspect that using a message box directly is the wrong way to do it. Most probably you need to use the UI delegate of the job for this. you mean to use KIO/JobUiDelegate ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, broulik, ngraham, pino Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
D14757: Warn user before copy operation if available space is not enough
shubham created this revision. shubham added reviewers: broulik, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/CMakeLists.txt src/core/copyjob.cpp To: shubham, broulik, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14648: Make read-only filenames selectable
shubham accepted this revision. shubham added a comment. This revision is now accepted and ready to land. Oh, forgot to do that in R241:e2c56f6ddc517bc4915ab3c84971d17054225c76 <https://phabricator.kde.org/R241:e2c56f6ddc517bc4915ab3c84971d17054225c76>. REPOSITORY R241 KIO BRANCH selectable-read-only-filename (branched from master) REVISION DETAIL https://phabricator.kde.org/D14648 To: ngraham, shubham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14610: Use KLineEdit for folder name if folder has write access, else use QLabel
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e2c56f6ddc51: Use KLineEdit for folder name if folder has write access, else use QLabel (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14610?vs=39164=39166 REVISION DETAIL https://phabricator.kde.org/D14610 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, rkflx, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14610: Use KLineEdit for folder name if folder has write access, else use QLabel
shubham updated this revision to Diff 39164. shubham added a comment. Add check for bFromTemplate simplify expression (!d->m_bFromTemplate && !itemList.supportsMoving()) to !(d->m_bFromTemplate || itemList.supportsMoving()) for better readability REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14610?vs=39163=39164 REVISION DETAIL https://phabricator.kde.org/D14610 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, rkflx, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14610: Use KLineEdit for folder name if folder has write access, else use QLabel
shubham updated this revision to Diff 39163. shubham added a comment. Re factor Remove unnecessary indentations use only !itemList.supportsMoving() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14610?vs=39112=39163 REVISION DETAIL https://phabricator.kde.org/D14610 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, rkflx, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14610: Use KLineEdit for folder name if folder has write access, else use QLabel
shubham added a comment. In D14610#303706 <https://phabricator.kde.org/D14610#303706>, @rkflx wrote: > In D14610#303537 <https://phabricator.kde.org/D14610#303537>, @rkflx wrote: > > > `KPropertiesDialog::setFileNameReadOnly` > > `m_bFromTemplate` > > > @shubham Any comments on that (see my questions to @dfaure above)? sorry, don't know about it INLINE COMMENTS > rkflx wrote in kpropertiesdialog.cpp:988 > Without your patch, we only tested for `!itemList.supportsMoving()`. Now you > also test for `(itemList.isDirectory() & !itemList.supportsWriting()`. Could > you explain in what cases we need that new test? As far as I can see this > blocks renaming the folder you removed the write permission from (while only > its children should be prevented from being renamed). > > (`&` instead of `&&` also caught my eye.) this test was intended for blocking directories without write access to rename , but as you say it should be done to it's child I missed that one & by mistake REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14610 To: shubham, rkflx, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14449: Modify device usage information
shubham added a comment. In D14449#300327 <https://phabricator.kde.org/D14449#300327>, @ngraham wrote: > +1 for using the same label but putting the information on more than one line like @rkflx suggests. sorry for causing trouble : ( REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D14449: Modify device usage information
shubham added a comment. In D14449#303710 <https://phabricator.kde.org/D14449#303710>, @rkflx wrote: > - The vertical spacing between the first and the second line is too big, it should be the same as for Size:. is there any other simpler way to achieve this? INLINE COMMENTS > rkflx wrote in kpropertiesdialog.cpp:1184-1186 > That's a bit odd: Why would you have to query that information here again, if > in the original implementation it is already available? > > Perhaps all calls to `setText` should take place only in one part of the > code, e.g. `slotFreeSpaceResult`. If all function calls to setText are to take place inside slotFreeSpaceResult, then we will need to make a new QLabel, so we can't re-use it(which is the main point as @ngraham had earlier said) > rkflx wrote in kpropertiesdialog.cpp:1279 > I don't think we can set a maximum width for the complete bar, because it can > conflict with languages with longer translations. > > More importantly, for the Oxygen widget style the text in a `KCapacityBar` > might be drawn inline and the bar should span the complete width of the > dialog, so I don't think we should fiddle too much with the sizes of > `m_capacityBar` or its sub-components. > > I guess we have to live with the longer bar for Breeze, which could already > become quite long without your patch if you resized the dialog. For other > languages it is also less of an issue. so we need to remove setMaximumWidth() ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D14449: Modify device usage information
shubham edited reviewers, added: rkflx; removed: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx, elvisangelaccio Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D14449: Modify device usage information
shubham updated this revision to Diff 39120. shubham added a comment. F6176187: 2.png <https://phabricator.kde.org/F6176187> @rkflx is this okay now? REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14449?vs=38784=39120 REVISION DETAIL https://phabricator.kde.org/D14449 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, elvisangelaccio, ngraham, #frameworks Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D14449: Modify device usage information
shubham added a comment. > Not if you set a maximum width. @rkflx eeh, skipped from my mind btw , then it is doable REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, elvisangelaccio, ngraham, #frameworks Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D14449: Modify device usage information
shubham added a comment. > Let me plug my suggestion again: > > Device capacity: ==- 24% used of 94.4 Gib >22.5 GiB used, 71.9 GiB free > if this design is used , then the capacity bar would look elongated and stretched, which doesn't looks good. Since used space is not of that much importance, so we can just omit it like this Device capacity: ===> 24% full of 90GiB (70GiB free) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, elvisangelaccio, ngraham, #frameworks Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D14610: Use KLineEdit for folder name if folder has write access, else use QLabel
shubham updated this revision to Diff 39112. shubham added a comment. Re-use Qlabel REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14610?vs=39082=39112 REVISION DETAIL https://phabricator.kde.org/D14610 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, rkflx, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14609: Do not return reference
This revision was automatically updated to reflect the committed changes. Closed by commit R241:65f56f12aa7f: Do not return reference (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14609?vs=39097=39099 REVISION DETAIL https://phabricator.kde.org/D14609 AFFECTED FILES src/filewidgets/kfileplaceeditdialog.cpp src/filewidgets/kfileplaceeditdialog_p.h To: shubham, ngraham, cfeck, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D14609: Do not return reference
shubham added a comment. using arc land --rev id, arc gives error saying Audit Failure : Non full name REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14609 To: shubham, ngraham, cfeck, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D14609: Do not return reference
shubham added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14609 To: shubham, ngraham, cfeck, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D14609: Do not return reference
shubham updated this revision to Diff 39097. shubham added a comment. Remove **cons**t REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14609?vs=39078=39097 REVISION DETAIL https://phabricator.kde.org/D14609 AFFECTED FILES src/filewidgets/kfileplaceeditdialog.cpp src/filewidgets/kfileplaceeditdialog_p.h To: shubham, ngraham, cfeck Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
D14610: Use KLineEdit if folder has write access, else use QLabel
shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14610 To: shubham, rkflx, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14610: Use KLineEdit for folder name if folder has write access, else use QLabel
shubham retitled this revision from "Use KLineEdit if folder has write access, else use QLabel" to "Use KLineEdit for folder name if folder has write access, else use QLabel". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14610 To: shubham, rkflx, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D14610: Use KLineEdit if folder has write access, else use QLabel
shubham updated this revision to Diff 39082. shubham retitled this revision from "Make KLineEdit read only if write access is denied" to "Use KLineEdit if folder has write access, else use QLabel". shubham edited the summary of this revision. shubham edited the test plan for this revision. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14610?vs=39079=39082 REVISION DETAIL https://phabricator.kde.org/D14610 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, rkflx, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
