This revision was automatically updated to reflect the committed changes.
Closed by commit R241:92ba7545763b: [kcm trash] Change kcm trash size percent
to 2 decimal places (authored by shubham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29513?vs=82221=82345
shubham created this revision.
shubham added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REVISION SUMMARY
This patch changes the precision from 3 decimal places to 2
TEST PLAN
Go
shubham added a comment.
@broulik @ngraham Any updates on this, how to proceed?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26650
To: shubham, broulik, ngraham
Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2,
michaelh, ngraham, bruns
shubham marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26650
To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
shubham updated this revision to Diff 73593.
shubham added a comment.
Make requested changes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26650?vs=73556=73593
BRANCH
filelight
REVISION DETAIL
https://phabricator.kde.org/D26650
AFFECTED FILES
src
shubham marked 3 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26650
To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
shubham marked 3 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26650
To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
shubham updated this revision to Diff 73556.
shubham added a comment.
Use desciptive variable name
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26650?vs=73535=73556
BRANCH
filelight
REVISION DETAIL
https://phabricator.kde.org/D26650
AFFECTED FILES
shubham updated this revision to Diff 73535.
shubham added a comment.
Use KService to get the application's icon
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26650?vs=73483=73535
BRANCH
filelight
REVISION DETAIL
https://phabricator.kde.org/D26650
shubham added inline comments.
INLINE COMMENTS
> broulik wrote in kpropertiesdialog.cpp:1113
> You can also use the icon from the service
I tried removing it, but I couldn't see the icon on the button then.
> anthonyfieroni wrote in kpropertiesdialog.cpp:1455
> service can be
shubham abandoned this revision.
shubham added a comment.
Abandoned infavour of D26650 <https://phabricator.kde.org/D26650>
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks, broulik
Cc: broulik, ltoscano, pino, kde-frameworks
shubham created this revision.
shubham added reviewers: broulik, ngraham.
shubham added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
shubham requested review of this revision.
REVISION SUMMARY
Related to D24932 <https://phabricator.kde.
shubham added a comment.
@broulik I believe this is what you wanted?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks, broulik
Cc: broulik, ltoscano, pino, kde-frameworks-devel, #frameworks, LeGast00n,
GB_2, michaelh, ngraham
shubham updated this revision to Diff 73376.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24932?vs=72263=73376
REVISION DETAIL
https://phabricator.kde.org/D24932
AFFECTED FILES
src/widgets/kpropertiesdialog.cpp
To: shubham, ngraham, #frameworks, broulik
shubham closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26265
To: shubham, ngraham, pino
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham added a comment.
@pino @ngraham Fixed here https://phabricator.kde.org/D26265.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: pino, kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh,
ngraham, bruns
shubham created this revision.
shubham added reviewers: ngraham, pino.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REVISION SUMMARY
Depends upon D24932 <https://phabricator.kde.org/D24932>
REPOSITORY
R2
shubham closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham updated this revision to Diff 72263.
shubham added a comment.
Remove the use of variable
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24932?vs=72261=72263
BRANCH
file
REVISION DETAIL
https://phabricator.kde.org/D24932
AFFECTED FILES
src
shubham retitled this revision from "Add Button to open the folder in filelight
for more details" to "Add Button to open the folder in filelight to view more
details".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham,
shubham retitled this revision from "Add Button to open the folder in filelight
to view more details" to "Add button to open the folder in filelight to view
more details".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham,
shubham updated this revision to Diff 72261.
shubham edited the summary of this revision.
shubham added a comment.
Fix whitespaces and crash condition
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24932?vs=72254=72261
BRANCH
file
REVISION DETAIL
https
shubham marked 9 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham retitled this revision from "[WIP]: Add Button to open the folder in
filelight for more details" to "Add Button to open the folder in filelight for
more details".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham,
shubham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham edited the summary of this revision.
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham updated this revision to Diff 72254.
shubham marked 2 inline comments as done.
shubham edited the summary of this revision.
shubham added a comment.
Fix above mentioned issues, now works perfectly fine
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
shubham added a comment.
@ngraham How should I create a KService for runApplication?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham added inline comments.
INLINE COMMENTS
> ngraham wrote in kpropertiesdialog.cpp:1100
> This is a `QPushButton`, so connect to `::clicked`
It is done this way a bit below in line 1106
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, n
shubham marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham updated this revision to Diff 68759.
shubham marked 3 inline comments as done.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24932?vs=68710=68759
REVISION DETAIL
https://phabricator.kde.org/D24932
AFFECTED FILES
src/widgets/kpropertiesdialog.cpp
shubham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham created this revision.
shubham added reviewers: ngraham, Frameworks.
shubham added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REVISION SUMMARY
BUG: 408962
Note: Does not compile on my machine due to system
shubham added a comment.
It is not a good practice to "goto" in C++
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D24492
To: hurikhan77, #baloo
Cc: shubham, kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2,
domson, ashaposhnikov, michaelh,
shubham added a reviewer: broulik.
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D23193
To: shubham, #frameworks, ngraham, broulik
Cc: #frameworks, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham added a comment.
In D23193#513023 <https://phabricator.kde.org/D23193#513023>, @ngraham wrote:
> I can't get the new currency to actually show up in KRunner when I test the
patch. Does it work for you?
It did worked before when I uploaded the patch first time, no
shubham updated this revision to Diff 64488.
shubham added a comment.
Move currency to its proper place alphabetically
REPOSITORY
R292 KUnitConversion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23193?vs=63838=64488
BRANCH
currency
REVISION DETAIL
https
shubham added reviewers: Frameworks, ngraham.
shubham added a subscriber: Frameworks.
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D23193
To: shubham, #frameworks, ngraham
Cc: #frameworks, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
shubham created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REVISION SUMMARY
FEATURE: 339448
REPOSITORY
R292 KUnitConversion
BRANCH
currency
REVISION DETAIL
https://phabricator.kde.org
shubham retitled this revision from "Change restoration icon" to "Modify
restoration icon to make it look like something is being restored from the
trash".
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23077
To: shubham, #vdg, ndavis
Cc: ngr
shubham edited the summary of this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23077
To: shubham, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
shubham edited the test plan for this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23077
To: shubham, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
shubham added a reviewer: VDG.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D23077
To: shubham, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
shubham created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23077
AFFECTED FILES
icons/actions/22
shubham abandoned this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18563
To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure,
elvisangelaccio, pino, kde-frameworks-devel
shubham abandoned this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18599
To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
shubham abandoned this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18384
To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, LeGast00n, michaelh,
ngraham, bruns
shubham added inline comments.
INLINE COMMENTS
> notifybysnore.h:44
> +QHash> m_notifications;
> +QString program = QStringLiteral("SnoreToast.exe");
> +QLocalServer server;
I doubt this compiles...You can't initialise variables inside the class
REPOSIT
shubham added a comment.
Does this function had any use when it was first implemented? Or may it come
to use later?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21692
To: bruns, #baloo, ngraham, astippich, poboiko
Cc: shubham, kde-frameworks-devel, LeGast00n
shubham updated this revision to Diff 58369.
shubham added a comment.
-
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20626?vs=58354=58369
BRANCH
sysinfo
REVISION DETAIL
https://phabricator.kde.org/D20626
AFFECTED FILES
src/kcms/kio/useragentinfo.cpp
shubham added a comment.
@dfaure Would you mind commiting it, I think I just messes up my ssh keys
REPOSITORY
R241 KIO
BRANCH
arcpatch-D20626
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham updated this revision to Diff 58354.
shubham edited the summary of this revision.
shubham added a comment.
proper rebase
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20626?vs=58351=58354
BRANCH
arcpatch-D20626
REVISION DETAIL
https
shubham retitled this revision from "Refactor and cleanup" to "Rely upon
QSysInfo to retrieve the system details".
shubham edited the summary of this revision.
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
BRANCH
arcpatch-D20626
REV
shubham updated this revision to Diff 58351.
shubham edited the summary of this revision.
shubham edited the test plan for this revision.
shubham added a comment.
Rely upon QSysInfo to retrieve the system details
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham updated this revision to Diff 57356.
shubham added a comment.
constantanize permissions
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20735?vs=57355=57356
BRANCH
octal
REVISION DETAIL
https://phabricator.kde.org/D20735
AFFECTED FILES
src
shubham updated this revision to Diff 57355.
shubham added a comment.
No type casting
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20735?vs=56979=57355
BRANCH
octal
REVISION DETAIL
https://phabricator.kde.org/D20735
AFFECTED FILES
src/ioslaves
shubham marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20735
To: shubham, ngraham, pino, #vdg
Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham added a comment.
Ping?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20735
To: shubham, ngraham, pino, #vdg
Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20735
To: shubham, ngraham, pino
Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20735
To: shubham, ngraham, pino
Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham updated this revision to Diff 56979.
shubham added a comment.
1. Use mode_t to get the permissions
2. Position the octal permissions inside "Advanced Permissions" tab
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20735?vs=56735=56979
BRAN
shubham added a comment.
@dfaure Ping?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham added a comment.
In D20735#454263 <https://phabricator.kde.org/D20735#454263>, @pino wrote:
> Tried to print it as octal-based value?
No, now I get that those permissions were base 10.
How to print it as octal?
REPOSITORY
R241 KIO
REVISION DETAI
shubham added a comment.
I had used permission() to get the mode_t variable, which I later type casted
to qint64, still the permissions resulted were completed wrong.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20735
To: shubham, ngraham, pino
Cc: pino, kde
shubham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20735
To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20735
To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
shubham created this revision.
shubham added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REVISION SUMMARY
This patch adds file permissions shown in octal format to the
KPropertiesDialog
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:b63c2a236faf: Fix no member named setTime_t
in QDateTime error while building (authored by shubham).
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20691?vs=56627
shubham updated this revision to Diff 56627.
shubham added a comment.
Fix unintentional mode change
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20691?vs=56609=56627
BRANCH
error
REVISION DETAIL
https://phabricator.kde.org/D20691
AFFECTED FILES
shubham edited the summary of this revision.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D20691
To: shubham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
shubham created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REVISION SUMMARY
BUG: 405554
REPOSITORY
R245 Solid
BRANCH
error
REVISION DETAIL
https://phabricator.kde.org/D20691
AFFECTED
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20626
To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
shubham abandoned this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20639
To: shubham, dfaure, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
shubham created this revision.
shubham added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REPOSITORY
R241 KIO
BRANCH
todo
REVISION DETAIL
https://phabricator.kde.org/D20639
AFFECTED
shubham added a comment.
@dfaure Intention was just to fix the TODO
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20625
To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:acc6b9b71b51: Truncate trailing forward slashes(/)
(authored by shubham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20625?vs=56437=56447
REVISION DETAIL
https
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20625
To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
shubham updated this revision to Diff 56437.
shubham marked an inline comment as done.
shubham added a comment.
Correcty chop trailing slash
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20625?vs=56416=56437
BRANCH
arcpatch-D20625
REVISION DETAIL
https
shubham created this revision.
shubham added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REPOSITORY
R241 KIO
BRANCH
cleanup
REVISION DETAIL
https://phabricator.kde.org/D20626
AFFECTED
shubham added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D20625
To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
shubham created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REPOSITORY
R241 KIO
BRANCH
trailing
REVISION DETAIL
https://phabricator.kde.org/D20625
AFFECTED FILES
src/core/kmountpoint.cpp
shubham added a comment.
@ngraham Are you still working on this?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18384
To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
shubham added a comment.
@ngraham Are you working on it?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18563
To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure,
elvisangelaccio
shubham added a comment.
@ngraham Any updates?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18563
To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure,
elvisangelaccio, pino, kde
shubham added a comment.
@ngraham Any updates?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18384
To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:b9a52834ec45: Refactor
KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e) (authored by shubham).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18788?vs
shubham added a comment.
Can someone experienced review this?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17632
To: dfaure, shubham, broulik, bruns, chinmoyr
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns
shubham added a comment.
Is it okay now?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D18788
To: shubham, cullmann
Cc: dhaumann, sars, kwrite-devel, kde-frameworks-devel, michaelh, ngraham,
bruns, demsking, cullmann
shubham updated this revision to Diff 51102.
shubham added a comment.
Accept and ignore the event
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18788?vs=51039=51102
BRANCH
arcpatch-D18788
REVISION DETAIL
https://phabricator.kde.org/D18788
shubham added inline comments.
INLINE COMMENTS
> sars wrote in kateviewinternal.cpp:2718
> Where did e->accept() / e->ignore() go? There is a reason they are there...
Btw no need to explicitly accept() the event, because isAccepted() function
returns true by default. But surely,
shubham added a comment.
@dhaumann I don't think using switch when there is only a single case good
thought
INLINE COMMENTS
> sars wrote in kateviewinternal.cpp:2702
> does this even compile on OSX? Why did you change this?
I can't tell, I don't have one. Btw Q_OS_OSX is depr
shubham created this revision.
shubham added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
shubham requested review of this revision.
REVISION SUMMARY
Removed unncessary switch and replaced it with simple if, more
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8657a239a28d: Add icon name to service providers in
.desktop file (authored by shubham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18761?vs=50953=50969
REVISION
shubham added a reviewer: Frameworks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18761
To: shubham, broulik, ngraham, #vdg, #okular, #frameworks
Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes,
alexde, IohannesPetros, GB_2, rooty
shubham added a comment.
In the rest of service providers, very few have any icon specified, and most
don't have.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18761
To: shubham, broulik, ngraham, #vdg, #okular
Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh
shubham abandoned this revision.
shubham added a comment.
Abandoned in favour of D18761 <https://phabricator.kde.org/D18761>
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D18730
To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular
1 - 100 of 385 matches
Mail list logo
