D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-02 Thread Shubham
shubham updated this revision to Diff 44712. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=44710=44712 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-02 Thread Shubham
shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB) " to "Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB) ". R

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-11-02 Thread Shubham
shubham updated this revision to Diff 44710. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=44688=44710 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-11-01 Thread Shubham
shubham updated this revision to Diff 44688. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=43938=44688 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-31 Thread Shubham
shubham added a comment. Can I get a review? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-19 Thread Shubham
shubham added a comment. @bruns Apart from these, does the code seems sane to you? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-19 Thread Shubham
shubham updated this revision to Diff 43938. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=43930=43938 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-19 Thread Shubham
shubham added a comment. @ngraham No, please recheck, the check is before the first m_totalSize > m_freeSpace check REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns, kde-frameworks-devel, micha

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-19 Thread Shubham
shubham updated this revision to Diff 43930. shubham marked 5 inline comments as done. shubham added a comment. File size limit check for a given file system before (m_totalSize > m_freeSpace) check REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-19 Thread Shubham
shubham added inline comments. INLINE COMMENTS > ngraham wrote in job_error.cpp:253 > Unrelated and incorrect change: `https` is correct here, so please revert. That was my previous commit where I changed http -> https. Don't know why it affected my local branch. REPOSITORY

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-18 Thread Shubham
shubham updated this revision to Diff 43895. shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system" to "Warn user before copy/move job if the file size exceeds the maximum poss

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system

2018-10-18 Thread Shubham
shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system

2018-10-18 Thread Shubham
shubham updated this revision to Diff 43894. shubham added a comment. Cache file system time instead of creating it every time REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=43890=43894 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system

2018-10-18 Thread Shubham
shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system

2018-10-18 Thread Shubham
shubham updated this revision to Diff 43890. shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System" to "Warn user before copy/move job if the file size exceeds the maximum possible file size(

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System

2018-10-18 Thread Shubham
shubham added a comment. Is there any predefined function which returns the file size limit for a given file system? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size of in a File System

2018-10-16 Thread Shubham
shubham retitled this revision from "Warn user before copy/move job if required space exceeds the maximum volume size of a File System" to "Warn user before copy/move job if the file size exceeds the maximum possible file size of in a File System". REPOSITORY R241

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System

2018-10-16 Thread Shubham
shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size of in a File System" to "Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System". REPOSITORY R241

D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

2018-10-16 Thread Shubham
shubham added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

2018-10-16 Thread Shubham
shubham added a reviewer: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

2018-10-16 Thread Shubham
shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if required space exceeds the maximum volume size of a File System

2018-10-16 Thread Shubham
shubham created this revision. shubham added a reviewer: ngraham. shubham added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. shubham requested review of this revision. REVISION SUMMARY BUG: 198772 TEST PLAN 1.Prepare copy/move job

D16141: Disable unmount option for / or /home

2018-10-11 Thread Shubham
shubham added inline comments. INLINE COMMENTS > kfileplacesview.cpp:33 > +#include > > #include Move this header up > kfileplacesview.cpp:54 > +#include > > #include "kfileplaceeditdialog_p.h" Move the header up, to its appropriate position l

D14449: Modify device usage information

2018-10-03 Thread Shubham
shubham added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: ngraham, pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, bruns

D14449: Modify device usage information

2018-10-03 Thread Shubham
shubham added a comment. won't the pie chart representation look good, as we have in windows? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15645: [WIP] Add scheme selection menu with a "System" entry.

2018-09-22 Thread Shubham
shubham added inline comments. INLINE COMMENTS > kcolorschememanager.cpp:39 > > +KActionMenu* KColorSchemeManagerPrivate::createSchemeMenu(const QIcon , > const QString , const QString , bool defaultEntry, > QObject *parent) > +{ KActionMenu* -> KActionMenu

D15557: Improve "insufficient disk space" error messgae

2018-09-17 Thread Shubham
shubham added a comment. Maybe "Dont have enough space available on the disk" REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin,

D14757: Warn user before copy/move operation if available space is not enough

2018-09-16 Thread Shubham
shubham added a comment. Sorry for that, will take care of that in future. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

2018-09-16 Thread Shubham
shubham added a comment. @ngraham I thought those "request changes" were against my prior diffs REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

2018-09-16 Thread Shubham
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:5a48bd21212c: Warn user before copy/move operation if available space is not enough (authored by shubham).

D15557: Improve "insufficient disk space" error messgae

2018-09-16 Thread Shubham
shubham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH improve-insufficient-disk-space-error-message (branched from master) REVISION DETAIL https://phabricator.kde.org/D15557 To: ngraham, #frameworks, #vdg, #dolphin, shubham Cc: kde

D14757: Warn user before copy/move operation if available space is not enough

2018-09-16 Thread Shubham
shubham updated this revision to Diff 41765. shubham added a comment. addressed broulik's comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41764=41765 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp

D14757: Warn user before copy/move operation if available space is not enough

2018-09-16 Thread Shubham
shubham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

2018-09-16 Thread Shubham
shubham updated this revision to Diff 41764. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41761=41764 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham

D14757: Warn user before copy/move operation if available space is not enough

2018-09-16 Thread Shubham
shubham updated this revision to Diff 41761. shubham added a comment. done above requested change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41751=41761 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp

D14757: Warn user before copy/move operation if available space is not enough

2018-09-16 Thread Shubham
shubham updated this revision to Diff 41751. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41747=41751 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham

D14757: Warn user before copy/move operation if available space is not enough

2018-09-16 Thread Shubham
shubham updated this revision to Diff 41747. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41746=41747 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure

D14757: Warn user before copy/move operation if available space is not enough

2018-09-16 Thread Shubham
shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

2018-09-16 Thread Shubham
shubham marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D14757: Warn user before copy/move operation if available space is not enough

2018-09-16 Thread Shubham
shubham updated this revision to Diff 41746. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=41655=41746 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/copyjob.cpp To: shubham, pino, dfaure, broulik Cc: ngraham, dfaure

D14757: Warn user before copy/move operation if available space is not enough

2018-09-14 Thread Shubham
shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy/move operation if available space is not enough

2018-09-14 Thread Shubham
shubham marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy/move operation if available space is not enough

2018-09-14 Thread Shubham
shubham retitled this revision from "Warn user before copy operation if available space is not enough" to "Warn user before copy/move operation if available space is not enough". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino

D14757: Warn user before copy operation if available space is not enough

2018-09-14 Thread Shubham
shubham updated this revision to Diff 41655. shubham edited reviewers, added: broulik; removed: cfeck. shubham added a comment. Done above requested changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=39531=41655 REVISION DETAIL https

D14757: Warn user before copy operation if available space is not enough

2018-09-02 Thread Shubham
shubham added inline comments. INLINE COMMENTS > pino wrote in copyjob.cpp:891 > Uninitialized pointer, this will crash two lines later... > Also, this is the base class of the private class used for this job, and this > function is part of that class already; so why aren't you j

D14757: Warn user before copy operation if available space is not enough

2018-09-02 Thread Shubham
shubham added a comment. @dfaure @pino help? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, cfeck Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D15127: Fix typos for "Show line count"

2018-08-28 Thread Shubham
This revision was automatically updated to reflect the committed changes. Closed by commit R39:4c43ab238ec2: Fix typos for Show line count (authored by shubham). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15127?vs=40564=40575 REVISION DETAIL https

D15127: Fix typos for "Show line count"

2018-08-28 Thread Shubham
shubham added a comment. Going to land this now REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15127 To: shubham, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D15127: Fix typos for "Show line count"

2018-08-28 Thread Shubham
shubham updated this revision to Diff 40564. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15127?vs=40563=40564 REVISION DETAIL https://phabricator.kde.org/D15127 AFFECTED FILES src/dialogs/katedialogs.cpp src/dialogs

D15127: Fix typos for "Show line count"

2018-08-28 Thread Shubham
shubham edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15127 To: shubham, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D15127: Fix typos for "Show line count"

2018-08-28 Thread Shubham
shubham created this revision. shubham added reviewers: cullmann, vkrause. shubham added projects: KTextEditor, Frameworks. Herald added a project: Kate. Herald added subscribers: kde-frameworks-devel, kwrite-devel. shubham requested review of this revision. REPOSITORY R39 KTextEditor REVISION

D15000: Display mounted file system type and mounted from fields in properties dialog

2018-08-26 Thread Shubham
This revision was automatically updated to reflect the committed changes. Closed by commit R241:9e706796b152: Display mounted file system type and mounted from fields in properties dialog (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000

D15000: Display mounted file system type and mounted from fields in properties dialog

2018-08-26 Thread Shubham
shubham added a comment. @cfeck @broulik any comments on this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik, ngraham, #frameworks, cfeck Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D14449: Modify device usage information

2018-08-25 Thread Shubham
shubham added a comment. You plz proceed on it. Right now working on some other patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Modify device usage information

2018-08-25 Thread Shubham
shubham added a comment. In D14449#315524 <https://phabricator.kde.org/D14449#315524>, @ngraham wrote: > Do you plan to submit a new version of this after the layout has been converted to use `QFormLayout`? I do hope some form of this patch makes it in, since IMHO it's a ni

D15000: Display mounted file system type and mounted from fields in properties dialog

2018-08-25 Thread Shubham
shubham added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik, ngraham Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type and mounted from fields in properties dialog

2018-08-24 Thread Shubham
shubham retitled this revision from "Display mounted file system type in properties dialog" to "Display mounted file system type and mounted from fields in properties dialog". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure,

D15000: Display mounted file system type in properties dialog

2018-08-24 Thread Shubham
shubham added a comment. Move Mounted from into conditional. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik, ngraham Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type in properties dialog

2018-08-24 Thread Shubham
shubham updated this revision to Diff 40397. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40312=40397 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik, ngraham Cc

D15000: Display mounted file system type in properties dialog

2018-08-23 Thread Shubham
shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type in properties dialog

2018-08-23 Thread Shubham
shubham updated this revision to Diff 40312. shubham added a comment. Add mounted from label REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40236=40312 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets

D15000: Display mounted file system type in properties dialog

2018-08-23 Thread Shubham
shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type in properties dialog

2018-08-23 Thread Shubham
shubham added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15000: Display mounted file system type in properties dialog

2018-08-22 Thread Shubham
shubham updated this revision to Diff 40236. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40233=40236 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik Cc: broulik

D15000: Display mounted file system type in properties dialog

2018-08-22 Thread Shubham
shubham added a comment. 1. use KMountPoint::mountPoint() 2. Move everything into isLocal REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15000: Display mounted file system type in properties dialog

2018-08-22 Thread Shubham
shubham updated this revision to Diff 40233. shubham edited the summary of this revision. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40219=40233 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp

D15000: Display mounted file system type in properties dialog

2018-08-22 Thread Shubham
shubham edited the summary of this revision. shubham added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15000: Display mounted file system type in properties dialog

2018-08-22 Thread Shubham
shubham removed a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15000: Display mounted file system type in properties dialog

2018-08-22 Thread Shubham
shubham updated this revision to Diff 40219. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40217=40219 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik Cc: kde

D15000: Display mounted file system type in properties dialog

2018-08-22 Thread Shubham
shubham added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15000: Display mounted file system type in properties dialog

2018-08-22 Thread Shubham
shubham created this revision. shubham added a reviewer: dfaure. shubham added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY F6209381: Screenshot_20180822_173758.png <https://phabricator.kde.org/F6209

D14757: Warn user before copy operation if available space is not enough

2018-08-18 Thread Shubham
shubham added inline comments. INLINE COMMENTS > pino wrote in copyjob.cpp:909 > The return value is `JobUiDelegateExtension::MessageBoxType`, not > `KMessageBox::ButtonCode`. There is no enum for Button Code inside JobUiDelegatextension. So how to take that into consideration? R

D14449: Modify device usage information

2018-08-17 Thread Shubham
shubham abandoned this revision. shubham added a comment. Actually should be implemented using form layout REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham

D14757: Warn user before copy operation if available space is not enough

2018-08-15 Thread Shubham
shubham added a reviewer: cfeck. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, cfeck Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy operation if available space is not enough

2018-08-13 Thread Shubham
shubham added a comment. A question requestMessageBox( ) is a "pure virtual" function inside "jobUiDelegateExtension" class which is implemented in "jobUiDelegate" class which is the derived class of "jobUiDelegateExtension". When I res

D14757: Warn user before copy operation if available space is not enough

2018-08-12 Thread Shubham
shubham edited reviewers, added: dfaure; removed: broulik, ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14757: Warn user before copy operation if available space is not enough

2018-08-12 Thread Shubham
shubham updated this revision to Diff 39531. shubham added a comment. use simpleJobPrivate REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14757?vs=39492=39531 REVISION DETAIL https://phabricator.kde.org/D14757 AFFECTED FILES src/core/CMakeLists.txt src

D14757: Warn user before copy operation if available space is not enough

2018-08-12 Thread Shubham
shubham added a comment. @dfaure is it that message boxes cant be used in non gui library as suggested by pino. Is there any harm in using kmessagebox instead? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, broulik, ngraham, pino Cc: dfaure, pino

D14757: Warn user before copy operation if available space is not enough

2018-08-12 Thread Shubham
shubham added a comment. In D14757#306938 <https://phabricator.kde.org/D14757#306938>, @pino wrote: > Also, considering this is in a job in `KIOCore` (i.e. non-gui library), I suspect that using a message box directly is the wrong way to do it. @dfaure what is you

D14757: Warn user before copy operation if available space is not enough

2018-08-12 Thread Shubham
shubham added a comment. In D14757#306938 <https://phabricator.kde.org/D14757#306938>, @pino wrote: > Also, considering this is in a job in `KIOCore` (i.e. non-gui library), I suspect that using a message box directly is the wrong way to do it. Most probably you need to u

D14757: Warn user before copy operation if available space is not enough

2018-08-12 Thread Shubham
shubham created this revision. shubham added reviewers: broulik, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL https

D14648: Make read-only filenames selectable

2018-08-06 Thread Shubham
shubham accepted this revision. shubham added a comment. This revision is now accepted and ready to land. Oh, forgot to do that in R241:e2c56f6ddc517bc4915ab3c84971d17054225c76 <https://phabricator.kde.org/R241:e2c56f6ddc517bc4915ab3c84971d17054225c76>. REPOSITORY R241 KIO

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

2018-08-06 Thread Shubham
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e2c56f6ddc51: Use KLineEdit for folder name if folder has write access, else use QLabel (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14610?vs

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

2018-08-06 Thread Shubham
shubham updated this revision to Diff 39164. shubham added a comment. Add check for bFromTemplate simplify expression (!d->m_bFromTemplate && !itemList.supportsMoving()) to !(d->m_bFromTemplate || itemList.supportsMoving()) for better readability REPOSITORY R241 KIO CHAN

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

2018-08-05 Thread Shubham
shubham updated this revision to Diff 39163. shubham added a comment. Re factor Remove unnecessary indentations use only !itemList.supportsMoving() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14610?vs=39112=39163 REVISION DETAIL https

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

2018-08-05 Thread Shubham
shubham added a comment. In D14610#303706 <https://phabricator.kde.org/D14610#303706>, @rkflx wrote: > In D14610#303537 <https://phabricator.kde.org/D14610#303537>, @rkflx wrote: > > > `KPropertiesDialog::setFileNameReadOnly` > > `m_bFromTemplate` &

D14449: Modify device usage information

2018-08-05 Thread Shubham
shubham added a comment. In D14449#300327 <https://phabricator.kde.org/D14449#300327>, @ngraham wrote: > +1 for using the same label but putting the information on more than one line like @rkflx suggests. sorry for causing trouble : ( REPOSITORY R241 KIO REVISI

D14449: Modify device usage information

2018-08-05 Thread Shubham
shubham added a comment. In D14449#303710 <https://phabricator.kde.org/D14449#303710>, @rkflx wrote: > - The vertical spacing between the first and the second line is too big, it should be the same as for Size:. is there any other simpler way to achieve this? INLINE

D14449: Modify device usage information

2018-08-05 Thread Shubham
shubham edited reviewers, added: rkflx; removed: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx, elvisangelaccio Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D14449: Modify device usage information

2018-08-05 Thread Shubham
shubham updated this revision to Diff 39120. shubham added a comment. F6176187: 2.png <https://phabricator.kde.org/F6176187> @rkflx is this okay now? REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14449?vs=38784=39120 REVISION DETAIL

D14449: Modify device usage information

2018-08-05 Thread Shubham
shubham added a comment. > Not if you set a maximum width. @rkflx eeh, skipped from my mind btw , then it is doable REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, elvisangelaccio, ngraham, #frameworks Cc: rkflx, dhaumann, kde-frameworks-de

D14449: Modify device usage information

2018-08-05 Thread Shubham
shubham added a comment. > Let me plug my suggestion again: > > Device capacity: ==- 24% used of 94.4 Gib >22.5 GiB used, 71.9 GiB free > if this design is used , then the capacity bar would look elongated and stretched, which doe

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

2018-08-05 Thread Shubham
shubham updated this revision to Diff 39112. shubham added a comment. Re-use Qlabel REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14610?vs=39082=39112 REVISION DETAIL https://phabricator.kde.org/D14610 AFFECTED FILES src/widgets/kpropertiesdialog.cpp

D14609: Do not return reference

2018-08-04 Thread Shubham
This revision was automatically updated to reflect the committed changes. Closed by commit R241:65f56f12aa7f: Do not return reference (authored by shubham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14609?vs=39097=39099 REVISION DETAIL https

D14609: Do not return reference

2018-08-04 Thread Shubham
shubham added a comment. using arc land --rev id, arc gives error saying Audit Failure : Non full name REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14609 To: shubham, ngraham, cfeck, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14609: Do not return reference

2018-08-04 Thread Shubham
shubham added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14609 To: shubham, ngraham, cfeck, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14609: Do not return reference

2018-08-04 Thread Shubham
shubham updated this revision to Diff 39097. shubham added a comment. Remove **cons**t REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14609?vs=39078=39097 REVISION DETAIL https://phabricator.kde.org/D14609 AFFECTED FILES src/filewidgets

D14610: Use KLineEdit if folder has write access, else use QLabel

2018-08-04 Thread Shubham
shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14610 To: shubham, rkflx, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14610: Use KLineEdit for folder name if folder has write access, else use QLabel

2018-08-04 Thread Shubham
shubham retitled this revision from "Use KLineEdit if folder has write access, else use QLabel" to "Use KLineEdit for folder name if folder has write access, else use QLabel". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14610 To: shubham, rkflx

D14610: Use KLineEdit if folder has write access, else use QLabel

2018-08-04 Thread Shubham
shubham updated this revision to Diff 39082. shubham retitled this revision from "Make KLineEdit read only if write access is denied" to "Use KLineEdit if folder has write access, else use QLabel". shubham edited the summary of this revision. shubham edited the test pl

<    1   2   3   4   >